Re: [libvirt] [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-14 Thread John Snow
On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: > To get rid of implicit filters related workarounds in future let's > deprecate them now. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qemu-deprecated.texi | 7 +++ > qapi/block-core.json | 6 -- >

Re: [libvirt] [Qemu-devel] [PATCH 1/2] qapi: deprecate drive-mirror and drive-backup

2019-08-14 Thread John Snow
On 8/14/19 6:07 AM, Vladimir Sementsov-Ogievskiy wrote: > It's hard and not necessary to maintain outdated versions of these > commands. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qemu-deprecated.texi | 4 > qapi/block-core.json | 4 > qapi/transaction.json | 2 +-

[libvirt] [PATCH 6/6] qemu: Don't report some ignored errors in qemuDomainGetStatsOneBlockFallback

2019-08-14 Thread Peter Krempa
The function ignores all errors from qemuStorageLimitsRefresh by calling virResetLastError. This still logs them. Since qemuStorageLimitsRefresh allows suppressing some, do so. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[libvirt] [PATCH 3/6] util: storagefile: Don't report errors from virStorageSourceUpdatePhysicalSize

2019-08-14 Thread Peter Krempa
virStorageSourceUpdatePhysicalSize is called only from qemuDomainStorageUpdatePhysical and all callers of it reset the libvirt error if -1 is returned. Don't bother setting the error in the first place. Signed-off-by: Peter Krempa --- src/util/virstoragefile.c | 12 ++-- 1 file

[libvirt] [PATCH 5/6] qemu: Allow suppressing errors from qemuStorageLimitsRefresh

2019-08-14 Thread Peter Krempa
qemuStorageLimitsRefresh uses qemuDomainStorageOpenStat internally and there are callers which don't care about the error. Propagate the skipInaccessible flag so that we can log less errors. Callers currently don't care about the return value change. Signed-off-by: Peter Krempa ---

[libvirt] [PATCH 4/6] qemu: driver: Improve error suppression in qemuDomainStorageUpdatePhysical

2019-08-14 Thread Peter Krempa
None of the callers of qemuDomainStorageUpdatePhysical care about errors. Use the new flag for qemuDomainStorageOpenStat which suppresses some errors and move the reset of the rest of the uncommon errors into this function. Document what is happening in a comment for the function. Signed-off-by:

[libvirt] [PATCH 2/6] qemu: Allow skipping some errors in qemuDomainStorageOpenStat

2019-08-14 Thread Peter Krempa
Some callers of this function actually don't care about errors and reset it. The message is still logged which might irritate users in this case. Add a boolean flag which will do few checks whether it actually makes sense to even try opening the storage file. For local files we check whether it

[libvirt] [PATCH 0/6] qemu: Allow suppressing some errors in qemu bulk stats code

2019-08-14 Thread Peter Krempa
There is an bugreport [1] that some Openstack deployments get periodic errors in the log. This is most probably from the bulk stats code which in some cases calls into the storage backends to update some aspects of storage volumes. Since none of the errors are fatal add code to allow skipping

[libvirt] [PATCH 1/6] util: Export virStorageFileSupportsBackingChainTraversal

2019-08-14 Thread Peter Krempa
The function will be reused in the qemu snapshot code. The argument is turned into const similarly to the other virStorageFileSupports* functions. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 + src/util/virstoragefile.c | 4 ++-- src/util/virstoragefile.h | 1 + 3 files

[libvirt] [PATCH v2 6/6] test_driver: implement virDomainUpdateDeviceFlags

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 72 ++ 1 file changed, 72 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index e271bc58f8..9bf3728654 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 5/6] test_driver: implement virDomainDetachDeviceAlias

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 12 1 file changed, 12 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 1152ca5bed..e271bc58f8 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -5119,6 +5119,17 @@

[libvirt] [PATCH v2 4/6] test_driver: implement virDomainDetachDevice

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 8 1 file changed, 8 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ff9693ccb7..1152ca5bed 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -5119,6 +5119,13 @@

[libvirt] [PATCH v2 3/6] test_driver: implement virDomainDetachDeviceFlags

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 178 + 1 file changed, 178 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index abf80b97cf..ff9693ccb7 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 2/6] test_driver: implement virDomainAttachDevice

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5f28e9017f..abf80b97cf 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -4935,6 +4935,14 @@

[libvirt] [PATCH v2 1/6] test_driver: implement virDomainAttachDeviceFlags

2019-08-14 Thread Ilias Stamatis
Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 290 + 1 file changed, 290 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index c39eef2d4b..5f28e9017f 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c

[libvirt] [PATCH v2 0/6] test_driver: implement device attach/detach APIs

2019-08-14 Thread Ilias Stamatis
This series needed a respin since there were conflicts when trying to apply on the current master. Ilias Stamatis (6): test_driver: implement virDomainAttachDeviceFlags test_driver: implement virDomainAttachDevice test_driver: implement virDomainDetachDeviceFlags test_driver: implement

Re: [libvirt] [PATCH] util: storage: Fix parsing of 'exportname' from legacy NBD strings

2019-08-14 Thread Peter Krempa
On Wed, Jul 31, 2019 at 17:22:48 +0200, Peter Krempa wrote: > If the nbd export name contains a colon, our parser would not parse it > properly as we split the string by colons. Modify the code to look up > the exportname and copy any trailing characters as the export name is > supposed to be at

Re: [libvirt] [PATCH 15/18] virhostdev: Unify virHostdevPreparePCIDevices behaviour for KVM and VFIO cases

2019-08-14 Thread Daniel Henrique Barboza
Michal, I believe the problem you're trying to fix in this patch is somehow the same I'm trying to fix in this patch here: https://www.redhat.com/archives/libvir-list/2019-June/msg01270.html Do you mind taking a look? If that's the case, I can drop that patch from the series that implements

Re: [libvirt] [PATCH v2 1/2] test_driver: handle different lifecycle actions in testDomainShutdownFlags

2019-08-14 Thread Erik Skultety
On Tue, Aug 13, 2019 at 03:28:09PM +0300, Ilias Stamatis wrote: > Signed-off-by: Ilias Stamatis I'll rephrase the commit subject to: Introduce testDomainActionSetState helper Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 0/2] test_driver: implement virDomainSetLifecycleAction

2019-08-14 Thread Erik Skultety
On Tue, Aug 13, 2019 at 03:28:08PM +0300, Ilias Stamatis wrote: > Ilias Stamatis (2): > test_driver: handle different lifecycle actions in > testDomainShutdownFlags > test_driver: implement virDomainSetLifecycleAction > > src/test/test_driver.c | 135

Re: [libvirt] [PATCH v2 1/2] test_driver: handle different lifecycle actions in testDomainShutdownFlags

2019-08-14 Thread Erik Skultety
On Tue, Aug 13, 2019 at 03:34:02PM +0300, Ilias Stamatis wrote: > On Tue, Aug 13, 2019 at 3:28 PM Ilias Stamatis > wrote: > > > > Signed-off-by: Ilias Stamatis > > --- > > src/test/test_driver.c | 77 -- > > 1 file changed, 45 insertions(+), 32

Re: [libvirt] [PATCH 00/18] Enhance virpcimock and test VFIO instead of KVM

2019-08-14 Thread Daniel Henrique Barboza
I've run make check with each individual patch, and everything seems fine in my environment. For all patches: Tested-by: Daniel Henrique Barboza I'll see if I can drop some code reviews later on. Thanks, DHB On 8/14/19 8:57 AM, Michal Privoznik wrote: Kernel structure looks slightly

[libvirt] [PATCH v3 1/2] qemu: formatting XML from domain def choosing the root name

2019-08-14 Thread Maxiwell S. Garcia
The function virDomainDefFormatInternal() has the predefined root name "domain" to format the XML. But to save both active and inactive domain in the snapshot XML, the new root name "inactiveDomain" was created. So, this function was modified to be driven by the new flag

[libvirt] [PATCH v3 0/2] snapshot: Store both config and live XML in the snapshot domain

2019-08-14 Thread Maxiwell S. Garcia
This patchset store both config and live XML in the snapshot XML. To avoid nest 'config' XML one level deeper ('inactive/domain'), it was necessary change the virDomainDefFormatInternal() to use 'domain' or 'inactiveDomain' in the root node. Maxiwell S. Garcia (2): qemu: formatting XML from

[libvirt] [PATCH v3 2/2] snapshot: Store both config and live XML in the snapshot domain

2019-08-14 Thread Maxiwell S. Garcia
The snapshot-create operation of running guests saves the live XML and uses it to replace the active and inactive domain in case of revert. So, the config XML is ignored by the snapshot process. This commit changes it and adds the config XML in the snapshot XML as the entry. In case of offline

[libvirt] [PATCH 5/5] security_util: Remove stale XATTRs

2019-08-14 Thread Michal Privoznik
It may happen that we leave some XATTRs behind. For instance, on a sudden power loss, the host just shuts down without calling restore on domain paths. This creates a problem, because when the host starts up again, the XATTRs are there but they don't reflect the true state and this may result in

[libvirt] [PATCH 4/5] util: Introduce virhostuptime

2019-08-14 Thread Michal Privoznik
This module contains function to get host boot time. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 4 +++ src/util/Makefile.inc.am | 2 ++ src/util/virhostuptime.c | 61 src/util/virhostuptime.h | 27 ++ 4 files

[libvirt] [PATCH 2/5] security_util: Use more VIR_AUTOFREE()

2019-08-14 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/security/security_util.c | 78 +++- 1 file changed, 32 insertions(+), 46 deletions(-) diff --git a/src/security/security_util.c b/src/security/security_util.c index 9d3f483f6b..04347f51e5 100644 ---

[libvirt] [PATCH 1/5] virUUIDFormat: s/VIR_UUID_RAW_LEN/VIR_UUID_BUFLEN/ in comment

2019-08-14 Thread Michal Privoznik
The function takes raw UUID and formats it into string representation. However, the comment mistakenly states that the expected size of raw UUID buffer is VIR_UUID_RAW_LEN bytes. We don't have such constant since v0.3.2~24. It should have been VIR_UUID_BUFLEN. Signed-off-by: Michal Privoznik ---

[libvirt] [PATCH 0/5] security: Deal with stale XATTRs

2019-08-14 Thread Michal Privoznik
There are some ways users can end up in stale XATTRs. One is sudden power loss, the other is stopping libvirt whilst some domains are running and then rebooting the host. And I believe users will find other creative ways to shut down domains without qemuProcessStop() being called. When that

[libvirt] [PATCH 3/5] security_util: Document virSecurityMoveRememberedLabel

2019-08-14 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- src/security/security_util.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/security/security_util.c b/src/security/security_util.c index 04347f51e5..365b2dd2d6 100644 --- a/src/security/security_util.c +++

Re: [libvirt] [PATCH] util: mdev: support persistent devices with mdevctl

2019-08-14 Thread Boris Fiuczynski
On 8/14/19 12:02 AM, Jonathon Jongsma wrote: When a host is rebooted, mediated devices disappear from sysfs. mdevctl (https://github.com/mdevctl/mdevctl) is a utility for managing and persisting these devices. It maintains a registry of mediated devices and can start and stop them by UUID.

[libvirt] 5.6.0 regression: "Some activation file descriptors are unclaimed"

2019-08-14 Thread Allen, John
After upgrading to v5.6.0, starting libvirtd fails with the following message in journalctl -xe: libvirtd[186338]: internal error: Some activation file descriptors are unclaimed 5b8569dd6e284b9159c701e8bffafb196983fc4a introduces the message. The commit message indicates that systemd version 227

[libvirt] [PATCH] remote_daemon_dispatch.c: typecast ARRAY_CARDINALITY() in remoteDispatchProbeURI()

2019-08-14 Thread Michal Privoznik
Since users can enable/disable drivers at compile time, it may happen that @drivers array is in fact empty (in both its occurrences within the function). This means that ARRAY_CARDINALITY() returns 0UL which makes gcc unhappy because of loop condition: i < ARRAY_CARDINALITY(drivers) GCC

[libvirt] [PATCH] src: Don't check lxc_monitor_protocol-struct when LXC is disabled

2019-08-14 Thread Michal Privoznik
If LXC is disabled at build time then there is no libvirt_driver_lxc_impl_la-*.lo to run the 'check-protocol' against. Signed-off-by: Michal Privoznik --- src/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Makefile.am b/src/Makefile.am index 3ae4b87abb..817a7ecf34 100644

Re: [libvirt] [PATCH 0/3] virNetDaemonCallInhibit: check for logind availability

2019-08-14 Thread Michal Privoznik
On 8/13/19 5:08 PM, Ján Tomko wrote: * get rid of a pointless error logged when system D-Bus is not available * do not send messages on systems without logind * remove four extra dbus calls on libvirtd startup when checking for logind availability Ján Tomko (3): util: introduce

Re: [libvirt] [PATCH 0/5] util: open pci config read-only for querying

2019-08-14 Thread Michal Privoznik
On 8/13/19 3:45 PM, Ján Tomko wrote: A bunch of functions opened the PCI device config as read-write even though they only read from it. Ján Tomko (5): util: introduce virPCIDeviceConfigOpenInternal util: Introduce virPCIDeviceConfigOpenWrite util: introduce readonly attribute to

[libvirt] [PATCH 13/18] virpcimock: Create symlink in /sys/kernel/iommu_groups/N/devices dir

2019-08-14 Thread Michal Privoznik
So far, we don't need to create anything under /sys/kernel/iommu_groups/N/devices directory (which is symlinked from /sys/bus/pci/devices/:BB:DD.F/iommu_group directory) because virhostdevtest still tests the old KVM assignment and thus has no notion of IOMMU groups. This will change in near

[libvirt] [PATCH 18/18] virpcitest: Use modern VFIO

2019-08-14 Thread Michal Privoznik
The pci-stub is so old school that no one uses it. All modern systems have adapted VFIO. Switch our virpcitest too. Signed-off-by: Michal Privoznik --- tests/virpcitest.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/virpcitest.c b/tests/virpcitest.c

[libvirt] [PATCH 16/18] qemuxml2argvtest: Switch to modern vfio backend

2019-08-14 Thread Michal Privoznik
The pci-assign device is so old school that no one uses it. All modern systems have adapted VFIO. Switch our xml2argv test too. Signed-off-by: Michal Privoznik --- .../hostdev-pci-address-device.args| 2 +- tests/qemuxml2argvdata/hostdev-pci-address.args| 2 +-

[libvirt] [PATCH 07/18] virpcimock: Rename @fakesysfspcidir

2019-08-14 Thread Michal Privoznik
We will need to create more directories and instead of introducing bunch of new variables to hold their actual paths, we can have one and reuse it. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[libvirt] [PATCH 02/18] Revert "virpcitest: Test virPCIDeviceDetach failure"

2019-08-14 Thread Michal Privoznik
This reverts commit b70c093ffa00cd87c8d39d3652b798f033a81faf. In next commit the virpcimock is going to be extended and thus binding a PCI device to vfio-pci driver will finally succeed. Remove this test as it will no longer make sense. Signed-off-by: Michal Privoznik --- tests/virpcitest.c |

[libvirt] [PATCH 14/18] virhostdev: Check driver name too in virHostdevIsPCINodeDeviceUsed()

2019-08-14 Thread Michal Privoznik
It may happen that there are two domains with the same name in two separate drivers (e.g. qemu and lxc). That is why for PCI devices we track both names of driver and domain combination which has taken the device. However, when we check if given PCI device is in use (or PCI devices from the same

[libvirt] [PATCH 05/18] virpcimock: Use VIR_AUTOFREE()

2019-08-14 Thread Michal Privoznik
It saves us couple of lines. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 109 +++-- 1 file changed, 36 insertions(+), 73 deletions(-) diff --git a/tests/virpcimock.c b/tests/virpcimock.c index 853ac588e9..0950f3ba00 100644 ---

[libvirt] [PATCH 17/18] virhostdevtest: Use modern VFIO

2019-08-14 Thread Michal Privoznik
The pci-stub is so old school that no one uses it. All modern systems have adapted VFIO. Switch our virhostdevtest too. Signed-off-by: Michal Privoznik --- tests/virhostdevtest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/virhostdevtest.c

[libvirt] [PATCH 11/18] virpcimock: Store PCI address as ints not string

2019-08-14 Thread Michal Privoznik
In upcoming patches we will need only some portions of the PCI address. To construct that easily, it's better if the PCI address of a device is stored as four integers rather than one string. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 76

[libvirt] [PATCH 10/18] virpcimock: Introduce and use pci_driver_get_path()

2019-08-14 Thread Michal Privoznik
Have just one function to generate path to a PCI driver so that when we change it in near future there's only few of the places we need to fix. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff

[libvirt] [PATCH 09/18] virpcimock: Introduce and use pci_device_get_path()

2019-08-14 Thread Michal Privoznik
Have just one function to generate path to a PCI device so that when we change it in near future there's only few of the places we need to fix. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 42 +++--- 1 file changed, 31 insertions(+), 11

[libvirt] [PATCH 08/18] virpcimock: Create devices/ and drivers/ under /sys/bus/pci upfront

2019-08-14 Thread Michal Privoznik
In near future, we will be creating devices under different location and just symlink them under devices/. Just like real kernel does. But for that we need the directories to exists. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 15 +++ 1 file changed, 15 insertions(+)

[libvirt] [PATCH 12/18] virpcimock: Create PCI devices under /sys/devices/pci*

2019-08-14 Thread Michal Privoznik
So far, we are creating devices directly under /sys/bus/pci/devices/*. There is not much problem with it, but if we really want to model kernel behaviour we need to create them under /sys/devices/pci:BB and then only symlink them from the old location. Signed-off-by: Michal Privoznik ---

[libvirt] [PATCH 04/18] virpcimock: Drop needless typecast

2019-08-14 Thread Michal Privoznik
When creating a PCI device, the pciDevice structure contains @id member which holds device address (.BB:DD.F) and is type of 'char *'. But the structure is initialized from a const char and in fact we never modify or free the @id. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 4

[libvirt] [PATCH 15/18] virhostdev: Unify virHostdevPreparePCIDevices behaviour for KVM and VFIO cases

2019-08-14 Thread Michal Privoznik
The virHostdevPreparePCIDevices() function works in several steps. In the very first one, it checks if devices we want to detach from the host are not taken already by some other domain. However, this piece of code returns different results depending on the stub driver used (which is not wrong per

[libvirt] [PATCH 06/18] virpcimock: Eliminate use of @fakesysfspcidir

2019-08-14 Thread Michal Privoznik
The @fakesysfspcidir is derived from @fakerootdir. We don't need two global variables that contain nearly the same content, especially when we construct the actual path anyways. Signed-off-by: Michal Privoznik --- tests/virpcimock.c | 41 - 1 file

[libvirt] [PATCH 00/18] Enhance virpcimock and test VFIO instead of KVM

2019-08-14 Thread Michal Privoznik
Kernel structure looks slightly different than what virpcimock creates. This did not use to be a problem, because we are testing KVM device assignment even though majority of systems we run on (if not all of them) use VFIO assignment. In order to switch our test suite (mainly virhostdevtest and

[libvirt] [PATCH 03/18] virpcimock: Create driver_override file in device dirs

2019-08-14 Thread Michal Privoznik
Newer kernels (v3.16-rc1~29^2~6^4) have 'driver_override' file which simplifies way of binding a PCI device to desired driver. Libvirt has support for this for some time too (v2.3.0-rc1~236), but not our virpcimock. So far we did not care because our code is designed to deal with this situation.

[libvirt] [PATCH 01/18] virpcimock: Move actions checking one level up

2019-08-14 Thread Michal Privoznik
The pci_driver_bind() and pci_driver_unbind() functions are "internal implementation", meaning other parts of the code should be able to call them and get the job done. Checking for actions (PCI_ACTION_BIND and PCI_ACTION_UNBIND) should be done in handlers (pci_driver_handle_bind() and

[libvirt] [PATCH 1/2] qapi: deprecate drive-mirror and drive-backup

2019-08-14 Thread Vladimir Sementsov-Ogievskiy
It's hard and not necessary to maintain outdated versions of these commands. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qemu-deprecated.texi | 4 qapi/block-core.json | 4 qapi/transaction.json | 2 +- blockdev.c| 10 ++ 4 files changed, 19 insertions(+),

[libvirt] [PATCH 0/2] Deprecate implicit filters

2019-08-14 Thread Vladimir Sementsov-Ogievskiy
Hi all! Max's series to fix some problems around filters consists of 42 patches. I'm sure that we didn't find all bugs around filters, and that filters would be a constant source of bugs in future, as during developing new feature nobody will consider all possible cases of dealing with filters

[libvirt] [PATCH 2/2] qapi: deprecate implicit filters

2019-08-14 Thread Vladimir Sementsov-Ogievskiy
To get rid of implicit filters related workarounds in future let's deprecate them now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qemu-deprecated.texi | 7 +++ qapi/block-core.json | 6 -- include/block/block_int.h | 10 +- blockdev.c| 10

Re: [libvirt] [PATCH 2/3] util: do not repeat the pm-is-supported string

2019-08-14 Thread Ján Tomko
On Wed, Aug 14, 2019 at 11:05:39AM +0200, Andrea Bolognani wrote: On Tue, 2019-08-13 at 17:24 +0200, Ján Tomko wrote: +++ b/src/util/virnodesuspend.c case VIR_NODE_SUSPEND_TARGET_HYBRID: -cmd = virCommandNewArgList("pm-is-supported", "--suspend-hybrid", NULL); +cmd =

Re: [libvirt] [PATCH 3/3] util: be quiet when pm-is-supported is unavailable

2019-08-14 Thread Andrea Bolognani
On Tue, 2019-08-13 at 17:24 +0200, Ján Tomko wrote: > Look up the binary name upfront to avoid the error: > Cannot find 'pm-is-supported' in path: No such file or directory > > In that case, we just assume nodesuspend is not available. > > Signed-off-by: Ján Tomko > --- >

Re: [libvirt] [PATCH 2/3] util: do not repeat the pm-is-supported string

2019-08-14 Thread Andrea Bolognani
On Tue, 2019-08-13 at 17:24 +0200, Ján Tomko wrote: > +++ b/src/util/virnodesuspend.c > case VIR_NODE_SUSPEND_TARGET_HYBRID: > -cmd = virCommandNewArgList("pm-is-supported", "--suspend-hybrid", > NULL); > +cmd = virCommandNewArgList(binary, "--suspend-hybrid", NULL); >

Re: [libvirt] [PATCH 1/3] util: use VIR_AUTOPTR virNodeSuspendSupportsTargetPMUtils

2019-08-14 Thread Andrea Bolognani
On Tue, 2019-08-13 at 17:24 +0200, Ján Tomko wrote: > +++ b/src/util/virnodesuspend.c > @@ -238,9 +238,8 @@ int virNodeSuspend(unsigned int target, > /* > * Check return code of command == 0 for success > * (i.e., the PM capability is supported) > */ > *supported = (status

Re: [libvirt] [PATCH] util: mdev: support persistent devices with mdevctl

2019-08-14 Thread Fabiano Fidêncio
On Wed, Aug 14, 2019 at 12:03 AM Jonathon Jongsma wrote: > > When a host is rebooted, mediated devices disappear from sysfs. mdevctl > (https://github.com/mdevctl/mdevctl) is a utility for managing and > persisting these devices. It maintains a registry of mediated devices > and can start and

Re: [libvirt] [PATCH 0/3] qemu: Allow migration with disk cache on

2019-08-14 Thread Peter Krempa
On Tue, Aug 13, 2019 at 18:08:35 +0200, Jiri Denemark wrote: > QEMU 4.0.0 and newer automatically drops caches at the end of migration, > which means we can safely allow migration even if disk/driver/@cache is > not none nor directsync. > > Jiri Denemark (3): > qemu: Clarify error message in