[libvirt] [PATCH v1 0/3] small code repetition purge on qemu_conf.c

Stumbled on this while changing qemu_conf.c for other reasons. Moved code around here and there to avoid repetition. Final result is 23 less lines for the same functionality, which is nothing to write home about but seems okay to contribute. Daniel Henrique Barboza (3): qemu_conf.c: introduce

[libvirt] [PATCH v1 2/3] qemu_conf.c: introduce qemuAddRemoveSharedDiskInternal

Following the same idea of avoid code repetition from the previous patch, this commit introduces a new function that aggregates the functions of qemuAddSharedDisk() and qemuRemoveSharedDisk() into a single place, using a flag to switch between add/remove operations. Both qemuAddSharedDisk() and

[libvirt] [PATCH v1 3/3] qemu_conf.c: introduce qemuAddRemoveSharedDeviceInternal

After the previous commits, qemuAddSharedDevice() and qemuRemoveSharedDevice() are now the same code with a different flag to call the internal functions. This patch aggregates the common code into a new function called qemuAddRemoveSharedDeviceInternal() to further reduce code repetition. Both

[libvirt] [PATCH v1 1/3] qemu_conf.c: introduce qemuAddRemoveSharedHostdevInternal

qemuAddSharedHostdev() has a code similar to qemuRemoveSharedHostdev(), with exception of one line that defines the operation (add or remove). This patch introduces a new function that aggregates the common code, using a flag to switch between the operations, avoiding code repetition. No

[libvirt] [PATCH] maint: Post-release version bump to 5.8.0

Signed-off-by: Jim Fehlig --- Pushed under trivial rule. Usually done by Michal but I need to push other changes to news for the 5.8.0 cycle. configure.ac | 2 +- docs/news.xml | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

[libvirt] [PATCH 0/3] Fix memlock limit during hotplug of mdev devices

The routine qemuDomainGetMemLockLimitBytes() has a couple tests to determine what the maximum limit of locked memory should be. If I start a domain without any vfio stuff, /proc/$PID/limits says the limit is 64KiB. If I start a guest with a vfio-ccw hostdev, the limit is now $GUEST_MEMORY + 1GiB.

[libvirt] [PATCH 3/3] qemu: Adjust max memlock on mdev hotplug

When starting a domain, we use the presence of a vfio-pci or mdev hostdev to determine if the memlock maximum needs to be increased. But if we hotplug either of these devices, only the vfio-pci path gets that love. This means that attaching a, say, vfio-ccw device will appear to succeed but the

[libvirt] [PATCH 2/3] qemu: Reset the maximum locked memory on hotplug fail

If attaching a PCI hostdev fails, there are several things that need to be un-done as part of the cleanup. One thing that is not done is re-calculating/re-setting the maximum amount of locked memory for the domain, since we may have changed that. Let's fix that, just to ensure everything is back

[libvirt] [PATCH 1/3] qemu: Refactor the max memlock routine

Let's pull this hunk out into a function, so it can be reused in another codepath that needs to do the same thing. Signed-off-by: Eric Farman --- src/qemu/qemu_domain.c | 30 ++ src/qemu/qemu_domain.h | 2 ++ src/qemu/qemu_hotplug.c | 11 +-- 3 files

Re: [libvirt] [PATCH 0/6] hostdev: handle usb detach/attach on node

Hi Nikolay, I was going to review these patches but first I followed up in the discussions at [1]. Daniel made a few points there: --- The problems around host USB device passthrough are conceptually similar to the problems of hots PCI device passthrough. In both cases we cannot assume the

Re: [libvirt] [PATCH v4 0/8] CPU Model Baseline and Comparison for s390x

On 8/20/19 10:06 AM, Jiri Denemark wrote: > First, let me apologize for such a late review. I'll try my best to > review your series earlier next time. > Your review is greatly appreciated! I haven't replied to your other posts on this series as my comments were mostly acknowledgements rather

Re: [libvirt] [Qemu-block] [PATCH] docs: Update preferred NBD device syntax

On 9/3/19 3:02 PM, Eric Blake wrote: > [adding libvirt list] > > On 9/3/19 1:50 PM, John Snow wrote: >> >> >> On 9/3/19 10:56 AM, Eric Blake wrote: >>> Mention the preferred URI form, especially since NBD is trying to >>> standardize that form:

[libvirt] Release of libvirt 5.7.0

A few hours ago I tagged the release in git and pushed the signed tarball and source rpm to the usual place: https://libvirt.org/sources/ I also tagged a release of the python bindings which you can find at https://libvirt.org/sources/python/ This is a balanced release with new

Re: [libvirt] [Qemu-block] [PATCH] docs: Update preferred NBD device syntax

[adding libvirt list] On 9/3/19 1:50 PM, John Snow wrote: > > > On 9/3/19 10:56 AM, Eric Blake wrote: >> Mention the preferred URI form, especially since NBD is trying to >> standardize that form: https://lists.debian.org/nbd/2019/06/msg00012.html >> >> Signed-off-by: Eric Blake >> --- >>

Re: [libvirt] [PATCH] news: rewording wrt NSS, virt-login-shell & split daemons

On 9/3/19 11:12 AM, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- docs/news.xml | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) Reviewed-by: Laine Stump (but unfortunately too late to be in the release tarball :-/) -- libvir-list

Re: [libvirt] [PATCH] virsh: Fix help for net-port-delete

On 9/3/19 12:47 PM, Jonathon Jongsma wrote: Apparently a copy/paste error. The net-port-delete help string was in fact from net-port-dumpxml. Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1747826 Signed-off-by: Jonathon Jongsma --- tools/virsh-network.c | 4 ++-- 1 file changed, 2

Re: [libvirt] [PATCH 2/2] test_driver: implement virDomainPMWakeup

On 8/13/19 1:20 PM, Ilias Stamatis wrote: Signed-off-by: Ilias Stamatis --- (My virObjectEventStateQueue rant in patch 1/2 applies here as well) Reviewed-by: Daniel Henrique Barboza src/test/test_driver.c | 37 + 1 file changed, 37 insertions(+)

Re: [libvirt] [PATCH 1/2] test_driver: implement virDomainPMSuspendForDuration

On 9/3/19 2:00 PM, Daniel Henrique Barboza wrote: On 8/13/19 1:19 PM, Ilias Stamatis wrote: Signed-off-by: Ilias Stamatis ---   src/test/test_driver.c | 79 ++   1 file changed, 79 insertions(+) [...] + +    virDomainObjSetState(vm,

Re: [libvirt] [PATCH 1/2] test_driver: implement virDomainPMSuspendForDuration

On 8/13/19 1:19 PM, Ilias Stamatis wrote: Signed-off-by: Ilias Stamatis --- src/test/test_driver.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 5f5c512571..d21a69c7ed 100755 ---

[libvirt] [PATCH] virsh: Fix help for net-port-delete

Apparently a copy/paste error. The net-port-delete help string was in fact from net-port-dumpxml. Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1747826 Signed-off-by: Jonathon Jongsma --- tools/virsh-network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH] news: rewording wrt NSS, virt-login-shell & split daemons

Signed-off-by: Daniel P. Berrangé --- docs/news.xml | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index bd112d56dc..f376e991cb 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -65,13 +65,13 @@

Re: [libvirt] [PATCH python] spec: Build python2 package in fedora < 31

On 9/2/19 11:47 AM, Nir Soffer wrote: > Since commit ee0cfbe65c5d (spec: Unconditionally build python2 on > Fedora) python2-libvirt is not built on any Fedora version. > > Fix the spec to drop python2-libvirt on Fedora 31. > > Signed-off-by: Nir Soffer > --- > libvirt-python.spec.in | 2 +- >

Re: [libvirt] [PATCH] news: document new libxml version requirement

On Tue, 2019-09-03 at 15:22 +0100, Daniel P. Berrangé wrote: > On Tue, Sep 03, 2019 at 04:19:01PM +0200, Andrea Bolognani wrote: > > On Tue, 2019-09-03 at 13:24 +0100, Daniel P. Berrangé wrote: > > > + > > > + > > > + libxml: min required libxml is now 2.9.1 > > > +

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: virt-manager-check » libvirt-fedora-rawhide #1056

On Tue, 2019-09-03 at 10:23 -0400, Cole Robinson wrote: > On 9/3/19 9:31 AM, c...@centos.org wrote: > > See > > > > > > -- > > Started by upstream project

Re: [libvirt] [Qemu-devel] [PULL 0/2] Audio 20190828 patches

On Wed, 28 Aug 2019 at 12:55, Gerd Hoffmann wrote: > > The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into > staging (2019-08-27 15:52:36 +0100) > > are available in the Git repository at: >

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: virt-manager-check » libvirt-fedora-rawhide #1056

On Tue, Sep 03, 2019 at 10:23:08AM -0400, Cole Robinson wrote: > > Traceback (most recent call last): > > File > > "/home/jenkins/build/libvirt/lib64/python3.7/site-packages/libvirt.py", > > line 24, in [snip] > Anyone know what's going on here? I don't think this is virt-manager's >

Re: [libvirt] [jenkins-ci PATCH v2] libvirt-ocaml: add a simple check job

On Tue, 2019-09-03 at 15:18 +0200, Pino Toscano wrote: > Run 'make check-manifest' as build step, so we ensure that the MANIFEST > file is up-to-date, and thus dist will (hopefully) work. > > Signed-off-by: Pino Toscano > --- > > Changes from v1: > - run 'make check-manifest' as separate job >

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: virt-manager-check » libvirt-fedora-rawhide #1056

On 9/3/19 9:31 AM, c...@centos.org wrote: > See > > > -- > Started by upstream project "virt-manager-check" build number 1056 > originally caused by: >

Re: [libvirt] [PATCH] news: document new libxml version requirement

On Tue, Sep 03, 2019 at 04:19:01PM +0200, Andrea Bolognani wrote: > On Tue, 2019-09-03 at 13:24 +0100, Daniel P. Berrangé wrote: > > + > > + > > + libxml: min required libxml is now 2.9.1 > > + > > + > > + Support for building with libxml versions

Re: [libvirt] [PATCH] news: document new libxml version requirement

On Tue, 2019-09-03 at 13:24 +0100, Daniel P. Berrangé wrote: > + > + > + libxml: min required libxml is now 2.9.1 > + > + > + Support for building with libxml versions older than 2.9.1 > + has been dropped. > + > + I don't

[libvirt] [PATCH v3 17/18] qemu: Add -blockdev support for external snapshots

Use the code for creating or attaching new storage source in the snapshot code and switch to 'blockdev-snapshot' for creating the snapshot itself. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_driver.c | 104 ++--- 1 file changed, 88

[libvirt] [PATCH v3 09/18] qemu: driver: Fix shallow non-reuse block copy

The code preparing data for creating/attaching the target image of block copy didn't use the correct reference to the existing backing chain in case when the copy should inherit it. This meant that qemu actually opened a second copy of the chain and operated on that. This would de-sync qemu from

[libvirt] [PATCH v3 13/18] qemu: snapshot: Rename external disk snapshot handling functions

Fix and unify the naming of external snapshot preparation functions. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 64 +- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH v3 18/18] qemu: Defer support checks for external active snapshots to blockdev code or qemu

Remove libvit's support check for the target of an external snapshot to the blockdev code or qemu. This will potentially require a more complex cleanup but removes a level of hardcoded feature checks. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_driver.c | 16

[libvirt] [PATCH v3 15/18] qemu: Merge use of 'reuse' flag in qemuDomainSnapshotDiskPrepareOne

Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_driver.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 397f943a1b..39d9118953 100644 --- a/src/qemu/qemu_driver.c +++

[libvirt] [PATCH v3 07/18] qemu: block: explicitly pass backing store to qemuBlockStorageSourceAttachPrepareBlockdev

Pass backing store as an argument rather than extracting it locally and fix the callers. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 4 +++- src/qemu/qemu_block.h | 1 + src/qemu/qemu_command.c | 2 +- src/qemu/qemu_migration.c | 4 +++- 4 files changed, 8 insertions(+), 3

[libvirt] [PATCH v3 08/18] qemu: Explicitly pass backing store to qemuBuildStorageSourceChainAttachPrepareBlockdevTop

In some cases we'll need to pass in a backing store which is not recorded as the backing store of @src. Export backingStore as variable and fix all callers to pass in the backing store. No semantic changes for now. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 12 +---

[libvirt] [PATCH v3 11/18] qemu: snapshot: Save status and config XMLs only on success

We changed to always saving the status and config XMLs to simplify code. After a few more refactors it's now possible to move it to the appropriate place and save the XMLs only on success again. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 10 +- 1 file changed, 5

[libvirt] [PATCH v3 10/18] qemu: snapshot: Fix image lock handling when taking a snapshot

When we take a snapshot we must properly remove our locking infrastructure locks. This was broken by commit 3817fa10c4ad9 which attempted to properly track the readonly state for the image as the locking code was executed after this change. Since we forced the image which was locked as read-write

[libvirt] [PATCH v3 12/18] qemu: snapshot: Move error preservation to qemuDomainSnapshotDiskDataCleanup

Make qemuDomainSnapshotDiskDataCleanup cleanup section friendly by moving the error preservation code inside it. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

[libvirt] [PATCH v3 14/18] qemu: Disband qemuDomainSnapshotCreateSingleDiskActive

After we always assume support for the 'transaction' command (c358adc57113b) and follow-up cleanups qemuDomainSnapshotCreateSingleDiskActive lost its value. Move the code into appropriate helpers and remove the function. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 53

[libvirt] [PATCH v3 16/18] qemu: snapshot: Skip overlay file creation/interogation if unsupported

With blockdev we'll be able to support protocols which are not supported by the storage backends in libvirt. This means that we have to be able to skip the creation and relative storage path reading if it's not supported. This will make it impossible to use relative backing for network protocols

[libvirt] [PATCH v3 02/18] tests: qemublock: Use bigger numbers as dummy capacity/physical

Actually test that the full range is available. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- tests/qemublocktest.c | 4 ++-- tests/qemublocktestdata/imagecreate/luks-encopts.json | 4 ++--

[libvirt] [PATCH v3 06/18] qemu: command: Refactor qemuBuildStorageSourceChainAttachPrepareBlockdevInternal

Extract the loop and supporting infrastructure to the caller as only one of the two callers actually cares about looping and rename the helper to qemuBuildStorageSourceChainAttachPrepareBlockdevOne. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 57

[libvirt] [PATCH v3 05/18] qemu: block: Explicitly specify backingStore when creating format layer props

Pass in backing store explicitly to qemuBlockStorageSourceGetBlockdevProps and fix the callers. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 8 +--- src/qemu/qemu_block.h | 3 ++- tests/qemublocktest.c | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git

[libvirt] [PATCH v3 04/18] qemu: block: Unify conditions to format backing store of format node definition

Move all bits of the formatting of the 'backing' attribute to a single condition and make it use a single extracted copy of the backing store. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff

[libvirt] [PATCH v3 03/18] qemu: monitor: Fix formatting of 'offset' in qemuMonitorJSONSaveMemory

The offset is unsigned long long thus 'U' must be used. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index

[libvirt] [PATCH v3 01/18] qemu: block: Use correct type when creating image size JSON entries

The 'u' modifier creates an unsigned int JSON attribute but the disk size and capacity fields are unsigned long long. If the size of the created image would be more than 4GiB we'd overflow and create sub-4G image. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_block.c |

[libvirt] [PATCH v3 00/18] qemu: Blockdevize external snapshot creation (blokcdev-add saga)

Another posting of this series as I've added a few patches which fix a problem with shallow block copy. Patches 1-5 of the original series were pushed. Patches 1-3 of this series were originally posted and reviewed separately but were not pushed yet due to the ongoing freeze. They are included

[libvirt] [jenkins-ci PATCH v2] libvirt-ocaml: add a simple check job

Run 'make check-manifest' as build step, so we ensure that the MANIFEST file is up-to-date, and thus dist will (hopefully) work. Signed-off-by: Pino Toscano --- Changes from v1: - run 'make check-manifest' as separate job guests/playbooks/build/projects/libvirt-ocaml.yml | 4

Re: [libvirt] [PATCH] news: Update for 5.7.0 release

On Tue, 2019-09-03 at 13:36 +0100, Daniel P. Berrangé wrote: > On Tue, Sep 03, 2019 at 02:26:23PM +0200, Andrea Bolognani wrote: > > On Tue, 2019-09-03 at 14:09 +0200, Michal Privoznik wrote: > > > + The big monolithic libvirtd daemon can now be replaced by > > > smaller > > > +

Re: [libvirt] [PATCH] news: Update for 5.7.0 release

On Tue, Sep 03, 2019 at 02:26:23PM +0200, Andrea Bolognani wrote: > On Tue, 2019-09-03 at 14:09 +0200, Michal Privoznik wrote: > > Signed-off-by: Michal Privoznik > > --- > > docs/news.xml | 133 ++ > > 1 file changed, 133 insertions(+) > > > >

Re: [libvirt] [PATCH] news: Update for 5.7.0 release

On Tue, 2019-09-03 at 14:09 +0200, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > docs/news.xml | 133 ++ > 1 file changed, 133 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index 0c79765fd0..f95af0f0e9 100644 >

[libvirt] [PATCH] news: document new libxml version requirement

Signed-off-by: Daniel P. Berrangé --- docs/news.xml | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 92d566c2fe..434aeab933 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -63,6 +63,15 @@ KVM device assignment from libvirt too.

[libvirt] [PATCH] news: Update for 5.7.0 release

Signed-off-by: Michal Privoznik --- docs/news.xml | 133 ++ 1 file changed, 133 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 0c79765fd0..f95af0f0e9 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -50,6 +50,30 @@ for

Re: [libvirt] [jenkins-ci PATCH] libvirt-ocaml: run 'make check-manifest' as build step

On Tue, 2019-09-03 at 11:13 +0200, Pino Toscano wrote: > On Tuesday, 3 September 2019 11:07:36 CEST Andrea Bolognani wrote: > > On Tue, 2019-09-03 at 10:55 +0200, Pino Toscano wrote: > > > +++ b/guests/playbooks/build/projects/libvirt-ocaml.yml > > > @@ -25,3 +25,4 @@ > > >./configure

Re: [libvirt] [dockerfiles PATCH v2 3/3] refresh: Update Dockerfiles due to new osinfo-db-tools build system

On Tue, 2019-09-03 at 13:42 +0200, Fabiano Fidêncio wrote: > Let's regfresh the archived Dockerfiles as osinfo-db-tools has recently > switched to using meson instead of autotools. s/regfresh/refresh/ With that fixed, Reviewed-by: Andrea Bolognani I'll fix the typos and push, then kick off

Re: [libvirt] [dockerfiles PATCH v2 2/3] refresh: Remove Dockerfiles from OSes not supported by osinfo-db-tools

On Tue, 2019-09-03 at 13:42 +0200, Fabiano Fidêncio wrote: > osinfo-db-tools has recently switched to using meson instead of > autotools and CentOS 7, Debian 9, Ubuntu 16.04. and Ubuntu 18.04 do not > have the minimum required version of meson. > > Signed-off-by: Fabiano Fidêncio > --- >

Re: [libvirt] [dockerfiles PATCH v2 1/3] refresh: Remove "cross" Dockerfiles

On Tue, 2019-09-03 at 13:42 +0200, Fabiano Fidêncio wrote: > refresh: Remove "cross" Dockerfiles s/Remove/Remove libosinfo/ > Cross builds haven't been working since the beginning as some > dependencies related to gobject intropsection s/gobject intropsection/GObject Introspection/ > are not

[libvirt] [dockerfiles PATCH v2 1/3] refresh: Remove "cross" Dockerfiles

Cross builds haven't been working since the beginning as some dependencies related to gobject intropsection are not target as multi architecture on Debian. Knowing that, let's also drop those Dockerfiles. Signed-off-by: Fabiano Fidêncio --- buildenv-libosinfo-debian-10-cross-aarch64.zip | Bin

[libvirt] [dockerfiles PATCH v2 2/3] refresh: Remove Dockerfiles from OSes not supported by osinfo-db-tools

osinfo-db-tools has recently switched to using meson instead of autotools and CentOS 7, Debian 9, Ubuntu 16.04. and Ubuntu 18.04 do not have the minimum required version of meson. Signed-off-by: Fabiano Fidêncio --- buildenv-libosinfo-centos-7.zip | Bin 458 -> 0 bytes

[libvirt] [dockerfiles PATCH v2 3/3] refresh: Update Dockerfiles due to new osinfo-db-tools build system

Let's regfresh the archived Dockerfiles as osinfo-db-tools has recently switched to using meson instead of autotools. The corresponding libvirt-jenkins-ci commit is 7b862090328a702. Signed-off-by: Fabiano Fidêncio --- buildenv-libosinfo-debian-10.zip | Bin 555 -> 559 bytes

[libvirt] [dockerfiles PATCH v2 0/3] Update libosinfo (& friends) dockerfiles

As osinfo-db-tools has recently switched to using meson instead of autotools, let's update the libosinfo-dockerfiles accordingly. Together with this change, let's also drop the "cross" Dockerfiles, as those were never working due to some gobject dependency not being multi architecture friendly on

Re: [libvirt] [ocaml PATCH 7/6] Hide again the internal helpers

On Tue, Sep 03, 2019 at 01:41:16PM +0200, Pino Toscano wrote: > Use a GCC pragma to hide all the internal helpers, so they are not > exposed as public symbols of the stub library. > > Signed-off-by: Pino Toscano > --- > libvirt/libvirt_c.h | 11 +++ > 1 file changed, 11 insertions(+) >

[libvirt] [ocaml PATCH 7/6] Hide again the internal helpers

Use a GCC pragma to hide all the internal helpers, so they are not exposed as public symbols of the stub library. Signed-off-by: Pino Toscano --- libvirt/libvirt_c.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libvirt/libvirt_c.h b/libvirt/libvirt_c.h index 541d8e3..45937f6

Re: [libvirt] [ocaml PATCH 6/6] Rename libvirt_c_epilogue.c to libvirt_c_common.c

On Tuesday, 3 September 2019 13:04:14 CEST Richard W.M. Jones wrote: > This is all fine. Should we try to use a linker script > to hide the public symbols from patch 2? Makes sense -- let me post a followup. Thanks, -- Pino Toscano signature.asc Description: This is a digitally signed message

Re: [libvirt] [ocaml PATCH 6/6] Rename libvirt_c_epilogue.c to libvirt_c_common.c

This is all fine. Should we try to use a linker script to hide the public symbols from patch 2? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual

Re: [libvirt] [DO NOT MERGE] [PATCH 0/1] Rewrite virt-host-validate in Go & Go packaging complication

On Mon, Sep 02, 2019 at 05:38:25PM +0100, Daniel P. Berrangé wrote: [...] Thus this patch is *NOT* something I'm proposing to merge as is. The code itself is fine, but it will need to go into a new git repo of its own. Please, put that in the subject prefix next time, for the sake of my

[libvirt] [dockerfiles PATCH 2/2] refresh: Update Dockerfiles due to new osinfo-db-tools build system

Let's regfresh the archived Dockerfiles as osinfo-db-tools has recently switched to using meson instead of autotools. The corresponding libvirt-jenkins-ci commit is 7b862090328a702. Signed-off-by: Fabiano Fidêncio --- buildenv-libosinfo-debian-10-cross-aarch64.zip | Bin 683 -> 688 bytes

[libvirt] [dockerfiles PATCH 1/2] refresh: Remove Dockerfiles from OSes not supported by osinfo-db-tools

osinfo-db-tools has recently switched to using meson instead of autotools and CentOS 7, Debian 9, Ubuntu 16.04. and Ubuntu 18.04 do not have the minimum required version of meson. Signed-off-by: Fabiano Fidêncio --- buildenv-libosinfo-centos-7.zip| Bin 458 -> 0 bytes

[libvirt] [dockerfiles PATCH 0/2] Update libosinfo (& friends) dockerfiles

As osinfo-db-tools has recently switched to using meson instead of autotools, let's update the libosinfo-dockerfiles accordingly. https://gitlab.com/fidencio/libvirt-dockerfiles/tree/wip/osinfo_db_tools_meson_update Fabiano Fidêncio (2): refresh: Remove Dockerfiles from OSes not supported by

Re: [libvirt] [jenkins-ci PATCH] libvirt-ocaml: run 'make check-manifest' as build step

On Tuesday, 3 September 2019 11:07:36 CEST Andrea Bolognani wrote: > On Tue, 2019-09-03 at 10:55 +0200, Pino Toscano wrote: > > This ensures that the MANIFEST file is up-to-date, and thus dist will > > (hopefully) work. > > > > Signed-off-by: Pino Toscano > > --- > >

Re: [libvirt] [jenkins-ci PATCH] libvirt-ocaml: run 'make check-manifest' as build step

On Tue, 2019-09-03 at 10:55 +0200, Pino Toscano wrote: > This ensures that the MANIFEST file is up-to-date, and thus dist will > (hopefully) work. > > Signed-off-by: Pino Toscano > --- > guests/playbooks/build/projects/libvirt-ocaml.yml | 1 + > jenkins/projects/libvirt-ocaml.yaml

[libvirt] [jenkins-ci PATCH] libvirt-ocaml: run 'make check-manifest' as build step

This ensures that the MANIFEST file is up-to-date, and thus dist will (hopefully) work. Signed-off-by: Pino Toscano --- guests/playbooks/build/projects/libvirt-ocaml.yml | 1 + jenkins/projects/libvirt-ocaml.yaml | 1 + 2 files changed, 2 insertions(+) diff --git

[libvirt] [ocaml PATCH 2/6] Turn libvirt_c.h as proper header

- make sure that all the function declarations are non-static, so the header can be included by more than one C source - move all the common includes there from the generated file from generator.pl - add include guard for it, even if it will not be used in practice Signed-off-by: Pino Toscano

[libvirt] [ocaml PATCH 1/6] Rename libvirt_c_prologue.c to libvirt_c.h

Since it contains prototypes of functions and common macros, just rename it so it will be used as proper general header for multiple sources in the future. Signed-off-by: Pino Toscano --- MANIFEST | 2 +- libvirt/Makefile.in | 2 +-

[libvirt] [ocaml PATCH 4/6] Rename the generated libvirt_c.c to libvirt_generated.c

Make it clear it is a generated source. Signed-off-by: Pino Toscano --- .gitignore | 2 +- Makefile.in | 2 +- libvirt/Makefile.in | 18 +- libvirt/README | 6 +++--- libvirt/generator.pl | 4 ++-- libvirt/libvirt.mli | 2 +- 6 files changed, 17

[libvirt] [ocaml PATCH 0/6] Split/reorganize sources

This series splits the sources in the 3 parts built on their own (instead of a whole source including everything), so it is easier to rebuild on changes. Also, improve their file names. Pino Toscano (6): Rename libvirt_c_prologue.c to libvirt_c.h Turn libvirt_c.h as proper header Build C

[libvirt] [ocaml PATCH 6/6] Rename libvirt_c_epilogue.c to libvirt_c_common.c

Make it clear it contains common code, and it is no more the final part of some other source. Signed-off-by: Pino Toscano --- MANIFEST | 2 +- libvirt/Makefile.in | 10 +- libvirt/README

[libvirt] [ocaml PATCH 5/6] Build libvirt_generated.c with -Wmissing-prototypes

There are no prototypes for the autogenerated C functions, so build this source with that too. Previously it was pulled in when all the sources were built as one. Signed-off-by: Pino Toscano --- libvirt/generator.pl | 4 1 file changed, 4 insertions(+) diff --git a/libvirt/generator.pl

[libvirt] [ocaml PATCH 3/6] Build C sources separately

Instead of including everything in a single C source, build all the 3 C sources separately. Signed-off-by: Pino Toscano --- libvirt/Makefile.in | 14 +++--- libvirt/README | 28 ++-- libvirt/generator.pl | 4

Re: [libvirt] [jenkins-ci PATCH] osinfo-db-tools: Don't try to build RPMs on CentOS 7

On Tue, Sep 3, 2019 at 10:38 AM Andrea Bolognani wrote: > > It no longer is a supported target platform. > > Signed-off-by: Andrea Bolognani Reviewed-by: Fabiano Fidêncio -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [jenkins-ci PATCH] osinfo-db-tools: Don't try to build RPMs on CentOS 7

It no longer is a supported target platform. Signed-off-by: Andrea Bolognani --- guests/playbooks/build/projects/osinfo-db-tools.yml | 5 - jenkins/projects/osinfo-db-tools.yaml | 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] [PATCH 0/2] Remove xenapi driver

On Tue, Sep 03, 2019 at 04:58:23AM +, Jim Fehlig wrote: > Remove the xenapi driver is unmaintained and has no known user base. > We are stuck with references in include/libvirt/virterror.h and > src/util/virerror.c but otherwise I think I've nuked xenapi everywhere. Yes, that's OK, we must

Re: [libvirt] [PATCH 1/1] tools: rewrite virt-host-validate in Go to be data driven

On Tue, Sep 03, 2019 at 08:56:14AM +0200, Peter Krempa wrote: > On Mon, Sep 02, 2019 at 17:38:26 +0100, Daniel Berrange wrote: > > The current virt-host-validate command has a bunch of checks > > defined in the source code which are thus only extensible by > > the upstream project, or downstream

Re: [libvirt] [PATCH] docs: rewrite hvsupport.html page generator in python

On Fri, 2019-08-30 at 13:25 +0100, Daniel P. Berrangé wrote: > As part of an goal to eliminate Perl from libvirt build tools, > rewrite the hvsupport.pl tool in Python. > > This was a straight conversion, manually going line-by-line to > change the syntax from Perl to Python. Thus the overall

Re: [libvirt] [PATCH 1/1] tools: rewrite virt-host-validate in Go to be data driven

On Mon, Sep 02, 2019 at 17:38:26 +0100, Daniel Berrange wrote: > The current virt-host-validate command has a bunch of checks > defined in the source code which are thus only extensible by > the upstream project, or downstream code modification. [...] This breaks in make check on my machine with