Re: [libvirt] [libvirt-tck PATCH] TCK.pm: Define libvirt VMs with an RNG device

2019-09-23 Thread Laine Stump
On 9/23/19 1:27 PM, Erik Skultety wrote: The nwfilter 220-no-ip-spoofing.t test relies on an SSH connection to the test VM. However, because the domain definition passed to libvirt lacks an RNG device, the SSH server isn't started inside the guest (even though that is the default on virt-builder

[libvirt] [PATCH v2 08/11] driver.c: change URI validation to handle QEMU and vbox case

2019-09-23 Thread Daniel Henrique Barboza
The existing QEMU and vbox URI path validation consider that a privileged user can use both a "/system" and a "/session" URI. This differs from all the other drivers that forbids the root user to use "/session" URI. Let's update virConnectValidateURIPath() to handle these cases as exceptions,

[libvirt] [PATCH v2 11/11] vbox_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/vbox/vbox_driver.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/vbox/vbox_driver.c b/src/vbox/vbox_driver.c index 1f31fa28df..d7e80828ab 100644 --- a/src/vbox/vbox_driver.c

[libvirt] [PATCH v2 05/11] node_device_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/node_device/node_device_driver.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index

[libvirt] [PATCH v2 03/11] interface_backend_udev.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/interface/interface_backend_udev.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index

[libvirt] [PATCH v2 02/11] interface_backend_netcf.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/interface/interface_backend_netcf.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/interface/interface_backend_netcf.c b/src/interface/interface_backend_netcf.c index

[libvirt] [PATCH v2 01/11] src/driver.c: add virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
The code to validate the URI path is repeated across several files. This patch creates a common validation code to be used across all of them. Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/driver.c | 24 src/driver.h

[libvirt] [PATCH v2 00/11] remove repetition of URI path validation

2019-09-23 Thread Daniel Henrique Barboza
This is a code repetition that I crossed a few times, then I noticed that Cole Robinson suggested a solution for it in the wiki. Here it is. changes from v1: - handle QEMU and vbox cases separately inside the validation function v1:

[libvirt] [PATCH v2 07/11] storage_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/storage/storage_driver.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index ce10b55ed0..1bec2d964f 100644 ---

[libvirt] [PATCH v2 06/11] secret_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/secret/secret_driver.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 7512a51c74..07ba679541 100644 ---

[libvirt] [PATCH v2 09/11] qemu_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_driver.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f7f059b6d6..fe4d50c372 100644 ---

[libvirt] [PATCH v2 10/11] vbox_common.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/vbox/vbox_common.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index ddabcb80ca..d3b8fb625f 100644 --- a/src/vbox/vbox_common.c

[libvirt] [PATCH v2 04/11] bridge_driver.c: virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/network/bridge_driver.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index c54be96407..c617bbb58f 100644 ---

[libvirt] [libvirt-tck PATCH] TCK.pm: Define libvirt VMs with an RNG device

2019-09-23 Thread Erik Skultety
The nwfilter 220-no-ip-spoofing.t test relies on an SSH connection to the test VM. However, because the domain definition passed to libvirt lacks an RNG device, the SSH server isn't started inside the guest (even though that is the default on virt-builder images) and therefore: "ssh: connect to

Re: [libvirt] [PATCH 05/22] docs: apibuild: Purge irrelevant typed parameter APIs from ignore

2019-09-23 Thread Ján Tomko
On Thu, Sep 19, 2019 at 07:13:08PM +0200, Peter Krempa wrote: The internal helpers are not considered any more so we don't have to ignore them either. Signed-off-by: Peter Krempa --- docs/apibuild.py | 5 - 1 file changed, 5 deletions(-) Reviewed-by: Ján Tomko diff --git

Re: [libvirt] [PATCH 03/22] util: typedparam: Move and unexport virTypedParameterAssignFromStr

2019-09-23 Thread Ján Tomko
On Thu, Sep 19, 2019 at 07:13:06PM +0200, Peter Krempa wrote: The function is only used as a helper in virTypedParamsAddFromString. Make it static and move it to virtypedparam-public.c. Signed-off-by: Peter Krempa --- src/libvirt_private.syms| 1 - src/util/virtypedparam-public.c | 95

Re: [libvirt] [PATCH 04/22] util: typedparam: Remove pointless cleanup label from virTypedParameterAssignFromStr

2019-09-23 Thread Ján Tomko
On Thu, Sep 19, 2019 at 07:13:07PM +0200, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/util/virtypedparam-public.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature --

Re: [libvirt] [PATCH 02/22] util: typedparam: Purge public bits from virTypedParamsGetStringList

2019-09-23 Thread Ján Tomko
On Thu, Sep 19, 2019 at 07:13:05PM +0200, Peter Krempa wrote: The function is not exported in the public API thus the error dispatching is not required. Signed-off-by: Peter Krempa --- src/util/virtypedparam.c | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Ján Tomko Jano

Re: [libvirt] [PATCH 01/22] util: typedparam: Split out public APIs into a separate file

2019-09-23 Thread Ján Tomko
On Thu, Sep 19, 2019 at 07:13:04PM +0200, Peter Krempa wrote: Some of the typed parameter APIs are exported publically, but the publicly is the more common spelling implementation was intermixed with private functions. Introduce virtypedparam-public.c, move all public API functions there and

Re: [libvirt] [PATCH 08/10] qemu_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
On 9/23/19 11:51 AM, Daniel P. Berrangé wrote: On Mon, Sep 23, 2019 at 11:03:41AM -0300, Daniel Henrique Barboza wrote: The existing QEMU URI path validation considers that a privileged user can use a "/session" URI as well. Let's update virConnectValidateURIPath() to consider this usage,

Re: [libvirt] [PATCH 08/10] qemu_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel P . Berrangé
On Mon, Sep 23, 2019 at 11:03:41AM -0300, Daniel Henrique Barboza wrote: > The existing QEMU URI path validation considers that a > privileged user can use a "/session" URI as well. Let's update > virConnectValidateURIPath() to consider this usage, allowing us > to use the function inside

Re: [libvirt] [PATCH 1/1] conf: handle empty string in interface target name

2019-09-23 Thread Peter Krempa
On Mon, Sep 23, 2019 at 11:21:33 -0300, Daniel Henrique Barboza wrote: > > > On 9/23/19 8:55 AM, Nikolay Shirokovskiy wrote: > > Empty name is not allowed by schema but qemu is able to start with such > > a config (and I guess some other hypervisors too). As a result name will > > be generated

Re: [libvirt] [PATCH] build: ensure Makefile.inc.am is checked for long lines

2019-09-23 Thread Eric Blake
On 9/23/19 8:39 AM, Daniel P. Berrangé wrote: > The filename match rule was accidentally excluding the > Makefile.inc.am files from the long lines check. > > Signed-off-by: Daniel P. Berrangé > --- > cfg.mk | 2 +- > src/interface/Makefile.inc.am | 6 -- >

Re: [libvirt] [PATCH 1/1] conf: handle empty string in interface target name

2019-09-23 Thread Daniel Henrique Barboza
On 9/23/19 8:55 AM, Nikolay Shirokovskiy wrote: Empty name is not allowed by schema but qemu is able to start with such a config (and I guess some other hypervisors too). As a result name will be generated by kernel and have form 'tap'. At the same time if target element is ommited in config

Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

2019-09-23 Thread Andrea Bolognani
On Mon, 2019-09-23 at 15:43 +0200, Pavel Hrdina wrote: > On Mon, Sep 23, 2019 at 03:03:47PM +0200, Andrea Bolognani wrote: > > Anyway, while I agree that in theory this is extremely simple to > > solve, I'd like to see that theory put into practice before we cut > > any release that requires

Re: [libvirt] [Libvirt-Security] [PATCH] qemu: snapshot: Do ACL check prior to checkpoint interlocking

2019-09-23 Thread Eric Blake
On 9/23/19 8:52 AM, Peter Krempa wrote: > Commit 7efe930ec3c introduced interlock of snapshots and checkpoints, > but the check is executed prior to the snapshot API ACL check. This > means that an unauthorized user can see whether a VM exists if it has a > checkpoint. > > Move the checks to

[libvirt] [PATCH 10/10] vbox_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/vbox/vbox_driver.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/vbox/vbox_driver.c b/src/vbox/vbox_driver.c index 1f31fa28df..d7e80828ab 100644 --- a/src/vbox/vbox_driver.c

[libvirt] [PATCH 05/10] node_device_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/node_device/node_device_driver.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index

[libvirt] [PATCH 08/10] qemu_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
The existing QEMU URI path validation considers that a privileged user can use a "/session" URI as well. Let's update virConnectValidateURIPath() to consider this usage, allowing us to use the function inside qemu_driver.c. Although the existing callers of virConnectValidateURIPath() didn't

[libvirt] [PATCH 09/10] vbox_common.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/vbox/vbox_common.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index ddabcb80ca..d3b8fb625f 100644 --- a/src/vbox/vbox_common.c

[libvirt] [PATCH 07/10] storage_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/storage/storage_driver.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index ce10b55ed0..1bec2d964f 100644 ---

[libvirt] [PATCH 06/10] secret_driver.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/secret/secret_driver.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c index 7512a51c74..07ba679541 100644 ---

[libvirt] [PATCH 03/10] interface_backend_udev.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/interface/interface_backend_udev.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index

[libvirt] [PATCH 02/10] interface_backend_netcf.c: use virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/interface/interface_backend_netcf.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/interface/interface_backend_netcf.c b/src/interface/interface_backend_netcf.c index

[libvirt] [PATCH 04/10] bridge_driver.c: virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/network/bridge_driver.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index c54be96407..c617bbb58f 100644 ---

[libvirt] [PATCH 01/10] src/driver.c: add virConnectValidateURIPath()

2019-09-23 Thread Daniel Henrique Barboza
The code to validate the URI path is repeated across several files. This patch creates a common validation code to be used across all of them. Suggested-by: Cole Robinson Signed-off-by: Daniel Henrique Barboza --- src/driver.c | 24 src/driver.h

[libvirt] [PATCH 00/10] remove repetition of URI path validation

2019-09-23 Thread Daniel Henrique Barboza
This is a code repetition that I crossed a few times, then I noticed that Cole Robinson suggested a solution for it in the wiki. Here it is. Daniel Henrique Barboza (10): src/driver.c: add virConnectValidateURIPath() interface_backend_netcf.c: use virConnectValidateURIPath()

Re: [libvirt] [PATCH] docs: document that C & Python are the preferred languages

2019-09-23 Thread Daniel P . Berrangé
On Thu, Sep 05, 2019 at 06:15:04PM +0100, Daniel P. Berrangé wrote: > On Thu, Sep 05, 2019 at 12:30:27PM -0400, Laine Stump wrote: > > (BTW, what does the removal of perl from libvirt say about continued > > use of perl for libvirt-tck? There are a lot of useful tests in there > > that find real

[libvirt] [PATCH] qemu: snapshot: Do ACL check prior to checkpoint interlocking

2019-09-23 Thread Peter Krempa
Commit 7efe930ec3c introduced interlock of snapshots and checkpoints, but the check is executed prior to the snapshot API ACL check. This means that an unauthorized user can see whether a VM exists if it has a checkpoint. Move the checks to proper places. Signed-off-by: Peter Krempa --- Given

Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

2019-09-23 Thread Fabiano Fidêncio
On Mon, Sep 23, 2019 at 3:40 PM Daniel P. Berrangé wrote: > > On Mon, Sep 23, 2019 at 03:37:15PM +0200, Fabiano Fidêncio wrote: > > On Mon, Sep 23, 2019 at 2:51 PM Daniel P. Berrangé > > wrote: > > > > > > On Mon, Sep 23, 2019 at 02:33:43PM +0200, Andrea Bolognani wrote: > > > > On Mon,

Re: [libvirt] [PATCH] rpm: stop compressing the ChangeLog file

2019-09-23 Thread Laine Stump
On 9/23/19 8:56 AM, Daniel P. Berrangé wrote: We stopped generating a giant ChangeLog file in commit ce97c33a795dec053f1e85c65ecd924b8c6ec4ba Author: Andrea Bolognani Date: Mon Apr 1 17:33:03 2019 +0200 maint: Stop generating ChangeLog from git so there is no reason to

[libvirt] [PATCH] build: ensure Makefile.inc.am is checked for long lines

2019-09-23 Thread Daniel P . Berrangé
The filename match rule was accidentally excluding the Makefile.inc.am files from the long lines check. Signed-off-by: Daniel P. Berrangé --- cfg.mk | 2 +- src/interface/Makefile.inc.am | 6 -- src/libxl/Makefile.inc.am | 5 -

Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

2019-09-23 Thread Pavel Hrdina
On Mon, Sep 23, 2019 at 03:03:47PM +0200, Andrea Bolognani wrote: > On Mon, 2019-09-23 at 13:51 +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 23, 2019 at 02:33:43PM +0200, Andrea Bolognani wrote: > > > tl;dr NACK until we figure out how to do this without dropping > > > several target

Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

2019-09-23 Thread Daniel P . Berrangé
On Mon, Sep 23, 2019 at 03:37:15PM +0200, Fabiano Fidêncio wrote: > On Mon, Sep 23, 2019 at 2:51 PM Daniel P. Berrangé > wrote: > > > > On Mon, Sep 23, 2019 at 02:33:43PM +0200, Andrea Bolognani wrote: > > > On Mon, 2019-09-23 at 13:23 +0200, Fabiano Fidêncio wrote: > > > > name:

Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

2019-09-23 Thread Fabiano Fidêncio
On Mon, Sep 23, 2019 at 2:51 PM Daniel P. Berrangé wrote: > > On Mon, Sep 23, 2019 at 02:33:43PM +0200, Andrea Bolognani wrote: > > On Mon, 2019-09-23 at 13:23 +0200, Fabiano Fidêncio wrote: > > > name: libvirt-dbus > > > +# libvirt-dbus depends on meson 0.49.0 which is not available on

[libvirt] libvirt-lxc broken by new systemd 243

2019-09-23 Thread Christian Ehrhardt
Hi, with the new systemd 243 libvirt-lxc seems broken. We had the particular symptom already in the past, the TL;DR is: 1. start a lxc guest 2. restart libvirtd 3. guest is gone This particular change is due to [1] fixed by [2] which as a side effect will wipe libvirt-lxc containers on daemon

Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

2019-09-23 Thread Andrea Bolognani
On Mon, 2019-09-23 at 13:51 +0100, Daniel P. Berrangé wrote: > On Mon, Sep 23, 2019 at 02:33:43PM +0200, Andrea Bolognani wrote: > > tl;dr NACK until we figure out how to do this without dropping > > several target platforms in the process > > In theory you can 'pip install meson'. The

[libvirt] [PATCH] rpm: stop compressing the ChangeLog file

2019-09-23 Thread Daniel P . Berrangé
We stopped generating a giant ChangeLog file in commit ce97c33a795dec053f1e85c65ecd924b8c6ec4ba Author: Andrea Bolognani Date: Mon Apr 1 17:33:03 2019 +0200 maint: Stop generating ChangeLog from git so there is no reason to compress it anymore. Signed-off-by: Daniel P. Berrangé

Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

2019-09-23 Thread Andrea Bolognani
On Mon, 2019-09-23 at 14:33 +0200, Andrea Bolognani wrote: > Based on the discussion we had on libvir-list, our approach for CI > should not be to drop target platforms on the basis that they doen't > include a recent enough Meson, but rather to make a suitable Meson > version available through

Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

2019-09-23 Thread Daniel P . Berrangé
On Mon, Sep 23, 2019 at 02:33:43PM +0200, Andrea Bolognani wrote: > On Mon, 2019-09-23 at 13:23 +0200, Fabiano Fidêncio wrote: > > name: libvirt-dbus > > +# libvirt-dbus depends on meson 0.49.0 which is not available on > > +# CentOS 7, Debian 9, Ubuntu 18; > > machines: > > -

Re: [libvirt] [PATCH v5 02/20] qemu-interop: ignore non-readable directories

2019-09-23 Thread Ján Tomko
On Mon, Sep 23, 2019 at 02:44:25PM +0400, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Whether a directory is missing or is not readable doesn't make much difference when populating the available configs. This removes errors when firmare or vhost-user config is looked up from a

Re: [libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

2019-09-23 Thread Andrea Bolognani
On Mon, 2019-09-23 at 13:23 +0200, Fabiano Fidêncio wrote: > name: libvirt-dbus > +# libvirt-dbus depends on meson 0.49.0 which is not available on > +# CentOS 7, Debian 9, Ubuntu 18; > machines: > - - libvirt-centos-7 > - - libvirt-debian-9 >- libvirt-debian-10

Re: [libvirt] [jenkins-ci PATCH] jenkins: Remove meson-syntax-check job

2019-09-23 Thread Andrea Bolognani
On Mon, 2019-09-23 at 13:24 +0200, Fabiano Fidêncio wrote: > On Mon, Sep 23, 2019 at 1:16 PM Andrea Bolognani wrote: > > Fabiano, let me know when it's a good time to push the patch and > > apply the changes. > > Feel free to merge it whenever you have time. It's not going to cause > any

[libvirt] [PATCH 1/1] conf: handle empty string in interface target name

2019-09-23 Thread Nikolay Shirokovskiy
Empty name is not allowed by schema but qemu is able to start with such a config (and I guess some other hypervisors too). As a result name will be generated by kernel and have form 'tap'. At the same time if target element is ommited in config the name will be generated by libvirt and have form

Re: [libvirt] [jenkins-ci PATCH] jenkins: Remove meson-syntax-check job

2019-09-23 Thread Fabiano Fidêncio
On Mon, Sep 23, 2019 at 1:16 PM Andrea Bolognani wrote: > > On Mon, 2019-09-23 at 11:47 +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 23, 2019 at 12:43:18PM +0200, Andrea Bolognani wrote: > > > On Mon, 2019-09-23 at 12:10 +0200, Fabiano Fidêncio wrote: > > > > On Thu, Sep 19, 2019 at 11:11 AM

[libvirt] [jenkins-ci PATCH] Switch libvirt-dbus builds to Meson

2019-09-23 Thread Fabiano Fidêncio
libvirt-dbus has switched its build system to meson and requires 0.49.0 or newer. It means, let's *not* build libvirt-dbus on: - Debian 9 (or older); - Ubuntu 18 (or older); - CentOS 7 Signed-off-by: Fabiano Fidêncio --- .../playbooks/build/projects/libvirt-dbus.yml | 37 +++

Re: [libvirt] [python PATCH 1/2] virDomainMigrate3Params: add missing bandwidth postcopy param

2019-09-23 Thread Daniel P . Berrangé
On Mon, Sep 23, 2019 at 01:08:28PM +0200, Pavel Hrdina wrote: > Introduced in libvirt 5.1.0 by commit . > > Signed-off-by: Pavel Hrdina > --- > libvirt-override.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [python PATCH 2/2] virDomainMigrate3Params: add missing parallel connections param

2019-09-23 Thread Daniel P . Berrangé
On Mon, Sep 23, 2019 at 01:08:29PM +0200, Pavel Hrdina wrote: > Introduced in libvirt 5.2.0 by commit . > > Reported-by: Liping Cheng > Signed-off-by: Pavel Hrdina > --- > libvirt-override.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |:

Re: [libvirt] [jenkins-ci PATCH] jenkins: Remove meson-syntax-check job

2019-09-23 Thread Andrea Bolognani
On Mon, 2019-09-23 at 11:47 +0100, Daniel P. Berrangé wrote: > On Mon, Sep 23, 2019 at 12:43:18PM +0200, Andrea Bolognani wrote: > > On Mon, 2019-09-23 at 12:10 +0200, Fabiano Fidêncio wrote: > > > On Thu, Sep 19, 2019 at 11:11 AM Pavel Hrdina wrote: > > > > Instead of removing the syntax-check

[libvirt] [python PATCH 1/2] virDomainMigrate3Params: add missing bandwidth postcopy param

2019-09-23 Thread Pavel Hrdina
Introduced in libvirt 5.1.0 by commit . Signed-off-by: Pavel Hrdina --- libvirt-override.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index 83ca0fc..bcda8c7 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -7993,6 +7993,9 @@ static

[libvirt] [python PATCH 2/2] virDomainMigrate3Params: add missing parallel connections param

2019-09-23 Thread Pavel Hrdina
Introduced in libvirt 5.2.0 by commit . Reported-by: Liping Cheng Signed-off-by: Pavel Hrdina --- libvirt-override.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt-override.c b/libvirt-override.c index bcda8c7..2e24d27 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@

[libvirt] [python PATCH 0/2] add missing migration params

2019-09-23 Thread Pavel Hrdina
We need to figure out a way how to check this by our test suite. Pavel Hrdina (2): virDomainMigrate3Params: add missing bandwidth postcopy param virDomainMigrate3Params: add missing parallel connections param libvirt-override.c | 6 ++ 1 file changed, 6 insertions(+) -- 2.21.0 --

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Fabiano Fidêncio
On Mon, Sep 23, 2019 at 12:38 PM Pavel Hrdina wrote: > > On Mon, Sep 23, 2019 at 12:31:34PM +0200, Andrea Bolognani wrote: > > On Mon, 2019-09-23 at 11:02 +0100, Daniel P. Berrangé wrote: > > > On Mon, Sep 23, 2019 at 11:59:01AM +0200, Andrea Bolognani wrote: > > > > For what it's worth, I also

Re: [libvirt] [PATCH] docs: attempt to document the general libvirt dev strategy

2019-09-23 Thread Pavel Hrdina
On Mon, Sep 23, 2019 at 11:10:53AM +0100, Daniel P. Berrangé wrote: > On Fri, Sep 20, 2019 at 07:33:08PM +0200, Pavel Hrdina wrote: > > On Fri, Sep 20, 2019 at 03:12:01PM +0100, Daniel P. Berrangé wrote: > > > There are various ideas / plans floating around for future libvirt work, > > > some of

[libvirt] [PATCH v5 14/20] qemu: add vhost-user-gpu helper unit

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Similar to the qemu_tpm.c, add a unit with a few functions to start/stop and setup the cgroup of the external vhost-user-gpu process. See function documentation. The vhost-user connection fd is set on qemuDomainVideoPrivate struct. Signed-off-by: Marc-André Lureau

[libvirt] [PATCH v5 20/20] tests: add vhost-user-gpu xml2argv tests

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- ...host-user-gpu-secondary.x86_64-latest.args | 43 + .../vhost-user-gpu-secondary.xml | 46 +++ .../vhost-user-vga.x86_64-latest.args | 40

[libvirt] [PATCH v5 18/20] qemu: start/stop the vhost-user-gpu external device

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Each vhost-user-gpu needs its own helper gpu process. Start/stop them, and apply the emulator cgroup controller. Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- src/qemu/qemu_extdevice.c | 45 +-- 1 file changed, 39

[libvirt] [PATCH v5 19/20] qemu: build vhost-user GPU devices

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau For each vhost-user GPUs, - build a socket chardev, and pass the vhost-user socket to it - build a vhost-user video device and associate it with the chardev Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- src/qemu/qemu_command.c| 56

[libvirt] [PATCH v5 16/20] tests: wrap vhost-user paths in qemuxml2argvtest

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- tests/qemuxml2argvtest.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 0b8ea13f58..dd38e57c2b 100644 ---

[libvirt] [PATCH v5 15/20] tests: mock execv/execve

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Learn to override the paths to the program to execute (vhost-user helpers are executed to check for runtime capabilities). Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- tests/virfilewrapper.c | 22 ++ 1 file changed, 22

[libvirt] [PATCH v5 17/20] qemu: prepare domain for vhost-user GPU

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Call qemuExtVhostUserGPUPrepareDomain() to fill the domain with the location of the vhost-user binary to start. Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- src/qemu/qemu_extdevice.c | 29 + src/qemu/qemu_extdevice.h | 5

[libvirt] [PATCH v5 13/20] qemu: add qemuDomainVideoPrivate

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- src/qemu/qemu_domain.c | 38 ++ src/qemu/qemu_domain.h | 12 2 files changed, 50 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c

[libvirt] [PATCH v5 11/20] qemu: add qemuSecurityStartVhostUserGPU helper

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau See function documentation. Used in a following patch. Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- src/qemu/qemu_security.c | 40 src/qemu/qemu_security.h | 6 ++ 2 files changed, 46 insertions(+) diff

[libvirt] [PATCH v5 12/20] conf: add privateData to virDomainVideoDef

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- src/conf/domain_conf.c | 26 +- src/conf/domain_conf.h | 8 ++-- src/vz/vz_sdk.c| 2 +- 3 files changed, 24 insertions(+), 12 deletions(-) diff --git

Re: [libvirt] [jenkins-ci PATCH] jenkins: Remove meson-syntax-check job

2019-09-23 Thread Daniel P . Berrangé
On Mon, Sep 23, 2019 at 12:43:18PM +0200, Andrea Bolognani wrote: > On Mon, 2019-09-23 at 12:10 +0200, Fabiano Fidêncio wrote: > > On Thu, Sep 19, 2019 at 11:11 AM Pavel Hrdina wrote: > > > Instead of removing the syntax-check job we can keep it if we use > > > 'suite' labels for our tests in a

[libvirt] [PATCH v5 10/20] qemu: add vhost-user helpers

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Add qemuVhostUserFetchConfigs() to discover vhost-user helpers. qemuVhostUserFillDomainGPU() will find the first matching GPU helper with the required capabilities and set the associated vhost_user_binary. Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson

[libvirt] [PATCH v5 09/20] qemu: restrict 'virgl=' option to non-vhostuser video type

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau vhost-user device doesn't have a virgl option, it is passed to the vhost-user-gpu helper process instead. Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- src/qemu/qemu_command.c| 9 ++---

[libvirt] [PATCH v5 07/20] qemu: check that qemu is vhost-user-vga capable

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau To support virtio VGA with vhost-user, vhost-user-vga device is necessary. Signed-off-by: Marc-André Lureau Reviewed-by: Ján Tomko --- src/qemu/qemu_domain.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_domain.c

[libvirt] [PATCH v5 05/20] qemu-cgroup: allow accel rendernode access

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Ján Tomko --- src/qemu/qemu_cgroup.c | 28 1 file changed, 28 insertions(+) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index ecd96efb0a..740a1b33dc 100644 ---

[libvirt] [PATCH v5 06/20] qemu: add vhost-user-gpu capabilities checks

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Those new devices are available since QEMU 4.1. Signed-off-by: Marc-André Lureau Reviewed-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 6 ++ src/qemu/qemu_capabilities.h | 4

[libvirt] [PATCH v5 08/20] qemu: validate virtio-gpu with vhost-user

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Check qemu capability, and accept 3d acceleration. 3d acceleration support is checked when looking for a suitable vhost-user helper. Signed-off-by: Marc-André Lureau Reviewed-by: Cole Robinson --- src/qemu/qemu_process.c | 57 +++-

[libvirt] [PATCH v5 00/20] Hi,

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau This series adds support for running virtio GPUs in seperate processes, thanks to vhost-user backend. The QEMU support landed for 4.1. There are several benefits of running the GPU/virgl in an external process, since Mesa is rather heavy on the qemu main loop, and may

[libvirt] [PATCH v5 01/20] qemu: generalize qemuFetchConfigs

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau The same config files disovery & priority rules are used for vhost-user backends. No functional change, the only difference is that qemuInteropFetchConfigs() takes a "name" argument and construct paths with it (ex: "firmware"). Signed-off-by: Marc-André Lureau

[libvirt] [PATCH v5 03/20] conf: format/parse/rng/docs for video

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Accept a new driver name attribute to specify usage of helper process, ex: Signed-off-by: Marc-André Lureau Reviewed-by: Ján Tomko --- docs/formatdomain.html.in | 12 ++- docs/schemas/domaincommon.rng | 8 +

[libvirt] [PATCH v5 04/20] domain: add rendernode attribute on

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau vhost-user-gpu helper takes --render-node option to specify on which GPU should the renderning be done. Signed-off-by: Marc-André Lureau Reviewed-by: Ján Tomko --- docs/formatdomain.html.in | 6 ++ docs/schemas/domaincommon.rng | 5

[libvirt] [PATCH v5 02/20] qemu-interop: ignore non-readable directories

2019-09-23 Thread marcandre . lureau
From: Marc-André Lureau Whether a directory is missing or is not readable doesn't make much difference when populating the available configs. This removes errors when firmare or vhost-user config is looked up from a user session libvirt if /etc/libvirt is not readable for ex. Signed-off-by:

Re: [libvirt] [jenkins-ci PATCH] jenkins: Remove meson-syntax-check job

2019-09-23 Thread Andrea Bolognani
On Mon, 2019-09-23 at 12:10 +0200, Fabiano Fidêncio wrote: > On Thu, Sep 19, 2019 at 11:11 AM Pavel Hrdina wrote: > > Instead of removing the syntax-check job we can keep it if we use > > 'suite' labels for our tests in a way that we would use 'syntax' label > > for syntax-check tests and 'unit'

Re: [libvirt] [jenkins-ci PATCH] jenkins: Remove meson-syntax-check job

2019-09-23 Thread Pavel Hrdina
On Mon, Sep 23, 2019 at 12:10:21PM +0200, Fabiano Fidêncio wrote: > On Thu, Sep 19, 2019 at 11:11 AM Pavel Hrdina wrote: > > > > On Wed, Sep 18, 2019 at 06:19:54PM +0200, Fabiano Fidêncio wrote: > > > It's been agreed that the projects using libvirt-jenkins-ci would have > > > the `syntax-check`

Re: [libvirt] [PATCH] docs: kbase: Add a section explaining how to verify SEV from the guest

2019-09-23 Thread Daniel P . Berrangé
On Mon, Sep 23, 2019 at 12:32:15PM +0200, Erik Skultety wrote: > On Mon, Sep 23, 2019 at 11:06:34AM +0100, Daniel P. Berrangé wrote: > > On Fri, Sep 20, 2019 at 01:47:09PM +0200, Erik Skultety wrote: > > > Commit 50dfabbb59 forgot to add this important bit on how to check that > > > all the

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Pavel Hrdina
On Mon, Sep 23, 2019 at 12:31:34PM +0200, Andrea Bolognani wrote: > On Mon, 2019-09-23 at 11:02 +0100, Daniel P. Berrangé wrote: > > On Mon, Sep 23, 2019 at 11:59:01AM +0200, Andrea Bolognani wrote: > > > For what it's worth, I also prefer 'syntax': the -check suffix is > > > useful for make

Re: [libvirt] [PATCH] docs: kbase: Add a section explaining how to verify SEV from the guest

2019-09-23 Thread Erik Skultety
On Mon, Sep 23, 2019 at 11:06:34AM +0100, Daniel P. Berrangé wrote: > On Fri, Sep 20, 2019 at 01:47:09PM +0200, Erik Skultety wrote: > > Commit 50dfabbb59 forgot to add this important bit on how to check that > > all the changes to the XML actually worked. > > --- > >

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Andrea Bolognani
On Mon, 2019-09-23 at 11:02 +0100, Daniel P. Berrangé wrote: > On Mon, Sep 23, 2019 at 11:59:01AM +0200, Andrea Bolognani wrote: > > For what it's worth, I also prefer 'syntax': the -check suffix is > > useful for make because it highlights that you're verifying some > > property of the program,

Re: [libvirt] [PATCH v4 14/20] qemu: add vhost-user-gpu helper unit

2019-09-23 Thread Ján Tomko
On Mon, Sep 23, 2019 at 02:16:37PM +0400, Marc-André Lureau wrote: Hi On Sat, Sep 21, 2019 at 1:05 AM Cole Robinson wrote: On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Similar to the qemu_tpm.c, add a unit with a few functions to > start/stop and

Re: [libvirt] [PATCH] qemu: fix operation job association when qemuCaps is NULL.

2019-09-23 Thread Jiri Denemark
On Sat, Sep 21, 2019 at 13:55:22 -0300, jcfara...@gmail.com wrote: > From: Julio Faracco > > Function qemuMigrationEatCookie() calls > qemuMigrationCookieXMLParseStr(), when qemuCaps is not set, function > assumes priv as a NULL pointer. At the end, function tries to set > job info operation to

Re: [libvirt] [PATCH v4 14/20] qemu: add vhost-user-gpu helper unit

2019-09-23 Thread Marc-André Lureau
Hi On Sat, Sep 21, 2019 at 1:05 AM Cole Robinson wrote: > > On 9/13/19 8:50 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Similar to the qemu_tpm.c, add a unit with a few functions to > > start/stop and setup the cgroup of the external vhost-user-gpu > > process.

Re: [libvirt] [PATCH] docs: attempt to document the general libvirt dev strategy

2019-09-23 Thread Daniel P . Berrangé
On Fri, Sep 20, 2019 at 07:33:08PM +0200, Pavel Hrdina wrote: > On Fri, Sep 20, 2019 at 03:12:01PM +0100, Daniel P. Berrangé wrote: > > There are various ideas / plans floating around for future libvirt work, > > some of which is actively in progress. Historically we've never captured > > this

Re: [libvirt] [jenkins-ci PATCH] jenkins: Remove meson-syntax-check job

2019-09-23 Thread Fabiano Fidêncio
On Thu, Sep 19, 2019 at 11:11 AM Pavel Hrdina wrote: > > On Wed, Sep 18, 2019 at 06:19:54PM +0200, Fabiano Fidêncio wrote: > > It's been agreed that the projects using libvirt-jenkins-ci would have > > the `syntax-check` running as part of their test suite. Therefore, > > there's no reason for

Re: [libvirt] [PATCH] docs: kbase: Add a section explaining how to verify SEV from the guest

2019-09-23 Thread Daniel P . Berrangé
On Fri, Sep 20, 2019 at 01:47:09PM +0200, Erik Skultety wrote: > Commit 50dfabbb59 forgot to add this important bit on how to check that > all the changes to the XML actually worked. > --- > docs/kbase/launch_security_sev.html.in | 12 > 1 file changed, 12 insertions(+) > > diff

[libvirt] [PATCH] clarify the xml example for NVDIMM more clealy

2019-09-23 Thread Luyao Zhong
The NVDIMM backend file can be a normal file or a real device file, Current xml example and explainations may mislead users. So add more info about the NVDIMM related elements and update the xml examples. Signed-off-by: Luyao Zhong --- docs/formatdomain.html.in | 9 ++--- 1 file changed, 6

Re: [libvirt] [dbus PATCH v2] build: convert to Meson/Ninja build system

2019-09-23 Thread Daniel P . Berrangé
On Mon, Sep 23, 2019 at 11:59:01AM +0200, Andrea Bolognani wrote: > On Mon, 2019-09-23 at 10:17 +0200, Pavel Hrdina wrote: > > On Sat, Sep 21, 2019 at 09:22:38AM +0200, Fabiano Fidêncio wrote: > > > One last things here (thanks, Pavel, for pointing this out), I'd > > > prefer the 'syntax' suite

  1   2   >