Re: [libvirt PATCH 05/10] conf: parse/format

2020-02-18 Thread Laine Stump
On 2/18/20 12:39 PM, Ján Tomko wrote: On Sun, Feb 16, 2020 at 11:22:54PM -0500, Laine Stump wrote: This is a very simple thing to parse and format, but needs to be done in 4 places, so two trivial utility functions have been made that can be called from all the higher level parser/formatters:  

Re: [libvirt PATCH 07/10] qemu/lxc: plumb isolatedPort from config down through bridge attachment

2020-02-18 Thread Laine Stump
On 2/18/20 12:46 PM, Ján Tomko wrote: On Sun, Feb 16, 2020 at 11:22:56PM -0500, Laine Stump wrote: This patch pushes the isolatedPort setting from the down all the way to the callers of virNetDevBridgeAddPort(), and sets BR_ISOLATED on the port (using virNetDevBridgePortSetIsolated()) after

Re: [libvirt PATCH 5/6] Make PATHs unique for a VM object instance

2020-02-18 Thread Shaju Abraham
On 2/11/20, 7:06 PM, "Daniel P. Berrangé" wrote: On Tue, Feb 11, 2020 at 10:05:53AM +0100, Martin Kletzander wrote: > > On Wed, Feb 05, 2020 at 05:32:50PM +, Daniel P. Berrangé wrote: > > > On Mon, Feb 03, 2020 at 12:43:32PM +, Daniel P. Berrangé wrote: > > > > From:

Re: virtlogd spinning on 100% CPU with the latest libvirt

2020-02-18 Thread Ján Tomko
On Tue, Feb 18, 2020 at 08:34:53PM +0100, Andrea Bolognani wrote: [Dropped Peter from CC. Please don't CC individual developers unless they've explicitly requested that you do so.] On Mon, 2020-02-17 at 17:50 +, Richard W.M. Jones wrote: Build libvirt from git (ccf7567329f). Using the

[libvirt RFC PATCH] util: vireventglibwatch: watch for G_IO_HUP and G_IO_ERR

2020-02-18 Thread Ján Tomko
To more closely match the previous usage in virEventPollDispatchHandles, where called the handle callback for any revents returned by poll. This should fix the virtlogd error on subsequent domain startup: error: can't connect to virtlogd: Cannot open log file:

[libvirt PATCH] docs: Expand documentation for the tickpolicy timer attribute

2020-02-18 Thread Andrea Bolognani
The current documentation is fairly terse and not easy to decode for someone who's not intimately familiar with the inner workings of timer devices. Expand on it by providing a somewhat verbose description of what behavior each policy will result in, as seen from both the guest OS and host point

Re: virtlogd spinning on 100% CPU with the latest libvirt

2020-02-18 Thread Andrea Bolognani
[Dropped Peter from CC. Please don't CC individual developers unless they've explicitly requested that you do so.] On Mon, 2020-02-17 at 17:50 +, Richard W.M. Jones wrote: > Build libvirt from git (ccf7567329f). > > Using the libvirt ‘run’ script, run something like > libguestfs-test-tool.

Re: [libvirt PATCH] docs: reduce excessive spacing in ToC for RST files

2020-02-18 Thread Ján Tomko
On Fri, Feb 07, 2020 at 04:05:02PM +, Daniel P. Berrangé wrote: The table of contents in the RST based files uses tags inside the , which results in 1em's worth of spacing above & below each entry. This results in way too much whitespace in the ToC. Signed-off-by: Daniel P. Berrangé ---

Re: [libvirt PATCH 10/10] docs: add info about to news file

2020-02-18 Thread Ján Tomko
On Sun, Feb 16, 2020 at 11:22:59PM -0500, Laine Stump wrote: Signed-off-by: Laine Stump --- docs/news.xml | 21 + 1 file changed, 21 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 09/10] conf: extra validation for

2020-02-18 Thread Ján Tomko
On Sun, Feb 16, 2020 at 11:22:58PM -0500, Laine Stump wrote: During the hypervisor-agnostic validation of network devices, verify that the interface type is either "network" or "bridge", and that if there is any , that it doesn't have any type associated with it. This needs to be done both for

Re: [libvirt PATCH 08/10] qemu: support updating during device update

2020-02-18 Thread Ján Tomko
On Sun, Feb 16, 2020 at 11:22:57PM -0500, Laine Stump wrote: This setting can be updating very easily on an already active interface by just changing it in sysfs. If the bridge used for connection is also changed, there is no need to separately update it, because the new setting isf done as a

Re: [libvirt PATCH 07/10] qemu/lxc: plumb isolatedPort from config down through bridge attachment

2020-02-18 Thread Ján Tomko
On Sun, Feb 16, 2020 at 11:22:56PM -0500, Laine Stump wrote: This patch pushes the isolatedPort setting from the down all the way to the callers of virNetDevBridgeAddPort(), and sets BR_ISOLATED on the port (using virNetDevBridgePortSetIsolated()) after the port has been successfully added to

Re: [libvirt PATCH 06/10] network: propagate between network and domain

2020-02-18 Thread Ján Tomko
On Sun, Feb 16, 2020 at 11:22:55PM -0500, Laine Stump wrote: Similar to the way that the , , and elements and the trustGuestRxFilters attribute in a (or in the appropriate element of a can be applied to a port when it is allocated for a domain's network interface, this patch checks for a

Re: [libvirt PATCH 05/10] conf: parse/format

2020-02-18 Thread Ján Tomko
On Sun, Feb 16, 2020 at 11:22:54PM -0500, Laine Stump wrote: This is a very simple thing to parse and format, but needs to be done in 4 places, so two trivial utility functions have been made that can be called from all the higher level parser/formatters: (only in domain status)