[libvirt PATCH] qemu: fix response timeout for agent guest-sync

2020-03-20 Thread Jonathon Jongsma
The agent 'guest-sync' command historically had a 5s response timeout which was different from other agent commands, which waited forever. When we added the ability to customize the response timeout for guest agent commands, we intended to continue to use 5s for 'guest-sync' when the user

[PATCH v2 2/4] qemu: capabilities: add QEMU_CAPS_VIRTFS_MULTIDEVS

2020-03-20 Thread Christian Schoenebeck
The QEMU 9pfs 'multidevs' option exists since QEMU 4.2, so just set this capability based on that QEMU version. Signed-off-by: Christian Schoenebeck --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 +

[PATCH v2 4/4] qemu: add support for 'multidevs' option

2020-03-20 Thread Christian Schoenebeck
This option prevents misbehaviours on guest if a qemu 9pfs export contains multiple devices, due to the potential file ID collisions this otherwise may cause. Signed-off-by: Christian Schoenebeck --- src/qemu/qemu_command.c | 7 +++ src/qemu/qemu_domain.c | 12 2 files

[PATCH v2 1/4] docs: virtfs: add section separators

2020-03-20 Thread Christian Schoenebeck
Signed-off-by: Christian Schoenebeck --- docs/formatdomain.html.in | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 594146009d..cc2c671c14 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4084,13

[PATCH v2 3/4] conf: add 'multidevs' option

2020-03-20 Thread Christian Schoenebeck
Introduce new 'multidevs' option for filesystem. This option prevents misbehaviours on guest if a qemu 9pfs export contains multiple devices, due to the potential file ID collisions this otherwise may cause. Signed-off-by: Christian Schoenebeck --- docs/formatdomain.html.in

[PATCH v2 0/4] add support for QEMU 9pfs 'multidevs' option

2020-03-20 Thread Christian Schoenebeck
QEMU 4.2 added a new option 'multidevs' for 9pfs. The following patch adds support for this new option to libvirt. In short, what is this about: to distinguish files uniquely from each other in general, numeric file IDs are typically used for comparison, which in practice is the combination of a

Re: [libvirt PATCH 4/5] gitlab: add several native CI jobs

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 06:13:13PM +0100, Andrea Bolognani wrote: > On Tue, 2020-03-10 at 10:09 +, Daniel P. Berrangé wrote: > > With GitLab CI aiming to replace Jenkins and Travis for CI purposes, we > > need to expand the coverage to include native builds. This patch adds > > all the jobs

Re: [libvirt PATCH 1/5] gitlab: use CI for building website contents

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 06:07:47PM +0100, Andrea Bolognani wrote: > On Tue, 2020-03-10 at 10:09 +, Daniel P. Berrangé wrote: > > +# This artifact published by this job is downloaded by libvirt.org to > > +# be deployed to the web root: > > +# > >

Re: [libvirt PATCH 4/5] gitlab: add several native CI jobs

2020-03-20 Thread Andrea Bolognani
On Tue, 2020-03-10 at 10:09 +, Daniel P. Berrangé wrote: > With GitLab CI aiming to replace Jenkins and Travis for CI purposes, we > need to expand the coverage to include native builds. This patch adds > all the jobs currently run in Travis. Compared to Jenkins we obviously > miss the FreeBSD

Re: [libvirt PATCH 1/5] gitlab: use CI for building website contents

2020-03-20 Thread Andrea Bolognani
On Tue, 2020-03-10 at 10:09 +, Daniel P. Berrangé wrote: > +# This artifact published by this job is downloaded by libvirt.org to > +# be deployed to the web root: > +# > https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=website > +website: > + script: > +- mkdir

[PATCH] util: authconfig: use g_key_file_*

2020-03-20 Thread Rafael Fonseca
Replace libvirt's virKeyFile by glib's GKeyFile. Signed-off-by: Rafael Fonseca --- src/util/virauthconfig.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/src/util/virauthconfig.c b/src/util/virauthconfig.c index fd846ddd4b..473b4c76d6 100644 ---

Re: [libvirt PATCH 0/4] src: add configurable support for cgroups usage

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 05:42:57PM +0100, Pavel Hrdina wrote: > On Fri, Mar 20, 2020 at 03:59:41PM +, Daniel P. Berrangé wrote: > > On Fri, Mar 20, 2020 at 04:48:58PM +0100, Pavel Hrdina wrote: > > > On Fri, Mar 20, 2020 at 03:39:58PM +, Daniel P. Berrangé wrote: > > > > On Fri, Mar 20,

Re: [libvirt PATCH 0/4] src: add configurable support for cgroups usage

2020-03-20 Thread Pavel Hrdina
On Fri, Mar 20, 2020 at 03:59:41PM +, Daniel P. Berrangé wrote: > On Fri, Mar 20, 2020 at 04:48:58PM +0100, Pavel Hrdina wrote: > > On Fri, Mar 20, 2020 at 03:39:58PM +, Daniel P. Berrangé wrote: > > > On Fri, Mar 20, 2020 at 04:30:07PM +0100, Pavel Hrdina wrote: > > > > On Fri, Mar 20,

[libvirt PATCH] docs: virtiofs: add missing aposthrophe

2020-03-20 Thread Ján Tomko
Signed-off-by: Ján Tomko Reported-by: Dr. David Alan Gilbert --- I pushed this on Monday, but forgot to send the e-mail. docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index

Re: [libvirt PATCH 0/4] src: add configurable support for cgroups usage

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 04:48:58PM +0100, Pavel Hrdina wrote: > On Fri, Mar 20, 2020 at 03:39:58PM +, Daniel P. Berrangé wrote: > > On Fri, Mar 20, 2020 at 04:30:07PM +0100, Pavel Hrdina wrote: > > > On Fri, Mar 20, 2020 at 01:40:10PM +, Daniel P. Berrangé wrote: > > > > This simple series

Re: [libvirt PATCH 0/4] src: add configurable support for cgroups usage

2020-03-20 Thread Pavel Hrdina
On Fri, Mar 20, 2020 at 03:39:58PM +, Daniel P. Berrangé wrote: > On Fri, Mar 20, 2020 at 04:30:07PM +0100, Pavel Hrdina wrote: > > On Fri, Mar 20, 2020 at 01:40:10PM +, Daniel P. Berrangé wrote: > > > This simple series allows apps to choose how cgroups are managed by > > > libvirt,

Re: [libvirt PATCH 3/4] qemu: wire up support for controlling use of cgroups backend

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 04:42:46PM +0100, Ján Tomko wrote: > On a Friday in 2020, Daniel P. Berrangé wrote: > > Currently the QEMU driver chooses between systemd machined and > > direct cgroups usage of privileged, and does not use either when > > unprivileged. > > > > This wires up support for

Re: [libvirt PATCH 3/4] qemu: wire up support for controlling use of cgroups backend

2020-03-20 Thread Ján Tomko
On a Friday in 2020, Daniel P. Berrangé wrote: Currently the QEMU driver chooses between systemd machined and direct cgroups usage of privileged, and does not use either when unprivileged. This wires up support for the new backend choice introduced by the earlier commits, allowing apps to

Re: [libvirt PATCH 0/4] src: add configurable support for cgroups usage

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 04:30:07PM +0100, Pavel Hrdina wrote: > On Fri, Mar 20, 2020 at 01:40:10PM +, Daniel P. Berrangé wrote: > > This simple series allows apps to choose how cgroups are managed by > > libvirt, between cgroupfs and machined, or disabled entirely. > > I'm not so sure about

Re: [libvirt PATCH 0/4] src: add configurable support for cgroups usage

2020-03-20 Thread Pavel Hrdina
On Fri, Mar 20, 2020 at 01:40:10PM +, Daniel P. Berrangé wrote: > This simple series allows apps to choose how cgroups are managed by > libvirt, between cgroupfs and machined, or disabled entirely. I'm not so sure about this series. The situation with cgroups and systemd is a bit more

Re: [libvirt PATCH 4/5] gitlab: add several native CI jobs

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 04:18:58PM +0100, Erik Skultety wrote: > On Fri, Mar 20, 2020 at 02:59:36PM +, Daniel P. Berrangé wrote: > > On Fri, Mar 20, 2020 at 03:52:15PM +0100, Erik Skultety wrote: > > > On Tue, Mar 10, 2020 at 10:09:44AM +, Daniel P. Berrangé wrote: > > > > With GitLab CI

Re: [libvirt PATCH 3/5] gitlab: group jobs into stages

2020-03-20 Thread Erik Skultety
On Tue, Mar 10, 2020 at 10:09:43AM +, Daniel P. Berrangé wrote: > Within a stage all jobs run in parallel. Stages are ordered so later > stages are only executed if previous stages succeeded. By using separate > stages for the cross builds, we can avoid wasting CI resources if the > relatively

Re: [libvirt PATCH 4/5] gitlab: add several native CI jobs

2020-03-20 Thread Erik Skultety
On Fri, Mar 20, 2020 at 02:59:36PM +, Daniel P. Berrangé wrote: > On Fri, Mar 20, 2020 at 03:52:15PM +0100, Erik Skultety wrote: > > On Tue, Mar 10, 2020 at 10:09:44AM +, Daniel P. Berrangé wrote: > > > With GitLab CI aiming to replace Jenkins and Travis for CI purposes, we > > > need to

Re: [libvirt PATCH 5/5] gitlab: rename the cross build jobs

2020-03-20 Thread Erik Skultety
On Tue, Mar 10, 2020 at 10:09:45AM +, Daniel P. Berrangé wrote: > The pipeline UI will truncate the names of jobs after about 15 > characters. As a result with the cross-builds, we truncate the > most important part of the job name. Putting the most important > part first is robust against

Re: [libvirt PATCH 2/5] gitlab: reduce number of cross-build CI jobs

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 03:57:40PM +0100, Erik Skultety wrote: > On Tue, Mar 10, 2020 at 10:09:42AM +, Daniel P. Berrangé wrote: > > We're going to add more build jobs to CI, and users have limited time > > granted on the shared CI runners. The number of cross-build jobs > > currently present

Re: [libvirt PATCH 4/5] gitlab: add several native CI jobs

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 03:52:15PM +0100, Erik Skultety wrote: > On Tue, Mar 10, 2020 at 10:09:44AM +, Daniel P. Berrangé wrote: > > With GitLab CI aiming to replace Jenkins and Travis for CI purposes, we > > need to expand the coverage to include native builds. This patch adds > > all the

Re: [libvirt PATCH 2/5] gitlab: reduce number of cross-build CI jobs

2020-03-20 Thread Erik Skultety
On Tue, Mar 10, 2020 at 10:09:42AM +, Daniel P. Berrangé wrote: > We're going to add more build jobs to CI, and users have limited time > granted on the shared CI runners. The number of cross-build jobs > currently present is not sustainable, so cut it down to two interesting > jobs to cover

Re: [libvirt PATCH 4/5] gitlab: add several native CI jobs

2020-03-20 Thread Erik Skultety
On Tue, Mar 10, 2020 at 10:09:44AM +, Daniel P. Berrangé wrote: > With GitLab CI aiming to replace Jenkins and Travis for CI purposes, we > need to expand the coverage to include native builds. This patch adds > all the jobs currently run in Travis. Compared to Jenkins we obviously > miss the

[libvirt PATCH] api: disallow virDomainAgentSetResponseTimeout() on read-only connections

2020-03-20 Thread Jonathon Jongsma
This function changes the amount of time that libvirt waits for a response from the guest agent for all guest agent commands. Since this is a configuration change, it should not be allowed on read-only connections. Signed-off-by: Jonathon Jongsma --- src/libvirt-domain.c | 2 ++ 1 file changed,

Re: [PATCH v2 3/5] conf, qemu: enable NVDIMM support for ppc64

2020-03-20 Thread Daniel Henrique Barboza
On 3/20/20 4:53 AM, Shivaprasad bhat wrote: On Thu, Mar 12, 2020 at 3:00 AM Daniel Henrique Barboza wrote: Using the 'uuid' element for ppc64 NVDIMM memory added in the previous patch, use it in qemuBuildMemoryDeviceStr() to pass it over to QEMU. Another ppc64 restriction is the necessity

Re: listen type socket support for rdp graphics

2020-03-20 Thread Vasiliy Tolstov
Ok Thanks! I'm read docs and think that tdp is also supported =). пт, 20 мар. 2020 г. в 12:51, Daniel P. Berrangé : > On Fri, Mar 20, 2020 at 04:05:46AM +0300, Vasiliy Tolstov wrote: > > Hi! How hard implement listen type socket support for rdp graphics? VNC > and > > SPICE already have such

[libvirt PATCH 3/4] qemu: wire up support for controlling use of cgroups backend

2020-03-20 Thread Daniel P . Berrangé
Currently the QEMU driver chooses between systemd machined and direct cgroups usage of privileged, and does not use either when unprivileged. This wires up support for the new backend choice introduced by the earlier commits, allowing apps to override the default logic in the driver when

[libvirt PATCH 4/4] lxc: wire up support for controlling use of cgroups backend

2020-03-20 Thread Daniel P . Berrangé
Currently the LXC driver chooses between systemd machined and direct cgroups usage. This wires up support for the new backend choice introduced by the earlier commits, allowing apps to override the default logic in the driver. This reverts commit c32a7de7d8f81384b17dbe529c6d3b3ac13c631d. ---

[libvirt PATCH 1/4] conf: allow different resource registration modes

2020-03-20 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Currently the QEMU driver has three ways of setting up cgroups. It either skips them entirely (if non-root), or uses systemd-machined, or uses cgroups directly. This change adds ability to configure the mechanism for registering resources between all these options

[libvirt PATCH 0/4] src: add configurable support for cgroups usage

2020-03-20 Thread Daniel P . Berrangé
This simple series allows apps to choose how cgroups are managed by libvirt, between cgroupfs and machined, or disabled entirely. Daniel P. Berrangé (4): conf: allow different resource registration modes util: allow choice between machined or direct cgroups filesystem qemu: wire up support

[libvirt PATCH 2/4] util: allow choice between machined or direct cgroups filesystem

2020-03-20 Thread Daniel P . Berrangé
The cgroups code currently tries to use machined and then falls back to using the cgroups filesystem directly. This introduces a new enum that allows callers to have explicit control over which impl is used. Signed-off-by: Daniel P. Berrangé --- src/lxc/lxc_cgroup.c | 1 +

Re: [libvirt PATCH 0/5] gitlab: expand the CI job coverage (RESEND)

2020-03-20 Thread Daniel P . Berrangé
ping On Tue, Mar 10, 2020 at 10:09:40AM +, Daniel P. Berrangé wrote: > There are two main goals with this series > > - Introduce a minimal job building the website and publishing > an artifact which can be deployed onto libvirt.org > - Expanding CI jobs to get coverage closer to

[libvirt PATCH] qemu: ensure domain event thread is always stopped

2020-03-20 Thread Daniel P . Berrangé
In previous commit: commit e6afacb0feabd9bf58331aa0e5259a35378be74e Author: Daniel P. Berrangé Date: Wed Feb 12 12:26:11 2020 + qemu: start/stop an event loop thread for domains A bogus comment was added claiming we didn't need to shutdown the event thread in the

Re: [PATCH 6/6] security: Try harder to run transactions

2020-03-20 Thread Pavel Mores
On Wed, Mar 18, 2020 at 06:32:16PM +0100, Michal Privoznik wrote: > When a QEMU process dies in the middle of a hotplug, then we fail > to restore the seclabels on the device. The problem is that if > the thread doing hotplug locks the domain object first and thus > blocks the thread that wants to

Re: listen type socket support for rdp graphics

2020-03-20 Thread Daniel P . Berrangé
On Fri, Mar 20, 2020 at 04:05:46AM +0300, Vasiliy Tolstov wrote: > Hi! How hard implement listen type socket support for rdp graphics? VNC and > SPICE already have such options? > And does this support for rdp available for qemu driver? (I need to access > qemu vm via rdp) There is no support for

[RFC] Faster libvirtd restart with nwfilter rules, one more time

2020-03-20 Thread nshirokovskiy
Hi, all. Some time ago I posted RFC [1] concerning an issue of unresponsive libvird during restart if there is large number of VMs

Re: [PATCH] qemu: reset await_event in all error paths in qemuAgentCommand

2020-03-20 Thread Michal Prívozník
On 20. 3. 2020 8:16, Nikolay Shirokovskiy wrote: > A fixup to patch [1]. We need to reset await_event in all > error paths. > > [1] 52532073d : qemu: remove redundant needReply argument of qemuAgentCommand > > Signed-off-by: Nikolay Shirokovskiy > --- > src/qemu/qemu_agent.c | 2 +- > 1 file

Re: [PATCH 0/6] Parse back some legacy backing store strings

2020-03-20 Thread Michal Prívozník
On 19. 3. 2020 20:35, Peter Krempa wrote: > See patch 4 for code and 6 for what we try to parse back. > > Peter Krempa (6): > virBitmapNewEmpty: Use g_new0 to allocate and remove error checking > virJSONValueObjectDeflattenWorker: Refactor cleanup > util: json: Extract deflattening of keys

Re: [PATCH v2 3/5] conf, qemu: enable NVDIMM support for ppc64

2020-03-20 Thread Shivaprasad bhat
On Thu, Mar 12, 2020 at 3:00 AM Daniel Henrique Barboza wrote: > > Using the 'uuid' element for ppc64 NVDIMM memory added in the > previous patch, use it in qemuBuildMemoryDeviceStr() to pass > it over to QEMU. > > Another ppc64 restriction is the necessity of a mem->labelsize, > given than ppc64

[PATCH] qemu: reset await_event in all error paths in qemuAgentCommand

2020-03-20 Thread Nikolay Shirokovskiy
A fixup to patch [1]. We need to reset await_event in all error paths. [1] 52532073d : qemu: remove redundant needReply argument of qemuAgentCommand Signed-off-by: Nikolay Shirokovskiy --- src/qemu/qemu_agent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git