With libpmem support compiled into qemu it will trigger the following
denials on every startup.
apparmor="DENIED" operation="open" name="/"
apparmor="DENIED" operation="open" name="/sys/bus/nd/devices/"
This is due to [1] that tries to auto-detect if the platform supports
auto flush for all
On Wed, Apr 8, 2020 at 9:50 PM Jamie Strandboge wrote:
>
> On Wed, 08 Apr 2020, Jamie Strandboge wrote:
>
> > On Wed, 08 Apr 2020, Christian Ehrhardt wrote:
> >
> > > With libpmem support compiled into qemu it will trigger the following
> > > denials on every startup.
> > > apparmor="DENIED"
Signed-off-by: Erik Skultety
---
.../update/templates/gitlab-runner.service.j2 | 14 ++
1 file changed, 14 insertions(+)
create mode 100644 guests/playbooks/update/templates/gitlab-runner.service.j2
diff --git a/guests/playbooks/update/templates/gitlab-runner.service.j2
Based on
https://docs.gitlab.com/runner/install/freebsd.html#installing-gitlab-runner
Signed-off-by: Erik Skultety
---
.../update/templates/gitlab-runner.j2 | 31 +++
1 file changed, 31 insertions(+)
create mode 100644 guests/playbooks/update/templates/gitlab-runner.j2
Signed-off-by: Erik Skultety
---
guests/lcitool | 46 --
1 file changed, 44 insertions(+), 2 deletions(-)
diff --git a/guests/lcitool b/guests/lcitool
index 689a8cf..975a811 100755
--- a/guests/lcitool
+++ b/guests/lcitool
@@ -175,7 +175,7 @@ class
since v1:
- .bash_logout is removed from the user home environment (causes builds to fail
on Debian)
- gitlab-runner is now downloaded to and executed from user's bin/ directory
instead of using /usr/local/bin
- both RC and systemd service files now define the user explicitly that the init
With the recent efforts in upstream libvirt to centralize our CI on
gitlab, let's add a new gitlab-specific flavor along with related
playbook tasks. This flavour revolves around installing and configuring
the gitlab-runner agent binary which requires the per-project
registration token to be
As part of the users tasks, we remove the .profile file after we create
our own .bash_profile. As part of that effort, let's remove the .bash_logout
skeleton file as well, the reason being gitlab's runner agent which
has a hard time initializing a build environment on Debian where the
system
On Fri, 2020-04-03 at 17:03 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 03, 2020 at 05:15:28PM +0200, Rafael Fonseca wrote:
> > This patch series convert various simple instances of virObject to
> > a
> > GObject equivalent.
> >
> > virDomain is still WIP because it causes some linking problem
On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
> --- a/src/conf/virstorageobj.c
> +++ b/src/conf/virstorageobj.c
> @@ -1052,7 +1052,13 @@
> virStoragePoolObjVolumeListExport(virConnectPtr conn,
> return data.nvols;
>
> error:
> -virObjectListFree(data.vols);
> +if
On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
> @@ -482,14 +495,14 @@ virNetworkFinalize(GObject *obj)
> * @uuid: pointer to the uuid
> *
> * Allocates a new network port object. When the object is no longer
> needed,
> - * virObjectUnref() must be called in order to not leak
On Wed, Apr 8, 2020 at 11:12 PM Jonathon Jongsma wrote:
>
> On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
> > @@ -503,14 +503,13 @@ virNWFilterGetXMLDesc(virNWFilterPtr nwfilter,
> > unsigned int flags)
> > int
> > virNWFilterRef(virNWFilterPtr nwfilter)
> > {
> > -
On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
> @@ -503,14 +503,13 @@ virNWFilterGetXMLDesc(virNWFilterPtr nwfilter,
> unsigned int flags)
> int
> virNWFilterRef(virNWFilterPtr nwfilter)
> {
> -VIR_DEBUG("nwfilter=%p refs=%d", nwfilter,
> - nwfilter ?
On Wed, Apr 8, 2020 at 10:47 PM Jonathon Jongsma wrote:
>
> On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
> >
> > #define virCheckAdmServerReturn(obj, retval) \
> > do { \
> > -virAdmServerPtr _srv = (obj); \
> > -if (!virObjectIsClass(_srv, virAdmServerClass) ||
On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
> Signed-off-by: Rafael Fonseca
> ---
> src/admin/libvirt-admin.c| 2 +-
> src/admin/libvirt_admin_private.syms | 1 -
> src/datatypes.c | 36 ++--
>
> src/datatypes.h
On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
> Signed-off-by: Rafael Fonseca
> ---
> src/admin/libvirt-admin.c| 2 +-
> src/admin/libvirt_admin_private.syms | 1 -
> src/datatypes.c | 42 ++--
>
> src/datatypes.h
Hotplugging PCI devices to Xen PV guests is only possible if the
libxl_domain_build_info struct has the e820_host field enabled when the
guest is created. By default it is disabled but libxl will automatically
enable e820_host if the config contains one or more PCI devices, in which
case
On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
> Signed-off-by: Rafael Fonseca
> ---
> src/conf/domain_conf.c | 35 ---
> src/conf/domain_conf.h | 9 -
> src/qemu/qemu_domain.c | 7 ---
> src/qemu/qemu_process.c | 3 +--
>
Add support in the domXML<->native config converter for max_event_channels.
The parser and formater functions for max_grant_frames were reworked to
also parse max_event_channels. In doing so the xenbus controller is added
earlier in the config parsing, requiring a small adjustment to one of the
This series implements support Xen's max_event_channels setting as proposed
in this thread
https://www.redhat.com/archives/libvir-list/2020-April/msg00376.html
See the individual patches for details.
Jim Fehlig (3):
conf: Add a new xenbus controller option for event channels
libxl: Add
Add support for setting event_channels in libxl domain config object and
include a test to check that it is properly converted from XML to libxl
domain config.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_conf.c| 14 +--
.../max-eventchannels-hvm.json|
Event channels are like PV interrupts and in conjuction with grant frames
form a data transfer mechanism for PV drivers. They are also used for
inter-processor interrupts. Guests with a large number of vcpus and/or
many PV devices many need to increase the maximum default value of 1023.
For this
On Wed, 08 Apr 2020, Jamie Strandboge wrote:
> On Wed, 08 Apr 2020, Christian Ehrhardt wrote:
>
> > With libpmem support compiled into qemu it will trigger the following
> > denials on every startup.
> > apparmor="DENIED" operation="open" name="/"
> > apparmor="DENIED" operation="open"
From: Marc-André Lureau
External devices are started before cgroup is created. Add the DBus
daemon to the VM cgroup with the rest of the external devices.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_dbus.c | 24
src/qemu/qemu_dbus.h | 3 +++
From: Marc-André Lureau
The file doesn't use virSystemd functions directly.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 2afe22f177..2e019b64af 100644
---
From: Marc-André Lureau
Allow calling qemuDBusStart() multiple times (as may be done by
qemu-slirp already).
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_dbus.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c
index
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_dbus.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c
index ae55bbb299..02dc3ebf07 100644
--- a/src/qemu/qemu_dbus.c
+++ b/src/qemu/qemu_dbus.c
@@ -142,13 +142,11 @@
From: Marc-André Lureau
Don't stop the DBus daemon if a slirp helper failed to start, as it
may be shared with other helpers.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_slirp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_slirp.c
From: Marc-André Lureau
The slirp helper process should be associated with the VM cgroup, like
other helpers.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_extdevice.c | 8
src/qemu/qemu_slirp.c | 14 ++
src/qemu/qemu_slirp.h | 3 +++
3 files changed, 25
From: Marc-André Lureau
Hi,
Here is a subset of the series posted earlier "RFC: basic CGroup
support with qemu:///session", as requested by Pavel.
Marc-André Lureau (6):
slirp: leave the dbus daemon running on error
slirp: add helper to VM cgroup
qemu-dbus: prevent double start of the
On Wed, Apr 08, 2020 at 07:05:17PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-04-08 at 16:21 +0100, Daniel P. Berrangé wrote:
> > +++ b/docs/Makefile.am
> > @@ -429,6 +429,10 @@ manpages/%.html.in: manpages/%.rst
> > %.html.tmp: %.html.in site.xsl subsite.xsl page.xsl \
> >
On Wed, 2020-04-08 at 16:21 +0100, Daniel P. Berrangé wrote:
> +++ b/docs/Makefile.am
> @@ -429,6 +429,10 @@ manpages/%.html.in: manpages/%.rst
> %.html.tmp: %.html.in site.xsl subsite.xsl page.xsl \
> $(acl_generated)
> $(AM_V_GEN)name=`echo $@ | sed -e 's/.tmp//'`; \
> +
The libvirt project has alot of git repositories, and they must all be
configured in the same way, more or less. This page documents the
settings changes that I have made in GitLab and GitHub when configuring
projects, both as a reminder for myself, and to help anyone else doing
the same in
On Wed, 08 Apr 2020, Christian Ehrhardt wrote:
> With libpmem support compiled into qemu it will trigger the following
> denials on every startup.
> apparmor="DENIED" operation="open" name="/"
> apparmor="DENIED" operation="open" name="/sys/bus/nd/devices/"
>
> This is due to [1] that tries
On Wed, Apr 08, 2020 at 06:08:59PM +0200, Ján Tomko wrote:
> On a Wednesday in 2020, Daniel P. Berrangé wrote:
> > To encourage contributors to make changes to the main website, add a
> > footer link to every page which links to the corresponding source file
> > in git. With gitlab, they are able
Ján Tomko [2020-04-08, 04:28PM +0200]:
> On a Monday in 2020, Bjoern Walk wrote:
> > Reviewed-by: Boris Fiuczynski
> > Signed-off-by: Bjoern Walk
> > ---
> > docs/formatdomain.html.in | 10 ++
> > 1 file changed, 10 insertions(+)
> >
>
> Reviewed-by: Ján Tomko
> and pushed
And thanks
On Wed, 2020-04-08 at 15:56 +0200, Erik Skultety wrote:
> On Wed, Apr 08, 2020 at 03:21:00PM +0200, Andrea Bolognani wrote:
> > I guess you could drop the image element and replace it with
> >
> > tags:
> > - fedora-31
>
> ^This is what I had in mind
>
> > but then you'd either have to
On a Wednesday in 2020, Daniel P. Berrangé wrote:
To encourage contributors to make changes to the main website, add a
footer link to every page which links to the corresponding source file
in git. With gitlab, they are able to edit content directly in the web
browser and then submit a merge
On Wed, 2020-04-08 at 16:03 +0100, Daniel P. Berrangé wrote:
> This naming clash has hit me several times, so I don't want to
> make it worse by creating super generic names for libvirt repos.
I clearly don't feel the same way, but I also don't feel strongly
enough about the topic to keep arguing
On Tue, Apr 07, 2020 at 17:36:18 +0200, Ján Tomko wrote:
> On a Friday in 2020, Jiri Denemark wrote:
> >CPU models defined in the cpu_map can use signature/@stepping attribute
> >to match a limited set of stepping numbers. The value is a bitmap for
> >bits 0..15 each corresponding to a single
Ideally I would like to decomission the current wiki.libvirt.org
site. It is based on mediawiki running on openshift and has myself
as a single point of failure.
GitLab provides a wiki, but I don't think we need to use that
either, as I think that it is desirable to bring the content into
our
To encourage contributors to make changes to the main website, add a
footer link to every page which links to the corresponding source file
in git. With gitlab, they are able to edit content directly in the web
browser and then submit a merge request. This gives a way to contribute
content that is
On Wed, Apr 08, 2020 at 04:54:17PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-04-08 at 15:26 +0100, Daniel P. Berrangé wrote:
> > On Wed, Apr 08, 2020 at 04:21:31PM +0200, Andrea Bolognani wrote:
> > > On Wed, 2020-04-08 at 12:54 +0100, Daniel P. Berrangé wrote:
> > > > +- docker push
With libpmem support compiled into qemu it will trigger the following
denials on every startup.
apparmor="DENIED" operation="open" name="/"
apparmor="DENIED" operation="open" name="/sys/bus/nd/devices/"
This is due to [1] that tries to auto-detect if the platform supports
auto flush for all
On Wed, 2020-04-08 at 15:26 +0100, Daniel P. Berrangé wrote:
> On Wed, Apr 08, 2020 at 04:21:31PM +0200, Andrea Bolognani wrote:
> > On Wed, 2020-04-08 at 12:54 +0100, Daniel P. Berrangé wrote:
> > > +- docker push ${CI_REGISTRY_IMAGE}/${NAME}:${CI_COMMIT_REF_SLUG}
> >
> > I'm not super happy
On 08.04.2020 16:08, Don Koch wrote:
> On Wed, 8 Apr 2020 10:34:08 +0300
> nshirokovskiy wrote:
>
>>
>>
>> On 07.04.2020 20:31, Don Koch wrote:
>>> On Thu, 19 Dec 2019 13:50:19 +0300
>>> Nikolay Shirokovskiy wrote:
>>>
If we use fake reboot then domain goes thru running->shutdown->running
On a Monday in 2020, Bjoern Walk wrote:
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
docs/formatdomain.html.in | 10 ++
1 file changed, 10 insertions(+)
Reviewed-by: Ján Tomko
and pushed
Jano
signature.asc
Description: PGP signature
On Wed, Apr 08, 2020 at 04:21:31PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-04-08 at 12:54 +0100, Daniel P. Berrangé wrote:
> > This builds a container image containing the DCO checking script.
> > It is then published at:
> >
> >
On Wed, 2020-04-08 at 12:54 +0100, Daniel P. Berrangé wrote:
> This builds a container image containing the DCO checking script.
> It is then published at:
>
>registry.gitlab.com/libvirt/libvirt-jenkins-ci/check-dco:master
>
> from where it can be used in all other project repositories. This
On a Monday in 2020, Peter Krempa wrote:
We always tried to install backing store for the image even if it didn't
make sesne, e.g. for a full backup into a raw image. Additionally we
sense
didn't record the backing file into the qcow2 metadata so the image
itself contained the diff of data
On Wed, Apr 08, 2020 at 03:21:00PM +0200, Andrea Bolognani wrote:
> On Wed, 2020-04-08 at 12:28 +0200, Erik Skultety wrote:
> > On Wed, Apr 08, 2020 at 12:05:11PM +0200, Andrea Bolognani wrote:
> > > You didn't answer in the other thread, so I'll ask again here: is the
> > > idea that we're going
On Wed, 2020-04-08 at 12:28 +0200, Erik Skultety wrote:
> On Wed, Apr 08, 2020 at 12:05:11PM +0200, Andrea Bolognani wrote:
> > You didn't answer in the other thread, so I'll ask again here: is the
> > idea that we're going to use only the FreeBSD runners to supplement
> > the shared runners for
Ján Tomko [2020-04-08, 02:52PM +0200]:
> Reviewed-by: Ján Tomko
> and pushed now.
Thanks!
> Jano
signature.asc
Description: PGP signature
On Wed, 8 Apr 2020 10:34:08 +0300
nshirokovskiy wrote:
>
>
> On 07.04.2020 20:31, Don Koch wrote:
> > On Thu, 19 Dec 2019 13:50:19 +0300
> > Nikolay Shirokovskiy wrote:
> >
> >> If we use fake reboot then domain goes thru running->shutdown->running
> >> state changes with shutdown state only
On Wed, 2020-04-08 at 12:42 +0200, Erik Skultety wrote:
> On Wed, Apr 08, 2020 at 11:49:45AM +0200, Andrea Bolognani wrote:
> > On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote:
> > > -extra_vars = json.dumps({
> > > +extra_vars_d = {
> >
> > You don't really need to change
On a Monday in 2020, Bjoern Walk wrote:
Update s390x capabilities for QEMU 4.2 with the actual GA version for
QEMU and on the latest z15 machine.
This picks up the new blockdev capability, so we need to refresh a bunch
of test cases as well.
Acked-by: Christian Borntraeger
Reviewed-by: Peter
On a Wednesday in 2020, Rafael Fonseca wrote:
Unlike `waitpid`, `virProcessWait` only returns -1 (error) or 0
(success), so comparing that to `pid` will always be false and the
parent will report failure with:
error : main:851 : Failed to fork as daemon: No such file or directory
even though
On Wed, Apr 8, 2020 at 2:13 PM Rafael Fonseca wrote:
>
> Signed-off-by: Rafael Fonseca
> Reported-by: Marcin Krol
Only difference in v2 is the Reported-by: line
Att
--
Rafael Fonseca
Unlike `waitpid`, `virProcessWait` only returns -1 (error) or 0
(success), so comparing that to `pid` will always be false and the
parent will report failure with:
error : main:851 : Failed to fork as daemon: No such file or directory
even though the grandchild process is succesfully running.
This builds a container image containing the DCO checking script.
It is then published at:
registry.gitlab.com/libvirt/libvirt-jenkins-ci/check-dco:master
from where it can be used in all other project repositories. This
avoids having to copy the check-dco.py script into every repo
when we
On a Monday in 2020, Laine Stump wrote:
If a pcie-root-port or pcie-downstream-port has hotplug='off' in its
subelement, and if the qemu binary supports the hotplug=false
option, then it will be added to the commandline for the pcie
controller. This controller will then not allow any
On 7. 4. 2020 14:10, Yi Li wrote:
> replace vm->def->disks[i] with dom_disk parameter
>
> Signed-off-by: Yi Li
> ---
> src/qemu/qemu_driver.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
Tweaked the commit mesage a bit, and pushed.
Reviewed-by: Michal Privoznik
Michal
On Wed, Apr 08, 2020 at 11:49:45AM +0200, Andrea Bolognani wrote:
> On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote:
> > # The vault password is only needed for the jenkins flavor, but in
> > # that case we want to make sure there's *something* in there
> > -if
On 6. 4. 2020 15:51, Laine Stump wrote:
> This series enables use of QEMU 5.0's new "hotplug=off" setting for
> pcie-root-ports and pcie-switch-downstream-ports. When set (in the
> subelement of the config), the emulated
> controller will report to the guest OS that devices cannot be
>
On Wed, Apr 08, 2020 at 12:05:11PM +0200, Andrea Bolognani wrote:
> On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote:
> > +- name: Register the gitlab-runner agent
> > + become: true
> > + become_user: gitlab
> > + shell: '/home/gitlab/bin/gitlab-runner register --non-interactive
> >
On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote:
> +- name: Register the gitlab-runner agent
> + become: true
> + become_user: gitlab
> + shell: '/home/gitlab/bin/gitlab-runner register --non-interactive --config
> {{ gitlab_runner_config_path }} --registration-token {{
On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote:
> # The vault password is only needed for the jenkins flavor, but in
> # that case we want to make sure there's *something* in there
> -if self.get_flavor() != "test":
> +if self.get_flavor() == "jenkins":
>
On Tue, Apr 07, 2020 at 08:10:29PM +0800, Yi Li wrote:
> replace vm->def->disks[i] with dom_disk parameter
>
> Signed-off-by: Yi Li
> ---
> src/qemu/qemu_driver.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>
On a Wednesday in 2020, Rafael Fonseca wrote:
On Tue, 7 Apr 2020, 22:14 Rafael Fonseca, wrote:
Unlike `waitpid`, `virProcessWait` only returns -1 (error) or 0
(success), so comparing that to `pid` will always be false and the
parent will report failure with:
error : main:851 : Failed to fork
On Tue, 2020-04-07 at 13:31 +0200, Erik Skultety wrote:
> As part of the users tasks, we remove the .profile file after we create
> our own .bash_profile. As part of that effort, let's remove the .bash_logout
> skeleton file as well, the reason being gitlab's runner agent which
> has a hard time
Ceph Nautilus supports separate image namespaces within a pool for
tenant isolation and QEMU added it as a rbd blockdev options from 5.0.0.
This optional attribute is used to access a image with namespace.
Add unit tests for this attribute.
https://bugzilla.redhat.com/show_bug.cgi?id=1816909
Signed-off-by: Han Han
---
docs/news.xml | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 0d3f3386..236a9bd6 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -44,6 +44,15 @@
+
+
+ qemu: Support rbd namespace
+
Signed-off-by: Han Han
---
src/conf/domain_conf.c| 4
src/util/virstoragefile.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6ad7552b..a4ee2e1e 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -9488,6
Signed-off-by: Han Han
---
docs/formatdomain.html.in | 5 +
docs/schemas/domaincommon.rng | 3 +++
2 files changed, 8 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index d56600dc..06e1a7ee 100644
--- a/docs/formatdomain.html.in
+++
The capability will be used for rbd namespace option. The rbd namespace
is introduced since ceph Nautilus and qemu v5.0.0.
Signed-off-by: Han Han
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
QEMU introduced rbd namespace blockdev args since v5.0.0[1].
Implement rbd namespace to libvirt. It could be used for tenant
isolation with in a pool after Ceph Nautilus.
Note that since the aarch64 qemu capabilities replies is not updated for the
namespace args, I didn't add capabilities test
On 07.04.2020 20:31, Don Koch wrote:
> On Thu, 19 Dec 2019 13:50:19 +0300
> Nikolay Shirokovskiy wrote:
>
>> If we use fake reboot then domain goes thru running->shutdown->running
>> state changes with shutdown state only for short period of time. At
>> least this is implementation details
77 matches
Mail list logo
