Re: [PATCH 24/24] qemu: backup: Setup TLS environment for pull-mode backup jobs

On 7/2/20 9:40 AM, Peter Krempa wrote: Use the configured TLS env to setup encryption of the TLS transport. https://bugzilla.redhat.com/show_bug.cgi?id=1822631 Signed-off-by: Peter Krempa --- src/qemu/qemu_backup.c | 80 +++--- 1 file changed, 76

Re: [PATCH 23/24] conf: backup: Add 'tls' attribute for 'server' element

On 7/2/20 9:40 AM, Peter Krempa wrote: Allow enabling TLS for the NBD server used to do pull-mode backups. Note that documentation already mentions 'tls', so this just implements the schema and XML bits. Signed-off-by: Peter Krempa --- +++

Re: [PATCH 22/24] qemu: conf: Add configuration of TLS environment for NBD transport of pull-backups

On 7/2/20 9:40 AM, Peter Krempa wrote: TLS is required to transport backed-up data securely when using pull-mode backups. Signed-off-by: Peter Krempa --- docs/formatbackup.rst | 4 src/qemu/libvirtd_qemu.aug | 5 src/qemu/qemu.conf | 37

Re: [PATCH 21/24] conf: backup: Store 'tlsAlias' and 'tlsSecretAlias' as internals of a backup

On 7/2/20 9:40 AM, Peter Krempa wrote: Add fields for storing the aliases necessary to clean up the TLS env for a backup job after it finishes. Signed-off-by: Peter Krempa --- +++ b/tests/domainbackupxml2xmlin/backup-pull-internal-invalid.xml @@ -0,0 +1,36 @@ + + 1525889631 + Are you

Re: [PATCH 19/24] checkpoint: Mention that VIR_DOMAIN_CHECKPOINT_XML_SIZE is expensive and stale

On 7/2/20 9:40 AM, Peter Krempa wrote: Data is valid only when queried as guest writes may increase the backup size. Signed-off-by: Peter Krempa --- docs/formatcheckpoint.rst | 4 src/libvirt-domain-checkpoint.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-)

Re: [PATCH 20/24] testCompareBackupXML: Add infrastructure for testing internal fields

On 7/2/20 9:40 AM, Peter Krempa wrote: There are few internal fields of the backup XML. Propagate the 'internal' flag so that the test can verify the XML infrastructure. Signed-off-by: Peter Krempa --- tests/genericxml2xmltest.c | 30 -- 1 file changed, 24

Re: [PATCH 18/24] qemu: checkpoint: Implement VIR_DOMAIN_CHECKPOINT_XML_SIZE

On 7/2/20 9:40 AM, Peter Krempa wrote: Introduce code which merges the appropriate bitmaps and queries the final size of the backup, so that we can print the XML with size information. Signed-off-by: Peter Krempa --- src/qemu/qemu_checkpoint.c | 143 - 1

Re: [PATCH 17/24] conf: checkpoint: Add a flag storing whether disk 'size' is valid

On 7/2/20 9:40 AM, Peter Krempa wrote: Avoid printing '0' size in case when we weren't able to determine the backup size by adding a flag whether the size is valid and interlock printing of the field according to the flag. Signed-off-by: Peter Krempa --- src/conf/checkpoint_conf.c

Re: [PATCH 16/24] docs: checkpoint: Convert XML documentation to RST

On 7/2/20 9:40 AM, Peter Krempa wrote: Switch to the new format for easier extension. Signed-off-by: Peter Krempa --- docs/formatcheckpoint.html.in | 198 -- docs/formatcheckpoint.rst | 162 2 files changed, 162

Re: [PATCH 15/24] qemu: backup: integrate with blockpull

On 7/2/20 9:40 AM, Peter Krempa wrote: Merge the bitmaps when finalizing a block pull job so that backups work properly afterwards. https://bugzilla.redhat.com/show_bug.cgi?id=1799010 Signed-off-by: Peter Krempa --- src/qemu/qemu_blockjob.c | 37 + 1

Re: [PATCH 14/24] backup: Allow configuring incremental backup per-disk individually

On 7/2/20 9:40 AM, Peter Krempa wrote: The semantics of the backup operation don't strictly require that all disks being backed up are part of the same incremental part (when a disk was checkpointed/backed up separately or in a different VM), or even they may not have an previous checkpoint at

Re: [PATCH 13/24] docs: backup: Convert XML documentation to RST

On 7/2/20 9:39 AM, Peter Krempa wrote: Switch to the new format for easier extension. Signed-off-by: Peter Krempa --- docs/formatbackup.html.in | 191 -- docs/formatbackup.rst | 149 + 2 files changed, 149 insertions(+),

Re: [PATCH 12/24] conf: backup: Don't explicitly forbid backup of read-only disk

On 7/2/20 9:39 AM, Peter Krempa wrote: Users may want to use this to create a full backup or even incremental if the checkpoints are pre existing. We still will not allow to create a pre-existing checkpoint on a read-only disk as that makes no sense.

Re: [PATCH 11/24] tests: qemuxml2argv: Test encrypted TLS key for nbd/vxhs disks

On 7/2/20 9:39 AM, Peter Krempa wrote: Add a dummy secret so that we see what command line is generated. Signed-off-by: Peter Krempa --- .../disk-network-tlsx509.x86_64-2.12.0.args| 15 --- .../disk-network-tlsx509.x86_64-latest.args| 18 +++---

Re: [PATCH 06/24] virQEMUDriverConfigLoadSpecificTLSEntry: Split up fetching of server-only config options

On 7/2/20 9:39 AM, Peter Krempa wrote: The '*_tls_x509_verify' options are relevant only when we are going to expose a server socket as client sockets always enable verification. Split up the macro to separate the common bits from the server bits so that when we'll later extend support of 'nbd'

Re: [PATCH 09/24] qemu: conf: Add configuration of TLS key encryption for 'vxhs' and 'nbd' disks

On 7/2/20 9:39 AM, Peter Krempa wrote: Until now libvirt didn't allow using encrypted TLS key for disk clients. Add fields for configuring the secret and propagate defaults. Signed-off-by: Peter Krempa --- src/qemu/libvirtd_qemu.aug | 2 ++ src/qemu/qemu.conf | 19

Re: [PATCH 10/24] qemu: domain: Setup secret for TLS key for nbd/vxhs disks

On 7/2/20 9:39 AM, Peter Krempa wrote: Setup the TLS secret when preparing a virStorageSource for use. https://bugzilla.redhat.com/show_bug.cgi?id=1602328 Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 44 +- 1 file changed, 31

Re: [PATCH 07/24] qemu: domain: Add infrastructure passing in TLS key's decryption key via 'secret'

On 7/2/20 9:39 AM, Peter Krempa wrote: Store the required data in the private data of a storage source and ensure that the 'alias' of the secret is formatted in the status XML. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c| 10 +- src/qemu/qemu_domain.h

Re: [PATCH 08/24] qemu block: Add internals for handling 'secret' corresponding to TLS key

On 7/2/20 9:39 AM, Peter Krempa wrote: Add infrastructure for hot- and cold-plug of the secret object holding decryption key for the TLS key. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 12 src/qemu/qemu_block.h | 2 ++ src/qemu/qemu_command.c | 11 ++-

Re: [PATCH 05/24] virQEMUDriverConfigLoadSpecificTLSEntry: Move fetching of 'chardev_tls' above macro

On 7/2/20 9:39 AM, Peter Krempa wrote: Move the extraction of the config value so that it makes more sense after upcoming refactors. Signed-off-by: Peter Krempa --- src/qemu/qemu_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake,

Re: [PATCH 04/24] qemu: conf: Move 'nbd' and 'vxhs' tls config variables together with rest of tls setup

On 7/2/20 9:39 AM, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/libvirtd_qemu.aug | 12 ++-- src/qemu/qemu_conf.h | 12 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red

Re: [PATCH 03/24] qemu.conf: Remove misleading mention of 'migrate_tls'

On 7/2/20 9:39 AM, Peter Krempa wrote: There's no such parameter. Reword the sentence to account for enabling TLS-encrypted migration using API flags. Signed-off-by: Peter Krempa --- src/qemu/qemu.conf | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake

Re: [PATCH 02/24] qemuDomainDiskHasEncryptionSecret: unexport

On 7/2/20 9:39 AM, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domain.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [PATCH 01/24] qemu: domain: Introduce helper for always fetching virStorageSource private data

On 7/2/20 9:39 AM, Peter Krempa wrote: Add a helper which will always return the storage source private data even if it was not allocated before. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 10 ++ src/qemu/qemu_domain.h | 2 ++ 2 files changed, 12 insertions(+)

Re: [PATCH 00/24] qemu: Incremental backup and TLS handling fixes

On Thu, 2020-07-02 at 16:39 +0200, Peter Krempa wrote: > This series consists of multiple parts fixing the following bugs. Some > of them depend on previous so I'm sending it as one to prevent > conflicts. > > - Patches 1 - 11: > > https://bugzilla.redhat.com/show_bug.cgi?id=1602328 > [RFE]

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

On Thu, Jul 02, 2020 at 11:01:54AM +0800, Jason Wang wrote: > So I think we agree that a new notifier is needed? Good to me, or a new flag should be easier (IOMMU_NOTIFIER_DEV_IOTLB)? -- Peter Xu

[PATCH 14/24] backup: Allow configuring incremental backup per-disk individually

The semantics of the backup operation don't strictly require that all disks being backed up are part of the same incremental part (when a disk was checkpointed/backed up separately or in a different VM), or even they may not have an previous checkpoint at all (e.g. when the disk was freshly

Re: [libvirt PATCH 28/31] tests: commandhelper: change how we detect if running as daemon

On a Thursday in 2020, Pavel Hrdina wrote: The old code works correctly with make and running directly from shell but it failed with Meson test suite where session ID and process group are the same in both cases. What changes in both cases is parent process ID so use that instead of session ID.

[PATCH 22/24] qemu: conf: Add configuration of TLS environment for NBD transport of pull-backups

TLS is required to transport backed-up data securely when using pull-mode backups. Signed-off-by: Peter Krempa --- docs/formatbackup.rst | 4 src/qemu/libvirtd_qemu.aug | 5 src/qemu/qemu.conf | 37 ++

[PATCH 20/24] testCompareBackupXML: Add infrastructure for testing internal fields

There are few internal fields of the backup XML. Propagate the 'internal' flag so that the test can verify the XML infrastructure. Signed-off-by: Peter Krempa --- tests/genericxml2xmltest.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git

[PATCH 16/24] docs: checkpoint: Convert XML documentation to RST

Switch to the new format for easier extension. Signed-off-by: Peter Krempa --- docs/formatcheckpoint.html.in | 198 -- docs/formatcheckpoint.rst | 162 2 files changed, 162 insertions(+), 198 deletions(-) delete mode 100644

[PATCH 01/24] qemu: domain: Introduce helper for always fetching virStorageSource private data

Add a helper which will always return the storage source private data even if it was not allocated before. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 10 ++ src/qemu/qemu_domain.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/src/qemu/qemu_domain.c

[PATCH 13/24] docs: backup: Convert XML documentation to RST

Switch to the new format for easier extension. Signed-off-by: Peter Krempa --- docs/formatbackup.html.in | 191 -- docs/formatbackup.rst | 149 + 2 files changed, 149 insertions(+), 191 deletions(-) delete mode 100644

[PATCH 12/24] conf: backup: Don't explicitly forbid backup of read-only disk

Users may want to use this to create a full backup or even incremental if the checkpoints are pre existing. We still will not allow to create a checkpoint on a read-only disk as that makes no sense. https://bugzilla.redhat.com/show_bug.cgi?id=1840053 Signed-off-by: Peter Krempa ---

[PATCH 08/24] qemu block: Add internals for handling 'secret' corresponding to TLS key

Add infrastructure for hot- and cold-plug of the secret object holding decryption key for the TLS key. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 12 src/qemu/qemu_block.h | 2 ++ src/qemu/qemu_command.c | 11 ++- 3 files changed, 24 insertions(+), 1

[PATCH 05/24] virQEMUDriverConfigLoadSpecificTLSEntry: Move fetching of 'chardev_tls' above macro

Move the extraction of the config value so that it makes more sense after upcoming refactors. Signed-off-by: Peter Krempa --- src/qemu/qemu_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 33b3989268..2cbff1348a

[PATCH 04/24] qemu: conf: Move 'nbd' and 'vxhs' tls config variables together with rest of tls setup

Signed-off-by: Peter Krempa --- src/qemu/libvirtd_qemu.aug | 12 ++-- src/qemu/qemu_conf.h | 12 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index 404498b611..7a6a33c77c 100644 ---

[PATCH 19/24] checkpoint: Mention that VIR_DOMAIN_CHECKPOINT_XML_SIZE is expensive and stale

Data is valid only when queried as guest writes may increase the backup size. Signed-off-by: Peter Krempa --- docs/formatcheckpoint.rst | 4 src/libvirt-domain-checkpoint.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/formatcheckpoint.rst

[PATCH 24/24] qemu: backup: Setup TLS environment for pull-mode backup jobs

Use the configured TLS env to setup encryption of the TLS transport. https://bugzilla.redhat.com/show_bug.cgi?id=1822631 Signed-off-by: Peter Krempa --- src/qemu/qemu_backup.c | 80 +++--- 1 file changed, 76 insertions(+), 4 deletions(-) diff --git

[PATCH 23/24] conf: backup: Add 'tls' attribute for 'server' element

Allow enabling TLS for the NBD server used to do pull-mode backups. Note that documentation already mentions 'tls', so this just implements the schema and XML bits. Signed-off-by: Peter Krempa --- docs/schemas/domainbackup.rng | 9 - src/conf/backup_conf.c

[PATCH 02/24] qemuDomainDiskHasEncryptionSecret: unexport

Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domain.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 74392760b8..697ddab727 100644 --- a/src/qemu/qemu_domain.c +++

[PATCH 21/24] conf: backup: Store 'tlsAlias' and 'tlsSecretAlias' as internals of a backup

Add fields for storing the aliases necessary to clean up the TLS env for a backup job after it finishes. Signed-off-by: Peter Krempa --- src/conf/backup_conf.c| 42 +++ src/conf/backup_conf.h| 5 +++

[PATCH 10/24] qemu: domain: Setup secret for TLS key for nbd/vxhs disks

Setup the TLS secret when preparing a virStorageSource for use. https://bugzilla.redhat.com/show_bug.cgi?id=1602328 Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 44 +- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git

[PATCH 09/24] qemu: conf: Add configuration of TLS key encryption for 'vxhs' and 'nbd' disks

Until now libvirt didn't allow using encrypted TLS key for disk clients. Add fields for configuring the secret and propagate defaults. Signed-off-by: Peter Krempa --- src/qemu/libvirtd_qemu.aug | 2 ++ src/qemu/qemu.conf | 19 +++ src/qemu/qemu_conf.c

[PATCH 11/24] tests: qemuxml2argv: Test encrypted TLS key for nbd/vxhs disks

Add a dummy secret so that we see what command line is generated. Signed-off-by: Peter Krempa --- .../disk-network-tlsx509.x86_64-2.12.0.args| 15 --- .../disk-network-tlsx509.x86_64-latest.args| 18 +++--- tests/qemuxml2argvtest.c | 2 ++

[PATCH 06/24] virQEMUDriverConfigLoadSpecificTLSEntry: Split up fetching of server-only config options

The '*_tls_x509_verify' options are relevant only when we are going to expose a server socket as client sockets always enable verification. Split up the macro to separate the common bits from the server bits so that when we'll later extend support of 'nbd' and 'vxhs' disks which are client only

[PATCH 18/24] qemu: checkpoint: Implement VIR_DOMAIN_CHECKPOINT_XML_SIZE

Introduce code which merges the appropriate bitmaps and queries the final size of the backup, so that we can print the XML with size information. Signed-off-by: Peter Krempa --- src/qemu/qemu_checkpoint.c | 143 - 1 file changed, 142 insertions(+), 1

[PATCH 00/24] qemu: Incremental backup and TLS handling fixes

This series consists of multiple parts fixing the following bugs. Some of them depend on previous so I'm sending it as one to prevent conflicts. - Patches 1 - 11: https://bugzilla.redhat.com/show_bug.cgi?id=1602328 [RFE] Add support for encrypted TLS client keys for disks - Patch 12:

[PATCH 17/24] conf: checkpoint: Add a flag storing whether disk 'size' is valid

Avoid printing '0' size in case when we weren't able to determine the backup size by adding a flag whether the size is valid and interlock printing of the field according to the flag. Signed-off-by: Peter Krempa --- src/conf/checkpoint_conf.c | 2 +- src/conf/checkpoint_conf.h

[PATCH 03/24] qemu.conf: Remove misleading mention of 'migrate_tls'

There's no such parameter. Reword the sentence to account for enabling TLS-encrypted migration using API flags. Signed-off-by: Peter Krempa --- src/qemu/qemu.conf | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index

[PATCH 07/24] qemu: domain: Add infrastructure passing in TLS key's decryption key via 'secret'

Store the required data in the private data of a storage source and ensure that the 'alias' of the secret is formatted in the status XML. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c| 10 +- src/qemu/qemu_domain.h| 3 +++

[PATCH 15/24] qemu: backup: integrate with blockpull

Merge the bitmaps when finalizing a block pull job so that backups work properly afterwards. https://bugzilla.redhat.com/show_bug.cgi?id=1799010 Signed-off-by: Peter Krempa --- src/qemu/qemu_blockjob.c | 37 + 1 file changed, 37 insertions(+) diff --git

Re: [libvirt PATCH 18/31] scripts: check-remote-protocol: remove unused OBJEXT argument

On a Thursday in 2020, Pavel Hrdina wrote: Signed-off-by: Pavel Hrdina --- scripts/check-remote-protocol.py | 5 ++--- src/Makefile.am | 10 +- 2 files changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [libvirt PATCH 07/31] docs: remove unused wrapstring.xsl file

On a Thursday in 2020, Pavel Hrdina wrote: Commit removed last usage of this file so drop it as well. Signed-off-by: Pavel Hrdina --- docs/Makefile.am| 1 - docs/wrapstring.xsl | 56 - 2 files changed, 57 deletions(-) delete mode 100644

Re: [libvirt PATCH 05/31] Makefile: drop undefined LIB_CLOCK_GETTIME

On a Thursday in 2020, Pavel Hrdina wrote: This was introduced together with clock-time gnulib module by commit and removed from libvirt by commit <86d223a762990c9d529065a2d3b30b6a00ea63dd>. Adjustment archeology appreciated. Signed-off-by: Pavel Hrdina --- src/util/Makefile.inc.am | 1 -

Re: [libvirt PATCH 04/31] configure: remove usage of AC_HEADER_MAJOR

On a Thursday in 2020, Pavel Hrdina wrote: Commit <03c532cf9711dd6ad35380455a77141ef7d492ab> removed usage of MAJOR_IN_MKDEV and MAJOR_IN_SYSMACROS from libvirt which makes the AC_HEADER_MAJOR useless. Signed-off-by: Pavel Hrdina --- configure.ac | 2 -- 1 file changed, 2 deletions(-)

Re: [libvirt PATCH 03/31] configure: introduce FLAT_NAMESPACE_FLAGS

On a Thursday in 2020, Pavel Hrdina wrote: Set FLAT_NAMESPACE_FLAGS to -Wl,-flat_namespace in configure only for macOS and use it unconditionally in Makefiles. Signed-off-by: Pavel Hrdina --- configure.ac | 13 + src/Makefile.am | 10 +++--- tests/Makefile.am | 7 +++

Re: [libvirt PATCH 02/31] configure: drop check for unsupported FreeBSD

On a Thursday in 2020, Pavel Hrdina wrote: FreeBSD 10 is no longer supported by libvirt and the struct member ifi_oqdrops is usable without any define on later FreeBSD versions. Signed-off-by: Pavel Hrdina --- configure.ac | 11 --- 1 file changed, 11 deletions(-) Reviewed-by: Ján

Re: [libvirt PATCH 01/31] build: use DLOPEN_LIBS directly

On a Thursday in 2020, Pavel Hrdina wrote: There is no need to have DRIVER_MODULES_LIBS as it's used only for libvirt.so. The other places are using DLOPEN_LIBS directly and dlopen is required if building with libvirtd. It might be worth noting that it is mandatory since

Re: [PATCH v5 11/20] pc_basic_device_init: pass PCMachineState

On 7/2/20 3:25 PM, Gerd Hoffmann wrote: > Need access to pcms for pcspk initialization. > Just preparation, no functional change. > > Signed-off-by: Gerd Hoffmann > --- > include/hw/i386/pc.h | 3 ++- > hw/i386/pc.c | 3 ++- > hw/i386/pc_piix.c| 2 +- > hw/i386/pc_q35.c | 2 +- >

[PATCH v5 02/20] stubs: add pci_create_simple

Needed for -soundhw cleanup. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- stubs/pci-bus.c | 7 +++ stubs/Makefile.objs | 1 + 2 files changed, 8 insertions(+) create mode 100644 stubs/pci-bus.c diff --git a/stubs/pci-bus.c

[PATCH v5 09/20] audio: deprecate -soundhw sb16

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/sb16.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c index df6f755a37f8..2d9e50f99b5d 100644 ---

[PATCH v5 05/20] audio: deprecate -soundhw es1370

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Add an alias so both es1370 and ES1370 are working with -device. Signed-off-by: Gerd Hoffmann --- hw/audio/es1370.c | 9 ++--- qdev-monitor.c| 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff

[PATCH v5 19/20] pcspk: update docs/system/target-i386-desc.rst.inc

Add PC speaker with config hints. Signed-off-by: Gerd Hoffmann --- docs/system/target-i386-desc.rst.inc | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/system/target-i386-desc.rst.inc b/docs/system/target-i386-desc.rst.inc index 47a169e0ae2a..7d1fffacbea3

[PATCH v5 20/20] audio: set default value for pcspk.iobase property

Allows dropping the explicit qdev_prop_set_uint32 call in pcspk_init. Signed-off-by: Gerd Hoffmann --- include/hw/audio/pcspk.h | 6 +- hw/audio/pcspk.c | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/hw/audio/pcspk.h b/include/hw/audio/pcspk.h index

[PATCH v5 10/20] audio: deprecate -soundhw hda

Add deprecation message to the audio init function. Signed-off-by: Gerd Hoffmann --- hw/audio/intel-hda.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index f673b8317a84..f6cea49686d7 100644 --- a/hw/audio/intel-hda.c +++

[PATCH v5 01/20] stubs: add isa_create_simple

Needed for -soundhw cleanup. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- stubs/isa-bus.c | 7 +++ stubs/Makefile.objs | 1 + 2 files changed, 8 insertions(+) create mode 100644 stubs/isa-bus.c diff --git a/stubs/isa-bus.c

[PATCH v5 17/20] audio: deprecate -soundhw pcspk

Add deprecation message to the audio init function. Factor out audio initialization and call that from both audio init and realize, so setting the audiodev property is enough to properly initialize pcspk. Add a property alias to the machine type to set the audio device, so pcspk can be

[PATCH v5 13/20] pc_basic_device_init: drop no_vmport arg

Now that we pass pcms anyway, we don't need the no_vmport arg any more. No functional change. Signed-off-by: Gerd Hoffmann --- include/hw/i386/pc.h | 1 - hw/i386/pc.c | 3 +-- hw/i386/pc_piix.c| 1 - hw/i386/pc_q35.c | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) diff

[PATCH v5 15/20] audio: rework pcspk_init()

Instead of creating and returning the pc speaker accept it as argument. That allows to rework the initialization workflow in followup patches. Signed-off-by: Gerd Hoffmann --- include/hw/audio/pcspk.h | 6 +- hw/i386/pc.c | 2 +- hw/isa/i82378.c | 2 +- hw/mips/jazz.c

[PATCH v5 00/20] audio: deprecate -soundhw

v2: - use g_assert_not_reached() for stubs. - add deprecation notice. v3: - rebase to latest master. - adapt to armbru's device initialization changes. v4: - reorder patches, drop temporary -global setup, go straight to -machine pcspk-audiodev= instead. - update error messages and

[PATCH v5 03/20] audio: add deprecated_register_soundhw

Add helper function for -soundhw deprecation. It can replace the simple init functions which just call {isa,pci}_create_simple() with a hardcoded type. It also prints a deprecation message. Signed-off-by: Gerd Hoffmann --- include/hw/audio/soundhw.h | 2 ++ hw/audio/soundhw.c | 24

[PATCH v5 14/20] softmmu: initialize spice and audio earlier

audiodev must be initialized before machine_set_property so the machine can have audiodev property aliases. spice must initialize before audiodev because the default audiodev is spice only in case spice is actually enabled. Signed-off-by: Gerd Hoffmann --- softmmu/vl.c | 12 ++-- 1

[PATCH v5 04/20] audio: deprecate -soundhw ac97

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Add an alias so both ac97 and AC97 are working with -device. Signed-off-by: Gerd Hoffmann --- hw/audio/ac97.c | 9 ++--- qdev-monitor.c | 1 + 2 files changed, 3 insertions(+), 7 deletions(-) diff --git

[PATCH v5 11/20] pc_basic_device_init: pass PCMachineState

Need access to pcms for pcspk initialization. Just preparation, no functional change. Signed-off-by: Gerd Hoffmann --- include/hw/i386/pc.h | 3 ++- hw/i386/pc.c | 3 ++- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff

[PATCH v5 08/20] audio: deprecate -soundhw gus

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/gus.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index c8df2bde6b32..7e4a8cadad6f 100644 --- a/hw/audio/gus.c

[PATCH v5 12/20] pc_basic_device_init: drop has_pit arg

Now that we pass pcms anyway, we don't need the has_pit arg any more. No functional change. Signed-off-by: Gerd Hoffmann --- include/hw/i386/pc.h | 1 - hw/i386/pc.c | 3 +-- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- 4 files changed, 3 insertions(+), 5 deletions(-) diff

[PATCH v5 07/20] audio: deprecate -soundhw cs4231a

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/cs4231a.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index ffdbb58d6a11..59705a8d4701 100644 ---

[PATCH v5 16/20] audio: create pcspk device early

Create the pcspk device early, so it exists at machine type initialization time. Signed-off-by: Gerd Hoffmann --- include/hw/i386/pc.h | 1 + hw/i386/pc.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index

[PATCH v5 18/20] audio: add soundhw deprecation notice

Signed-off-by: Gerd Hoffmann --- docs/system/deprecated.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 843ae71fc618..6aa492b45006 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -82,6

[PATCH v5 06/20] audio: deprecate -soundhw adlib

Switch to deprecated_register_soundhw(). Remove the now obsolete init function. Signed-off-by: Gerd Hoffmann --- hw/audio/adlib.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index 7c3b67dcfb8c..65dff5b6fca4 100644 ---

Re: [libvirt PATCH] docs: Update CI documentation

On Thu, Jul 02, 2020 at 03:04:41PM +0200, Andrea Bolognani wrote: > We're no longer using either Travis CI or the Jenkins-based > CentOS CI, but we have started using Cirrus CI. > > Mention the libvirt-ci subproject as well, as a pointer for those > who might want to learn more about our CI

[libvirt PATCH] docs: Update CI documentation

We're no longer using either Travis CI or the Jenkins-based CentOS CI, but we have started using Cirrus CI. Mention the libvirt-ci subproject as well, as a pointer for those who might want to learn more about our CI infrastructure. Signed-off-by: Andrea Bolognani --- docs/ci.rst | 12

Re: [libvirt PATCH] NEWS: Update for libvirt 6.5.0

On Thu, Jul 02, 2020 at 02:41:38PM +0200, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > NEWS.rst | 27 +++ > 1 file changed, 27 insertions(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/NEWS.rst b/NEWS.rst > index 0e9822cd03..499711fb18

[libvirt PATCH] NEWS: Update for libvirt 6.5.0

Signed-off-by: Andrea Bolognani --- NEWS.rst | 27 +++ 1 file changed, 27 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0e9822cd03..499711fb18 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -47,8 +47,30 @@ v6.5.0 (unreleased) alphabetical order. Hook script in old

[libvirt PATCH 31/31] tools: wireshark: fix compilation errors

With meson introduction which is using the same CFLAGS for the whole project some compilation errors were discovered. Signed-off-by: Pavel Hrdina --- tools/wireshark/src/packet-libvirt.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

[libvirt PATCH 19/31] src: Makefile: remove LOCK_CHECKING_CFLAGS leftover

Commit removed objectlocking test but forgot to remove all of the usages of LOCK_CHECKING_CFLAGS. Signed-off-by: Pavel Hrdina --- src/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index e1117029ebc..834e356b68b 100644 --- a/src/Makefile.am +++

[libvirt PATCH 26/31] src: remote: Makefile: properly format sysconfdir in virtproxyd.conf

Commit <5b816e16968ba02def56f067774ecd9a8c8d44d7> removed hard-coded sysconfdir path from *.conf files but missed virtproxyd. Signed-off-by: Pavel Hrdina --- src/remote/Makefile.inc.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am

[libvirt PATCH 28/31] tests: commandhelper: change how we detect if running as daemon

The old code works correctly with make and running directly from shell but it failed with Meson test suite where session ID and process group are the same in both cases. What changes in both cases is parent process ID so use that instead of session ID. Signed-off-by: Pavel Hrdina ---

[libvirt PATCH 11/31] m4: virt-sanlock: drop check for SANLK_INQ_WAIT

SANLK_INQ_WAIT was introduced in sanlock 2.4 which is available in all supported OSes. Signed-off-by: Pavel Hrdina --- m4/virt-sanlock.m4| 9 - src/locking/lock_driver_sanlock.c | 6 -- 2 files changed, 15 deletions(-) diff --git a/m4/virt-sanlock.m4

[libvirt PATCH 16/31] m4: virt-xdr: rewrite XDR check

The current code to check XDR support was obsolete and way to complicated. On linux we can use pkg-config to check for libtirpc and have the CFLAGS and LIBS configured by it as well. On MinGW there is portablexdr library which installs header files directly into system include directory. On

[libvirt PATCH 09/31] m4: virt-sanlock: drop check for sanlock_inq_lockspace

This check was introduced by commit <96a02703daad4dc6663165adbc0feade9900cebd> to guard calling sanlock_inq_lockspace() function but it used SANLK_INQ_WAIT as a parameter which was introduced later. This was eventually fixed by commit <238dba0f9c925359cb3b8beddd8c8ae739cb4e06>. We can safely

[libvirt PATCH 08/31] docs: drop %.png: %.fig rule

convert bin is part of ImageMagick package and uses uniconvertor to create png file from fig files. Unfortunately uniconvertor is python2 only and not available in most recent distributions which makes the convert command fail with: sh: uniconvertor: command not found /usr/bin/mv: cannot stat

[libvirt PATCH 29/31] tests: use WITH_NSS instead of NSS

Signed-off-by: Pavel Hrdina --- m4/virt-nss.m4 | 2 +- tests/nssmock.c | 2 +- tests/nsstest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/m4/virt-nss.m4 b/m4/virt-nss.m4 index 951a74e835b..b519c36e859 100644 --- a/m4/virt-nss.m4 +++ b/m4/virt-nss.m4 @@ -58,7 +58,7 @@

[libvirt PATCH 21/31] src: remote: Makefile: drop CFLAGS and LDFLAGS duplication

Signed-off-by: Pavel Hrdina --- src/remote/Makefile.inc.am | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am index 8a40c96563c..893d6894e2f 100644 --- a/src/remote/Makefile.inc.am +++ b/src/remote/Makefile.inc.am

[libvirt PATCH 04/31] configure: remove usage of AC_HEADER_MAJOR

Commit <03c532cf9711dd6ad35380455a77141ef7d492ab> removed usage of MAJOR_IN_MKDEV and MAJOR_IN_SYSMACROS from libvirt which makes the AC_HEADER_MAJOR useless. Signed-off-by: Pavel Hrdina --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index

[libvirt PATCH 25/31] src: util: Makefile: drop undefined OPENPTY_LIBS

Commit added check for openpty function from util library using AC_CHECK_LIB(). However, that macro doesn't define OPENPTY_LIBS, it only defines WITH_LIBUTIL and prepends -lutil into LIBS for the whole project. Signed-off-by: Pavel Hrdina --- src/util/Makefile.inc.am | 1 - 1 file changed, 1

[libvirt PATCH 23/31] src: util: rename some program macros

Fixes inconsistency with macro names for external programs. Signed-off-by: Pavel Hrdina --- m4/virt-external-programs.m4| 8 src/util/virnetdevmidonet.c | 4 ++-- src/util/virnetdevopenvswitch.c | 16 3 files changed, 14 insertions(+), 14 deletions(-) diff

[libvirt PATCH 00/31] fixes and cleanups for current build system

While working on rewrite to Meson I discovered some parts of our current build system that could be improved to help with the transition to Meson. It will make the review of the Meson patches a bit easier. Pavel Hrdina (31): build: use DLOPEN_LIBS directly configure: drop check for

[libvirt PATCH 15/31] m4: virt-selinux: drop check for selabel_open signature change

All supported OSes have at least libselinux version 2.5 so it's safe to drop this check. Signed-off-by: Pavel Hrdina --- m4/virt-selinux.m4| 17 - tests/securityselinuxhelper.c | 5 ++--- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git

  1   2   >