Re: [PATCH v2 1/7] hyperv: implement domainSetAutostart

2020-10-17 Thread Matt Coleman
> On Oct 15, 2020, at 8:57 AM, Michal Privoznik wrote: > > On 10/13/20 7:13 AM, Matt Coleman wrote: >> +char enabledValue[] = "2", disabledValue[] = "0"; >> + >> +if (priv->wmiVersion == HYPERV_WMI_VERSION_V1) { >> +methodName = "ModifyVirtualSystem"; >> +

Re: [PATCH v2 6/7] hyperv: fix domainManagedSave on Hyper-V V2

2020-10-17 Thread Matt Coleman
> On Oct 13, 2020, at 1:14 AM, Matt Coleman wrote: > > +if (priv->wmiVersion == HYPERV_WMI_VERSION_V2) > +requestedState = > MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED_BUT_OFFLINE; ... > +MSVM_COMPUTERSYSTEM_REQUESTEDSTATE_ENABLED_BUT_OFFLINE = 6, I realized I named this after

Re: [PATCH v2 2/7] hyperv: implement nodeGetFreeMemory

2020-10-17 Thread Matt Coleman
> On Oct 15, 2020, at 8:56 AM, Michal Privoznik wrote: > > On 10/13/20 7:13 AM, Matt Coleman wrote: >> +if (hypervGetWmiClass(Win32_OperatingSystem, ) < 0 || >> +!operatingSystem) { >> +virReportError(VIR_ERR_INTERNAL_ERROR, >> + _("Could not get free