Re: [libvirt PATCH 3/3] qemu: Extra check for NBD URI being specified

2020-12-17 Thread Martin Kletzander
On Thu, Dec 17, 2020 at 11:15:11AM +0100, Peter Krempa wrote: On Wed, Dec 16, 2020 at 12:19:28 +0100, Martin Kletzander wrote: It must be used when migration URI uses `unix:` transport because otherwise we cannot just guess where to connect for disk migration.

Re: [libvirt][PATCH v1 0/3] introduce 'restrictive' mode in numatune

2020-12-17 Thread Daniel Henrique Barboza
On 12/15/20 10:12 PM, Luyao Zhong wrote: Before this patch set, numatune only has three memory modes: static, interleave and prefered. These memory policies are ultimately set by mbind() system call. Memory policy could be 'hard coded' into the kernel, but none of above policies fit our

Re: [libvirt][PATCH v1 3/3] qemu: add parser and formatter for 'restrictive' mode in numatune

2020-12-17 Thread Daniel Henrique Barboza
On 12/15/20 10:13 PM, Luyao Zhong wrote: --- include/libvirt/libvirt-domain.h | 1 + src/conf/numa_conf.c | 9 + src/qemu/qemu_command.c | 6 ++- src/qemu/qemu_process.c | 27 +

Re: [PATCH 2/5] bhyve: remove redundant code that adds "template" netdev name

2020-12-17 Thread Roman Bogorodskiy
Laine Stump wrote: > The FreeBSD version of virNetDevTapCreate() now calls > virNetDevGenerateName(), and virNetDevGenerateName() understands that > a blank ifname should be replaced with a generated name based on a > device-type-specific template - so there is no longer any need for the >

Re: RFC PATCH: Issue 90 (Test Clarification)

2020-12-17 Thread Peter Krempa
On Wed, Dec 16, 2020 at 19:37:48 -0600, Ryan Gahagan wrote: > We addressed the feedback from our previous RFC patch for the most part. > Under src/util/virstoragefile.c, we left a cast to an integer pointer > that Peter mentioned because we were unable to provide a better Casting uid_t * to int *

Re: [PATCH libvirt v1] tests: add capabilities for QEMU 5.2.0 on s390x

2020-12-17 Thread Andrea Bolognani
On Wed, 2020-12-16 at 10:10 +0100, Shalini Chellathurai Saroja wrote: > tests/domaincapsdata/qemu_5.2.0.s390x.xml | 231 + > .../caps_5.2.0.s390x.replies | 25458 > .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 3300 ++ >

Re: [RFC PATCH 1/6] conf: Add NFS disk protocol

2020-12-17 Thread Peter Krempa
On Wed, Dec 16, 2020 at 19:37:49 -0600, Ryan Gahagan wrote: Please add a commit message. > Signed-off-by: Ryan Gahagan > --- > src/libxl/libxl_conf.c| 1 + > src/libxl/xen_xl.c| 1 + > src/qemu/qemu_block.c | 3 +++ > src/qemu/qemu_command.c | 1 + >

Re: [libvirt PATCH 3/3] qemu: Extra check for NBD URI being specified

2020-12-17 Thread Peter Krempa
On Wed, Dec 16, 2020 at 12:19:28 +0100, Martin Kletzander wrote: > It must be used when migration URI uses `unix:` transport because otherwise we > cannot just guess where to connect for disk migration. > > https://bugzilla.redhat.com/show_bug.cgi?id=1638889 > > Signed-off-by: Martin Kletzander

RE: [PATCH] util: Add phys_port_name support on virPCIGetNetName

2020-12-17 Thread Adrian Chiris
>-Original Message- >From: Laine Stump >Sent: Thursday, December 17, 2020 5:22 AM >To: libvir-list@redhat.com >Cc: Dmytro Linkin ; Moshe Levi ; >Adrian Chiris >Subject: Re: [PATCH] util: Add phys_port_name support on >virPCIGetNetName > >External email: Use caution opening links or

Re: To start multiple KVM guests from one qcow2 image with transient disk option

2020-12-17 Thread Peter Krempa
On Mon, Dec 14, 2020 at 22:49:03 -0500, Masayoshi Mizuma wrote: > On Sat, Dec 12, 2020 at 11:57:15AM +0100, Peter Krempa wrote: > > On Fri, Dec 11, 2020 at 20:58:48 -0500, Masayoshi Mizuma wrote: > > > Hello, > > > > > > I would like to start multiple KVM guests from one qcow2 image, and > > >

Re: [PATCH 4/4] lxd_domain: Require that VIR_LXC_DOMAIN_NAMESPACE_SOURCE_NONE is zero

2020-12-17 Thread Michal Privoznik
On 12/17/20 3:53 AM, Laine Stump wrote: On 12/16/20 4:13 PM, Michal Privoznik wrote: Our parser code relies on the fact that VIR_LXC_DOMAIN_NAMESPACE_SOURCE_NONE has value of zero and thus uses g_new0().  But strictly speaking, this is not mandated by the enum typedef. Fix that. Is there

Re: [PATCH 2/2] virnetdevopenvswitch: Try to unescape ovs-vsctl reply in one specific case

2020-12-17 Thread Michal Privoznik
On 12/16/20 8:17 PM, Laine Stump wrote: On 12/16/20 1:45 PM, Michal Privoznik wrote: During testing of my patch v6.10.0-rc1~221 it was found that    'ovs-vsctl get Interface $name name' or    'ovs-vsctl find Interface options:vhost-server-path=$path' may return a string in double quotes, e.g.

Re: [PATCH 6/5] lxc: skip the netdev autogenerated name counter past existing devices

2020-12-17 Thread Michal Privoznik
On 12/17/20 1:28 AM, Laine Stump wrote: On 12/16/20 4:27 PM, Michal Privoznik wrote: On 12/16/20 9:13 PM, Laine Stump wrote: the lxc driver uses virNetDevGenerateName() for its veth device names since patch 2dd0fb492, so it should be using virNetDevReserveName() during daemon restart/reconnect