On 2020-12-18 at 22:01, John Ferlan wrote:
>
>Coverity reminds us of the ancient software engineering proverb related
>to being stuck with ownership because you touched the code last :-) - I
>know this patch didn't cause the problem, but because the code was
>touched Coverity decided to look
On Fri, Dec 18, 2020 at 10:42:16PM +0100, Olaf Hering wrote:
Am Fri, 18 Dec 2020 21:09:45 +0100
schrieb Martin Kletzander :
I am guessing you want to `--migrateuri`, possibly with `--listen-address`.
Not sure if I really _want_ all these extra knobs. The intent is clear and
obvious, the
Am Fri, 18 Dec 2020 21:09:45 +0100
schrieb Martin Kletzander :
> I am guessing you want to `--migrateuri`, possibly with `--listen-address`.
Not sure if I really _want_ all these extra knobs. The intent is clear and
obvious, the connection needs to go to the specified host and/or IP address.
On Thu, Dec 17, 2020 at 8:00 AM Peter Krempa wrote:
> Also note that the upstream test-suite run in the CI does actually
> provide the expected output. Obviously you can't use the ENV variable to
> automatically overwrite your files, but you certainly can copy out the
> diffs from the CI. Just
On Wed, Dec 16, 2020 at 08:34:29PM +0100, Olaf Hering wrote:
A naive 'virsh migrate --live domU xen+tcp://cross-over-ip' uses the ordinary
uplink instead of the requested IP address. According to the documentation an
additional option has to be specified to really use the other network
On 12/15/20 5:24 PM, Tim Wiederhake wrote:
This series refactors the various scripts found in tests/cputestdata and
adds support for CORE_CAPABILITY MSR, as found on e.g. SnowRidge.
Acquiring test data on a new system is a two step process. "cpu-gather.sh"
gathers information on the target
On 12/15/20 5:24 PM, Tim Wiederhake wrote:
Fixes the leaking file descriptors. Does not silently ignore errors
(e.g. permission denied on /dev/cpu/0/msr if run as non-root) and
always attempt to read from /dev/kvm if /dev/cpu/0/msr failed.
'gather_msr()' returns a dictionary of values, as a
On 12/15/20 5:24 PM, Tim Wiederhake wrote:
This changes the invocation from
./cpu-gather.sh | ./cpu-parse.sh
to
./cpu-gather.py | ./cpu-parse.sh
Signed-off-by: Tim Wiederhake
---
tests/cputestdata/cpu-gather.py | 13 +
tests/cputestdata/cpu-gather.sh | 5 +
2 files
On 12/15/20 1:16 PM, Tim Wiederhake wrote:
See individual commit messages for more details.
Tim Wiederhake (2):
schemas: Deduplicate cpuTopology in cputypes.rng
schema: Allow counter element in host cpu definition
docs/schemas/cputypes.rng | 15 +--
1 file changed, 9
There are some variables which are used only inside the single
loop the function has. Let's declare them inside the loop body to
make that obvious. Also, fix indendation.
Signed-off-by: Michal Privoznik
---
src/util/virlease.c | 15 ---
1 file changed, 8 insertions(+), 7
When adding a new lease by our leaseshelper then virLeaseNew() is
called. Here, we check for DNSMASQ_LEASE_EXPIRES environment
variable which is the expiration time for the lease. For infinite
lease time the value is zero. However, our code is not prepared
for that and adds "expiry-time" into the
After v6.3.0-rc1~64 a lease can have infinite expiry time. This
means that the expiration time will appear as a value of zero.
Do the expiration check only if the expiration time is not zero.
Fixes: 97a0aa246799c97d0a9ca9ecd6b4fd932ae4756c
Signed-off-by: Michal Privoznik
---
Firstly, bring variables that are used only within loops into
their respective loops. Secondly, drop 'error' label which is
redundant since we have @rv which holds the return value.
Thirdly, fix indendation in one case, the rest is indented
properly.
Signed-off-by: Michal Privoznik
---
If leasehelper fails all that we are left with is a simple error
message produced by dnsmasq:
lease-init script returned exit code 1
This is because the leasehelper did not write any message to
stderr. According to dnsmasq's manpage, whenever it's invoking
leasehelper the stderr is kept open:
In v6.3.0-rc1~64 we've introduced ability to configure lease
time, but forgot to document the feature. Let's fix that.
Fixes: 97a0aa246799c97d0a9ca9ecd6b4fd932ae4756c
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1908631
Signed-off-by: Michal Privoznik
---
docs/formatnetwork.html.in |
After v6.3.0-rc1~64 a lease can have infinite expiry time. This
means that the expiration time will appear as a value of zero.
Do the expiration check only if the expiration time is not zero.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1908053
Fixes:
This function is misusing VIR_INSERT_ELEMENT() to behave like
VIR_APPEND_ELEMENT(). Use the latter to make it explicit what we
are trying to achieve.
Signed-off-by: Michal Privoznik
---
src/network/bridge_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
In virLeaseNew() we are trying to remove trailing space (per
comment it may happen that older versions of dnsmasq put it into
an env variable). Well, instead of open coding it, we can use
virTrimSpaces().
Signed-off-by: Michal Privoznik
---
src/util/virlease.c | 3 +--
1 file changed, 1
We don't need to track the lease file size. Instead, we can
simply check if the file was empty by comparing the buffer the
file was read into with an empty string.
Signed-off-by: Michal Privoznik
---
src/network/bridge_driver.c | 34 ++
1 file changed, 18
Some things are broken when using leases that don't expire. We don't
store "expiry-time" in corresponding $brname.status file which sets off
a spiral and we get errors from other places which expect it to be there
always. These patches make sure that the attribute is always there. I've
also
Coverity reminds us of the ancient software engineering proverb related
to being stuck with ownership because you touched the code last :-) - I
know this patch didn't cause the problem, but because the code was
touched Coverity decided to look harder and found another leak.
On 12/16/20 1:01 AM,
Otherwise in some places we can mistakenly report 'unsupported' error instead
of root cause. So let's handle root cause explicitly from the macro.
Signed-off-by: Nikolay Shirokovskiy
---
src/qemu/qemu_migration.c | 33 ++---
1 file changed, 22 insertions(+), 11
Otherwise in some places we can mistakenly report 'unsupported' error instead
of root cause. So let's handle root cause explicitly from the macro.
Signed-off-by: Nikolay Shirokovskiy
---
src/libvirt-domain.c | 511 ++-
src/libvirt-host.c | 18
Otherwise in some places we can mistakenly report 'unsupported' error instead
of root cause. So let's handle root cause explicitly from the macro.
Signed-off-by: Nikolay Shirokovskiy
---
src/libxl/libxl_migration.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
Otherwise we can get misleading error messages. One example is when connection
is broken we got "this function is not supported by the connection driver:
virDomainMigrate3" from virDomainMigrate3.
Signed-off-by: Nikolay Shirokovskiy
---
src/driver.h | 9 +++--
1 file changed, 3
Justification is in the last patch.
Diff to v2 [1]:
- instead of RFC where fix was applied only to virMigrate3 now
all the places where VIR_DRV_SUPPORTS_FEATURE is used patched
to handle errors
[1] [RFC PATCH v2] fix error message in virMigrate3 if connection is broken
Hi Daniel and Jiri,
On 2020/12/8 18:31, Jiri Denemark wrote:
> On Tue, Dec 08, 2020 at 09:27:39 +, Daniel P. Berrangé wrote:
>> On Tue, Dec 08, 2020 at 10:06:25AM +0800, zhukeqian wrote:
>>>
>>> On 2020/12/7 18:38, Daniel P. Berrangé wrote:
On Mon, Dec 07, 2020 at 09:55:53AM +0800,
27 matches
Mail list logo
