On Tue, Jan 5, 2021 at 11:50 AM Yan Fu wrote:
> Tested with v6.10.0-283-g1948d4e61e.
>
> 1.Can define/start/destroy mdev device successfully;
>
> 2.'virsh nodedev-list' has no '--active' option, which is inconsistent
> with the description in the patch：
> # virsh nodedev-list --active
> error:
Reviewed-by: Huacai Chen
On Thu, Jan 7, 2021 at 2:46 AM Philippe Mathieu-Daudé wrote:
>
> The 'fulong2e' machine alias has been marked as deprecated since
> QEMU v5.1 (commit c3a09ff68dd, the machine is renamed 'fuloong2e').
> Time to remove it now.
>
> Signed-off-by: Philippe Mathieu-Daudé
>
Am Wed, 6 Jan 2021 19:46:02 +0100
schrieb Philippe Mathieu-Daudé :
> The 'fulong2e' machine alias has been marked as deprecated since
> QEMU v5.1 (commit c3a09ff68dd, the machine is renamed 'fuloong2e').
> Time to remove it now.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
On 2021-01-07 at 10:52, Shi Lei wrote:
>On 2021-01-06 at 18:21, Michal Privoznik wrote:
>>On 1/6/21 3:40 AM, Shi Lei wrote:
>>> Extract common code as helper function virNetlinkTalk, then simplify
>>> the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
>>>
>>> - default:
>>> -
On 2021-01-06 at 18:21, Michal Privoznik wrote:
>On 1/6/21 3:40 AM, Shi Lei wrote:
>> Extract common code as helper function virNetlinkTalk, then simplify
>> the functions virNetlink[DumpLink|NewLink|DelLink|GetNeighbor].
>>
>> Signed-off-by: Shi Lei
>> ---
>> src/util/virnetlink.c | 225
Hi Jiri,
On 2021/1/7 2:11, Jiri Denemark wrote:
> On Tue, Jan 05, 2021 at 21:54:05 +0800, Keqian Zhu wrote:
>> On 2021/1/5 21:34, Daniel P. Berrangé wrote:
>>> On Tue, Jan 05, 2021 at 09:28:27PM +0800, Keqian Zhu wrote:
>> The purpose of QEMU commit 65ace0604551 (migration: add postcopy total
Hi Michal
> On Jan 6, 2021, at 19:45, Michal Privoznik wrote:
>
> On 1/4/21 3:31 AM, Eiichi Tsukata wrote:
>> Currently, swtpm TPM state file is removed when a transient domain is
>> powered off or undefined. When we store TPM state on a shared storage
>> such as NFS and use transient domain,
On 12/18/20 10:45 PM, Shi Lei wrote:
On 2020-12-18 at 22:01, John Ferlan wrote:
Coverity reminds us of the ancient software engineering proverb related
to being stuck with ownership because you touched the code last :-) - I
know this patch didn't cause the problem, but because the code was
The two scenarios were found by Coverity after a seemingly-unrelated
change to virLXCProcessSetupInterfaceTap() (in commit ecfc2d5f43), and
explained by John Ferlan here:
https://www.redhat.com/archives/libvir-list/2020-December/msg00810.html
To re-explain:
a) On entry to
In all cases *except* when parsing status XML as libvirt is being
restarted, the XML parser will delete any manually specified interface
name (aka "" aka net->ifname) that could have been
generated by virNetDevGenerateName(). This means that during the setup
when a domain is being started (e.g.
Laine Stump (2):
lxc: remove unnecessary call to virNetDevReserveName()
lxc: eliminate leaked and dangling pointers in
virLXCProcessSetupInterfaceTap
src/lxc/lxc_process.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
--
2.29.2
virDeviceHasPCIExpressLink() wasn't checking that pcie_cap_pos was
valid before attempting to use it, which could lead to reading the
byte at offset 0+PCI_CAP_ID_EXP instead of [valid
offset]+PCI_CAP_ID_EXP. In particular, this could happen for
"integrated" PCI devices (those that are on the PCIe
Signed-off-by: Ryan Gahagan
---
.../disk-network-nfs.x86_64-latest.args | 56 +++
tests/qemuxml2argvdata/disk-network-nfs.xml | 48
tests/qemuxml2argvtest.c | 1 +
...isk-network-nfs-inactive.x86_64-latest.xml | 54 ++
Signed-off-by: Ryan Gahagan
---
src/conf/domain_conf.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 453e06491e..96ee009058 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6888,6
Signed-off-by: Ryan Gahagan
---
src/qemu/qemu_block.c | 67 +++-
src/qemu/qemu_domain.c | 70 ++
2 files changed, 136 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index
Signed-off-by: Ryan Gahagan
---
docs/formatdomain.rst | 24 ++--
docs/schemas/domaincommon.rng | 32
2 files changed, 54 insertions(+), 2 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index
Signed-off-by: Ryan Gahagan
---
src/util/virstoragefile.c | 8
src/util/virstoragefile.h | 8
2 files changed, 16 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 1176630282..3097e11984 100644
--- a/src/util/virstoragefile.c
+++
Signed-off-by: Ryan Gahagan
---
src/libxl/libxl_conf.c| 1 +
src/libxl/xen_xl.c| 1 +
src/qemu/qemu_block.c | 3 +++
src/qemu/qemu_command.c | 1 +
src/qemu/qemu_domain.c| 2 ++
src/qemu/qemu_snapshot.c | 3 +++
src/util/virstoragefile.c | 6 ++
Per Issue 90[1], QEMU supports using an NFS disk but Libvirt had no
support for attaching a disk of this type. This patch series adds in
this capability as well as the tests necessary to make sure it works
correctly.
The changes in this second version over the previous patch series for
this issue
Signed-off-by: Ryan Gahagan
---
src/util/virstoragefile.c | 49 +++
tests/virstoragetest.c| 13 +++
2 files changed, 62 insertions(+)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 3097e11984..d67f0f2c3f 100644
---
On a Wednesday in 2021, Peter Krempa wrote:
Patches 1-6 are mostly cleanups noticed while looking at the schema.
See patch 7/7 for explanation.
Peter Krempa (7):
virSecretDefParseUsage: Use g_autofree for type_str
secretXMLParseNode: Clean up freeing of memory
virSecretLookupParseSecret:
On a Wednesday in 2021, Peter Krempa wrote:
There's plenty of existing documentation [1] which shows as example a
name which contains a space and a dot ('client.admin secret') as ceph
usage name.
Use a more relaxed type in the RNG schema since the usage name is
actually just a string used to
On a Wednesday in 2021, Peter Krempa wrote:
Objects such as domain, pool, etc re-define the regex for the format.
Add more generic types for objects with/without a slash which we'll be
able to reuse also for other objects.
Signed-off-by: Peter Krempa
---
docs/schemas/basictypes.rng| 13
On a Wednesday in 2021, Peter Krempa wrote:
New libxml2 handles '\n' properly so the literal newline is not
necessary.
, because 2.9.1 is the minimum version we support.
Signed-off-by: Peter Krempa
---
docs/schemas/domaincommon.rng | 8 ++--
docs/schemas/storagecommon.rng | 4 +---
2
Sorry, looks like I'm compiling with debug options and missed this error.
It was a deliberate change but compiler don't like it.
The build fix is pushed.
Nikolay
On Wed, Jan 6, 2021 at 5:44 PM Daniel P. Berrangé
wrote:
> On Fri, Dec 18, 2020 at 09:56:47AM +0300, Nikolay Shirokovskiy wrote:
>
The 'fulong2e' machine alias has been marked as deprecated since
QEMU v5.1 (commit c3a09ff68dd, the machine is renamed 'fuloong2e').
Time to remove it now.
Signed-off-by: Philippe Mathieu-Daudé
---
docs/system/deprecated.rst | 5 -
docs/system/removed-features.rst | 5 +
On 1/6/21 3:05 PM, Daniel P. Berrangé wrote:
On Wed, Jan 06, 2021 at 02:40:15PM -0300, Daniel Henrique Barboza wrote:
On 1/6/21 2:30 PM, Daniel P. Berrangé wrote:
On Wed, Jan 06, 2021 at 02:24:35PM -0300, Daniel Henrique Barboza wrote:
On 1/6/21 8:13 AM, Erik Skultety wrote:
On Wed,
On Tue, Jan 05, 2021 at 21:54:05 +0800, Keqian Zhu wrote:
> On 2021/1/5 21:34, Daniel P. Berrangé wrote:
> > On Tue, Jan 05, 2021 at 09:28:27PM +0800, Keqian Zhu wrote:
> The purpose of QEMU commit 65ace0604551 (migration: add postcopy total
> blocktime into query-migrate)
> is to
On Wed, Jan 06, 2021 at 02:40:15PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 1/6/21 2:30 PM, Daniel P. Berrangé wrote:
> > On Wed, Jan 06, 2021 at 02:24:35PM -0300, Daniel Henrique Barboza wrote:
> > >
> > >
> > > On 1/6/21 8:13 AM, Erik Skultety wrote:
> > > > On Wed, Jan 06, 2021 at
On 1/6/21 2:30 PM, Daniel P. Berrangé wrote:
On Wed, Jan 06, 2021 at 02:24:35PM -0300, Daniel Henrique Barboza wrote:
On 1/6/21 8:13 AM, Erik Skultety wrote:
On Wed, Jan 06, 2021 at 08:00:52AM -0300, Daniel Henrique Barboza wrote:
On 1/6/21 7:09 AM, Daniel P. Berrangé wrote:
On Tue,
On Wed, Jan 06, 2021 at 02:24:35PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 1/6/21 8:13 AM, Erik Skultety wrote:
> > On Wed, Jan 06, 2021 at 08:00:52AM -0300, Daniel Henrique Barboza wrote:
> > >
> > >
> > > On 1/6/21 7:09 AM, Daniel P. Berrangé wrote:
> > > > On Tue, Jan 05, 2021 at
On 1/6/21 8:13 AM, Erik Skultety wrote:
On Wed, Jan 06, 2021 at 08:00:52AM -0300, Daniel Henrique Barboza wrote:
On 1/6/21 7:09 AM, Daniel P. Berrangé wrote:
On Tue, Jan 05, 2021 at 05:18:13PM -0300, Daniel Henrique Barboza wrote:
Hi,
This is something I've been giving a thought after
There's plenty of existing documentation [1] which shows as example a
name which contains a space and a dot ('client.admin secret') as ceph
usage name.
Use a more relaxed type in the RNG schema since the usage name is
actually just a string used to look up the secret.
[1]:
New libxml2 handles '\n' properly so the literal newline is not
necessary.
Signed-off-by: Peter Krempa
---
docs/schemas/domaincommon.rng | 8 ++--
docs/schemas/storagecommon.rng | 4 +---
2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/docs/schemas/domaincommon.rng
Signed-off-by: Peter Krempa
---
src/util/virsecret.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/util/virsecret.c b/src/util/virsecret.c
index 9ed803d45b..57c8583539 100644
--- a/src/util/virsecret.c
+++ b/src/util/virsecret.c
@@ -90,8 +90,7 @@
Objects such as domain, pool, etc re-define the regex for the format.
Add more generic types for objects with/without a slash which we'll be
able to reuse also for other objects.
Signed-off-by: Peter Krempa
---
docs/schemas/basictypes.rng| 13 +
docs/schemas/domaincommon.rng |
Signed-off-by: Peter Krempa
---
src/conf/secret_conf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/conf/secret_conf.c b/src/conf/secret_conf.c
index 273987bdb4..9cacc43e28 100644
--- a/src/conf/secret_conf.c
+++ b/src/conf/secret_conf.c
@@ -52,7 +52,7 @@ static int
'genericName' allows arbitrary numeric strings so using an explicit
'unsignedInt' choice is pointless. The elements take an username or a
uid which is prefixed by '+', both of which are covered by
'genericName'.
Signed-off-by: Peter Krempa
---
docs/schemas/domaincommon.rng | 10 ++
1
Use one variable per extracted property instead of reusing strings and
drop needless VIR_FREE calls.
Signed-off-by: Peter Krempa
---
src/conf/secret_conf.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/conf/secret_conf.c b/src/conf/secret_conf.c
index
Patches 1-6 are mostly cleanups noticed while looking at the schema.
See patch 7/7 for explanation.
Peter Krempa (7):
virSecretDefParseUsage: Use g_autofree for type_str
secretXMLParseNode: Clean up freeing of memory
virSecretLookupParseSecret: Use g_steal_pointer
schema: domaincommon:
On Thu, Dec 24, 2020 at 08:14:41AM -0600, Jonathon Jongsma wrote:
> Several functions accept providing a node device by name or by wwnn,wwpn
> pair. Extract the logic to do this into a function that can be used by
> both callers.
>
> Signed-off-by: Jonathon Jongsma
> ---
Reviewed-by: Erik
On Tue, Jan 05, 2021 at 17:25:54 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst| 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtxend.rst | 215
On 1/6/21 12:03 PM, Daniel P. Berrangé wrote:
On Wed, Jan 06, 2021 at 12:00:30PM -0300, Daniel Henrique Barboza wrote:
On 1/6/21 11:47 AM, Daniel P. Berrangé wrote:
On Wed, Jan 06, 2021 at 11:42:09AM -0300, Daniel Henrique Barboza wrote:
Commit v6.10.0-103-g198c1eb6b4 fixed this issue.
On Tue, Jan 05, 2021 at 17:25:53 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst | 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtvzd.rst | 215
On Tue, Jan 05, 2021 at 17:25:52 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst | 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtvboxd.rst | 213
On Tue, Jan 05, 2021 at 17:25:51 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst| 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtstoraged.rst | 215
On Tue, Jan 05, 2021 at 17:25:50 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst | 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtsecretd.rst | 214
Commit v6.10.0-103-g198c1eb6b4 fixed this issue.
Signed-off-by: Daniel Henrique Barboza
---
Changes from v2:
- clarified that the bug fix will not affect existing guests that will
update from an older Libvirt version to 7.0.0.
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git
On Wed, Jan 06, 2021 at 12:00:30PM -0300, Daniel Henrique Barboza wrote:
>
>
> On 1/6/21 11:47 AM, Daniel P. Berrangé wrote:
> > On Wed, Jan 06, 2021 at 11:42:09AM -0300, Daniel Henrique Barboza wrote:
> > > Commit v6.10.0-103-g198c1eb6b4 fixed this issue.
> > >
> > > Signed-off-by: Daniel
On 1/6/21 11:47 AM, Daniel P. Berrangé wrote:
On Wed, Jan 06, 2021 at 11:42:09AM -0300, Daniel Henrique Barboza wrote:
Commit v6.10.0-103-g198c1eb6b4 fixed this issue.
Signed-off-by: Daniel Henrique Barboza
---
I forgot to update NEWS.rst back then :/
NEWS.rst | 7 +++
1 file
On Tue, Jan 05, 2021 at 17:25:49 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst | 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtqemud.rst | 215
On Tue, Jan 05, 2021 at 17:25:48 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst | 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtnwfilterd.rst | 215
On Tue, Jan 05, 2021 at 17:25:47 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst| 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtnodedevd.rst | 214
On Wed, Jan 06, 2021 at 11:42:09AM -0300, Daniel Henrique Barboza wrote:
> Commit v6.10.0-103-g198c1eb6b4 fixed this issue.
>
> Signed-off-by: Daniel Henrique Barboza
> ---
>
> I forgot to update NEWS.rst back then :/
>
> NEWS.rst | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff
On Fri, Dec 18, 2020 at 09:56:47AM +0300, Nikolay Shirokovskiy wrote:
> Otherwise in some places we can mistakenly report 'unsupported' error instead
> of root cause. So let's handle root cause explicitly from the macro.
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/qemu/qemu_migration.c
Commit v6.10.0-103-g198c1eb6b4 fixed this issue.
Signed-off-by: Daniel Henrique Barboza
---
I forgot to update NEWS.rst back then :/
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index da88b19d0a..2c5cee77db 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@
On Tue, Jan 05, 2021 at 17:25:46 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst| 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtnetworkd.rst | 215
On 1/6/21 12:12 PM, Tim Wiederhake wrote:
Changes to a virtio network device such as
...
were quietly dismissed by `virsh update-device ... --live`.
Signed-off-by: Tim Wiederhake
Reviewed-by: Daniel P. Berrangé
---
src/qemu/qemu_hotplug.c | 10 ++
1 file
On Tue, Jan 05, 2021 at 17:25:45 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst| 1 +
> docs/manpages/meson.build | 1 +
> docs/manpages/virtlxcd.rst | 215
On Tue, Jan 05, 2021 at 17:25:44 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst | 1 +
> docs/manpages/meson.build| 1 +
> docs/manpages/virtinterfaced.rst | 215
On Tue, Jan 05, 2021 at 17:25:43 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst | 7 ++
> docs/manpages/meson.build| 1 +
> docs/manpages/virtbhyved.rst | 193
On Thu, Dec 24, 2020 at 08:14:31AM -0600, Jonathon Jongsma wrote:
> At startup, query devices that are defined by 'mdevctl' and add them to
> the node device list.
>
> This adds a complication: we now have two potential sources of
> information for a node device:
> - udev for all devices and for
On Tue, Jan 05, 2021 at 17:25:40 +, Daniel P. Berrangé wrote:
> Subsitute in the current version so the example always reflect today's
> version of reality.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/libvirtd.rst | 2 +-
> docs/manpages/meson.build | 1 +
>
On Tue, Jan 05, 2021 at 17:25:41 +, Daniel P. Berrangé wrote:
> This group will be distinct from the per-driver modular daemon mapages.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git
On Tue, Jan 05, 2021 at 17:25:39 +, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/libvirtd.rst | 48 +++---
> 1 file changed, 24 insertions(+), 24 deletions(-)
Reviewed-by: Jiri Denemark
On Tue, Jan 05, 2021 at 17:25:42 +, Daniel P. Berrangé wrote:
> This is an adaptation of the libvirtd manpage.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> docs/manpages/index.rst | 1 +
> docs/manpages/meson.build| 1 +
> docs/manpages/virtproxyd.rst | 256
On Thu, Dec 24, 2020 at 08:14:29AM -0600, Jonathon Jongsma wrote:
> This adds some internal API to query for persistent mediated devices
> that are defined by mdevctl. Following commits will make use of this
> information. This just provides the infrastructure and tests for this
> feature. One
All callers of qemuMonitorJSONMakeCommandInternal will benefit from
making @arguments a double pointer and passing it to
virJSONValueObjectCreate directly which will clear it if it steals the
value.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 32
Prepare for a refactor of qemuMonitorJSONMakeCommandInternal.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 3 +--
src/qemu/qemu_monitor_json.c | 5 +++--
src/qemu/qemu_monitor_json.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_monitor.c
Use automatic memory freeing to remove the 'cleanup:' label and 'ret'
variable.
Signed-off-by: Peter Krempa
---
tests/qemumonitorjsontest.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
The callers of qemuMonitorAddObject rely on the fact that @alias is
filled only when the object is added successfully. This is documented
but the code didn't behave like that.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
The monitor code uses 'flags' for the flags of the monitor builder,
while in this function it's a different set of flags. All callers pass a
variable named 'cdevflags', so rename the argument to suit.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 10 +-
1 file changed, 5
This is a resend of the patches from:
https://www.redhat.com/archives/libvir-list/2020-November/msg01625.html
which can be justified without the rest of the series. This series
cleans up some monitor code and few related bits to testing.
The reset of the series will be posted once there's
Remove freeing/clearing of @props as the function doesn't guarantee that
it happens on success, rename the variable hodling copy of the alias and
use g_autofree to automatically free it and remove the cleanup label as
well as 'ret' variable.
Signed-off-by: Peter Krempa
---
Use automatic memory freeing and remove the 'cleanup' label and 'ret'
variable.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
We create a new 'vm' so we must also fake the nodeset.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvtest.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 662d0d5df6..8b2df07448 100644
--- a/tests/qemuxml2argvtest.c
+++
This allows simplification of the callers.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 13 -
src/qemu/qemu_monitor.c | 11 +++
src/qemu/qemu_monitor.h | 2 +-
src/qemu/qemu_monitor_json.c | 5 ++---
src/qemu/qemu_monitor_json.h
Check once before looping through the args.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvtest.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index d2712e0dce..662d0d5df6 100644
---
virJSONValueObjectRemoveKey can be used as direct replacement. Fix the
one caller and remove the duplicate function.
Signed-off-by: Peter Krempa
---
src/util/virjson.c | 29 -
1 file changed, 4 insertions(+), 25 deletions(-)
diff --git a/src/util/virjson.c
This allows simplification of the caller as well as will enable a later
refactor of qemuMonitorJSONMakeCommandInternal.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_migration_params.c | 9 +++--
src/qemu/qemu_monitor.c | 11 +++
src/qemu/qemu_monitor.h | 2 +-
On Thu, Dec 24, 2020 at 08:14:36AM -0600, Jonathon Jongsma wrote:
> With mediated devices, we can now define persistent node devices that
> can be started and stopped. In order to take advantage of this, we need
> an API to define new node devices.
>
> Signed-off-by: Jonathon Jongsma
> ---
...
On Thu, Dec 24, 2020 at 08:14:35AM -0600, Jonathon Jongsma wrote:
> We need to periodically query mdevctl for changes to device definitions
> since an administrator can define new devices with mdevctl outside of
> libvirt.
>
> In the future, mdevctl may add a way to signal device add/remove via
>
On Thu, Dec 24, 2020 at 08:14:34AM -0600, Jonathon Jongsma wrote:
> The udev thread handles received udev events. This is accomplished by
> setting dataReady to 'true' and signalling the thread.
>
> We also want to use this thread to handle mdev events, so we'll need to
> add another variable to
On a Wednesday in 2021, Michal Privoznik wrote:
Tested with the following change:
diff --git a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
b/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
index f6bb663e97..875e2316a0 100644
--- a/tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml
On Fri, Dec 18, 2020 at 09:56:48AM +0300, Nikolay Shirokovskiy wrote:
> Otherwise we can get misleading error messages. One example is when connection
> is broken we got "this function is not supported by the connection driver:
> virDomainMigrate3" from virDomainMigrate3.
>
> Signed-off-by:
On Fri, Dec 18, 2020 at 09:56:47AM +0300, Nikolay Shirokovskiy wrote:
> Otherwise in some places we can mistakenly report 'unsupported' error instead
> of root cause. So let's handle root cause explicitly from the macro.
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/qemu/qemu_migration.c
On Fri, Dec 18, 2020 at 09:56:46AM +0300, Nikolay Shirokovskiy wrote:
> Otherwise in some places we can mistakenly report 'unsupported' error instead
> of root cause. So let's handle root cause explicitly from the macro.
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
>
On Fri, Dec 18, 2020 at 09:56:45AM +0300, Nikolay Shirokovskiy wrote:
> Otherwise in some places we can mistakenly report 'unsupported' error instead
> of root cause. So let's handle root cause explicitly from the macro.
>
> Signed-off-by: Nikolay Shirokovskiy
> ---
> src/libvirt-domain.c | 511
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms | 2 +-
src/qemu/qemu_migration.c | 2 +-
src/util/virfile.c| 13 +
src/util/virfile.h| 1 +
src/util/virstoragefile.c | 11 ---
src/util/virstoragefile.h | 1 -
6 files
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms | 2 +-
src/storage/storage_util.c | 2 +-
src/util/virfile.c | 47 ++
src/util/virfile.h | 4
src/util/virstoragefile.c | 47
All these headers are indirectly included provided by virfile.h having
virstoragefile.h which will be removed in the following patch.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/driver.c | 1 +
src/qemu/qemu_interop_config.c | 1 +
src/qemu/qemu_shim.c
The function doesn't take virStorageSource as argument and has nothing
in common with virStorageSource or storage file.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms| 1 -
src/locking/lock_driver_lockd.c | 68 -
It is not used anywhere else.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/conf/storage_conf.c | 23 ++-
src/util/virstoragefile.c | 24
src/util/virstoragefile.h | 2 --
3 files changed, 22 insertions(+), 27 deletions(-)
diff
The last usage outside of tests was removed by commit
<780f8c94ca8b3dee7eb59c1bfbc32f672f965df8>.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms | 1 -
src/util/virstoragefile.c | 33 -
src/util/virstoragefile.h | 3 ---
The only reason why virstoragefile.h needs to be included in virfile.h
is that virFileNBDDeviceAssociate() takes virStorageFileFormat argument.
The function doesn't need the enum value as it converts the value to
string and uses only that.
Change the argument to string which will allow us to
The last user was removed by commit
<40f0e0348dfc84f28a500e262c4953b0d3b44fa0>.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms| 1 -
src/util/virstorageencryption.c | 34 -
src/util/virstorageencryption.h | 2 --
3
Function virQEMUBuildQemuImgKeySecretOpts is not used anywhere else
so there is no need to have it in util.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/libvirt_private.syms | 1 -
src/storage/storage_util.c | 74 --
src/util/virqemu.c
This series is pushed, posting only to track the changes to fix the
issues pointed out by Peter.
Pavel Hrdina (9):
util: remove unused virStorageGenerateQcowPassphrase
virstoragefile: remove unused virStorageFileChainCheckBroken
util: move virQEMUBuildQemuImgKeySecretOpts into storage
Now that individual child elements allow their children to be
interleaved, let's allow direct children of to be
interleaved too.
Signed-off-by: Michal Privoznik
---
docs/schemas/domaincommon.rng | 346 +-
1 file changed, 174 insertions(+), 172 deletions(-)
diff
The element of can have children elements
( and ). Allow them to be interleaved.
Signed-off-by: Michal Privoznik
---
docs/schemas/domaincommon.rng | 54 ++-
1 file changed, 28 insertions(+), 26 deletions(-)
diff --git a/docs/schemas/domaincommon.rng
1 - 100 of 137 matches
Mail list logo
