Re: [PATCH] libxl: Fix domain shutdown

2021-02-22 Thread Jim Fehlig
On 2/22/21 10:34 AM, Michal Privoznik wrote: On 2/22/21 6:02 PM, Jim Fehlig wrote: On 2/22/21 5:46 AM, Michal Privoznik wrote: On 2/20/21 1:19 AM, Jim Fehlig wrote: Commit fa30ee04a2 caused a regression in normal domain shutown. Initiating a shutdown from within the domain or via 'virsh

Re: [PATCH RESEND 20/20] virhostdev.c: remove missing PCI devs from hostdev manager

2021-02-22 Thread Laine Stump
On 2/22/21 4:11 PM, Daniel Henrique Barboza wrote: I learned this 20+ years ago and forgot it along the road. Heavy metal lyrics and World of Warcraft public chat aren't the best sources for learning proper English grammar, so it seems. I learned Turkish from taxi drivers and random people at

Re: [PATCH RESEND 20/20] virhostdev.c: remove missing PCI devs from hostdev manager

2021-02-22 Thread Daniel Henrique Barboza
On 2/22/21 1:12 AM, Laine Stump wrote: On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote: virHostdevReAttachPCIDevices() is called when we want to re-attach a list of hostdevs back to the host, either on the shutdown path or via a 'virsh detach-device' call.  This function always count on

Re: [PATCH] libxl: Fix domain shutdown

2021-02-22 Thread Jim Fehlig
On 2/22/21 5:46 AM, Michal Privoznik wrote: On 2/20/21 1:19 AM, Jim Fehlig wrote: Commit fa30ee04a2 caused a regression in normal domain shutown. Initiating a shutdown from within the domain or via 'virsh shutdown' does cause the guest OS running in the domain to shutdown, but libvirt never

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Peter Krempa
On Mon, Feb 22, 2021 at 19:22:49 +0100, Peter Krempa wrote: > On Mon, Feb 22, 2021 at 18:42:00 +0100, Paolo Bonzini wrote: > > On 22/02/21 15:57, Markus Armbruster wrote: > > > * The block layer's pseudo-protocol "json:" (which can get embedded in > > >image headers) > > > > If it gets

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Peter Krempa
On Mon, Feb 22, 2021 at 18:42:00 +0100, Paolo Bonzini wrote: > On 22/02/21 15:57, Markus Armbruster wrote: > > * The block layer's pseudo-protocol "json:" (which can get embedded in > >image headers) > > If it gets embedded in image headers, I don't think we'll be able to > deprecate it ever.

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Paolo Bonzini
On 22/02/21 18:54, Daniel P. Berrangé wrote: These are sent to QEMU as double-quoted strings (the single-quoted JSON is parsed to get interpolation and printed back; commit 563890c7c7, "libqtest: escape strings in QMP commands, fix leak", 2014-07-01). However, doing the interpolation requires a

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Daniel P . Berrangé
On Mon, Feb 22, 2021 at 06:42:00PM +0100, Paolo Bonzini wrote: > On 22/02/21 15:57, Markus Armbruster wrote: > > * The block layer's pseudo-protocol "json:" (which can get embedded in > >image headers) > > If it gets embedded in image headers, I don't think we'll be able to > deprecate it

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Daniel P . Berrangé
On Mon, Feb 22, 2021 at 06:47:30PM +0100, Paolo Bonzini wrote: > On 22/02/21 16:24, Daniel P. Berrangé wrote: > > This problem isn't unique to QEMU. Any app using JSON from the > > shell will have the tedium of quote escaping. JSON is incredibly > > widespread and no other apps felt it neccessary

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Paolo Bonzini
On 22/02/21 16:24, Daniel P. Berrangé wrote: This problem isn't unique to QEMU. Any app using JSON from the shell will have the tedium of quote escaping. JSON is incredibly widespread and no other apps felt it neccessary to introduce single quoting support, because the benefit doesn't outweigh

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Paolo Bonzini
On 22/02/21 15:57, Markus Armbruster wrote: * The block layer's pseudo-protocol "json:" (which can get embedded in image headers) If it gets embedded in image headers, I don't think we'll be able to deprecate it ever. We'd need to keep a converter for old images, at which point it's

Re: [PATCH] libxl: Fix domain shutdown

2021-02-22 Thread Michal Privoznik
On 2/22/21 6:02 PM, Jim Fehlig wrote: On 2/22/21 5:46 AM, Michal Privoznik wrote: On 2/20/21 1:19 AM, Jim Fehlig wrote: Commit fa30ee04a2 caused a regression in normal domain shutown. Initiating a shutdown from within the domain or via 'virsh shutdown' does cause the guest OS running in the

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Liviu Ionescu
On Mon, 22 Feb 2021 at 17:27, Daniel P. Berrangé wrote: > > IMHO we should deprecate and eventually remove single quotes +1 If a JSON cannot be directly processed by the standard JavaScript parser, it should not be used. Regards, Liviu -- Sent from my iPad via Gmail.

Re: [PATCH v2 05/13] conf: Introduce virtio-mem model

2021-02-22 Thread David Hildenbrand
On 22.02.21 17:28, Peter Krempa wrote: On Mon, Feb 22, 2021 at 16:57:11 +0100, David Hildenbrand wrote: On 22.02.21 16:46, Michal Privoznik wrote: On 2/18/21 4:00 PM, David Hildenbrand wrote: On 18.02.21 14:31, Michal Privoznik wrote: [...] In QEMU, we could make "info balloon" etc. also

Re: [PATCH v2 05/13] conf: Introduce virtio-mem model

2021-02-22 Thread Peter Krempa
On Mon, Feb 22, 2021 at 16:57:11 +0100, David Hildenbrand wrote: > On 22.02.21 16:46, Michal Privoznik wrote: > > On 2/18/21 4:00 PM, David Hildenbrand wrote: > > > On 18.02.21 14:31, Michal Privoznik wrote: [...] > In QEMU, we could make "info balloon" etc. also include virtio-mem provided >

Re: [PATCH v2 05/13] conf: Introduce virtio-mem model

2021-02-22 Thread David Hildenbrand
On 22.02.21 16:46, Michal Privoznik wrote: On 2/18/21 4:00 PM, David Hildenbrand wrote: On 18.02.21 14:31, Michal Privoznik wrote: Since now we have (possibly) two or more devices that allow memory inflation/deflation and accounting for all of them (and thus keeping updated) might be hard.

Re: [PATCH v2 05/13] conf: Introduce virtio-mem model

2021-02-22 Thread Daniel P . Berrangé
On Thu, Feb 18, 2021 at 04:00:05PM +0100, David Hildenbrand wrote: > On 18.02.21 14:31, Michal Privoznik wrote: > > The virtio-mem is paravirtualized mechanism of adding/removing > > memory to/from a VM. A virtio-mem-pci device is split into blocks > > of equal size which are then exposed (all or

Re: [PATCH v2 05/13] conf: Introduce virtio-mem model

2021-02-22 Thread Michal Privoznik
On 2/18/21 4:00 PM, David Hildenbrand wrote: On 18.02.21 14:31, Michal Privoznik wrote: Since now we have (possibly) two or more devices that allow memory inflation/deflation and accounting for all of them (and thus keeping updated) might be hard. Therefore, I'm deliberately forbidding

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Daniel P . Berrangé
On Mon, Feb 22, 2021 at 03:57:22PM +0100, Markus Armbruster wrote: > We use JSON in several external interfaces: > > * QMP > > * The guest agent's QMP > > * QAPIfied command line options when the option argument starts with > '{' > > * The block layer's pseudo-protocol "json:" (which can get

Re: A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Peter Krempa
On Mon, Feb 22, 2021 at 15:57:22 +0100, Markus Armbruster wrote: > We use JSON in several external interfaces: > > * QMP > > * The guest agent's QMP > > * QAPIfied command line options when the option argument starts with > '{' > > * The block layer's pseudo-protocol "json:" (which can get

[libvirt PATCH] NEWS: mention cgroups on hosts with systemd bug fix

2021-02-22 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- NEWS.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index bee49923a5..eac86d8a4e 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -71,6 +71,23 @@ v7.1.0 (unreleased) of relying on ``VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE`` if

A brief look at deprecating our JSON extensions over RFC 8259

2021-02-22 Thread Markus Armbruster
We use JSON in several external interfaces: * QMP * The guest agent's QMP * QAPIfied command line options when the option argument starts with '{' * The block layer's pseudo-protocol "json:" (which can get embedded in image headers) I *think* that's all. The JSON parser we use for these

Re: [libvirt PATCH] NEWS: mention support for vhost-user-blk

2021-02-22 Thread Pavel Hrdina
On Mon, Feb 22, 2021 at 03:44:53PM +0100, Peter Krempa wrote: > On Mon, Feb 22, 2021 at 15:38:41 +0100, Pavel Hrdina wrote: > > Signed-off-by: Pavel Hrdina > > --- > > NEWS.rst | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/NEWS.rst b/NEWS.rst > > index

Re: [libvirt PATCH] NEWS: mention support for vhost-user-blk

2021-02-22 Thread Peter Krempa
On Mon, Feb 22, 2021 at 15:38:41 +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > NEWS.rst | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 440dbf2601..56a9afe749 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -47,6 +47,11 @@ v7.1.0

[libvirt PATCH] NEWS: mention support for vhost-user-blk

2021-02-22 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 440dbf2601..56a9afe749 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -47,6 +47,11 @@ v7.1.0 (unreleased) to set the hostdev device's MAC address (which is a necessary

Re: [PATCH] NEWS: Mention snapshot quiesce rollback bugfix

2021-02-22 Thread Ján Tomko
On a Monday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- NEWS.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 440dbf2601..8d639253ff 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -51,6 +51,20 @@ v7.1.0 (unreleased) * **Bug fixes** +

[PATCH] NEWS: Mention snapshot quiesce rollback bugfix

2021-02-22 Thread Peter Krempa
Signed-off-by: Peter Krempa --- NEWS.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 440dbf2601..8d639253ff 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -51,6 +51,20 @@ v7.1.0 (unreleased) * **Bug fixes** + * qemu: Fix disk quiescing rollback when

Re: [libvirt PATCH v4 12/25] nodedev: Refresh mdev devices when changes are detected

2021-02-22 Thread Erik Skultety
On Thu, Feb 18, 2021 at 12:04:56PM -0600, Jonathon Jongsma wrote: > On Wed, 17 Feb 2021 14:35:51 +0100 > Erik Skultety wrote: > > > > +static void > > > +mdevctlEventHandleCallback(GFileMonitor *monitor G_GNUC_UNUSED, > > > + GFile *file, > > > +

Re: [libvirt PATCH 0/2] followup fix for cpu quota limits

2021-02-22 Thread Michal Privoznik
On 2/19/21 7:55 PM, Pavel Hrdina wrote: Pavel Hrdina (2): domain_validate: use defines for cpu period and quota limits docs: use proper cpu quota value in our documentation docs/formatdomain.rst | 8 docs/manpages/virsh.rst | 2 +-

Re: [PATCH] libxl: Fix domain shutdown

2021-02-22 Thread Michal Privoznik
On 2/20/21 1:19 AM, Jim Fehlig wrote: Commit fa30ee04a2 caused a regression in normal domain shutown. Initiating a shutdown from within the domain or via 'virsh shutdown' does cause the guest OS running in the domain to shutdown, but libvirt never reaps the domain so it is always shown in a

Re: [libvirt PATCH v4 09/25] nodedev: add mdevctl devices to node device list

2021-02-22 Thread Erik Skultety
... > > > +bool changed; > > > +virNodeDeviceDefPtr olddef = > > > virNodeDeviceObjGetDef(obj); + > > > +was_defined = virNodeDeviceObjIsPersistent(obj); > > > > "defined" as a name will do just fine > > > > > +/* Active devices contain some

[libvirt PATCH 2/5] cpu_map/sync_qemu_i386.py: Add mapping for ibrs

2021-02-22 Thread Tim Wiederhake
This was added to qemu in commit 623972ceae091b31331ae4a1dc94fe5cbb891937. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 2a16e48520..02e6724f65 100755 ---

[libvirt PATCH 5/5] cpumap: Add support for svme-addr-check CPU feature

2021-02-22 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index b03a6b065d..c43520d08f 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -554,6

[libvirt PATCH 3/5] cpu_map/sync_qemu_i386.py: Add mapping for svme-addr-check

2021-02-22 Thread Tim Wiederhake
This was added to qemu in commit 5447089c2b3b084b51670af36fc86ee3979e04be. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 02e6724f65..3febecdfd1 100755 ---

[libvirt PATCH 4/5] cpumap: Add support for ibrs CPU feature

2021-02-22 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-EPYC-7502-32-Core-host.xml | 1 + 3 files changed, 5 insertions(+) diff --git

[libvirt PATCH 1/5] cpu_map/sync_qemu_i386.py: Add mapping for amd-ssbd

2021-02-22 Thread Tim Wiederhake
This was added to qemu in commit 623972ceae091b31331ae4a1dc94fe5cbb891937. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index d2a05db77c..2a16e48520 100755 ---

[libvirt PATCH 0/5] cpu_map: Sync with Qemu

2021-02-22 Thread Tim Wiederhake
Qemu updated its list of known cpu features. Follow suit. Tim Wiederhake (5): cpu_map/sync_qemu_i386.py: Add mapping for amd-ssbd cpu_map/sync_qemu_i386.py: Add mapping for ibrs cpu_map/sync_qemu_i386.py: Add mapping for svme-addr-check cpumap: Add support for ibrs CPU feature cpumap:

Entering freeze for libvirt-7.1.0

2021-02-22 Thread Jiri Denemark
I have just tagged v7.1.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

Re: [PATCH 4/4] ui, monitor: remove deprecated VNC ACL option and HMP commands

2021-02-22 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > The VNC ACL concept has been replaced by the pluggable "authz" framework > which does not use monitor commands. > > Signed-off-by: Daniel P. Berrangé This looks OK to me, so: Reviewed-by: Dr. David Alan Gilbert however, can you explicitly

Re: [libvirt PATCH v4 05/25] nodedev: add ability to parse mdevs from mdevctl

2021-02-22 Thread Erik Skultety
On Wed, Feb 17, 2021 at 08:55:12AM -0600, Jonathon Jongsma wrote: > On Tue, 16 Feb 2021 15:20:28 -0700 > Alex Williamson wrote: > > > On Tue, 16 Feb 2021 16:00:40 -0600 > > Jonathon Jongsma wrote: > > > > > On Mon, 15 Feb 2021 18:22:08 +0100 > > > Erik Skultety wrote: > > > > > > > On Wed,

Re: [libvirt PATCH v4 03/25] nodedev: Add ability to filter by active state

2021-02-22 Thread Erik Skultety
On Thu, Feb 18, 2021 at 04:05:19PM -0600, Jonathon Jongsma wrote: > On Mon, 15 Feb 2021 18:22:41 +0100 > Erik Skultety wrote: > > > On Wed, Feb 03, 2021 at 11:38:47AM -0600, Jonathon Jongsma wrote: > > > Add two flag values for virConnectListAllNodeDevices() so that we > > > can list only node

Re: [libvirt PATCH v4 00/25] Add support for persistent mediated devices

2021-02-22 Thread Erik Skultety
On Wed, Feb 03, 2021 at 11:38:44AM -0600, Jonathon Jongsma wrote: > This patch series follows the previously-merged series which added support for > transient mediated devices. This series expands mdev support to include > persistent device definitions. Again, it relies on mdevctl as the backend.