On 2/24/21 7:52 AM, Kevin Wolf wrote:
> Add an ObjectOptions union that will eventually describe the options of
> all user creatable object types. As unions can't exist without any
> branches, also add the first object type.
>
> This adds a QAPI schema for the properties of the iothread object.
>
On 2/24/21 7:52 AM, Kevin Wolf wrote:
> The option has been deprecated in QEMU 5.0, remove it.
>
> Signed-off-by: Kevin Wolf
> ---
> qapi/qom.json| 6 +-
> docs/system/deprecated.rst | 5 -
> docs/system/removed-features.rst | 5 +
> qom/qom-qmp-cmds.c
On 2/24/21 7:52 AM, Kevin Wolf wrote:
> The 'props' option has been deprecated in 5.0 in favour of a flattened
> object-add command. Time to change our test cases to drop the deprecated
> option.
>
> Signed-off-by: Kevin Wolf
> ---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software
Adding xen-devel and Ian to cc.
On 2/24/21 6:11 AM, Daniel P. Berrangé wrote:
The following features have been deprecated for well over the 2
release cycle we promise
This reminded me of a bug report we received late last year when updating to
5.2.0. 'virsh setvcpus' suddenly stopped working
24.02.2021 16:11, Daniel P. Berrangé wrote:
The same data is available in the 'BlockDeviceInfo' struct.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
24.02.2021 16:11, Daniel P. Berrangé wrote:
The same information is available via the 'recording' and 'busy' fields.
Signed-off-by: Daniel P. Berrangé
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
Upcoming patch will remove unnecessary actions if the VM crashed. The
cleanup needs to be performed always, thus needs to be moved earlier.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_backup.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git
If the VM isn't active calculating the job stats doesn't make sense.
Additionally this prevents a crash of libvirtd if qemu terminates while
libvirt wasn't running:
Thread 28 "init-backup-tes" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffb9310640 (LWP 3201116)]
Doing so results in a crash.
Peter Krempa (2):
qemuBackupJobTerminate: Move cleanup of temp files earlier
qemuBackupJobTerminate: Don't calculate backup job stats if VM isn't
active
src/qemu/qemu_backup.c | 33 ++---
1 file changed, 18 insertions(+), 15
Move the extent formatting code into
virStorageVolDefFormatSourceExtents.
Signed-off-by: Peter Krempa
---
src/conf/storage_conf.c | 53 +++--
1 file changed, 30 insertions(+), 23 deletions(-)
diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
When the backing store of the image can't be parsed
virStorageSourceNewFromBacking returns -1. storageBackendProbeTarget
then also fails which makes the pool refresh fail or even the storage
pool becomes inactive after (re)start of libvirtd.
In situations when we can't access the backing store
Commit bc3a78f61a2aaac3 errorneously removed the return value check from
virStorageSourceNewFromBacking. In cases when we e.g. can't parse the
backing store string this leads to a crash:
#0 virStorageSourceGetActualType (def=0x0) at
../../../libvirt/src/conf/storage_source_conf.c:1014
#1
Patch 1/4 should go into this release, the rest can wait.
Peter Krempa (4):
storageBackendProbeTarget: Check return value of
virStorageSourceNewFromBacking
storageBackendProbeTarget: Don't fail if backing store can't be parsed
virStorageVolDefFormat: Extract formatting of source extents
If there are no source extents the volume XML has an empty
element. Remove it if there's nothing in it by using
virXMLFormatElement.
Signed-off-by: Peter Krempa
---
src/conf/storage_conf.c| 10 +-
tests/storagevolxml2xmlout/vol-file-backing.xml|
See https://bugzilla.redhat.com/show_bug.cgi?id=1840770
Signed-off-by: Tim Wiederhake
---
src/qemu/qemu_process.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index bfa742577f..cecf606312 100644
---
V1: https://listman.redhat.com/archives/libvir-list/2021-February/msg01275.ht=
ml
Changes since V1:
* Only check for forbidden features
* Check if `check` !=3D none
* Renamed patch
Tim Wiederhake (1):
qemuProcessUpdateGuestCPU: Check host cpu for forbidden features
src/qemu/qemu_process.c |
On 2/25/21 1:20 PM, Ján Tomko wrote:
On a Tuesday in 2021, Kristina Hanicova wrote:
In: vshTableRowNew(), vshTablePrint(), vshTablePrintToStdout().
Signed-off-by: Kristina Hanicova
---
tools/vsh-table.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git
On a Tuesday in 2021, Kristina Hanicova wrote:
In functions: virNetDevBandwidthParseRate(),
virNetDevBandwidthParse()
Signed-off-by: Kristina Hanicova
---
src/conf/netdev_bandwidth_conf.c | 42 +---
1 file changed, 17 insertions(+), 25 deletions(-)
Reviewed-by:
Hi,
On 2/24/21 10:11 AM, Daniel P. Berrangé wrote:
The newer 'query-cpus-fast' command avoids side effects on the guest
execution. Note that some of the field names are different in the
'query-cpus-fast' command.
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst
On a Tuesday in 2021, Kristina Hanicova wrote:
In files: netdev_bandwidth_conf: in virNetDevBandwidthParse(),
bridge_driver: in networkPortSetParameters(), qemu_driver: in
qemuDomainSetInterfaceParameters(), test_driver: in
testDomainSetInterfaceParameters(), virnetdevbandwidthtest: in
On a Tuesday in 2021, Kristina Hanicova wrote:
Signed-off-by: Kristina Hanicova
---
src/conf/netdev_bandwidth_conf.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Tuesday in 2021, Kristina Hanicova wrote:
In: vshTableRowNew(), vshTablePrint(), vshTablePrintToStdout().
Signed-off-by: Kristina Hanicova
---
tools/vsh-table.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/tools/vsh-table.c b/tools/vsh-table.c
index
In files: src/lxc/lxc_native: in lxcAddNetworkRouteDefinition(),
src/conf/networkcommon_conf: in virNetDevIPRouteCreate() and
virNetDevIPRouteParseXML()
Signed-off-by: Kristina Hanicova
Reviewed-by: Laine Stump
---
src/conf/networkcommon_conf.c | 55 +++
In files: src/conf/domain_conf: in virDomainNetIPInfoParseXML(),
src/lxc/lxc_native: in lxcAddNetworkRouteDefinition(),
src/vz/vz_sdk: in prlsdkGetRoutes(), src/conf/networkcommon_conf:
in virNetDevIPRouteCreate()
Signed-off-by: Kristina Hanicova
Reviewed-by: Laine Stump
---
Signed-off-by: Kristina Hanicova
---
src/conf/networkcommon_conf.c | 30 +-
1 file changed, 13 insertions(+), 17 deletions(-)
diff --git a/src/conf/networkcommon_conf.c b/src/conf/networkcommon_conf.c
index 26eeb6dbda..430d48a997 100644
---
This is v2 from
https://listman.redhat.com/archives/libvir-list/2021-February/msg01129.html
I changed variable names in patch 1/3 as suggested by Laine. Patches 2/3
and 3/3 have already been reviewed-by and I am sending them for
completeness.
This uses g_autofree (if possible) in file
I have just tagged v7.1.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
A ping to save this series from falling thru the cracks.
ср, 27 янв. 2021 г. в 11:19, Nikolay Shirokovskiy <
nshirokovs...@virtuozzo.com>:
> Polite ping.
>
> On Mon, Jan 11, 2021 at 12:49 PM Nikolay Shirokovskiy <
> nshirokovs...@virtuozzo.com> wrote:
>
>> Hi, all.
>>
>> I started this work as
On Wed, Feb 24, 2021 at 19:30:20 +0100, Jiri Denemark wrote:
> Using the job owner API name directly works fine as long as it is a
> static string or the owner's thread is still running. However, this is
> not always the case. For example, when the owner API name is filled in a
> job when we're
On Thu, Feb 25, 2021 at 08:17:09 +0100, Tim Wiederhake wrote:
> libvirt performs cpu checking if "check" is set to "partial", but skips
> checking the cpu if "check" is set to "full".
This is intentional because QEMU knows better. I wish we had no CPU
comparison in libvirt at all, but we can't do
30 matches
Mail list logo
