[libvirt PATCH 6/7] Do not check return value of VIR_REALLOC_N

Signed-off-by: Jiri Denemark --- src/bhyve/bhyve_parse_command.c | 8 +++--- src/conf/capabilities.c | 3 +-- src/conf/domain_conf.c | 11 src/conf/storage_conf.c | 3 +-- src/conf/virinterfaceobj.c | 2 +-

[libvirt PATCH 4/7] Do not check return value of VIR_EXPAND_N

Signed-off-by: Jiri Denemark --- src/access/viraccessdriverstack.c | 3 +- src/conf/backup_conf.c| 3 +- src/conf/capabilities.c | 4 +- src/conf/domain_addr.c| 6 +-- src/conf/domain_conf.c

[libvirt PATCH 3/7] util: Make virResizeN return void

Signed-off-by: Jiri Denemark --- src/util/viralloc.c | 17 + src/util/viralloc.h | 4 ++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/util/viralloc.c b/src/util/viralloc.c index 1317537c8a..cd770eb601 100644 --- a/src/util/viralloc.c +++

[libvirt PATCH 1/7] util: Drop G_GNUC_WARN_UNUSED_RESULT from reallocation APIs

Our reallocation APIs already abort on OOM and thus can only return 0. There's no need to force callers to check the result. Signed-off-by: Jiri Denemark --- src/util/viralloc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/viralloc.h b/src/util/viralloc.h

[libvirt PATCH 2/7] Do not check return value of VIR_RESIZE_N

Signed-off-by: Jiri Denemark --- src/bhyve/bhyve_capabilities.c | 5 + src/bhyve/bhyve_parse_command.c | 11 ++ src/conf/capabilities.c | 36 - src/conf/cpu_conf.c | 11 ++ src/conf/domain_capabilities.c | 5 ++---

[libvirt PATCH 0/7] Change reallocation APIs to return void

They can never return anything but zero anyway. Jiri Denemark (7): util: Drop G_GNUC_WARN_UNUSED_RESULT from reallocation APIs Do not check return value of VIR_RESIZE_N util: Make virResizeN return void Do not check return value of VIR_EXPAND_N util: Make virExpandN return void Do not

[libvirt PATCH 5/7] util: Make virExpandN return void

Signed-off-by: Jiri Denemark --- src/util/viralloc.c | 14 ++ src/util/viralloc.h | 4 ++-- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/util/viralloc.c b/src/util/viralloc.c index cd770eb601..81f5ba9a09 100644 --- a/src/util/viralloc.c +++

[libvirt PATCH 7/7] util: Make virReallocN return void

Signed-off-by: Jiri Denemark --- src/util/viralloc.c | 13 + src/util/viralloc.h | 4 ++-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/util/viralloc.c b/src/util/viralloc.c index 81f5ba9a09..cd7ae9e7d1 100644 --- a/src/util/viralloc.c +++

Re: [PATCH v1 01/12] libxl: add API wrapper for libxl_domain_create_restore

Am Thu, 18 Mar 2021 21:51:18 -0600 schrieb Jim Fehlig : > Unless someone listening has a better idea, I lean towards > libxl_api_wrapper.h > with function names libxl*Wrapper. I will rename the header, adjust the two style issues, and use these function names: libxlDomainCreateRestoreWrapper

[libvirt PATCH] qemu: Drop redundant checks for qemuCaps before virQEMUCapsGet

virQEMUCapsGet checks for qemuCaps itself, no need to do it explicitly. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 5 + src/qemu/qemu_process.c | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index

[libvirt PATCH 1/2] qemu: Use g_autofree in qemuMigrationJobCheckStatus

Signed-off-by: Jiri Denemark --- src/qemu/qemu_migration.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 79dcb4a15d..ba2ee4f081 100644 --- a/src/qemu/qemu_migration.c +++

[libvirt PATCH 2/2] qemu: Use g_autoptr in qemuMonitorJSONSetCapabilities

Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index b669630bc8..5e7f425495 100644 --- a/src/qemu/qemu_monitor_json.c +++

[libvirt PATCH 0/2] qemu: Use g_auto* in a few more places

I'll be touching these functions soon, let's modernize them first. Jiri Denemark (2): qemu: Use g_autofree in qemuMigrationJobCheckStatus qemu: Use g_autoptr in qemuMonitorJSONSetCapabilities src/qemu/qemu_migration.c| 15 +-- src/qemu/qemu_monitor_json.c | 19

[libvirt PATCH] qemu: Update asyncOwnerAPI when entering async job phase

In case an async job spans multiple APIs (e.g., incoming migration) the API that started the job is recorded as the asyncOwnerAPI even though it is no longer running and the owner thread is updated properly to the one currently handling the job. Let's also update asyncOwnerAPI to make it more

[PATCH 2/6] qemu: capabilities: Introduce QEMU_CAPS_COMPAT_DEPRECATED

The capability is asserted if qemu supports the -compat deprecated-input= and deprecated-output= settings to control what should happen if deprecated fields are used in QMP. This will be used for a developer/tester-oriented setting which will aid us in catching use of deprecated settings sooner.

[PATCH 1/6] docs/drvqemu: Convert to RST

There are two links to this document using anchors so they need to be updated as well. Signed-off-by: Peter Krempa --- docs/drvqemu.html.in| 743 docs/drvqemu.rst| 588 + docs/formatdomain.rst | 2

[PATCH 4/6] qemuxml2xmltest: Enable 'qemu-ns' case

The XML formatter validation was missing for this code path. Signed-off-by: Peter Krempa --- .../qemu-ns.x86_64-latest.xml | 51 +++ tests/qemuxml2xmltest.c | 1 + 2 files changed, 52 insertions(+) create mode 100644

[PATCH 5/6] qemu: Add per-VM control of deprecation behavior

Similar to the qemu.conf knob 'deprecation_behavior' add a per-VM knob in the QEMU namespace: Signed-off-by: Peter Krempa --- docs/drvqemu.rst | 48 +++ docs/schemas/domaincommon.rng | 16 +++ src/qemu/qemu_domain.c

[PATCH 3/6] qemu: conf: Add 'deprecation_behavior' setting to qemu.conf

New QEMU supports an harsh, but hard to ignore way to notify that the QMP user used an deprecated command. This is useful e.g. for developers to see that something needs to be fixed. This patch introduces a qemu.conf option to enable the setting in cases when qemu supports it so that developers

[PATCH 6/6] qemu: command: Handle formatting of '-compat' options

Enable '-compat' if requested in qemu.conf and supported by qemu to instruct qemu to crash when a deprecated command is used and stop returning deprecated fields. This setting is meant for libvirt developers and such. --- src/qemu/qemu_command.c | 80 +++

[PATCH 0/6] qemu: Allow control of deprecation behaviour

For debugging purposes it's very useful to disable all deprecated commands and fields in qemu. This series implements a qemu.conf knob and a qemu namespace element to control this. The implementation tries to be very conservative to allow downgrades of qemu and such without breaking the startup

[libvirt PATCH 1/3] gitignore: Ignore __pycache__ directory

Unfortunately running Python scripts causes this directory to be created in the *source* directory, and there doesn't seem to be a way to prevent that from happening. Signed-off-by: Andrea Bolognani --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore

[libvirt PATCH 3/3] syntax-check: Run flake8 on all Python scripts

Currenty we only check files that end in .py, but we have at least a couple of scripts that don't have that suffix and we nonetheless want to keep compliant with the code style. Extend the sc_flake8 syntax-check rule so that any file that contains a Python 3 shebang is fed to flake8 too.

[libvirt PATCH 0/3] Misc Python-adjacent fixes

Andrea Bolognani (3): gitignore: Ignore __pycache__ directory tests: Fix flake8 errors in virsh-auth syntax-check: Run flake8 on all Python scripts .gitignore| 3 +++ build-aux/syntax-check.mk | 6 -- tests/virsh-auth | 20 ++-- 3 files

[libvirt PATCH 2/3] tests: Fix flake8 errors in virsh-auth

Specifically E111 indentation is not a multiple of four This commit is better viewed with 'git show -w'. Signed-off-by: Andrea Bolognani --- tests/virsh-auth | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/virsh-auth b/tests/virsh-auth index

Re: [libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

On Fri, Mar 19, 2021 at 04:11:39PM +0100, Kashyap Chamarthy wrote: > On Fri, Mar 19, 2021 at 11:59:11AM +0100, Pavel Hrdina wrote: > > On Fri, Mar 19, 2021 at 11:10:05AM +0100, Kashyap Chamarthy wrote: > > > On Thu, Mar 18, 2021 at 01:26:45PM +0100, Pavel Hrdina wrote: > > [...] > > > > Nit: I'd

[libvirt PATCH v3 51/51] storage_conf: Use virXMLPropTristateXXX in virStoragePoolDefParseSource

Signed-off-by: Tim Wiederhake --- src/conf/storage_conf.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 6116b04d44..286cdf105d 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@

[libvirt PATCH v3 50/51] storage_adapter_conf: Use virXMLPropTristateXXX in virStorageAdapterParseXMLFCHost

Signed-off-by: Tim Wiederhake --- src/conf/storage_adapter_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c index 69062b4b58..a19920c8b2 100644 --- a/src/conf/storage_adapter_conf.c +++

[libvirt PATCH v3 48/51] network_conf: Use virXMLPropTristateXXX in virNetworkForwardNatDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/network_conf.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 4cf4aa4840..bbd18ba163 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@

[libvirt PATCH v3 35/51] domain_conf: Use virXMLPropTristateXXX in virDomainAudioDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c341091c99..0b5d8e5164 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt PATCH v3 49/51] numa_conf: Use virXMLPropTristateXXX in virDomainNumaDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/numa_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 64b93fd7d1..2555eeaef9 100644 --- a/src/conf/numa_conf.c +++ b/src/conf/numa_conf.c @@ -1079,17 +1079,9 @@

[libvirt PATCH v3 46/51] backup_conf: Use virXMLPropTristateXXX in virDomainBackupDefParse

Signed-off-by: Tim Wiederhake --- src/conf/backup_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index ce85ed8bad..d3ea9ce4a3 100644 --- a/src/conf/backup_conf.c +++ b/src/conf/backup_conf.c @@ -234,8

[libvirt PATCH v3 42/51] domain_conf: Use virXMLPropTristateXXX in virDomainFeaturesDefParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 146 ++--- 1 file changed, 33 insertions(+), 113 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3289c9fa12..dfa8b98aae 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH v3 47/51] device_conf: Use virXMLPropTristateXXX in virPCIDeviceAddressParseXML

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 0dd60985e9..8d0540bb02 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -214,7

[libvirt PATCH v3 10/51] conf: Use virTristateXXX in virDomainLoaderDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 26 -- src/conf/domain_conf.h | 4 ++-- 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0480fc610d..9e106b8846 100644 ---

[libvirt PATCH v3 43/51] domain_conf: Use virXMLPropTristateXXX in virDomainLoaderDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 29 + 1 file changed, 5 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index dfa8b98aae..55405d129b 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH v3 44/51] domain_conf: Use virXMLPropTristateXXX in virDomainVcpuParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 28 +--- 1 file changed, 5 insertions(+), 23 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 55405d129b..97c7a3ec28 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH v3 45/51] backup_conf: Use virXMLPropTristateXXX in virDomainBackupDiskDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/backup_conf.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index ba58b2e322..ce85ed8bad 100644 --- a/src/conf/backup_conf.c +++ b/src/conf/backup_conf.c @@ -106,7

[libvirt PATCH v3 40/51] domain_conf: Use virXMLPropTristateXXX in virDomainIOMMUDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 41 + 1 file changed, 9 insertions(+), 32 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0b009bb237..c7d2e86dfe 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH v3 16/51] virxml: Add virXMLPropTristateSwitch

Convenience function to return value of an on / off attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 41 src/util/virxml.h| 6 +- 3 files changed, 47 insertions(+), 1 deletion(-) diff

[libvirt PATCH v3 25/51] domain_conf: Use virXMLPropTristateXXX in virDomainNetDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 180 +++-- 1 file changed, 49 insertions(+), 131 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7e17ded2a1..97eb1b6f8a 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH v3 39/51] domain_conf: Use virXMLPropTristateXXX in virDomainMemoryDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4debb895e9..0b009bb237 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15705,16

[libvirt PATCH v3 41/51] domain_conf: Use virXMLPropTristateXXX in virDomainVsockDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c7d2e86dfe..3289c9fa12 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15841,17

[libvirt PATCH v3 37/51] domain_conf: Use virXMLPropTristateXXX in virDomainShmemDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6b98d34eb4..ef1a9cdab2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14358,17

[libvirt PATCH v3 38/51] domain_conf: Use virXMLPropTristateXXX in virDomainPerfEventDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ef1a9cdab2..4debb895e9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15442,7

[libvirt PATCH v3 30/51] domain_conf: Use virXMLPropTristateXXX in virDomainGraphicsDefParseXMLSDL

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 35320fe1e5..4684496522 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt PATCH v3 21/51] domain_conf: Use virXMLPropTristateXXX in virDomainDiskSourceNVMeParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4fd4fabb3f..f2fb3c8dd5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8397,7

[libvirt PATCH v3 29/51] domain_conf: Use virXMLPropTristateXXX in virDomainGraphicsDefParseXMLVNC

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 842a134220..35320fe1e5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13043,7

[libvirt PATCH v3 36/51] domain_conf: Use virXMLPropTristateXXX in virDomainMemballoonDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0b5d8e5164..6b98d34eb4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

[libvirt PATCH v3 34/51] domain_conf: Use virXMLPropTristateXXX in virDomainAudioOSSParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index afd37e3e49..c341091c99 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13837,18 +13837,12

[libvirt PATCH v3 18/51] domain_conf: Use virXMLPropTristateXXX in virDomainVirtioOptionsParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7dfbca12e5..6997b7d743 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH v3 28/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseLog

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0f3be88235..842a134220 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11812,20

[libvirt PATCH v3 33/51] domain_conf: Use virXMLPropTristateXXX in virDomainAudioJackParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index dff554874f..afd37e3e49 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13822,19

[libvirt PATCH v3 32/51] domain_conf: Use virXMLPropTristateXXX in virDomainAudioCommonParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d78d09a4b9..dff554874f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13716,8

[libvirt PATCH v3 05/51] conf: Use virTristateXXX in virDomainActualNetDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 17 + src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 014f318dcd..8e94860b51 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH v3 31/51] domain_conf: Use virXMLPropTristateXXX in virDomainGraphicsDefParseXMLSpice

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 75 ++ 1 file changed, 10 insertions(+), 65 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4684496522..d78d09a4b9 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH v3 09/51] conf: Use virTristateXXX in virDomainMemballoonDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 26 -- src/conf/domain_conf.h | 4 ++-- 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e99699028a..0480fc610d 100644 ---

[libvirt PATCH v3 19/51] domain_conf: Use virXMLPropTristateXXX in virDomainDeviceInfoParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6997b7d743..920078a706 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c

[libvirt PATCH v3 20/51] domain_conf: Use virXMLPropTristateXXX in virDomainDiskSourceNetworkParse

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 920078a706..4fd4fabb3f 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8274,7

[libvirt PATCH v3 23/51] domain_conf: Use virXMLPropTristateXXX in virDomainActualNetDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f17c979e31..6a43fb2588 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10435,7

[libvirt PATCH v3 24/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceReconnectDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6a43fb2588..7e17ded2a1 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10618,7

[libvirt PATCH v3 22/51] domain_conf: Use virXMLPropTristateXXX in virDomainDiskDefDriverParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 36 ++-- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f2fb3c8dd5..f17c979e31 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH v3 27/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseFile

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7fb096e6d9..0f3be88235 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11777,20

[libvirt PATCH v3 26/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseTCP

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 97eb1b6f8a..7fb096e6d9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11703,17

[libvirt PATCH v3 15/51] virxml: Add virXMLPropTristateBool

Convenience function to return value of a yes / no attribute. Signed-off-by: Tim Wiederhake --- src/libvirt_private.syms | 1 + src/util/virxml.c| 41 src/util/virxml.h| 5 + 3 files changed, 47 insertions(+) diff --git

[libvirt PATCH v3 17/51] domain_conf: Use virXMLPropTristateXXX in virDomainKeyWrapCipherDefParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9e106b8846..7dfbca12e5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1447,10

[libvirt PATCH v3 12/51] conf: Use virTristateXXX in virStorageAdapterFCHost

Signed-off-by: Tim Wiederhake --- src/conf/storage_adapter_conf.c | 4 +++- src/conf/storage_adapter_conf.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c index 77ecb8d5f2..69062b4b58 100644 ---

[libvirt PATCH v3 06/51] conf: Use virTristateXXX in virDomainNetDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 17 + src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8e94860b51..9f59756119 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH v3 11/51] conf: Use virTristateXXX in virDomainDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index d6ca5e9725..25af058241 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2755,7 +2755,7 @@ struct

[libvirt PATCH v3 14/51] conf: Use virTristateXXX in virPCIDeviceAddress

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.c | 16 +--- src/util/virpci.h | 2 +- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 714ac50762..0dd60985e9 100644 --- a/src/conf/device_conf.c +++

[libvirt PATCH v3 04/51] conf: Use virTristateXXX in virDomainDiskDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 39 --- src/conf/domain_conf.h | 6 +++--- 2 files changed, 27 insertions(+), 18 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 43789fa2c7..014f318dcd 100644 ---

[libvirt PATCH v3 03/51] conf: Use virTristateXXX in virDomainDeviceInfo

Signed-off-by: Tim Wiederhake --- src/conf/device_conf.h | 4 ++-- src/conf/domain_conf.c | 26 -- src/qemu/qemu_command.c | 3 ++- src/qemu/qemu_hotplug.c | 2 +- 4 files changed, 21 insertions(+), 14 deletions(-) diff --git a/src/conf/device_conf.h

[libvirt PATCH v3 13/51] conf: Use virTristateXXX in virStoragePoolSourceDevice

Signed-off-by: Tim Wiederhake --- src/conf/storage_conf.c | 7 --- src/conf/storage_conf.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 2e07c81f8a..6116b04d44 100644 --- a/src/conf/storage_conf.c +++

[libvirt PATCH v3 08/51] conf: Use virTristateXXX in virDomainGraphicsDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 6619b9f006..09b697432d 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1862,7 +1862,7 @@ struct

[libvirt PATCH v3 01/51] conf: Use virTristateXXX in virStorageSource

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 12 src/conf/storage_source_conf.h | 2 +- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 7671050134..3d24479f28 100644 ---

[libvirt PATCH v3 07/51] conf: Use virTristateXXX in virDomainChrSourceDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 34 +- src/conf/domain_conf.h | 6 +++--- 2 files changed, 24 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9f59756119..e99699028a 100644 ---

[libvirt PATCH v3 02/51] conf: Use virTristateXXX in virStorageSourceNVMeDef

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 4 +++- src/conf/storage_source_conf.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3d24479f28..27eb98d93c 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH v3 00/51] Refactor XML parsing boilerplate code

This series replaces some recurring boilerplate code in src/conf/ regarding the extraction of a virTristate(Switch|Bool) XML attribute. The boilerplate code looks roughly like this, g_autofree char *str = NULL; if (str = virXMLPropString(node, ...)) { int val; if ((val =

[libvirt PATCH] ci: Drop prefix from Dockerfiles

Since the string "ci" is already contained in the path, it seems unnecessary to include it into the filename too: in fact, we only do that for Dockerfiles and not for files in ci/cirrus, even though those are generated the very same way. Signed-off-by: Andrea Bolognani --- .gitlab-ci.yml

Re: [libvirt PATCH 8/9] conf: introduce support for firmware auto-selection feature filtering

On Fri, Mar 19, 2021 at 11:59:11AM +0100, Pavel Hrdina wrote: > On Fri, Mar 19, 2021 at 11:10:05AM +0100, Kashyap Chamarthy wrote: > > On Thu, Mar 18, 2021 at 01:26:45PM +0100, Pavel Hrdina wrote: [...] > > Nit: I'd recast it as: "When using firmware auto-selection, different > > features are

Re: [PATCH 3/3] NEWS: Mention support for full backups via virDomainBackupBegin

On 3/18/21 11:45 AM, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > NEWS.rst | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 9d819a3cf2..c2013ecac9 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -24,6 +24,15 @@ v7.2.0 (unreleased) >

[PATCH v4 11/13] qemuxml2argvtest: Add DO_CAPS_LATEST variant of 'numatune-memnode'

The test has interesting config of the memory backend object. Preserve the 5.2 output too since it's prior to JSONification. Signed-off-by: Peter Krempa --- .../numatune-memnode.x86_64-5.2.0.args| 43 +++ .../numatune-memnode.x86_64-latest.args | 43

[PATCH v4 02/13] virQEMUQAPISchemaTraverse: Fix quoting in comment

It tripped up highlighter in my editor. Signed-off-by: Peter Krempa --- src/qemu/qemu_qapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_qapi.c b/src/qemu/qemu_qapi.c index f7e4ca9324..f4047f507a 100644 --- a/src/qemu/qemu_qapi.c +++ b/src/qemu/qemu_qapi.c

[PATCH v4 07/13] qemu: command: Use JSON for QAPIfied -object directly

Skip the lossy conversion to legacy commandline arguments by using the JSON props directly when -object is QAPIfied. This avoids issues with conversion of bitmaps and also allows validation of the generated JSON against the QMP schema in the tests. Since the new approach is triggered by a qemu

[PATCH v4 03/13] qemu: capabilities: Introduce QEMU_CAPS_OBJECT_QAPIFIED

Starting from qemu-6.0 the parameters of -object/object-add are formally described by the QAPI schema. Additionally this changes the nesting of the properties as the 'props' nested object will be flattened to the parent. We'll need to detect whether qemu switched to this new approach to generate

[PATCH v4 09/13] qemumonitorjsontest: Remove tripwire guarding object-add QAPIfication

Libvirt is now prepared for QAPIfied object-add. Signed-off-by: Peter Krempa --- tests/qemumonitorjsontest.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 82c74e2ef9..48b41c908a 100644 ---

[PATCH v4 12/13] qemuxml2argvtest: Pin examples of -object usage to qemu-5.2 caps

Add a selection of tests making exapmple use of -object prior to change to the JSON format for -object. Signed-off-by: Peter Krempa --- ...disk-network-tlsx509-nbd.x86_64-5.2.0.args | 50 ...virtio-scsi-reservations.x86_64-5.2.0.args | 55 +

[PATCH v4 08/13] tests: qemuxml2argv: Validate generation of JSON props for object-add

Similarly to the validation for blockdev-add and netdev_add, use the qemuxml2argv test repository to drive validation of props for object-add. Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

[PATCH v4 05/13] qemuMonitorCreateObjectPropsWrap: Open-code in qemuBuildMemoryBackendProps

There's just one caller left. Since qemuBuildMemoryBackendProps is too complex to be modified for now, just move the adding of 'id' and 'qom' type directly into the function. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 6 -- src/qemu/qemu_monitor.c | 15 ---

[PATCH v4 01/13] qemuxml2argvdata: Remove unused output file 'disk-network-tlsx509.x86_64-latest.args'

Signed-off-by: Peter Krempa --- .../disk-network-tlsx509.x86_64-latest.args | 90 --- 1 file changed, 90 deletions(-) delete mode 100644 tests/qemuxml2argvdata/disk-network-tlsx509.x86_64-latest.args diff --git a/tests/qemuxml2argvdata/disk-network-tlsx509.x86_64-latest.args

[PATCH v4 06/13] qemu: monitor: Don't add 'props' wrapper if qemu has QEMU_CAPS_OBJECT_QAPIFIED

Set 'objectAddNoWrap' when the capability is present. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index d26ea94803..6b32c4cfe3 100644 --- a/src/qemu/qemu_monitor.c +++

[PATCH v4 04/13] qemu: monitor: Make wrapping of 'props' of 'object-add' optional

Construct the JSON object which is used for object-add without the 'props' wrapper and add the wrapper only in the monitor code. This simplifies the JSON->commandline generator in the first place and also prepares for upcoming qemu where 'props' will be removed. Signed-off-by: Peter Krempa ---

[PATCH v4 00/13] qemu: Prepare for -object QAPIfication

The qemu changes are merged upstream now, so this series is now required to ensure qemu compatibility with 'object_add' (support for 'props' sub-object is now dropped from qemu, but libvirt would still use it) and also to allow further updates of capability test data, as the build would fail now

Re: [libvirt PATCH v2 09/51] conf: Use virTristateXXX in virDomainMemballoonDef

On Fri, Mar 19, 2021 at 15:16:49 +0100, Tim Wiederhake wrote: > On Fri, 2021-03-19 at 15:00 +0100, Peter Krempa wrote: > > On Fri, Mar 19, 2021 at 14:40:23 +0100, Tim Wiederhake wrote: > > > Signed-off-by: Tim Wiederhake > > > --- > > > src/conf/domain_conf.h | 4 ++-- > > > 1 file changed, 2

Re: [libvirt PATCH v2 09/51] conf: Use virTristateXXX in virDomainMemballoonDef

On Fri, 2021-03-19 at 15:00 +0100, Peter Krempa wrote: > On Fri, Mar 19, 2021 at 14:40:23 +0100, Tim Wiederhake wrote: > > Signed-off-by: Tim Wiederhake > > --- > > src/conf/domain_conf.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/conf/domain_conf.h

Re: [libvirt PATCH v2 09/51] conf: Use virTristateXXX in virDomainMemballoonDef

On Fri, Mar 19, 2021 at 14:40:23 +0100, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > src/conf/domain_conf.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h > index 09b697432d..2d342effb1 100644 > ---

[libvirt PATCH v2 19/51] domain_conf: Use virXMLPropTristateXXX in virDomainDeviceInfoParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c8411bdf40..91dc00edad 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6620,8

[libvirt PATCH v2 46/51] backup_conf: Use virXMLPropTristateXXX in virDomainBackupDefParse

Signed-off-by: Tim Wiederhake --- src/conf/backup_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/backup_conf.c b/src/conf/backup_conf.c index ce85ed8bad..d3ea9ce4a3 100644 --- a/src/conf/backup_conf.c +++ b/src/conf/backup_conf.c @@ -234,8

[libvirt PATCH v2 50/51] storage_adapter_conf: Use virXMLPropTristateXXX in virStorageAdapterParseXMLFCHost

Signed-off-by: Tim Wiederhake --- src/conf/storage_adapter_conf.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c index 69062b4b58..a19920c8b2 100644 --- a/src/conf/storage_adapter_conf.c +++

[libvirt PATCH v2 22/51] domain_conf: Use virXMLPropTristateXXX in virDomainDiskDefDriverParseXML

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 39b1e237f5..ef7eed5682 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

  1   2   >