Re: [PATCH v2 00/12] libxl: bump LIBXL_API_VERSION

2021-03-30 Thread Jim Fehlig
On 3/25/21 10:26 AM, Olaf Hering wrote: Various changes to handle libxl API variants. Olaf v2: - adjust names of wrapper functions adjust indent adjust style of braces rename new header Olaf Hering (12): libxl: add API wrapper for libxl_domain_create_restore libxl: add API

Re: [PATCH v2 07/12] libxl: add API wrapper for libxl_domain_need_memory

2021-03-30 Thread Jim Fehlig
On 3/25/21 10:26 AM, Olaf Hering wrote: Upcoming changes will use different LIBXL_API_VERSION variants. Prepare libxl_domain_need_memory, which changed the storage size of "need_memkb" in Xen 4.8. With Xen 4.12 the libxl_domain_config parameter was changed Let's hope third time is a charm

RE: [PATCH-for-5.2] target/mips: Deprecate nanoMIPS ISA

2021-03-30 Thread Vince Del Vecchio
[Sorry for the resend; original seems to have been corrupted] On 11/2/20 12:27 PM, Philippe Mathieu-Daudé wrote: > The nanoMIPS ISA has been announced in 2018 for various projects: > > GCC: https://gcc.gnu.org/legacy-ml/gcc/2018-05/msg00012.html > Linux: https://lwn.net/Articles/753605/ >

Re: [libvirt PATCH v6 16/30] api: add virNodeDeviceDefineXML()

2021-03-30 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:12AM -0500, Jonathon Jongsma wrote: > With mediated devices, we can now define persistent node devices that > can be started and stopped. In order to take advantage of this, we need > an API to define new node devices. > > Signed-off-by: Jonathon Jongsma > --- >

Re: [libvirt PATCH v6 14/30] nodedev: Refresh mdev devices when changes are detected

2021-03-30 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:10AM -0500, Jonathon Jongsma wrote: > We need to query mdevctl for changes to device definitions since an > administrator can define new devices by executing mdevctl outside of > libvirt. > > In the future, mdevctl may add a way to signal device add/remove via >

Re: [PATCH] already removed obj is not allowed to acquire job

2021-03-30 Thread Martin Kletzander
On Tue, Mar 30, 2021 at 04:36:41PM +0800, Hogan Wang wrote: From: Zhuang Shengen a removed vm begin a job may cause unanticipated results.so add judgement in qemuDomainObjBeginJobInternal to forbid a removed obj acquire the job Actually what I meant was that there is some part of the code

Re: [libvirt][PATCH v4 0/3] introduce 'restrictive' mode in numatune

2021-03-30 Thread Martin Kletzander
On Tue, Mar 30, 2021 at 08:53:19AM +, Zhong, Luyao wrote: -Original Message- From: Martin Kletzander Sent: Thursday, March 25, 2021 10:28 PM To: Daniel P. Berrangé Cc: Zhong, Luyao ; libvir-list@redhat.com Subject: Re: [libvirt][PATCH v4 0/3] introduce 'restrictive' mode in

Re: [libvirt PATCH v6 13/30] nodedev: handle mdevs that disappear from mdevctl

2021-03-30 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:09AM -0500, Jonathon Jongsma wrote: > mdevctl does not currently provide any events when the list of defined > devices changes, so we will need to poll mdevctl for the list of defined > devices periodically. When a mediated device no longer exists from one > iteration

Re: [libvirt PATCH v6 12/30] nodedev: add helper functions to remove node devices

2021-03-30 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:08AM -0500, Jonathon Jongsma wrote: > When a mediated device is stopped or undefined by an application outside > of libvirt, we need to remove it from our list of node devices within > libvirt. This patch introduces virNodeDeviceObjListRemoveLocked() and >

Re: [libvirt PATCH v6 28/30] nodedev: add docs about mdev attribute order

2021-03-30 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:24AM -0500, Jonathon Jongsma wrote: > Mention that mdev attribute order is significant. > > Signed-off-by: Jonathon Jongsma > --- Reviewed-by: Erik Skultety

Re: [libvirt PATCH v6 29/30] nodedev: factor out function to add mediated devices

2021-03-30 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:25AM -0500, Jonathon Jongsma wrote: > To accomodate re-use of this functionality in a following patch, split > out the processing of an individual mdev definition into a separate > function. > --- > src/node_device/node_device_driver.c | 103

Re: [libvirt PATCH v6 30/30] nodedev: avoid delay when defining a new mdev

2021-03-30 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:26AM -0500, Jonathon Jongsma wrote: > When calling virNodeDeviceDefineXML() to define a new mediated device, > we call virMdevctlDefine() and then wait for the new device to appear in > the driver's device list before returning. This caused long delays due > to the

[PATCH] virfile: Replace AbsPath judgement method with g_path_is_absolute()

2021-03-30 Thread Luke Yue
The g_path_is_absolute() considers more situations than just a simply "path[0] == '/'". Related issue: https://gitlab.com/libvirt/libvirt/-/issues/12 Signed-off-by: Luke Yue --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c

Re: Ways to deal with broken machine types

2021-03-30 Thread David Edmondson
On Tuesday, 2021-03-23 at 15:40:24 -04, Michael S. Tsirkin wrote: > On Tue, Mar 23, 2021 at 05:40:36PM +, Daniel P. Berrangé wrote: >> On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote: >> > Let me hijack this thread for beyond this case scope. >> > >> > I agree that for this

Re: [Libvirt] Attach qemu commands to an running xml domain

2021-03-30 Thread Peter Krempa
On Tue, Mar 30, 2021 at 11:49:51 +, Waleed Musa wrote: Your reply email looks very broken, but I think I can find the relevant parts: > > From: Peter Krempa > Sent: Tuesday, March 30, 2021 01:42 PM > To: Waleed Musa > Cc: libvir-list@redhat.com ; Moshe Levi

Re: Ways to deal with broken machine types

2021-03-30 Thread Michael S. Tsirkin
On Tue, Mar 30, 2021 at 12:21:37PM +0100, David Edmondson wrote: > > Unfortunately I do not think this is practical :(. > > > > All examples of breakage I am aware of, we did not > > realise some part of interface was part of guest ABI > > and unsafe to change. We simply would not know to write a

Re: [Libvirt] Attach qemu commands to an running xml domain

2021-03-30 Thread Waleed Musa
From: Peter Krempa Sent: Tuesday, March 30, 2021 01:42 PM To: Waleed Musa Cc: libvir-list@redhat.com ; Moshe Levi ; Adrian Chiris Subject: Re: [Libvirt] Attach qemu commands to an running xml domain External email: Use caution opening links or attachments

Re: [PATCH] NEWS: Mention fix for exec-restart of virtlo(g|ck)d and 'object_add' improvements

2021-03-30 Thread Andrea Bolognani
On Tue, 2021-03-30 at 10:32 +0200, Peter Krempa wrote: > * **Improvements** > > + * qemu: Compatibility with ``qemu-6.0`` for certain hot-(un)-plug > operations > + > +Libvirt ``7.2.0`` is required for compatibility with the upcoming > +``qemu-6.0`` release for hotplug and hotunplug of

libvirt-7.2.0 release candidate 2

2021-03-30 Thread Jiri Denemark
I have just tagged v7.2.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

Re: [Libvirt] Attach qemu commands to an running xml domain

2021-03-30 Thread Peter Krempa
On Tue, Mar 30, 2021 at 09:35:48 +, Waleed Musa wrote: > Hi all, > > I see in libvirt you are supporting attach/detach devices to existing xml > domain using attachDeviceFlags and detachDeviceFlags APIs. > Now we are adding some qemu command to the xml domain related to some > interfaces

[Libvirt] Attach qemu commands to an running xml domain

2021-03-30 Thread Waleed Musa
Hi all, I see in libvirt you are supporting attach/detach devices to existing xml domain using attachDeviceFlags and detachDeviceFlags APIs. Now we are adding some qemu command to the xml domain related to some interfaces using alias names before starting the VM, but we will face an issue with

RE: [libvirt][PATCH v4 0/3] introduce 'restrictive' mode in numatune

2021-03-30 Thread Zhong, Luyao
> -Original Message- > From: Martin Kletzander > Sent: Thursday, March 25, 2021 10:28 PM > To: Daniel P. Berrangé > Cc: Zhong, Luyao ; libvir-list@redhat.com > Subject: Re: [libvirt][PATCH v4 0/3] introduce 'restrictive' mode in numatune > > On Thu, Mar 25, 2021 at 02:14:47PM +,

[PATCH] already removed obj is not allowed to acquire job

2021-03-30 Thread Hogan Wang
From: Zhuang Shengen a removed vm begin a job may cause unanticipated results.so add judgement in qemuDomainObjBeginJobInternal to forbid a removed obj acquire the job Signed-off-by: Zhuang Shengen Reviewed-by: Hogan Wang --- src/qemu/qemu_domainjob.c | 7 +++ 1 file changed, 7

[PATCH] NEWS: Mention fix for exec-restart of virtlo(g|ck)d and 'object_add' improvements

2021-03-30 Thread Peter Krempa
Mention that libvirt-7.2 will be needed to do stuff that executes 'object-add'/'object-del' QMP commands with the upcoming qemu-6.0 and that exec-restart of virtlockd and virtlogd was fixed. Signed-off-by: Peter Krempa --- NEWS.rst | 12 1 file changed, 12 insertions(+) diff --git

[PATCH 1/3] tests: negative test for hugepages with anonymous memory backing

2021-03-30 Thread Han Han
Signed-off-by: Han Han --- .../qemuxml2argvdata/hugepages-anonymous.err | 1 + .../qemuxml2argvdata/hugepages-anonymous.xml | 25 +++ tests/qemuxml2argvtest.c | 1 + 3 files changed, 27 insertions(+) create mode 100644

[PATCH 0/3] tests: qemuxml2argv negative tests for hugepages and numatune

2021-03-30 Thread Han Han
Han Han (3): tests: negative test for hugepages with anonymous memory backing tests: negative test for hugepages with ondemand mode tests: negative test of binding memnode cellid to an nonexist guest cell .../qemuxml2argvdata/hugepages-anonymous.err | 1 +

[PATCH 3/3] tests: negative test of binding memnode cellid to an nonexist guest cell

2021-03-30 Thread Han Han
Signed-off-by: Han Han --- ...une-memnode-cellid-nonexist-guest-cell.err | 1 + ...une-memnode-cellid-nonexist-guest-cell.xml | 31 +++ tests/qemuxml2argvtest.c | 1 + 3 files changed, 33 insertions(+) create mode 100644

[PATCH 2/3] tests: negative test for hugepages with ondemand mode

2021-03-30 Thread Han Han
Signed-off-by: Han Han --- tests/qemuxml2argvdata/hugepages-ondemand.err | 1 + tests/qemuxml2argvdata/hugepages-ondemand.xml | 25 +++ tests/qemuxml2argvtest.c | 1 + 3 files changed, 27 insertions(+) create mode 100644