[PATCH V2] tests: Fix qemuxml2xmltest with audio driver defined in env

If QEMU_AUDIO_DRV is defined in the build host environment, several tests in qemuxml2xmltest fail. $ env | grep -i audio AUDIODRIVER=pulseaudio QEMU_AUDIO_DRV=pa SDL_AUDIODRIVER=pulse An example test failure with the above environment 907) QEMU XML-2-XML-active video-virtio-gpu-sdl-gl In

[PATCH] tests: Fix qemuxml2xmltest with audio driver defined in env

If QEMU_AUDIO_DRV is defined in the build host environment, several tests in qemuxml2xmltest fail. $ env | grep -i audio AUDIODRIVER=pulseaudio QEMU_AUDIO_DRV=pa SDL_AUDIODRIVER=pulse An example test failure with the above environment 907) QEMU XML-2-XML-active video-virtio-gpu-sdl-gl In

Re: [PATCH RFC 0/3] Add checkpoint/restore support to LXC using CRIU

On Thu, Apr 01, 2021 at 10:16:36AM -0300, Julio Faracco wrote: Hi Michal and Martin, Thanks for your reply. Just an explanation. I'm not interested directly in developing this specific feature. If there is a GSoC student addressed to this... Excellent. I'm interested in developing snapshot and

Re: [libvirt PATCH] downloads.html: Add a link to GPG key used signing releases

On a Thursday in 2021, Jiri Denemark wrote: While the key is available on public GPG key servers, having it locally at https://libvirt.org/sources/gpg_key.asc is even better. I don't remember where but I think someone was trying to find the key used to sign libvirt-glib. Also, Pavel uses his

Re: [PATCH V2] tests: Fix qemuxml2xmltest with audio driver defined in env

On Thu, Apr 01, 2021 at 11:44:59AM -0600, Jim Fehlig wrote: > If QEMU_AUDIO_DRV is defined in the build host environment, several tests > in qemuxml2xmltest fail. > > $ env | grep -i audio > AUDIODRIVER=pulseaudio > QEMU_AUDIO_DRV=pa > SDL_AUDIODRIVER=pulse > > An example test failure with the

Re: [libvirt PATCH] downloads.html: Add a link to GPG key used signing releases

On Thu, 2021-04-01 at 17:36 +0200, Jiri Denemark wrote: > While the key is available on public GPG key servers, having it locally > at https://libvirt.org/sources/gpg_key.asc is even better. > > Signed-off-by: Jiri Denemark > --- > docs/downloads.html.in | 4 +++- > 1 file changed, 3

Re: [PATCH] tests: Fix qemuxml2xmltest with audio driver defined in env

On Thu, Apr 01, 2021 at 11:10:28AM -0600, Jim Fehlig wrote: > If QEMU_AUDIO_DRV is defined in the build host environment, several tests > in qemuxml2xmltest fail. > > $ env | grep -i audio > AUDIODRIVER=pulseaudio > QEMU_AUDIO_DRV=pa > SDL_AUDIODRIVER=pulse > > An example test failure with the

[libvirt PATCH] downloads.html: Add a link to GPG key used signing releases

While the key is available on public GPG key servers, having it locally at https://libvirt.org/sources/gpg_key.asc is even better. Signed-off-by: Jiri Denemark --- docs/downloads.html.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/downloads.html.in

Re: [libvirt PATCH v6 00/30] Add support for persistent mediated devices

On Wed, 31 Mar 2021 16:00:48 +0200 Erik Skultety wrote: > On Fri, Mar 26, 2021 at 11:47:56AM -0500, Jonathon Jongsma wrote: > > This patch series follows the previously-merged series which added > > support for transient mediated devices. This series expands mdev > > support to include

[libvir PATCH] run: fix flake8 violations

Two blank lines are needed either side of functions. Comments must have a single space character immediately after the "#". The unused exception variable can be removed. Signed-off-by: Daniel P. Berrangé --- I dropped the ball by not running syntax check on the 'run' script changes. Pushed

[PATCH 12/39] util: virlog: Remove pointless 'cleanup' labels

Previous refactors left empty cleanup labels. Remove them. Signed-off-by: Peter Krempa --- src/util/virlog.c | 47 +-- 1 file changed, 17 insertions(+), 30 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 4782f6f27d..004792db01

[PATCH 20/39] virshParseRateStr: Refactor cleanup

Use g_auto for the string list and remove 'ret' and 'cleanup:'. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 86de4255fa..37be298809 100644 ---

[PATCH 38/39] util: virstring: Remove the virStringSplitCount wrapper funcion

Callers which need the count of elements now count it in place. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/util/virstring.c | 20 src/util/virstring.h | 6 -- 3 files changed, 27 deletions(-) diff --git a/src/libvirt_private.syms

[PATCH 25/39] storage: zfs: Use g_strsplit instead of virStringSplitCount

Both instances just check the length once. Replicate that faithfully. Signed-off-by: Peter Krempa --- src/storage/storage_backend_zfs.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index

[PATCH 26/39] virResctrlGetCacheInfo: Restrict variable scope and use automatic freeing

Move variables into the loop which uses them and use automatic freeing for temporarily allocated variables. Signed-off-by: Peter Krempa --- src/util/virresctrl.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/src/util/virresctrl.c

[PATCH 37/39] virVMXParseConfig: Replace virStringSplitCount by g_strsplit

Remove the last usage of virStringSplitCount Signed-off-by: Peter Krempa --- src/vmx/vmx.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 0b12b5dd7d..7832fd143e 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -1574,18 +1574,17 @@

[PATCH 24/39] virStorageBackendZFSRefreshPool: Reduce scope of 'tokens'

Declare it in the loop that actually uses it. Signed-off-by: Peter Krempa --- src/storage/storage_backend_zfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c index cab1fd1637..6fed25cf4d 100644 ---

[PATCH 27/39] virResctrlAllocNewFromInfo: Restrict variable scope and use automatic freeing

Move variables into the loop which uses them and use automatic freeing for temporarily allocated variables. Signed-off-by: Peter Krempa --- src/util/virresctrl.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index

[PATCH 15/39] virLogParseFilter: Replace virStringSplitCount by g_strsplit

We don't really need the count. Signed-off-by: Peter Krempa --- src/util/virlog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 57eb0de538..8a4cfbfdc2 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1556,7 +1556,6

[PATCH 33/39] xenParsePCI: Replace virStringSplitCount by g_strsplit

Count the number of elements in place just for the check. Signed-off-by: Peter Krempa --- src/libxl/xen_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 835f48ec42..49a816add2 100644 ---

[PATCH 31/39] util: virresctrl: Remove empty 'cleanup' sections

Signed-off-by: Peter Krempa --- src/util/virresctrl.c | 111 +++--- 1 file changed, 39 insertions(+), 72 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 6d8e669852..73b0061937 100644 --- a/src/util/virresctrl.c +++

[PATCH 36/39] virSystemdActivationInitFromNames: Replace virStringSplit by g_strsplit

While the code invokes the string list length calculation twice, it happens only on error path, which by itself should never happen. Signed-off-by: Peter Krempa --- src/util/virsystemd.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/util/virsystemd.c

[PATCH 32/39] util: virresctrl: Use g_strsplit instead of virStringSplitCount

In 3 of 4 instances the code didn't even need the count of the elements. Signed-off-by: Peter Krempa --- src/util/virresctrl.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index

[PATCH 35/39] openvzParseBarrierLimit: Rework string handling

Use g_strsplit instead of virStringSplitCount and automatically free the temporary string list. Signed-off-by: Peter Krempa --- src/openvz/openvz_conf.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c

[PATCH 22/39] virStorageSourceParseBackingJSONUriCookies: Use g_strsplit instead of virStringSplitCount

Count the elements after splitting the string. Signed-off-by: Peter Krempa --- src/storage_file/storage_source_backingstore.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/storage_file/storage_source_backingstore.c

[PATCH 39/39] tests: string: Remove pointless test for virStringListFreeCount

It's way more useful to run valgrind against the rest of the code than this test to see whether virStringListFreeCount works. Remove the test. Signed-off-by: Peter Krempa --- tests/virstringtest.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/tests/virstringtest.c

[PATCH 17/39] virshParseEventStr: Use g_strsplit and automatic memory freeing

Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index a778421b66..86de4255fa 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9342,24

[PATCH 34/39] xenParseXLVnuma: Replace virStringSplitCount by g_strsplit

Signed-off-by: Peter Krempa --- src/libxl/xen_xl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index 65cd26bb21..e8a75979d4 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -523,9 +523,11 @@ xenParseXLVnuma(virConfPtr

[PATCH 05/39] virStorageFileBackendGlusterPriv: Remove 'canonpaht'

Signed-off-by: Peter Krempa --- src/storage_file/storage_file_backend_gluster.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/storage_file/storage_file_backend_gluster.c b/src/storage_file/storage_file_backend_gluster.c index 252eb523af..0cd4cf9f62 100644 ---

[PATCH 14/39] virLogParseFilters: Refactor string list handling

Rewrite the code to remove the need to calculate the string list count. Signed-off-by: Peter Krempa --- src/util/virlog.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 56059f62f1..57eb0de538 100644 ---

[PATCH 28/39] virResctrlAllocNewFromInfo: Use g_autoptr for 'ret'

Remove 'cleanup' and 'error' labels by switching 'ret' to automatic pointer and stealing it in the return statement. Signed-off-by: Peter Krempa --- src/util/virresctrl.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/util/virresctrl.c

[PATCH 30/39] util: virresctrl: Use automatic memory freeing

Signed-off-by: Peter Krempa --- src/util/virresctrl.c | 53 ++- 1 file changed, 17 insertions(+), 36 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 53c202f99f..6d8e669852 100644 --- a/src/util/virresctrl.c +++

[PATCH 11/39] util: virlog: Use g_auto(GStrv) instead of g_strfreev in cleanup section

Signed-off-by: Peter Krempa --- src/util/virlog.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 934c96915b..4782f6f27d 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1459,7 +1459,7 @@ virLogOutputPtr

[PATCH 03/39] Remove virStorageSourceGetUniqueIdentifier file backend API

The API isn't used any more. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/storage_file/storage_file_backend.h | 4 -- src/storage_file/storage_file_backend_fs.c| 24 --- .../storage_file_backend_gluster.c| 71

[PATCH 23/39] storage: zfs: Don't split string if we need only first/last component

Use str(r)chr to find the correct bit rather than fully splitting the string. Signed-off-by: Peter Krempa --- src/storage/storage_backend_zfs.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/storage/storage_backend_zfs.c

[PATCH 29/39] virResctrlAllocGetUnused: Use g_autoptr for variables of virResctrlAlloc type

Refactor the handling of variables so that the cleanup section can be sanitized. Signed-off-by: Peter Krempa --- src/util/virresctrl.c | 32 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index

[PATCH 07/39] Remove virStorageFileCanonicalizePath

Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/util/virstoragefile.c | 210 -- src/util/virstoragefile.h | 8 -- 3 files changed, 219 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index

[PATCH 02/39] virStorageSourceGetMetadata: Use depth limit instead of unique path checking

Prevent unbounded chains by limiting the recursion depth of virStorageSourceGetMetadataRecurse to the maximum number of image layers we limit anyways. This removes the last use of virStorageSourceGetUniqueIdentifier which will allow us to delete some crusty old infrastructure which isn't really

[PATCH 18/39] bhyveParsePCIFbuf: Use g_strsplit instead of virStringSplitCount

Signed-off-by: Peter Krempa --- src/bhyve/bhyve_parse_command.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_command.c index 70f5ac42a0..d86d37b697 100644 --- a/src/bhyve/bhyve_parse_command.c +++

[PATCH 19/39] virHostValidateGetCPUFlags: Use g_strsplit instead of virStringSplitCount

We don't need the count of elements to iterate the list. Signed-off-by: Peter Krempa --- tools/virt-host-validate-common.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index

[PATCH 01/39] qemuDomainStorageSourceValidateDepth: Define chain depth as macro

The magic constant will be used in one more place. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 76e8903dbc..f818fce271 100644 --- a/src/qemu/qemu_domain.c +++

[PATCH 16/39] virLogParseOutput: Replace virStringSplitCount by g_strsplit

Unfortunately here we do need the count of elements. Use g_strv_length to calculate it so that virStringSplitCount can be removed later. Signed-off-by: Peter Krempa --- src/util/virlog.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virlog.c b/src/util/virlog.c

[PATCH 21/39] virshParseRateStr: Use g_strsplit instead of virStringSplitCount

Count the elements after splitting the string. Signed-off-by: Peter Krempa --- tools/virsh-domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 37be298809..532169d8d7 100644 --- a/tools/virsh-domain.c +++

[PATCH 13/39] virLogParseOutputs: Refactor string list handling

Rewrite the code to remove the need to calculate the string list count. Signed-off-by: Peter Krempa --- src/util/virlog.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 004792db01..56059f62f1 100644 ---

[PATCH 08/39] virDomainDiskAddISCSIPoolSourceHost: use g_strsplit instead of virStringSplitCount

Count the elements directly using g_strv_length. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d050a519c6..2ab476dfdb 100644 --- a/src/conf/domain_conf.c +++

[PATCH 10/39] virStorageFileParseBackingStoreStr: use g_strsplit instead of virStringSplitCount

The presence of the second element can be checked by looking at it directly. Signed-off-by: Peter Krempa --- src/util/virstoragefile.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index e6bc723d1e..e3ec64486e

[PATCH 09/39] virJSONValueObjectDeflattenWorker: use g_strsplit instead of virStringSplitCount

The presence of the second element can be checked by looking at it directly. Signed-off-by: Peter Krempa --- src/util/virjson.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 82081db870..f376490288 100644 ---

[PATCH 06/39] tests: Remove testing of virStorageFileCanonicalizePath

Remove the last code using the function. Signed-off-by: Peter Krempa --- tests/virstoragetest.c | 100 - 1 file changed, 100 deletions(-) diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index 157d577c7d..23cc72d85c 100644 ---

[PATCH 04/39] storage_file: Remove virStorageFileBackendFsPriv

The private data structure is no longer used. Signed-off-by: Peter Krempa --- src/storage_file/storage_file_backend_fs.c | 20 1 file changed, 20 deletions(-) diff --git a/src/storage_file/storage_file_backend_fs.c b/src/storage_file/storage_file_backend_fs.c index

[PATCH 00/39] String cleaning

It's spring, let's clean up some string cruft. Peter Krempa (39): qemuDomainStorageSourceValidateDepth: Define chain depth as macro virStorageSourceGetMetadata: Use depth limit instead of unique path checking Remove virStorageSourceGetUniqueIdentifier file backend API storage_file:

Re: [libvirt PATCH 2/2] ci: Call meson consistently

On Wed, 2021-03-31 at 23:31 +0200, Martin Kletzander wrote: > On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: > > We should always pass --werror and display the contents of the > > log file in case of failure. > > Any reason why the lines are not in one place? What I did in

Re: [PATCH] test: Update screenshot

On Thu, 2021-04-01 at 13:39 +0200, Michal Privoznik wrote: > While having screenshot of NeXT Cube running WorldWideWeb, I > think this deserves a little upgrade. Something more fancy. > > Signed-off-by: Michal Privoznik > --- > src/test/test-screenshot.png | Bin 33443 -> 1855 bytes > 1 file

Re: [PATCH RFC 0/3] Add checkpoint/restore support to LXC using CRIU

Hi Michal and Martin, Thanks for your reply. Just an explanation. I'm not interested directly in developing this specific feature. If there is a GSoC student addressed to this... Excellent. I'm interested in developing snapshot and container migration which unfortunately requires this feature.

Re: [libvirt PATCHv2] docs: secret: do not use a valuable password

On Thu, Apr 01, 2021 at 02:54:54PM +0200, Ján Tomko wrote: > Our website displays " **" as the example password. > Despite its tradition rooted in 18th Century French literature, > we cannot assume it to be public. > > Use *** as suggested by Erik instead. > > Signed-off-by: Ján

[libvirt PATCHv2] docs: secret: do not use a valuable password

Our website displays " **" as the example password. Despite its tradition rooted in 18th Century French literature, we cannot assume it to be public. Use *** as suggested by Erik instead. Signed-off-by: Ján Tomko --- docs/formatsecret.html.in | 2 +- 1 file changed, 1 insertion(+),

Re: [libvirt PATCH 5/4] meson: Don't check whether /usr/local/bin/grep is GNU grep

On Thu, Apr 01, 2021 at 02:17:14PM +0200, Andrea Bolognani wrote: > Since /usr/local is where ports live, it's reasonable to assume > that a grep binary found in there will have been installed via > ports and will thus be GNU grep. > > Suggested-by: Erik Skultety > Signed-off-by: Andrea

Re: [libvirt PATCH] docs: secret: do not use a valuable password

On Thu, Apr 01, 2021 at 02:02:01PM +0200, Ján Tomko wrote: > Our website displays " **" as the example password. > Despite its tradition rooted in 18th century French literature, > we cannot assume it to be public. > > Use a random string of letters and numbers instead. > >

Re: [libvirt PATCH 1/4] meson: Print custom message when GNU grep is not installed

On Thu, 2021-04-01 at 12:03 +0200, Erik Skultety wrote: > On Thu, Apr 01, 2021 at 11:51:15AM +0200, Andrea Bolognani wrote: > > I disagree that the hunk should be squashed in, though, since this > > patch simply changes the error message and not what's been checked. > > It should go in separately,

[libvirt PATCH 5/4] meson: Don't check whether /usr/local/bin/grep is GNU grep

Since /usr/local is where ports live, it's reasonable to assume that a grep binary found in there will have been installed via ports and will thus be GNU grep. Suggested-by: Erik Skultety Signed-off-by: Andrea Bolognani --- build-aux/meson.build | 4 1 file changed, 4 deletions(-) diff

[libvirt PATCH] docs: secret: do not use a valuable password

Our website displays " **" as the example password. Despite its tradition rooted in 18th century French literature, we cannot assume it to be public. Use a random string of letters and numbers instead. Signed-off-by: Ján Tomko --- docs/formatsecret.html.in | 2 +- 1 file changed, 1

[PATCH] test: Update screenshot

While having screenshot of NeXT Cube running WorldWideWeb, I think this deserves a little upgrade. Something more fancy. Signed-off-by: Michal Privoznik --- src/test/test-screenshot.png | Bin 33443 -> 1855 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git

Re: [PATCH] XML update in

On a Wednesday in 2021, Ján Tomko wrote: On a Wednesday in 2021, Kristina Hanicova wrote: Previously, we accepted empty bridge name, because some old versions of VMWare Workstation did not put it into the config. But this doesn't make much sense - to have an interface type bridge with no name.

Re: Gsoc2021

On a Wednesday in 2021, Aaryan Singh wrote: Hello, This is Aaryan, a 2nd-year undergraduate student at Kalinga institute of industrial technology. Welcome, Aaryan! Jano I have a keen interest in the " test driver API coverage " project. since I have worked in cloud computing and DevOps

Re: Gsoc2021

On 3/31/21 3:01 PM, Aaryan Singh wrote: Hello, This is Aaryan, a 2nd-year undergraduate student at Kalinga institute of industrial technology. I have a keen interest in the " test driver API coverage " project. since I have worked in cloud computing and DevOps that's why I am this

Re: [PATCH RFC 0/3] Add checkpoint/restore support to LXC using CRIU

On 4/1/21 12:01 AM, Martin Kletzander wrote: On Sat, Feb 27, 2021 at 01:14:29AM -0300, Julio Faracco wrote: Hi guys, Hi and sorry for not replying earlier. Yeah, sorry. I have this marked for review and yet still haven't done so. I marked this series as RFC to discuss some points. I'm

Release of libvirt-7.2.0

The 7.2.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing any

Re: [libvirt PATCH 1/4] meson: Print custom message when GNU grep is not installed

On Thu, Apr 01, 2021 at 11:51:15AM +0200, Andrea Bolognani wrote: > On Thu, 2021-04-01 at 11:23 +0200, Erik Skultety wrote: > > Please squash this in before merging: > > > > diff --git a/build-aux/meson.build b/build-aux/meson.build > > index 1095982397..e491bdeebc 100644 > > ---

Re: [libvirt PATCH 1/4] meson: Print custom message when GNU grep is not installed

On Thu, 2021-04-01 at 11:23 +0200, Erik Skultety wrote: > Please squash this in before merging: > > diff --git a/build-aux/meson.build b/build-aux/meson.build > index 1095982397..e491bdeebc 100644 > --- a/build-aux/meson.build > +++ b/build-aux/meson.build > @@ -26,10 +26,6 @@ if

Re: [PATCH] docs: formatnetworkport: Fix typos

On Thu, Apr 01, 2021 at 11:55:42AM +0800, Han Han wrote: > Signed-off-by: Han Han > --- Reviewed-by: Erik Skultety

Re: [libvirt PATCH 0/4] meson: Make syntax-check work on FreeBSD and macOS

On Wed, Mar 24, 2021 at 07:37:56PM +0100, Andrea Bolognani wrote: > Test pipeline: > > https://gitlab.com/abologna/libvirt/-/pipelines/275868429 > > Note that > > https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/101 > > needs to be merged and the data in ci/cirrus/ regenerated >

Re: [libvirt PATCH 1/4] meson: Print custom message when GNU grep is not installed

On Thu, Apr 01, 2021 at 11:10:05AM +0200, Erik Skultety wrote: > On Wed, Mar 24, 2021 at 07:37:57PM +0100, Andrea Bolognani wrote: > > Currently, if GNU grep is not installed on a FreeBSD system the > > configuration step will fail with > > > > Program grep found: YES (/usr/bin/grep) > >

[PATCH resend] lib: Drop internal virXXXPtr typedefs

Historically, we declared pointer type to our types: typedef struct _virXXX virXXX; typedef virXXX *virXXXPtr; But usefulness of such declaration is questionable, at best. Unfortunately, we can't drop every such declaration - we have to carry some over, because they are part of public API

Re: [libvirt PATCH 1/4] meson: Print custom message when GNU grep is not installed

On Wed, Mar 24, 2021 at 07:37:57PM +0100, Andrea Bolognani wrote: > Currently, if GNU grep is not installed on a FreeBSD system the > configuration step will fail with > > Program grep found: YES (/usr/bin/grep) > Program /usr/local/bin/grep found: NO > > ERROR: Program

Re: [PATCH 2/6] qemu: capabilities: Introduce QEMU_CAPS_COMPAT_DEPRECATED

On Thu, Apr 01, 2021 at 10:07:15AM +0200, Peter Krempa wrote: On Thu, Apr 01, 2021 at 00:05:55 +0200, Martin Kletzander wrote: On Fri, Mar 19, 2021 at 07:33:50PM +0100, Peter Krempa wrote: > The capability is asserted if qemu supports the -compat > deprecated-input= and deprecated-output=

Re: [PATCH 0/6] qemu: Allow control of deprecation behaviour

On Thu, Apr 01, 2021 at 10:37:31AM +0200, Peter Krempa wrote: On Thu, Apr 01, 2021 at 00:36:52 +0200, Martin Kletzander wrote: On Fri, Mar 19, 2021 at 07:33:48PM +0100, Peter Krempa wrote: > For debugging purposes it's very useful to disable all deprecated > commands and fields in qemu. This

Re: [PATCH 0/6] qemu: Allow control of deprecation behaviour

On Thu, Apr 01, 2021 at 00:36:52 +0200, Martin Kletzander wrote: > On Fri, Mar 19, 2021 at 07:33:48PM +0100, Peter Krempa wrote: > > For debugging purposes it's very useful to disable all deprecated > > commands and fields in qemu. This series implements a qemu.conf knob and > > a qemu namespace

Re: [libvirt PATCH 1/2] conf: add support for disk "rotation_rate" property

On Thu, Apr 01, 2021 at 10:18:11AM +0800, Han Han wrote: > On Wed, Mar 31, 2021 at 5:51 PM Daniel P. Berrangé > wrote: > > > This lets the app expose the virtual SCSI or IDE disks as solid state > > devices by setting a rate of '1', or rotational media by setting a > > rate between 1025 and

Re: [PATCH 2/6] qemu: capabilities: Introduce QEMU_CAPS_COMPAT_DEPRECATED

On Thu, Apr 01, 2021 at 00:05:55 +0200, Martin Kletzander wrote: > On Fri, Mar 19, 2021 at 07:33:50PM +0100, Peter Krempa wrote: > > The capability is asserted if qemu supports the -compat > > deprecated-input= and deprecated-output= settings to control what should > > happen if deprecated fields

Re: [libvirt PATCH 0/2] qemu: wire up support for rotation rate for disks

On Wed, Mar 31, 2021 at 10:50:24AM +0100, Daniel P. Berrangé wrote: > By default QEMU doesn't report any rotation information to guests, so > guests assume rotational media. This lets the user specify an explicit > speed in RPM, or 1 for SSD. This may allow the user to achieve better > performance