[PATCH 0/1] replace the method in several files

Using `git grep -n "\[0\].*'/'"` to find files that may need the treatment, then judge and replace. There may be some files replaced by mistake though. Luke Yue (1): Replace AbsPath judgement method with g_path_is_absolute() src/conf/backup_conf.c| 2 +- src/conf/snapshot_conf.c

[PATCH 1/1] Replace AbsPath judgement method with g_path_is_absolute()

The g_path_is_absolute() considers more situations than just a simply "path[0] == '/'". Related issue: https://gitlab.com/libvirt/libvirt/-/issues/12 Signed-off-by: Luke Yue --- src/conf/backup_conf.c| 2 +- src/conf/snapshot_conf.c | 2 +- src/conf/storage_source_conf.c

Re: [libvirt PATCH 00/17] drop meson checks for runtime binaries

On Mon, Apr 19, 2021 at 11:10 AM Pavel Hrdina wrote: > > On Mon, Apr 19, 2021 at 01:59:52PM +0100, Daniel P. Berrangé wrote: > > On Mon, Apr 19, 2021 at 02:50:13PM +0200, Michal Privoznik wrote: > > > On 4/19/21 2:24 PM, Neal Gompa wrote: > > > > On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina

Re: [libvirt PATCH v2 5/5] virshCheckpointListCollect: Do not pass NULL to qsort

On 4/19/21 7:54 AM, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake Reviewed-by: Laine Stump I pushed all 5 patches.

Re: [libvirt PATCH v2 3/5] cmdCheckpointList: Fix memory leak

On 4/19/21 7:54 AM, Tim Wiederhake wrote: Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2 As with the last patch, a short description would have gained me the time I spent looking into the original patch (on the other hand, not having the explanation forces me to go back to the source to

Re: [libvirt PATCH v2 4/5] cmdSnapshotList: Fix memory leak

On 4/19/21 7:54 AM, Tim Wiederhake wrote: Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2 Signed-off-by: Tim Wiederhake Reviewed-by: Laine Stump

Re: [libvirt PATCH v2 2/5] virDomainFeaturesDefParse: Fix memory leak

On 4/19/21 7:54 AM, Tim Wiederhake wrote: Fixes: 94013ee04e3945307a71f5c4897d78729e7eaff4 While not necessary, a short explanation would have led to less time spent loooking into the original patch. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 2

Re: [libvirt PATCH v2 1/5] xenParseHypervisorFeatures: Fix memory leak

On 4/19/21 7:54 AM, Tim Wiederhake wrote: Fixes:b523e22521afe733165869c9e1ae18e88536acd6 Signed-off-by: Tim Wiederhake --- src/libxl/xen_common.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c

Re: [PATCH for-7.4.0 00/38] qemu: Remove support for qemu-1.5 - qemu-2.10 and clean up capabilities

On Mon, Apr 19, 2021 at 02:35:04PM +0200, Peter Krempa wrote: > May 7, 2021 is the 2nd anniversary of release of rhel-8, which means we > no longer have to support qemu-1.5. > > Remove the capabilities and test data for the versions we no longer care > about and clean up some capabilities related

[libvirt PATCH v2 20/21] meson: optional_programs should be used only for building libvirt

Drop code that creates defines with program paths and update the comment to reflect current usage of optional_programs. Signed-off-by: Pavel Hrdina --- meson.build | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/meson.build b/meson.build index

[libvirt PATCH v2 17/21] meson: move iscsiadm check into storage_iscsi condition

This requires to define the binary name in code because we compile src/util/viriscsi.c unconditionally. Signed-off-by: Pavel Hrdina --- meson.build | 22 -- src/util/viriscsi.h | 2 ++ 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/meson.build

[libvirt PATCH v2 16/21] meson: drop check for runtime binary dependencies

These binaries are used only during runtime so technically there is no need to check for them while compiling libvirt. Usually the location is the same while compiling and running but it may not be true. In addition they are not strictly required to compile the code so this way developers don't

[libvirt PATCH v2 15/21] qemu_conf: use virFindFileInPathFull for runtime binaries

Following patches will stop detecting the full path during compilation so we will need to do it here. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_conf.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index

[libvirt PATCH v2 21/21] libvirt.spec: drop no longer required build dependencies

These are no longer required to build libvirt as they are used during compilation only by meson to detect if some "auto" features should be enabled or not but in spec file we explicitly enable/disable all libvirt features. Signed-off-by: Pavel Hrdina --- libvirt.spec.in | 31

[libvirt PATCH v2 19/21] meson: use runtime binaries to only resolve features with "auto" value

This way meson will try to do the right thing by default but we will allow users to change this behavior by using -Dname=enabled. This comes with two benefits compared to the previous behavior: - no need to install the binaries if developers would like to check that the code compiles

[libvirt PATCH v2 18/21] meson: stop setting runtime binaries defines during compilation

Technically the location of these binaries may be different when compiling libvirt or running it. This will allow users to change $PATH to use different binaries as well. Signed-off-by: Pavel Hrdina --- meson.build| 41 --

[libvirt PATCH v2 13/21] storage: use virFindFileInPath to validate presence of mkfs

Future patch will remove MKFS define as we will no longer check it during compilation. Signed-off-by: Pavel Hrdina --- src/storage/storage_backend_fs.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/storage/storage_backend_fs.c

[libvirt PATCH v2 12/21] bhyvexml2argvtest: use virCommandToStringFull to strip command path

Currently the tests would fail if the bhyve commands are installed in different path then /usr/bin. Strip the command path to not depend on the host environment. Signed-off-by: Pavel Hrdina --- tests/bhyvexml2argvdata/bhyvexml2argv-acpiapic.args | 2 +-

[libvirt PATCH v2 14/21] virfile: introduce virFindFileInPathFull()

Extend virFindFileInPath to search in custom extra paths as well. Some binaries that libvirt needs are not usually in $PATH so we need to have a way to look for these as well. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 2 +- src/util/virfile.c | 16 ++--

[libvirt PATCH v2 10/21] tests: testutilsqemu: move virFindFileInPath into domaincapsmock

Having the function on mock library reflect more closely what we usually do in tests. Signed-off-by: Pavel Hrdina --- tests/domaincapsmock.c | 16 tests/testutilsqemu.c | 15 --- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git

[libvirt PATCH v2 11/21] meson: don't check collie as program for sheepdog

Upstream sheepdog changed collie to dog back in 2013 in version 0.7.0. Looking into repology that version is no longer used by any distribution supported by libvirt. Signed-off-by: Pavel Hrdina --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build

[libvirt PATCH v2 09/21] virnetdev: move virNetDevSetRootQDisc to virnetdevbandwidth

The function in question uses "tc" binary so virnetdevbandwidth feels like better place for it. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 2 +- src/qemu/qemu_domain.c| 3 ++- src/util/virnetdev.c | 46

[libvirt PATCH v2 05/21] virdnsmasq: remove binaryPath argument from dnsmasqCapsNewFromBinary

We always pass DNSMASQ so there is no need for the argument at all. Signed-off-by: Pavel Hrdina --- src/network/bridge_driver.c | 4 ++-- src/util/virdnsmasq.c | 4 ++-- src/util/virdnsmasq.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git

[libvirt PATCH v2 08/21] tests: use virfirewallmock instead of hasNetfilterTools

Instead of checking for specific error that the binaries are not available mock the virFindFileInPath function. This way we don't have to skip these tests on host where the binaries are missing. Signed-off-by: Pavel Hrdina --- tests/networkxml2firewalltest.c | 16 ++--

[libvirt PATCH v2 07/21] tests: introduce virfirewallmock

This will allow us to run tests using firewall on hosts where the mocked binaries are not available/installed instead of skipping these tests. Signed-off-by: Pavel Hrdina --- src/util/virfile.h | 3 ++- tests/meson.build | 1 + tests/virfirewallmock.c | 34

[libvirt PATCH v2 06/21] virfirewall: use virFindFileInPath instead of virFileIsExecutable

Following patches will make this change necessary as we will stop detecting the full path during compile time. Signed-off-by: Pavel Hrdina --- src/util/virfirewall.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index

[libvirt PATCH v2 04/21] virdnsmasq: remove binaryPath argument from dnsmasqCapsNewFromBuffer

We always pass DNSMASQ so there is no need for the argument at all. Signed-off-by: Pavel Hrdina --- src/util/virdnsmasq.c | 4 ++-- src/util/virdnsmasq.h | 3 +-- tests/networkxml2conftest.c | 6 +++--- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git

[libvirt PATCH v2 03/21] virdnsmasq: drop unused dnsmasqCapsRefresh function

Instead of removing binaryPath let's drop the function completely as it is not used anywhere. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 - src/util/virdnsmasq.c| 17 - src/util/virdnsmasq.h| 1 - 3 files changed, 19 deletions(-) diff --git

[libvirt PATCH v2 02/21] virdnsmasq: drop unused dnsmasqCapsNewFromFile function

Instead of removing binaryPath let's drop the function completely as it is not used anywhere. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 - src/util/virdnsmasq.c| 30 -- src/util/virdnsmasq.h| 2 -- 3 files changed, 33 deletions(-) diff

[libvirt PATCH v2 01/21] bridge_driver: fix comment about dnsmasqCaps

We will never call dnsmasqCapsRefresh() so reflect what actually happens. Signed-off-by: Pavel Hrdina --- src/network/bridge_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 1172dbbc18..706a557ee8 100644

[libvirt PATCH v2 00/21] cleanup meson checks for runtime binaries

Recent attempt to add a lot of meson options to specify different runtime paths motivated me enough to cleanup this from meson. Changes in v2: - split and rework patch 16/17 to address review comments - added a new patch to cleanup libvirt.spec.in file Pavel Hrdina (21): bridge_driver:

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

On Mon, Apr 19, 2021 at 05:26:55PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 06:22:18PM +0200, Pavel Hrdina wrote: > > On Mon, Apr 19, 2021 at 05:05:56PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Apr 19, 2021 at 06:01:42PM +0200, Andrea Bolognani wrote: > > > > On Mon,

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

On Mon, Apr 19, 2021 at 06:22:18PM +0200, Pavel Hrdina wrote: > On Mon, Apr 19, 2021 at 05:05:56PM +0100, Daniel P. Berrangé wrote: > > On Mon, Apr 19, 2021 at 06:01:42PM +0200, Andrea Bolognani wrote: > > > On Mon, 2021-04-19 at 13:35 +0100, Daniel P. Berrangé wrote: > > > > On Fri, Apr 16, 2021

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

On Mon, Apr 19, 2021 at 05:05:56PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 06:01:42PM +0200, Andrea Bolognani wrote: > > On Mon, 2021-04-19 at 13:35 +0100, Daniel P. Berrangé wrote: > > > On Fri, Apr 16, 2021 at 09:12:45PM +0200, Pavel Hrdina wrote: > > > > - if not

Re: [libvirt PATCH v2] spec: Merge -bash-completion and -admin into -client

On Mon, 2021-04-19 at 16:51 +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 05:42:01PM +0200, Andrea Bolognani wrote: > > Basically, if we can't avoid the overhead of duplication altogether, > > I'd rather pay it on the filesystem than in the RPM database, where > > it's felt over and

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

On Mon, Apr 19, 2021 at 06:01:42PM +0200, Andrea Bolognani wrote: > On Mon, 2021-04-19 at 13:35 +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 16, 2021 at 09:12:45PM +0200, Pavel Hrdina wrote: > > > - if not get_option('storage_iscsi').disabled() and iscsiadm_prog.found() > > > + if not

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

On Mon, 2021-04-19 at 13:35 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 16, 2021 at 09:12:45PM +0200, Pavel Hrdina wrote: > > - if not get_option('storage_iscsi').disabled() and iscsiadm_prog.found() > > + if not get_option('storage_iscsi').disabled() > > use_storage = true > >

Re: [libvirt PATCH v2] spec: Merge -bash-completion and -admin into -client

On Mon, Apr 19, 2021 at 05:42:01PM +0200, Andrea Bolognani wrote: > On Mon, 2021-04-19 at 11:45 +0200, Michal Privoznik wrote: > > On 4/15/21 2:52 PM, Andrea Bolognani wrote: > > > the latter is also very small and, just like virsh, > > > is something that you likely want to have available on any

Re: [libvirt PATCH v2] spec: Merge -bash-completion and -admin into -client

On Mon, 2021-04-19 at 11:45 +0200, Michal Privoznik wrote: > On 4/15/21 2:52 PM, Andrea Bolognani wrote: > > the latter is also very small and, just like virsh, > > is something that you likely want to have available on any > > virtualization host to help with management and debugging > > tasks. >

Re: [libvirt PATCH 2/2] remove sheepdog support from libvirt

On Mon, Apr 19, 2021 at 01:51:36PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 02:45:52PM +0200, Pavel Hrdina wrote: > > On Mon, Apr 19, 2021 at 01:24:26PM +0200, Peter Krempa wrote: > > > On Mon, Apr 19, 2021 at 13:12:07 +0200, Pavel Hrdina wrote: > > > > On Mon, Apr 19, 2021 at

RE: Feature proposal: Add page-per-vq flag to the 'driver' element of virtio devices

On Monday, April 19, 2021 18:10 Jonathon Jongsma wrote: >On Mon, 19 Apr 2021 14:16:59 +0200 >Michal Privoznik wrote: > >> On 4/18/21 10:08 AM, Gavi Teitz wrote: >> > Hi, >> > >> > The page-per-vq flag is important for vdpa with vhost-user >> > performance [1]. >> > >> > Currently there is

Re: Feature proposal: Add page-per-vq flag to the 'driver' element of virtio devices

On Mon, 19 Apr 2021 14:16:59 +0200 Michal Privoznik wrote: > On 4/18/21 10:08 AM, Gavi Teitz wrote: > > Hi, > > > > The page-per-vq flag is important for vdpa with vhost-user > > performance [1]. > > > > Currently there is no way in libvirt to set it in the xml > > page-per-vq except with qemu

Re: [libvirt PATCH 00/17] drop meson checks for runtime binaries

On Mon, Apr 19, 2021 at 01:59:52PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 02:50:13PM +0200, Michal Privoznik wrote: > > On 4/19/21 2:24 PM, Neal Gompa wrote: > > > On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina wrote: > > > > > > > > > > > > > > I don't think this is a good

Re: [PATCH] add the ability to disable transport authentication (like esxi et al)

On 4/7/21 3:52 PM, simonmartin76 wrote: Signed-off-by: Simon Martin --- src/hyperv/hyperv_driver.c | 5 + src/hyperv/hyperv_util.c | 11 +++ src/hyperv/hyperv_util.h | 1 + 3 files changed, 17 insertions(+) Hey, sorry for delayed review. The patch looks good, but could

Re: [libvirt PATCH 00/17] drop meson checks for runtime binaries

On Mon, Apr 19, 2021 at 02:50:13PM +0200, Michal Privoznik wrote: > On 4/19/21 2:24 PM, Neal Gompa wrote: > > On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina wrote: > > > > > > > > > > I don't think this is a good "cleanup" to do. Having these checks is > > useful since without them, we'd blindly

Re: [PATCH 0/3] tests: qemuxml2argv negative tests for hugepages and numatune

On 3/30/21 8:36 AM, Han Han wrote: Han Han (3): tests: negative test for hugepages with anonymous memory backing tests: negative test for hugepages with ondemand mode tests: negative test of binding memnode cellid to an nonexist guest cell

Re: [libvirt PATCH 2/2] remove sheepdog support from libvirt

On Mon, Apr 19, 2021 at 02:45:52PM +0200, Pavel Hrdina wrote: > On Mon, Apr 19, 2021 at 01:24:26PM +0200, Peter Krempa wrote: > > On Mon, Apr 19, 2021 at 13:12:07 +0200, Pavel Hrdina wrote: > > > On Mon, Apr 19, 2021 at 12:53:11PM +0200, Peter Krempa wrote: > > > > On Mon, Apr 19, 2021 at 12:47:59

Re: [libvirt PATCH 00/17] drop meson checks for runtime binaries

On 4/19/21 2:24 PM, Neal Gompa wrote: On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina wrote: I don't think this is a good "cleanup" to do. Having these checks is useful since without them, we'd blindly build modules that possibly wouldn't work because we haven't verified that those

Re: [libvirt PATCH 2/2] remove sheepdog support from libvirt

On Mon, Apr 19, 2021 at 01:24:26PM +0200, Peter Krempa wrote: > On Mon, Apr 19, 2021 at 13:12:07 +0200, Pavel Hrdina wrote: > > On Mon, Apr 19, 2021 at 12:53:11PM +0200, Peter Krempa wrote: > > > On Mon, Apr 19, 2021 at 12:47:59 +0200, Pavel Hrdina wrote: > > > > Upstream sheepdog project doesn't

[PATCH 19/38] qemuxml2(argv|xml)test: Retire QEMU_CAPS_DEVICE_VIDEO_PRIMARY from tests

All tests now get that capability via virQEMUCapsInitQMPBasicArch. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- tests/qemuxml2argvtest.c | 70 +--- tests/qemuxml2xmltest.c | 30 +++-- 2 files changed, 20

[PATCH 29/38] qemu: monitor: Remove qemuMonitorSupportsActiveCommit

Modern code uses QMP schema to query for active commit support. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_monitor.c | 11 - src/qemu/qemu_monitor.h | 1 - src/qemu/qemu_monitor_json.c | 33 ---

[PATCH 17/38] qemuxml2argvtest: Remove tests for absence of QEMU_CAPS_DEVICE_VIDEO_PRIMARY

All supported qemu versions now have the capability so testing the absence doesn't make sense. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- .../qemuxml2argvdata/video-qxl-nodevice.args | 32 ---

[PATCH 15/38] qemu: capabilities: Move setting of QEMU_CAPS_MACH_VIRT_GIC_VERSION to virQEMUCapsInitQMPBasicArch

Move it under AARCH 64, since it's a platform specific feature, thus it will be removed from all other platforms. Since virQEMUCapsInitQMPBasicArch is used in qemuxml2argv test to initiate qemuCaps for tests with fake capabilities, all the tests gain GIC support now. Signed-off-by: Peter Krempa

[PATCH 37/38] qemu: capabilities: Retire QEMU_CAPS_EGL_HEADLESS

The feature is present in all supported qemu versions (>2.11) and there isn't a reasonable way to detect it. In addition the capability wasn't even used to gate any functionality except for reporting the presence in the domain capabilities XML. Signed-off-by: Peter Krempa ---

[PATCH 26/38] qemu: capabilities: Retire QEMU_CAPS_DEVICE_VIDEO_PRIMARY

Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 -

[PATCH 32/38] qemu: capabilities: Fix detection of 'vmport'

'query-commandline-options' never returned 'vmport' but we can detect it in the list of supported object types. This removes it from all non-x86 originating test data as it's platform specific. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 +--

[PATCH 01/38] qemu: Formally deprecate support for qemu < 2.11

As of May 7 2021, rhel-8 will be out for two years, which means we no longer have to support rhel-7 ancient qemu. QEMU versions in our supported distros: RHEL-8: 2.12 Debian Stable: 3.1 OpenSuse LEAP 15.0 (SLES15 GA): 2.11 OpenSuse LEAP 15.2: 4.2 Ubuntu (Bionic): 2.11 Ubuntu (Focal): 4.2

[PATCH 28/38] qemu: monitor: Remove qemuMonitorGetEvents

Modern code uses QMP schema to query for supported event types. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_monitor.c | 12 src/qemu/qemu_monitor.h | 2 -- src/qemu/qemu_monitor_json.c | 57

[PATCH 03/38] qemuxml2argvtest: Remove versioned tests for qemu < 2.11

Drop all the cases pinned to unsupported versions. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- .../channel-unix-guestfwd.x86_64-2.5.0.args | 33 - .../console-virtio-unix.x86_64-2.5.0.args | 34 --

[PATCH 08/38] qemuBuildDeviceAddressStr: Remove unused 'qemuCaps'

The qemuCaps is left for the device commandline formatters for now as it might come in handy. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_command.c | 73 - 1 file changed, 36

[PATCH 34/38] qemu: capabilities: Retire QEMU_CAPS_MACHINE_SMM_OPT

The feature is present in all supported QEMU versions and there isn't a more elegant way to detect it. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_validate.c

[PATCH 24/38] qemu_domain_address: Drop compatibility with pre-device vga specification for q35

Remove the slot reservation for the vga card which doesn't make sense with supported qemus any more for the q35 machine type. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_domain_address.c | 40 -- 1 file

[PATCH 33/38] qemu: capabilities: Retire QEMU_CAPS_VHOSTUSER_MULTIQUEUE

All supported qemus have it, there isn't an elegant way to detect it and it's unlikely to be ever removed on purpose. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_domain.c

[PATCH 16/38] qemuxml2argvtest: Remove negative test case for 'net-vhostuser-multiq'

QEMU_CAPS_VHOSTUSER_MULTIQUEUE is now always enabled, so the negative case doesn't make sense. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- tests/qemuxml2argvdata/net-vhostuser-multiq.err | 1 - tests/qemuxml2argvtest.c| 1 - 2

[PATCH 38/38] qemu: capabilities: Retire QEMU_CAPS_NUMA_DIST

The feature is present in all supported qemu versions (>2.11) and there isn't a reasonable way to detect it. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 --- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_validate.c

[PATCH 35/38] qemu: capabilities: Retire QEMU_CAPS_SDL_GL

The feature is present in all supported qemu versions (>2.11) and there isn't a reasonable way to detect it. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_validate.c

[PATCH 25/38] qemuDomainValidateDevicePCISlotsChipsets: Remove unused @qemuCaps

Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_domain_address.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 8a2494947b..fff8816aa8 100644 ---

[PATCH 36/38] qemu: capabilities: Retire QEMU_CAPS_MACHINE_KERNEL_IRQCHIP_SPLIT

The feature is present in all supported qemu versions (>2.11) and there isn't a reasonable way to detect it. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_validate.c

[PATCH 31/38] qemu: capabilities: Retire QEMU_CAPS_MACHINE_IOMMU

The feature is no longer asserted. Remove the checks related to it and make the code work properly with QEMU_CAPS_DEVICE_INTEL_IOMMU. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 19 +++ src/qemu/qemu_validate.c | 3

[PATCH 21/38] qemuhotplugtest: Add also always-present capabilities

Use virQEMUCapsInitQMPBasicArch in qemuHotplugCreateObjects so that we also add the always-present capabilities to the set of capabilities used for the hotplug test and fix fallout. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- tests/qemuhotplugtest.c

[PATCH 30/38] qemu: capabilities: Probe QMP schema before probing commands

All supported QEMU versions now support query-qmp-schema. In the future it will be possible to use the output of query-qmp-schema to also detect commands reliably. Since we are at the point where we have the least amount of .replies files needing changing for a long time, move the

[PATCH 22/38] qemu: command: Remove legacy '-vga' commandline formatter

All supported qemus now support using '-device' for adding a graphics device. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_command.c | 115 +++- 1 file changed, 6 insertions(+), 109 deletions(-) diff --git

[PATCH 23/38] qemu_domain_address: Drop compatibility with pre-device vga specification for i440fx

Remove the slot reservation for the vga card which doesn't make sense with supported qemus any more for the i440fx machine type. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_domain_address.c | 37 +++--- 1 file

[PATCH 27/38] qemu: capabilities: Always assume QEMU_CAPS_QUERY_QMP_SCHEMA

All supported qemu versions have 'query-qmp-schema' so we can remove the check whether it exists and all logic conntected to it. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_capabilities.c | 36 ---

[PATCH 13/38] qemu: capabilities: Move setting of PPC specific flags to virQEMUCapsInitQMPBasicArch

QEMU_CAPS_MACHINE_PSERIES_RESIZE_HPT and QEMU_CAPS_MACHINE_PSERIES_MAX_CPU_COMPAT are now always asserted on PPC machine types, move them to virQEMUCapsInitQMPBasicArch. It's now always set for AARCH64, move it into the function setting basic caps for the emulator. Signed-off-by: Peter Krempa

[PATCH 20/38] qemu: capabilities: Move rest of always present caps to virQEMUCapsInitQMPArch

These conveniently don't have any test fallout. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_capabilities.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_capabilities.c

Re: [libvirt PATCH 16/17] meson: drop check for runtime binary dependencies

On Fri, Apr 16, 2021 at 09:12:45PM +0200, Pavel Hrdina wrote: > These binaries are used only during runtime so technically there is no > need to check for them while compiling libvirt. > > Usually the location is the same while compiling and running but it may > not be true. In addition they are

[PATCH 07/38] qemuAssignDeviceControllerAlias: Remove unused 'qemuCaps' argument

Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_alias.c | 3 +-- src/qemu/qemu_alias.h | 1 - src/qemu/qemu_hotplug.c | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_alias.c

[PATCH for-7.4.0 00/38] qemu: Remove support for qemu-1.5 - qemu-2.10 and clean up capabilities

May 7, 2021 is the 2nd anniversary of release of rhel-8, which means we no longer have to support qemu-1.5. Remove the capabilities and test data for the versions we no longer care about and clean up some capabilities related stuff: - remove code for QEMU_CAPS_DEVICE_VIDEO_PRIMARY - remove

[PATCH 14/38] qemuxml2argvtest: Remove negative test for gic v3/host

QEMU_CAPS_MACH_VIRT_GIC_VERSION will be assumed for all aarch64 machines starting from next commit, so this test will become invalid. Remove it. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- tests/qemuxml2argvdata/aarch64-gic-host.err | 1 -

[PATCH 12/38] qemuxml2argvtest: Remove negative test case 'pseries-features-htp-resize'

All supported qemu versions now have the flag so the test doesn't make sense any more. The flag setting will be moved to virQEMUCapsInitQMPBasicArch which will make this test fail. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa ---

[PATCH 11/38] qemu: capabilities: Move setting of QEMU_CAPS_CPU_AARCH64_OFF to virQEMUCapsInitQMPBasicArch

It's now always set for AARCH64, move it into the function setting basic caps for the emulator. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_capabilities.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH 06/38] virQEMUCapsHasPCIMultiBus: Remove logic for PPC multibus support check

All machine types which have PCI support multibus since qemu 2.0 according to the logic we had, thus we can remove all the machine type and version checks which are now dead code. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa ---

[PATCH 10/38] virQEMUCapsInitQMPVersionCaps: Remove unneeded version checks

Now that minimum supported qemu version is 2.11, we can remove the conditions. Note that the check enabling QEMU_CAPS_TCG was for < 2.10. Signed-off-by: Peter Krempa Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_capabilities.c | 65 +---

[PATCH 04/38] qemuxml2xmltest: Remove versioned tests for qemu < 2.11

Drop all the cases pinned to unsupported versions. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- .../disk-cache.x86_64-1.5.3.xml | 61 --- .../disk-cache.x86_64-2.6.0.xml | 61

[PATCH 09/38] virQEMUCapsInitProcessCaps: Remove obsolete version checks

We no longer have to mask out IOMMU and NVDIMM support as we no longer support the broken qemu versions. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- src/qemu/qemu_capabilities.c | 17 - 1 file changed, 17

[PATCH 02/38] NEWS: Mention that minimum supported qemu version was bumped to 2.11

TODO: move news to correct section, add sign-off (anti-push failsafe) Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 5f8b0ae02d..d65d6174af 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -5,6 +5,13 @@

[PATCH 05/38] qemucapabilitiesdata: Drop capability test data for qemu < 2.11

Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko Reviewed-by: Pavel Hrdina Reviewed-by: Neal Gompa --- .../caps_1.5.3.x86_64.replies | 3327 --- .../caps_1.5.3.x86_64.xml | 176 - .../caps_1.6.0.x86_64.replies | 3298 ---

Re: [libvirt PATCH 00/17] drop meson checks for runtime binaries

On Fri, Apr 16, 2021 at 3:13 PM Pavel Hrdina wrote: > > Recent attempt to add a lot of meson options to specify different > runtime paths motivated me enough to cleanup this from meson. > > Pavel Hrdina (17): > bridge_driver: fix comment about dnsmasqCaps > virdnsmasq: drop unused

Re: Feature proposal: Add page-per-vq flag to the 'driver' element of virtio devices

On 4/18/21 10:08 AM, Gavi Teitz wrote: Hi, The page-per-vq flag is important for vdpa with vhost-user performance [1]. Currently there is no way in libvirt to set it in the xml page-per-vq except with qemu args, like so: Yeah, we view extra cmd line arguments as unsupported. Are there

Feature proposal: Add page-per-vq flag to the 'driver' element of virtio devices

Hi, The page-per-vq flag is important for vdpa with vhost-user performance [1]. Currently there is no way in libvirt to set it in the xml page-per-vq except with qemu args, like so: However, this is not an

[libvirt PATCH v2 5/5] virshCheckpointListCollect: Do not pass NULL to qsort

Signed-off-by: Tim Wiederhake --- tools/virsh-checkpoint.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c index afe849dd16..e88f9ffb47 100644 --- a/tools/virsh-checkpoint.c +++ b/tools/virsh-checkpoint.c @@ -628,7 +628,8

[libvirt PATCH v2 4/5] cmdSnapshotList: Fix memory leak

Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2 Signed-off-by: Tim Wiederhake --- tools/virsh-snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 2bec722c61..e64117785c 100644 --- a/tools/virsh-snapshot.c +++

[libvirt PATCH v2 3/5] cmdCheckpointList: Fix memory leak

Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2 Signed-off-by: Tim Wiederhake --- tools/virsh-checkpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c index 20a02b0b02..afe849dd16 100644 --- a/tools/virsh-checkpoint.c

[libvirt PATCH v2 2/5] virDomainFeaturesDefParse: Fix memory leak

Fixes: 94013ee04e3945307a71f5c4897d78729e7eaff4 Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 17bbeddec6..356398294e 100644 ---

[libvirt PATCH v2 1/5] xenParseHypervisorFeatures: Fix memory leak

Fixes:b523e22521afe733165869c9e1ae18e88536acd6 Signed-off-by: Tim Wiederhake --- src/libxl/xen_common.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index 12a44280cb..6fa69fbdf0 100644 ---

[libvirt PATCH v2 0/5] Fix some memory leaks

Issues were found by llvm's asan and ubsan sanitizers. V1: https://listman.redhat.com/archives/libvir-list/2021-April/msg00640.html Changes since V1: * Edited patch #1 to use two g_autofree variables instead of VIR_FREE'ing a reused variable * Removed "virQEMUCapsSetHostModel: Fix memory

Re: [libvirt PATCH 2/2] remove sheepdog support from libvirt

On Mon, Apr 19, 2021 at 13:12:07 +0200, Pavel Hrdina wrote: > On Mon, Apr 19, 2021 at 12:53:11PM +0200, Peter Krempa wrote: > > On Mon, Apr 19, 2021 at 12:47:59 +0200, Pavel Hrdina wrote: > > > Upstream sheepdog project doesn't have any active development for almost > > > 3 years as the last

Re: [libvirt PATCH 2/2] remove sheepdog support from libvirt

On Mon, Apr 19, 2021 at 12:04:16PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 19, 2021 at 12:47:59PM +0200, Pavel Hrdina wrote: > > Upstream sheepdog project doesn't have any active development for almost > > 3 years as the last commit is from 28/06/2018 [1]. > > > > Looking into repology [2]

Re: [libvirt PATCH 2/2] remove sheepdog support from libvirt

On Mon, Apr 19, 2021 at 12:53:11PM +0200, Peter Krempa wrote: > On Mon, Apr 19, 2021 at 12:47:59 +0200, Pavel Hrdina wrote: > > Upstream sheepdog project doesn't have any active development for almost > > 3 years as the last commit is from 28/06/2018 [1]. > > > > Looking into repology [2] the

  1   2   >