Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

2021-04-29 Thread Michal Prívozník
On 4/29/21 5:52 PM, Stefan Hajnoczi wrote: > The scsi=on|off property was deprecated in QEMU 5.0 and can be removed > completely at this point. > > Drop the scsi=on|off option. It was only available on Legacy virtio-blk > devices. Linux v5.6 already dropped support for it. > > Remove the

[PATCH 2/2] meson: Declare GLIB_VERSION_* macros at configure

2021-04-29 Thread Michal Privoznik
So far we have three places where glib version is recorded: meson.build and then in config.h. The latter is so well hidden that it's easy to miss when bumping minimal glib version in the former. With a bit of python^Wmeson string magic GLIB_VERSION_MIN_REQUIRED and GLIB_VERSION_MAX_ALLOWED macros

[PATCH 1/2] qemu_domainjob: Drop 'const' from strings in _qemuDomainJobObj

2021-04-29 Thread Michal Privoznik
These strings are not constant really. They are allocated in qemuDomainObjBeginJobInternal() and freed in qemuDomainReset*Job(). Freeing a pointer to const looks weird. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domainjob.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 0/2] meson: Declare GLIB_VERSION_* macros at configure

2021-04-29 Thread Michal Privoznik
I was playing around with bumped glib version and found couple of issues. Michal Prívozník (2): qemu_domainjob: Drop 'const' from strings in _qemuDomainJobObj meson: Declare GLIB_VERSION_* macros at configure config.h | 10 -- meson.build | 7 +++

Re: [PATCH RFC v5 07/12] hw/riscv: PLIC update external interrupt by KVM when kvm enabled

2021-04-29 Thread Anup Patel
On Mon, Apr 12, 2021 at 12:24 PM Yifei Jiang wrote: > > Only support supervisor external interrupt currently. > > Signed-off-by: Yifei Jiang > Signed-off-by: Yipeng Yin > --- > hw/intc/sifive_plic.c| 29 - > target/riscv/kvm-stub.c | 5 + >

Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

2021-04-29 Thread Eduardo Habkost
On Thu, Apr 29, 2021 at 04:52:21PM +0100, Stefan Hajnoczi wrote: > The scsi=on|off property was deprecated in QEMU 5.0 and can be removed > completely at this point. > > Drop the scsi=on|off option. It was only available on Legacy virtio-blk > devices. Linux v5.6 already dropped support for it. >

libvirt-7.3.0 release candidate 2

2021-04-29 Thread Jiri Denemark
I have just tagged v7.3.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

Re: [PATCH] virtio-blk: drop deprecated scsi=on|off property

2021-04-29 Thread Peter Krempa
On Thu, Apr 29, 2021 at 16:52:21 +0100, Stefan Hajnoczi wrote: > The scsi=on|off property was deprecated in QEMU 5.0 and can be removed > completely at this point. > > Drop the scsi=on|off option. It was only available on Legacy virtio-blk > devices. Linux v5.6 already dropped support for it. >

[PATCH] virtio-blk: drop deprecated scsi=on|off property

2021-04-29 Thread Stefan Hajnoczi
The scsi=on|off property was deprecated in QEMU 5.0 and can be removed completely at this point. Drop the scsi=on|off option. It was only available on Legacy virtio-blk devices. Linux v5.6 already dropped support for it. Remove the hw_compat_2_4[] property assignment since scsi=on|off no longer

Re: [PATCH] Add page_per_vq flag to the 'driver' element of virtio devices

2021-04-29 Thread Jonathon Jongsma
On Thu, 2021-04-29 at 14:12 +0300, Gavi Teitz wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1925363 > > Add support for setting the page-per-vq flag, which is important for > vdpa with vhost-user performance. > > Signed-off-by: Gavi Teitz > [snip] > diff --git a/src/conf/domain_conf.c

[PATCH] qemu: add support for max-ram-below-4g option

2021-04-29 Thread Zhiyong Ye
The 'below4g' attribute added in 'memory' element can be used to specify the low memory area, which allows to get a larger PCI I/O window below 4G when reduce it to a smaller value, and when raise value allows legacy non-PAE guests to have as much memory as possible in the 32bit address space

[PATCH v2 0/1] qemu: add support for max-ram-below-4g option

2021-04-29 Thread Zhiyong Ye
For background, see: https://listman.redhat.com/archives/libvir-list/2021-April/msg01196.html Changes since V1: * Change the 'below4g' attribute to not share the 'unit' argument with actual memory size, and let its unit default to KiB * Add docs and test changes * Add check in the ABI stability

[PATCH v2 1/1] qemu: add support for max-ram-below-4g option

2021-04-29 Thread Zhiyong Ye
The 'below4g' attribute added in 'memory' element can be used to specify the low memory area, which allows to get a larger PCI I/O window below 4G when reduce it to a smaller value, and when raise value allows legacy non-PAE guests to have as much memory as possible in the 32bit address space

Re: [PATCH] Add page_per_vq flag to the 'driver' element of virtio devices

2021-04-29 Thread Peter Krempa
On Thu, Apr 29, 2021 at 14:12:44 +0300, Gavi Teitz wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1925363 > > Add support for setting the page-per-vq flag, which is important for > vdpa with vhost-user performance. > > Signed-off-by: Gavi Teitz > --- > docs/formatdomain.rst

[PATCH] Add page_per_vq flag to the 'driver' element of virtio devices

2021-04-29 Thread Gavi Teitz
https://bugzilla.redhat.com/show_bug.cgi?id=1925363 Add support for setting the page-per-vq flag, which is important for vdpa with vhost-user performance. Signed-off-by: Gavi Teitz --- docs/formatdomain.rst | 11 +- docs/schemas/domaincommon.rng

Re: [PATCH] vm : forbid to start a being removed vm

2021-04-29 Thread Hogan Wang
> On 3/11/21 2:13 AM, Hogan Wang wrote: > > From: Zhuang Shengen > > > > When a vm is doing migration phase confirm, and then start it > > concurrently, it will lead to the vm out of libvirtd control. > > > > Cause Analysis: > > 1. thread1 migrate vm out. > > 2. thread2 start the migrating vm.

[PATCHv2] qemu: add support for max-ram-below-4g option

2021-04-29 Thread Zhiyong Ye
The 'below4g' attribute added in 'memory' element can be used to specify the low memory area, which allows to get a larger PCI I/O window below 4G when reduce it to a smaller value, and when raise value allows legacy non-PAE guests to have as much memory as possible in the 32bit address space

[PATCH 1/1] qemu: add support for max-ram-below-4g option

2021-04-29 Thread Zhiyong Ye
The 'below4g' attribute added in 'memory' element can be used to specify the low memory area, which allows to get a larger PCI I/O window below 4G when reduce it to a smaller value, and when raise value allows legacy non-PAE guests to have as much memory as possible in the 32bit address space

[PATCH 0/1] qemu: add support for max-ram-below-4g option

2021-04-29 Thread Zhiyong Ye
For background, see: https://listman.redhat.com/archives/libvir-list/2021-April/msg01196.html Changes since V1: * Change the 'below4g' attribute to not share the 'unit' argument with actual memory size, and let its unit default to KiB * Add docs and test changes Zhiyong Ye (1): qemu: add