Re: [PATCH v2] libxl: adjust handling of libxl_device_nic objects

On 5/19/21 3:37 AM, Olaf Hering wrote: libxl objects are supposed to be initialized and disposed. Adjust libxlMakeNic to use an already initialized object, it is owned by the caller. Adjust libxlMakeNicList to initialize the list of objects, before they are filled by libxlMakeNic. In case of

Re: [PATCH v1] libxl: adjust handling of libxl_device_disk objects

On 5/19/21 2:42 AM, Olaf Hering wrote: libxl objects are supposed to be initialized and disposed. Correct the usage of libxl_device_disk objects which are allocated on the stack. Initialize each one prior usage, and dispose them once done. Adjust libxlMakeDisk to use an already initialized

Re: [PATCH v1] libxl: remove libxl_domain_config_init from libxlBuildDomainConfig

On 5/19/21 2:40 AM, Olaf Hering wrote: The passed libxl_domain_config is owned, and already initialized, by the caller. Signed-off-by: Olaf Hering --- src/libxl/libxl_conf.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Jim Fehlig diff --git a/src/libxl/libxl_conf.c

memory allocations for libraries used by libvirt

Currently src/libxl/ allocates a bunch of buffers with variants of g_new0() or g_strdup(), which will be consumed by libxenlight.so. Once the objects which contain these buffers are not needed anymore, libxenlight.so will release them with ordinary calls to free() in its *_dispose() API. In

Re: [PATCH 3/4] conf: add s390-pv as launch security type

On 5/19/21 4:34 PM, Daniel Henrique Barboza wrote: On 5/19/21 2:40 PM, Boris Fiuczynski wrote: Add launch security type 's390-pv' as well as some tests. Signed-off-by: Boris Fiuczynski ---   docs/schemas/domaincommon.rng |  1 +   src/conf/domain_conf.c 

Re: [PATCH 3/4] conf: add s390-pv as launch security type

On 5/19/21 2:40 PM, Boris Fiuczynski wrote: Add launch security type 's390-pv' as well as some tests. Signed-off-by: Boris Fiuczynski --- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 8 + src/conf/domain_conf.h

Re: [PATCH 2/4] qemu: add s390-pv-guest capability

On 5/19/21 2:40 PM, Boris Fiuczynski wrote: Add s390-pv-guest capability. Signed-off-by: Boris Fiuczynski --- Reviewed-by: Daniel Henrique Barboza src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h| 1 +

Re: [PATCH 1/4] conf: refactor launch security to allow more types

On 5/19/21 2:40 PM, Boris Fiuczynski wrote: To allow other types of launch security the SEV type specific parameters like e.g. policy need to be optional and be separated from other new launch security types. A test is added to ensure the previously required and now optional launch security

Re: Qemu block filter insertion/removal API

19.05.2021 16:02, Kevin Wolf wrote: Am 19.05.2021 um 14:19 hat Vladimir Sementsov-Ogievskiy geschrieben: 19.05.2021 14:44, Kevin Wolf wrote: Am 17.05.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! I'd like to be sure that we know where we are going to. In blockdev-era

[PATCH 3/4] conf: add s390-pv as launch security type

Add launch security type 's390-pv' as well as some tests. Signed-off-by: Boris Fiuczynski --- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 8 + src/conf/domain_conf.h| 1 + src/qemu/qemu_command.c

[PATCH 1/4] conf: refactor launch security to allow more types

To allow other types of launch security the SEV type specific parameters like e.g. policy need to be optional and be separated from other new launch security types. A test is added to ensure the previously required and now optional launch security policy remains required when launch security type

[PATCH 0/4] Support for launchSecurity type s390-pv

This patch series introduces the launch security type s390-pv. Specifying s390-pv as launch security type in an s390 domain prepares for running the guest in protected virtualization secure mode, also known as IBM Secure Execution. Boris Fiuczynski (4): conf: refactor launch security to allow

[PATCH 4/4] docs: add s390-pv documentation

Add documentation for launch security type s390-pv. Signed-off-by: Boris Fiuczynski --- docs/formatdomain.rst | 7 docs/kbase/s390_protected_virt.rst | 55 +- 2 files changed, 54 insertions(+), 8 deletions(-) diff --git a/docs/formatdomain.rst

[PATCH 2/4] qemu: add s390-pv-guest capability

Add s390-pv-guest capability. Signed-off-by: Boris Fiuczynski --- src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h| 1 + tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 + 3 files changed, 4 insertions(+) diff --git

Re: [PATCH] conf: Report alias name of the detached device in error

On 5/19/21 8:37 AM, Kristina Hanicova wrote: On Wed, May 19, 2021 at 9:58 AM Michal Prívozník > wrote: On 5/18/21 6:07 PM, Laine Stump wrote: > On 5/18/21 5:44 AM, Kristina Hanicova wrote: >> Resolves:

Re: [libvirt PATCH 1/2] storage: add support for QCOW2 cluster_size option

On Wed, May 19, 2021 at 02:49:14PM +0200, Peter Krempa wrote: > On Thu, May 13, 2021 at 13:23:04 +0200, Pavel Hrdina wrote: > > The default value hard-coded in QEMU (64KiB) is not always the ideal. > > Having a possibility to set the cluster_size by user may in specific > > use-cases improve

Re: [libvirt PATCH 2/2] storage_file: add support to probe cluster_size from QCOW2 images

On Wed, May 19, 2021 at 02:57:18PM +0200, Peter Krempa wrote: > On Thu, May 13, 2021 at 13:23:05 +0200, Pavel Hrdina wrote: > > >From QEMU docs/interop/qcow2.txt : > > > >Byte 20 - 23: cluster_bits > > Number of bits that are used for addressing an offset > >

Re: Qemu block filter insertion/removal API

19.05.2021 14:44, Kevin Wolf wrote: Am 17.05.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi all! I'd like to be sure that we know where we are going to. In blockdev-era where qemu user is aware about block nodes, all nodes have good names and controlled by user we can

Re: [libvirt PATCH 1/4] test: move nodedev xml2xml output to a separate dir

On Wed, 2021-05-19 at 10:46 +0200, Michal Prívozník wrote: > On 5/14/21 11:28 PM, Jonathon Jongsma wrote: > > Currently, we're loading and parsing the xml from the input file, > > and > > then formatting it and then comparing it directly back to the input > > file. This works for now, but is

Re: RFC: Qemu backup interface plans

19.05.2021 14:20, Kevin Wolf wrote: Am 19.05.2021 um 08:11 hat Vladimir Sementsov-Ogievskiy geschrieben: 2. Test, that we can start backup job with source = (target of backup-top filter), so that we have "push backup with fleecing". Make an option for backup to start without a filter, when we

Plans for the next release

We are getting close to the next release of libvirt. To aim for the release on Jun 01 I suggest entering the freeze on Tuesday May 25 and tagging RC2 on Thursday May 27. I hope this works for everyone. Jirka

[libvirt PATCH 05/10] virDomainAudioDefParseXML: Don't ignore return value of virDomainAudio*Parse()

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 50 +- 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2142e45fd5..1350c46039 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 04/10] virDomainAudioDefParseXML: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `id`. Allowing negative numbers to be interpreted this way makes no sense for this attribute. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 74

[libvirt PATCH 03/10] virDomainAudioDef: Change type of "sdl.driver" to virDomainAudioSDLDriver

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 17 + src/conf/domain_conf.h | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 758f699c2c..9e6719265f 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part XII

For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainAudioPulseAudioParse: Use virXMLProp* virDomainAudioDef: Change type of "type" to virDomainAudioType virDomainAudioDef: Change type of "sdl.driver" to

[libvirt PATCH 01/10] virDomainAudioPulseAudioParse: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `latency`. Allowing negative numbers to be interpreted this way makes no sense for this attribute. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 10 ++ 1 file

Re: [PATCH v2 2/3] conf: Parse/format XML input type 'evdev'

On 5/11/21 12:16 PM, Kristina Hanicova wrote: > Signed-off-by: Kristina Hanicova > --- > docs/formatdomain.rst| 37 - > docs/schemas/domaincommon.rng| 20 +++ > src/conf/domain_audit.c | 1 + > src/conf/domain_conf.c

[libvirt PATCH 06/10] virDomainIOMMUDefParseXML: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `UINT_MAX + value + 1`) for attribute `aw_bits`. Allowing negative numbers to be interpreted this way makes no sense for this attribute. Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 69

[libvirt PATCH 02/10] virDomainAudioDef: Change type of "type" to virDomainAudioType

Signed-off-by: Tim Wiederhake --- src/bhyve/bhyve_command.c | 2 +- src/conf/domain_conf.c| 18 ++ src/conf/domain_conf.h| 2 +- src/qemu/qemu_command.c | 4 ++-- src/qemu/qemu_validate.c | 2 +- 5 files changed, 15 insertions(+), 13 deletions(-) diff --git

[libvirt PATCH 09/10] virStorageAdapterParseXML: Use virXMLProp*

Signed-off-by: Tim Wiederhake --- src/conf/storage_adapter_conf.c | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c index a834eee81f..e93b26f06f 100644 ---

[libvirt PATCH 08/10] virStorageAdapterFCHost: Change type of "type" to virStorageAdapterType

Signed-off-by: Tim Wiederhake --- src/conf/storage_adapter_conf.c | 5 +++-- src/conf/storage_adapter_conf.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c index 717d00dc4a..a834eee81f 100644 ---

[libvirt PATCH 07/10] virStorageAdapterParseXML: Use g_autofree

Signed-off-by: Tim Wiederhake --- src/conf/storage_adapter_conf.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/conf/storage_adapter_conf.c b/src/conf/storage_adapter_conf.c index 6b5a58e1e7..717d00dc4a 100644 --- a/src/conf/storage_adapter_conf.c +++

[libvirt PATCH 10/10] virDomainDeviceSpaprVioAddressParseXML: Use virXMLProp*

This strictens the parser to disallow negative values (interpreted as `ULLONG_MAX + value + 1`) for attribute `reg`. Allowing negative numbers to be interpreted this way makes no sense for this attribute, as it refers to a 32 bit address space. Signed-off-by: Tim Wiederhake ---

Re: [libvirt PATCH 2/2] storage_file: add support to probe cluster_size from QCOW2 images

On Thu, May 13, 2021 at 13:23:05 +0200, Pavel Hrdina wrote: > >From QEMU docs/interop/qcow2.txt : > >Byte 20 - 23: cluster_bits > Number of bits that are used for addressing an offset > within a cluster (1 << cluster_bits is the cluster size). > >

Re: [PATCH v2 3/3] virsh-domain: Drop support for old APIs in cmdSetmem and cmdSetmaxmem

On Wed, May 19, 2021 at 12:16:57 +0200, Michal Privoznik wrote: > Some of our really old APIs are missing @flags argument. We > introduced their variants with "Flags" suffix and wired some > logic into virsh to call the new variant only if necessary. This > enables virsh to talk to older daemon

Re: Qemu block filter insertion/removal API

Am 19.05.2021 um 14:19 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.05.2021 14:44, Kevin Wolf wrote: > > Am 17.05.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Hi all! > > > > > > I'd like to be sure that we know where we are going to. > > > > > > In blockdev-era where

Re: [PATCH v2 2/3] virsh-domain: Fix @ret handling in cmdSetmem and cmdSetmaxmem

On Wed, May 19, 2021 at 12:16:56 +0200, Michal Privoznik wrote: > These functions initialize @ret to true and only after something > fails either they call cleanup code (which consists only from > virshDomainFree()) and return false, or they set ret = false and > carry on (when the failure

Re: [PATCH v2 1/3] virsh: Fix logic wrt to --current flag in cmdSetmem

On Wed, May 19, 2021 at 12:16:55 +0200, Michal Privoznik wrote: > In my commit of v7.1.0-rc1~376 I've simplified the logic of > handling @flags. My assumption back then was that calling > virDomainSetMemory() is equivalent to > virDomainSetMemoryFlags(flags = 0). But that is not the case, >

Re: [libvirt PATCH 1/2] storage: add support for QCOW2 cluster_size option

On Thu, May 13, 2021 at 13:23:04 +0200, Pavel Hrdina wrote: > The default value hard-coded in QEMU (64KiB) is not always the ideal. > Having a possibility to set the cluster_size by user may in specific > use-cases improve performance for QCOW2 images. > > QEMU internally has some limits, the

Re: [PATCH] conf: Report alias name of the detached device in error

On Wed, May 19, 2021 at 9:58 AM Michal Prívozník wrote: > On 5/18/21 6:07 PM, Laine Stump wrote: > > On 5/18/21 5:44 AM, Kristina Hanicova wrote: > >> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1942367 > >> > >> Signed-off-by: Kristina Hanicova > >> --- > >> src/conf/domain_conf.c

Re: [PATCH libvirt v2] tests: Add capabilities for QEMU 6.0.0 on s390x

On 5/19/21 10:41 AM, Andrea Bolognani wrote: On Tue, May 18, 2021 at 03:53:09PM +0200, Shalini Chellathurai Saroja wrote: Introduce replies and xml files for QEMU 6.0.0 on s390x. Signed-off-by: Shalini Chellathurai Saroja --- The replies file is removed from this patch and is available in

Re: RFC: Qemu backup interface plans

Am 19.05.2021 um 13:49 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.05.2021 14:20, Kevin Wolf wrote: > > Am 19.05.2021 um 08:11 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > > > 2. Test, that we can start backup job with source = (target of > > > > > backup-top filter), so that we have

Re: Qemu block filter insertion/removal API

Am 17.05.2021 um 14:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > I'd like to be sure that we know where we are going to. > > In blockdev-era where qemu user is aware about block nodes, all nodes have > good names and controlled by user we can efficiently use block filters. >

Re: RFC: Qemu backup interface plans

Am 19.05.2021 um 08:11 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 2. Test, that we can start backup job with source = (target of > > > backup-top filter), so that we have "push backup with fleecing". > > > Make an option for backup to start without a filter, when we don't > > > need

Re: Qemu block filter insertion/removal API

18.05.2021 19:49, Max Reitz wrote: On 17.05.21 14:44, Vladimir Sementsov-Ogievskiy wrote: Hi all! I'd like to be sure that we know where we are going to. In blockdev-era where qemu user is aware about block nodes, all nodes have good names and controlled by user we can efficiently use block

[PATCH v2 3/3] virsh-domain: Drop support for old APIs in cmdSetmem and cmdSetmaxmem

Some of our really old APIs are missing @flags argument. We introduced their variants with "Flags" suffix and wired some logic into virsh to call the new variant only if necessary. This enables virsh to talk to older daemon which may be lacking new APIs. However, in case of cmdSetmem() we are

[PATCH v2 0/3] virsh: Fix logic wrt to --current flag in cmdSetmem

v2 of: https://listman.redhat.com/archives/libvir-list/2021-May/msg00484.html diff to v1: - Work in Jano's and Peter's review suggestions in 1/3. - Patches 2/3 and 3/3 are new. I've done 2/3 before 3/3 because it's still worth merging even if 3/3 is disliked. Michal Prívozník (3): virsh: Fix

[PATCH v2 1/3] virsh: Fix logic wrt to --current flag in cmdSetmem

In my commit of v7.1.0-rc1~376 I've simplified the logic of handling @flags. My assumption back then was that calling virDomainSetMemory() is equivalent to virDomainSetMemoryFlags(flags = 0). But that is not the case, because it is equivalent to virDomainSetMemoryFlags(flags =

[PATCH v2 2/3] virsh-domain: Fix @ret handling in cmdSetmem and cmdSetmaxmem

These functions initialize @ret to true and only after something fails either they call cleanup code (which consists only from virshDomainFree()) and return false, or they set ret = false and carry on (when the failure occurred close to cleanup code). Switch them to the usual pattern in which ret

Re: RFC: Qemu backup interface plans

18.05.2021 19:39, Max Reitz wrote: Hi, Your proposal sounds good to me in general.  Some small independent building blocks that seems to make sense to me. Thanks! I hope it's not too difficult to read and understand my English. On 17.05.21 14:07, Vladimir Sementsov-Ogievskiy wrote:

[PATCH v2] libxl: adjust handling of libxl_device_nic objects

libxl objects are supposed to be initialized and disposed. Adjust libxlMakeNic to use an already initialized object, it is owned by the caller. Adjust libxlMakeNicList to initialize the list of objects, before they are filled by libxlMakeNic. In case of error the objects are disposed by

Re: [PATCH v1] libxl: adjust handling of libxl_device_nic objects

Am Wed, 19 May 2021 10:44:17 +0200 schrieb Olaf Hering : > for (i = 0; i < nnics; i++) { > if (virDomainNetGetActualType(l_nics[i]) == > VIR_DOMAIN_NET_TYPE_HOSTDEV) > -continue; > +nvnics++; > +} This part inverts the logic, should look like that

[PATCH v1] libxl: adjust handling of libxl_device_nic objects

libxl objects are supposed to be initialized and disposed. Adjust libxlMakeNic to use an already initialized object, it is owned by the caller. Adjust libxlMakeNicList to initialize the list of objects, before they are filled by libxlMakeNic. In case of error the objects are disposed by

Re: [libvirt PATCH 4/4] docs: nodedev: document mdev uuid property

On 5/14/21 11:29 PM, Jonathon Jongsma wrote: > Signed-off-by: Jonathon Jongsma > --- > docs/formatnode.html.in | 4 > 1 file changed, 4 insertions(+) > > diff --git a/docs/formatnode.html.in b/docs/formatnode.html.in > index 3065570405..9a505f0fe9 100644 > --- a/docs/formatnode.html.in >

Re: [libvirt PATCH 2/4] nodedev: support auto-start property for mdevs

On 5/14/21 11:28 PM, Jonathon Jongsma wrote: > From: Boris Fiuczynski > > This adds a new element to the mdev capabilities xml schema that > represents the start policy for a defined mediated device. The actual > auto-start functionality is handled behind the scenes by mdevctl, but it > wasn't

Re: [libvirt PATCH 1/4] test: move nodedev xml2xml output to a separate dir

On 5/14/21 11:28 PM, Jonathon Jongsma wrote: > Currently, we're loading and parsing the xml from the input file, and > then formatting it and then comparing it directly back to the input > file. This works for now, but is severely limiting as it relies on the > input file being fully-specified and

[PATCH v1] libxl: adjust handling of libxl_device_disk objects

libxl objects are supposed to be initialized and disposed. Correct the usage of libxl_device_disk objects which are allocated on the stack. Initialize each one prior usage, and dispose them once done. Adjust libxlMakeDisk to use an already initialized object, it is owned by the caller. Adjust

Re: [PATCH libvirt v2] tests: Add capabilities for QEMU 6.0.0 on s390x

On Tue, May 18, 2021 at 03:53:09PM +0200, Shalini Chellathurai Saroja wrote: > Introduce replies and xml files for QEMU 6.0.0 on s390x. > > Signed-off-by: Shalini Chellathurai Saroja > --- > The replies file is removed from this patch and is available in >

[PATCH v1] libxl: remove libxl_domain_config_init from libxlBuildDomainConfig

The passed libxl_domain_config is owned, and already initialized, by the caller. Signed-off-by: Olaf Hering --- src/libxl/libxl_conf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 8ea9b35292..3149ee3b4a 100644 ---

Re: [PATCH] virsh: Fix logic wrt to --current flag in cmdSetmem

On Tue, May 18, 2021 at 15:55:45 +0200, Pavel Hrdina wrote: > On Tue, May 18, 2021 at 03:17:56PM +0200, Michal Prívozník wrote: > > On 5/18/21 3:12 PM, Pavel Hrdina wrote: > > > On Tue, May 18, 2021 at 03:02:55PM +0200, Ján Tomko wrote: > > >> On a Tuesday in 2021, Michal Privoznik wrote: > > >>>

Re: [PATCH] conf: Report alias name of the detached device in error

On 5/18/21 6:07 PM, Laine Stump wrote: > On 5/18/21 5:44 AM, Kristina Hanicova wrote: >> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1942367 >> >> Signed-off-by: Kristina Hanicova >> --- >>   src/conf/domain_conf.c | 19 +-- >>   1 file changed, 13 insertions(+), 6