On Tue, May 25, 2021 at 11:34 AM Andrea Bolognani wrote:
>
> On Tue, May 25, 2021 at 05:06:41PM +0200, Michal Prívozník wrote:
> > On 5/25/21 12:00 PM, Andrea Bolognani wrote:
> > > On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote:
> > >> -# For storage wiping with different
Am Tue, 25 May 2021 23:40:59 +0200
schrieb Olaf Hering :
> In case of error the objects are disposed by libxl_domain_config_dispose.
I just realized this is not always true, unless this change is applied on top.
If libxlMakeNic fails, libxl_domain_config_dispose can not release anything.
With
libxl objects are supposed to be initialized and disposed.
Adjust libxlMakeNic to use an already initialized object, it is owned by
the caller.
Adjust libxlMakeNicList to initialize the list of objects, before they
are filled by libxlMakeNic. In case of error the objects are disposed
by
On Tue, May 25, 2021 at 11:36:59AM -0500, Jonathon Jongsma wrote:
> On Tue, 2021-05-25 at 11:20 +0100, Daniel P. Berrangé wrote:
> > On Fri, May 14, 2021 at 04:28:57PM -0500, Jonathon Jongsma wrote:
> > > This is a short patch series based on an initial patch from Boris
> > > Fiuczynski
> > > that
Hi,
A request has come up recently in vagrant-libvirt about changing the
permissions used for the VM volume image file.
Currently there is a backing image file uploaded that gets 744 as the file
permissions, and then the VM domain is created using this as the backing
file for any changes. The
On Tue, 2021-05-25 at 11:20 +0100, Daniel P. Berrangé wrote:
> On Fri, May 14, 2021 at 04:28:57PM -0500, Jonathon Jongsma wrote:
> > This is a short patch series based on an initial patch from Boris
> > Fiuczynski
> > that I massaged a little bit and added a few additional patches.
> >
> > This
On Tue, May 25, 2021 at 06:02:47PM +0200, Thomas Huth wrote:
> It's "...-than=..." and not "...-then=...".
>
> Fixes: 8dd259d0c6 ("meson: add manywarnings")
> Signed-off-by: Thomas Huth
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build
It's "...-than=..." and not "...-then=...".
Fixes: 8dd259d0c6 ("meson: add manywarnings")
Signed-off-by: Thomas Huth
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 4f23f9104e..8ee0416700 100644
--- a/meson.build
+++
On Tue, May 25, 2021 at 05:06:41PM +0200, Michal Prívozník wrote:
> On 5/25/21 12:00 PM, Andrea Bolognani wrote:
> > On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote:
> >> -# For storage wiping with different algorithms
> >> -BuildRequires: scrub
> >
> > Turns out we're actually
I have just tagged v7.4.0-rc1 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
On 5/25/21 12:00 PM, Andrea Bolognani wrote:
> On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote:
>> -# For mount/umount in FS driver
>> -BuildRequires: util-linux
>
> This BuildRequires is duplicated, so please drop the other instance
> as well.
>
>> -# For storage wiping with
Hello all,
If I understand correctly, the addition of cluster_size support [1] will be available in libvirt 7.4.0, expected to be included in RHEL-AV-8.5.0.
I know "Red Hat does not generally disclose future release schedules" but is it possible to know roughly when this is due for
25.05.2021 11:50, Max Reitz wrote:
On 19.05.21 08:11, Vladimir Sementsov-Ogievskiy wrote:
18.05.2021 19:39, Max Reitz wrote:
[...]
On 17.05.21 14:07, Vladimir Sementsov-Ogievskiy wrote:
[...]
Not also, that there is another benefit of such thing: we'll implement this
callback in qcow2
Am Fri, 21 May 2021 10:49:15 -0600
schrieb Jim Fehlig :
> There's actually a subtle bug with this logic change.
Well, the devid index number used to depend on "nnics", now it would depend on
"nvnics". That might be an incompatible change indeed.
Olaf
pgpsGmVto0jvm.pgp
Description: Digitale
In recent commit f772c1fd2a a misaligned %endif sneaked in which
upsets syntax-check. Align it properly.
Signed-off-by: Michal Privoznik
---
Pushed as trivial and build breaker fix.
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in
On 5/25/21 12:12 PM, Pavel Hrdina wrote:
> On Tue, May 25, 2021 at 11:57:39AM +0200, Michal Prívozník wrote:
>> On 5/25/21 11:48 AM, Michal Privoznik wrote:
>>>
>>
>> Meanwhile, this was fixed in libxml2's upstream:
>>
>>
Currently we expose libvirt Go packages at
libvirt.org/libvirt-go
libvirt.org/libvirt-go-xml
These packages have not supported Go modules historically and when we
tried to introduce modules, we hit the problem that we're not using
semver for versioning.
The only way around this is to
On Fri, May 14, 2021 at 04:28:57PM -0500, Jonathon Jongsma wrote:
> This is a short patch series based on an initial patch from Boris Fiuczynski
> that I massaged a little bit and added a few additional patches.
>
> This allows you to define mediated devices in libvirt which are started
>
On Tue, May 25, 2021 at 11:57:39AM +0200, Michal Prívozník wrote:
> On 5/25/21 11:48 AM, Michal Privoznik wrote:
> >
>
> Meanwhile, this was fixed in libxml2's upstream:
>
> https://gitlab.gnome.org/GNOME/libxml2/-/commit/13ad8736d294536da4cbcd70a96b0a2fbf47070c
>
> So I guess there won't be
On Tue, May 25, 2021 at 10:00:47AM +0200, Pavel Hrdina wrote:
> -# For mount/umount in FS driver
> -BuildRequires: util-linux
This BuildRequires is duplicated, so please drop the other instance
as well.
> -# For storage wiping with different algorithms
> -BuildRequires: scrub
Turns out we're
On 5/25/21 11:48 AM, Michal Privoznik wrote:
>
Meanwhile, this was fixed in libxml2's upstream:
https://gitlab.gnome.org/GNOME/libxml2/-/commit/13ad8736d294536da4cbcd70a96b0a2fbf47070c
So I guess there won't be any regression with any upstream release of
libxml2. But as I pointed out in v1,
On Tue, May 25, 2021 at 10:00:46AM +0200, Pavel Hrdina wrote:
> Drop code that creates defines with program paths and update the comment
> to reflect current usage of optional_programs.
>
> Signed-off-by: Pavel Hrdina
> ---
> meson.build | 10 +-
> 1 file changed, 1 insertion(+), 9
On Tue, May 25, 2021 at 10:00:45AM +0200, Pavel Hrdina wrote:
> This way meson will try to do the right thing by default but we will
> allow users to change this behavior by using -Dname=enabled. This comes
> with two benefits compared to the previous behavior:
>
> - no need to install the
On Tue, May 25, 2021 at 02:36:04AM -0700, Andrea Bolognani wrote:
> On Tue, May 25, 2021 at 10:00:43AM +0200, Pavel Hrdina wrote:
> > + if not get_option('storage_iscsi').disabled()
> > +iscsi_enable = true
> > +iscsiadm_prog = find_program('iscsiadm', required: false, dirs:
> >
There was a recent change in libxml2 that caused a trouble for
us. To us, in domain or network XMLs are just opaque
value where management application can store whatever data it
finds fit. At XML parser/formatter level, we just make a copy of
the element during parsing and then format it back.
I guess this is more of an academic problem, because if
content was problematic we would have caught the
error during parsing. Anyway, as is this function returns -1
without any error reported. Fix it by reporting one.
Signed-off-by: Michal Privoznik
---
src/util/virxml.c | 2 ++
1 file
So far, we have to places where we format into XMLs:
domain and network. Bot places share the same code. Move it into
a helper function and just call it from those places.
Signed-off-by: Michal Privoznik
---
src/conf/domain_conf.c | 23 ++---
src/conf/network_conf.c | 23
v2 of:
https://listman.redhat.com/archives/libvir-list/2021-May/msg00767.html
diff to v1:
- Deduplicated the code per Pavel's suggestion
Michal Prívozník (3):
virxml: Introduce and use virXMLFormatMetadata()
virxml: Report error if virXMLFormatMetadata() fails
virxml: Avoid double
On Tue, May 25, 2021 at 10:00:44AM +0200, Pavel Hrdina wrote:
> Technically the location of these binaries may be different when
> compiling libvirt or running it. This will allow users to change $PATH
> to use different binaries as well.
>
> Signed-off-by: Pavel Hrdina
> ---
> meson.build
On Tue, May 25, 2021 at 10:00:43AM +0200, Pavel Hrdina wrote:
> + if not get_option('storage_iscsi').disabled()
> +iscsi_enable = true
> +iscsiadm_prog = find_program('iscsiadm', required: false, dirs:
> libvirt_sbin_path)
> +
> +if not iscsiadm_prog.found()
> + if
Bjoern Walk [2021-05-25, 11:01AM +0200]:
> Michal Privoznik [2021-05-25, 09:32AM +0200]:
> > There was a recent change in libxml2 that caused a trouble for
> > us. To us, in domain or network XMLs are just opaque
> > value where management application can store whatever data it
> > finds fit.
On Tue, May 25, 2021 at 10:00:42AM +0200, Pavel Hrdina wrote:
> +#define EBTABLES_PATH "ebtables"
> +#define IPTABLES_PATH "iptables"
> +#define IP6TABLES_PATH "ip6tables"
These are no longer paths, so you should rename them accordingly in a
preparatory patch.
> +#define IP_PATH "ip"
Same here.
On Tue, May 25, 2021 at 10:52:49AM +0200, Michal Prívozník wrote:
> On 5/25/21 10:47 AM, Daniel P. Berrangé wrote:
> > On Tue, May 25, 2021 at 09:32:35AM +0200, Michal Privoznik wrote:
> >> There was a recent change in libxml2 that caused a trouble for
> >> us. To us, in domain or network XMLs
On Tue, May 25, 2021 at 10:00:41AM +0200, Pavel Hrdina wrote:
> Following patches will stop detecting the full path during compilation
> so we will need to do it here.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_conf.c | 18 ++
> 1 file changed, 14 insertions(+), 4
On Tue, May 25, 2021 at 10:00:40AM +0200, Pavel Hrdina wrote:
> Extend virFindFileInPath to search in custom extra paths as well. Some
> binaries that libvirt needs are not usually in $PATH so we need to have
> a way to look for these as well.
>
> Signed-off-by: Pavel Hrdina
> ---
>
Michal Privoznik [2021-05-25, 09:32AM +0200]:
> There was a recent change in libxml2 that caused a trouble for
> us. To us, in domain or network XMLs are just opaque
> value where management application can store whatever data it
> finds fit. At XML parser/formatter level, we just make a copy of
On Tue, May 25, 2021 at 09:32:35AM +0200, Michal Privoznik wrote:
> There was a recent change in libxml2 that caused a trouble for
> us. To us, in domain or network XMLs are just opaque
> value where management application can store whatever data it
> finds fit. At XML parser/formatter level, we
On 5/25/21 10:47 AM, Daniel P. Berrangé wrote:
> On Tue, May 25, 2021 at 09:32:35AM +0200, Michal Privoznik wrote:
>> There was a recent change in libxml2 that caused a trouble for
>> us. To us, in domain or network XMLs are just opaque
>> value where management application can store whatever
On 19.05.21 08:11, Vladimir Sementsov-Ogievskiy wrote:
18.05.2021 19:39, Max Reitz wrote:
[...]
On 17.05.21 14:07, Vladimir Sementsov-Ogievskiy wrote:
[...]
Not also, that there is another benefit of such thing: we'll
implement this callback in qcow2 driver, so that backup will read
On Tue, May 25, 2021 at 09:32:35AM +0200, Michal Privoznik wrote:
> There was a recent change in libxml2 that caused a trouble for
> us. To us, in domain or network XMLs are just opaque
> value where management application can store whatever data it
> finds fit. At XML parser/formatter level, we
On 5/21/21 9:11 PM, Laine Stump wrote:
> see patch 4 for the why.
>
> Found during testing of https://bugzilla.redhat.com/1939776
>
> Laine Stump (4):
> qemu_hotplug.c: don't skip cleanup on failures of
> qemuDomainAttachNetDevice
> conf: new function virDomainNetRemoveByObj()
>
Following patches will stop detecting the full path during compilation
so we will need to do it here.
Signed-off-by: Pavel Hrdina
---
src/qemu/qemu_conf.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index
This way meson will try to do the right thing by default but we will
allow users to change this behavior by using -Dname=enabled. This comes
with two benefits compared to the previous behavior:
- no need to install the binaries if developers would like to check
that the code compiles
This requires to define the binary name in code because we compile
src/util/viriscsi.c unconditionally.
Signed-off-by: Pavel Hrdina
---
meson.build | 22 --
src/util/viriscsi.h | 2 ++
2 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/meson.build
Drop code that creates defines with program paths and update the comment
to reflect current usage of optional_programs.
Signed-off-by: Pavel Hrdina
---
meson.build | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/meson.build b/meson.build
index
These are no longer required to build libvirt as they are used during
compilation only by meson to detect if some "auto" features should be
enabled or not but in spec file we explicitly enable/disable all libvirt
features.
Signed-off-by: Pavel Hrdina
---
libvirt.spec.in | 31
Technically the location of these binaries may be different when
compiling libvirt or running it. This will allow users to change $PATH
to use different binaries as well.
Signed-off-by: Pavel Hrdina
---
meson.build| 41 --
Extend virFindFileInPath to search in custom extra paths as well. Some
binaries that libvirt needs are not usually in $PATH so we need to have
a way to look for these as well.
Signed-off-by: Pavel Hrdina
---
src/libvirt_private.syms | 2 +-
src/util/virfile.c | 16 ++--
Recent attempt to add a lot of meson options to specify different
runtime paths motivated me enough to cleanup this from meson.
Changes in v3:
These binaries are used only during runtime so technically there is no
need to check for them while compiling libvirt.
Usually the location is the same while compiling and running but it may
not be true. In addition they are not strictly required to compile the
code so this way developers don't
There was a recent change in libxml2 that caused a trouble for
us. To us, in domain or network XMLs are just opaque
value where management application can store whatever data it
finds fit. At XML parser/formatter level, we just make a copy of
the element during parsing and then format it back.
51 matches
Mail list logo
