From: Masayoshi Mizuma
QEMU_DOMAIN_DISK_PRIVATE(disk)->transientOverlayCreated flag
gets true unexpectedly on qemuProcessSetupDisksTransientSnapshot() when
the disk has option.
The flag should be enabled on qemuDomainAttachDiskGeneric() after the
overlay setup is completed.
Skip enabling
On 5/26/21 11:16 AM, Ján Tomko wrote:
On a Wednesday in 2021, Daniel P. Berrangé wrote:
We have helper methods that return boolans for ro/user/autostart
booleans (or bools if you want to be pedantic)
properties. We then pack them into a flags parameter, and later
unpack them again. This
Hi,
While developing cloud-hypervisor driver for libvirt, we re-fitted
cloud-hypervisor project's CI to libvirt. This CI was built on Rust and
currently supports VM boot up tests.
https://github.com/cloud-hypervisor/libvirt/tree/ch/ch_integration_tests
We are working on extending this CI to
I have just tagged v7.4.0-rc2 in the repository and pushed signed
tarballs and source RPMs to https://libvirt.org/sources/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make
Attribute `type` and sub-element `metadata_cache` are internally stored
in the `virStorageSource` structure. Sometimes we only care about the
disk source bits so we need a dedicated helper for that.
Signed-off-by: Pavel Hrdina
---
src/conf/domain_conf.c | 46
Before the mentioned commit we always parsed the whole disk definition
for qemuDomainBlockCopy API but we only used the @src part. Based on
that assumption the code was changed to parse only the disk
element.
Unfortunately that is not correct as we need to parse some parts of
element as well.
Pavel Hrdina (2):
domain_conf: extract disk driver source bits to its own function
virDomainDiskDefParseSource: parse source bits from driver element
src/conf/domain_conf.c | 52 ++
1 file changed, 37 insertions(+), 15 deletions(-)
--
2.31.1
On 5/27/21 3:24 PM, Jonathon Jongsma wrote:
> On Thu, 27 May 2021 14:04:08 +0200
> Michal Prívozník wrote:
>
>> On 5/26/21 5:40 PM, Jonathon Jongsma wrote:
>>> As Daniel Berrange mentioned, the method of supporting autostart
>>> for node devices was not consistent with other libvirt objects.
>>>
On Wed, May 26, 2021 at 11:37:48 -0500, Jonathon Jongsma wrote:
> On Tue, May 25, 2021 at 10:12 AM Jiri Denemark wrote:
> >
> > I have just tagged v7.4.0-rc1 in the repository and pushed signed
> > tarballs and source RPMs to https://libvirt.org/sources/
> >
> > Please give the release candidate
On Thu, 27 May 2021 14:04:08 +0200
Michal Prívozník wrote:
> On 5/26/21 5:40 PM, Jonathon Jongsma wrote:
> > As Daniel Berrange mentioned, the method of supporting autostart
> > for node devices was not consistent with other libvirt objects.
> > This patch series reverts this feature before it
On 5/25/21 6:50 PM, Darragh Bailey wrote:
> Hi,
>
> A request has come up recently in vagrant-libvirt about changing the
> permissions used for the VM volume image file.
>
> Currently there is a backing image file uploaded that gets 744 as the file
> permissions, and then the VM domain is
On 5/26/21 5:40 PM, Jonathon Jongsma wrote:
> As Daniel Berrange mentioned, the method of supporting autostart for node
> devices was not consistent with other libvirt objects. This patch series
> reverts this feature before it gets into a release. I will submit a follow-up
> patch soon which adds
On 5/26/21 5:40 PM, Jonathon Jongsma wrote:
> This reverts parts of commit bb8c3b61208ed0f29dcbeca857529600f04b3146
> that added tests for autostart functionality (which will be reverted in
> the following commit)
> ---
> tests/nodedevschemadata/mdev_autostart.xml| 10 --
>
On a Thursday in 2021, Thomas Huth wrote:
We are already compiling libvirt with -Wvla - so it does not make
too much sense to still allow people to use alloca() instead. Thus
put it on the list of things we want to warn about. Fortunately,
there is currently no warning with this flag, so the
On Thu, May 27, 2021 at 12:00:59PM +0100, Daniel P. Berrangé wrote:
On Thu, May 27, 2021 at 12:49:28PM +0200, Martin Kletzander wrote:
On Thu, May 27, 2021 at 12:37:36PM +0200, Thomas Huth wrote:
> The flag has a typo in it, it's "...-than=..." and not "...-then=...",
> so this was in fact
On Wed, May 26, 2021 at 05:26:42PM +0200, Ján Tomko wrote:
> On a Wednesday in 2021, Daniel P. Berrangé wrote:
> > This is in prep for switching to use the modular daemons by default. In
> > testing that setup I hit a couple of minor bugs.
> >
> > Daniel P. Berrangé (10):
> > remote: use
On Thu, May 27, 2021 at 12:49:28PM +0200, Martin Kletzander wrote:
> On Thu, May 27, 2021 at 12:37:36PM +0200, Thomas Huth wrote:
> > The flag has a typo in it, it's "...-than=..." and not "...-then=...",
> > so this was in fact never used. Since we're also using -Wvla (without
> > size), we
On Thu, May 27, 2021 at 12:37:36PM +0200, Thomas Huth wrote:
The flag has a typo in it, it's "...-than=..." and not "...-then=...",
so this was in fact never used. Since we're also using -Wvla (without
size), we should already get warnings about any variable length arrays
anyway, so the
We are already compiling libvirt with -Wvla - so it does not make
too much sense to still allow people to use alloca() instead. Thus
put it on the list of things we want to warn about. Fortunately,
there is currently no warning with this flag, so the current
sources should be clean.
On Wed, May 26, 2021 at 10:40:25AM -0500, Jonathon Jongsma wrote:
> This reverts parts of commit bb8c3b61208ed0f29dcbeca857529600f04b3146
> that added tests for autostart functionality (which will be reverted in
> the following commit)
> ---
> tests/nodedevschemadata/mdev_autostart.xml
On Wed, May 26, 2021 at 10:40:26AM -0500, Jonathon Jongsma wrote:
> We supported autostart of node devices via an xml element, but this
> is not consistent with other libvirt objects which use an explicit API
> for setting autostart status. So revert this and implement it as an
> official API in a
On Thu, May 27, 2021 at 11:46:56AM +0200, Michal Privoznik wrote:
In one of my recent commits I've done some renaming. But whilst
doing so I also mistakenly replaced 'goto cleanup' with 'return
-1' in virCapabilitiesHostNUMAInitReal() which was incorrect.
Fixes:
The flag has a typo in it, it's "...-than=..." and not "...-then=...",
so this was in fact never used. Since we're also using -Wvla (without
size), we should already get warnings about any variable length arrays
anyway, so the additional "-Wvla-larger-than" does not make much sense
and thus we can
In one of my recent commits I've done some renaming. But whilst
doing so I also mistakenly replaced 'goto cleanup' with 'return
-1' in virCapabilitiesHostNUMAInitReal() which was incorrect.
Fixes: fe25224fdaa53bbeceed3ddeef1b3a150665e656
Signed-off-by: Michal Privoznik
---
On a Wednesday in 2021, Masayoshi Mizuma wrote:
From: Masayoshi Mizuma
When is set to a disk and the overlay
disk already exists because of something abnormal, libvirt is terminated
by Segmentation fault.
# virsh start Test0
error: Disconnected from qemu:///system due to end of file
25 matches
Mail list logo
