[libvirt PATCH v2] meson: Don't include warning flags in summary

The list takes up half a screen on my machine and it doesn't seem useful enough for that to be warranted, especially when it results in other, arguably more relevant parts of the summary being pushed off-screen. Signed-off-by: Andrea Bolognani Reviewed-by: Pavel Hrdina --- Changes from [v1]:

Re: [libvirt PATCH 0/2] fix disk XML formatting for qemuDomainBlockCopy API

On Thu, May 27, 2021 at 16:23:24 +0200, Pavel Hrdina wrote: > Pavel Hrdina (2): > domain_conf: extract disk driver source bits to its own function > virDomainDiskDefParseSource: parse source bits from driver element > > src/conf/domain_conf.c | 52 ++ >

Re: [libvirt PATCH 00/26] meson: Various fixes and improvements

On Tue, Jun 01, 2021 at 11:41:37AM +0200, Pavel Hrdina wrote: > On Tue, Jun 01, 2021 at 10:37:31AM +0200, Andrea Bolognani wrote: > > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/312508056 > > > > Andrea Bolognani (26): > > spec: Be explicit about more features > > meson:

Re: Storing PCI(e) VPD Board Serial Numbers

On Fri, May 28, 2021 at 10:58:05PM +0300, Dmitrii Shcherbakov wrote: > Hello Libvirt Developers, > > I am looking for some feedback on a planned enhancement to Libvirt: the aim > is > to store a portion of PCI(e) Vital Product Data (VPD) for each device along > with other PCI/PCIe device

Release of libvirt-7.4.0

The 7.4.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing any

Re: [libvirt PATCH] docs: introduce stubs for new libvirt Go packages

On Tue, May 25, 2021 at 12:12:08PM +0100, Daniel P. Berrangé wrote: > The corresponding repos exist > > https://gitlab.com/libvirt/libvirt-go-module > https://gitlab.com/libvirt/libvirt-go-xml-module > > but I'm leaving them empty until we've completed this release, then > I'll populate with

Re: [libvirt PATCH 00/26] meson: Various fixes and improvements

On Tue, Jun 01, 2021 at 10:37:31AM +0200, Andrea Bolognani wrote: > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/312508056 > > Andrea Bolognani (26): > spec: Be explicit about more features > meson: Whitespace tweaks > meson: Don't use 'required: true' > meson: Drop curl

Re: [libvirt PATCH 26/26] meson: Don't include warning flags in summary

On Tue, Jun 01, 2021 at 10:37:57AM +0200, Andrea Bolognani wrote: > The list takes up half a screen on my machine and it doesn't > seem useful enough for that to be warranted, especially when it > results in other, arguably more relevant parts of the summary > being pushed off-screen. It might be

Re: [libvirt PATCH 25/26] meson: Reorganize summary

On Tue, Jun 01, 2021 at 10:37:56AM +0200, Andrea Bolognani wrote: > Different types of drivers are more accurately sorted into > separate categories, the "Windows" section has been absorbed > into a more generic "Target" section which also contains other > information about the OS configuration,

Re: [libvirt PATCH 24/26] meson: Style tweaks

On Tue, Jun 01, 2021 at 10:37:55AM +0200, Andrea Bolognani wrote: > These checks look different than most similar ones for no > particular reason. > > This commit is better viewed with 'git show -w'. Drop this line as I don't agree that it's better. It obscures the fact that the code "if

Re: [libvirt PATCH 08/26] meson: Make libm a required dependency

On Tue, Jun 01, 2021 at 10:37:39AM +0200, Andrea Bolognani wrote: > We use it unconditionally. > > Signed-off-by: Andrea Bolognani > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index 81f8caae06..922bf93659 100644 > ---

Re: [PATCH] NEWS: disks: Mention improvements and XML fix

On Tue, Jun 01, 2021 at 09:29:29 +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > NEWS.rst | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 8358cbd369..66ce95d7cb 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -20,6 +20,17 @@

[libvirt PATCH 21/26] meson: Switch to autodetection for apparmor_profiles

Match the behavior of most other features. This will result in a change in behavior, because profiles will now be installed whenever AppArmor support is enabled; on the other hand, this is probably the behavior users expected in the first place. Signed-off-by: Andrea Bolognani ---

[libvirt PATCH 26/26] meson: Don't include warning flags in summary

The list takes up half a screen on my machine and it doesn't seem useful enough for that to be warranted, especially when it results in other, arguably more relevant parts of the summary being pushed off-screen. Signed-off-by: Andrea Bolognani --- meson.build | 5 - 1 file changed, 5

[libvirt PATCH 23/26] meson: Switch to autodetection for driver_test

Match the behavior of most other features. Signed-off-by: Andrea Bolognani --- meson.build | 2 +- meson_options.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 53c9a038d0..1a2503488a 100644 --- a/meson.build +++ b/meson.build @@

[libvirt PATCH 22/26] meson: Switch to autodetection for driver_remote

Match the behavior of most other features. Signed-off-by: Andrea Bolognani --- meson.build | 14 +++--- meson_options.txt | 2 +- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index be6765a034..53c9a038d0 100644 --- a/meson.build +++

[libvirt PATCH 25/26] meson: Reorganize summary

Different types of drivers are more accurately sorted into separate categories, the "Windows" section has been absorbed into a more generic "Target" section which also contains other information about the OS configuration, and some other smaller tweaks have been applied. Signed-off-by: Andrea

[libvirt PATCH 16/26] meson: Fix firewalld check

firewalld is Linux-only, so it should be disabled by default everywhere else and attempts to explicitly enable firewalld support on non-Linux targets should result in an error. Signed-off-by: Andrea Bolognani --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[libvirt PATCH 24/26] meson: Style tweaks

These checks look different than most similar ones for no particular reason. This commit is better viewed with 'git show -w'. Signed-off-by: Andrea Bolognani --- meson.build | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/meson.build

[libvirt PATCH 19/26] meson: Rewrite apparmor_profiles check

Attempting to enable apparmor_profiles when apparmor support is not enabled should result in an error. Signed-off-by: Andrea Bolognani --- meson.build | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index a9f87473db..55bb724a52 100644 ---

[libvirt PATCH 20/26] meson: Turn apparmor_profiles into a feature

Similar knobs, such as firewalld_zone and sysctl_config, are already features, so convert this one as well to comply with expectations. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 2 +- meson.build | 14 +++--- meson_options.txt | 2 +-

[libvirt PATCH 09/26] meson: Drop numactl_version

It's not used. Signed-off-by: Andrea Bolognani --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index 922bf93659..8aaa0ce370 100644 --- a/meson.build +++ b/meson.build @@ -1071,7 +1071,6 @@ else intl_dep = dependency('', required: false) endif

[libvirt PATCH 15/26] meson: Rewrite firewalld check

This makes it possible to explicitly disable firewalld support regardless of the platform that's been targeted. Signed-off-by: Andrea Bolognani --- meson.build | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 9b5de6daa1..faccbd750c

[libvirt PATCH 08/26] meson: Make libm a required dependency

We use it unconditionally. Signed-off-by: Andrea Bolognani --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 81f8caae06..922bf93659 100644 --- a/meson.build +++ b/meson.build @@ -1022,7 +1022,7 @@ endif libxml_version = '2.9.1'

[libvirt PATCH 07/26] meson: Use built-in pcap detection

Meson already knows how to look for pcap using pkg-config first, and falling back to pcap-config if that didn't work. https://mesonbuild.com/Dependencies.html#pcap Signed-off-by: Andrea Bolognani --- meson.build | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git

[libvirt PATCH 14/26] meson: Fix disabling netcf

If the feature is disabled, the corresponding flags should not show up in the compiler command line. Signed-off-by: Andrea Bolognani --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 14d6ce039f..9b5de6daa1 100644 ---

[libvirt PATCH 18/26] meson: Use dependency() when possible

This is the preferred way to figure out whether a library is available, and for the most part we can just adopt it right away; in a few cases, unfortunately, we're stuck with using cc.find_library() until further down the road, when all our target platforms ship with pkg-config enabled versions of

[libvirt PATCH 13/26] meson: Tweak XDR check

Keep all the platform-specific code in one place. Signed-off-by: Andrea Bolognani --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 3ee8694886..14d6ce039f 100644 --- a/meson.build +++ b/meson.build @@ -1266,6 +1266,8 @@ if

[libvirt PATCH 12/26] meson: Rewrite polkit check

The new version will report an error if the user asks for polkit support to be enabled on Windows instead of silently ignoring such requests. Signed-off-by: Andrea Bolognani --- meson.build | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git

[libvirt PATCH 17/26] meson: Rewrite libacl check

libacl is Linux-only, so we don't need to explicitly check for either the target platform or header availability, and we can simply rely on cc.find_library() instead. The corresponding preprocessor define is renamed to more accurately reflect the nature of the check. Signed-off-by: Andrea

[libvirt PATCH 06/26] meson: Use get_pkgconfig_variable('cflags')

Meson offers a native convenience method that can be used to fetch pkg-config variables from a dependency, so we can use that instead of calling pkg-config manually. Signed-off-by: Andrea Bolognani --- meson.build | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[libvirt PATCH 11/26] meson: Fix sanlock detection

If the user explicitly asked for sanlock support to be enabled, then failure to find the corresponding library should result in an error. Signed-off-by: Andrea Bolognani --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index

[libvirt PATCH 10/26] meson: Fix vstorage detection

We're supposed to error out if the user has explicitly asked for vstorage support to be enabled and that can't be done, but we've been looking at the wrong option. Fixes: 2127d53f2f90443f3e4919c1082350ee2b3096f1 Signed-off-by: Andrea Bolognani --- meson.build | 2 +- 1 file changed, 1

[libvirt PATCH 04/26] meson: Drop curl workaround

It appears to no longer be necessary. Signed-off-by: Andrea Bolognani --- meson.build | 10 -- 1 file changed, 10 deletions(-) diff --git a/meson.build b/meson.build index 2544880732..1360dd325e 100644 --- a/meson.build +++ b/meson.build @@ -904,16 +904,6 @@ endif curl_version =

[libvirt PATCH 05/26] meson: Drop netinet workaround

It appears to no longer be necessary. Signed-off-by: Andrea Bolognani --- meson.build| 16 src/util/virnetdevbridge.c | 18 -- 2 files changed, 34 deletions(-) diff --git a/meson.build b/meson.build index 1360dd325e..9c494faa5c 100644 ---

[libvirt PATCH 03/26] meson: Don't use 'required: true'

It's the default. Signed-off-by: Andrea Bolognani --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 4d76e1f651..2544880732 100644 --- a/meson.build +++ b/meson.build @@ -804,7 +804,7 @@ if host_machine.system() == 'freebsd'

[libvirt PATCH 00/26] meson: Various fixes and improvements

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/312508056 Andrea Bolognani (26): spec: Be explicit about more features meson: Whitespace tweaks meson: Don't use 'required: true' meson: Drop curl workaround meson: Drop netinet workaround meson: Use

[libvirt PATCH 01/26] spec: Be explicit about more features

We want to be explicit about which features are enabled in our RPM build instead of relying on default values. Signed-off-by: Andrea Bolognani --- libvirt.spec.in | 3 +++ mingw-libvirt.spec.in | 2 ++ 2 files changed, 5 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index

[libvirt PATCH 02/26] meson: Whitespace tweaks

Signed-off-by: Andrea Bolognani --- meson.build | 24 src/locking/meson.build | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/meson.build b/meson.build index 4f23f9104e..4d76e1f651 100644 --- a/meson.build +++ b/meson.build @@

[PATCH] NEWS: disks: Mention improvements and XML fix

Signed-off-by: Peter Krempa --- NEWS.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 8358cbd369..66ce95d7cb 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -20,6 +20,17 @@ v7.4.0 (unreleased) * **New features** + * qemu: Add support for hotplugging

Re: [PATCH] qemuProcessSetupDisksTransientSnapshot: Skip enabling transientOverlayCreated flag

On Thu, May 27, 2021 at 12:55:12 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > QEMU_DOMAIN_DISK_PRIVATE(disk)->transientOverlayCreated flag > gets true unexpectedly on qemuProcessSetupDisksTransientSnapshot() when > the disk has option. > > The flag should be enabled on