[PATCH v3 3/3] conf: domain: Introduce and use virDomainObjGetMessages()

2021-06-29 Thread Luke Yue
The test driver and qemu driver share the same code in virDomainGetMessages(), so extract it to a function. Signed-off-by: Luke Yue --- src/conf/domain_conf.c | 53 src/conf/domain_conf.h | 5 src/libvirt_private.syms | 1 +

[PATCH v3 2/3] test_driver: Introduce testDomainObjCheckTaint

2021-06-29 Thread Luke Yue
In order to test the virDomainGetMessages for test driver, we need to check some taints or deprecations, so introduce testDomainObjCheckTaint for checking taints. As we introduced testDomainObjCheckTaint for test driver, the `dominfo` command in virshtest will now print tainting messages, so add

[PATCH v3 1/3] test_driver: Implement virDomainGetMessages

2021-06-29 Thread Luke Yue
Signed-off-by: Luke Yue --- src/test/test_driver.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index ef0ddab54d..35742fcde3 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@

[PATCH v3 0/3] Implement virDomainGetMessages for test driver

2021-06-29 Thread Luke Yue
v3: - Squash tests commit - Extract the same code in test driver and qemu driver to a function Luke Yue (3): test_driver: Implement virDomainGetMessages test_driver: Introduce testDomainObjCheckTaint conf: domain: Introduce and use virDomainObjGetMessages() src/conf/domain_conf.c | 53

Re: [libvirt PATCH 3/5] qemu: Default to TPM 2.0 for ARM virt guests

2021-06-29 Thread liuyd.f...@fujitsu.com
Sorry for the inconvenience. Tested-by: Liu Yiding Thanks, Liu On 6/29/21 9:08 PM, Andrea Bolognani wrote: > On Tue, Jun 29, 2021 at 02:54:24AM +, liuyd.f...@fujitsu.com wrote: >> That works for me. Thanks. >> >> Tested-by: liuyd.f...@fujitsu.com > Glad to hear that! Can you please provide

[PATCH 04/10] ch_monitor: Add pty json builder function

2021-06-29 Thread William Douglas
Add function to build the the json structure to configure a PTY in cloud-hypervisor. The configuration only supports a single serial or console device. Signed-off-by: William Douglas --- src/ch/ch_monitor.c | 59 + 1 file changed, 59 insertions(+)

[PATCH 10/10] ch_driver: Turn on the domainOpenConsole API

2021-06-29 Thread William Douglas
With all the rest of the enablement work out of the way, add the final call for the cloud-hypervisor driver to handle domainOpenConsole. Signed-off-by: William Douglas --- src/ch/ch_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index

[PATCH 09/10] ch_driver: Add handler for console API

2021-06-29 Thread William Douglas
Add the handler function to find and open the console character device that will be used by the console API. Signed-off-by: William Douglas --- src/ch/ch_driver.c | 77 ++ 1 file changed, 77 insertions(+) diff --git a/src/ch/ch_driver.c

[PATCH 05/10] ch_monitor: Make use of the PTY json builder

2021-06-29 Thread William Douglas
Call into the PTY json builder for configured serial and console devices though the devices themselves still aren't allowed in configuration. Signed-off-by: William Douglas --- src/ch/ch_monitor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c

[PATCH 06/10] ch_process: Handle enabled console devices

2021-06-29 Thread William Douglas
Add functionality to allow libvirt console to connect to the cloud-hypervisor created PTY associated with a VM. This will need to be run once the VM is created by cloud-hypervisor. Signed-off-by: William Douglas --- src/ch/ch_process.c | 64 + 1 file

[PATCH 03/10] ch_monitor: Use virCHMonitorGet to access cloud-hypervisor API

2021-06-29 Thread William Douglas
Now that virCHMonitorGet is capable of handling data returned by the cloud-hypervisor API, make use of this via virCHMonitorGetInfo to call into the vm.info endpoint. Signed-off-by: William Douglas --- src/ch/ch_monitor.c | 15 +++ src/ch/ch_monitor.h | 3 +++ 2 files changed, 18

[PATCH 02/10] ch_monitor: Update virCHMonitorGet to handle accept a response

2021-06-29 Thread William Douglas
The virCHMonitorGet function needed to be able to return data from the hypervisor. This functionality is needed in order for the driver to support PTY enablement and getting details about the VM state. Signed-off-by: William Douglas --- src/ch/ch_monitor.c | 37

[PATCH 07/10] ch_process: Update the domain with console path information

2021-06-29 Thread William Douglas
Add call to update the domain with console path information from cloud-hypervisor as part of the last stages of initializing the domain. Signed-off-by: William Douglas --- src/ch/ch_process.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/ch/ch_process.c b/src/ch/ch_process.c index

[PATCH 08/10] ch_domain: Allow controller and chr devices

2021-06-29 Thread William Douglas
With the console and serial device handling fully functional, allow the required device types to be specified in the domain configuration. Signed-off-by: William Douglas --- src/ch/ch_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ch/ch_domain.c

[PATCH 00/10] ch: Add Console support

2021-06-29 Thread William Douglas
This series enables console support in the cloud-hypervisor driver. Cloud-hypervisor only supports a single console or serial device at a time, hence the checks to ensure the domain configuration is only passing one or the other. I wasn't sure if the controller device should have some additonal

[PATCH 01/10] ch_monitor: Make unused function static

2021-06-29 Thread William Douglas
The virCHMonitorGet function wasn't in use and was declared as non-static (though not in a header file). This function isn't going to be used outside of the monitor though so remove the initial declaration and define the function to be static. Future work should adjust this function to allow

Re: [PATCH] docs: formatdomain: Document disk serial truncation status quo

2021-06-29 Thread Tomáš Golembiovský
On Tue, Jun 29, 2021 at 03:33:26PM +0200, Peter Krempa wrote: > On Mon, Jun 28, 2021 at 16:55:34 +0200, Tomáš Golembiovský wrote: > > Hi, > > > > I have a few questions regarding this to get better understanding on how > > this should be handled by management apps. > > > > On Fri, Jun 04, 2021

Re: [PATCH] docs: formatdomain: Document disk serial truncation status quo

2021-06-29 Thread Peter Krempa
On Mon, Jun 28, 2021 at 16:55:34 +0200, Tomáš Golembiovský wrote: > Hi, > > I have a few questions regarding this to get better understanding on how > this should be handled by management apps. > > On Fri, Jun 04, 2021 at 02:08:40PM +0200, Peter Krempa wrote: > > Disk serials are truncated

Re: [libvirt PATCH 3/5] qemu: Default to TPM 2.0 for ARM virt guests

2021-06-29 Thread Andrea Bolognani
On Tue, Jun 29, 2021 at 02:54:24AM +, liuyd.f...@fujitsu.com wrote: > That works for me. Thanks. > > Tested-by: liuyd.f...@fujitsu.com Glad to hear that! Can you please provide a full Tested-by tag in the expected format Tested-by: FirstName LastName so that it's suitable for inclusion

Re: [PATCH 1/4] qemu: interface: add qemuDomainDefIsOvsport

2021-06-29 Thread Michal Prívozník
On 6/28/21 11:18 AM, zhangjl02 wrote: > From: zhangjl02 > > Tell whether a port definition is an ovs managed virtual port > --- > src/qemu/qemu_domain.c | 13 + > src/qemu/qemu_domain.h | 3 +++ > 2 files changed, 16 insertions(+) > > diff --git a/src/qemu/qemu_domain.c

Re: [PATCH 3/4] qemu: interface: remove setting noqueue for ovs port

2021-06-29 Thread Michal Prívozník
On 6/28/21 11:18 AM, zhangjl02 wrote: > From: zhangjl02 > > Return 0 directly if the port is ovs managed. When the ovs port is set > noqueue, qos config on this port will not work. > --- > src/qemu/qemu_domain.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/qemu/qemu_domain.c

Re: [PATCH 4/4] qemu: interface: check and use ovs command to set qos of ovs managed port

2021-06-29 Thread Michal Prívozník
On 6/28/21 11:18 AM, zhangjl02 wrote: > From: zhangjl02 > > When qos is set or delete, we have to check if the port is an ovs managed > port. If true, call the virNetDevOpenvswitchInterfaceSetQos function when qos > is set, and call the virNetDevOpenvswitchInterfaceClearQos function when > the

Re: [PATCH 2/4] qemu: interface: add virNetDevOpenvswitchInterfaceSetQos and virNetDevOpenvswitchInterfaceClearQos

2021-06-29 Thread Michal Prívozník
On 6/28/21 11:18 AM, zhangjl02 wrote: > From: zhangjl02 > > Introduce qos setting and cleaning method. Use ovs command to set qos > parameters on specific interface of qemu virtual machine. > > When an ovs port is created, we add 'ifname' to external-ids. When setting > qos on an ovs port,

Re: [PATCH v3 6/6] docs: add s390-pv documentation

2021-06-29 Thread Pavel Hrdina
On Tue, Jun 29, 2021 at 10:05:17AM +0200, Erik Skultety wrote: > ... > > > > +Example guest definition without launchSecurity > > > +=== > > > + > > > +Minimal domain XML for a protected virtualization guest using the > > > +``iommu='on'`` setting for

Re: [PATCH v2 1/3] test_driver: Implement virDomainGetMessages

2021-06-29 Thread Martin Kletzander
On Mon, Jun 28, 2021 at 11:36:45PM +0800, Luke Yue wrote: And I have another question, as it's freeze for 7.5.0, should I change the version number in comments to 7.6.0 in the new patches? Thanks! Yep, it won't make 7.5.0 now. Thanks. signature.asc Description: PGP signature

Re: [PATCH v3 6/6] docs: add s390-pv documentation

2021-06-29 Thread Boris Fiuczynski
On 6/25/21 12:11 PM, Pavel Hrdina wrote: @@ -158,8 +163,42 @@ allocated 2K entries. A commonly used value for swiotlb is 262144. Example guest definition -Minimal domain XML for a protected virtualization guest, essentially -it's mostly about the ``iommu``

Re: [PATCH v3 3/6] conf: refactor launch security to allow more types

2021-06-29 Thread Boris Fiuczynski
On 6/25/21 10:51 AM, Pavel Hrdina wrote: On Tue, Jun 22, 2021 at 03:10:46PM +0200, Boris Fiuczynski wrote: Adding virDomainSecDef for general launch security data and moving virDomainSEVDef as an element for SEV data. Signed-off-by: Boris Fiuczynski --- src/conf/domain_conf.c | 127

Re: [PATCH v3 6/6] docs: add s390-pv documentation

2021-06-29 Thread Erik Skultety
... > > +Example guest definition without launchSecurity > > +=== > > + > > +Minimal domain XML for a protected virtualization guest using the > > +``iommu='on'`` setting for each virtio device. > > I don't know how s390-pv works but for example with

libvirt-7.5.0 release candidate 2

2021-06-29 Thread Jiri Denemark
I have just tagged v7.5.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make