On 7/16/21 2:31 AM, Olaf Hering wrote:
Am Fri, 16 Jul 2021 00:58:43 -0700
schrieb Andrea Bolognani :
The sysconfig files shipped with libvirt contain the defaults, and
the admin is absolutely welcome to tweak them however they might like
after installation, just as is the case for all the
qemuMigrationSrcRunPrepareBlockDirtyBitmaps receives the flags parameter
from qemuMigrationSrcRun, where flags are based on the main API enum
values. Similar to commit f58349c9c6, use the main API enum instead of
internal driver enum when checking flags in
Signaling the condition before vm->def->id is reset to -1 is dangerous:
in case a waiting thread wakes up, it does not see anything interesting
(the domain is still marked as running) and just enters virDomainObjWait
where it waits forever because the condition will never be signalled
again.
On 7/16/21 8:51 AM, Daniel P. Berrangé wrote:
On Fri, Jul 16, 2021 at 09:49:40PM +0900, Motohiro Kawahito wrote:
From: "Daniel P. Berrangé"
To: Motohiro Kawahito
Cc: libvir-list@redhat.com
Date: 2021/07/16 17:22
Subject: [EXTERNAL] Re: Question about skipping
virDomainDiskDefAssignAddress
On Fri, Jul 16, 2021 at 09:49:40PM +0900, Motohiro Kawahito wrote:
> > From: "Daniel P. Berrangé"
> > To: Motohiro Kawahito
> > Cc: libvir-list@redhat.com
> > Date: 2021/07/16 17:22
> > Subject: [EXTERNAL] Re: Question about skipping
> virDomainDiskDefAssignAddress
> >
> > On Fri, Jul 16, 2021
> From: "Daniel P. Berrangé"
> To: Motohiro Kawahito
> Cc: libvir-list@redhat.com
> Date: 2021/07/16 17:22
> Subject: [EXTERNAL] Re: Question about skipping
virDomainDiskDefAssignAddress
>
> On Fri, Jul 16, 2021 at 01:01:50PM +0900, Motohiro Kawahito wrote:
> > > From: "Daniel P. Berrangé"
>
This series add the ability to statistic the halt polling time when
VM execute HLT(arm is WFI).
v1:
https://listman.redhat.com/archives/libvir-list/2021-July/msg00029.html
v2:
https://listman.redhat.com/archives/libvir-list/2021-July/msg00339.html
changes from v1:
- Move virGetCgroupValueRaw to
This function add halt polling time interface in domstats. So that
we can use command 'virsh domstats VM' to get the data if system
support.
Signed-off-by: Yang Fei
---
src/libvirt-domain.c | 7 +++
src/qemu/qemu_driver.c | 20
2 files changed, 27 insertions(+)
diff
Add helper function virGetCpuHaltPollTime to obtain halt polling
time. If the kernel support halt polling time statistic, and mount
debugfs. This function will take effect on KVM VMs.
Signed-off-by: Yang Fei
---
src/libvirt_private.syms | 1 +
src/util/virutil.c | 43
Please use this as fixup.
Signed-off-by: Boris Fiuczynski
---
docs/formatdomaincaps.html.in | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in
index 30a95d5594..5dbdb25849 100644
---
Even though 'id' attribute is output-only, we should accept xml
files containing it.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1941594
Signed-off-by: Kristina Hanicova
---
docs/formatdomain.rst | 2 +-
docs/schemas/domaincommon.rng | 5 +
2 files changed, 6
Kristina Hanicova (2):
docs: Allow 'id' attribute for 'cachetune' element
tests: Modify to test output value of
We can also delete out xml thanks to the change in the call of
the test to DO_TEST instead of DO_TEST_DIFFERENT.
Signed-off-by: Kristina Hanicova
---
tests/genericxml2xmlindata/cachetune.xml | 8 +++---
tests/genericxml2xmloutdata/cachetune.xml | 34 ---
Am Fri, 16 Jul 2021 00:58:43 -0700
schrieb Andrea Bolognani :
> This arrangement appears to be very common, too: on my Fedora 34
> machine, /etc/sysconfig contains ~25 files, all owned by some package
> and most consisting of at least one non-comment lines.
Forgot to reply to this paragraph:
Adding availability of s390-pv in domain capabilities and adjust tests.
Signed-off-by: Boris Fiuczynski
---
docs/schemas/domaincaps.rng| 9 +
src/conf/domain_capabilities.c | 1 +
src/conf/domain_capabilities.h | 1 +
This patch series introduces the launch security type s390-pv.
Specifying s390-pv as launch security type in an s390 domain prepares for
running the guest in protected virtualization secure mode, also known as
IBM Secure Execution.
diff to v4:
- changed rng to do the verification for every
Add s390-pv-guest capability.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Daniel Henrique Barboza
Reviewed-by: Pavel Hrdina
---
src/qemu/qemu_capabilities.c| 2 ++
src/qemu/qemu_capabilities.h| 1 +
tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 +
Add documentation for launch security type s390-pv.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Daniel Henrique Barboza
---
docs/formatdomain.rst | 7
docs/kbase/s390_protected_virt.rst | 55 +-
2 files changed, 54 insertions(+), 8 deletions(-)
Add documentation for domain capability s390-pv.
Signed-off-by: Boris Fiuczynski
---
docs/formatdomaincaps.html.in | 10 ++
1 file changed, 10 insertions(+)
diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in
index 10d23f4c0b..30a95d5594 100644
---
When SEV is not supported but specified in the domain XML by a user it
should not result in an internal error (VIR_ERR_INTERNAL_ERROR)
therefore switching to XML error (VIR_ERR_CONFIG_UNSUPPORTED).
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_validate.c | 2 +-
1 file changed, 1
Expose existing KVMSupportsSecureGuest capability.
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h | 3 +++
2 files changed, 9 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index
Use the common id 'lsec0' for all launchSecurity types in the QEMU
command line construction.
Signed-off-by: Boris Fiuczynski
---
src/qemu/qemu_command.c| 10 +-
.../launch-security-s390-pv.s390x-latest.args | 4 ++--
Add launch security type 's390-pv' as well as some tests.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Daniel Henrique Barboza
---
docs/schemas/domaincommon.rng | 5 +++
src/conf/domain_conf.c| 7
src/conf/domain_conf.h| 1
Adding virDomainSecDef for general launch security data
and moving virDomainSEVDef as an element for SEV data.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 133 +---
src/conf/domain_conf.h | 16
Change launch security to make it reusable for other types.
Signed-off-by: Boris Fiuczynski
---
docs/schemas/domaincommon.rng | 74 +++
1 file changed, 41 insertions(+), 33 deletions(-)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
Make use of virDomainLaunchSecurity enum.
Signed-off-by: Boris Fiuczynski
Reviewed-by: Daniel Henrique Barboza
---
src/conf/domain_conf.c | 108 -
1 file changed, 64 insertions(+), 44 deletions(-)
diff --git a/src/conf/domain_conf.c
Am Fri, 16 Jul 2021 00:58:43 -0700
schrieb Andrea Bolognani :
> The sysconfig files shipped with libvirt contain the defaults, and
> the admin is absolutely welcome to tweak them however they might like
> after installation, just as is the case for all the configuration
> files in /etc/libvirt.
Signed-off-by: Mahmoud Mandour
---
docs/system/deprecated.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index e2e0090878..aaf0ee5777 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -126,6 +126,12
On Fri, Jul 16, 2021 at 01:01:50PM +0900, Motohiro Kawahito wrote:
> > From: "Daniel P. Berrangé"
> > To: Motohiro Kawahito
> > Cc: libvir-list@redhat.com
> > Date: 2021/07/16 00:42
> > Subject: [EXTERNAL] Re: Question about skipping
> virDomainDiskDefAssignAddress
> >
>
> > With the
On Thu, Jul 15, 2021 at 11:23:37PM +0200, Olaf Hering wrote:
> sysconfig files are owned by the admin of the host. He has the liberty
> to put anything he wants into these files. This makes it difficult to
> provide different defaults.
>
> Remove the sysconfig file and place the current desired
30 matches
Mail list logo
