Re: [PATCH v3 1/2] util: Add virGetCpuHaltPollTime

On 2021/7/19 18:20, Michal Prívozník wrote: > On 7/16/21 12:42 PM, Yang Fei wrote: >> Add helper function virGetCpuHaltPollTime to obtain halt polling >> time. If the kernel support halt polling time statistic, and mount >> debugfs. This function will take effect on KVM VMs. >> >>

Re: [PATCH v3 2/2] qemu: Introduce qemuDomainGetStatsCpuHaltPollTime

On 2021/7/19 17:07, Peter Krempa wrote: > On Fri, Jul 16, 2021 at 18:42:23 +0800, Yang Fei wrote: >> This function add halt polling time interface in domstats. So that >> we can use command 'virsh domstats VM' to get the data if system >> support. >> >> Signed-off-by: Yang Fei >> --- >>

Re: [PATCH v3 1/2] util: Add virGetCpuHaltPollTime

On 2021/7/19 17:05, Peter Krempa wrote: > On Fri, Jul 16, 2021 at 18:42:22 +0800, Yang Fei wrote: >> Add helper function virGetCpuHaltPollTime to obtain halt polling >> time. If the kernel support halt polling time statistic, and mount >> debugfs. This function will take effect on KVM VMs. >>

[PATCH] meson: disable bogus warnings from sanitizers on Fedora

When building with sanitizers on Fedora we get a wierd error message In file included from /usr/include/string.h:519, from ../src/internal.h:28, from ../src/util/virsocket.h:21, from ../src/util/virsocketaddr.h:21, from

Re: [PATCH v1] virtqemud: remove sysconfig file

Am Mon, 19 Jul 2021 12:01:57 -0400 schrieb Andrea Bolognani : > On Fri, Jul 16, 2021 at 12:04:00PM +0200, Olaf Hering wrote: > > None of the files in /etc have to be owned by a package. > > We are slowly getting there. > Is this goal of having packages not touch /etc connected to the idea > of

Re: [PATCH v1] virtqemud: remove sysconfig file

On Fri, Jul 16, 2021 at 12:04:00PM +0200, Olaf Hering wrote: > Am Fri, 16 Jul 2021 00:58:43 -0700 > schrieb Andrea Bolognani : > > > This arrangement appears to be very common, too: on my Fedora 34 > > machine, /etc/sysconfig contains ~25 files, all owned by some package > > and most consisting of

Re: [libvirt PATCH] qemu: Signal domain condition in qemuProcessStop a bit later

On Mon, Jul 19, 2021 at 09:37:01 +0200, Michal Prívozník wrote: > On 7/16/21 5:06 PM, Jiri Denemark wrote: > > Signaling the condition before vm->def->id is reset to -1 is dangerous: > > in case a waiting thread wakes up, it does not see anything interesting > > (the domain is still marked as

Re: [PATCH v1] virtqemud: remove sysconfig file

Am Mon, 19 Jul 2021 13:21:39 +0100 schrieb Daniel P. Berrangé : > The challenge i see here is that of managing upgrades to the proposed > state. This is as easy as this for each modified file that was marked as %config(noreplace): %pre test -f /etc/sysconfig/file.rpmsave && mv -v "$_" "$_".old

Re: [libvirt PATCH 00/10] virHashNew refactorings - part VI

On Mon, 2021-07-19 at 14:08 +0200, Peter Krempa wrote: > On Mon, Jul 19, 2021 at 11:55:44 +0200, Tim Wiederhake wrote: > > "virHashNew" cannot return NULL, yet we check for NULL in various > > places. > > > > See > > https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html > > . >

Re: [PATCH v1] virtqemud: remove sysconfig file

On Mon, Jul 19, 2021 at 02:07:10PM +0200, Olaf Hering wrote: > Am Mon, 19 Jul 2021 09:55:37 +0100 > schrieb Daniel P. Berrangé : > > > I don't see that would have made any change since --listen was not enabled > > either before / after the changes. > > It was the default in the SUSE package. > I

Re: [PATCH 0/5] virsh: avoid local enum helpers with 'vir' prefix

On a %A in %Y, Peter Krempa wrote: > Follow up to: > > https://listman.redhat.com/archives/libvir-list/2021-July/msg00281.html > > Peter Krempa (5): > virsh-host: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers > virsh-domain: Avoid 'vir' prefix for locally declared VIR_ENUM* >

Re: [PATCH 13/13] docs/deprecated: deprecate passing plugin args through `arg=`

On Sat, Jul 17, 2021 at 12:09:20 +0200, Mahmoud Mandour wrote: > Signed-off-by: Mahmoud Mandour > --- > docs/system/deprecated.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst > index e2e0090878..aaf0ee5777 100644 > ---

Re: [PATCH v1] virtqemud: remove sysconfig file

Am Mon, 19 Jul 2021 09:55:37 +0100 schrieb Daniel P. Berrangé : > I don't see that would have made any change since --listen was not enabled > either before / after the changes. It was the default in the SUSE package. I should have checked libvirt.git if it has been used. > Originally the

Re: [libvirt PATCH 00/10] virHashNew refactorings - part VI

On Mon, Jul 19, 2021 at 11:55:44 +0200, Tim Wiederhake wrote: > "virHashNew" cannot return NULL, yet we check for NULL in various places. > > See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html. > > Tim Wiederhake (10): > qemuStateInitialize: `virHashNew` cannot return

[PATCH 3/5] virsh-network: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers

Stuff used in virsh should use 'virsh'. Signed-off-by: Peter Krempa --- tools/virsh-network.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index d95db7f6d1..152df1086b 100644 --- a/tools/virsh-network.c +++

[PATCH 4/5] virsh-volume: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers

Stuff used in virsh should use 'virsh'. Signed-off-by: Peter Krempa --- tools/virsh-volume.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index 1da9b7217f..fe632b1b19 100644 --- a/tools/virsh-volume.c +++

[PATCH 5/5] syntax-check: Prohibit 'vir' prefix for enum implementations in virsh

Avoid potential conflict of enum helpers declared in virsh. Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 7 +++ 1 file changed, 7 insertions(+) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 256f9f695a..cedb360bfd 100644 ---

[PATCH 2/5] virsh-domain: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers

Stuff used in virsh should use 'virsh'. Signed-off-by: Peter Krempa --- tools/virsh-completer-domain.c | 8 tools/virsh-domain.c | 16 tools/virsh-domain.h | 8 3 files changed, 16 insertions(+), 16 deletions(-) diff --git

[PATCH 0/5] virsh: avoid local enum helpers with 'vir' prefix

Follow up to: https://listman.redhat.com/archives/libvir-list/2021-July/msg00281.html Peter Krempa (5): virsh-host: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers virsh-domain: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers virsh-network: Avoid 'vir' prefix for

[PATCH 1/5] virsh-host: Avoid 'vir' prefix for locally declared VIR_ENUM* helpers

Stuff used in virsh should use 'virsh'. Signed-off-by: Peter Krempa --- tools/virsh-completer-host.c | 2 +- tools/virsh-domain.c | 2 +- tools/virsh-host.c | 4 ++-- tools/virsh-host.h | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [libvirt PATCH v2 0/2] Remove macros "VIR_INSERT_ELEMENT_COPY" and "VIR_INSERT_ELEMENT_COPY_INPLACE"

On 7/9/21 3:23 PM, Tim Wiederhake wrote: > See https://listman.redhat.com/archives/libvir-list/2021-July/msg00163.html > > Changes since V1: > * Fixed a mistake in the copy-out of virQEMUCapsGetMachineTypesCaps, where > the array was allocated with the un-adjusted size. > > Tim Wiederhake (2): >

Re: [PATCH v3 1/2] util: Add virGetCpuHaltPollTime

On 7/16/21 12:42 PM, Yang Fei wrote: > Add helper function virGetCpuHaltPollTime to obtain halt polling > time. If the kernel support halt polling time statistic, and mount > debugfs. This function will take effect on KVM VMs. > > Signed-off-by: Yang Fei > --- > src/libvirt_private.syms | 1 +

Re: [PATCH 2/2] tests: Modify to test output value of

On 7/16/21 12:15 PM, Kristina Hanicova wrote: > We can also delete out xml thanks to the change in the call of > the test to DO_TEST instead of DO_TEST_DIFFERENT. I think the subject can be formatted better: genericxml2xmltest: Modify cachetune test to include id Alternatively, the element

Re: [PATCH 1/2] docs: Allow 'id' attribute for 'cachetune' element

On 7/16/21 12:15 PM, Kristina Hanicova wrote: > Even though 'id' attribute is output-only, we should accept xml > files containing it. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1941594 > > Signed-off-by: Kristina Hanicova > --- > docs/formatdomain.rst | 2 +- >

[libvirt PATCH 09/10] testQemuGetLatestCaps: Use automatic memory management

Signed-off-by: Tim Wiederhake --- tests/testutilsqemu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 72c0b1857b..72b53096d9 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -585,7 +585,7 @@

[libvirt PATCH 00/10] virHashNew refactorings - part VI

"virHashNew" cannot return NULL, yet we check for NULL in various places. See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html. Tim Wiederhake (10): qemuStateInitialize: `virHashNew` cannot return NULL qemuMonitorGetPRManagerInfo: `virHashNew` cannot return NULL

[libvirt PATCH 10/10] testQemuGetLatestCaps: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- tests/testutilsqemu.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 72b53096d9..fab676c070 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -594,7 +594,7 @@

[libvirt PATCH 08/10] testQemuGetLatestCaps: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- tests/testutilsqemu.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index be576037e2..72c0b1857b 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -585,12 +585,9 @@

[libvirt PATCH 05/10] qemuMonitorJSONGetAllBlockJobInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor_json.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 22339d..472308e1d3 100644 --- a/src/qemu/qemu_monitor_json.c +++

[libvirt PATCH 07/10] qemuMonitorJSONGetAllBlockJobInfo: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor_json.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 59c5eedb0a..7e53e0ce84 100644 --- a/src/qemu/qemu_monitor_json.c +++

[libvirt PATCH 04/10] qemuMonitorGetPRManagerInfo: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 36b1f15c7d..b06c842a7a 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4515,7

[libvirt PATCH 03/10] qemuMonitorGetPRManagerInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 940eeab9a8..36b1f15c7d 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4516,21 +4516,18

[libvirt PATCH 06/10] qemuMonitorJSONGetAllBlockJobInfo: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor_json.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 472308e1d3..59c5eedb0a 100644 --- a/src/qemu/qemu_monitor_json.c +++

[libvirt PATCH 01/10] qemuStateInitialize: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index df44c3fbd0..521063d438 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -753,8 +753,7 @@

[libvirt PATCH 02/10] qemuMonitorGetPRManagerInfo: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index f66a3457c1..940eeab9a8 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4522,8 +4522,7 @@

Re: [PATCH] test_driver: Implement virDomainGetControlInfo and add test

On 7/13/21 2:21 PM, Luke Yue wrote: > As test driver won't have real background job running, in order to get > all possible states, the time is used here to decide which state to be > returned. The default time will get `ok` as return value. > > Note that using `virsh domtime fc4 200` won't take

Re: [libvirt PATCH 2/2] virsh: allow nodedev-list --all --tree

On 7/7/21 11:29 PM, Jonathon Jongsma wrote: > Allow the tree view with --all so that we can see all inactive mdevs in > a tree structure nested under their parent devices. > > Signed-off-by: Jonathon Jongsma > --- > tools/virsh-nodedev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [libvirt PATCH 1/2] nodedev: fix parent device of inactive mdevs

On 7/7/21 11:29 PM, Jonathon Jongsma wrote: > Inactive mdevs were simply formatting their parent name as the value > received from mdevctl rather than looking up the libvirt nodedev name of > the parent device. This resulted in a parent value of e.g. > ':5b:00.0' instead of 'pci__5b_00_0'.

Re: [PATCH v3 2/2] qemu: Introduce qemuDomainGetStatsCpuHaltPollTime

On Fri, Jul 16, 2021 at 18:42:23 +0800, Yang Fei wrote: > This function add halt polling time interface in domstats. So that > we can use command 'virsh domstats VM' to get the data if system > support. > > Signed-off-by: Yang Fei > --- > src/libvirt-domain.c | 7 +++ >

Re: [PATCH v3 1/2] util: Add virGetCpuHaltPollTime

On Fri, Jul 16, 2021 at 18:42:22 +0800, Yang Fei wrote: > Add helper function virGetCpuHaltPollTime to obtain halt polling > time. If the kernel support halt polling time statistic, and mount > debugfs. This function will take effect on KVM VMs. > > Signed-off-by: Yang Fei > --- >

Re: [PATCH v1] virtqemud: remove sysconfig file

On Fri, Jul 16, 2021 at 10:31:11AM +0200, Olaf Hering wrote: > Am Fri, 16 Jul 2021 00:58:43 -0700 > schrieb Andrea Bolognani : > > > The sysconfig files shipped with libvirt contain the defaults, and > > the admin is absolutely welcome to tweak them however they might like > > after installation,

Re: Question about skipping virDomainDiskDefAssignAddress

On Mon, Jul 19, 2021 at 11:00:33AM +0900, Motohiro Kawahito wrote: > Laine Stump wrote on 2021/07/17 00:01:36: > > > From: Laine Stump > > To: Libvirt > > Cc: Motohiro Kawahito , "Daniel P. Berrangé" > > > > Date: 2021/07/17 00:01 > > Subject: [EXTERNAL] Re: Question about skipping >

Re: How do we specify disk device names for non-Linux VMs in XML?

On Fri, Jul 16, 2021 at 10:53:54 +0900, Motohiro Kawahito wrote: > The XML parser (or verifier) in libvirt seems to support only Linux device > names for a disk, such as hda, sda and vda. > Can anyone let us know how libvirt supports disk device names for > non-Linux VMs? > We are developing a

Re: [PATCH] qemu: migration: Use correct flag when preparing block dirty bitmaps

On Fri, Jul 16, 2021 at 09:30:03 -0600, Jim Fehlig wrote: > qemuMigrationSrcRunPrepareBlockDirtyBitmaps receives the flags parameter > from qemuMigrationSrcRun, where flags are based on the main API enum > values. Similar to commit f58349c9c6, use the main API enum instead of > internal driver

Re: [libvirt PATCH] qemu: Signal domain condition in qemuProcessStop a bit later

On 7/16/21 5:06 PM, Jiri Denemark wrote: > Signaling the condition before vm->def->id is reset to -1 is dangerous: > in case a waiting thread wakes up, it does not see anything interesting > (the domain is still marked as running) and just enters virDomainObjWait > where it waits forever because