RE: [libvirt][PATCH v4 3/4] qemu: Add command-line to enable SGX

2021-07-20 Thread Huang, Haibin
> -Original Message- > From: Daniel P. Berrangé > Sent: Tuesday, July 20, 2021 5:08 PM > To: Huang, Haibin > Cc: libvir-list@redhat.com; Ding, Jian-feng ; Yang, > Lin A ; Lu, Lianhao > Subject: Re: [libvirt][PATCH v4 3/4] qemu: Add command-line to enable SGX > > On Thu, Jul 01, 2021

Re: [PATCH v1] remove sysconfig files

2021-07-20 Thread Olaf Hering
Am Tue, 20 Jul 2021 19:00:20 +0200 schrieb Olaf Hering : > +#Environment=QEMU_AUDIO_DRV=sdl > +#Environment=SDL_AUDIODRIVER=pulse These two knobs are undocumented. Instead of dropping them I decided to put them into the service files. I do not know if both are intended for a wider audience, or

[PATCH v1] remove sysconfig files

2021-07-20 Thread Olaf Hering
sysconfig files are owned by the admin of the host. He has the liberty to put anything he wants into these files. This makes it difficult to provide different built-in defaults. Remove the sysconfig file and place the current desired default into the service file. Local customizations can now go

[PATCH] qemu_migration: Unregister close callback only if connection still exists

2021-07-20 Thread Michal Privoznik
When doing a peer-to-peer migration it may happen that the connection to the destination disappears. If that happens, there's no point in trying to unregister the close callback because the connection is closed already. It results only in polluting logs with this message: error :

Re: [libvirt PATCH] virIdentityEnsureSystemToken: Fix error message

2021-07-20 Thread Daniel P . Berrangé
On Tue, Jul 20, 2021 at 05:04:20PM +0200, Tim Wiederhake wrote: > This appears to be a copy-paste mistake from the check directly above. > > Signed-off-by: Tim Wiederhake > --- > src/util/viridentity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [libvirt PATCH] virIdentityEnsureSystemToken: Fix error message

2021-07-20 Thread Jano Tomko
On a %A in %Y, Tim Wiederhake wrote: > This appears to be a copy-paste mistake from the check directly above. > > Signed-off-by: Tim Wiederhake > --- > src/util/viridentity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Ján Tomko Jano

[libvirt PATCH] ci: maximize cirrus CI ram/cpu allocation

2021-07-20 Thread Daniel P . Berrangé
For macOS you always get the maximum configuration by default (12 CPUs, 24 GB RAM), but for FreeBSD you get 2 CPUs, 4 GBs by default. This change increases the allocation to 8 CPUs, 8 GBs for FreeBSD. Signed-off-by: Daniel P. Berrangé --- In theory this could make builds quicker. In practice

[libvirt PATCH] virIdentityEnsureSystemToken: Fix error message

2021-07-20 Thread Tim Wiederhake
This appears to be a copy-paste mistake from the check directly above. Signed-off-by: Tim Wiederhake --- src/util/viridentity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/viridentity.c b/src/util/viridentity.c index eb77f69e2e..c18326c8cb 100644 ---

[PATCH 1/2] genericxml2xmltest: Substitute 'inactive' variable with 'active'

2021-07-20 Thread Kristina Hanicova
Having negation in a name of a bool variable seems a bit confusing to me. I think the substitution makes the code much more readable. Signed-off-by: Kristina Hanicova --- tests/genericxml2xmltest.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-)

Re: [PATCH v2 0/2] Add support for 'id' attribute for 'cachetune'

2021-07-20 Thread Michal Prívozník
On 7/20/21 2:58 PM, Kristina Hanicova wrote: > This is v2 of: > https://listman.redhat.com/archives/libvir-list/2021-July/msg00441.html > > Changes since v1 (suggested by Michal): > * slight change of documentation > * improved commit message > > Kristina Hanicova (2): > docs: Allow 'id'

[PATCH 2/2] genericxml2xmltest: Refactor DO_TEST_FULL() calls

2021-07-20 Thread Kristina Hanicova
I have added 2 new macros to call tests which are expected to fail in order to make the code more consistent and readable. Signed-off-by: Kristina Hanicova --- tests/genericxml2xmltest.c | 63 +++--- 1 file changed, 25 insertions(+), 38 deletions(-) diff --git

[PATCH 0/2] genericxml2xmltest: Refactor test calls

2021-07-20 Thread Kristina Hanicova
Kristina Hanicova (2): genericxml2xmltest: Substitute 'inactive' variable with 'active' genericxml2xmltest: Refactor DO_TEST_FULL() calls tests/genericxml2xmltest.c | 71 -- 1 file changed, 29 insertions(+), 42 deletions(-) -- 2.31.1

Re: [PATCH v5 02/11] conf: Rework SEV XML parse and format methods

2021-07-20 Thread Pavel Hrdina
On Fri, Jul 16, 2021 at 11:44:26AM +0200, Boris Fiuczynski wrote: > Make use of virDomainLaunchSecurity enum. > > Signed-off-by: Boris Fiuczynski > Reviewed-by: Daniel Henrique Barboza > --- > src/conf/domain_conf.c | 108 - > 1 file changed, 64

[PATCH v2 2/2] genericxml2xmltest: Modify cachetune test to include id

2021-07-20 Thread Kristina Hanicova
I changed DO_TEST_DIFFERENT to DO_TEST, which allows us to remove the duplicate out file. I also added id attribute for domain element in order to parse it as a live XML ('cachetune id' is in the output of only live XMLs). Lastly I added id of cachetune to test its output value. Signed-off-by:

[PATCH v2 1/2] docs: Allow 'id' attribute for 'cachetune' element

2021-07-20 Thread Kristina Hanicova
Even though 'id' attribute is output-only, we should accept xml files containing it. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1941594 Signed-off-by: Kristina Hanicova --- docs/formatdomain.rst | 1 + docs/schemas/domaincommon.rng | 5 + 2 files changed, 6 insertions(+)

[PATCH v2 0/2] Add support for 'id' attribute for 'cachetune'

2021-07-20 Thread Kristina Hanicova
This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-July/msg00441.html Changes since v1 (suggested by Michal): * slight change of documentation * improved commit message Kristina Hanicova (2): docs: Allow 'id' attribute for 'cachetune' element genericxml2xmltest: Modify

Re: [libvirt PATCH] docs: add kbase article on how to configure core dumps for QEMU

2021-07-20 Thread Michal Prívozník
On 7/20/21 2:12 PM, Daniel P. Berrangé wrote: > Enabling core dumps is a reasonably straightforward task, but is not > documented clearly. This page provides as easy link to point users > to when they need to debug QEMU. > > Signed-off-by: Daniel P. Berrangé > --- > docs/kbase/index.rst

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-20 Thread Erik Skultety
On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote: > > lavocado aims to be an alternative test framework for the libvirt > > project using Python, python-libvirt and Avocado. This can be used to > > write unit,

[libvirt PATCH] docs: add kbase article on how to configure core dumps for QEMU

2021-07-20 Thread Daniel P . Berrangé
Enabling core dumps is a reasonably straightforward task, but is not documented clearly. This page provides as easy link to point users to when they need to debug QEMU. Signed-off-by: Daniel P. Berrangé --- docs/kbase/index.rst | 4 ++ docs/kbase/meson.build| 1 +

Plans for the next release

2021-07-20 Thread Jiri Denemark
We are getting close to the next release of libvirt. To aim for the release on Aug 02 I suggest entering the freeze on Tuesday Jul 27 and tagging RC2 on Thursday Jul 29. I'll be on PTO next week and thus I won't be able to make the RC releases, Pavel Hrdina volunteered to make them while I'm

Re: [libvirt][PATCH v4 0/4] Support query and use SGX

2021-07-20 Thread Pavel Hrdina
On Tue, Jul 20, 2021 at 10:16:48AM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 20, 2021 at 10:47:27AM +0200, Pavel Hrdina wrote: > > On Fri, Jul 16, 2021 at 12:58:19AM +, Huang, Haibin wrote: > > > > > > > -Original Message- > > > > From: Pavel Hrdina > > > > Sent: Wednesday, July

Re: [libvirt][PATCH v4 0/4] Support query and use SGX

2021-07-20 Thread Daniel P . Berrangé
On Tue, Jul 20, 2021 at 10:47:27AM +0200, Pavel Hrdina wrote: > On Fri, Jul 16, 2021 at 12:58:19AM +, Huang, Haibin wrote: > > > > > -Original Message- > > > From: Pavel Hrdina > > > Sent: Wednesday, July 7, 2021 5:48 PM > > > To: Huang, Haibin > > > Cc: libvir-list@redhat.com;

Re: [libvirt][PATCH v4 0/4] Support query and use SGX

2021-07-20 Thread Daniel P . Berrangé
On Wed, Jul 07, 2021 at 11:47:37AM +0200, Pavel Hrdina wrote: > On Thu, Jul 01, 2021 at 08:10:25PM +0800, Haibin Huang wrote: > > This patch series provides support for enabling Intel's Software Guard > > Extensions (SGX) feature in guest VM. > > > > Giving the SGX support in QEMU is still

Re: [libvirt][PATCH v4 3/4] qemu: Add command-line to enable SGX

2021-07-20 Thread Daniel P . Berrangé
On Thu, Jul 01, 2021 at 08:10:28PM +0800, Haibin Huang wrote: > From: Lin Yang > > If SGX is defined in domain, add the argument to enable > SGX in -cpu : > > -cpu ,+sgx,+sgx-debug,+sgx1,+sgx-encls-c, > +sgx-enclv,+sgx-exinfo,+sgx-kss,+sgx-mode64, >

Re: [PATCH v3 1/2] util: Add virGetCpuHaltPollTime

2021-07-20 Thread Michal Prívozník
On 7/20/21 4:55 AM, Yang Fei wrote: > > > On 2021/7/19 17:05, Peter Krempa wrote: >> On Fri, Jul 16, 2021 at 18:42:22 +0800, Yang Fei wrote: >>> Add helper function virGetCpuHaltPollTime to obtain halt polling >>> time. If the kernel support halt polling time statistic, and mount >>> debugfs.

Re: [libvirt][PATCH v4 0/4] Support query and use SGX

2021-07-20 Thread Pavel Hrdina
On Fri, Jul 16, 2021 at 12:58:19AM +, Huang, Haibin wrote: > > > -Original Message- > > From: Pavel Hrdina > > Sent: Wednesday, July 7, 2021 5:48 PM > > To: Huang, Haibin > > Cc: libvir-list@redhat.com; Ding, Jian-feng ; > > Yang, > > Lin A ; Lu, Lianhao > > Subject: Re:

Re: [PATCH] meson: disable bogus warnings from sanitizers on Fedora

2021-07-20 Thread Tim Wiederhake
On Mon, 2021-07-19 at 19:19 +0100, Daniel P. Berrangé wrote: > When building with sanitizers on Fedora we get a wierd error weird > message > > In file included from /usr/include/string.h:519, > from ../src/internal.h:28, > from ../src/util/virsocket.h:21, >