> -Original Message-
> From: Daniel P. Berrangé
> Sent: Tuesday, July 20, 2021 5:08 PM
> To: Huang, Haibin
> Cc: libvir-list@redhat.com; Ding, Jian-feng ; Yang,
> Lin A ; Lu, Lianhao
> Subject: Re: [libvirt][PATCH v4 3/4] qemu: Add command-line to enable SGX
>
> On Thu, Jul 01, 2021
Daniel P. Berrangé writes:
> On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote:
>>
>> This is supported already:
>>
>> $ avocado run --tap - --test-runner='nrunner' tests/domain/transient.py
>> 1..3
>> ok 1 tests/domain/transient.py:TransientDomain.test_autostart
>> ok 2
On Wed, Jul 21, 2021 at 06:50:03PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote:
> > On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote:
> > > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote:
> > > > I'm adding more
On Tue, Jul 20, 2021 at 02:19:25PM +0200, Erik Skultety wrote:
> On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote:
> > Libvirt has consumers writing applications in a variety of
> > languages, and periodically reporting bugs. My general wish
> > for a test harness would be for
On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote:
> On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote:
> > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote:
> > > I'm adding more information with some details inside the README file.
> >
> > Overall, I'm
On Wed, Jul 21, 2021 at 2:29 PM Peter Krempa wrote:
> On Wed, Jul 21, 2021 at 14:05:05 +0200, Kristina Hanicova wrote:
> > We didn't always save status xml after generating new taint
> > message, which resulted in it being deleted in case of a libvirtd
> > restart. Some taint messages were
On 7/21/21 3:02 PM, Daniel P. Berrangé wrote:
> On Wed, Jul 21, 2021 at 02:29:34PM +0200, Peter Krempa wrote:
>> On Wed, Jul 21, 2021 at 14:05:05 +0200, Kristina Hanicova wrote:
>>> We didn't always save status xml after generating new taint
>>> message, which resulted in it being deleted in case
On Fri, Jul 16, 2021 at 11:10:28AM +0800, Zhenzhong Duan wrote:
> Thanks Peter, Pavel and Daniel's comments on v1 version, now the v2 comes.
>
> * What's TDX?
> TDX stands for Trust Domain Extensions which isolates VMs from
> the virtual-machine manager (VMM)/hypervisor and any other software on
On Wed, Jul 21, 2021 at 10:13:32AM -0400, Andrea Bolognani wrote:
> On Wed, Jul 21, 2021 at 02:07:58PM +0100, Daniel P. Berrangé wrote:
> > On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote:
> > > Also pre-existing: do we even care about handling upgrades from
> > > versions of the
On Wed, Jul 21, 2021 at 02:07:58PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote:
> > Also pre-existing: do we even care about handling upgrades from
> > versions of the daemon that didn't have support for systemd socket
> > passing at this
On Wed, Jul 21, 2021 at 03:08:02PM +0200, Peter Krempa wrote:
> On Wed, Jul 21, 2021 at 14:46:43 +0200, Tim Wiederhake wrote:
> > The undefined behaviour sanitizer (UBSAN) defaults to merely printing an
> > error message if it detects undefined behaviour. These error messages often
> > end up in
On Wed, Jul 21, 2021 at 03:08:02PM +0200, Peter Krempa wrote:
> On Wed, Jul 21, 2021 at 14:46:43 +0200, Tim Wiederhake wrote:
> > +++ b/.gitlab-ci.yml
> > @@ -89,6 +89,8 @@ stages:
> > - meson build --werror -Ddocs=disabled -Db_lundef=false
> > -Db_sanitize="$SANITIZER"
> > - ninja -C
Am Wed, 21 Jul 2021 06:00:12 -0700
schrieb Andrea Bolognani :
> For most software, the default configuration files consist of mostly
> comments and act more like documentation for what the local
> configuration might look like. Claiming that the defaults are
> actually defined in the source code
ping
On Wed, 2021-07-14 at 11:44 +0200, Tim Wiederhake wrote:
> "virHashNew" cannot return NULL, yet we check for NULL in various
> places.
>
> See
> https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html
> .
>
> Tim Wiederhake (10):
> conf: Add AUTOPTR_CLEANUP_FUNC for
On Wed, Jul 21, 2021 at 03:02:59PM +0200, Peter Krempa wrote:
> On Wed, Jul 21, 2021 at 14:46:42 +0200, Tim Wiederhake wrote:
> > virFileReadLimFD always returns null-terminated data. To that end, it has to
> > add one to the maximum file size. If the maxium file size is INT_MAX, this
> > triggers
On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote:
> On Tue, Jul 20, 2021 at 07:00:20PM +0200, Olaf Hering wrote:
> > if [ -f %{_localstatedir}/lib/rpm-state/libvirt/restart ]; then
> > # See if user has previously modified their install to
> > # tell libvirtd to use
On Wed, Jul 21, 2021 at 14:46:43 +0200, Tim Wiederhake wrote:
> The undefined behaviour sanitizer (UBSAN) defaults to merely printing an
> error message if it detects undefined behaviour. These error messages often
> end up in captured output and do not fail the tests, effectively hiding
> the
On a %A in %Y, Peter Krempa wrote:
> On Wed, Jul 21, 2021 at 14:46:40 +0200, Tim Wiederhake wrote:
>> The next commit will use this macro outside the apparmor context.
>>
>> Signed-off-by: Tim Wiederhake
>> ---
>> src/security/security_apparmor.c | 4 ++--
>> src/security/security_apparmor.h |
On Wed, Jul 21, 2021 at 14:46:42 +0200, Tim Wiederhake wrote:
> virFileReadLimFD always returns null-terminated data. To that end, it has to
> add one to the maximum file size. If the maxium file size is INT_MAX, this
> triggers a signed integer overflow.
>
> There is no instance left where a
On Wed, Jul 21, 2021 at 02:29:34PM +0200, Peter Krempa wrote:
> On Wed, Jul 21, 2021 at 14:05:05 +0200, Kristina Hanicova wrote:
> > We didn't always save status xml after generating new taint
> > message, which resulted in it being deleted in case of a libvirtd
> > restart. Some taint messages
On Wed, Jul 21, 2021 at 14:46:40 +0200, Tim Wiederhake wrote:
> The next commit will use this macro outside the apparmor context.
>
> Signed-off-by: Tim Wiederhake
> ---
> src/security/security_apparmor.c | 4 ++--
> src/security/security_apparmor.h | 1 -
> src/security/virt-aa-helper.c|
On Wed, Jul 21, 2021 at 01:23:56PM +0200, Olaf Hering wrote:
> Am Wed, 21 Jul 2021 03:16:39 -0700 schrieb Andrea Bolognani
> :
> > On Tue, Jul 20, 2021 at 07:00:20PM +0200, Olaf Hering wrote:
> > > sysconfig files are owned by the admin of the host. He has the liberty
> > > to put anything he
On Wed, Jul 21, 2021 at 14:46:41 +0200, Tim Wiederhake wrote:
> The use of INT_MAX as maximum file length is problematic for reasons
> discussed in the next commit.
>
> Signed-off-by: Tim Wiederhake
> ---
> tests/networkxml2firewalltest.c | 2 +-
> tests/testutils.c | 5 +++--
> 2
virFileReadLimFD always returns null-terminated data. To that end, it has to
add one to the maximum file size. If the maxium file size is INT_MAX, this
triggers a signed integer overflow.
There is no instance left where a caller would call virFileReadLimFD with a
maxium file size of INT_MAX. Make
The undefined behaviour sanitizer (UBSAN) defaults to merely printing an
error message if it detects undefined behaviour. These error messages often
end up in captured output and do not fail the tests, effectively hiding
the warning. Make the test cases fail to make the issues visible.
The use of INT_MAX as maximum file length is problematic for reasons
discussed in the next commit.
Signed-off-by: Tim Wiederhake
---
tests/networkxml2firewalltest.c | 2 +-
tests/testutils.c | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git
The next commit will use this macro outside the apparmor context.
Signed-off-by: Tim Wiederhake
---
src/security/security_apparmor.c | 4 ++--
src/security/security_apparmor.h | 1 -
src/security/virt-aa-helper.c| 10 +-
src/util/virfile.h | 3 +++
4 files changed,
The undefined behaviour sanitizer (UBSAN) defaults to merely printing an
error message if it detects undefined behaviour. These error messages often
end up in captured output and do not fail the tests, effectively hiding
the warning.
This series fixes all previously hidden issues and makes UBSAN
On Wed, Jul 21, 2021 at 14:05:05 +0200, Kristina Hanicova wrote:
> We didn't always save status xml after generating new taint
> message, which resulted in it being deleted in case of a libvirtd
> restart. Some taint messages were preserved thanks to saving
> status xml separately at the end of
On 7/20/21 4:44 PM, Kristina Hanicova wrote:
>
> Kristina Hanicova (2):
> genericxml2xmltest: Substitute 'inactive' variable with 'active'
> genericxml2xmltest: Refactor DO_TEST_FULL() calls
>
> tests/genericxml2xmltest.c | 71 --
> 1 file changed, 29
On Wed, Jul 21, 2021 at 12:06:35PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 21, 2021 at 11:48:17AM +0100, Daniel P. Berrangé wrote:
> > Thus I'm really puzzelled why libvirt didn't see a real benefit
> > when I tested it. As you say though, FreeBSD builds are no worse
> > than Linux builds,
On Wed, Jul 21, 2021 at 12:36:40PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote:
> > In particular, I worry about changes in defaults being more difficult
> > for users to detect: in Debian at least, changes to the default
> > sysconfig files
On a %A in %Y, Peter Krempa wrote:
> Peter Krempa (33):
> qemu: monitor: Remove handlers for the 'POWERDOWN' event
> qemu: monitor: Remove return value from qemuMonitorEmit* functions
> qemu: Remove return value from qemuMonitorDomainEventCallback
> qemu: Remove return value from
On a %A in %Y, Peter Krempa wrote:
> The submission of the event to the helper thread has a verbose cleanup
> path which was duplicated in all the event handlers. Simplify it by
> extracting the code into a helper named 'qemuProcessEventSubmit' and
> reuse it where appropriate.
>
> Signed-off-by:
On a %A in %Y, Peter Krempa wrote:
> The callers in the monitor code invoking the callbacks after events are
> received don't actually check the return value from the callbacks and
> there isn't really anything we could do on failure.
>
> Remove the return value from the intermediary functions so
We didn't always save status xml after generating new taint
message, which resulted in it being deleted in case of a libvirtd
restart. Some taint messages were preserved thanks to saving
status xml separately at the end of the calling functions (which
makes sense, because qemuDomainObjTaint was
On Wed, Jul 21, 2021 at 01:51:01PM +0200, Olaf Hering wrote:
> Am Wed, 21 Jul 2021 12:36:40 +0100
> schrieb Daniel P. Berrangé :
>
> > If we remove the sysconfig files, we're not expecting users to
> > modify the .service files. Instead they will be using the systemd
> > overrides in
Am Wed, 21 Jul 2021 12:36:40 +0100
schrieb Daniel P. Berrangé :
> If we remove the sysconfig files, we're not expecting users to
> modify the .service files. Instead they will be using the systemd
> overrides in /etc/systemd/system/libvirtd.service.d/ to
> customize.
Why not /etc/sysconfig/file
On Wed, Jul 21, 2021 at 03:16:39AM -0700, Andrea Bolognani wrote:
> On Tue, Jul 20, 2021 at 07:00:20PM +0200, Olaf Hering wrote:
> In particular, I worry about changes in defaults being more difficult
> for users to detect: in Debian at least, changes to the default
> sysconfig files result in the
Commit e9b534905f4 introduced an error when parsing an empty list
returned from mdevctl.
This occurs e.g. if nodedev-undefine is used to undefine the last
defined mdev which causes the following error messages
libvirtd[33143]: internal error: Unexpected format for mdevctl response
Am Wed, 21 Jul 2021 03:16:39 -0700
schrieb Andrea Bolognani :
> On Tue, Jul 20, 2021 at 07:00:20PM +0200, Olaf Hering wrote:
> > sysconfig files are owned by the admin of the host. He has the liberty
> > to put anything he wants into these files. This makes it difficult to
> > provide different
On Wed, Jul 21, 2021 at 01:07:04PM +0200, Michal Prívozník wrote:
> On 7/20/21 5:05 PM, Daniel P. Berrangé wrote:
> > For macOS you always get the maximum configuration by default (12 CPUs,
> > 24 GB RAM), but for FreeBSD you get 2 CPUs, 4 GBs by default. This
> > change increases the allocation
On 7/20/21 5:05 PM, Daniel P. Berrangé wrote:
> For macOS you always get the maximum configuration by default (12 CPUs,
> 24 GB RAM), but for FreeBSD you get 2 CPUs, 4 GBs by default. This
> change increases the allocation to 8 CPUs, 8 GBs for FreeBSD.
>
> Signed-off-by: Daniel P. Berrangé
> ---
On Wed, Jul 21, 2021 at 11:48:17AM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 21, 2021 at 06:39:07AM -0400, Andrea Bolognani wrote:
> > On Tue, Jul 20, 2021 at 04:05:22PM +0100, Daniel P. Berrangé wrote:
> > > For macOS you always get the maximum configuration by default (12 CPUs,
> > > 24 GB
On Mon, Jul 19, 2021 at 14:36:59 +0200, Tim Wiederhake wrote:
> On Mon, 2021-07-19 at 14:08 +0200, Peter Krempa wrote:
> > On Mon, Jul 19, 2021 at 11:55:44 +0200, Tim Wiederhake wrote:
> > > "virHashNew" cannot return NULL, yet we check for NULL in various
> > > places.
> > >
> > > See
> > >
On 7/21/21 12:45 PM, Boris Fiuczynski wrote:
On 7/21/21 12:04 PM, Pavel Hrdina wrote:
On Fri, Jul 16, 2021 at 11:44:24AM +0200, Boris Fiuczynski wrote:
This patch series introduces the launch security type s390-pv.
Specifying s390-pv as launch security type in an s390 domain prepares
for
On Wed, Jul 21, 2021 at 06:39:07AM -0400, Andrea Bolognani wrote:
> On Tue, Jul 20, 2021 at 04:05:22PM +0100, Daniel P. Berrangé wrote:
> > For macOS you always get the maximum configuration by default (12 CPUs,
> > 24 GB RAM), but for FreeBSD you get 2 CPUs, 4 GBs by default. This
> > change
The submission of the event to the helper thread has a verbose cleanup
path which was duplicated in all the event handlers. Simplify it by
extracting the code into a helper named 'qemuProcessEventSubmit' and
reuse it where appropriate.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c |
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 12 ++--
src/qemu/qemu_process.c | 4 +---
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 8
src/qemu/qemu_process.c | 4 +---
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 8
src/qemu/qemu_process.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 14 +++---
src/qemu/qemu_process.c | 3 +--
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
On 7/21/21 12:04 PM, Pavel Hrdina wrote:
On Fri, Jul 16, 2021 at 11:44:24AM +0200, Boris Fiuczynski wrote:
This patch series introduces the launch security type s390-pv.
Specifying s390-pv as launch security type in an s390 domain prepares for
running the guest in protected virtualization
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 8
src/qemu/qemu_process.c | 4 ++--
src/qemu/qemu_processpriv.h | 8
3 files changed, 10 insertions(+), 10 deletions(-)
diff
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 6 +++---
src/qemu/qemu_process.c | 3 +--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
The removed error messages are impossible as the enum values are
converted via VIR_ENUM helpers and guarded by compiler checks.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 8
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 6 +++---
src/qemu/qemu_process.c | 3 +--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 10 +-
src/qemu/qemu_process.c | 13 -
2 files changed, 9 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 8
src/qemu/qemu_process.c | 3 +--
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 6 +++---
src/qemu/qemu_process.c | 4 +---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 12 ++--
src/qemu/qemu_process.c | 3 +--
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 8
src/qemu/qemu_process.c | 3 +--
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 26 +-
src/qemu/qemu_process.c | 4 +---
2 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 6 +++---
src/qemu/qemu_process.c | 3 +--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 16
src/qemu/qemu_process.c | 4 +---
2 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 6 +++---
src/qemu/qemu_process.c | 3 +--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 8
src/qemu/qemu_process.c | 3 +--
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 8
src/qemu/qemu_process.c | 4 +---
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 6 +++---
src/qemu/qemu_process.c | 5 +
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 6 +++---
src/qemu/qemu_process.c | 4 +---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
On Tue, Jul 20, 2021 at 04:05:22PM +0100, Daniel P. Berrangé wrote:
> For macOS you always get the maximum configuration by default (12 CPUs,
> 24 GB RAM), but for FreeBSD you get 2 CPUs, 4 GBs by default. This
> change increases the allocation to 8 CPUs, 8 GBs for FreeBSD.
>
> ---
> In theory
Change the callback prototype and fix the callback registered in the
process code.
It is also impossible for @info to be non-NULL in the cleanup section so
the cleanup can be completely removed.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 14 +++---
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 12 ++--
src/qemu/qemu_process.c | 3 +--
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 8
src/qemu/qemu_process.c | 3 +--
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 6 +++---
src/qemu/qemu_process.c | 4 +---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 10 +-
src/qemu/qemu_process.c | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 10 +-
src/qemu/qemu_process.c | 3 +--
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 14 +++---
src/qemu/qemu_process.c | 3 +--
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 14 +++---
src/qemu/qemu_process.c | 4 +---
2 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
Change the callback prototype and fix the callback registered in the
process code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.h | 8
src/qemu/qemu_process.c | 4 +---
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_monitor.h
The callers in the monitor code invoking the callbacks after events are
received don't actually check the return value from the callbacks and
there isn't really anything we could do on failure.
Remove the return value from the intermediary functions so we can later
remove them from the callback
The qemu process code doesn't register a callback for it so we don't
need to be handling it at all.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 11 ---
src/qemu/qemu_monitor.h | 5 -
src/qemu/qemu_monitor_json.c | 7 ---
3 files changed, 23 deletions(-)
Peter Krempa (33):
qemu: monitor: Remove handlers for the 'POWERDOWN' event
qemu: monitor: Remove return value from qemuMonitorEmit* functions
qemu: Remove return value from qemuMonitorDomainEventCallback
qemu: Remove return value from qemuMonitorDomainShutdownCallback
qemu: Remove
On Tue, Jul 20, 2021 at 07:00:20PM +0200, Olaf Hering wrote:
> sysconfig files are owned by the admin of the host. He has the liberty
> to put anything he wants into these files. This makes it difficult to
> provide different built-in defaults.
s/He has/They have/
s/he wants/they want/
> +++
On Fri, Jul 16, 2021 at 11:44:24AM +0200, Boris Fiuczynski wrote:
> This patch series introduces the launch security type s390-pv.
> Specifying s390-pv as launch security type in an s390 domain prepares for
> running the guest in protected virtualization secure mode, also known as
> IBM Secure
On Fri, Jul 16, 2021 at 11:44:28AM +0200, Boris Fiuczynski wrote:
> Adding virDomainSecDef for general launch security data
> and moving virDomainSEVDef as an element for SEV data.
>
> Signed-off-by: Boris Fiuczynski
> Reviewed-by: Daniel Henrique Barboza
> ---
> src/conf/domain_conf.c |
Adding libvirt-security since I forgot when sending the patch.
On Wed, Jul 21, 2021 at 11:27:41 +0200, Peter Krempa wrote:
> 'virStoragePoolObjListSearch' returns a locked and refed object, thus we
> must release it on ACL permission failure.
>
> Fixes: 7aa0e8c0cb8
> Resolves:
'virStoragePoolObjListSearch' returns a locked and refed object, thus we
must release it on ACL permission failure.
Fixes: 7aa0e8c0cb8
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1984318
Signed-off-by: Peter Krempa
---
Technically a security issue since it DoS-es the objects a user
I removed negation from the name of a variable to make the code
more readable.
Signed-off-by: Kristina Hanicova
---
tests/lxcxml2xmltest.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/lxcxml2xmltest.c b/tests/lxcxml2xmltest.c
index
Having negation in a name of a bool variable seems a bit
confusing to me. I think the substitution makes the code much
more readable.
Signed-off-by: Kristina Hanicova
---
diff to v1:
* I forgot to change inactive_only variable in struct testInfo
tests/genericxml2xmltest.c | 50
On Tue, Jul 20, 2021 at 18:19:54 +0200, Michal Privoznik wrote:
> When doing a peer-to-peer migration it may happen that the
> connection to the destination disappears. If that happens,
> there's no point in trying to unregister the close callback
> because the connection is closed already. It
91 matches
Mail list logo
