Re: [PATCH v2 0/4] Add support for two i386 pm options which control acpi hotplug

2021-08-31 Thread Ani Sinha
On Thu, 19 Aug 2021, Ani Sinha wrote: > Hi: > > I added some negative xml2argv tests as well as new xml2xml tests. In the > process, > I also fixed a bug where I had not added appropriate code to generate the > output > xml correctly. > The patch series is sent again as v2. Kindly, please

Re: [PATCH 3/8] ch_monitor: Update virCHMonitorGet to handle accept a response

2021-08-31 Thread Douglas, William
On Fri, 2021-08-27 at 17:30 +0100, Daniel P. Berrangé wrote: > On Thu, Aug 26, 2021 at 02:59:17PM -0700, William Douglas wrote: > > The virCHMonitorGet function needed to be able to return data from > > the > > hypervisor. This functionality is needed in order for the driver to > > support PTY

Re: [PATCH v3 0/2] hw/arm/raspi: Remove deprecated raspi2/raspi3 aliases

2021-08-31 Thread Peter Maydell
On Fri, 27 Aug 2021 at 07:08, Philippe Mathieu-Daudé wrote: > > Since v2: > - updated "Since 6.1" -> "Since 6.2" > > Peter reported CI failure [*] but I can't reproduce: > https://gitlab.com/philmd/qemu/-/pipelines/360227279 'make check' seems to work for me too this time... Applied to

RFC: revert to external snapshot API

2021-08-31 Thread Nikolay Shirokovskiy
Hi, all. I want to implement reverting to external snapshot functionality. I've checked the mailing list history and found some previous attempts (not sure if this is a complete list of them). [1] was done in 2012 by the Redhat team itself. [2] and [3] was done in 2018. Looks like it was not

Re: [libvirt PATCH] meson: avoid bogus warnings from clang and g_autoptr

2021-08-31 Thread Daniel P . Berrangé
On Tue, Aug 31, 2021 at 05:23:08PM +0200, Pavel Hrdina wrote: > On Tue, Aug 31, 2021 at 03:08:19PM +0100, Daniel P. Berrangé wrote: > > Clang has previously had trouble with G_DEFINE_AUTOPTR_CLEANUP_FUNC > > generated code, thinking it was unused. We turn off -Wunused-function > > to avoid

Re: [libvirt PATCH] meson: avoid bogus warnings from clang and g_autoptr

2021-08-31 Thread Pavel Hrdina
On Tue, Aug 31, 2021 at 03:08:19PM +0100, Daniel P. Berrangé wrote: > Clang has previously had trouble with G_DEFINE_AUTOPTR_CLEANUP_FUNC > generated code, thinking it was unused. We turn off -Wunused-function > to avoid tripping up on that with CLang. > > New CLang has started having trouble

Re: [libvirt PATCH] tests: virstoragetest: remove tests without backing type

2021-08-31 Thread Peter Krempa
On Tue, Aug 31, 2021 at 12:16:13 +0100, Daniel P. Berrangé wrote: > On Tue, Aug 31, 2021 at 12:03:06PM +0200, Ján Tomko wrote: > > As of qemu commit: > > > > commit 497a30dbb065937d67f6c43af6dd78492e1d6f6d > > qemu-img: Require -F with -b backing image > > > > creating images with backing

Re: [libvirt PATCH] news: add FC VMID entry

2021-08-31 Thread Andrea Bolognani
On Tue, Aug 31, 2021 at 02:53:57PM +0200, Pavel Hrdina wrote: > + * Add support for Fibre Channel VMID > + > +New VM element was added to allow users set *allow users to set Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

[libvirt PATCH] meson: avoid bogus warnings from clang and g_autoptr

2021-08-31 Thread Daniel P . Berrangé
Clang has previously had trouble with G_DEFINE_AUTOPTR_CLEANUP_FUNC generated code, thinking it was unused. We turn off -Wunused-function to avoid tripping up on that with CLang. New CLang has started having trouble with g_autoptr now too. In usage scenarios where the variable is set, but never

[PATCH 1/2] qemu: probe for virtio-blk-pci discard option support

2021-08-31 Thread yuxiating
Signed-off-by: yuxiating --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_4.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 +

[PATCH 2/2] qemu: support for virtio-blk-pci discard options

2021-08-31 Thread yuxiating
DISCARD and WRITE_ZEROES features for machine type >= 4.0 is enabled by default since commit 5c81161f804144b146607f890e84613a4cbad95c virtio-blk: add "discard" and "write-zeroes" properties Sometimes guestos has bugs DISCARD need to be disabled. Signed-off-by: yuxiating ---

[libvirt PATCH] news: add FC VMID entry

2021-08-31 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 200256c299..72b63a19ea 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,13 @@ v7.7.0 (unreleased) * **New features** + * Add support for Fibre Channel VMID + +

Re: [libvirt PATCH] qemu, xen: add missing deps on virtlockd/virtlogd sockets

2021-08-31 Thread Jiri Denemark
On Tue, Aug 31, 2021 at 12:04:14 +0100, Daniel P. Berrangé wrote: > The QEMU driver uses both virtlogd and virtlockd, while the Xen driver > uses virtlockd. The libvirtd.service unit contains deps on the socket > units for these services, but these deps were missed in the modular > daemons. As a

Re: [libvirt PATCH] rpm: fix typo in post transaction scriptlet name

2021-08-31 Thread Jiri Denemark
On Tue, Aug 31, 2021 at 12:03:33 +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index b01379d242..624b0e0302 100644 > --- a/libvirt.spec.in

Re: [libvirt PATCH] rpm: fix typo in post transaction scriptlet name

2021-08-31 Thread Pavel Hrdina
On Tue, Aug 31, 2021 at 12:03:33PM +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > libvirt.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Pavel Hrdina signature.asc Description: PGP signature

Re: [libvirt PATCH] tests: virstoragetest: remove tests without backing type

2021-08-31 Thread Daniel P . Berrangé
On Tue, Aug 31, 2021 at 12:03:06PM +0200, Ján Tomko wrote: > As of qemu commit: > > commit 497a30dbb065937d67f6c43af6dd78492e1d6f6d > qemu-img: Require -F with -b backing image > > creating images with backing images requires specifying the format. > > Remove tests which do not pass the

[libvirt PATCH] qemu, xen: add missing deps on virtlockd/virtlogd sockets

2021-08-31 Thread Daniel P . Berrangé
The QEMU driver uses both virtlogd and virtlockd, while the Xen driver uses virtlockd. The libvirtd.service unit contains deps on the socket units for these services, but these deps were missed in the modular daemons. As a result the virtlockd/virtlogd sockets are not started when the

[libvirt PATCH] rpm: fix typo in post transaction scriptlet name

2021-08-31 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b01379d242..624b0e0302 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1441,7 +1441,7 @@ fi %preun daemon-driver-secret

[PATCH 1/1] qemu: add virtio-blk queue-size option

2021-08-31 Thread Hiroki Narukawa
The option "queue-size" in virtio-blk was added in qemu-2.12.0, and default value increased from qemu-5.0.0. However, increasing this value may lead to drop of random access performance. This is configurable value, so we want to use it via libvirt. Signed-off-by: Hiroki Narukawa ---

[PATCH 0/1] qemu: add virtio-blk queue-size option

2021-08-31 Thread Hiroki Narukawa
Hello, The option "queue-size" in virtio-blk was added in qemu-2.12.0, and default value increased from qemu-5.0.0. However, increasing this value may lead to drop of random access performance. This is configurable value, so we want to use it via libvirt. Sorry, my previous e-mail had wrong CC

[PATCH 0/1] qemu: add virtio-blk queue-size option

2021-08-31 Thread Hiroki Narukawa
Hello, The option "queue-size" in virtio-blk was added in qemu-2.12.0, and default value increased from qemu-5.0.0. However, increasing this value may lead to drop of random access performance. This is configurable value, so we want to use it via libvirt. Could you review this patch? Hiroki

[libvirt PATCH] tests: virstoragetest: remove tests without backing type

2021-08-31 Thread Ján Tomko
As of qemu commit: commit 497a30dbb065937d67f6c43af6dd78492e1d6f6d qemu-img: Require -F with -b backing image creating images with backing images requires specifying the format. Remove tests which do not pass the backing format on the command line. Signed-off-by: Ján Tomko ---

[PATCH 1/1] qemu: add virtio-blk queue-size option

2021-08-31 Thread Hiroki Narukawa
The option "queue-size" in virtio-blk was added in qemu-2.12.0, and default value increased from qemu-5.0.0. However, increasing this value may lead to drop of random access performance. This is configurable value, so we want to use it via libvirt. Signed-off-by: Hiroki Narukawa ---

Re: [PATCH v2 2/2] qemuValidateDomainDeviceDefDiskTransient: Add checking set-action capability

2021-08-31 Thread Peter Krempa
On Mon, Aug 30, 2021 at 00:30:43 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > option requires set-action capability > if destroy action is set to all of the events configuration. > > Signed-off-by: Masayoshi Mizuma > --- > src/qemu/qemu_validate.c | 13 - > 1 file

Re: [PATCH v2 1/2] qemu: process: Split out the statement to handle the qemu is allowed to reboot

2021-08-31 Thread Peter Krempa
On Mon, Aug 30, 2021 at 00:30:42 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > Split out the statement to handle whether the qemu is allowed to reboot > or not. So that it gets available for the later patch. > > Signed-off-by: Masayoshi Mizuma > --- > src/qemu/qemu_process.c |

Re: [PATCH] qemuProcessSetupDisksTransientHotplug: Add checking set-action capability

2021-08-31 Thread Peter Krempa
On Wed, Aug 25, 2021 at 19:08:46 -0400, Masayoshi Mizuma wrote: > From: Masayoshi Mizuma > > The VM is terminated abnormally when > is set to the disk option and the qemu doesn't have set-action capability. > > # virsh start guest01 > error: Failed to start domain 'guest01' > error: