On 10/5/21 1:51 AM, Ani Sinha wrote:
This change introduces a new libvirt sub-element under that
can be used to configure all pci related features.
Currently the only sub-sub element supported by this sub-element is
'acpi-bridge-hotplug' as shown below:
The above option is
On 10/5/21 1:51 AM, Ani Sinha wrote:
Added the following new libvirt conf option to the release note to indicate
their availability with the next release:
Signed-off-by: Ani Sinha
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
On 10/5/21 1:51 AM, Ani Sinha wrote:
This change adds backend qemu command line support for new libvirt global
feature 'acpi-bridge-hotplug'. This option can be used as following:
The '' sub-element under '' is also newly introduced.
'acpi-bridge-hotplug' turns on the
On 10/7/21 11:12 PM, Laine Stump wrote:
@@ -27932,6 +27995,30 @@ virDomainDefFormatFeatures(virBuffer *buf,
virDomainIBSTypeToString(def->features[i]));
break;
+ case VIR_DOMAIN_FEATURE_PCI:
+ if (def->features[i] !=
On 10/5/21 1:51 AM, Ani Sinha wrote:
This change introduces a new libvirt sub-element under that
can be used to configure all pci related features.
Currently the only sub-sub element supported by this sub-element is
'acpi-bridge-hotplug' as shown below:
I guess this is as
On 10/5/21 1:51 AM, Ani Sinha wrote:
qemu added support for i440fx specific global boolean flag
PIIX4_PM.acpi-pci-hotplug-with-bridge-support
around version 2.1. This flag is enabled by default. When disabled, it turns
off acpi pci hotplug for cold plugged pci bridges in i440fx machine types.
On 10/7/21 09:08, Cole Robinson wrote:
With cgroup v1 I'm seeing LXC container startup failures:
$ sudo virt-install --connect lxc:/// --name test-container --memory 128
--boot init=/bin/sh
Starting install...
ERRORerror from service:
GDBus.Error:org.freedesktop.machine1.NoMachineForPID:
Also just for the statistics , it's been almost 2 months now since the
effort on the two patches started.
On Fri, Oct 8, 2021 at 4:46 AM Ani Sinha wrote:
> Other than laine doesn't anyone have any feedback on this patch set?
> Timely reviews help contributions. It's difficult to sit on a patch
Other than laine doesn't anyone have any feedback on this patch set? Timely
reviews help contributions. It's difficult to sit on a patch set and keep
rebasing for ever.
On Tue, Oct 5, 2021 at 11:21 AM Ani Sinha wrote:
> changelog:
>
> v6: rebased to latest. capabilities have been renamed as per
Signed-off-by: Wei-Chen Chen
Signed-off-by: Praveen K Paladugu
---
po/POTFILES.in| 1 +
tools/meson.build | 5 +++
tools/virt-host-validate-ch.c | 85 +++
tools/virt-host-validate-ch.h | 24 ++
tools/virt-host-validate.c|
rbd encryption is new in qemu 6.1.0.
This commit adds capability probing for it.
Signed-off-by: Or Ozeri
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 +
3 files changed,
On a Thursday in 2021, Peter Krempa wrote:
Convert one of the tests to a different device.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/watchdog-device.x86_64-latest.args | 2 +-
tests/qemuxml2argvdata/watchdog-device.xml| 2 +-
2 files changed, 2 insertions(+), 2
On a Thursday in 2021, Ioanna Alifieraki wrote:
Create a corrupt profile and expect to be removed after the test is run.
Signed-off-by: Ioanna Alifieraki
---
tests/meson.build | 1 +
tests/virt-aa-helper-test | 29 +
2 files changed, 30 insertions(+)
On a Thursday in 2021, Ioanna Alifieraki wrote:
This commit aims to address the bug reported in [1] and [2].
If the profile is corrupted (0-size) the VM cannot be launched.
To overcome this check if the profile exists and if it has 0 size
remove it and create it again.
[1]
On a Thursday in 2021, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
...e.args => panic-double.x86_64-latest.args} | 16
tests/qemuxml2argvdata/panic-no-address.args | 33 -
.../panic-no-address.x86_64-latest.args | 37 +++
On a Thursday in 2021, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/watchdog-device.args | 34 -
.../watchdog-device.x86_64-latest.args| 38 +++
tests/qemuxml2argvdata/watchdog-dump.args | 34 -
v4:
- added disk post parse to image creation flow in qemublocktest (since more
tests failed after adding engine validation)
- removed symlink changes
- added luks2 and engine documentation
- switched to using enum engine instead of int
- added validation for encryption engine and formats
This commit extends libvirt XML configuration to support luks2 encryption
format.
This means that becomes valid.
Currently librbd is the only engine that supports this new format.
Signed-off-by: Or Ozeri
---
docs/formatstorageencryption.html.in | 12 +++-
rbd encryption is new in qemu 6.1.0.
This commit adds a new encryption engine property which
allows the user to use this new encryption engine.
Signed-off-by: Or Ozeri
---
docs/formatstorageencryption.html.in | 7 +-
docs/schemas/storagecommon.rng| 1 +
This commit extends libvirt XML configuration to support a custom encryption
engine.
This means that becomes valid.
The only engine for now is qemu. However, a new engine (librbd) will be added
in an upcoming commit.
If no engine is specified, qemu will be used (assuming qemu driver is used).
The post parse callback is part of the real (non-test) processing flow.
This commit adds it (for disks) to the qemublocktest flow as well.
Specifically, this will be needed for tests that use luks encryption,
so that the default encryption engine (which is added in an upcoming commit)
will be
On a Thursday in 2021, Peter Krempa wrote:
Move the validation from 'qemuBuildRomStr' into the function which
validates device info. It was originally named
'qemuValidateDomainDeviceDefAddress' but this commit renames it to
'qemuValidateDomainDeviceDefInfo'.
Signed-off-by: Peter Krempa
---
On a Thursday in 2021, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_validate.c | 72 ++--
1 file changed, 24 insertions(+), 48 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Thursday in 2021, Peter Krempa wrote:
Rename it to 'qemuProcessPrepareDeviceBootorder' and call it from
'qemuProcessPrepareDomain' rather than
'qemuProcessPrepareDomainStorage'.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 6 +++---
1 file changed, 3 insertions(+), 3
On a Thursday in 2021, Peter Krempa wrote:
'effectiveBootIndex' is a copy of 'bootIndex' if
On a Thursday in 2021, Peter Krempa wrote:
Merge the code from qemuBuildVirtioOptionsStr so that we don't have to
call two separate functions.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 39 ++-
.../vhost-vsock-ccw-iommu.s390x-latest.args |
On a Thursday in 2021, Peter Krempa wrote:
'virtio-vga' is a virtio device but we didn't use the virtio formatter
for it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description:
On a Thursday in 2021, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 2 +-
src/conf/domain_conf.h | 2 +-
src/qemu/qemu_validate.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Thursday in 2021, Peter Krempa wrote:
Commit ffda44030a2 added validation of the 'acpiIndex' field in
virDomainDeviceInfo by calling 'virDomainDeviceInfoIterate' from
'qemuValidateDomainDef'. This is overly complicated we have
'qemuValidateDomainDeviceDef' which is already called for every
On a Thursday in 2021, Peter Krempa wrote:
Remove the nw unused boot-index related attributes and the code which is
*now
assigning it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 71 -
src/qemu/qemu_command.h | 2 --
On a Thursday in 2021, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 27 ---
1 file changed, 27 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Thursday in 2021, Peter Krempa wrote:
The code doesn't need the name as it determines it internally. Remove
the argument and fix all callers. In certain cases it lead to
s/lead/led/
Lead and lead compounds can cause cancer, reproductive harm or birth
defects in the state of California.
On a Thursday in 2021, Peter Krempa wrote:
Fill in the effective boot index for network devices (or hostdev-backed
network devices via 'qemuProcessPrepareDeviceBootorder'. This patch
doesn't clean up the cruft to make it more obvious what's happening.
Signed-off-by: Peter Krempa
---
On a Thursday in 2021, Peter Krempa wrote:
Since we already have code for per-device behaviour we can also populate
the device name and extract virtioOptions in the switch statement so
that callers don't have to pass it in.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 107
On a Thursday in 2021, Peter Krempa wrote:
Add the bus suffix in a separate call. This will make it more obvious
what's happening in the next commit.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Ján Tomko
On a Thursday in 2021, Peter Krempa wrote:
The function is static and will be needed in the virtio device config
helper.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 248
1 file changed, 124 insertions(+), 124 deletions(-)
Reviewed-by:
On a Thursday in 2021, Peter Krempa wrote:
The 'virito' argument was misleadingly implying that it's true for all
*virtio
virtio devices, but that's not the case. 'virtio-vga(-gl)' is a virtio
device but doesn't accept the usual bus-dependant suffix.
Add a comment for
On a Thursday in 2021, Peter Krempa wrote:
Split out the function a bit more to separate the per-device code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 151 +---
1 file changed, 80 insertions(+), 71 deletions(-)
Reviewed-by: Ján Tomko
On a Thursday in 2021, Peter Krempa wrote:
Split up the bus lookup into a function called
'qemuBuildDeviceAddressPCIGetBus'.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 48 +
1 file changed, 30 insertions(+), 18 deletions(-)
Reviewed-by:
On a Thursday in 2021, Peter Krempa wrote:
To simplify upcoming refactors change the logic such that we don't
return early for device types which can't be transitional.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 90 -
1 file changed, 45
s/St/Str/ in the commit summary
On a Thursday in 2021, Peter Krempa wrote:
The PCI address case grew massive over time. Split it out into a new
function qemuBuildDeviceAddressPCIStr.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 147 ++--
1 file
On a Thursday in 2021, Peter Krempa wrote:
Extract the code into 'qemuBuildVirtioDevGetConfig' so that we can
later reuse it when converting individual device code into the more
modern JSON approach as the extracted code will be necessary either way.
Signed-off-by: Peter Krempa
---
On a Thursday in 2021, Peter Krempa wrote:
Per coding guidelines error messages should not be broken into lines and
variables should be separated by apostrophes.
https://libvirt.org/coding-style.html#error-message-format
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 8 ++--
This patch-series aims to address the bug reported in [1] and [2].
Bug description :
Some times libvirt fails to start a vm with the following error :
libvirt: error : unable to set AppArmor profile
'libvirt-b05b297f-952f-42d6-b04e-f9a13767db54' for '/usr/bin/kvm-spice': No
such file or
Reorganise create and remove functionality into functions for later
reuse in calls from multiple places.
Signed-off-by: Ioanna Alifieraki
---
src/security/virt-aa-helper.c | 55 ++-
1 file changed, 35 insertions(+), 20 deletions(-)
diff --git
On a Thursday in 2021, Peter Krempa wrote:
Mention the QMP command 'device_add' rather than 'qemuMonitorAddDevice'
and remove the weird formatting.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_block.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Ján Tomko
Jano
Create a corrupt profile and expect to be removed after the test is run.
Signed-off-by: Ioanna Alifieraki
---
tests/meson.build | 1 +
tests/virt-aa-helper-test | 29 +
2 files changed, 30 insertions(+)
diff --git a/tests/meson.build b/tests/meson.build
Currently there is no way to remove the profile file.
This commit provides this functionality (required for next commit).
Signed-off-by: Ioanna Alifieraki
---
src/security/virt-aa-helper.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git
This commit aims to address the bug reported in [1] and [2].
If the profile is corrupted (0-size) the VM cannot be launched.
To overcome this check if the profile exists and if it has 0 size
remove it and create it again.
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890084
[2]
On a Thursday in 2021, Peter Krempa wrote:
Use automatic memory freeing and remove 'ret' variable and 'cleanup'
label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
Reviewed-by: Ján Tomko
Jano
On a Thursday in 2021, Peter Krempa wrote:
Report the error from 'qemuValidateDomainWatchdogDef' rather than
'qemuBuildWatchdogDevStr'.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 10 +++---
src/qemu/qemu_validate.c | 4 +++-
2 files changed, 6 insertions(+), 8 deletions(-)
On a Thursday in 2021, Peter Krempa wrote:
For conversion of '-device' we'll try to avoid usage of arrays if
possible, so for now if the array coversion function is not provided the
convertor will error out.
Signed-off-by: Peter Krempa
---
src/util/virqemu.c | 8 +++-
1 file changed, 7
On a Thursday in 2021, Peter Krempa wrote:
Use g_autoptr for 'vcpuprops' and remove the 'cleanup' label and 'ret'
varlaible which is no longer needed.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
On a Thursday in 2021, Peter Krempa wrote:
We commonly use 'props' for the JSON object describing something. Rename
the monitor device addition code.
Additionally the common approach is to clear the pointer if it was
consumed so the arguments are adjusted to do so.
Signed-off-by: Peter Krempa
On a Thursday in 2021, Peter Krempa wrote:
With automatic memory freeing we can simplify the function to avoid two
almost-identical calls to virQEMUBuildCommandLineJSONRecurse.
Signed-off-by: Peter Krempa
---
src/util/virqemu.c | 18 ++
1 file changed, 6 insertions(+), 12
On a Thursday in 2021, Peter Krempa wrote:
Optimize the number of string copies by using the virBuffers in the
callers directly. Simplest way to achieve this is to just open code the
one function call 'virQEMUBuildDriveCommandlineFromJSON' was wrapping
in the two callers.
Signed-off-by: Peter
On a Thursday in 2021, Peter Krempa wrote:
The returned argument list is a NULL-terminated string list and the only
caller doesn't use the count. Remove the argument.
Signed-off-by: Peter Krempa
---
src/util/vircommand.c| 4 +---
src/util/vircommand.h| 2 +-
tests/qemuxml2argvtest.c | 3
On a Thursday in 2021, Peter Krempa wrote:
The same test in regards to the 'panic' device is the 'panic-double'
case, thus panic-isa can be removed.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/panic-isa.xml | 33
tests/qemuxml2xmltest.c | 1
On a Thursday in 2021, Peter Krempa wrote:
All callers basically end up dumping the buffer into a string and then
adding '-object' 'props' arguments to virCommand. Simplify all callers
by doing this in the function itself.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 119
On a Thursday in 2021, Peter Krempa wrote:
Input devices of VIR_DOMAIN_INPUT_TYPE_EVDEV type are instantiated via
an '-object' rather than a '-device'. Mixing them in one function is a
bad idea as the caller then needs to use the string correctly which is
not the case in
On a Thursday in 2021, Peter Krempa wrote:
Rename the function to 'qemuBuildMemoryCellBackendProps' and return the
properties before conversion to commandline arguments. This requires
changes in the caller.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 39
On a Thursday in 2021, Peter Krempa wrote:
In many cases we use a signed value, but use the sign to note that it
was not assigned. For converting to JSON objects it will be handy to
have possibility to do this automatically.
Signed-off-by: Peter Krempa
---
src/util/virjson.c | 7 ++-
1 file
Move the validation code into a separate function. For now the
validation is still kept in the commandline format step as simply just
moving it to the validator causes failures in the test suite, which will
need to be investigated deeper.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c
virtio-net-pci specific properties and their types according to QEMU:
tx=
ioeventfd= - on/off (default: true)
event_idx= - on/off (default: true)
csum=- on/off (default: true)
gso= - on/off (default: true)
host_tso4= - on/off (default: true)
The 'vhost-user-fs-pci' has following properties we control:
chardev= - ID of a chardev to use as a backend
queue-size=- (default: 128)
tag=
bootindex=
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 43 -
Move the code into a new function called qemuBuildControllerPCIDevStr
so that the code is self contained and the original function easier to
follow.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 157 ++--
1 file changed, 87 insertions(+), 70
All users were converted to the JSON counterpart.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 99 +
1 file changed, 1 insertion(+), 98 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 53f38ff306..bfba69a974
Simplify the generator by moving few properties earlier.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 8 ++--
.../hostdev-mdev-display-ramfb.x86_64-latest.args | 2 +-
.../hostdev-subsys-mdev-vfio-ccw-boot.s390x-latest.args | 2 +-
3
Now that all users were converted to qemuBuildRomProps we can remove the
old code and un-mark qemuBuildRomProps as unused.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 34 +-
1 file changed, 1 insertion(+), 33 deletions(-)
diff --git
The 'usb-hub' device doesn't have any special properties.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
It's not used since last commit.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 -
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml |
Internally format the SCSI controller properties into JSON, but convert
it back to a string so that we for now change just the SCSI controller.
The change in tests is expected as the 'reg' field for a spapr-vio
address is expected to be a number:
$ qemu-system-ppc64 -device spapr-vscsi,help
Simplify the generator by shuffling around few fields.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c| 10 +++---
.../hostdev-scsi-lsi.x86_64-4.1.0.args | 12 ++--
.../hostdev-scsi-lsi.x86_64-latest.args| 12 ++--
The 'virtio-rng' has the following property types according to QEMU:
rng=>
max-bytes= - (default: 9223372036854775807)
period=- (default: 65536)
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 46 +++--
src/qemu/qemu_command.h |
Move the 'deflate-on-oom' and 'free-page-reporting' before the address
to simplify the genrator code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 8 ++--
tests/qemuxml2argvdata/balloon-ccw-deflate.args | 2 +-
Generate the 'zpci' device via JSON.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 81 +++--
src/qemu/qemu_command.h | 3 +-
src/qemu/qemu_hotplug.c | 27 +-
3 files changed, 49 insertions(+), 62 deletions(-)
diff --git
The watchdog doesn't have any special properties.
Convert the command line generator and hotplug code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 31 +++
src/qemu/qemu_command.h | 6 +++---
src/qemu/qemu_hotplug.c | 6 +++---
3 files changed, 21
Add a JSON variant of the generator of properties for virtio devices.
For convenience both the old and new are for now marked as unused, which
will be removed once the conversion is complete.
The formatted properties have following types according to QEMU.
'virtio-blk-pci' was used as an example:
On a Thursday in 2021, Peter Krempa wrote:
Enforce that the ':' separator between the key and value is always
present.
Signed-off-by: Peter Krempa
---
src/util/virjson.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP
'virtio-vga' is a virtio device but we didn't use the virtio formatter
for it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index daaccff9b6..dc3320ba9a 100644
---
Add the bus suffix in a separate call. This will make it more obvious
what's happening in the next commit.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
Move the bootindex before the address so that the code is simpler.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 6 +-
tests/qemuxml2argvdata/aarch64-video-virtio-gpu-pci.args| 2 +-
tests/qemuxml2argvdata/boot-complex.args
Build the properties of 'vhost-scsi' device via JSON. In comparison to
previous similar refactors this also modifies the hotplug code to attach
the vhost fd handle explicitly rather than using
'qemuMonitorAddDeviceWithFd'.
The 'vhost-scsi' device doesn't have any special (non-string) properties.
Format a JSON object with the device properties and then use
qemuBuildDeviceCommandlineFromJSON to convert it to the standard
commandline for now.
The 'ioport' property of 'pvpanic' is a number in QEMU:
ioport=- (default: 1285)
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c
All virtio devices were converted to the new JSON formatter so we can
remove the old one.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 65 +
1 file changed, 1 insertion(+), 64 deletions(-)
diff --git a/src/qemu/qemu_command.c
Introduce infrastructure to format 'drive' addresses via the standard
helper rather than hand-rolled generators used inline.
The code needs to know the disk bus to format the correct address which
is passed in via an internal field in virDomainDeviceDriveAddress.
The field types according to
This includes the 'pc-dimm', 'nvdimm', 'virtio-pmem-pci' and
'virtio-mem-pci' devices.
The value types according to QEMU are:
'pc-dimm'
node= - (default: 0)
memdev=>
'nvdimm'
label-size=
memdev=>
node= - (default: 0)
unarmed= - (default: false)
uuid=
The codec devices have the following properties we control:
cad= - (default: 4294967295)
audiodev= - ID of an audiodev to use as a backend
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 64 ++---
1 file changed, 28
Build the properties of 'vhost-vsock' device via JSON. In comparison to
previous similar refactors this also modifies the hotplug code to attach
the vhost fd handle explicitly rather than using
'qemuMonitorAddDeviceWithFd'.
The properties of vhost-vsock have the following types according to
QEMU:
The sound devices have only the 'audiodev' property which is a string.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 40 +++-
1 file changed, 23 insertions(+), 17 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 27 ---
1 file changed, 27 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 60404b6dd8..daaccff9b6 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1042,13
Use automatic memory freeing and remove 'ret' variable and 'cleanup'
label.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor_json.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index
Use g_autoptr for 'vcpuprops' and remove the 'cleanup' label and 'ret'
varlaible which is no longer needed.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_hotplug.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c
The handlers for PCI, SCSI and USB controllers already use JSON
internally. This patch converts 'virtio-serial', 'ccid' and 'sata' to do
the same and passes out the JSON directly so that it can be used in
monitor code to avoid conversion.
>From the controllers converted in this patch only
Internally format the PCI controller properties into JSON, but convert
it back to a string as preparation for upcoming refactors.
The following types are declared for the properties we use by QEMU:
'nec-usb-xhci'
p2=- (default: 4)
p3=- (default: 4)
'ich9-usb-uhci6'
The 'vfio-pci-nohotplug' device has the following property types
according to QEMU:
display=- on/off/auto (default: "off")
sysfsdev=
ramfb=
bootindex=
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 48 ++---
src/qemu/qemu_command.h |
Remove the nw unused boot-index related attributes and the code which is
assigning it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 71 -
src/qemu/qemu_command.h | 2 --
src/qemu/qemu_hotplug.c | 5 ++-
3 files changed, 16 insertions(+), 62
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c| 6 +-
tests/qemuxml2argvdata/net-virtio-teaming-hostdev.args | 4 ++--
tests/qemuxml2argvdata/net-virtio-teaming.args | 4 ++--
3 files changed, 5 insertions(+), 9 deletions(-)
diff --git
Move the code from 'qemuValidateDomainDeviceDefDiskFrontend' into
'qemuValidateDomainDeviceDefAddressDrive' which is called from
'qemuValidateDomainDeviceDefAddress' so that we have all address
validation code together.
This also allows us to remove the inline validation inside
Base the validation on presence of JSON as we do with other validated
commands. This will prepare the code for a refactor so that it's the
same for all validated commands.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvtest.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff
1 - 100 of 197 matches
Mail list logo
