Re: [PATCH 1/1] bridge_driver: use ovs-vsctl to setup and clean Qos when

2021-11-08 Thread Laine Stump
On 11/8/21 5:18 AM, Michal Prívozník wrote: On 11/3/21 4:11 AM, jx8zjs wrote: From: zhangjl02 Fix bug 1826168: bridge type network with ovs bridge can start with Qos setting which do not take any effect Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=1826168 Signed-off-by: zhangjl02

Re: [PATCH] qemu: tpm: Initialize variable with NULL

2021-11-08 Thread Michal Prívozník
On 11/8/21 3:50 PM, Stefan Berger wrote: > > On 11/8/21 09:40, Ján Tomko wrote: >> On a Monday in 2021, Marc-André Lureau wrote: >>> On Mon, Nov 8, 2021 at 5:53 PM Stefan Berger >>> wrote: Initialize an autofree'd variable with NULL that causes crashes if a TPM 1.2 is used and the

Re: [PATCH] qemu: tpm: Initialize variable with NULL

2021-11-08 Thread Stefan Berger
On 11/8/21 09:40, Ján Tomko wrote: On a Monday in 2021, Marc-André Lureau wrote: On Mon, Nov 8, 2021 at 5:53 PM Stefan Berger wrote: Initialize an autofree'd variable with NULL that causes crashes if a TPM 1.2 is used and the variable doesn't get a value assigned. Signed-off-by: Stefan

Re: [PATCH] qemu: tpm: Initialize variable with NULL

2021-11-08 Thread Ján Tomko
On a Monday in 2021, Marc-André Lureau wrote: On Mon, Nov 8, 2021 at 5:53 PM Stefan Berger wrote: Initialize an autofree'd variable with NULL that causes crashes if a TPM 1.2 is used and the variable doesn't get a value assigned. Signed-off-by: Stefan Berger certainly, I wished there

Re: [PATCH] qemu: tpm: Initialize variable with NULL

2021-11-08 Thread Daniel P . Berrangé
On Mon, Nov 08, 2021 at 06:06:50PM +0400, Marc-André Lureau wrote: > On Mon, Nov 8, 2021 at 5:53 PM Stefan Berger wrote: > > > > Initialize an autofree'd variable with NULL that causes crashes > > if a TPM 1.2 is used and the variable doesn't get a value assigned. > > > > Signed-off-by: Stefan

Re: [PATCH] qemu: tpm: Initialize variable with NULL

2021-11-08 Thread Marc-André Lureau
On Mon, Nov 8, 2021 at 5:53 PM Stefan Berger wrote: > > Initialize an autofree'd variable with NULL that causes crashes > if a TPM 1.2 is used and the variable doesn't get a value assigned. > > Signed-off-by: Stefan Berger certainly, I wished there would be a gcc error there.. Reviewed-by:

[PATCH] qemu: tpm: Initialize variable with NULL

2021-11-08 Thread Stefan Berger
Initialize an autofree'd variable with NULL that causes crashes if a TPM 1.2 is used and the variable doesn't get a value assigned. Signed-off-by: Stefan Berger --- src/qemu/qemu_tpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c

Re: [libvirt PATCH 04/10] virNetworkEventDispatchDefaultFunc: Cleanup

2021-11-08 Thread Michal Prívozník
On 11/8/21 1:17 PM, Tim Wiederhake wrote: > Remove unnecessary label and goto. > > Signed-off-by: Tim Wiederhake > --- > src/conf/network_event.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/src/conf/network_event.c b/src/conf/network_event.c > index

Re: [libvirt PATCH 00/10] Cleanup some cleanup / error paths

2021-11-08 Thread Michal Prívozník
On 11/8/21 1:17 PM, Tim Wiederhake wrote: > > > Tim Wiederhake (10): > adminConnectListServers: Cleanup > virCHDomainObjBeginJob: Cleanup > virDomainCapsCPUModelsCopy: Cleanup > virNetworkEventDispatchDefaultFunc: Cleanup > virSaveCookieParse: Cleanup > virBufferAddBuffer: Cleanup >

Re: [libvirt PATCHv2 5/7] tests: convert name-escape to use real caps

2021-11-08 Thread Tim Wiederhake
On Wed, 2021-11-03 at 11:53 +0100, Ján Tomko wrote: > For later QEMUs than 2.11 we do FD passing for character devices, > so lock the capabilites to this exact version. > > Signed-off-by: Ján Tomko Reviewed-by: Tim Wiederhake > --- >  ...-escape.args => name-escape.x86_64-2.11.0.args} |  7

Re: [PATCH] docs/about/deprecated: Remove empty 'related binaries' section

2021-11-08 Thread Joaquin de Andres
On 11/5/21 15:26, Philippe Mathieu-Daudé wrote: Commit 497a30dbb06 ("qemu-img: Require -F with -b backing image") removed the content of the "Related binaries" section but forgot to remove the section title. Since it is now empty, remove it too. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH] bridge_driver: Drop needless fwd declarations

2021-11-08 Thread Martin Kletzander
On Mon, Nov 08, 2021 at 11:47:27AM +0100, Michal Privoznik wrote: Some forward declarations in bridge_driver.c are not needed really. They only create a noise when trying to jump onto the correct tag. Drop them. Signed-off-by: Michal Privoznik Reviewed-by: Martin Kletzander ---

Re: [PATCH] bridge_driver: Drop needless fwd declarations

2021-11-08 Thread Tim Wiederhake
On Mon, 2021-11-08 at 11:47 +0100, Michal Privoznik wrote: > Some forward declarations in bridge_driver.c are not needed > really. They only create a noise when trying to jump onto the > correct tag. Drop them. > > Signed-off-by: Michal Privoznik Reviewed-by: Tim Wiederhake > --- >  

[libvirt PATCH 09/10] testLXCCapsInit: Cleanup

2021-11-08 Thread Tim Wiederhake
Remove unnecessary label and goto. Cleanup line breaks. Signed-off-by: Tim Wiederhake --- tests/testutilslxc.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/tests/testutilslxc.c b/tests/testutilslxc.c index 857407dfb2..ac7a01a4e8 100644 ---

[libvirt PATCH 10/10] testVshTableHeader: Cleanup

2021-11-08 Thread Tim Wiederhake
Remove unnecessary label and goto. This also fixes a bug where a failure to create the table would result in the test passing. Signed-off-by: Tim Wiederhake --- tests/vshtabletest.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tests/vshtabletest.c

[libvirt PATCH 08/10] fillXenCaps: Cleanup

2021-11-08 Thread Tim Wiederhake
Rework to remove unnecessary label and goto. Signed-off-by: Tim Wiederhake --- tests/domaincapstest.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index 9ea5bed5c2..4a46acb9ad 100644 ---

[libvirt PATCH 07/10] virSCSIVHostOpenVhostSCSI: Cleanup

2021-11-08 Thread Tim Wiederhake
Remove unnecessary label, goto, and closing of not-open file descriptor. Signed-off-by: Tim Wiederhake --- src/util/virscsivhost.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/util/virscsivhost.c b/src/util/virscsivhost.c index afbfddb0fb..487301ab64 100644 ---

[libvirt PATCH 06/10] virBufferAddBuffer: Cleanup

2021-11-08 Thread Tim Wiederhake
Remove unnecessary label and goto. Signed-off-by: Tim Wiederhake --- src/util/virbuffer.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c index 8f9cd57e06..a4834174a1 100644 --- a/src/util/virbuffer.c +++

[libvirt PATCH 05/10] virSaveCookieParse: Cleanup

2021-11-08 Thread Tim Wiederhake
Remove unnecessary label and goto. Signed-off-by: Tim Wiederhake --- src/conf/virsavecookie.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/conf/virsavecookie.c b/src/conf/virsavecookie.c index 6cb7fafb1f..c24a292355 100644 --- a/src/conf/virsavecookie.c +++

[libvirt PATCH 03/10] virDomainCapsCPUModelsCopy: Cleanup

2021-11-08 Thread Tim Wiederhake
Remove unnecessary label and goto. Signed-off-by: Tim Wiederhake --- src/conf/domain_capabilities.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index 22f0963326..1766129092 100644 ---

[libvirt PATCH 04/10] virNetworkEventDispatchDefaultFunc: Cleanup

2021-11-08 Thread Tim Wiederhake
Remove unnecessary label and goto. Signed-off-by: Tim Wiederhake --- src/conf/network_event.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/conf/network_event.c b/src/conf/network_event.c index a47bf4dd3e..6335cbf711 100644 --- a/src/conf/network_event.c +++

[libvirt PATCH 01/10] adminConnectListServers: Cleanup

2021-11-08 Thread Tim Wiederhake
Remove unnecessary label and goto. Signed-off-by: Tim Wiederhake --- src/admin/admin_server.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/admin/admin_server.c b/src/admin/admin_server.c index 623c682b2d..6731a366cf 100644 --- a/src/admin/admin_server.c +++

[libvirt PATCH 00/10] Cleanup some cleanup / error paths

2021-11-08 Thread Tim Wiederhake
Tim Wiederhake (10): adminConnectListServers: Cleanup virCHDomainObjBeginJob: Cleanup virDomainCapsCPUModelsCopy: Cleanup virNetworkEventDispatchDefaultFunc: Cleanup virSaveCookieParse: Cleanup virBufferAddBuffer: Cleanup virSCSIVHostOpenVhostSCSI: Cleanup fillXenCaps: Cleanup

[libvirt PATCH 02/10] virCHDomainObjBeginJob: Cleanup

2021-11-08 Thread Tim Wiederhake
Remove unnecessary label and goto. Signed-off-by: Tim Wiederhake --- src/ch/ch_domain.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/src/ch/ch_domain.c b/src/ch/ch_domain.c index 9d32d8669a..dd4de9e1ea 100644 --- a/src/ch/ch_domain.c

Re: [PATCH v2 1/2] tests/acceptance: introduce new check-avocado tartget

2021-11-08 Thread Willian Rampazzo
On Mon, Nov 8, 2021 at 6:49 AM Philippe Mathieu-Daudé wrote: > > On 11/8/21 10:24, Daniel P. Berrangé wrote: > > On Mon, Nov 08, 2021 at 08:59:51AM +0100, Thomas Huth wrote: > >> On 05/11/2021 16.53, Willian Rampazzo wrote: > >>> This introduces a new `make` target, `check-avocado`, and adds a >

[PATCH] bridge_driver: Drop needless fwd declarations

2021-11-08 Thread Michal Privoznik
Some forward declarations in bridge_driver.c are not needed really. They only create a noise when trying to jump onto the correct tag. Drop them. Signed-off-by: Michal Privoznik --- src/network/bridge_driver.c | 14 -- 1 file changed, 14 deletions(-) diff --git

Re: [PATCH 1/1] bridge_driver: use ovs-vsctl to setup and clean Qos when

2021-11-08 Thread Michal Prívozník
On 11/3/21 4:11 AM, jx8zjs wrote: > From: zhangjl02 > > Fix bug 1826168: bridge type network with ovs bridge can start with Qos > setting which do not take any effect > > Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=1826168 > Signed-off-by: zhangjl02 > --- >

Re: [PATCH v2 0/4] Introduce TCG domain features

2021-11-08 Thread Kashyap Chamarthy
On Fri, Nov 05, 2021 at 10:35:16AM +0100, Michal Privoznik wrote: > v2 of: > > https://listman.redhat.com/archives/libvir-list/2021-November/msg00143.html > > diff to v1: > - Patches 1/4 and 2/4 are new, per Dan's suggestion > - Patch 4/4 was reworked, since after 2/4 we are using -accel >

Re: [PATCH v2 1/2] tests/acceptance: introduce new check-avocado tartget

2021-11-08 Thread Philippe Mathieu-Daudé
On 11/8/21 10:24, Daniel P. Berrangé wrote: > On Mon, Nov 08, 2021 at 08:59:51AM +0100, Thomas Huth wrote: >> On 05/11/2021 16.53, Willian Rampazzo wrote: >>> This introduces a new `make` target, `check-avocado`, and adds a >>> deprecation message about the `check-acceptance` target. This is >>> a

Re: [PATCH v2 1/2] tests/acceptance: introduce new check-avocado tartget

2021-11-08 Thread Daniel P . Berrangé
On Mon, Nov 08, 2021 at 08:59:51AM +0100, Thomas Huth wrote: > On 05/11/2021 16.53, Willian Rampazzo wrote: > > This introduces a new `make` target, `check-avocado`, and adds a > > deprecation message about the `check-acceptance` target. This is > > a preparation for renaming the

Re: [PATCH v2 1/2] tests/acceptance: introduce new check-avocado tartget

2021-11-08 Thread Philippe Mathieu-Daudé
On 11/8/21 08:59, Thomas Huth wrote: > On 05/11/2021 16.53, Willian Rampazzo wrote: >> This introduces a new `make` target, `check-avocado`, and adds a >> deprecation message about the `check-acceptance` target. This is >> a preparation for renaming the `tests/acceptance` folder to >>  

Re: [PATCH v2 1/2] tests/acceptance: introduce new check-avocado tartget

2021-11-08 Thread Thomas Huth
On 05/11/2021 16.53, Willian Rampazzo wrote: This introduces a new `make` target, `check-avocado`, and adds a deprecation message about the `check-acceptance` target. This is a preparation for renaming the `tests/acceptance` folder to `tests/avocado`. The plan is to remove the call to the