Re: [libvirt PATCH 3/9] qemu: add -display dbus capability check (to update to 6.3)

Hi On Tue, Nov 30, 2021 at 12:41 AM Peter Krempa wrote: > > On Fri, Nov 05, 2021 at 14:51:13 +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > --- > > src/qemu/qemu_capabilities.c | 2 ++ > >

[PATCH] util: fix erroneous requirement for phys_port_id to get ifname of a VF

Commit 795e9e05c3 (libvirt-7.7.0) refactored the code in virpci.c and virnetdev.c that gathered lists of the Virtual Functions (VF) of an SRIOV Physical Function (PF) to simplify the code. Unfortunately the simplification made the assumption that a VF's netdev interface name should only be

Re: [PATCH 1/1] NEWS: document DEVICE_UNPLUG_GUEST_ERROR support

On Fri, Nov 12, 2021 at 03:47:48PM -0300, Daniel Henrique Barboza wrote: > Signed-off-by: Daniel Henrique Barboza > --- > NEWS.rst | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Andrea Bolognani and pushed. -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH] NEWS: Mention two minor regression fixes and addition to bulk stats

On Tue, Nov 30, 2021 at 01:44:18PM -0800, Andrea Bolognani wrote: > On Thu, Nov 25, 2021 at 03:54:45PM +0100, Peter Krempa wrote: > > Signed-off-by: Peter Krempa > > --- > > NEWS.rst | 16 > > 1 file changed, 16 insertions(+) > > Reviewed-by: Andrea Bolognani I've also already

Re: [PATCH] NEWS: Mention two minor regression fixes and addition to bulk stats

On Thu, Nov 25, 2021 at 03:54:45PM +0100, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > NEWS.rst | 16 > 1 file changed, 16 insertions(+) Reviewed-by: Andrea Bolognani -- Andrea Bolognani / Red Hat / Virtualization

Re: [PATCH 22/23] util: virhash: Remove 'virHashFree'

On a Tuesday in 2021, Peter Krempa wrote: The code was converted to stop using this function. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/util/virhash.c | 19 --- src/util/virhash.h | 1 - 3 files changed, 21 deletions(-) Reviewed-by: Ján

Re: [PATCH 20/23] qemuxml2arvtest: Use 'g_hash_table_unref' for clearing the qapi schema cache

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa s/arv/argv/ in the commit summary --- tests/qemuxml2argvtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 23/23] util: virhash: Replace 'virHashDataFree' by 'GDestroyNotify'

On a Tuesday in 2021, Peter Krempa wrote: We pass through to glib's hash table functions so we can also use glibs function prototype definition. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 2 +- src/util/virhash.c | 4 ++-- src/util/virhash.h | 12

Re: [PATCH 21/23] Switch away from virHashFree

On a Tuesday in 2021, Peter Krempa wrote: Use 'g_clear_pointer(, g_hash_table_unref)' instead. In few instances it allows us to also remove explicit clearing of pointers. Signed-off-by: Peter Krempa --- src/conf/domain_addr.c | 2 +- src/conf/domain_conf.c | 2

Re: [PATCH 19/23] qemumonitorjsontest: mymain: Automatically free GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Use separate automatically cleared variables for the x86_64 and s390 versions of the QAPI schema. Signed-off-by: Peter Krempa --- tests/qemumonitorjsontest.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko

Re: [PATCH 18/23] qemumonitorjsontest: testBlockNodeNameDetect: Automatically free GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Additionally we no longer need the cleanup section. Signed-off-by: Peter Krempa --- tests/qemumonitorjsontest.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP

Re: [PATCH 17/23] nwfilterxml2firewalltest: testCompareXMLToArgvFiles: Automatically free GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- tests/nwfilterxml2firewalltest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 16/23] nwfilterxml2firewalltest: virNWFilterIncludeDefToRuleInst: Automatically free GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- tests/nwfilterxml2firewalltest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 15/23] qemuCheckpointGetXMLDescUpdateSize: Don't combine automatic freeing with manual

On a Tuesday in 2021, Peter Krempa wrote: 'blockNamedNodeData' is declared for automatic freeing but we also free it manually and reuse which is a code pattern we don't normally allow. Rewrite the code to have actually two separate hash tables. Signed-off-by: Peter Krempa ---

Re: [PATCH 14/23] qemuProcessRefreshLegacyBlockjobs: Automatically free GHashTable and refactor cleanup

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 13/23] qemuProcessRefreshDisks: Automatically free GHashTable and refactor cleanup

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 12/23] qemuProcessWaitForMonitor: Automatically free GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 11/23] qemuRefreshPRManagerState: Automatically free GHashTable and refactor cleanup

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 10/23] qemuRefreshVirtioChannelState: Automatically free GHashTable and refactor cleanup

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 09/23] qemuMigrationSrcFetchMirrorStats: Automatically free GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 06/23] qemuDomainUpdateMemoryDeviceInfo: Automatically free temporary GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 08/23] qemuDomainGetDiskErrors: Automatically free GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 07/23] qemuDomainBlocksStatsGather: Automatically free GHashTable and refactor cleanup

On a Tuesday in 2021, Peter Krempa wrote: No need for the cleanup section once we switch to g_autoptr. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc

Re: [PATCH 05/23] virNWFilterBuildAll: Automatically free temporary GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/nwfilter/nwfilter_gentech_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 04/23] virNWFilterDoInstantiate: Automatically free temporary GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/nwfilter/nwfilter_gentech_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc Description: PGP signature

Re: [PATCH 21/23] Switch away from virHashFree

On Tue, Nov 30, 2021 at 15:14:14 +, Daniel P. Berrangé wrote: > On Tue, Nov 30, 2021 at 03:32:05PM +0100, Peter Krempa wrote: > > Use 'g_clear_pointer(, g_hash_table_unref)' instead. > > > > In few instances it allows us to also remove explicit clearing of > > pointers. > > > >

Re: [PATCH 21/23] Switch away from virHashFree

On Tue, Nov 30, 2021 at 03:32:05PM +0100, Peter Krempa wrote: > Use 'g_clear_pointer(, g_hash_table_unref)' instead. > > In few instances it allows us to also remove explicit clearing of > pointers. > > Signed-off-by: Peter Krempa > --- > src/conf/domain_addr.c | 2 +- >

Re: [PATCH 00/23] virHashFree refactoring and removal

On Tue, Nov 30, 2021 at 03:31:44PM +0100, Peter Krempa wrote: Peter Krempa (23): virDomainNetDefParseXML: Automatically free GHashTable virDomainDeviceValidateAliasImpl: Automatically free GHashTable and remove cleanup libxlLoggerNew: Avoid virHashFree by rearranging code

Re: [PATCH 03/23] libxlLoggerNew: Avoid virHashFree by rearranging code

On a Tuesday in 2021, Peter Krempa wrote: Allocate the hash table only after the log file is opened so that we don't need to deallocate it on failure. Signed-off-by: Peter Krempa --- src/libxl/libxl_logger.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Ján Tomko

Re: [PATCH 02/23] virDomainDeviceValidateAliasImpl: Automatically free GHashTable and remove cleanup

On a Tuesday in 2021, Peter Krempa wrote: After the conversion to g_autofree, the cleanup label is no longer needed. Signed-off-by: Peter Krempa --- src/conf/domain_validate.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc

Re: [PATCH 01/23] virDomainNetDefParseXML: Automatically free GHashTable

On a Tuesday in 2021, Peter Krempa wrote: Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f88405ab02..25e504a99a 100644 --- a/src/conf/domain_conf.c +++

[PATCH 19/23] qemumonitorjsontest: mymain: Automatically free GHashTable

Use separate automatically cleared variables for the x86_64 and s390 versions of the QAPI schema. Signed-off-by: Peter Krempa --- tests/qemumonitorjsontest.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/qemumonitorjsontest.c

[PATCH 14/23] qemuProcessRefreshLegacyBlockjobs: Automatically free GHashTable and refactor cleanup

Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 382d562fb1..5bbd03210b 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8540,22

[PATCH 16/23] nwfilterxml2firewalltest: virNWFilterIncludeDefToRuleInst: Automatically free GHashTable

Signed-off-by: Peter Krempa --- tests/nwfilterxml2firewalltest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c index 3e8436a98c..6ab62f60c9 100644 --- a/tests/nwfilterxml2firewalltest.c +++

[PATCH 06/23] qemuDomainUpdateMemoryDeviceInfo: Automatically free temporary GHashTable

Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 1f45b30975..3dfc79f61e 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -8198,7 +8198,7 @@

[PATCH 21/23] Switch away from virHashFree

Use 'g_clear_pointer(, g_hash_table_unref)' instead. In few instances it allows us to also remove explicit clearing of pointers. Signed-off-by: Peter Krempa --- src/conf/domain_addr.c | 2 +- src/conf/domain_conf.c | 2 +- src/conf/nwfilter_conf.c

[PATCH 12/23] qemuProcessWaitForMonitor: Automatically free GHashTable

Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 2fdd5b95e2..d1b34612ee 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2392,7 +2392,7 @@

[PATCH 20/23] qemuxml2arvtest: Use 'g_hash_table_unref' for clearing the qapi schema cache

Signed-off-by: Peter Krempa --- tests/qemuxml2argvtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index b3fa676af7..5e4cd7389c 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -823,7 +823,7 @@

[PATCH 23/23] util: virhash: Replace 'virHashDataFree' by 'GDestroyNotify'

We pass through to glib's hash table functions so we can also use glibs function prototype definition. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 2 +- src/util/virhash.c | 4 ++-- src/util/virhash.h | 12 ++-- src/util/virobject.c | 4

[PATCH 22/23] util: virhash: Remove 'virHashFree'

The code was converted to stop using this function. Signed-off-by: Peter Krempa --- src/libvirt_private.syms | 1 - src/util/virhash.c | 19 --- src/util/virhash.h | 1 - 3 files changed, 21 deletions(-) diff --git a/src/libvirt_private.syms

[PATCH 15/23] qemuCheckpointGetXMLDescUpdateSize: Don't combine automatic freeing with manual

'blockNamedNodeData' is declared for automatic freeing but we also free it manually and reuse which is a code pattern we don't normally allow. Rewrite the code to have actually two separate hash tables. Signed-off-by: Peter Krempa --- src/qemu/qemu_checkpoint.c | 16 1 file

[PATCH 17/23] nwfilterxml2firewalltest: testCompareXMLToArgvFiles: Automatically free GHashTable

Signed-off-by: Peter Krempa --- tests/nwfilterxml2firewalltest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/nwfilterxml2firewalltest.c b/tests/nwfilterxml2firewalltest.c index 6ab62f60c9..315afddca0 100644 --- a/tests/nwfilterxml2firewalltest.c +++

[PATCH 18/23] qemumonitorjsontest: testBlockNodeNameDetect: Automatically free GHashTable

Additionally we no longer need the cleanup section. Signed-off-by: Peter Krempa --- tests/qemumonitorjsontest.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index bcf5caa9a4..91a9193f2a 100644

[PATCH 13/23] qemuProcessRefreshDisks: Automatically free GHashTable and refactor cleanup

Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index d1b34612ee..382d562fb1 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8316,18

[PATCH 08/23] qemuDomainGetDiskErrors: Automatically free GHashTable

Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5330a1d3b7..4fcd6190d1 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16439,7 +16439,7 @@

[PATCH 10/23] qemuRefreshVirtioChannelState: Automatically free GHashTable and refactor cleanup

Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c355a39e15..8dface7ec0 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@

[PATCH 11/23] qemuRefreshPRManagerState: Automatically free GHashTable and refactor cleanup

Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 8dface7ec0..2fdd5b95e2 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@

[PATCH 09/23] qemuMigrationSrcFetchMirrorStats: Automatically free GHashTable

Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 8001792f5a..8fb9a3214c 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -6237,7

[PATCH 04/23] virNWFilterDoInstantiate: Automatically free temporary GHashTable

Signed-off-by: Peter Krempa --- src/nwfilter/nwfilter_gentech_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index ecba16d55c..55c7571ea5 100644 ---

[PATCH 07/23] qemuDomainBlocksStatsGather: Automatically free GHashTable and refactor cleanup

No need for the cleanup section once we switch to g_autoptr. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4e680bc0a7..5330a1d3b7 100644 ---

[PATCH 05/23] virNWFilterBuildAll: Automatically free temporary GHashTable

Signed-off-by: Peter Krempa --- src/nwfilter/nwfilter_gentech_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index 55c7571ea5..ea1f4f4092 100644 ---

[PATCH 03/23] libxlLoggerNew: Avoid virHashFree by rearranging code

Allocate the hash table only after the log file is opened so that we don't need to deallocate it on failure. Signed-off-by: Peter Krempa --- src/libxl/libxl_logger.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/libxl/libxl_logger.c b/src/libxl/libxl_logger.c

[PATCH 02/23] virDomainDeviceValidateAliasImpl: Automatically free GHashTable and remove cleanup

After the conversion to g_autofree, the cleanup label is no longer needed. Signed-off-by: Peter Krempa --- src/conf/domain_validate.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index

[PATCH 01/23] virDomainNetDefParseXML: Automatically free GHashTable

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f88405ab02..25e504a99a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -10244,7 +10244,7 @@

[PATCH 00/23] virHashFree refactoring and removal

Peter Krempa (23): virDomainNetDefParseXML: Automatically free GHashTable virDomainDeviceValidateAliasImpl: Automatically free GHashTable and remove cleanup libxlLoggerNew: Avoid virHashFree by rearranging code virNWFilterDoInstantiate: Automatically free temporary GHashTable

Re: [PATCH] qemu_domainjob: remove dead code

On a Tuesday in 2021, Kristina Hanicova wrote: Function qemuDomainJobAllowed() is never used -> remove it. Unused as of commit 3f2fa8f3032779bf09590a4b24898636ee916876 Signed-off-by: Kristina Hanicova --- src/qemu/qemu_domainjob.c | 6 -- src/qemu/qemu_domainjob.h | 2 -- 2 files

Re: [PATCH 0/6] Fix potential deadlock and crash in libxl driver

On a Monday in 2021, Jim Fehlig wrote: I've been investigating what turns out to be some long-standing issues in the libxl driver. One of them causes libvirtd to deadlock, the other can lead to a segmentation fault. Both can be triggered by repeatedly rebooting a collection of VMs. My reproducer

[PATCH] qemu_domainjob: remove dead code

Function qemuDomainJobAllowed() is never used -> remove it. Signed-off-by: Kristina Hanicova --- src/qemu/qemu_domainjob.c | 6 -- src/qemu/qemu_domainjob.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index

Re: [PATCH 0/6] Fix potential deadlock and crash in libxl driver

On Mon, Nov 29, 2021 at 09:38:39AM -0700, Jim Fehlig wrote: > I've been investigating what turns out to be some long-standing issues in > the libxl driver. One of them causes libvirtd to deadlock, the other can > lead to a segmentation fault. Both can be triggered by repeatedly rebooting > a

Re: [PATCH 2/3] virsh: Add '--full-seclabels' option for dominfo

On Mon, 2021-11-29 at 17:52 +0100, Martin Kletzander wrote: > On Thu, Sep 02, 2021 at 08:29:35PM +0800, Luke Yue wrote: > > There is no virsh command uses virDomainGetSecurityLabelList API, > > so add > > an option for dominfo to call it and print full list of security > > labels. > > > > Also

Re: [libvirt PATCH] util: canonicalize 'arm64' arch to 'aarch64'

On Tue, Nov 30, 2021 at 10:53:45AM +, Daniel P. Berrangé wrote: > macOS on Apple silicon reports 'arm64' as the architecture from uname, > which we need to canonicalize to VIR_ARCH_AARCH64 / 'aarch64'. > > Signed-off-by: Daniel P. Berrangé > --- > > NB, I suggest we push this during freeze as

[libvirt PATCH] util: canonicalize 'arm64' arch to 'aarch64'

macOS on Apple silicon reports 'arm64' as the architecture from uname, which we need to canonicalize to VIR_ARCH_AARCH64 / 'aarch64'. Signed-off-by: Daniel P. Berrangé --- NB, I suggest we push this during freeze as it is a trivial bugfix src/util/virarch.c | 2 ++ 1 file changed, 2

Re: [PATCH v2 3/4] conf: Introduce TCG domain features

On Mon, Nov 22, 2021 at 13:24:02 +0100, Michal Prívozník wrote: > On 11/22/21 10:30, Peter Krempa wrote: > > On Fri, Nov 05, 2021 at 10:35:19 +0100, Michal Privoznik wrote: > >> It may come handy to be able to tweak TCG options, in this > >> specific case the size of translation block cache size