Re: [libvirt PATCH 1/2] qemu: Support enabling migration caps unless a flag is used

2021-12-14 Thread Michal Prívozník
On 12/13/21 15:29, Jiri Denemark wrote: > So far we were enabling specific migration capabilities when a > corresponding API flag is set. We need to generalize our code to be able > to enable some migration capabilities unless a particular API flag is > used. > > Signed-off-by: Jiri Denemark >

Re: [libvirt PATCH 0/2] qemu: Add support for return-path migration capability

2021-12-14 Thread Michal Prívozník
On 12/13/21 15:29, Jiri Denemark wrote: > See 2/2 for more details about the capability. > > Jiri Denemark (2): > qemu: Support enabling migration caps unless a flag is used > qemu: Add support for return-path migration capability > > src/qemu/qemu_migration_params.c | 39

[libvirt][PATCH v9 5/5] Add unit tests for guest VM creation command with SGX EPC

2021-12-14 Thread Haibin Huang
From: Lin Yang Two unit test files were added to verify qemu command generated with SGX EPC enabled with 6.2.0 qemu capability. Signed-off-by: Lin Yang --- .../sgx-epc.x86_64-6.2.0.args | 37 +++ tests/qemuxml2argvdata/sgx-epc.xml| 36

[libvirt][PATCH v9 4/5] qemu: Add command-line to generate SGX EPC memory backend

2021-12-14 Thread Haibin Huang
From: Lin Yang According to the result parsing from xml, add the argument of SGX EPC memory backend into QEMU command line: #qemu-system-x86_64 \ .. \ -object memory-backend-epc,id=mem1,size=64M,prealloc=on \ -object memory-backend-epc,id=mem2,size=28M \

[libvirt][PATCH v9 3/5] conf: Introduce SGX EPC element into device memory xml

2021-12-14 Thread Haibin Huang
From: Lin Yang ... 512 ... Signed-off-by: Lin Yang --- docs/schemas/domaincommon.rng| 1 + src/conf/domain_conf.c | 6 ++ src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 1 + src/qemu/qemu_alias.c| 3 +++

[libvirt][PATCH v9 2/5] Transfer Qemu SGX Capabilities to XML

2021-12-14 Thread Haibin Huang
Convert qemu sgx capabilities: {"sgx": true, "section-size": 0, "flc": false} to XML format: no 1 Signed-off-by: Haibin Huang --- docs/schemas/domaincaps.rng | 22 ++- src/conf/domain_capabilities.c| 19

[libvirt][PATCH v9 1/5] Get SGX Capabilities from QEMU

2021-12-14 Thread Haibin Huang
The Qemu QMP provide the command "query-sgx-capabilities" libvirt call the command to get sgx capabilities {"execute":"query-sgx-capabilities"} {"return": {"sgx": true, "sgx1": true, "sgx2": false, "section-size": 0, \ "flc": false}} Signed-off-by: Haibin Huang ---

[libvirt][PATCH v9 0/5] Support query and use SGX

2021-12-14 Thread Haibin Huang
This patch series provides support for enabling Intel's Software Guard Extensions (SGX) feature in guest VM. Giving the SGX support in QEMU be accepted and will be merged in two days Intel SGX is a set of instructions that increases the security of application code and data, giving them more

Re: [libvirt PATCH 00/17] Bump minimum dnsmasq version

2021-12-14 Thread Laine Stump
On 12/14/21 2:09 PM, Ján Tomko wrote: This bumps the minimum dnsmasq version to the point where we do not need capability probing, reducing it to a version check (which I will be happy to remove on request). Unless I missed something, this also means we no longer need to spawn radvd manually.

Re: [libvirt PATCH 08/17] network: assume DNSMASQ_CAPS_RA_PARAM

2021-12-14 Thread Laine Stump
On 12/14/21 2:09 PM, Ján Tomko wrote: Introduced by: "Introduced by dnsmasq commit:" commit c4cd95df68b573b63d234ecdb675228657d65353 Author: Simon Kelley CommitDate: 2013-10-10 20:58:11 +0100 Add --ra-param and remove --force-fast-ra git describe: v2.67rc3-3-gc4cd95d contains:

Re: [libvirt PATCH 03/17] util: dnsmasq: mandate at least version 2.67

2021-12-14 Thread Laine Stump
On 12/14/21 2:09 PM, Ján Tomko wrote: All the capabilities should be supported in 2.67. Make this the minimum version, since even the oldest distros we support have moved on: Debian 8: 2.72 CentOS 7: 2.76 Ubuntu 18.04: 2.79 Signed-off-by: Ján Tomko --- src/util/virdnsmasq.c | 13

Re: [libvirt PATCH 09/17] util: dnsmasq: delete assumed capability flags

2021-12-14 Thread Laine Stump
On 12/14/21 2:09 PM, Ján Tomko wrote: Signed-off-by: Ján Tomko --- src/util/virdnsmasq.c | 22 ++ src/util/virdnsmasq.h | 4 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index efe65174f8..016d9d64a8

[libvirt PATCH 15/17] util: remove dnsmasqCapsGetVersion

2021-12-14 Thread Ján Tomko
It has no callers anymore. Signed-off-by: Ján Tomko --- src/libvirt_private.syms | 1 - src/util/virdnsmasq.c| 9 - src/util/virdnsmasq.h| 1 - 3 files changed, 11 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 36f826e2ed..8ed50d1c45 100644

[libvirt PATCH 16/17] util: dnsmasq: remove caps completely

2021-12-14 Thread Ján Tomko
Now that we only check whether the dnsmasq version is new enough, there is no need for the caps field. Signed-off-by: Ján Tomko --- src/libvirt_private.syms | 1 - src/util/virdnsmasq.c| 17 - src/util/virdnsmasq.h| 5 - 3 files changed, 23 deletions(-) diff --git

[libvirt PATCH 14/17] spec: do not require radvd

2021-12-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 32b4243d0a..b37c6e17f3 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -283,7 +283,6 @@ BuildRequires: libnl3-devel BuildRequires: libselinux-devel

[libvirt PATCH 17/17] network: remove unused 'driver' parameter

2021-12-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- src/network/bridge_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 39f6ed14e1..23d9ed4226 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@

[libvirt PATCH 13/17] build: do not search for radvd binary

2021-12-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index cea8bbfa0c..0b7a2a69c1 100644 --- a/meson.build +++ b/meson.build @@ -860,7 +860,6 @@ optional_programs = [ 'modprobe', 'ovs-vsctl', 'pdwtags', - 'radvd',

[libvirt PATCH 10/17] network: remove any code dealing with radvd

2021-12-14 Thread Ján Tomko
Since dnsmasq supports --ra-param for a long time, this code is now unused. Signed-off-by: Ján Tomko --- src/network/bridge_driver.c | 248 +--- 1 file changed, 6 insertions(+), 242 deletions(-) diff --git a/src/network/bridge_driver.c

[libvirt PATCH 12/17] conf: remove radvdPid from virNetworkObj

2021-12-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- src/conf/virnetworkobj.c | 16 src/conf/virnetworkobj.h | 7 --- src/libvirt_private.syms | 2 -- 3 files changed, 25 deletions(-) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index 41c7dcba5c..f18eb35ae2 100644 ---

[libvirt PATCH 11/17] network: driver: remove unused radvdStateDir variable

2021-12-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- src/network/bridge_driver_platform.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/network/bridge_driver_platform.h b/src/network/bridge_driver_platform.h index 884fa82831..de7cbc1195 100644 --- a/src/network/bridge_driver_platform.h +++

[libvirt PATCH 09/17] util: dnsmasq: delete assumed capability flags

2021-12-14 Thread Ján Tomko
Signed-off-by: Ján Tomko --- src/util/virdnsmasq.c | 22 ++ src/util/virdnsmasq.h | 4 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index efe65174f8..016d9d64a8 100644 --- a/src/util/virdnsmasq.c +++

[libvirt PATCH 08/17] network: assume DNSMASQ_CAPS_RA_PARAM

2021-12-14 Thread Ján Tomko
Introduced by: commit c4cd95df68b573b63d234ecdb675228657d65353 Author: Simon Kelley CommitDate: 2013-10-10 20:58:11 +0100 Add --ra-param and remove --force-fast-ra git describe: v2.67rc3-3-gc4cd95d contains: v2.67rc4~12 Signed-off-by: Ján Tomko --- src/network/bridge_driver.c | 6

[libvirt PATCH 07/17] network: assume DNSMASQ_CAPS_BIND_DYNAMIC

2021-12-14 Thread Ján Tomko
Introduced by dnsmasq commit: commit 54dd393f3938fc0c19088fbd319b95e37d81a2b0 CommitDate: 2012-06-20 11:23:38 +0100 Add --bind-dynamic git describe: v2.63test1 contains: v2.63test1^0 Signed-off-by: Ján Tomko --- src/network/bridge_driver.c | 68 ++--- 1

[libvirt PATCH 06/17] util: remove DNSMASQ_RA_SUPPORT

2021-12-14 Thread Ján Tomko
Now that the macro is unused, delete it. Signed-off-by: Ján Tomko --- src/util/virdnsmasq.h | 8 1 file changed, 8 deletions(-) diff --git a/src/util/virdnsmasq.h b/src/util/virdnsmasq.h index 92c5d4129d..9b8aeef226 100644 --- a/src/util/virdnsmasq.h +++ b/src/util/virdnsmasq.h @@

[libvirt PATCH 05/17] network: assume DNSMASQ_RA_SUPPORT

2021-12-14 Thread Ján Tomko
Delete the code that is only run without the capability. Signed-off-by: Ján Tomko --- src/network/bridge_driver.c | 134 +--- 1 file changed, 19 insertions(+), 115 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index

[libvirt PATCH 04/17] network: assume DNSMASQ_DHCPv6_SUPPORT

2021-12-14 Thread Ján Tomko
Remove the (now unreachable) error message and the macro. Signed-off-by: Ján Tomko --- src/network/bridge_driver.c | 14 -- src/util/virdnsmasq.h | 6 -- 2 files changed, 20 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index

[libvirt PATCH 02/17] tests: do not test dnsmasq older than 2.67

2021-12-14 Thread Ján Tomko
Prepare to retire older versions by droping older tests. Signed-off-by: Ján Tomko --- .../networkxml2confdata/isolated-network.conf | 5 +-- .../nat-network-dns-srv-record-minimal.conf | 10 +++--- .../nat-network-dns-srv-record.conf | 2 ++ .../nat-network-dns-txt-record.conf

[libvirt PATCH 03/17] util: dnsmasq: mandate at least version 2.67

2021-12-14 Thread Ján Tomko
All the capabilities should be supported in 2.67. Make this the minimum version, since even the oldest distros we support have moved on: Debian 8: 2.72 CentOS 7: 2.76 Ubuntu 18.04: 2.79 Signed-off-by: Ján Tomko --- src/util/virdnsmasq.c | 13 + 1 file changed, 13 insertions(+)

[libvirt PATCH 01/17] util: dnsmasqCapsSetFromBuffer: use error label

2021-12-14 Thread Ján Tomko
Rename 'fail' to 'error' to match the prevalent usage. Signed-off-by: Ján Tomko --- src/util/virdnsmasq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index b62e353ceb..90a1ea35b6 100644 --- a/src/util/virdnsmasq.c +++

[libvirt PATCH 00/17] Bump minimum dnsmasq version

2021-12-14 Thread Ján Tomko
This bumps the minimum dnsmasq version to the point where we do not need capability probing, reducing it to a version check (which I will be happy to remove on request). Unless I missed something, this also means we no longer need to spawn radvd manually. Note that DNSMASQ_CAPS_BINDTODEVICE was

Re: [PATCH] rpm: don't start/stop -ro.socket units for virtlockd/virtlogd

2021-12-14 Thread Ján Tomko
On a Tuesday in 2021, Daniel P. Berrangé wrote: These daemons do not have any support for unprivileged readonly access, so we must not reference -ro.socket units in scripts. Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 18 +++--- 1 file changed, 11 insertions(+), 7

[libvirt PATCH 2/2] virDomainFeaturesHyperVDefParse: Compare hyperv mode

2021-12-14 Thread Tim Wiederhake
Previous patch neglected the possibility of different modes for hyperv (e.g. "custom" and "passthrough"). Fixes: 6e83fafe331dd0b4fb19aa384c3dd36b3af62933 Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/conf/domain_conf.c

[libvirt PATCH 1/2] docs: domain: Clarify on the dangers of migrating with hyperv-passthrough enabled

2021-12-14 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- docs/formatdomain.rst | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 0c5e33c78f..2e9c450606 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -1929,7 +1929,14 @@

[libvirt PATCH 0/2] Addendum to hyperv-passthrough

2021-12-14 Thread Tim Wiederhake
Spotted by Daniel. Patches were already merged though, hence this addendum. Tim Wiederhake (2): docs: domain: Clarify on the dangers of migrating with hyperv-passthrough enabled virDomainFeaturesHyperVDefParse: Compare hyperv mode docs/formatdomain.rst | 9 -

[PATCH] rpm: don't start/stop -ro.socket units for virtlockd/virtlogd

2021-12-14 Thread Daniel P . Berrangé
These daemons do not have any support for unprivileged readonly access, so we must not reference -ro.socket units in scripts. Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/libvirt.spec.in

[libvirt PATCH 2/2] qemu: Drop driver parameter from qemuDomainSetFakeReboot

2021-12-14 Thread Jiri Denemark
And its callers. The parameter is no longer used since virDomainObjSave was replaced with qemuDomainSaveStatus wrapper. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c | 3 +-- src/qemu/qemu_domain.h | 3 +-- src/qemu/qemu_driver.c | 14 +++--- src/qemu/qemu_process.c | 13

[libvirt PATCH 1/2] qemu: Use qemuDomainSaveStatus

2021-12-14 Thread Jiri Denemark
It is a nice wrapper around virDomainObjSave which logs a warning, but otherwise ignores the error. Let's use it where appropriate. Signed-off-by: Jiri Denemark --- src/qemu/qemu_domain.c| 11 ++--- src/qemu/qemu_migration.c | 9 + src/qemu/qemu_process.c | 85

[libvirt PATCH 0/2] qemu: Use qemuDomainSaveStatus

2021-12-14 Thread Jiri Denemark
Jiri Denemark (2): qemu: Use qemuDomainSaveStatus qemu: Drop driver parameter from qemuDomainSetFakeReboot src/qemu/qemu_domain.c| 12 ++--- src/qemu/qemu_domain.h| 3 +- src/qemu/qemu_driver.c| 14 +++--- src/qemu/qemu_migration.c | 9 +--- src/qemu/qemu_process.c | 98

Re: [PATCH] rpm: fix typo in daemon name in %post/%preun scripts

2021-12-14 Thread Jiri Denemark
On Tue, Dec 14, 2021 at 16:17:32 +, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > libvirt.spec.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 32b4243d0a..97030be407 100644 > ---

[PATCH] rpm: fix typo in daemon name in %post/%preun scripts

2021-12-14 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 32b4243d0a..97030be407 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1297,7 +1297,7 @@ exit 0 %post daemon

[libvirt PATCH v4 2/3] qemu: probe for sev-guest.kernel-hashes property

2021-12-14 Thread Daniel P . Berrangé
This sev-guest object property indicates whether QEMU should expose the kernel, ramdisk, cmdline hashes to the firmware for measurement. The 6.2.0 capabilities are selectively refreshed to pull in the kernel-hashes parameter to the schema. Signed-off-by: Daniel P. Berrangé ---

[libvirt PATCH v4 3/3] qemu: format sev-guest.kernel-hashes property

2021-12-14 Thread Daniel P . Berrangé
Set the kernel-hashes property on the sev-guest object if the config asked for it explicitly. While QEMU machine types currently default to having this setting off, it is not guaranteed to remain this way. We can't assume that the QEMU capabilities were generated on an AMD host with SEV, so we

[libvirt PATCH v4 1/3] conf: add support for setting SEV kernel hashes

2021-12-14 Thread Daniel P . Berrangé
Normally the SEV measurement only covers the firmware loader contents. When doing a direct kernel boot, however, with new enough OVMF it is possible to ask for the measurement to cover the kernel, ramdisk and command line. It can't be done automatically as that would break existing guests using

[libvirt PATCH v4 0/3] Support SEV direct kernel boot

2021-12-14 Thread Daniel P . Berrangé
This is the left over pieces from the rest fo the previous SEV series. In this version I've changed the way we probe for capabilities and also changed the way we set the capabilities in the test suite so we don't rely on them being generated on an AMD SEV host. Daniel P. Berrangé (3): conf: add

Re: [libvirt PATCH 04/10] virDomainFeaturesHyperVDefParse: Read attribute "mode" of element "hyperv"

2021-12-14 Thread Daniel P . Berrangé
On Fri, Nov 26, 2021 at 03:34:56PM +0100, Tim Wiederhake wrote: > Currently, this attribute may either have a value of "custom", or be absent > (which defaults to "custom"), for backwards compatibility. > > Signed-off-by: Tim Wiederhake > --- > src/conf/domain_conf.c | 11 +-- >

Re: [libvirt PATCH 10/10] docs: domain: Add documentation for hyperv passthrough mode

2021-12-14 Thread Daniel P . Berrangé
On Fri, Nov 26, 2021 at 03:35:02PM +0100, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > docs/formatdomain.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst > index 95ef2e0d05..ec944f89db 100644 > ---

[PATCH v4 0/3] remove sysconfig files

2021-12-14 Thread Olaf Hering
rebased to 359e9f5cf4526eff630d803f68df9733abaef419 Olaf Hering (3): libvirt.spec: relocate pre script of daemon-driver-qemu remove sysconfig files NEWS: mention removal of sysconfig NEWS.rst| 10 +++ docs/daemons.rst| 20 +

[PATCH v4 3/3] NEWS: mention removal of sysconfig

2021-12-14 Thread Olaf Hering
Signed-off-by: Olaf Hering --- NEWS.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 4d1a1501ef..ce324afb8a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -36,6 +36,16 @@ v8.0.0 (unreleased) * **Improvements** + * packaging: sysconfig files no longer

[PATCH v4 1/3] libvirt.spec: relocate pre script of daemon-driver-qemu

2021-12-14 Thread Olaf Hering
Reduce the delta in an upcoming change. No change in behavior intended. Signed-off-by: Olaf Hering --- libvirt.spec.in | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 32b4243d0a..66eff7c7e8 100644 ---

[PATCH v4 2/3] remove sysconfig files

2021-12-14 Thread Olaf Hering
sysconfig files are owned by the admin of the host. They have the liberty to put anything they want into these files. This makes it difficult to provide different built-in defaults. Remove the sysconfig file and place the current desired default into the service file. Local customizations can

[libvirt PATCH] Fix some typos

2021-12-14 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- docs/manpages/virsh.rst | 2 +- src/qemu/qemu_domain.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 275f416090..265725d214 100644 --- a/docs/manpages/virsh.rst +++

Re: [libvirt PATCH 2/5] util: dnsmasq: refactor CapsRefresh

2021-12-14 Thread Laine Stump
On 12/13/21 1:58 PM, Ján Tomko wrote: Use two variables with automatic cleanup instead of reusing one. Remove the pointless cleanup label. Signed-off-by: Ján Tomko --- src/util/virdnsmasq.c | 37 - 1 file changed, 16 insertions(+), 21 deletions(-) diff

[PATCH 0/2] KVM features: two almost trivial cleanups

2021-12-14 Thread Michal Privoznik
I've noticed these while reviewing a patch that touched this part of code. Michal Prívozník (2): qemuxml2xmloutdata: Turn kvm-features.xml and kvm-features-off.xml into symlinks domain_conf: Use virXMLFormatElement*() more in virDomainDefFormatFeatures() src/conf/domain_conf.c

[PATCH 1/2] qemuxml2xmloutdata: Turn kvm-features.xml and kvm-features-off.xml into symlinks

2021-12-14 Thread Michal Privoznik
There's no real difference between input and output XMLs for kvm-features and kvm-features-off test cases. Do what we usually do in such case - turn the output file into a symlink of the input file. Signed-off-by: Michal Privoznik --- tests/qemuxml2argvdata/kvm-features-off.xml | 7 +++-

[PATCH 2/2] domain_conf: Use virXMLFormatElement*() more in virDomainDefFormatFeatures()

2021-12-14 Thread Michal Privoznik
There are few places in virDomainDefFormatFeatures() which can use virXMLFormatElement() or virXMLFormatElementEmpty() instead of writing directly into the output buffer. After this, there are still a lot of places left, but that is much bigger task. Signed-off-by: Michal Privoznik ---

Re: [libvirt PATCH v3 10/13] qemu: report max number of SEV guests

2021-12-14 Thread Daniel P . Berrangé
On Tue, Dec 14, 2021 at 11:44:00AM +0100, Peter Krempa wrote: > On Fri, Dec 10, 2021 at 16:47:10 +, Daniel P. Berrangé wrote: > > Different CPU generations have different limits on the number > > of SEV/SEV-ES guests that can be run. Since both limits come > > from the same overall set, there

Re: [PATCH v7 1/2] qemu: support dirty ring feature

2021-12-14 Thread Hyman Huang
On 12/14/21 20:21, Michal Prívozník wrote: On 12/14/21 10:22, Michal Prívozník wrote: On 11/23/21 15:36, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Dirty ring feature was introduced in qemu-6.1.0, this patch add the corresponding feature named 'dirty-ring', which enable dirty

RE: [libvirt][PATCH v8 3/5] conf: Introduce SGX EPC element into device memory xml

2021-12-14 Thread Huang, Haibin
Ok, I will fix it. Thank you! > -Original Message- > From: Ani Sinha > Sent: Tuesday, December 14, 2021 2:54 PM > To: Huang, Haibin > Cc: libvir-list@redhat.com; Ding, Jian-feng ; Yang, > Lin A ; Lu, Lianhao ; Zhong, > Yang > Subject: Re: [libvirt][PATCH v8 3/5] conf: Introduce SGX EPC

Re: [PATCH v7 1/2] qemu: support dirty ring feature

2021-12-14 Thread Michal Prívozník
On 12/14/21 10:22, Michal Prívozník wrote: > On 11/23/21 15:36, huang...@chinatelecom.cn wrote: >> From: Hyman Huang(黄勇) >> >> Dirty ring feature was introduced in qemu-6.1.0, this patch >> add the corresponding feature named 'dirty-ring', which enable >> dirty ring feature when starting vm. >>

Re: [libvirt PATCH 0/5] use g_auto for virCommand (Episode II.V: Goodbye, Galaxy!)

2021-12-14 Thread Michal Prívozník
On 12/13/21 19:58, Ján Tomko wrote: > Fear not, the end is near. > > Ján Tomko (5): > docs: use g_auto in virCommand example > util: dnsmasq: refactor CapsRefresh > util: iscsi: use two vars in CreateIfaceIQN > util: refactor virNodeSuspendSetNodeWakeup > util: use g_auto in

Re: [libvirt PATCH 00/20] use g_auto for virCommand (Episode II: The Sequel)

2021-12-14 Thread Michal Prívozník
On 12/13/21 19:42, Ján Tomko wrote: > TBD: docs/ and src/util > > Ján Tomko (20): > openvz: refactor openvzExtractVersionInfo > openvz: refactor openvzLoadDomains > openvz: refactor openvzGetVEID > openvz: refactor openvzDomainDefineCmd > openvz: refactor openvzSetInitialConfig >

Re: [PATCH] conf: Turn virDomainDef.kvm_features into a struct

2021-12-14 Thread Ján Tomko
On a Tuesday in 2021, Michal Privoznik wrote: In future commits we will need to store not just an array of VIR_TRISTATE_SWITCH_* but also an additional integer. Follow the example of TCG and introduce a structure where both the array an integer can live. Signed-off-by: Michal Privoznik ---

Re: [PATCH v7 1/2] qemu: support dirty ring feature

2021-12-14 Thread Michal Prívozník
On 12/14/21 12:20, Hyman Huang wrote: > > Ok, i'll rebase the master once the changes get merged and test if the > dirty ring still works. > You can find all the patches applied in my branch: https://gitlab.com/MichalPrivoznik/libvirt/-/commits/review/ Michal

Re: [PATCH v7 1/2] qemu: support dirty ring feature

2021-12-14 Thread Hyman Huang
On 12/14/21 17:22, Michal Prívozník wrote: On 11/23/21 15:36, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Dirty ring feature was introduced in qemu-6.1.0, this patch add the corresponding feature named 'dirty-ring', which enable dirty ring feature when starting vm. To implement

[libvirt PATCH] examples: hellolibvirt: fix argc check

2021-12-14 Thread Ján Tomko
https://gitlab.com/libvirt/libvirt/-/issues/255 Reported-by: Jeremy Alcim Signed-off-by: Ján Tomko --- Pushed as trivial. examples/c/misc/hellolibvirt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/c/misc/hellolibvirt.c b/examples/c/misc/hellolibvirt.c

Re: [libvirt PATCH v3 13/13] qemu: format sev-guest.kernel-hashes property

2021-12-14 Thread Daniel P . Berrangé
On Tue, Dec 14, 2021 at 12:08:37PM +0100, Peter Krempa wrote: > On Fri, Dec 10, 2021 at 16:47:13 +, Daniel P. Berrangé wrote: > > Set the kernel-hashes property on the sev-guest object if > > the config asked for it explicitly. While QEMU machine > > types currently default to having this

Re: [libvirt PATCH v3 12/13] qemu: probe for sev-guest.kernel-hashes property

2021-12-14 Thread Daniel P . Berrangé
On Tue, Dec 14, 2021 at 12:04:17PM +0100, Peter Krempa wrote: > On Fri, Dec 10, 2021 at 16:47:12 +, Daniel P. Berrangé wrote: > > This sev-guest object property indicates whether QEMU should > > expose the kernel, ramdisk, cmdline hashes to the firmware > > for measurement. > > > > The 6.2.0

Re: [libvirt PATCH v3 13/13] qemu: format sev-guest.kernel-hashes property

2021-12-14 Thread Peter Krempa
On Fri, Dec 10, 2021 at 16:47:13 +, Daniel P. Berrangé wrote: > Set the kernel-hashes property on the sev-guest object if > the config asked for it explicitly. While QEMU machine > types currently default to having this setting off, it > is not guaranteed to remain this way. > >

Re: [libvirt PATCH v3 12/13] qemu: probe for sev-guest.kernel-hashes property

2021-12-14 Thread Peter Krempa
On Fri, Dec 10, 2021 at 16:47:12 +, Daniel P. Berrangé wrote: > This sev-guest object property indicates whether QEMU should > expose the kernel, ramdisk, cmdline hashes to the firmware > for measurement. > > The 6.2.0 capabilities are hacked to look as if they were > generated with sev-guest

Re: [libvirt PATCH v3 10/13] qemu: report max number of SEV guests

2021-12-14 Thread Peter Krempa
On Fri, Dec 10, 2021 at 16:47:10 +, Daniel P. Berrangé wrote: > Different CPU generations have different limits on the number > of SEV/SEV-ES guests that can be run. Since both limits come > from the same overall set, there is typically also BIOS config > to set the tradeoff betweeen SEV and

Re: [libvirt PATCH v3 12/13] qemu: probe for sev-guest.kernel-hashes property

2021-12-14 Thread Peter Krempa
On Fri, Dec 10, 2021 at 16:47:12 +, Daniel P. Berrangé wrote: > This sev-guest object property indicates whether QEMU should > expose the kernel, ramdisk, cmdline hashes to the firmware > for measurement. > > The 6.2.0 capabilities are hacked to look as if they were > generated with sev-guest

[PATCH] conf: Turn virDomainDef.kvm_features into a struct

2021-12-14 Thread Michal Privoznik
In future commits we will need to store not just an array of VIR_TRISTATE_SWITCH_* but also an additional integer. Follow the example of TCG and introduce a structure where both the array an integer can live. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 20 +---

Re: [PATCH v7 1/2] qemu: support dirty ring feature

2021-12-14 Thread Michal Prívozník
On 11/23/21 15:36, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > Dirty ring feature was introduced in qemu-6.1.0, this patch > add the corresponding feature named 'dirty-ring', which enable > dirty ring feature when starting vm. > > To implement the dirty-ring feature,

Re: [libvirt PATCH v3 09/13] util: pull CPUID helper function out of CPU driver

2021-12-14 Thread Peter Krempa
On Fri, Dec 10, 2021 at 16:47:09 +, Daniel P. Berrangé wrote: > This will be needed directly in the QEMU driver in a later patch. > > Signed-off-by: Daniel P. Berrangé > --- > src/cpu/cpu_x86.c| 34 +-- > src/libvirt_private.syms | 1 + > src/util/virhostcpu.c

Re: [PATCH] libxl: Implement domainGetMessages API

2021-12-14 Thread Peter Krempa
On Tue, Dec 14, 2021 at 09:14:38 +, Daniel P. Berrangé wrote: > On Tue, Dec 14, 2021 at 10:05:26AM +0100, Peter Krempa wrote: > > On Mon, Dec 13, 2021 at 17:35:36 -0700, Jim Fehlig wrote: > > > Since commit 46783e6307a, the 'virsh dominfo' command calls > > > virDomainGetMessages to report any

Re: [PATCH] libxl: Implement domainGetMessages API

2021-12-14 Thread Daniel P . Berrangé
On Tue, Dec 14, 2021 at 10:05:26AM +0100, Peter Krempa wrote: > On Mon, Dec 13, 2021 at 17:35:36 -0700, Jim Fehlig wrote: > > Since commit 46783e6307a, the 'virsh dominfo' command calls > > virDomainGetMessages to report any messages from the domain. > > Hypervisors not implementing the API now

Re: [PATCH] libxl: Implement domainGetMessages API

2021-12-14 Thread Peter Krempa
On Tue, Dec 14, 2021 at 10:05:51 +0100, Peter Krempa wrote: > On Mon, Dec 13, 2021 at 17:35:36 -0700, Jim Fehlig wrote: > > Since commit 46783e6307a, the 'virsh dominfo' command calls > > virDomainGetMessages to report any messages from the domain. > > Hypervisors not implementing the API now get

Re: [PATCH] libxl: Implement domainGetMessages API

2021-12-14 Thread Peter Krempa
On Mon, Dec 13, 2021 at 17:35:36 -0700, Jim Fehlig wrote: > Since commit 46783e6307a, the 'virsh dominfo' command calls > virDomainGetMessages to report any messages from the domain. > Hypervisors not implementing the API now get the following > log message when clients invoke 'virsh dominfo' > >

Re: [PATCH] libxl: Implement domainGetMessages API

2021-12-14 Thread Michal Prívozník
On 12/14/21 01:35, Jim Fehlig wrote: > Since commit 46783e6307a, the 'virsh dominfo' command calls > virDomainGetMessages to report any messages from the domain. > Hypervisors not implementing the API now get the following > log message when clients invoke 'virsh dominfo' > > this function is not