On 1/4/22 11:59 AM, Michal Privoznik wrote:
In a few places (e.g. device attach/detach/update) we are given a
device XML, parse it but then need a copy of parsed data so that
the original can be passed to function handling the request over
inactive XML and the copy is then passed to function
On Tue, Dec 21, 2021 at 2:44 AM Yifei Jiang via wrote:
>
> Add virtual time context description to vmstate_kvmtimer. After cpu being
> loaded, virtual time context is updated to KVM.
>
> Signed-off-by: Yifei Jiang
> Signed-off-by: Mingwang Li
> Reviewed-by: Anup Patel
Reviewed-by: Alistair
On Tue, Dec 21, 2021 at 3:45 AM Yifei Jiang via wrote:
>
> We hope that virtual time adjusts with vm state changing. When a vm
> is stopped, guest virtual time should stop counting and kvm_timer
> should be stopped. When the vm is resumed, guest virtual time should
> continue to count and
On Tue, Dec 21, 2021 at 3:41 AM Yifei Jiang via wrote:
>
> Use char-fe to handle console sbi call, which implement early
> console io while apply 'earlycon=sbi' into kernel parameters.
>
> Signed-off-by: Yifei Jiang
> Signed-off-by: Mingwang Li
> Reviewed-by: Anup Patel
> ---
>
Folks,
I'd like to get this patch set in next release. Bubbling up this thread
as it was sent out before the holidays.
Regards,
Praveen K Paladugu
On 12/10/2021 2:34 PM, Praveen K Paladugu wrote:
This patchset adds support for cgroup management of ch threads. This version
correctly manages
The commit that added error checking to this function
forgot to adjust the WIN32 stub.
Fixes: a873924e36b28c5b125621e35b32beb6b077bcc8
Signed-off-by: Ján Tomko
---
Pushed as a build fix.
src/util/virdaemon.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
On Wed, Jan 05, 2022 at 04:06:49PM +0100, Ján Tomko wrote:
> Add a new attribute to control the killpriv feature:
>
>
> ...
>
>
>
>
Ewww, ewww, ewww.
This is a horrible element & attribute name. Even with the docs I have
little clue as to why we would ever need this
Add a new attribute to control the killpriv feature:
...
https://bugzilla.redhat.com/show_bug.cgi?id=1972571
Signed-off-by: Ján Tomko
---
docs/formatdomain.rst | 4
docs/schemas/domaincommon.rng | 7 +++
https://bugzilla.redhat.com/show_bug.cgi?id=1972571
Signed-off-by: Ján Tomko
---
src/qemu/qemu_virtiofs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c
index 1b853a5a59..c89da76c27 100644
--- a/src/qemu/qemu_virtiofs.c
+++
Ján Tomko (2):
conf: add killpriv v2 attribute for virtiofs
qemu: virtiofs: add (no_)killpriv_v2 support
docs/formatdomain.rst | 4
docs/schemas/domaincommon.rng | 7 +++
src/conf/domain_conf.c| 15
From: Thomas Huth
It's likely broken, and nobody cared for picking it up again
during the deprecation phase, so let's remove this now.
Since this is the last entry in deprecated_targets_list, remove
the related code in the configure script, too.
Signed-off-by: Thomas Huth
Reviewed-by: Richard
Obviously s/out/output/ in $SUBJ
On Wed, Jan 05, 2022 at 02:31:37PM +0100, Martin Kletzander wrote:
Suggested-by: Erik Skultety
Signed-off-by: Martin Kletzander
---
src/util/virlog.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/util/virlog.c
Suggested-by: Erik Skultety
Signed-off-by: Martin Kletzander
---
src/util/virlog.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/util/virlog.c b/src/util/virlog.c
index 139dce8d0220..b44ad0ef6c47 100644
--- a/src/util/virlog.c
+++ b/src/util/virlog.c
@@
On Wed, Jan 05, 2022 at 12:29:18PM +0100, Erik Skultety wrote:
On Tue, Jan 04, 2022 at 02:47:10PM +0100, Martin Kletzander wrote:
And make callers check the return value as well. This helps error out early for
invalid environment variables.
That is desirable because it could lead to
On Wed, Jan 05, 2022 at 11:14:20AM +, Daniel P. Berrangé wrote:
> On Wed, Jan 05, 2022 at 03:02:07AM -0800, Andrea Bolognani wrote:
> > What if I changed things so that both the HVF test cases and the
> > testutilsqemu bit above are only built on macOS? We'd still have the
> > weird mix of
We are getting close to the next release of libvirt. To aim for the
release on Jan 14 I suggest entering the freeze on Monday Jan 10 and
tagging RC2 on Wednesday Jan 12.
I hope this works for everyone.
Jirka
On Tue, Jan 04, 2022 at 02:47:04PM +0100, Martin Kletzander wrote:
> Before this series:
>
> # LIBVIRT_LOG_OUTPUTS=1:asdf:fdsa:meh libvirtd
>
>
> After this series:
>
> # LIBVIRT_LOG_OUTPUTS=1:asdf:fdsa:meh libvirtd
> libvirt: error : invalid argument: Invalid destination 'asdf' for output
>
On Tue, Jan 04, 2022 at 02:47:08PM +0100, Martin Kletzander wrote:
> The only difference is that we are not going to be guaranteed that the mutex
> is
> normal (as opposed to recursive, although there is no system known to me that
> would default to recursive mutexes), but that was done only to
On Tue, Jan 04, 2022 at 02:47:12PM +0100, Martin Kletzander wrote:
> There is no need to do that since both fallible functions do that already.
>
> Signed-off-by: Martin Kletzander
> ---
Reviewed-by: Erik Skultety
On Tue, Jan 04, 2022 at 02:47:11PM +0100, Martin Kletzander wrote:
> Callers that already do this anyway can be cleaned up thanks to this and the
> one
> that does not (daemon startup) gains the benefit of the error being printed to
> standard error output changing:
>
>
On Tue, Jan 04, 2022 at 02:47:09PM +0100, Martin Kletzander wrote:
> This prevents starting any daemons with improper logging settings. This is
> desirable on its own, but will be even more beneficial when more functions
> start
> reporting errors and failing on them, coming up in following
On Tue, Jan 04, 2022 at 02:47:07PM +0100, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
Reviewed-by: Erik Skultety
On Tue, Jan 04, 2022 at 02:47:06PM +0100, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
Reviewed-by: Erik Skultety
On Tue, Jan 04, 2022 at 02:47:05PM +0100, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander
> ---
Reviewed-by: Erik Skultety
On Tue, Jan 04, 2022 at 02:47:10PM +0100, Martin Kletzander wrote:
> And make callers check the return value as well. This helps error out early
> for
> invalid environment variables.
>
> That is desirable because it could lead to deadlocks. This can happen when
> resetting logging after
On Wed, Jan 05, 2022 at 03:02:07AM -0800, Andrea Bolognani wrote:
> On Wed, Jan 05, 2022 at 10:10:07AM +, Daniel P. Berrangé wrote:
> > On Tue, Jan 04, 2022 at 07:52:50PM +0100, Andrea Bolognani wrote:
> > > + if (hvf_machines[i] != NULL) {
> > > + for (j = 0; hvf_machines[i][j] != NULL;
On Wed, Jan 05, 2022 at 10:10:07AM +, Daniel P. Berrangé wrote:
> On Tue, Jan 04, 2022 at 07:52:50PM +0100, Andrea Bolognani wrote:
> > + if (hvf_machines[i] != NULL) {
> > + for (j = 0; hvf_machines[i][j] != NULL; j++) {
> > + virQEMUCapsAddMachine(tmpCaps,
> > +
On Wed, Jan 05, 2022 at 10:04:59AM +, Daniel P. Berrangé wrote:
> On Tue, Jan 04, 2022 at 07:52:54PM +0100, Andrea Bolognani wrote:
> > +
> > + "hvf" domain type adds support of > + href="https://developer.apple.com/documentation/hypervisor;>
> > + Hypervisor.framework
On Wed, Jan 05, 2022 at 01:36:23AM -0800, Andrea Bolognani wrote:
> On Wed, Jan 05, 2022 at 09:23:09AM +, Daniel P. Berrangé wrote:
> > On Tue, Jan 04, 2022 at 07:52:46PM +0100, Andrea Bolognani wrote:
> > > +static const char *
> > > +virQEMUCapsAccelStr(virDomainVirtType type)
> > > +{
> > >
On Tue, Jan 04, 2022 at 07:52:50PM +0100, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> tests/testutilsqemu.c | 40
> 1 file changed, 40 insertions(+)
>
> diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
> index
On Tue, Jan 04, 2022 at 07:52:54PM +0100, Andrea Bolognani wrote:
> From: Roman Bolshakov
>
> Signed-off-by: Roman Bolshakov
> Signed-off-by: Andrea Bolognani
> ---
> docs/docs.html.in | 3 +
> docs/index.html.in | 3 +-
> docs/macos.html.in | 229
On Tue, Jan 04, 2022 at 07:52:49PM +0100, Andrea Bolognani wrote:
> Apple Silicon (aarch64) has HVF support, but there is no
> 32-bit Intel hardware that is HVF-capable.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/qemu/qemu_capabilities.c | 3 ++-
> 1 file changed, 2 insertions(+), 1
On Tue, Jan 04, 2022 at 07:52:48PM +0100, Andrea Bolognani wrote:
> From: Roman Bolshakov
>
> With this change virsh domcapabilites shows:
>
>
> https://gitlab.com/libvirt/libvirt/-/issues/147
>
> Signed-off-by: Roman Bolshakov
> Signed-off-by: Andrea Bolognani
> ---
>
On Wed, Jan 05, 2022 at 09:23:09AM +, Daniel P. Berrangé wrote:
> On Tue, Jan 04, 2022 at 07:52:46PM +0100, Andrea Bolognani wrote:
> > +static const char *
> > +virQEMUCapsAccelStr(virDomainVirtType type)
> > +{
> > +if (type == VIR_DOMAIN_VIRT_KVM) {
> > +return "kvm";
> > +}
On Wed, Jan 05, 2022 at 09:18:17AM +, Daniel P. Berrangé wrote:
> On Tue, Jan 04, 2022 at 07:52:44PM +0100, Andrea Bolognani wrote:
> > -if (virttype == VIR_DOMAIN_VIRT_KVM && capsType ==
> > VIR_DOMAIN_VIRT_QEMU) {
> > +if (virQEMUCapsTypeIsAccelerated(virttype) && capsType ==
> >
On Tue, Jan 04, 2022 at 07:52:47PM +0100, Andrea Bolognani wrote:
> From: Roman Bolshakov
>
> With more acceleration types, KVM should be used only in error messages
> related to KVM.
>
> Signed-off-by: Roman Bolshakov
> Signed-off-by: Andrea Bolognani
> ---
> src/qemu/qemu_capabilities.c |
On Tue, Jan 04, 2022 at 07:52:46PM +0100, Andrea Bolognani wrote:
> From: Roman Bolshakov
>
> This makes possible to add more accelerators by touching less code and
> reduces code duplication.
>
> Signed-off-by: Roman Bolshakov
> Signed-off-by: Andrea Bolognani
> ---
>
On Tue, Jan 04, 2022 at 07:52:45PM +0100, Andrea Bolognani wrote:
> From: Roman Bolshakov
>
> The function should be used to check if qemu capabilities include a
> hardware acceleration, i.e. accel is not TCG.
>
> Signed-off-by: Roman Bolshakov
> Signed-off-by: Andrea Bolognani
> ---
>
On Tue, Jan 04, 2022 at 07:52:44PM +0100, Andrea Bolognani wrote:
> From: Roman Bolshakov
>
> It replaces hardcoded checks that select accelCPU/accelCPUModels
> (formerly known as kvmCPU/kvmCPUModels) for KVM. It'll be cleaner to use
> the function when multiple accelerators are supported in
On Tue, Jan 04, 2022 at 07:52:42PM +0100, Andrea Bolognani wrote:
> From: Roman Bolshakov
>
> There's no QMP command for querying if hvf is supported, therefore we
> use sysctl interface that tells if Hypervisor.framework works/available
> on the host.
>
> Signed-off-by: Roman Bolshakov
>
On Tue, Jan 04, 2022 at 07:52:41PM +0100, Andrea Bolognani wrote:
> From: Roman Bolshakov
>
> Signed-off-by: Roman Bolshakov
> Signed-off-by: Andrea Bolognani
> ---
> src/qemu/qemu_capabilities.c | 1 +
> src/qemu/qemu_capabilities.h | 1 +
> 2 files changed, 2 insertions(+)
Reviewed-by:
On Tue, Jan 04, 2022 at 07:52:40PM +0100, Andrea Bolognani wrote:
> From: Roman Bolshakov
>
> QEMU supports Hypervisor.framework since 2.12 as hvf accel.
> Hypervisor.framework provides a lightweight interface to run a virtual
> cpu on macOS without the need to install third-party kernel
>
42 matches
Mail list logo
