On Sat, Jan 15, 2022 at 02:22 Laine Stump wrote:
> On 1/14/22 3:29 PM, Ján Tomko wrote:
> > On a Friday in 2022, Laine Stump wrote:
> >> Since it's Friday and we're talking about personal preferences - I
> >> personally dislike the use of i and j (and anything else with a single
> >> letter) as
On 1/14/22 3:29 PM, Ján Tomko wrote:
On a Friday in 2022, Laine Stump wrote:
Since it's Friday and we're talking about personal preferences - I
personally dislike the use of i and j (and anything else with a single
letter) as variable names, because it makes using a text search for
occurences
On a Friday in 2022, Daniel P. Berrangé wrote:
Given previous platforms we've dropped, we can bump the min
compilers.
Daniel P. Berrangé (3):
configure: bump min required GCC to 7.4.0
configure: bump min required CLang to 6.0 / XCode 10.0
examples: drop some conditionals checks from macros
On a Friday in 2022, Laine Stump wrote:
Since it's Friday and we're talking about personal preferences - I
personally dislike the use of i and j (and anything else with a single
letter) as variable names, because it makes using a text search for
occurences pointless. Sure, longer variable
This demonstrates that when the XML config contains
the firmware auto-selection code will ignore the high priority pflash
OVMF builds tagged with the 'amd-sev' feature, and instead pick the
ROM builds without a varstore.
Signed-off-by: Daniel P. Berrangé
---
This is different from most OVMF firmware builds in that there
is no separate NVRAM variables store. The main image is readonly
and does not persist variables. As such it uses the old style
-bios config with QEMU rather than pflash.
Signed-off-by: Daniel P. Berrangé
---
If the '' type attribute is set, then use this to filter
the available firmware files. This allows forcing use of a firmware
with or without NVRAM, where both options are available. This will
be used for AMD SEV when doing a measured boot, where NVRAM must
be forbidden.
Signed-off-by: Daniel P.
The loader 'type' is a property that is useful to filter on when
selecting firmware. For example, with AMD SEV it is desirable to be
able to request selecting of firmware without NVRAM using:
Signed-off-by: Daniel P. Berrangé
---
docs/formatdomain.rst | 12
The normal requirements for UEFI firmware images are to support
persistence of variables, either in the main image, or more typically in
a separate NVRAM file.
In a confidential computing environment, however, persistence of
variables can cause trust issues and prevent measurement of the firmware
The firmware distros have given people for use with AMD SEV thus far has
just been one of the regular OVMF builds. This is sufficient for booting
a guest with SEV enabled, but is useless if you want to actually
validate the guest measurement. The NVRAM store is untrustworthy since
it is not
Several distros have been dropped since the last time we bumped the
minimum required CLang version.
Per repology, currently shipping versions are:
RHEL-8: 10.0.1
Debian Buster: 7.0.1
openSUSE Leap 15.2: 9.0.1
Ubuntu LTS 18.04: 6.0.0
Ubuntu LTS 20.04: 10.0.0
We no longer need to worry about GCC version older than 7.4.0. The other
remaining conditionals checks were also overkill for the example code.
In the unlikely event that someone tries to re-use the code in a
scenario where further conditions apply they can figure out.
Signed-off-by: Daniel P.
Given previous platforms we've dropped, we can bump the min
compilers.
Daniel P. Berrangé (3):
configure: bump min required GCC to 7.4.0
configure: bump min required CLang to 6.0 / XCode 10.0
examples: drop some conditionals checks from macros
config.h | 14
Several distros have been dropped since the last time we bumped the
minimum required GCC version.
Per repology, currently shipping versions are:
RHEL-8: 8.3.1
Debian Buster: 8.3.0
openSUSE Leap 15.2: 7.5.0
Ubuntu LTS 18.04: 7.5.0
Ubuntu LTS 20.04:
On 14/01/22 8:17 pm, Michal Prívozník wrote:
On 1/13/22 15:43, Michal Prívozník wrote:
On 1/13/22 08:33, Divya Garg wrote:
Issue
Divya Garg (2):
Add the port allocation logic for isa-serial devices.
qemu: add index for isa-serial device using target.port
61 files changed, 156
Thanks Michal !! For reviewing and merging my patch. I will keep all the
nits
pointed by you in mind for my next patches. :)
On 13/01/22 8:50 pm, Michal Prívozník wrote:
On 1/13/22 08:33, Divya Garg wrote:
This commit takes care of following cases:
-> Check availability of requested ports.
On 13/01/22 8:13 pm, Michal Prívozník wrote:
On 1/13/22 08:33, Divya Garg wrote:
Issue
Divya Garg (2):
Add the port allocation logic for isa-serial devices.
qemu: add index for isa-serial device using target.port
61 files changed, 156 insertions(+), 90 deletions(-)
Hey, couple of
On 13/01/22 8:13 pm, Michal Prívozník wrote:
On 1/13/22 08:33, Divya Garg wrote:
VM XML accepts target.port but this does not get passed while building the qemu
command line for this VM.
Signed-off-by: Divya Garg
---
src/qemu/qemu_command.c | 25 +++
On 1/14/22 10:56 AM, Ján Tomko wrote:
On a Friday in 2022, Tim Wiederhake wrote:
This was not mentioned before.
Signed-off-by: Tim Wiederhake
---
docs/coding-style.rst | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/coding-style.rst b/docs/coding-style.rst
index
On Fri, Jan 14, 2022 at 09:24:23AM -0800, Andrea Bolognani wrote:
> On Fri, Jan 14, 2022 at 04:43:58PM +0100, Ján Tomko wrote:
> > On a Friday in 2022, Tim Wiederhake wrote:
> > > + Historically, libvirt declared pointer types 'virXXXPtr' for
> > > + both public and internal types. Do not
On Fri, Jan 14, 2022 at 04:43:58PM +0100, Ján Tomko wrote:
> On a Friday in 2022, Tim Wiederhake wrote:
> > + Historically, libvirt declared pointer types 'virXXXPtr' for
> > + both public and internal types. Do not introduce new such
> > + typedefs for internal types.
>
> This weakly
On Fri, Jan 14, 2022 at 04:43:58PM +0100, Ján Tomko wrote:
> On a Friday in 2022, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake
> > ---
> > docs/coding-style.rst | 5 +
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/docs/coding-style.rst b/docs/coding-style.rst
> > index
On Wed, Jan 12, 2022 at 09:47:58AM +0100, Michal Privoznik wrote:
> After previous cleanups, there's just one caller of
> dnsmasqCapsNewEmpty() and it is dnsmasqCapsNewFromBinary().
> And the former is pretty short. Therefore, it is not necessary
> for the code to live in two separate functions.
On a Friday in 2022, Peter Krempa wrote:
Note that I've truncated the auto-generated stuff out of patches 2/3 and
3/3.
For full version:
git fetch https://gitlab.com/pipo.sk/libvirt.git device-json-reenable
Also note that I've based this on the 'staging' branch of qemu.git
currently, which
On a Friday in 2022, Peter Krempa wrote:
The machine type doesn't change the test result and prevents tests being
changed every time we are about to update real capabilities to a new
qemu.
Signed-off-by: Peter Krempa
---
You should've truncated this patch too, for consistency ;)
Jano
On a Wednesday in 2022, Michal Privoznik wrote:
There are two tests currently that simulate QMP talk:
qemucapabilitiestest and qemuhotplugtest. In both cases they
check whether currently executed command is the one for which
reply was provided. If not an error message is reported. However,
the
On a Wednesday in 2022, Peter Krempa wrote:
Patches 1 and 2 should be pushed for 8.0 as the bug was introduced in
this dev cycle and the patches are specifically kept very simple.
The rest of the series refactors the snapshot validation and helper code
to have less weird semantics which lead to
On Wed, Jan 12, 2022 at 09:47:57AM +0100, Michal Privoznik wrote:
> The function is no longer used. Remove it.
>
> Signed-off-by: Michal Privoznik
> ---
> src/libvirt_private.syms | 1 -
> src/util/virdnsmasq.c| 14 --
> src/util/virdnsmasq.h| 1 -
> 3 files changed, 16
On Wed, Jan 12, 2022 at 09:47:54AM +0100, Michal Privoznik wrote:
> +VIR_TEST_MAIN_PRELOAD(mymain,
> + VIR_TEST_MOCK("network"))
Also I think "virdnsmasqmock" would be a better name for this mock
library, as it mocks stuff that influences the "virdnsmasq" module.
--
Andrea
On a Wednesday in 2022, Peter Krempa wrote:
The function isn't used outside of src/conf/snapshot_conf.c
Exported by 21b2651e72ee33211e057d5c3921d9af65465f8e
for the code motion in 9b75154c07dc50fb50296f35543f5dba0337cbb8
but its user was later reverted in
On Wed, Jan 12, 2022 at 09:47:56AM +0100, Michal Privoznik wrote:
> DISCLAIMER: dnsmasq capabilities are empty as of v8.0.0-rc1~145.
>
> In a real environment the dnsmasq capabilities are constructed
> using dnsmasqCapsNewFromBinary(). We also have
> dnsmasqCapsNewFromBuffer() to bypass checks
Now that qemu fixed device unplug when JSON syntax is used with -device
we can re-enable the feature.
Since the old capability string representation is condemned by
suggesting filtering it as a workaround we must introduce a new string.
To achieve this the original capability position is renamed
The machine type doesn't change the test result and prevents tests being
changed every time we are about to update real capabilities to a new
qemu.
Signed-off-by: Peter Krempa
---
tests/qemuxml2argvdata/x86-kvm-32-on-64.x86_64-latest.args | 2 +-
tests/qemuxml2argvdata/x86-kvm-32-on-64.xml
Note that I've truncated the auto-generated stuff out of patches 2/3 and
3/3.
For full version:
git fetch https://gitlab.com/pipo.sk/libvirt.git device-json-reenable
Also note that I've based this on the 'staging' branch of qemu.git
currently, which means that there's a small possibility that
On a Friday in 2022, Michal Privoznik wrote:
Couple of cleanups I've done whilst looking around our code base.
Michal Prívozník (11):
storage_file: Declare virStorageSourceParseRBDColonString only in one
header
virconf: Report an error in when virConfSetValue() fails
xen_xl: Check for
On a Friday in 2022, Michal Privoznik wrote:
There are few places inside src/libxl/xen_xl.c that can benefit
from g_autofree. Let them use automatic memory freeing.
Signed-off-by: Michal Privoznik
---
src/libxl/xen_xl.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
On a Friday in 2022, Michal Privoznik wrote:
The virStorageSourceParseRBDColonString() function is declared in
src/storage_file/storage_source.h and
src/storage_file/storage_source_backingstore.h but implemented
only in the .c that corresponds to the latter header file.
Therefore, drop
On a Friday in 2022, Tim Wiederhake wrote:
This was not mentioned before.
Signed-off-by: Tim Wiederhake
---
docs/coding-style.rst | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/coding-style.rst b/docs/coding-style.rst
index 14c5136398..e1ed34f764 100644
---
On a Friday in 2022, Tim Wiederhake wrote:
There are no instances of that label left.
Signed-off-by: Tim Wiederhake
---
docs/coding-style.rst | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Friday in 2022, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
docs/coding-style.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/coding-style.rst b/docs/coding-style.rst
index 470c61860f..dca9de1915 100644
--- a/docs/coding-style.rst
+++ b/docs/coding-style.rst
@@
On a Friday in 2022, Tim Wiederhake wrote:
The code style showed `bool hasFoos; if (hasFoos == true)` as a
good example in one place, only to warn against comparisons with
`true` a couple of paragraphs further down.
Merge this advice on comparing with `true` into the "Conditional
expressions"
On Wed, Jan 12, 2022 at 09:47:54AM +0100, Michal Privoznik wrote:
> With this code in place, the virFileIsExecutable() check can be
> removed from dnsmasqCapsRefreshInternal() because
> virFindFileInPath() already made sure the binary is executable.
>
> But introducing virFileIsExecutable() means
The code style showed `bool hasFoos; if (hasFoos == true)` as a
good example in one place, only to warn against comparisons with
`true` a couple of paragraphs further down.
Merge this advice on comparing with `true` into the "Conditional
expressions" section and split the example up for
Some additions and clarifications to libvirt's code style
documentation, based on points of feedback that are given
regularly on the mailing list.
Tim Wiederhake (4):
docs: coding-style: Clarify on virXXXPtr types
docs: coding-style: Rewrite section on shortening comparisons
docs:
This was not mentioned before.
Signed-off-by: Tim Wiederhake
---
docs/coding-style.rst | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/coding-style.rst b/docs/coding-style.rst
index 14c5136398..e1ed34f764 100644
--- a/docs/coding-style.rst
+++ b/docs/coding-style.rst
@@
Signed-off-by: Tim Wiederhake
---
docs/coding-style.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/coding-style.rst b/docs/coding-style.rst
index 470c61860f..dca9de1915 100644
--- a/docs/coding-style.rst
+++ b/docs/coding-style.rst
@@ -54,6 +54,7 @@ Struct type names
and
There are no instances of that label left.
Signed-off-by: Tim Wiederhake
---
docs/coding-style.rst | 1 -
1 file changed, 1 deletion(-)
diff --git a/docs/coding-style.rst b/docs/coding-style.rst
index 3dedb032f4..14c5136398 100644
--- a/docs/coding-style.rst
+++ b/docs/coding-style.rst
@@
On 1/13/22 15:43, Michal Prívozník wrote:
> On 1/13/22 08:33, Divya Garg wrote:
>> Issue
>
>>
>> Divya Garg (2):
>> Add the port allocation logic for isa-serial devices.
>> qemu: add index for isa-serial device using target.port
>
>
>> 61 files changed, 156 insertions(+), 90 deletions(-)
On Wed, Jan 12, 2022 at 09:47:53AM +0100, Michal Privoznik wrote:
> The dnsmasqCaps type has its own cleanup function defined and
> ready to use via g_autoptr(). Use automatic cleanup instead of
> an explicit one.
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/virdnsmasq.c | 18
There are few places where a cleanup label contains nothing but a
return statement. Drop such labels and return directly.
Signed-off-by: Michal Privoznik
---
tools/virsh-host.c | 20 ++--
tools/vsh.c| 11 ---
2 files changed, 10 insertions(+), 21 deletions(-)
The xenParseXLVnuma() function is responsible for parsing 'vnuma'
part of XL config and setting corresponding values in
virDomainDef. While doing so it uses a static buffer which is set
to data we are interested in and then parsing the buffer further
(e.g. string to integer conversion, bitmap
After previous cleanups some labels are needless: they contain
nothing but a return statement. Drop such labels and return
directly.
Signed-off-by: Michal Privoznik
---
src/libxl/xen_common.c | 7 ++--
src/libxl/xen_xl.c | 80 ++
src/libxl/xen_xm.c
In xenParseXLVnuma() the @cpu variable is freed explicitly.
However, when switched to g_autoptr(virCPUDef) the explicit call
can be removed.
Signed-off-by: Michal Privoznik
---
src/libxl/xen_xl.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/libxl/xen_xl.c
There are few places inside src/libxl/xen_xl.c that can benefit
from g_autofree. Let them use automatic memory freeing.
Signed-off-by: Michal Privoznik
---
src/libxl/xen_xl.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/src/libxl/xen_xl.c
In xenParseXLDisk() the @libxldisk variable (which is type of
libxl_device_disk) is allocated on heap. But this is not
necessary as nothing in the function needs that approach.
Allocate the variable on the stack and drop corresponding
VIR_FREE() call.
Signed-off-by: Michal Privoznik
---
The virStorageSourceParseRBDColonString() function is declared in
src/storage_file/storage_source.h and
src/storage_file/storage_source_backingstore.h but implemented
only in the .c that corresponds to the latter header file.
Therefore, drop declaration from storage_source.h as the function
is not
The way that virConfSetValue() works (and the way it is even
documented) is that the @value pointer is always consumed.
However, since the first order pointer is passed it leaves
callers in a pickle situation - they always have to set pointer
to NULL after calling virConfSetValue() to avoid
This commit declares g_autoptr() function for virConfValue type.
At the same time, it switches variable declarations to use it.
Also, in a few places we might have freed a variable twice, for
instance in xenFormatXLDomainNamespaceData(). This is because
virConfSetValue() consumes passed pointer
Couple of cleanups I've done whilst looking around our code base.
Michal Prívozník (11):
storage_file: Declare virStorageSourceParseRBDColonString only in one
header
virconf: Report an error in when virConfSetValue() fails
xen_xl: Check for virConfSetValue() retval
src: Declare and
Callers of virConfSetValue() don't report any error, they just
pass the error blindly. Therefore, report an error when
virConfSetValue() is about to fail.
Signed-off-by: Michal Privoznik
---
src/util/virconf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/util/virconf.c
There's one case where the return value of virConfSetValue() is
not checked for and it's in xenFormatXLInputDevs() function.
Let's fix that.
Signed-off-by: Michal Privoznik
---
src/libxl/xen_xl.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/libxl/xen_xl.c
The 8.0.0 release of both libvirt and libvirt-python is tagged and
signed tarballs and source RPMs are available at
https://libvirt.org/sources/
https://libvirt.org/sources/python/
Thanks everybody who helped with this release by sending patches,
reviewing, testing, or providing
> > > index 144ba4dd12..a8f41dc8c2 100644
> > > --- a/src/conf/domain_conf.h
> > > +++ b/src/conf/domain_conf.h
> > > @@ -1187,6 +1187,12 @@ typedef enum {
> > > VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_LAST
> > > } virDomainChrConsoleTargetType;
> > >
> > > +/*
> > > + * The value of
63 matches
Mail list logo
