We are getting close to the next release of libvirt. To aim for the
release on Mar 01 I suggest entering the freeze on Wednesday Feb 23 and
tagging RC2 on Friday Feb 25.
I hope this works for everyone.
Jirka
From: Hyman Huang(黄勇)
Extend domdirtyrate-calc virsh api with mode option, either
of these three options "page-sampling,dirty-bitmap,dirty-ring"
can be specified when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
docs/manpages/virsh.rst| 7 +--
From: Hyman Huang(黄勇)
calc-dirty-rate command was introduced since qemu >=5.2.0.
Introduce QEMU_CAPS_CALC_DIRTY_RATE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Extend flags parameter of virDomainStartDirtyRateCalc as a
superset of virDomainDirtyRateCalcFlags, parse the flags and
handle it correspondingly in qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 23 ++-
1
From: Hyman Huang(黄勇)
mode option of calc-dirty-rate command since qemu >=6.2.0.
Introduce QEMU_CAPS_DIRTYRATE_MODE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Add calc_mode for dirtyrate statistics retured by
virsh domstats --dirtyrate api, also add vcpu dirtyrate
if dirty-ring mode was used in last measurement.
Signed-off-by: Hyman Huang(黄勇)
---
src/libvirt-domain.c | 6 +
src/qemu/qemu_driver.c | 22
From: Hyman Huang(黄勇)
Probing QEMU_CAPS_CALC_DIRTY_RATE capability in advance
in case of failure when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
From: Hyman Huang(黄勇)
Add mode parameter to qemuDomainStartDirtyRateCalc API, 'mode'
option of 'calc-dirty-rate' command was introduced since
qemu >= 6.2.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 3 ++-
src/qemu/qemu_monitor.c | 5 +++--
src/qemu/qemu_monitor.h
From: Hyman Huang(黄勇)
For any virTypedParameter API normal practice is to use a string
to expose the data, not the rather enum integer value.
So let's drop the virDomainDirtyRateStatus in public header file
and introduce internal enum def qemuMonitorDirtyRateStatus to
describe the dirty page
From: Hyman Huang(黄勇)
v5:
- [PATCH v5 9/9]: Fix alignment error in qemuDomainGetStatsDirtyRate.
v4:
- Rebase the master
- [PATCH v4 1/9]: Refactor dirty page rate calculation status
implementation, display calc_status as string when
'virsh domstats
From: Hyman Huang(黄勇)
Introduce virDomainDirtyRateCalcFlags to get ready for
adding mode parameter to qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 13 +
1 file changed, 13 insertions(+)
diff --git
From: Hyman Huang(黄勇)
Extend flags parameter of virDomainStartDirtyRateCalc as a
superset of virDomainDirtyRateCalcFlags, parse the flags and
handle it correspondingly in qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 23 ++-
1
From: Hyman Huang(黄勇)
Probing QEMU_CAPS_CALC_DIRTY_RATE capability in advance
in case of failure when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
From: Hyman Huang(黄勇)
mode option of calc-dirty-rate command since qemu >=6.2.0.
Introduce QEMU_CAPS_DIRTYRATE_MODE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
From: Hyman Huang(黄勇)
Introduce virDomainDirtyRateCalcFlags to get ready for
adding mode parameter to qemuDomainStartDirtyRateCalc.
Signed-off-by: Hyman Huang(黄勇)
---
include/libvirt/libvirt-domain.h | 13 +
1 file changed, 13 insertions(+)
diff --git
From: Hyman Huang(黄勇)
For any virTypedParameter API normal practice is to use a string
to expose the data, not the rather enum integer value.
So let's drop the virDomainDirtyRateStatus in public header file
and introduce internal enum def qemuMonitorDirtyRateStatus to
describe the dirty page
From: Hyman Huang(黄勇)
Add calc_mode for dirtyrate statistics retured by
virsh domstats --dirtyrate api, also add vcpu dirtyrate
if dirty-ring mode was used in last measurement.
Signed-off-by: Hyman Huang(黄勇)
---
src/libvirt-domain.c | 6 +
src/qemu/qemu_driver.c | 22
From: Hyman Huang(黄勇)
Extend domdirtyrate-calc virsh api with mode option, either
of these three options "page-sampling,dirty-bitmap,dirty-ring"
can be specified when calculating dirty page rate.
Signed-off-by: Hyman Huang(黄勇)
---
docs/manpages/virsh.rst| 7 +--
From: Hyman Huang(黄勇)
v4:
- Rebase the master
- [PATCH v4 1/9]: Refactor dirty page rate calculation status
implementation, display calc_status as string when
'virsh domstats --dirtyrate' api return.
- [PATCH v4 3/9]: Adjust the 'cap check' block before
From: Hyman Huang(黄勇)
Add mode parameter to qemuDomainStartDirtyRateCalc API, 'mode'
option of 'calc-dirty-rate' command was introduced since
qemu >= 6.2.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_driver.c | 3 ++-
src/qemu/qemu_monitor.c | 5 +++--
src/qemu/qemu_monitor.h
From: Hyman Huang(黄勇)
calc-dirty-rate command was introduced since qemu >=5.2.0.
Introduce QEMU_CAPS_CALC_DIRTY_RATE capability definition.
Signed-off-by: Hyman Huang(黄勇)
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
On Mon, 14 Feb 2022 at 17:44, Stefan Hajnoczi wrote:
>
> The following changes since commit cc5ce8b8b6be83e5fe3b668dbd061ad97c534e3f:
>
> Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220210' into
> staging (2022-02-13 20:33:28 +)
>
> are available in the Git repository
When using we still parse the path,
but completely ignore it, replacing any user provided content with
a custom generated path. This makes sense since when undefining the
guest, the code to cleanup NVRAM also uses the same generated path.
Instead of silently ignoring user config, we should
This demonstrates that
/usr/share/OVMF/OVMF_CODE.fd
gets expanded to give a per-VM NVRAM path.
Signed-off-by: Daniel P. Berrangé
---
.../bios-nvram-template.x86_64-latest.args| 37 +++
.../qemuxml2argvdata/bios-nvram-template.xml | 21 +++
There are a mind bending number of possible ways to configure the
firmware with/without NVRAM. Only a small portion are tested and
many error scenarios are silently ignored.
This series attempts to get coverage of every possible XML config
scenario and report explicit errors in all invalid
The virDomainLoaderDef struct contains fields for both and
elements, so it makes sense to parse them in the same method,
just like we'll format them in the same method.
Signed-off-by: Daniel P. Berrangé
---
src/conf/domain_conf.c | 92 ++
1 file
Instead of using XPath, parse the using the XML node and
property helpers so the code is consistent with the parsing of
.
Signed-off-by: Daniel P. Berrangé
---
src/conf/domain_conf.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c
Before creating a NVRAM path, the qemuDomainNVRAMPathGenerate
method checks whether the config is using the old style
firmware approach. This check is redundant in one of the two
callers. By inlining the check into the other caller, it makes
it clearer to understand that the NVRAM path filling is
The QEMU driver will populate the template to the nvram file any time it
sees both the template and nvram paths present. It will auto-generate a
nvram path per-VM if not provided by the user, but only if the loader
is marked R/O.
So with a R/O loader we have these possible scenarios
- No NVRAM
Currently if the firmware attribute is set then we silently
ignore most of the and element configs. This
changes the code so that we always fully parse the and
but then use a post-parse method to explicitly reject
invalid combinations.
Signed-off-by: Daniel P. Berrangé
---
This is to make it explicit that the template only applies to the NVRAM
store, not the main loader binary, even if the loader is writable.
Signed-off-by: Daniel P. Berrangé
---
src/conf/domain_conf.c | 10 +-
src/conf/domain_conf.h | 2 +-
src/qemu/qemu_firmware.c | 8
The following is expected to raise an error:
because no path to the pflash loader is given and there is
no default built-in.
Signed-off-by: Daniel P. Berrangé
---
tests/qemuxml2argvdata/bios-nvram-no-path.err | 1 +
tests/qemuxml2argvdata/bios-nvram-no-path.xml | 19
Signed-off-by: Daniel P. Berrangé
---
src/qemu/qemu_domain.c | 4 ++--
src/qemu/qemu_domain.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index c764f6296c..4e9c845f68 100644
--- a/src/qemu/qemu_domain.c
+++
On Thu, Jan 27, 2022 at 12:00:18PM +0100, Andrea Bolognani wrote:
> This makes it possible to reduce the number of cases we have to
> consider, because 'sles' declares itself to be like 'suse' and
> both 'rhel' and 'centos' declare themselves to be like 'fedora'.
>
> We have to move the check for
On Tue, Feb 15, 2022 at 05:26:51PM +0100, Michal Privoznik wrote:
> When installing openrc init scripts, we take whatever mode the
> generated files are in an copy them under /etc/init.d/. This is
> not ideal, because those files are not executable and they should
> be.
>
> Resolves:
On Tue, Feb 15, 2022 at 21:57 Michal Privoznik wrote:
> When installing openrc init scripts, we take whatever mode the
> generated files are in an copy them under /etc/init.d/. This is
> not ideal, because those files are not executable and they should
> be.
>
> Resolves:
When installing openrc init scripts, we take whatever mode the
generated files are in an copy them under /etc/init.d/. This is
not ideal, because those files are not executable and they should
be.
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/250
Signed-off-by: Michal Privoznik
---
On Tue, Feb 15, 2022 at 16:19:51 +0100, Michal Privoznik wrote:
> The minimal supported version of QEMU is 2.11. And after
> capabilities for older QEMUs were dropped in
> v7.3.0-17-g184de10c1d we have some domaincapsdata/ files that are
> never read. This is because domaincapstest uses
>
The minimal supported version of QEMU is 2.11. And after
capabilities for older QEMUs were dropped in
v7.3.0-17-g184de10c1d we have some domaincapsdata/ files that are
never read. This is because domaincapstest uses
testQemuCapsIterate() which iterates over
qemucapabilitiesdata/caps_*.xml files.
Since libvirt-guests script/service can operate on various URIs and we do
support both socket activation and traditional services, the ordering should be
specified for all the possible sockets and services.
Also remove the Wants= dependency since do not want to start any service. We
cannot know
On 2/15/22 12:12, Martin Kletzander wrote:
> Since libvirt-guests script/service can operate on various URIs and we do
> support both socket activation and traditional services, the ordering should
> be
> specified for all the possible sockets and services.
>
> Also remove the Wants= dependency
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 12 ++--
src/qemu/qemu_capabilities.h | 4 ++--
tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 2 --
tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 2 --
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 -
tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 1 -
Some version checks no longer make sense as the minimum supported qemu
is now qemu-3.1.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index
Upcoming patches will raise the minimum required qemu version to 3.1.
Signed-off-by: Peter Krempa
---
.../caps_2.12.0.aarch64.replies | 19577 -
.../caps_2.12.0.aarch64.xml | 329 -
.../caps_2.12.0.ppc64.replies | 23072
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 -
tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 1 -
Starting with qemu-3.1 we always have the '-overcommit' argument and use
it instead of '-realtime'. Remove the capability check and fix all
fake-caps tests.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c| 10 ++
Upcoming patches will raise the minimum required qemu version to 3.1.
Signed-off-by: Peter Krempa
---
.../caps_2.11.0.s390x.replies | 18237 ---
.../caps_2.11.0.s390x.xml | 2593 --
.../caps_2.11.0.x86_64.replies| 19525
All qemu versions now support FD passing either directly or via FDset.
Assume that we always have this capability so that we can simplify
chardev handling in many cases.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c| 14 +++---
As of April 23 2022, Ubuntu 20.04 will be out for two years, which means
we no longer have to support Ubuntu 18.04 along with qemu-2.11 shipped
with it.
This then brings the minimum qemu version we have to support to
qemu-3.1:
Debian 10/Stable: 3.1
OpenSUSE Leap 15.3: 5.2
Ubuntu
All supported QEMUs now accept werror/rerror as argument for the
frontend disk device, so we can remove the old code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 34 +++---
src/qemu/qemu_command.h | 3 +--
src/qemu/qemu_hotplug.c | 3 +--
3 files
The flag was based on a version check which no longer made sense. Remove
the flag by replacing it's only use by an arch-check which is equivalent
at this point.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 10 ++
src/qemu/qemu_capabilities.h
Upcoming patches will raise the minimum required qemu version to 3.1.
Signed-off-by: Peter Krempa
---
.../cpu-host-model.x86_64-3.0.0.args | 36 ---
.../mlock-off.x86_64-3.0.0.args | 31
.../mlock-on.x86_64-3.0.0.args| 31
Upcoming patches will raise the minimum required qemu version to 3.1.
Signed-off-by: Peter Krempa
---
.../cpu-host-model.x86_64-2.11.0.args | 36 --
...ics-vnc-auto-socket-cfg.x86_64-2.11.0.args | 34 -
...raphics-vnc-auto-socket.x86_64-2.11.0.args | 32
Upcoming patches will raise the minimum required qemu version to 3.1.
Signed-off-by: Peter Krempa
---
.../cpu-host-model.x86_64-2.12.0.args | 36 --
.../disk-error-policy-s390x.s390x-2.12.0.args | 35 --
.../disk-error-policy.x86_64-2.12.0.args | 37
For modern qemu versions we use the presence of 'set-numa-node' qmp
command.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 35bf07142a..43880d24e7 100644
---
As of April 23 2022, Ubuntu 20.04 will be out for two years, which per
our platform support policy means we no longer have to support
Ubuntu 18.04.
Signed-off-by: Peter Krempa
---
ci/containers/ubuntu-1804.Dockerfile | 108 ---
ci/gitlab.yml| 16
Upcoming patches will raise the minimum required qemu version to 3.1.
Signed-off-by: Peter Krempa
---
.../caps_3.0.0.ppc64.replies | 23945
.../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1073 -
.../caps_3.0.0.riscv32.replies| 14919 --
As of April 23 2022, Ubuntu 20.04 will be out for two years, which per
our platform support policy means we no longer have to support
Ubuntu 18.04.
The supported platforms thus will have the following qemu versions:
Debian 10/Stable: 3.1
OpenSUSE Leap 15.3: 5.2
Ubuntu
On Thu, Feb 03, 2022 at 18:23:25 +0100, Michal Prívozník wrote:
> On 2/3/22 15:51, Peter Krempa wrote:
> > This API has the same semantics as 'virDomainQemuMonitorCommand' but
> > accepts file descriptors which are then forwarded to qemu.
> >
> > Signed-off-by: Peter Krempa
> > ---
> >
On Fri, Feb 11, 2022 at 14:49:04 +0100, Kristina Hanicova wrote:
> v1 is here:
> https://listman.redhat.com/archives/libvir-list/2022-January/msg00958.html
>
> diff to v1:
> * rebase onto the current master
>
> (bellow are the ones suggested by Jirka, thanks)
> * removed check if callbacks
Since libvirt-guests script/service can operate on various URIs and we do
support both socket activation and traditional services, the ordering should be
specified for all the possible sockets and services.
Also remove the Wants= dependency since do not want to start any service. We
cannot know
62 matches
Mail list logo
