Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Ani Sinha
On Tue, 8 Mar 2022, Michael S. Tsirkin wrote: > On Tue, Mar 08, 2022 at 10:23:20PM +0530, Ani Sinha wrote: > > On Tue, Mar 8, 2022 at 10:17 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Mar 08, 2022 at 10:15:11PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Tue, 8 Mar 2022, Laine

Re: [libvirt PATCH 0/2] nwfilter cleanups for legacy platforms

2022-03-08 Thread Laine Stump
On 3/8/22 12:52 PM, Daniel P. Berrangé wrote: We have a couple of compatibility hacks to cope with changes in iptables userspace and kernel. These were very long ago so not relevant to our current build platforms. Removing them makes the code clearer. The tests have churn because we were never

Re: REST service for libvirt to simplify SEV(ES) launch measurement

2022-03-08 Thread Tobin Feldman-Fitzthum
On 3/3/22 12:40 PM, Daniel P. Berrangé wrote: > On Fri, Feb 25, 2022 at 04:11:27PM -0500, Tobin Feldman-Fitzthum wrote: >> Some comments on the example protocol stuff >> >> On 2/23/22 1:38 PM, Dov Murik wrote: >>> +cc Tobin, James >>> >>> On 23/02/2022 19:28, Daniel P. Berrangé wrote:

Re: REST service for libvirt to simplify SEV(ES) launch measurement

2022-03-08 Thread Tobin Feldman-Fitzthum
On 3/3/22 12:20 PM, Daniel P. Berrangé wrote: > On Fri, Feb 25, 2022 at 03:10:35PM -0500, Tobin Feldman-Fitzthum wrote: >> >> >> On 2/24/22 7:26 AM, Daniel P. Berrangé wrote: >>> On Wed, Feb 23, 2022 at 03:33:22PM -0500, Tobin Feldman-Fitzthum wrote: On 2/23/22 1:38 PM, Dov Murik

[libvirt PATCH 1/2] nwfilter: drop support for legacy iptables match syntax

2022-03-08 Thread Daniel P . Berrangé
Long ago we adapted to iptables changes by introducing support for '-m conntrack': commit 06844ccbaa8544d7d08d568aff37bc4e3648f304 Author: Stefan Berger Date: Tue Aug 6 20:30:46 2013 -0400 nwfilter: Use -m conntrack rather than -m state Since iptables version 1.4.16 '-m state

[libvirt PATCH 2/2] nwfilter: drop support for legacy iptables conntrack direction

2022-03-08 Thread Daniel P . Berrangé
Long ago we adapted to Linux kernel changes which inverted the behaviour of the conntrack --ctdir setting: commit a6a04ea47a8143ba46150889d8dae1c861df6389 Author: Stefan Berger Date: Wed May 15 21:02:11 2013 -0400 nwfilter: check for inverted ctdir Linux netfilter at some point

[libvirt PATCH 0/2] nwfilter cleanups for legacy platforms

2022-03-08 Thread Daniel P . Berrangé
We have a couple of compatibility hacks to cope with changes in iptables userspace and kernel. These were very long ago so not relevant to our current build platforms. Removing them makes the code clearer. The tests have churn because we were never properly testing this aspect in the past Daniel

Re: [libvirt PATCH v2 0/6] Add support for 'blob' to virtio video device

2022-03-08 Thread Jonathon Jongsma
ping On 2/24/22 2:47 PM, Jonathon Jongsma wrote: Add support to libvirt for the 'blob' option for virtio video devices in qemu. Also do a little preparatory refactoring of the video device xml parsing code. Changes in v2: - Added some basic documentation - add a qemu capability - Make

[libvirt PATCH v3] qemu: support multiqueue for vdpa net device

2022-03-08 Thread Jonathon Jongsma
The vdpa device supports multiqueue, so remove the restriction from qemuDomainValidateActualNetDef() that prevents us from using this functionality. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2024406 Signed-off-by: Jonathon Jongsma --- Changes in v3: - Do not set the model type in

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Michael S. Tsirkin
On Tue, Mar 08, 2022 at 10:23:20PM +0530, Ani Sinha wrote: > On Tue, Mar 8, 2022 at 10:17 PM Michael S. Tsirkin wrote: > > > > On Tue, Mar 08, 2022 at 10:15:11PM +0530, Ani Sinha wrote: > > > > > > > > > On Tue, 8 Mar 2022, Laine Stump wrote: > > > > > > > Aha! the domain of qemu-de...@nongnu.org

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Michael S. Tsirkin
On Tue, Mar 08, 2022 at 10:15:49PM +0530, Ani Sinha wrote: > > Change log: > v2: rebased the patchset. Laine's response is appended at the end. > > I am re-introducing the patchset for which got > reverted here few months back: > > https://www.spinics.net/linux/fedora/libvir/msg224089.html >

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Ani Sinha
On Tue, Mar 8, 2022 at 10:17 PM Michael S. Tsirkin wrote: > > On Tue, Mar 08, 2022 at 10:15:11PM +0530, Ani Sinha wrote: > > > > > > On Tue, 8 Mar 2022, Laine Stump wrote: > > > > > Aha! the domain of qemu-de...@nongnu.org was incorrect in the original > > > send > > > (it was "nognu.org"), so

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Michael S. Tsirkin
On Tue, Mar 08, 2022 at 10:15:11PM +0530, Ani Sinha wrote: > > > On Tue, 8 Mar 2022, Laine Stump wrote: > > > Aha! the domain of qemu-de...@nongnu.org was incorrect in the original send > > (it was "nognu.org"), so none of this thread was making it to that list. > > > Not to give any excuses

[libvirt] [PATCH RESEND v2 4/4] NEWS: document new acpi pci hotplug config option

2022-03-08 Thread Ani Sinha
Added the following new libvirt conf option to the release note to indicate their availability with the next release: Signed-off-by: Ani Sinha --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index a5b6106bc2..e474b32e69 100644 ---

[libvirt] [PATCH RESEND v2 3/4] qemu: command: add support for acpi-bridge-hotplug feature

2022-03-08 Thread Ani Sinha
This change adds backend qemu command line support for new libvirt global feature 'acpi-bridge-hotplug'. This option can be used as following: The '' sub-element under '' is also newly introduced. 'acpi-bridge-hotplug' turns on the following command line option to qemu for x86

[libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Ani Sinha
Change log: v2: rebased the patchset. Laine's response is appended at the end. I am re-introducing the patchset for which got reverted here few months back: https://www.spinics.net/linux/fedora/libvir/msg224089.html The reason for the reversal was that there seemed to be some

[libvirt] [PATCH RESEND v2 2/4] conf: introduce support for acpi-bridge-hotplug feature

2022-03-08 Thread Ani Sinha
This change introduces a new libvirt sub-element under that can be used to configure all pci related features. Currently the only sub-sub element supported by this sub-element is 'acpi-bridge-hotplug' as shown below: The above option is only available for the QEMU driver, for x86

[libvirt] [PATCH RESEND v2 1/4] qemu: capablities: detect acpi-pci-hotplug-with-bridge-support

2022-03-08 Thread Ani Sinha
qemu added support for i440fx specific global boolean flag PIIX4_PM.acpi-pci-hotplug-with-bridge-support around version 2.1. This flag is enabled by default. When disabled, it turns off acpi pci hotplug for cold plugged pci bridges in i440fx machine types. Very recently, in qemu version 6.1,

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Ani Sinha
On Tue, 8 Mar 2022, Laine Stump wrote: > Aha! the domain of qemu-de...@nongnu.org was incorrect in the original send > (it was "nognu.org"), so none of this thread was making it to that list. Not to give any excuses but this happened because on Qemu side I never have to type this manually.

Re: [PATCH 03/17] docs: formatsnapshot: Convert to 'rst'

2022-03-08 Thread Peter Krempa
On Mon, Mar 07, 2022 at 18:56:22 +0100, Ján Tomko wrote: > On a Monday in 2022, Peter Krempa wrote: > > Signed-off-by: Peter Krempa > > --- > > docs/formatsnapshot.html.in | 352 > > docs/formatsnapshot.rst | 297 ++ > >

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Michael S. Tsirkin
On Tue, Mar 08, 2022 at 09:57:04PM +0530, Ani Sinha wrote: > > > On Tue, Mar 8, 2022 at 21:21 Laine Stump wrote: > > Aha! the domain of qemu-de...@nongnu.org was incorrect in the original > send (it was "nognu.org"), so none of this thread was making it to that > list. I've

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Ani Sinha
On Tue, Mar 8, 2022 at 21:21 Laine Stump wrote: > Aha! the domain of qemu-de...@nongnu.org was incorrect in the original > send (it was "nognu.org"), so none of this thread was making it to that > list. I've corrected it in this message, but interested parties from > qemu-devel will need to look

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Laine Stump
Aha! the domain of qemu-de...@nongnu.org was incorrect in the original send (it was "nognu.org"), so none of this thread was making it to that list. I've corrected it in this message, but interested parties from qemu-devel will need to look on the libvir-list archives for the actual patch

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-08 Thread Laine Stump
On 3/8/22 1:39 AM, Ani Sinha wrote: Changelog: v2 - rebased the patch series to latest master. I am re-introducing the patchset for which got reverted here few months back: https://www.spinics.net/linux/fedora/libvir/msg224089.html The reason for the reversal was that there seemed to be some

Re: [PATCH 0/2] libvirt-qemu: Two simple fixes

2022-03-08 Thread Ján Tomko
On a Tuesday in 2022, Michal Privoznik wrote: *** BLURB HERE *** Michal Prívozník (2): libvirt-qemu: Don't allow NULL cmd in virDomainQemuMonitorCommandWithFiles() libvirt-qemu: Fix capitalization of QEMU src/libvirt-qemu.c | 24 +--- 1 file changed, 13 insertions(+),

[PATCH 0/2] libvirt-qemu: Two simple fixes

2022-03-08 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (2): libvirt-qemu: Don't allow NULL cmd in virDomainQemuMonitorCommandWithFiles() libvirt-qemu: Fix capitalization of QEMU src/libvirt-qemu.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) -- 2.34.1

[PATCH 1/2] libvirt-qemu: Don't allow NULL cmd in virDomainQemuMonitorCommandWithFiles()

2022-03-08 Thread Michal Privoznik
Nothing in daemon code is prepared for the command in virDomainQemuMonitorCommandWithFiles() to be NULL. In fact, the client side doesn't expect this either as our RPC describes the argument as: remote_nonnull_string cmd; Validate the argument in the public API implementation.

[PATCH 2/2] libvirt-qemu: Fix capitalization of QEMU

2022-03-08 Thread Michal Privoznik
In plenty of places we mention qemu, Qemu but the correct form is all capitals. Signed-off-by: Michal Privoznik --- src/libvirt-qemu.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/libvirt-qemu.c b/src/libvirt-qemu.c index

Re: [libvirt PATCH] spec: Move virkey* manual pages from -daemon to -client

2022-03-08 Thread Pavel Hrdina
On Thu, Jan 27, 2022 at 03:47:56PM +0100, Andrea Bolognani wrote: > The documentation included in these manual pages is mostly useful > to users of the 'send-key' virsh command, and the virsh manual > page refers to them, so it makes more sense to install them along > with virsh instead of