Re: [PATCH] Allow VM to read sysfs PCI config, revision files

On Thu, May 19, 2022 at 3:04 PM Michal Prívozník wrote: > > On 5/19/22 08:09, Christian Ehrhardt wrote: > > On Thu, May 12, 2022 at 3:27 PM Max Goodhart wrote: > >> > >> Oops, I didn't intend for the commit author email to be > >> git...@chromakode.com here. Would you please use

Re: [libvirt PATCH 69/80] qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Finish phase

On Thu, May 12, 2022 at 17:20:34 +0200, Peter Krempa wrote: > On Tue, May 10, 2022 at 17:21:30 +0200, Jiri Denemark wrote: > > Everything was already done in the normal Finish phase and vCPUs are > > running. We just need to wait for all remaining data to be transferred. > > > > Signed-off-by:

Re: [libvirt PATCH 68/80] qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Prepare phase

On Thu, May 12, 2022 at 17:16:32 +0200, Peter Krempa wrote: > On Tue, May 10, 2022 at 17:21:29 +0200, Jiri Denemark wrote: > > The QEMU process is already running, all we need to do is to call > > migrate-recover QMP command. Except for some checks and cookie handling, > > of course. > > > >

Re: [libvirt PATCH 66/80] qemu: Handle incoming migration in qemuMigrationAnyConnectionClosed

On Thu, May 12, 2022 at 17:09:27 +0200, Peter Krempa wrote: > On Tue, May 10, 2022 at 17:21:27 +0200, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > src/qemu/qemu_migration.c | 10 ++ > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git

[PATCH v2] remote_daemon: Don't run virStateCleanup() if virStateReload() is still running

When a SIGHUP is received a thread is spawned that runs virStateReload(). However, if SIGINT is received while the former thread is still running then we may get into problematic situation: the cleanup code in main() sees drivers initialized and thus calls virStateCleanup(). So now we have two

Re: [PATCH] remote_daemon: Don't run virStateCleanup() if virStateReload() is still running

On 5/19/22 15:27, Martin Kletzander wrote: > On Mon, Apr 25, 2022 at 11:06:06AM +0200, Michal Privoznik wrote: >> When a SIGHUP is received a thread is spawned that runs >> virStateReload(). However, if SIGINT is received while the former >> thread is still running then we may get into problematic

Re: [PATCH] remote_daemon: Don't run virStateCleanup() if virStateReload() is still running

On Mon, Apr 25, 2022 at 11:06:06AM +0200, Michal Privoznik wrote: When a SIGHUP is received a thread is spawned that runs virStateReload(). However, if SIGINT is received while the former thread is still running then we may get into problematic situation: the cleanup code in main() sees drivers

Re: [libvirt PATCH 59/80] qemu: Implement VIR_MIGRATE_POSTCOPY_RESUME for Confirm phase

On Thu, May 12, 2022 at 16:27:24 +0200, Peter Krempa wrote: > On Tue, May 10, 2022 at 17:21:20 +0200, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > > --- > > src/qemu/qemu_migration.c | 49 +-- > > 1 file changed, 32 insertions(+), 17 deletions(-) >

Re: [PATCH] Allow VM to read sysfs PCI config, revision files

On 5/19/22 08:09, Christian Ehrhardt wrote: > On Thu, May 12, 2022 at 3:27 PM Max Goodhart wrote: >> >> Oops, I didn't intend for the commit author email to be >> git...@chromakode.com here. Would you please use c...@chromakode.com as the >> author of the patch? > > Yeah I can amend that (and

Re: [libvirt PATCH 2/5] src: QemuMonitorCommandWithFiles: report error when fd passing is unsupported

On Wed, May 18, 2022 at 04:00:57PM +0200, Ján Tomko wrote: The result of the <= 0 comparison was assigned to 'rc', rendering the if (rc == 0) condition dead code. Signed-off-by: Ján Tomko --- src/libvirt-qemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] apparmor: Add support for dbus chardev

Commit 7648e40da50e added support for dbus chardev but forgot to handle it in AppArmor code. Signed-off-by: Martin Kletzander --- Pushed under the build-breaker rule. src/security/security_apparmor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/security/security_apparmor.c

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

Hi, > Hmm, ok ... but maybe I should call the new enum HotKeyMod instead of > GrabMod to make it more obvious that it is something different? Looks good to me. take care, Gerd

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

On 19/05/2022 12.48, Gerd Hoffmann wrote: Hi, Oh well, I just noticed that we already have a GrabToggleKeys enum in qapi/common.json ... I wonder whether I should try to use that instead? It seems to be used in a slightly different context, though, if I get that right ...?

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

Hi, > Oh well, I just noticed that we already have a GrabToggleKeys enum in > qapi/common.json ... I wonder whether I should try to use that instead? It > seems to be used in a slightly different context, though, if I get that > right ...? qemu/ui/input-linux.c Those switch the input routing

Re: [libvirt PATCH v4 00/11] Add QEMU "-display dbus" support

On 5/13/22 20:38, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > This series implements supports for the QEMU "-display dbus" support, > available > since 7.0. > > By default, libvirt will start a private VM bus (sharing and reusing the > existing "vmstate" VM bus &

Plans for the next release

We are getting close to the next release of libvirt. To aim for the release on June 01 I suggest entering the freeze on Wednesday May 25 in the evening and tagging RC2 on Monday May 30. I hope this works for everyone. Jirka

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

On 19/05/2022 09.51, Daniel P. Berrangé wrote: On Thu, May 19, 2022 at 09:27:08AM +0200, Thomas Huth wrote: On 19/05/2022 09.08, Thomas Huth wrote: On 19/05/2022 08.39, Thomas Huth wrote: On 18/05/2022 17.08, Markus Armbruster wrote: Thomas Huth writes: The "-display sdl" option still

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

On 19/05/2022 10.57, Markus Armbruster wrote: Daniel P. Berrangé writes: On Thu, May 19, 2022 at 09:27:08AM +0200, Thomas Huth wrote: On 19/05/2022 09.08, Thomas Huth wrote: On 19/05/2022 08.39, Thomas Huth wrote: On 18/05/2022 17.08, Markus Armbruster wrote: Thomas Huth writes: The

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

Daniel P. Berrangé writes: > On Thu, May 19, 2022 at 09:27:08AM +0200, Thomas Huth wrote: >> On 19/05/2022 09.08, Thomas Huth wrote: >> > On 19/05/2022 08.39, Thomas Huth wrote: >> > > On 18/05/2022 17.08, Markus Armbruster wrote: >> > > > Thomas Huth writes: >> > > > >> > > > > The "-display

Re: [PATCH 0/5] Some docs updates

On Sat, May 07, 2022 at 09:17:35AM +0800, Han Han wrote: > Han Han (5): > docs: apps: Add desktop app gnome-boxes > docs: formatdomain: Add the introduced versions of net rss attrs > news: Add news for rss and rss_hash_report attributes > docs: drivers: Mention KVM/HVF in the link of qemu

Re: [PATCH 1/5] docs: apps: Add desktop app gnome-boxes

On Sat, May 07, 2022 at 09:17:36AM +0800, Han Han wrote: > +`gnome-boxes `__ > + A gnome application to access virtual machines. The correct URL according to [1] is [2] (which currently redirects to [3]). I've changed that as well as spelling

Re: [PATCH] remoteOpenConn: Pass correct variable to virConnectSetIdentity()

On Thu, May 19, 2022 at 10:00:26AM +0200, Michal Privoznik wrote: > The remoteOpenConn() function was refactored recently. As a part > of that new variable @newconn was introduced which holds > virConnect object as it's being gradually constructed throughout > the function. At the very end, when

[PATCH] remoteOpenConn: Pass correct variable to virConnectSetIdentity()

The remoteOpenConn() function was refactored recently. As a part of that new variable @newconn was introduced which holds virConnect object as it's being gradually constructed throughout the function. At the very end, when everything succeeded the variable is stolen into passed @conn. However,

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

On Thu, May 19, 2022 at 09:27:08AM +0200, Thomas Huth wrote: > On 19/05/2022 09.08, Thomas Huth wrote: > > On 19/05/2022 08.39, Thomas Huth wrote: > > > On 18/05/2022 17.08, Markus Armbruster wrote: > > > > Thomas Huth writes: > > > > > > > > > The "-display sdl" option still uses a hand-crafted

Re: [PATCH v2 2/2] cpu_ppc64: add support for host-model on POWER10

On Tue, May 17, 2022 at 05:32:56PM -0300, Daniel Henrique Barboza wrote: > On 5/12/22 04:52, Andrea Bolognani wrote: > > Don't forget to add the new test case to qemuxml2xmltest too. > > > > It would be great if, as a follow-up, you could look into converting > > these test cases to the

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

Thomas Huth writes: > On 18/05/2022 17.08, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> The "-display sdl" option still uses a hand-crafted parser for its >>> parameters since we didn't want to drag an interface we considered >>> somewhat flawed into the QAPI schema. Since the flaws

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

On 19/05/2022 09.08, Thomas Huth wrote: On 19/05/2022 08.39, Thomas Huth wrote: On 18/05/2022 17.08, Markus Armbruster wrote: Thomas Huth writes: The "-display sdl" option still uses a hand-crafted parser for its parameters since we didn't want to drag an interface we considered somewhat

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

On 19/05/2022 08.39, Thomas Huth wrote: On 18/05/2022 17.08, Markus Armbruster wrote: Thomas Huth writes: The "-display sdl" option still uses a hand-crafted parser for its parameters since we didn't want to drag an interface we considered somewhat flawed into the QAPI schema. Since the

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

On 18/05/2022 17.41, Eric Blake wrote: On Wed, May 18, 2022 at 03:44:45PM +0200, Thomas Huth wrote: The "-display sdl" option still uses a hand-crafted parser for its parameters since we didn't want to drag an interface we considered somewhat flawed into the QAPI schema. Since the flaws are

Re: [PATCH v2 2/3] ui: Switch "-display sdl" to use the QAPI parser

On 18/05/2022 17.08, Markus Armbruster wrote: Thomas Huth writes: The "-display sdl" option still uses a hand-crafted parser for its parameters since we didn't want to drag an interface we considered somewhat flawed into the QAPI schema. Since the flaws are gone now, it's time to QAPIfy.

Re: [PATCH] Allow VM to read sysfs PCI config, revision files

On Thu, May 12, 2022 at 3:27 PM Max Goodhart wrote: > > Oops, I didn't intend for the commit author email to be git...@chromakode.com > here. Would you please use c...@chromakode.com as the author of the patch? Yeah I can amend that (and we see you control that email address). Also since I

Re: [PATCH] Allow VM to read sysfs PCI config, revision files

On Thu, May 12, 2022 at 3:27 PM Max Goodhart wrote: > > From: Max Goodhart Hi Max, thanks for the work to identify and fix this! It is indeed a natural evolution of my 27a9ebf2818 00fbb9e5167 f2cbb94eabd that made the rules so far. Signed-off-by: Christian Ehrhardt > This fixes a blank