Re: [PATCH] qemu: Add vhost-user-blk unix socket to support server mode

2023-03-20 Thread Zhenguo Yao
Peter Krempa 于2023年3月16日周四 21:51写道: > > On Thu, Mar 09, 2023 at 16:58:07 +0800, Zhenguo Yao wrote: > > qemu support server mode when using vhost-user-blk disk. > > Let libvirt to support this. > > Could you please elaborate how you expect to use this? > > I'm asking because server mode comes with

Re: [PATCH 1/2] util: Separate numactl and stubs into different source files

2023-03-20 Thread Martin Kletzander
On Mon, Mar 20, 2023 at 11:50:16AM +, Daniel P. Berrangé wrote: On Mon, Mar 20, 2023 at 12:39:55PM +0100, Martin Kletzander wrote: Fix the build, mainly with clang's optimizations and demonstrate a separation of function implementations. This patch does it only for functions that differ in

Re: [PATCH 0/5] Consistently use 'libvirt.org' instead of 'www.libvirt.org' and update links to subprojects

2023-03-20 Thread Peter Krempa
On Wed, Mar 15, 2023 at 16:44:22 +0100, Andrea Bolognani wrote: > On Wed, Mar 15, 2023 at 01:58:18PM +0100, Peter Krempa wrote: > > Note that the required DNS changes for the subproject pages are not live > > yet. > > > > Peter Krempa (5): > > Use 'libvirt.org' instead of 'www.libvirt.org' > >

Re: [PATCH 0/2] Work around broken clang. Again.

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 03:17:24PM +0100, Michal Prívozník wrote: > On 3/16/23 15:51, Andrea Bolognani wrote: > > On Wed, Mar 15, 2023 at 08:10:26PM +0100, Michal Privoznik wrote: > >> We ran into so many clang bugs recently, that I'm strongly in favor of > >> making it optional and aim on gcc

Re: [PATCH] meson: Work around too strict lld

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 02:54:11PM +0100, Michal Privoznik wrote: > With its version 16.0, the LLVM's linker turned on > --no-undefined-version by default [1]. This breaks how we detect > --version-script= detection, because at the compile time there's > no library built yet that we can use to

Re: [PATCH 0/2] Work around broken clang. Again.

2023-03-20 Thread Michal Prívozník
On 3/16/23 15:51, Andrea Bolognani wrote: > On Wed, Mar 15, 2023 at 08:10:26PM +0100, Michal Privoznik wrote: >> We ran into so many clang bugs recently, that I'm strongly in favor of >> making it optional and aim on gcc only. Debugging these issues burns our >> time needlessly. >> > [...] >> >>

[PATCH] meson: Work around too strict lld

2023-03-20 Thread Michal Privoznik
With its version 16.0, the LLVM's linker turned on --no-undefined-version by default [1]. This breaks how we detect --version-script= detection, because at the compile time there's no library built yet that we can use to make --version-script= happy. To cancel their choice of defaults, pass

Re: [PATCH 1/1] capabilities: reduce scope in virCapabilitiesInitCaches()

2023-03-20 Thread Ján Tomko
On a Monday in 2023, Shaleen Bathla wrote: over-writing a variable in inner while-loop without freeing previous memory leaks it over time. To fix this, we can just change scope of bank variable to the inner loop. Signed-off-by: Shaleen Bathla --- src/conf/capabilities.c | 2 +- 1 file changed,

[PATCH 1/1] capabilities: reduce scope in virCapabilitiesInitCaches()

2023-03-20 Thread Shaleen Bathla
over-writing a variable in inner while-loop without freeing previous memory leaks it over time. To fix this, we can just change scope of bank variable to the inner loop. Signed-off-by: Shaleen Bathla --- src/conf/capabilities.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] util: Separate numactl and stubs into different source files

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 12:39:55PM +0100, Martin Kletzander wrote: > Fix the build, mainly with clang's optimizations and demonstrate a > separation of function implementations. This patch does it only for > functions that differ in implementation based on WITH_NUMACTL but > ideally this would be

[PATCH 0/2] Fix clang build without numactl and without any code/optimization changes

2023-03-20 Thread Martin Kletzander
See 1/2 for details, pipeline for this is here: https://gitlab.com/nertpinx/libvirt/-/pipelines/811802916 Martin Kletzander (2): util: Separate numactl and stubs into different source files Revert "meson: stop CLang doing inter-procedural analysis" meson.build| 20 --

[PATCH 1/2] util: Separate numactl and stubs into different source files

2023-03-20 Thread Martin Kletzander
Fix the build, mainly with clang's optimizations and demonstrate a separation of function implementations. This patch does it only for functions that differ in implementation based on WITH_NUMACTL but ideally this would be done for the WITH_NUMAD and __linux__ parts as well. Signed-off-by:

[PATCH 2/2] Revert "meson: stop CLang doing inter-procedural analysis"

2023-03-20 Thread Martin Kletzander
This reverts commit f9f5ab57189b9c378d1893cf302865ac9b88bbbc. This should not be needed any more thanks to previous commit (util: Separate numactl and stubs into different source files) and future issue should be fixed the same way as in that commit. Signed-off-by: Martin Kletzander ---