Plans for 9.6.0 release (freeze on Wednesday 26 Jul)

2023-07-21 Thread Jiri Denemark
We are getting close to 9.6.0 release of libvirt. To aim for the release on Tuesday 01 Aug I suggest entering the freeze on Wednesday 26 Jul and tagging RC2 on Friday 28 Jul. I hope this works for everyone. Jirka

Re: [PATCH 2/2] qemu_tpm: Try harder to create emulator state

2023-07-21 Thread Ján Tomko
On a Friday in 2023, Michal Privoznik wrote: If a per-domain SWTPM state directory exists but is empty our code still considers it a valid state and skips running 'swtpm_setup' (handled in qemuTPMEmulatorRunSetup()). While we should not try to inspect individual files created by swtpm, we can

Re: [PATCH 1/4] qemu: Generate shorter channel target paths

2023-07-21 Thread Daniel P . Berrangé
On Wed, Jul 12, 2023 at 04:49:53PM +0200, Michal Privoznik wrote: > A device is basically an UNIX socket into guest. > Whatever is sent from the host, appears in the guest and vice > versa. But because of that, the length of the path to the socket > is important (underscored by fact that we

Re: [PATCH 1/2] virfile: Introduce virDirIsEmpty()

2023-07-21 Thread Ján Tomko
On a Friday in 2023, Michal Privoznik wrote: There might be cases where we want to know whether given directory is empty or not. Introduce a helper for that: virDirIsEmpty(). Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virfile.c | 39

Re: [PATCH 0/2] Improve the validation for queues and queue_size

2023-07-21 Thread Michal Prívozník
On 7/21/23 04:36, Han Han wrote: > > Han Han (2): > conf/domain_validate.c: Improve the err for queue validation > conf/domain_validate: Validate the disk queue_size > > src/conf/domain_validate.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > Reviewed-by: Michal

Re: [PATCH] docs: Mention vhostuser for queues and queue_size

2023-07-21 Thread Michal Prívozník
On 7/20/23 10:53, Han Han wrote: > > > On Thu, Jul 20, 2023 at 2:56 PM Michal Prívozník > wrote: > > On 7/20/23 08:22, Han Han wrote: > > These two attributes are supported for vhost-user-blk as well. > > > > Signed-off-by: Han Han

Re: [PATCH 0/4] qemu: generate shorter channel target paths

2023-07-21 Thread Michal Prívozník
On 7/12/23 16:49, Michal Privoznik wrote: > Polite ping. Michal

[PATCH] qemu_domain: Partially validate memory amounts when auto-adding NUMA node

2023-07-21 Thread Michal Privoznik
When automatically adding a NUMA node (qemuDomainDefNumaAutoAdd()) the memory size of the node is computed as: total_memory - sum(memory devices) And we have a nice helper for that: virDomainDefGetMemoryInitial() so it looks logical to just call it. Except, this code runs in post parse

Plans for the next release

2023-07-21 Thread Jiri Denemark
We are getting close to the next release of libvirt. To aim for the release on Aug 01 I suggest entering the freeze on Wednesday Jul 26 and tagging RC2 on Friday Jul 28. I hope this works for everyone. Jirka

[PATCH 0/2] qemu_tpm: Try harder to create emulator state

2023-07-21 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (2): virfile: Introduce virDirIsEmpty() qemu_tpm: Try harder to create emulator state src/libvirt_private.syms | 1 + src/qemu/qemu_tpm.c | 3 ++- src/util/virfile.c | 39 +++ src/util/virfile.h | 3

[PATCH 2/2] qemu_tpm: Try harder to create emulator state

2023-07-21 Thread Michal Privoznik
If a per-domain SWTPM state directory exists but is empty our code still considers it a valid state and skips running 'swtpm_setup' (handled in qemuTPMEmulatorRunSetup()). While we should not try to inspect individual files created by swtpm, we can still consider empty folder as non-existent

[PATCH 1/2] virfile: Introduce virDirIsEmpty()

2023-07-21 Thread Michal Privoznik
There might be cases where we want to know whether given directory is empty or not. Introduce a helper for that: virDirIsEmpty(). Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virfile.c | 39 +++ src/util/virfile.h