/-/pipelines/615807379
macOS 12 job: https://gitlab.com/abologna/libvirt/-/jobs/2895958597
Andrea Bolognani (2):
util: Preserve macOS dyld environment by default
tests: Reset macOS dyld environment
src/util/vircommand.c| 2 ++
tests/qemuxml2argvtest.c | 2 ++
2 files changed, 4
The DYLD_* environment variables on macOS have the same purpose
as the LD_* variables have on Linux. Since we're preserving the
latter by default, it makes sense to do the same for the former
as well.
Signed-off-by: Andrea Bolognani
---
src/util/vircommand.c | 2 ++
1 file changed, 2 insertions
: operation failed: Unable to
find a satisfying vhost-user-gpu
that were showing up on macOS 12 go away.
Signed-off-by: Andrea Bolognani
---
tests/qemuxml2argvtest.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 8933e373f7
On Wed, Aug 10, 2022 at 10:54:16AM -0500, Andrea Bolognani wrote:
> On Wed, Aug 10, 2022 at 05:16:57PM +0200, Christophe de Dinechin wrote:
> > This works. We now have a clean test suite on macOS 12:
> >
> > Ok: 252
> > Expected Fail: 0
> > Fai
On Tue, Aug 09, 2022 at 05:26:28PM +0200, Pavel Hrdina wrote:
> On Tue, Jul 19, 2022 at 04:17:44PM +0200, Andrea Bolognani wrote:
> > +destdir = os.getenv('DESTDIR')
> > +if destdir:
> > +destdir = Path(destdir)
> > +if not destdir.is_absolute():
> &
/archives/libvir-list/2022-July/232929.html
Andrea Bolognani (2):
scripts: Add $DESTDIR support to meson-install-web.py
ci: Fix paths shown in the website
.gitlab-ci.yml | 6 +++---
scripts/meson-install-web.py | 8 ++--
2 files changed, 9 insertions(+), 5 deletions
meson already supports $DESTDIR natively, but in this case
we're using a custom script and so we have to do some extra
work ourselves.
Signed-off-by: Andrea Bolognani
---
scripts/meson-install-web.py | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/scripts/meson
=true
and then take advantage of $DESTDIR support to still be able
to write the HTML files without requiring root privileges.
Reported-by: Martin Kletzander
Signed-off-by: Andrea Bolognani
Reviewed-by: Pavel Hrdina
---
.gitlab-ci.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
On Wed, Aug 10, 2022 at 05:16:57PM +0200, Christophe de Dinechin wrote:
> On 2022-08-10 at 16:29 +02, Andrea Bolognani wrote...
> > We need to mock the function that probes for HVF support.
> >
> > Andrea Bolognani (3):
> > tests: Use domaincapsmock in qemucapabi
On Mon, Aug 08, 2022 at 08:54:14PM +0200, Christophe de Dinechin wrote:
> On Fri, May 06, 2022 at 03:00:14AM -0700, Andrea Bolognani wrote:
> > The other issue is in qemuxml2argvtest:
> >
> > error : virCommandWait:2752 : internal error: Child process
> >(/usr/l
We need to mock the function that probes for HVF support.
Andrea Bolognani (3):
tests: Use domaincapsmock in qemucapabilitiestest
qemu: Make virQEMUCapsProbeHVF() non-static
tests: Mock virQEMUCapsProbeHVF()
src/qemu/qemu_capabilities.c | 4 ++--
src/qemu/qemu_capabilities.h | 2 ++
tests
, and a bunch of error messages along the lines of
In 'tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml':
Offset 7557
Expect [c]
Actual [hvf'/>
Signed-off-by: Andrea Bolognani
---
tests/domaincapsmock.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/domaincapsmoc
We need to do this so that we can mock it in the test suite.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_capabilities.c | 4 ++--
src/qemu/qemu_capabilities.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
This doesn't change anything at the moment, but is necessary
for the upcoming fix.
Signed-off-by: Andrea Bolognani
---
tests/qemucapabilitiestest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/qemucapabilitiestest.c b/tests/qemucapabilitiestest.c
index 79dd358ef4
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
src/qemu/qemu_capabilities.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index f8e70470f6..79ef8b88ef 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src
On Tue, Aug 09, 2022 at 11:34:20AM +0200, Christophe de Dinechin wrote:
> On 9 Aug 2022, at 11:28, Andrea Bolognani wrote:
> > Yeah, this seems to help and the change makes sense to me.
> >
> > I wonder why we didn't run into this much earlier though? As I
> &g
namic
> ++ libvirt_flat_namespace
> + coverage_flags
>),
> )
> --
> 2.37.1
>
>
> Could you please check?
Yeah, this seems to help and the change makes sense to me.
I wonder why we didn't run into this much earlier though? As I
mentioned, the test runs successfu
Instead of duplicating the list of attributes that are not
allowed for some of the IOMMU models, use two separate switch
statements: one for the attributes and one for the address.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_validate.c | 22 +-
1 file changed, 9
-by: Andrea Bolognani
---
docs/kbase/secureboot.rst | 31 ---
1 file changed, 28 insertions(+), 3 deletions(-)
diff --git a/docs/kbase/secureboot.rst b/docs/kbase/secureboot.rst
index 5fa59ad5e2..4340454a7b 100644
--- a/docs/kbase/secureboot.rst
+++ b/docs/kbase
Changes from [v1]:
* document configuration where Secure Boot support is completely
absent, not just inactive;
* explain in more detail how the various firmware features interact
with one another.
[v1] https://listman.redhat.com/archives/libvir-list/2022-August/233449.html
Andrea
-boot feature
to be enabled achieves that result at the cost of some slight
additional verbosity.
Signed-off-by: Andrea Bolognani
---
docs/kbase/secureboot.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/kbase/secureboot.rst b/docs/kbase/secureboot.rst
index 8f151c1f2a..5fa59ad5e2
On Thu, Aug 04, 2022 at 10:29:12AM +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 04, 2022 at 03:32:32AM -0500, Andrea Bolognani wrote:
> > On Wed, Aug 03, 2022 at 05:29:15PM +0100, Daniel P. Berrangé wrote:
> > > On Wed, Aug 03, 2022 at 06:15:24PM +0200, Andr
On Wed, Aug 03, 2022 at 05:29:15PM +0100, Daniel P. Berrangé wrote:
> On Wed, Aug 03, 2022 at 06:15:24PM +0200, Andrea Bolognani wrote:
> >
> >
> > +
> >
> >
> >
>
> If we want secureboot disabled, this looks wrong.
-boot feature
to be enabled achieves that result at the cost of some slight
additional verbosity.
Signed-off-by: Andrea Bolognani
---
docs/kbase/secureboot.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/kbase/secureboot.rst b/docs/kbase/secureboot.rst
index 8f151c1f2a..5fa59ad5e2
On Tue, Aug 02, 2022 at 09:03:01AM +0200, Michal Prívozník wrote:
> On 8/1/22 18:10, Andrea Bolognani wrote:
> > On Fri, Jul 29, 2022 at 09:42:13AM +0200, Michal Privoznik wrote:
> >> +++ b/tests/testutilsqemu.c
> >> @@ -150,12 +150,13 @@ bool
> >> virTPMSwtpm
rdcoded capabilities. Would it make sense to extend
this so that it's possible to control things as the test case level,
so that we can have coverage for things like e.g. trying to use TPM
1.2 when the swtpm binary only supports TPM 2.0?
That'd all be follow-up work, of course. Your change is g
n which tries to execute it so that
> predictable result is returned.
>
> Signed-off-by: Michal Privoznik
> ---
> tests/testutilsqemu.c | 18 ++
> 1 file changed, 18 insertions(+)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
On Fri, Jul 29, 2022 at 09:42:11AM +0200, Michal Privoznik wrote:
> In virtpm.h there are two functions exposed for querying swtpm
> and swtpm_setup capabilieis: virTPMSwtpmCapsGet() and
*capabilities
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
On Fri, Jul 22, 2022 at 05:23:15PM +0100, Daniel P. Berrangé wrote:
> This is to enable SEV builds of UEFI which provide only a single CODE.fd
> file, with not VARS.fd.
This is a significant enough user-visible change that a NEWS entry
for it would be warranted.
--
Andrea Bolognani / R
ess = VIR_TRISTATE_BOOL_NO;
+} else if (flash->mode == QEMU_FIRMWARE_FLASH_MODE_STATELESS) {
+def->os.loader->stateless = VIR_TRISTATE_BOOL_YES;
}
VIR_DEBUG("decided on firmware '%s' template '%s' NVRAM '%s'",
--
Andrea Bolognani / Red Hat / Virtualization
printing out
Only EFI firmware permits NVRAM
is a bit confusing, since the user has not directly mentioned NVRAM
anywhere. Something along the lines of
virReportError(VIR_ERR_XML_DETAIL,
_("Firmware type '%s' only supports stateless operations"),
virDomainOsDefFirmwareTypeToString(def->os.firmware));
would be more understandable and actionable, I think.
--
Andrea Bolognani / Red Hat / Virtualization
rs/debian-10-cross-s390x.Dockerfile
> delete mode 100644 ci/containers/debian-10.Dockerfile
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
ab/containers.yml | 3 ++-
> ci/manifest.yml | 5 ++---
> 3 files changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
: false
This makes for a cleaner diff, but you could also optimize for a more
minimal manifest and change the entry to
alpine-315: x86_64
instead.
Either way,
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
has
happened, as in that case you can just run 'lcitool manifest' and
have the tool dutifully delete the now-unused files for you instead
of having to hunt them down manually :)
--
Andrea Bolognani / Red Hat / Virtualization
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_alias.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c
index 7efd91051e..7b91fe3141 100644
--- a/src/qemu/qemu_alias.c
+++ b/src/qemu/qemu_alias.c
@@ -597,6 +597,14
Note that we can only do this for intel-iommu and virtio-iommu,
which are configured using -device; smmuv3 is configured using
a machine type property, so there's no room on the command line
for an alias in that case.
https://bugzilla.redhat.com/show_bug.cgi?id=2108483
Signed-off-by: Andrea
Signed-off-by: Andrea Bolognani
---
src/conf/schemas/domaincommon.rng | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/conf/schemas/domaincommon.rng
b/src/conf/schemas/domaincommon.rng
index 2f07c25430..d15dd33f47 100644
--- a/src/conf/schemas/domaincommon.rng
+++ b/src/conf/schemas
Andrea Bolognani (3):
schema: Allow IOMMU devices to have aliases
qemu: Assign default alias to IOMMU devices
qemu: Add IOMMU device alias to command line
src/conf/schemas/domaincommon.rng | 3 +++
src/qemu/qemu_alias.c | 10
meson already supports $DESTDIR natively, but in this case
we're using a custom script and so we have to do some extra
work ourselves.
Signed-off-by: Andrea Bolognani
---
scripts/meson-install-web.py | 13 +
1 file changed, 13 insertions(+)
diff --git a/scripts/meson-install-web.py
This will be useful later.
Signed-off-by: Andrea Bolognani
---
scripts/meson-install-web.py | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/scripts/meson-install-web.py b/scripts/meson-install-web.py
index a03f8523cd..fdf407ba33 100755
--- a/scripts/meson-install
=true
and then take advantage of $DESTDIR support to still be able
to write the HTML files without requiring root privileges.
Reported-by: Martin Kletzander
Signed-off-by: Andrea Bolognani
---
.gitlab-ci.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/.gitlab-ci.yml b
Compare
https://abologna.gitlab.io/-/libvirt/-/jobs/2741293181/artifacts/website/manpages/virtqemud.html#files
with
https://libvirt.org/manpages/virtqemud.html#files
Andrea Bolognani (3):
scripts: Port meson-install-web.py to pathlib
scripts: Add $DESTDIR support to meson-install
On Mon, Jun 27, 2022 at 11:07:35AM +0100, Daniel P. Berrangé wrote:
> On Mon, Jun 27, 2022 at 12:00:59PM +0200, Gerd Hoffmann wrote:
> > On Thu, Jun 23, 2022 at 06:14:12PM +0200, Andrea Bolognani wrote:
> > > The main motivation behind this series was making it as simple as
&g
Provide simple recipes for the most common high-level tasks.
Signed-off-by: Andrea Bolognani
---
docs/kbase/index.rst | 3 ++
docs/kbase/meson.build| 1 +
docs/kbase/secureboot.rst | 102 ++
3 files changed, 106 insertions(+)
create mode 100644
going away for no apparent reason.
A more user-friendly approach is to produce meaningful error
messages in those scenarios. As a first step towards that goal,
stop conditionally parsing information.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 38
be able to
automatically enable secure-boot when enrolled-keys=yes. Since
the combination never resulted in a working configuration, the
chances of this causing real-world VMs to disappear are
extremely low.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c| 7
Regardless of whether firmware autoselection is in use, we
still want to parse the list of requested features. Doing this
will allow us to produce better error messages.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 28 ++--
1 file changed, 14 insertions
All the data in the element ends up in the same struct
as that coming from the element, so it makes sense to
have a single entry point for parsing an XML document into a
virDomainLoaderDef instance.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 22 +-
1 file
in the
original approach to firmware autoselection, so we want to
keep that working.
Anything else should result in a descriptive error.
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/327
Signed-off-by: Andrea Bolognani
---
src/conf/domain_validate.c| 48
of existings VMs and will not prevent
legitimate guest code from running.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_firmware.c| 2 ++
.../firmware-auto-efi-enrolled-keys.x86_64-latest.args | 1 +
.../qemuxml2argvdata/firmware-auto-efi
The latter doesn't make sense without the former, so make that
visible in the XML.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 10 ++
.../firmware-auto-efi-enrolled-keys.x86_64-latest.xml | 1 +
2 files changed, 11 insertions(+)
diff
Currently, the lack of a element results in the
element being completely ignored, but this is unnecessarily
limiting: even when firmware autoselection is in use, it should
be possible for the user to specify a custom path for the NVRAM
file.
Signed-off-by: Andrea Bolognani
---
src/conf
When testing firmware selection, we don't really care about any
of the hardware assigned to the VM, and in fact it's better to
keep it as minimal as possible to make sure that the focus
remains on the firmware bits.
Signed-off-by: Andrea Bolognani
---
.../firmware-auto-bios.x86_64-latest.args
There are currently no failure scenarios for the function, but
we're about to add one.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3977b5040f
Pure code movement, needed to prepare for upcoming changes.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 57 +-
1 file changed, 29 insertions(+), 28 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
No sane firmware build will fail this check, but just to be on
the safe side let's check anyway.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_firmware.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
Signed-off-by: Andrea Bolognani
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 9a92fb4fcb..63e0388e47 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -29,6 +29,11 @@ v8.5.0 (unreleased)
* **Improvements**
+ * conf: Improved firmware autoselection
We're going to start passing multiple nodes to the function in
a moment, so we need a more specific name.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf
the use of
custom NVRAM paths with firmware autoselection in an upcoming
commit.
Signed-off-by: Andrea Bolognani
---
tests/qemuxml2argvdata/firmware-auto-bios.xml | 1 -
.../firmware-auto-efi-loader-secure.x86_64-latest.args | 2 +-
tests/qemuxml2argvdata/firmware-auto-efi
Note that some of these new tests are displaying incorrect or
suboptimal behavior. When we address those in upcoming patches,
this will be highlighted by changes in the test data.
Signed-off-by: Andrea Bolognani
---
...-auto-efi-enrolled-keys.x86_64-latest.args | 35
This makes the function more consistent with
virDomainLoaderDefParseXML() by preferring the virXMLProp
class of functions to XPath access.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 49 --
1 file changed, 28 insertions(+), 21 deletions
This makes it explicit that there are two possible scenarios
(whether or not firmware autoselection is in use) and will make
upcoming changes cleaner to implement.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_validate.c | 28 +++-
1 file changed, 15 insertions
The previous name was identical, modulo the case, to the
completely unrelated virDomainNVRAMDefParseXML().
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
Group all tests related to firmware selection together and give
them consistent names that leave room for further tests to be
added in an upcoming commit.
Signed-off-by: Andrea Bolognani
---
tests/qemusecuritytest.c | 6 +--
... => firmware-auto-bios.x86_64-latest.a
This currently has not effect whatsoever, so it's just cluttering
the input files.
We're going to add specific handling for this scenario, as well
as a test case covering it, in an upcoming commit.
Signed-off-by: Andrea Bolognani
---
tests/qemuxml2argvdata/firmware-auto-bios.xml
It belongs to virDomainLoaderDefParseXMLNvram(), where the other
parts of the element are handled.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index
useful to keep it
around.
Signed-off-by: Andrea Bolognani
---
.../bios-nvram-os-interleave.xml | 40 --
.../bios-nvram-os-interleave.xml | 52 ---
tests/qemuxml2xmltest.c | 1 -
3 files changed, 93 deletions(-)
delete mode
Signed-off-by: Andrea Bolognani
---
src/conf/domain_validate.c| 7 +++
...ware-manual-efi-features.x86_64-latest.err | 1 +
.../firmware-manual-efi-features.xml | 21 +++
tests/qemuxml2argvtest.c | 1 +
4 files changed, 30
The pci-bridge-many-disks test case is not related to firmware
handling at all, so we can trim it without losing any coverage.
Signed-off-by: Andrea Bolognani
---
tests/qemuxml2argvdata/pci-bridge-many-disks.args | 1 -
tests/qemuxml2argvdata/pci-bridge-many-disks.xml | 1 -
tests
When the 'type' attribute is present we'd end up overwriting
this value via virDomainStorageSourceParse(). Moving this
assignment makes the current code clearer and will also help
with upcoming changes.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1
This simplifies the test data without negatively impacting test
coverage.
Signed-off-by: Andrea Bolognani
---
.../virtio-iommu-aarch64.aarch64-latest.args| 2 +-
tests/qemuxml2argvdata/virtio-iommu-aarch64.xml | 6 ++
.../virtio-iommu-aarch64.aarch64-latest.xml
/-/commits/firmware
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/571485540
Andrea Bolognani (28):
tests: Remove firmware bits from unrelated tests
tests: Use firmware autoselection on aarch64
tests: Drop bios-nvram-os-interleave test
tests: Rename and reorganize firmware tes
p it. But at least
it made us spot an issue in our CI, so it wasn't all for nothing :)
--
Andrea Bolognani / Red Hat / Virtualization
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
src/qemu/qemu_firmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c
index 1dd5c09636..c8f462bfcf 100644
--- a/src/qemu/qemu_firmware.c
+++ b/src/qemu
sensible course of action is to keep the
current checks in place, effectively preventing the use of secure
boot on aarch64, until Someone™ implements TZ support across the
stack.
--
Andrea Bolognani / Red Hat / Virtualization
On Fri, May 06, 2022 at 03:00:14AM -0700, Andrea Bolognani wrote:
> I'm trying to enable CI coverage for macOS 12, but I'm running into a
> couple of issues that I'm not sure how to handle.
>
> Note that the test suite currently passes on macOS 11[1], so these
> failures have to b
Even when the os.loader element is absent, we still have to
validate that the user is not attempting to use firmware
autoselection with a driver that doesn't implement the feature.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_validate.c | 6 +++---
1 file changed, 3 insertions(+), 3
We explicitly check whether the value is YES or NO, which makes
it unnecessary to make sure it's not ABSENT beforehand.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_firmware.c | 38 --
1 file changed, 16 insertions(+), 22 deletions(-)
diff --git a/src
Andrea Bolognani (3):
vmx: Declare support for firmware autoselection
conf: Fix virDomainDefOSValidate()
qemu: Simplify handling of virTristateBool values
src/conf/domain_validate.c | 6 +++---
src/qemu/qemu_firmware.c | 38 --
src/vmx/vmx.c
The feature was implemented in commits b4e34d1083bc and
9bb6e4e739fa but the corresponding feature flag was not set in
the driver, so other parts of of libvirt wouldn't be able to
know about it.
Signed-off-by: Andrea Bolognani
---
src/vmx/vmx.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On Thu, Jun 09, 2022 at 08:11:17AM +0200, Erik Skultety wrote:
> On Tue, Jun 07, 2022 at 01:06:41PM +0200, Erik Skultety wrote:
> > On Tue, Jun 07, 2022 at 02:34:50AM -0700, Andrea Bolognani wrote:
> > > Can I push the remaining two patches now, or are the issues that made
>
On Thu, Jun 09, 2022 at 12:46:38PM +0200, Erik Skultety wrote:
> On Thu, Jun 09, 2022 at 11:07:57AM +0100, Daniel P. Berrangé wrote:
> > On Thu, Jun 09, 2022 at 06:01:34AM -0400, Andrea Bolognani wrote:
> > > On Wed, Jun 08, 2022 at 08:03:07AM +0200, Erik Skultety wrote:
>
build
> $ ../configure ... --with-git-submodules=ignore
Using
--with-git-submodules=validate
would work too, since we'd have updated the submodules beforehand.
I think I would prefer this approach to changing the git
configuration for the root user.
--
Andrea Bolognani / Red Hat / Virtualization
On Wed, Jun 08, 2022 at 07:59:36AM +0200, Erik Skultety wrote:
> Signed-off-by: Erik Skultety
> ---
> ci/integration-template.yml | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
tool / legacy interface at this point. Anyone who's
not a libvirt or firmware developer should really use the
feature-based firmware selection interface instead.
I have a couple of improvements to the automatic firmware selection
feature and the corresponding documentation in mind. Hopefully I'll
get around to post patches over the next few days.
--
Andrea Bolognani / Red Hat / Virtualization
On Thu, May 26, 2022 at 04:24:41PM +0200, Erik Skultety wrote:
> On Thu, May 26, 2022 at 04:01:45PM +0200, Andrea Bolognani wrote:
> > Test pipeline:
> >
> > https://gitlab.com/abologna/libvirt/-/pipelines/548848259
> >
> > Only patches 1-5 should be pushed un
On Wed, Jun 01, 2022 at 10:05:26AM +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> docs/contact.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
ny cross arch CI builds
I'm not entirely convinced this is the exact set of trade-offs we
want, but the new limit is going to be active starting tomorrow so
it's probably a good idea to merge this right away and tweak things
further later, so
Reviewed-by: Andrea Bolognani
Erik, are you okay with this plan? If so, we can push the patches.
--
Andrea Bolognani / Red Hat / Virtualization
On Thu, May 26, 2022 at 04:23:44PM +0200, Erik Skultety wrote:
> On Thu, May 26, 2022 at 04:01:50PM +0200, Andrea Bolognani wrote:
> > +++ b/ci/manifest.yml
> > @@ -157,7 +157,6 @@ targets:
> >- arch: x86_64
> >
> >- arch: mingw32
> > -
On Thu, May 26, 2022 at 03:07:52PM +0200, Erik Skultety wrote:
> On Thu, May 26, 2022 at 05:15:28AM -0700, Andrea Bolognani wrote:
> > On Thu, May 26, 2022 at 12:05:23PM +0200, Erik Skultety wrote:
> > > Please don't push this yet, because the integration tests would f
This requires publishing the RPMs as artifacts from the regular
build job.
Signed-off-by: Andrea Bolognani
---
ci/gitlab/builds.yml | 4
ci/integration.yml | 16
ci/manifest.yml | 4
3 files changed, 24 insertions(+)
diff --git a/ci/gitlab/builds.yml b/ci
Signed-off-by: Andrea Bolognani
---
...gw32.Dockerfile => fedora-36-cross-mingw32.Dockerfile} | 2 +-
...gw64.Dockerfile => fedora-36-cross-mingw64.Dockerfile} | 2 +-
ci/gitlab/builds.yml | 6 +++---
ci/gitlab/containe
Signed-off-by: Andrea Bolognani
---
ci/integration.yml | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/ci/integration.yml b/ci/integration.yml
index 5b60b41e85..43f22813c9 100644
--- a/ci/integration.yml
+++ b/ci/integration.yml
@@ -49,24 +49,24 @@ fedora-35
Signed-off-by: Andrea Bolognani
Reviewed-by: Erik Skultety
---
ci/containers/fedora-34.Dockerfile | 109 -
ci/gitlab.yml | 20 --
ci/integration.yml | 16 -
ci/manifest.yml| 8 ---
4 files changed
It's a stable distro, so we expect all jobs to succeed.
Signed-off-by: Andrea Bolognani
---
ci/gitlab/containers.yml | 2 +-
ci/manifest.yml | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/ci/gitlab/containers.yml b/ci/gitlab/containers.yml
index 5b8a91c295
Notable changes:
* 'lcitool manifest' now generates GitLab CI rules spread
across a bunch of files;
* container images are built less frequently for the main
repository.
Signed-off-by: Andrea Bolognani
Reviewed-by: Erik Skultety
---
ci/gitlab.yml | 747
The target is intentionally not added to the integration tests
at this time, because the corresponding VM template is not yet
available on the runner. A later patch will take care of that.
Signed-off-by: Andrea Bolognani
---
ci/containers/fedora-36.Dockerfile | 108
;
* don't stop publishing RPMs from the Fedora 35 job
[v1] https://listman.redhat.com/archives/libvir-list/2022-May/231838.html
Andrea Bolognani (7):
ci: Drop Fedora 34
ci: Refresh generated files
ci: Add Fedora 36
ci: Move MinGW jobs to Fedora 36
ci: Don't mark any Fedora 36 job
On Thu, May 26, 2022 at 12:05:23PM +0200, Erik Skultety wrote:
> On Thu, May 26, 2022 at 11:05:30AM +0200, Andrea Bolognani wrote:
> > Test pipeline:
> >
> > https://gitlab.com/abologna/libvirt/-/pipelines/548549670
> >
> > Matching libvirt-perl MR, nee
601 - 700 of 8356 matches
Mail list logo
