Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR")
adds support for CLZERO CPUID bit. This commit extends support for this
bit in libvirt.
This patch is based off of libvirt-4.5 tree.
Signed-off-by: Ani Sinha
---
src/cpu/cpu_map.xml | 5 +
1 file
Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR")
adds support for CLZERO CPUID bit.
This commit extends support for this CPUID bit into libvirt.
Signed-off-by: Ani Sinha
---
src/cpu_map/x86_EPYC-IBPB.xml | 1 +
src/cpu_map/x86_EPYC.xml | 1 +
s
:
On Wed, Nov 27, 2019 at 11:10:21AM +, Ani Sinha wrote:
Hi :
I see a commit in qemu that adds support for CLZERO but in CPUIDs. :
commit e900135dcfb676a4019dc206395e02db5d1de0d6
Author: Sebastian Andrzej Siewior
Date: Wed Sep 25 23:49:48 2019 +0200
i386: Add CPUID bit for CLZERO
Hi all :
Can I get some love for this patch?
thanks
ani
On Dec 3, 2019, 4:49 PM +0530, Ani Sinha , wrote:
Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR")
adds support for CLZERO CPUID bit. This commit extends support for this
bit in libvirt.
This patch is
Hi :
I see a commit in qemu that adds support for CLZERO but in CPUIDs. :
commit e900135dcfb676a4019dc206395e02db5d1de0d6
Author: Sebastian Andrzej Siewior
Date: Wed Sep 25 23:49:48 2019 +0200
i386: Add CPUID bit for CLZERO and XSAVEERPTR
The CPUID bits CLZERO and XSAVEERPTR are availble on
> On Dec 16, 2019, at 5:35 PM, Jiri Denemark wrote:
>
> On Tue, Dec 03, 2019 at 03:09:12 -0800, Ani Sinha wrote:
>> Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and XSAVEERPTR")
>> adds support for CLZERO CPUID bit.
>> This commit extends su
Thanks. Going forward I will only send patches against the current master.
Ani
On 12/16/19, 5:37 PM, "Jiri Denemark" wrote:
On Tue, Dec 03, 2019 at 03:19:39 -0800, Ani Sinha wrote:
> Qemu commit e900135dcfb67 ("i386: Add CPUID bit for CLZERO and
XSAVEERPTR&qu
> On Mar 24, 2020, at 2:53 PM, Daniel P. Berrangé wrote:
>
> This is a patch against QEMU actually.
Oops! Yes sorry, not sure what I was thinking. Yes this is Qemu. I will resend
the email in Qemu-devel mailing list.
ani
Hi :
Is there a recommended way to disable some unit tests in Libvirt ? We some
broken tests which we want to fix incrementally but while we do that, we want
to keep running other non-broken tests.
thanks
Ani
letter but somehow it went out without one). If required I can
send it again. The new patch series has the issues fixed, unit tests added
and they all pass fine.
Requesting for a review and feedback.
Thanks
ani
On Mon, 16 Aug 2021, Ani Sinha wrote:
> 'acpi-pci-hotplug-with-bridge-support' and 'a
Signed-off-by: Ani Sinha
---
...pc-i440fx-acpi-hotplug-bridge-disable.args | 28 +
.../pc-i440fx-acpi-hotplug-bridge-disable.xml | 17 +++
.../pc-i440fx-acpi-hotplug-bridge-enable.args | 28 +
.../pc-i440fx-acpi-hotplug-bridge-enable.xml | 17 +++
...
libvirt xml snippet:
Similarly for turning them on explicitly, they can pass " enabled='yes' " in
the above xml snippet.
Unit tests for this change will be added in a subsequent patch.
Signed-off-by: Ani Sinha
---
docs/schemas/domaincommon.rng | 17 +++
Hi :
The previous patch I sent was half baked and had issues. I am sending the
fixed patch complete with added unit tests for the new libvirt xml options.
The first patch in the series is the actual change. It also adds related
schema modifications. Additionally, it makes the necessary
On Thu, 19 Aug 2021, Ani Sinha wrote:
> Hi:
>
> I added some negative xml2argv tests as well as new xml2xml tests. In the
> process,
> I also fixed a bug where I had not added appropriate code to generate the
> output
> xml correctly.
> The patch series is sent aga
tests. It will be added later on. It it sent for
initial comments and suggestions.
Signed-off-by: Ani Sinha
---
src/conf/domain_conf.c | 10 ++
src/conf/domain_conf.h | 2 ++
src/qemu/qemu_capabilities.c | 9 +
src/qemu/qemu_capabilities.h | 5 +
src/qemu
On Mon, 16 Aug 2021, Peter Krempa wrote:
> On Mon, Aug 16, 2021 at 19:01:27 +0530, Ani Sinha wrote:
> >
> >
> > On Mon, 16 Aug 2021, Peter Krempa wrote:
> >
> > > On Mon, Aug 16, 2021 at 18:35:48 +0530, Ani Sinha wrote:
> > > > Hi :
>
Hi :
getting this strange build error here. Googling did not help. Anyone has
any ideas as to what I am missing? I am on Ubuntu 20.04 LTS.
FAILED: src/libvirt-admin.so.0.7006.0
cc -o src/libvirt-admin.so.0.7006.0
src/libvirt-admin.so.0.7006.0.p/meson-generated_.._admin_admin_protocol.c.o
How can I disable building docs?
On Mon, 16 Aug 2021, Ani Sinha wrote:
>
>
> On Mon, 16 Aug 2021, Peter Krempa wrote:
>
> > On Mon, Aug 16, 2021 at 18:35:48 +0530, Ani Sinha wrote:
> > > Hi :
> > >
> > > getting this strange build error here. Goog
On Mon, 16 Aug 2021, Peter Krempa wrote:
> On Mon, Aug 16, 2021 at 18:35:48 +0530, Ani Sinha wrote:
> > Hi :
> >
> > getting this strange build error here. Googling did not help. Anyone has
> > any ideas as to what I am missing? I am on Ubuntu 20.04 LT
Hi:
I added some negative xml2argv tests as well as new xml2xml tests. In the
process,
I also fixed a bug where I had not added appropriate code to generate the output
xml correctly.
The patch series is sent again as v2. Kindly, please provide inputs and review
them.
[PATCH v2 1/4] pm/i386:
libvirt xml snippet:
Similarly for turning them on explicitly, they can pass " enabled='yes' " in
the above xml snippet.
Unit tests for this change will be added in subsequent patches.
Signed-off-by: Ani Sinha
---
docs/schemas/domaincommon.rng | 17 +++
This change adds positive xml2argv unit tests for the following change:
78ced83e3bb354 ("pm/i386: add support for two options that controls acpi
hotplug on q35/i440fx")
These tests ensure that libvirt generates the correct qemu commandline for a
given input xml.
Signed-off-by:
are absent.
Signed-off-by: Ani Sinha
---
.../qemuxml2argvdata/pc-i440fx-acpi-hotplug-bridge-enable.err | 1 +
tests/qemuxml2argvdata/pc-i440fx-acpi-root-hotplug-enable.err | 1 +
tests/qemuxml2argvdata/q35-acpi-hotplug-bridge-enable.err | 1 +
tests/qemuxml2
l.
Signed-off-by: Ani Sinha
---
.../pc-i440fx-acpi-hotplug-bridge-disable.xml | 31 +
.../pc-i440fx-acpi-root-hotplug-disable.xml | 31 +
.../q35-acpi-hotplug-bridge-disable.xml | 45 +++
tests/qemuxml2xmltest.c | 9
4 fil
On Sun, 12 Sep 2021, Ani Sinha wrote:
> Hi all:
>
> This patchset introduces libvirt xml support for the following two pm conf
> options:
>
>
>
>
>
>
Another option is to create a new xml tag and add these under that tag.
Something like:
+
+
+
Ping again …
On Wed, Sep 1, 2021 at 09:03 Ani Sinha wrote:
>
>
> On Thu, 19 Aug 2021, Ani Sinha wrote:
>
> > Hi:
> >
> > I added some negative xml2argv tests as well as new xml2xml tests. In
> the process,
> > I also fixed a bug where I had not added ap
Hi all:
This patchset introduces libvirt xml support for the following two pm conf
options:
The above two options are only available for qemu driver and that too for x86
guests only. Both of them are global options.
``acpi-hotplug-bridge`` option enables or disables ACPI hotplug
q35,
the capability is detected as QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE.
Please note that the test specific qemu capabilities .replies files has already
been updated as a part of regular refreshing them when a new qemu version is
released. Hence, no updates to those files are required.
Signed-off-by:
as a part of regular refreshing them when a new qemu version is
released. Hence, no updates to those files are required.
Signed-off-by: Ani Sinha
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_5.2.0.x86
Also unit tests have been added to test qemu capability
validation checks.
Signed-off-by: Ani Sinha
---
src/qemu/qemu_command.c | 28 +
src/qemu/qemu_validate.c | 21 +
...pc-i440fx-acpi-hotplug-bridge-disable
disable PCI hotplug on the
root bus")
The above qemu commit describes some compelling reasons why users might to
disable hotplug on PCI root buses.
This change also adds related unit tests to exercise the new conf options.
Signed-off-by: Ani Sinha
---
docs/formatdomain.rs
tplug-with-bridge-support")
Signed-off-by: Ani Sinha
---
NEWS.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 4521499db7..3f7f2c4d4d 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -17,6 +17,15 @@ v7.8.0 (unreleased)
* **New features**
+ * Add supp
On Thu, 9 Sep 2021, Laine Stump wrote:
> On 8/19/21 6:50 AM, Ani Sinha wrote:
> > Hi:
> >
> > I added some negative xml2argv tests as well as new xml2xml tests. In the
> > process,
> > I also fixed a bug where I had not added appropriate code to generate
DanPB,
Could you please reiterate the suggestion regarding the placement of the
pci root hotplug xml you made in the irc channel?
On Fri, Sep 24, 2021 at 02:16 Laine Stump wrote:
> On 9/11/21 11:26 PM, Ani Sinha wrote:
> > Hi all:
> >
> > This patchset introduce
.
That could be posted as a separate patch set.
Sounds good?
On Sat, Sep 25, 2021 at 8:29 PM Laine Stump wrote:
> On 9/23/21 4:46 PM, Laine Stump wrote:
> > On 9/11/21 11:26 PM, Ani Sinha wrote:
> >> Hi all:
> >>
> >> This patchset introduces libvirt xml suppor
Other than laine doesn't anyone have any feedback on this patch set? Timely
reviews help contributions. It's difficult to sit on a patch set and keep
rebasing for ever.
On Tue, Oct 5, 2021 at 11:21 AM Ani Sinha wrote:
> changelog:
>
> v6: rebased to latest. capabilities have been renam
Also just for the statistics , it's been almost 2 months now since the
effort on the two patches started.
On Fri, Oct 8, 2021 at 4:46 AM Ani Sinha wrote:
> Other than laine doesn't anyone have any feedback on this patch set?
> Timely reviews help contributions. It's difficult to sit on a
On Fri, 8 Oct 2021, Laine Stump wrote:
> On 10/5/21 1:51 AM, Ani Sinha wrote:
> > This change introduces a new libvirt sub-element under that
> > can be used to configure all pci related features.
> > Currently the only sub-sub element supported by this sub-elemen
her ACPI based hotplug or native hotplug for bridges
(for example for pcie root port controller in q35 machines).
Qemu capability validation checks have also been added along with related unit
tests to exercise the new conf option.
Signed-off-by: Ani Sinha
---
docs/formatdomain.rst
q35,
the capability is detected as QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE.
Please note that the test specific qemu capabilities .replies files has already
been updated as a part of regular refreshing them when a new qemu version is
released. Hence, no updates to those files are required.
Signed-off-by:
Added the following new libvirt conf option to the release note to indicate
their availability with the next release:
Signed-off-by: Ani Sinha
Reviewed-by: Laine Stump
---
NEWS.rst | 8
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index caa61f0646
capability
validation checks as well as checks for using this option with the right
architecture.
Signed-off-by: Ani Sinha
---
src/qemu/qemu_command.c | 20 +++
.../aarch64-acpi-hotplug-bridge-disable.err | 1 +
...pc-i440fx-acpi-hotplug-bridge-disable.args | 31
her through
libvirt makes things simpler for end users.
Ani Sinha (4):
qemu: capablities: detect presence of
acpi-pci-hotplug-with-bridge-support
conf: introduce support for acpi-bridge-hotplug feature
qemu: command: add support for acpi-bridge-hotplug feature
NEWS: add new acpi pci h
On Fri, 8 Oct 2021, Laine Stump wrote:
> On 10/5/21 1:51 AM, Ani Sinha wrote:
> > This change adds backend qemu command line support for new libvirt global
> > feature 'acpi-bridge-hotplug'. This option can be used as following:
> >
> >
> >
> >
On Wed, 20 Oct 2021, Laine Stump wrote:
> On 10/18/21 12:31 AM, Ani Sinha wrote:
> > Error messages must conform to spec as specified here:
> > https://www.libvirt.org/coding-style.html#error-message-format
> >
> > This change encloses format specifiers i
Signed-off-by: Ani Sinha
---
src/qemu/qemu_validate.c| 6 +++---
.../pc-i440fx-acpi-root-hotplug-disable.x86_64-5.1.0.err| 2 +-
.../pc-i440fx-acpi-root-hotplug-enable.x86_64-5.1.0.err | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git
https://gitlab.com/libvirt/libvirt/-/commit/bdc3e8f47be108fa552b72a6d913528869e61097
I think you completely missed the logic here and you are rewriting a patch
without cc'ing the original author. I'm sorry but this is rude.
Ani
On Thu, Oct 14, 2021 at 16:54 Michal Prívozník wrote:
> On 10/14/21 12:16 PM, Ani Sinha wrote:
> >
> https://gitlab.com/libvirt/libvirt/-/commit/bdc3e8f47be108fa552b72a6d913528869e61097
> > <
> https://gitlab.com/libvirt/libvirt/-/commit/bdc3e8f47be108fa552b72a6d91352
On Fri, Oct 8, 2021 at 12:12 PM Ani Sinha wrote:
> qemu added support for i440fx specific global boolean flag
>
> PIIX4_PM.acpi-pci-hotplug-with-bridge-support
>
> around version 2.1. This flag is enabled by default. When disabled, it
> turns
> off acpi pci hotplug for col
This patch series adds a couple of negative unit tests in order to make sure
we fail in case of invalid conf options.
* [PATCH 1/2] conf/test: add a negative unit test for invalid pci
Above patch makes sure we fail if invalid pci specific global feature is
specified.
* [PATCH 2/2] conf/test:
This change adds a negative unit test to make sure that invalid or unknown pci
related features specified in the input domain xml file will result in an
error.
Signed-off-by: Ani Sinha
---
.../pci-feature-invalid.x86_64-latest.err | 1 +
.../qemuxml2argvdata/pci-feature-invalid.xml | 25
'acpi-bridge-hotplug' global config only supports 'state=off|on' attribute. Any
other attributes are invalid. Added a unit test to make sure we fail in case an
invalid config option is specified.
Signed-off-by: Ani Sinha
---
...i-bridge-hotplug-invalid.x86_64-latest.err | 1 +
.../pci-acpi
oller")
Fixes: 7300ccc9b3 ("conf: introduce support for acpi-bridge-hotplug feature")
Signed-off-by: Ani Sinha
---
src/conf/domain_conf.c | 6 ++
src/qemu/qemu_validate.c| 6 +++---
.../pc-i440fx-acpi-root-ho
On Tue, 28 Sep 2021, Daniel P. Berrangé wrote:
> On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote:
> > This change introduces libvirt xml support for the following two pm options:
> >
> >
> >
> >
> >
>
>
> > +``acpi-hotplu
On Tue, Sep 28, 2021 at 3:28 PM Ani Sinha wrote:
>
>
>
> On Tue, 28 Sep 2021, Daniel P. Berrangé wrote:
>
> > On Tue, Sep 28, 2021 at 02:35:47PM +0530, Ani Sinha wrote:
> > >
> > >
> > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote:
> > &
On Tue, 28 Sep 2021, Daniel P. Berrangé wrote:
> On Tue, Sep 28, 2021 at 03:28:04PM +0530, Ani Sinha wrote:
> >
> >
> > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote:
> >
> > > On Tue, Sep 28, 2021 at 02:35:47PM +0530, Ani Sinha wrote:
> > > &g
On Tue, 28 Sep 2021, Daniel P. Berrangé wrote:
> On Thu, Sep 23, 2021 at 04:46:38PM -0400, Laine Stump wrote:
> > On 9/11/21 11:26 PM, Ani Sinha wrote:
> > > Hi all:
> > >
> > > This patchset introduces libvirt xml support for the
On Tue, Sep 28, 2021 at 17:49 Daniel P. Berrangé
wrote:
> On Tue, Sep 28, 2021 at 05:31:43PM +0530, Ani Sinha wrote:
> >
> >
> > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote:
> >
> > > On Thu, Sep 23, 2021 at 04:46:38PM -0400, Laine Stump wrote:
> >
On Tue, 28 Sep 2021, Daniel P. Berrangé wrote:
> On Tue, Sep 28, 2021 at 02:35:47PM +0530, Ani Sinha wrote:
> >
> >
> > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote:
> >
> > > On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote:
> > >
be used like this:
This will turn off hotplug capability on the pci-root ports. To turn the
capability on, we set hotplug='on' above (which is also the default).
Signed-off-by: Ani Sinha
---
NEWS.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index
se the new conf option has also been added.
Signed-off-by: Ani Sinha
---
docs/formatdomain.rst | 12
src/qemu/qemu_validate.c | 9 +-
.../pc-i440fx-acpi-root-hotplug-disable.xml | 30 +++
.../pc-i440fx-acpi-root-hotplug-
to qemu for x86 guests:
-global PIIX4_PM.acpi-root-pci-hotplug=
This change also adds the required qemuxml2argv unit tests in order to test
correct qemu arguments. Unit tests have also been added to test qemu capability
validation checks.
Signed-off-by: Ani Sinha
---
src/qemu/qemu_command.c
as a part of regular refreshing them when a new qemu version is
released. Hence, no updates to those files are required.
Signed-off-by: Ani Sinha
Reviewed-by: Laine Stump
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 3 +++
tests/
ons
and graceful failure scenarios in case qemu did not support the option.
Ani Sinha (4):
qemu: capablities: detect presence of acpi-root-pci-hotplug for i440fx
machines
conf: introduce option to enable/disable pci hotplug on pci-root
controller
qemu: command: add support to enabl
On Tue, Sep 28, 2021 at 10:17 PM Laine Stump wrote:
> On 9/28/21 4:44 AM, Daniel P. Berrangé wrote:
> > On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote:
> >> This change introduces libvirt xml support for the followin
On Tue, Sep 28, 2021 at 10:21 PM Daniel P. Berrangé
wrote:
> On Tue, Sep 28, 2021 at 06:14:12PM +0530, Ani Sinha wrote:
> > On Tue, Sep 28, 2021 at 17:49 Daniel P. Berrangé
> > wrote:
> >
> > > On Tue, Sep 28, 2021 at 05:31:43PM +0530, Ani Sinha wrote:
> >
On Tue, 28 Sep 2021, Laine Stump wrote:
> On 9/28/21 12:54 PM, Ani Sinha wrote:
> >
> >
> > On Tue, Sep 28, 2021 at 10:17 PM Laine Stump > <mailto:la...@redhat.com>> wrote:
> >
> > On 9/28/21 4:44 AM, Daniel P. Berrangé wrote:
> > &g
On Tue, 28 Sep 2021, Daniel P. Berrangé wrote:
> On Tue, Sep 28, 2021 at 06:14:12PM +0530, Ani Sinha wrote:
> > On Tue, Sep 28, 2021 at 17:49 Daniel P. Berrangé
> > wrote:
> >
> > > On Tue, Sep 28, 2021 at 05:31:43PM +0530, Ani Sinha wrote:
> > > >
>
opposed to native hotplug) are outlined in (b). There are use cases where users
would still want to use native hotplug. Therefore, this config option
enables users to choose either ACPI based hotplug or native hotplug for bridges
(for example for pcie root port controller in q35 machines).
Ani Sinha (
her ACPI based hotplug or native hotplug for bridges
(for example for pcie root port controller in q35 machines).
Qemu capability validation checks have also been added along with related unit
tests to exercise the new conf option.
Signed-off-by: Ani Sinha
---
docs/formatdomain.rst
capability
validation checks as well as checks for using this option with the right
architecture.
Signed-off-by: Ani Sinha
---
src/qemu/qemu_command.c | 14
.../aarch64-acpi-hotplug-bridge-disable.err | 1 +
...pc-i440fx-acpi-hotplug-bridge-disable.args | 31
q35,
the capability is detected as QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE.
Please note that the test specific qemu capabilities .replies files has already
been updated as a part of regular refreshing them when a new qemu version is
released. Hence, no updates to those files are required.
Signed-off-by:
Added the following new libvirt conf option to the release note to indicate
their availability with the next release:
Signed-off-by: Ani Sinha
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index fd20e50d18..0bf4ee002c 100644
On Wed, Sep 29, 2021 at 7:58 PM Igor Mammedov wrote:
>
> On Tue, 28 Sep 2021 11:47:26 +0100
> Daniel P. Berrangé wrote:
>
> > On Tue, Sep 28, 2021 at 03:28:04PM +0530, Ani Sinha wrote:
> > >
> > >
> > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote
On Fri, Sep 24, 2021 at 2:16 AM Laine Stump wrote:
>
> On 9/11/21 11:26 PM, Ani Sinha wrote:
> > Hi all:
> >
> > This patchset introduces libvirt xml support for the following two pm conf
> > options:
> >
> >
> >
> >
> >
>
On Thu, Sep 30, 2021 at 18:52 Laine Stump wrote:
> On 9/30/21 2:16 AM, Ani Sinha wrote:
> > On Fri, Sep 24, 2021 at 2:16 AM Laine Stump wrote:
> >>
> >> On 9/11/21 11:26 PM, Ani Sinha wrote:
> >>> The above two options are only available for qemu driver a
Ping
On Mon, Sep 13, 2021 at 1:39 PM Ani Sinha wrote:
>
>
> On Sun, 12 Sep 2021, Ani Sinha wrote:
>
> > Hi all:
> >
> > This patchset introduces libvirt xml support for the following two pm
> conf
> > options:
> >
> >
> >
> >
The indentation of the first item under the categoty "new features" for the
future release v7.9.0 is not right. Fix it.
Signed-off-by: Ani Sinha
---
NEWS.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NEWS.rst b/NEWS.rst
index 76d2375e97..caa61f0
option to chose one or the other through
libvirt makes things simpler for end users.
Ani Sinha (4):
qemu: capablities: detect presence of
acpi-pci-hotplug-with-bridge-support
conf: introduce support for acpi-bridge-hotplug feature
qemu: command: add support for acpi-bridge-hotplug feature
On Fri, 1 Oct 2021, Laine Stump wrote:
> On 10/1/21 5:29 AM, Ani Sinha wrote:
> > changelog:
> >
> > v7: rebased the patches post libvirt release 7.8. Adjusted NEWS.rst to
> > reflect 7.9 (unreleased)
> > version. Changed version info for new config optio
her ACPI based hotplug or native hotplug for bridges
(for example for pcie root port controller in q35 machines).
Qemu capability validation checks have also been added along with related unit
tests to exercise the new conf option.
Signed-off-by: Ani Sinha
---
docs/formatdomain.rst
capability
validation checks as well as checks for using this option with the right
architecture.
Signed-off-by: Ani Sinha
---
src/qemu/qemu_command.c | 14
.../aarch64-acpi-hotplug-bridge-disable.err | 1 +
...pc-i440fx-acpi-hotplug-bridge-disable.args | 31
q35,
the capability is detected as QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE.
Please note that the test specific qemu capabilities .replies files has already
been updated as a part of regular refreshing them when a new qemu version is
released. Hence, no updates to those files are required.
Signed-off-by:
Added the following new libvirt conf option to the release note to indicate
their availability with the next release:
Signed-off-by: Ani Sinha
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 76d2375e97..c8c7d86ac8 100644
On Mon, 4 Oct 2021, Andrea Bolognani wrote:
> On Fri, Oct 01, 2021 at 02:59:45PM +0530, Ani Sinha wrote:
> > +++ b/src/qemu/qemu_capabilities.c
> > + /* 410 */
> > + "piix4-acpi-root-hotplug-en", /*
> > QEMU_CAPS_PI
On Mon, 4 Oct 2021, Andrea Bolognani wrote:
> On Sat, Oct 02, 2021 at 09:37:13PM +0530, Ani Sinha wrote:
> > The indentation of the first item under the categoty "new features" for the
> > future release v7.9.0 is not right. Fix it.
> >
> > Signed-off-by:
hotplug so that it
is clearer, less confusing and more accurate.
Signed-off-by: Ani Sinha
---
src/qemu/qemu_capabilities.c | 2 +-
tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml | 2 +-
tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml | 2 +-
tests/qemucapabilitiesdata/caps_6.1.0.
On Mon, 4 Oct 2021, Andrea Bolognani wrote:
> On Mon, Oct 04, 2021 at 10:19:17PM +0530, Ani Sinha wrote:
> > On Mon, 4 Oct 2021, Andrea Bolognani wrote:
> > > On Fri, Oct 01, 2021 at 02:59:45PM +0530, Ani Sinha wrote:
> > > > +++ b/src/qemu/qemu_capabilities.c
On Mon, 4 Oct 2021, Laine Stump wrote:
> On 10/4/21 1:26 PM, Ani Sinha wrote:
> > The capability name piix4-acpi-root-hotplug-en is not conventional and
> > appreared to be confusing to some. "en" suffix is also incorrect as the
> > capability in qemu is used to
her ACPI based hotplug or native hotplug for bridges
(for example for pcie root port controller in q35 machines).
Qemu capability validation checks have also been added along with related unit
tests to exercise the new conf option.
Signed-off-by: Ani Sinha
---
docs/formatdomain.rst
q35,
the capability is detected as QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE.
Please note that the test specific qemu capabilities .replies files has already
been updated as a part of regular refreshing them when a new qemu version is
released. Hence, no updates to those files are required.
Signed-off-by:
Added the following new libvirt conf option to the release note to indicate
their availability with the next release:
Signed-off-by: Ani Sinha
---
NEWS.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index caa61f0646..25de621c91 100644
ave built and tested their systems based on native hotplug.
They may not want to suddenly move to acpi based hotplug just because it is now
the default in qemu. Supporting the option to chose one or the other through
libvirt makes things simpler for end users.
Ani Sinha (4):
qemu: capablities:
capability
validation checks as well as checks for using this option with the right
architecture.
Signed-off-by: Ani Sinha
---
src/qemu/qemu_command.c | 14
.../aarch64-acpi-hotplug-bridge-disable.err | 1 +
...pc-i440fx-acpi-hotplug-bridge-disable.args | 31
On Mon, 27 Sep 2021, Ján Tomko wrote:
> On a Monday in 2021, Ani Sinha wrote:
> > The following change in qemu added support for a global boolean flag
> > specific
> > to i440fx machines that would turn off or on acpi based hotplug for pci root
> > bus:
> >
&g
On Mon, 27 Sep 2021, Ján Tomko wrote:
> On a Monday in 2021, Ani Sinha wrote:
> > This change introduces libvirt xml support to enable/disable hotplug on the
> > pci-root controller. It adds a 'target' subelement for the pci-root
> > controller
> > with a 'hotplug'
On Sun, 26 Sep 2021, Laine Stump wrote:
> On 9/26/21 10:35 AM, Ani Sinha wrote:
> > This change introduces libvirt xml support to enable/disable hotplug on the
> > pci-root controller. It adds a 'target' subelement for the pci-root
> > controller
> > with a 'hotpl
On Sun, 26 Sep 2021, Laine Stump wrote:
> On 9/26/21 10:35 AM, Ani Sinha wrote:
> > This change adds qemu backend command line support for enabling or disabling
> > hotplug on the pci-root controller using the 'target' sub-element of the
> > pci-root cont
On Mon, 27 Sep 2021, Laine Stump wrote:
> On 9/27/21 4:05 AM, Ján Tomko wrote:
> > On a Monday in 2021, Ani Sinha wrote:
> > > This change introduces libvirt xml support to enable/disable hotplug on
> > > the
> > > pci-root controller. It adds a
+Igor
+Michael
On Thu, 23 Sep 2021, Laine Stump wrote:
> On 9/11/21 11:26 PM, Ani Sinha wrote:
> > Hi all:
> >
> > This patchset introduces libvirt xml support for the following two pm conf
> > options:
> >
> >
> >
> >
> >
1 - 100 of 241 matches
Mail list logo
