[libvirt] [PATCH] qemu: cgroup: fix cgroup permission logic

Fix logic error introduced in commit d6c91b3c which essentially broke starting any domain. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src/qemu/qemu_cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c

[libvirt] [PATCH] tools: virt-host-validate: fix KVM check on s390

Since kernel version 4.5, s390 has the 'sie' flag to declare its hardware virtualization support. Let's make virt-host-validate aware so this check is passed correctly. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> ---

[libvirt] [PATCH] conf: node_device: fix wrong XML element reference

When reading in a XML definition for a SCSI target device, the name property of struct scsi_target refers to the @target element. Let's fix this obvious typo. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> -

[libvirt] [PATCH v2 2/2] tests: nodedevxml2xml: add test for SCSI target

Let's add a test for SCSI target nodedev devices. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- tests/nodedevschemadata/scsi_target0_0_0.xml | 7 +++ tests/nodedevxml2xmltest.c | 1 + 2 files changed, 8 insertions(+) create mode 100644 tests/nodedevsche

[libvirt] [PATCH v2 0/2] Fixup SCSI node devices

SCSI targets seem to be missing proper treatment and it was actually not possible to import a SCSI target nodedev device definition because of some typo. In order to extend the test case to catch this, I found that the XML schema was missing as well. Bjoern Walk (2): conf: node_device: fix up

[libvirt] [PATCH v2 1/2] conf: node_device: fix up SCSI target

When reading in an XML definition for a SCSI target device, the name property of struct scsi_target refers to the @target element. Let's fix this obvious typo and also extend the XML schema to provide validation. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- docs/schemas/noded

Re: [libvirt] [PATCH v2] host-validate: Improve CPU flags processing

Andrea Bolognani [2016-03-31, 05:29PM +0200]: > [...] > +if (!STRPREFIX(line, "flags") && !STRPREFIX(line, "Features")) At least on s390x, the flags line begins with a lower-cased "features". I can post a follow-up patch to include the platform specific stuff for

[libvirt] [PATCH 0/4] virt-host-validate: add s390 support

This patch series adds support to the s390 platform for the virt-host-validate tool which detects virtualization capabilities of the host. It has been tested on x86 that no regression is introduced. Bjoern Walk (4): tools: virt-host-validate: fix missing translation marker tools: virt-host

[libvirt] [PATCH 3/4] tools: virt-host-validate: improve error handling

When virHostValidateCPUFlag returns NULL, that's more an unexpected error than the sign of missing CPU flags. Let's react to this appropriately. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- tools/virt-host-validate-qemu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[libvirt] [PATCH 4/4] tools: virt-host-validate: HW virt support on s390

Extend the detection of hardware virtualization to the s390 platform. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- tools/virt-host-validate-common.c | 3 ++- tools/virt-host-validate-common.h | 1 + tools/virt-host-validate-qemu.c | 21 +++-- 3 files chang

[libvirt] [PATCH 2/4] tools: virt-host-validate: fix CPU flag detection

Let's fix CPU flag detection on s390, where the flags line begins with a lower-case 'features'. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- tools/virt-host-validate-common.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/virt-host-va

[libvirt] [PATCH 1/4] tools: virt-host-validate: fix missing translation marker

Fix a minor typo. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- tools/virt-host-validate-qemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virt-host-validate-qemu.c b/tools/virt-host-validate-qemu.c index b96b020..eb08e7e 100644 --- a/tools/vir

Re: [libvirt] [PATCH] qemu: hotplug: fix changeable media ejection

John Ferlan <jfer...@redhat.com> [2016-07-21, 12:23PM +0200]: On 07/08/2016 06:30 AM, Bjoern Walk wrote: Since return code is checked globally at the end of the function, let's make sure that we set it correctly at any point. This fixes a regression introduced in commit 0aa19f35

Re: [libvirt] [PATCH] qemu: hotplug: fix changeable media ejection

Bjoern Walk <bw...@linux.vnet.ibm.com> [2016-07-08, 12:34PM +0200]: Since return code is checked globally at the end of the function, let's make sure that we set it correctly at any point. This fixes a regression introduced in commit 0aa19f35 where the first command to eject changeable

[libvirt] [PATCH] qemu: hotplug: fix changeable media ejection

Since return code is checked globally at the end of the function, let's make sure that we set it correctly at any point. This fixes a regression introduced in commit 0aa19f35 where the first command to eject changeable media would fail unconditionally. Signed-off-by: Bjoern Walk <

Re: [libvirt] [PATCH] qemu: hotplug: fix changeable media ejection

John Ferlan [2016-07-22, 12:58PM +0200]: [...] Ahh - the success case. I was reading as the failure and goto case probably because of the commit message. Yeah, I probably should have explained this explicitly in the commit message, sorry about that. So ACK to the patch

Re: [libvirt] [PATCH] nodedev: Return the parent for a virNodeDevicePtr struct

John Ferlan [2017-02-08, 11:06PM +0100]: When the 'parent' was added to the virNodeDevicePtr structure by commit id 'e8a4ea75a' the 'parent' field was not properly filled in when a virGetNodeDevice call was made within driver/config code. Only the device name was ever filled

Re: [libvirt] [PATCH 1/3] nodedev: Add driver callback mechanism to add/remove devices

John Ferlan [2017-02-09, 04:36AM +0100]: Add a callback mechanism as a side door of sorts to the event mgmt functions that are triggered when a node_device object is added or removed. This includes a mechanism to enumerate already added devices for those stateInitialize

Re: [libvirt] [PATCH 00/17] Avoid races with udev

Michal Privoznik [2016-10-26, 02:52PM +0200]: I've came across interesting bug recently. The problem was that user tried to start a domain, but qemu was denied access to some device. Even though we relabelled it initially. By debugging I found the root cause: while we were

[libvirt] Race in log manager causes segfault

Hello, I am currently investigating a rare segfault in libvirt. I have attached a backtrace, the coredump is for s390x. I am currently trying to reproduce the segfault on x86 but it did not occur yet (timespan to short). This can be triggered by rapidly performing domain start/stop cycles in a

Re: [libvirt] [PATCH] docs: don't install news.rng file

at.com https://www.redhat.com/mailman/listinfo/libvir-list However, this does its job, with the above fixed. Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> -- IBM Systems Linux on z Systems & Virtualization Development --

Re: [libvirt] [PATCH] docs: don't install news.rng file

Peter Krempa <pkre...@redhat.com> [2017-04-05, 08:44AM +0200]: On Wed, Apr 05, 2017 at 07:58:36 +0200, Bjoern Walk wrote: Daniel P. Berrange <berra...@redhat.com> [2017-04-04, 07:24PM +0200]: > The news.rng file gets picked up by the wildcard match on docs/schemas, > and

Re: [libvirt] [PATCH] Document preferred naming conventions

Daniel P. Berrange [2017-03-03, 10:50AM +0100]: This documents the preferred conventions for naming files, structs, enums, typedefs and functions. Signed-off-by: Daniel P. Berrange --- HACKING | 71

Re: [libvirt] [PATCH] Document preferred naming conventions

Peter Krempa <pkre...@redhat.com> [2017-03-06, 10:40AM +0100]: On Mon, Mar 06, 2017 at 10:21:28 +0100, Bjoern Walk wrote: I personally would prefer this style: typedef struct _virHashTable { ... } virHashTable, *virHashTablePtr; This is done for example in sr

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

the ordering. Tested-by: Bjoern Walk <bw...@linux.vnet.ibm.com> signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 3/3] tests: deterministichash: Make hash tables arch-independent

Peter Krempa <pkre...@redhat.com> [2017-08-03, 09:47AM +0200]: > On Thu, Aug 03, 2017 at 07:24:35 +0200, Bjoern Walk wrote: > > Peter Krempa <pkre...@redhat.com> [2017-08-02, 05:39PM +0200]: > > > It turns out that our implementation of the hashing function is &

Re: [libvirt] [PATCH 24/24] tests: qemumonitorjson: Test extraction of iSCSI device node names

So, this test fails on S390 because the actual test in testBlockNodeNameDetect is dependent on the ordering of the entries in the hash table, which is different on big endian machines. There are two other tests which have multiple results in the backing chain, 'same-backing' and 'relative', but

Re: [libvirt] [PATCH 2/9] util: json: Add virJSONValueIsObject

Peter Krempa [2017-06-27, 02:46PM +0200]: > Allows testing whether a virJSONValue is an object. > --- > src/libvirt_private.syms | 1 + > src/util/virjson.c | 10 ++ > src/util/virjson.h | 2 ++ > 3 files changed, 13 insertions(+) > > diff --git

[libvirt] [PATCH 5/7] util: helper functions for fibre channel devices

We will need some convenient helper functions for managing sysfs-entries for fibre channel-backed devices. Let's implement them and make them available in the private API. Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- po/POTFILES.in | 1 + src/Makefile.am

[libvirt] [PATCH 4/7] virsh: nodedev: ability to filter CCW capabilities

Now that the node_device driver is aware of CCW devices, let's hook up virsh so that we can filter them properly. Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Reviewed-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm

[libvirt] [PATCH 6/7] node_device: introduce new capability FC_RPORT

/sys/devices/[...]/host0/rport-0:0-0/target0:0:0 scsi_host0 target0:0:0 rport-0:0-0 0x9d73bc45f0e21a86 Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vne

[libvirt] [PATCH 7/7] docs: update news.xml

Mention CCW and fc_remote_port capablities in the news.xml file. Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/ne

[libvirt] [PATCH 1/7] node_device: Use the iterator variable

From: Marc Hartmayer <mhart...@linux.vnet.ibm.com> As the switch statement checks data.type of the iterator variable @cap it must use this variable for the update too. Suggested-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ib

[libvirt] [PATCH 2/7] node_device: Unlock obj in case of an error too

From: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Unlock @obj in case of an error too. Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com&

[libvirt] [PATCH 0/7] extend node_device for CCW and fc_remote_port

the fc_remote_port subcapability for SCSI targets. Here we expose the relevant rport name as well as the port_name (WWPN). Bjoern Walk (5): node_device: detect CCW devices virsh: nodedev: ability to filter CCW capabilities util: helper functions for fibre channel devices node_device

[libvirt] [PATCH 3/7] node_device: detect CCW devices

| +- scsi_target0_0_0 | +- scsi_0_0_0_0 Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- docs/schemas/basictypes.rng | 31 ++ docs/schemas/doma

Re: [libvirt] [PATCH 1/7] node_device: Use the iterator variable

John Ferlan <jfer...@redhat.com> [2017-05-25, 02:37PM -0400]: On 05/22/2017 02:38 AM, Bjoern Walk wrote: From: Marc Hartmayer <mhart...@linux.vnet.ibm.com> As the switch statement checks data.type of the iterator variable @cap it must use this variable for the update too. s/mu

Re: [libvirt] [PATCH 4/7] virsh: nodedev: ability to filter CCW capabilities

John Ferlan <jfer...@redhat.com> [2017-05-25, 03:21PM -0400]: On 05/22/2017 02:38 AM, Bjoern Walk wrote: Now that the node_device driver is aware of CCW devices, let's hook up virsh so that we can filter them properly. Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com&

Re: [libvirt] [PATCH 6/7] node_device: introduce new capability FC_RPORT

John Ferlan <jfer...@redhat.com> [2017-05-25, 03:26PM -0400]: On 05/22/2017 02:38 AM, Bjoern Walk wrote: Similar to scsi_host and fc_host, there is a relation between a scsi_target and its transport specific fc_remote_port. Let's expose this relation and relevant information

Re: [libvirt] [PATCH 3/7] node_device: detect CCW devices

John Ferlan [2017-05-25, 03:05PM -0400]: One would hope they're in range, but since the rng had ranges should you check here similar to what virDomainDeviceCCWAddressIsValid does? It's fine this way since this is essentially reporting from udev which one can only assume

Re: [libvirt] [PATCH 5/7] util: helper functions for fibre channel devices

John Ferlan <jfer...@redhat.com> [2017-05-25, 03:23PM -0400]: On 05/22/2017 02:38 AM, Bjoern Walk wrote: We will need some convenient helper functions for managing sysfs-entries for fibre channel-backed devices. Let's implement them and make them available in the private API. Sign

Re: [libvirt] [PATCH 7/7] docs: update news.xml

John Ferlan <jfer...@redhat.com> [2017-05-25, 03:26PM -0400]: On 05/22/2017 02:38 AM, Bjoern Walk wrote: Mention CCW and fc_remote_port capablities in the news.xml file. Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm

Re: [libvirt] [PATCH 0/7] extend node_device for CCW and fc_remote_port

Thanks a lot for your review John. If you don't mind, you can make the adjustments you mentioned and push, as I can only prepare a v2 on Monday and I wanted to get this in v3.4.0. Best, Bjoern -- IBM Systems Linux on z Systems & Virtualization Development

Re: [libvirt] [PATCH 05/13] nodedev: Use common naming for virnodedeviceobj

John Ferlan [2017-05-19, 09:08AM -0400]: A virNodeDeviceObjPtr is an @obj A virNodeDeviceObjListPtr is an @devs More intuitive for the virNodeDeviceObjListPtr would be @objs, but I guess the naming scheme is already well defined here. signature.asc Description: PGP

Re: [libvirt] [PATCH 04/13] nodedev: Move node_device_linux_sysfs from node_driver to conf

John Ferlan [2017-05-19, 09:08AM -0400]: Move the whole file from src/node_device into src/conf and rename the API's to have the "virNodeDevice" prefix. Signed-off-by: John Ferlan --- src/Makefile.am| 8

Re: [libvirt] [PATCH 00/13] Make the virNodeDeviceObjPtr private

John Ferlan [2017-05-19, 09:08AM -0400]: All part of the effort I have to have a common object model. This series is node device test, driver, and virnodedevobj related. There's also a couple of bug fixes at the beginning of the series from things I have found during this

Re: [libvirt] [PATCH] util: fix virfcp build on non-Linux

Roman Bogorodskiy [2017-05-26, 08:05PM +0400]: - Include virerror.h for virReportSystemError - Rename stub functions to match original function names --- Pushed under the build breaker rule. src/util/virfcp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH v3 9/9] interface: Convert virInterfaceObj to use virObjectLockable

John Ferlan [2017-05-30, 06:43AM -0400]: [...] void -virInterfaceObjFree(virInterfaceObjPtr obj) +virInterfaceObjEndAPI(virInterfaceObjPtr *obj) Naming is hard, and I don't have any better suggestion. Just wanted to say that the name is, maybe, improvable :) { -if

Re: [libvirt] [PATCH v3 8/9] interface: Introduce virInterfaceObjNew

John Ferlan [2017-05-30, 06:43AM -0400]: Create/use a helper to perform the object allocation Signed-off-by: John Ferlan --- src/conf/virinterfaceobj.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git

Re: [libvirt] [PATCH v1 4/7] qemu: Allow regeneration of aliases

Michal Privoznik [2017-09-21, 04:47PM +0200]: > In the near future the qemuAssignDeviceAliases() function is > going to be called multiple times: once at the domain define > time, then in domain prepare phase. To avoid regenerating the > same aliases the second time we need

Re: [libvirt] [PATCH v3 4/5] util: Improve CPU frequency parsing

Andrea Bolognani [2017-12-14, 01:34PM +0100]: > Make the parser both more strict, by not ignoring errors reported > by virStrToLong_ui(), and more permissive, by not failing due to > unrelated fields which just happen to have a know prefix and > accepting any amount of

Re: [libvirt] [PATCH v3 4/5] util: Improve CPU frequency parsing

Andrea Bolognani <abolo...@redhat.com> [2017-12-14, 03:01PM +0100]: > On Thu, 2017-12-14 at 14:55 +0100, Bjoern Walk wrote: > > > + * Returns: 0 when the string has been parsed successfully and the CPU > > > + * frequency has been stored in @mhz, >0 when the

Re: [libvirt] [PATCH 2/6] util: Introduce virHostCPUGetInfoParseCPUInfo()

Andrea Bolognani [2017-12-13, 12:34PM +0100]: > So you'd leave it in virHostCPUGetInfoPopulateLinux()? Why? > I found it more important that all the initialization (cpu, nodes, etc.) is in one place. But it actually doesn't matter. > With my approach, the value is changed

Re: [libvirt] [PATCH v3 3/5] util: Print architecture name in /proc/cpuinfo parser

VIR_WARN("Your architecture is not supported by the %s parser", > +VIR_WARN("%s is not supported by the %s parser", > + virArchToString(arch), > CPUINFO_PATH); > return 1; > } > -- > 2.14.3 > Reviewed-by: Bjoern Walk <

Re: [libvirt] [PATCH v2 0/4] Improvements to CPU frequency reporting

PU data for Moonshot (RHEL 7.4) > util: Tweak virHostCPUParseFrequencyString() > util: Don't report CPU frequency for ARM hosts > > Bjoern Walk (1): > util: virhostcpu: factor out frequency parsing > Everything looks fine. Thanks for taking my patch into consideration. si

Re: [libvirt] [PATCH v2 2/4] util: virhostcpu: factor out frequency parsing

Pino Toscano <ptosc...@redhat.com> [2017-12-13, 05:35PM +0100]: > On Wednesday, 13 December 2017 17:10:19 CET Andrea Bolognani wrote: > > From: Bjoern Walk <bw...@linux.vnet.ibm.com> > > > > All different architectures use the same copy-pasted code to parse &g

[libvirt] [PATCH 1/3] util: virhostcpu: parse frequency information on S390

Core(s) per socket: 8 Thread(s) per core: 1 NUMA cell(s):1 Memory size: 16273908 KiB Reviewed-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com

[libvirt] [PATCH 2/3] tests: virhostcputest: testcase for S390 system

Let's add a testcase for a S390 system running kernel version 4.14 on LPAR. Reviewed-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- .../linux-s390x-with

[libvirt] [PATCH 0/3] processor frequency information on S390

. This goes on top of Andrea's changes in here: https://www.redhat.com/archives/libvir-list/2017-December/msg00519.html Bjoern Walk (3): util: virhostcpu: parse frequency information on S390 tests: virhostcputest: testcase for S390 system util: virsysinfo: parse frequency information on S390 src

[libvirt] [PATCH 3/3] util: virsysinfo: parse frequency information on S390

<mhart...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src/util/virsysinfo.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/util/virsysinfo.c b/src/util/

Re: [libvirt] [PATCH 2/6] util: Introduce virHostCPUGetInfoParseCPUInfo()

Andrea Bolognani [2017-12-11, 05:40PM +0100]: > This handles only the /proc/cpuinfo part of virHostCPUGetInfo(). > > Signed-off-by: Andrea Bolognani > --- > src/util/virhostcpu.c | 60 > +-- > 1 file

Re: [libvirt] [PATCH 3/6] util: Introduce virHostCPUGetInfoParseCPUFrequency()

ling list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > I attach my take on this refactorization for comparison. Feel free to take stuff you like. Or don't :) -- IBM Systems Linux on z Systems & Virtualization Development -

Re: [libvirt] [PATCH 6/6] util: Don't report CPU frequency for ARM hosts

Andrea Bolognani [2017-12-11, 05:40PM +0100]: > Some ARM platforms, such as the original Raspberry Pi, report the > CPU frequency in the BogoMIPS field of /proc/cpuinfo, so libvirt > parsed that field and returned it through its API. > > However, not only many more boards

Re: [libvirt] [PATCH 0/6] Improvements to CPU frequency reporting

Andrea Bolognani <abolo...@redhat.com> [2017-12-12, 04:43PM +0100]: > On Tue, 2017-12-12 at 12:52 +0100, Bjoern Walk wrote: > > Andrea Bolognani <abolo...@redhat.com> [2017-12-11, 05:40PM +0100]: > > > A few steps towards eventually fixing > > > > > &g

Re: [libvirt] [PATCH 12/14] conf: convert sclp/sclplm as

280a8a85..6cc7731a7 100644 > --- a/tests/qemuxml2argvtest.c > +++ b/tests/qemuxml2argvtest.c > @@ -2061,6 +2061,12 @@ mymain(void) > QEMU_CAPS_VIRTIO_CCW, > QEMU_CAPS_VIRTIO_S390, > QEMU_CAPS_SCLP_S390); > +DO_TEST_FULL("s390-console2seria

Re: [libvirt] [PATCH 13/14] qemu: switch s390/s390x default console back to serial

/qemuxml2xmloutdata/qemuxml2xmlout-s390-serial-console.xml > @@ -14,18 +14,12 @@ >destroy > > /usr/bin/qemu-system-s390x > - > - > - > > > > > > >

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

Hello Daniel, thank you for this interesting insight. The future-proof choice of tools, especially programming languages, is certainly a problem that a lot of project have to solve sooner rather then later. For projects that are currently written in any non-memory-managed language, this issue is

Re: [libvirt] [PATCH 0/6] Improvements to CPU frequency reporting

Andrea Bolognani [2017-12-11, 05:40PM +0100]: > A few steps towards eventually fixing > > https://bugzilla.redhat.com/show_bug.cgi?id=1206353 > > The commit message for patch 6/6 contains most of the rationale, > previous patches are cleanups. If not for the new test case

Re: [libvirt] [PATCH 07/13] qemu: Add hotpluging support for PCI devices on S390 guests

Cornelia Huck [2018-05-24, 06:25PM +0200]: > On Thu, 24 May 2018 14:24:32 +0200 > Xiao Feng Ren wrote: > > > From: Yi Min Zhao > > > > This commit adds hotplug support for PCI devices on S390 guests. > > There's no need to

Re: [libvirt] [PATCH 01/13] conf: Add definitions for 'uid' and 'fid' PCI address attributes

; identifier). > > > > Signed-off-by: Yi Min Zhao > > Reviewed-by: Boris Fiuczynski > > Reviewed-by: Stefan Zimmermann > > Reviewed-by: Bjoern Walk > > --- > > src/util/virpci.h | 10 ++ > > 1 file changed, 10 insertions(+) > > > &g

Re: [libvirt] [PATCH 08/13] conf: Introduce parser, formatter for uid and fid

Pino Toscano [2018-05-25, 01:05PM +0200]: > On Thursday, 24 May 2018 14:24:33 CEST Xiao Feng Ren wrote: > > diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng > > index 1a18cd31b1..8050a3ebc4 100644 > > --- a/docs/schemas/basictypes.rng > > +++

Re: [libvirt] [PATCH] qemu: hotplug: fix mdev attach for vfio-ccw

John Ferlan [2018-06-26, 03:03PM -0400]: > > > On 06/26/2018 07:47 AM, Bjoern Walk wrote: > > Mediated devices of model 'vfio-ccw' are using CCW addresses, so make > > sure to call the correct address preparation code for the model. > > > > Reviewe

[libvirt] [PATCH] qemu: hotplug: fix mdev attach for vfio-ccw

Mediated devices of model 'vfio-ccw' are using CCW addresses, so make sure to call the correct address preparation code for the model. Reviewed-by: Shalini Chellathurai Saroja Reviewed-by: Boris Fiuczynski Signed-off-by: Bjoern Walk --- src/qemu/qemu_hotplug.c | 11 +-- 1 file changed

Re: [libvirt] [PATCH 0/8] vfio-ccw passthrough support

Shalini Chellathurai Saroja [2018-04-11, 05:49PM +0200]: > Let us support the basic channel I/O passthrough infrastructure based on > vfio, which have been introduced in QEMU 2.10. The current focus is to > support dasd-eckd (cu_type/dev_type = 0x3990/0x3390) as the

Re: [libvirt] [PATCH 3/3] util: virsysinfo: parse frequency information on S390

John Ferlan <jfer...@redhat.com> [2018-01-04, 03:56PM -0500]: > On 12/19/2017 05:08 AM, Bjoern Walk wrote: > > diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c > > index ab81b1f7..0c2267e3 100644 > > --- a/src/util/virsysinfo.c > > +++ b/src/util/

Re: [libvirt] [PATCH 1/3] util: virhostcpu: parse frequency information on S390

John Ferlan <jfer...@redhat.com> [2018-01-05, 03:53PM -0500]: > > > On 12/19/2017 05:08 AM, Bjoern Walk wrote: > > Since kernel version 4.7, processor frequency information is available > > on S390. Let's adjust the parser so this information shows up for virsh > &g

Re: [libvirt] [PATCH 2/3] tests: virhostcputest: testcase for S390 system

John Ferlan <jfer...@redhat.com> [2018-01-05, 03:55PM -0500]: > > > On 12/19/2017 05:08 AM, Bjoern Walk wrote: > > Let's add a testcase for a S390 system running kernel version 4.14 on > > LPAR. > > > > Reviewed-by: Marc Hartmayer <mhart...@linux.vnet.

Re: [libvirt] [PATCH 1/3] util: virhostcpu: parse frequency information on S390

John Ferlan [2018-01-05, 03:13PM -0500]: > Doh - should have read the cover letter - this goes on top of > Andrea's changes... Sometimes it's just better to wait and/or provide > review to the series you trying to use! > Ye, sorry, should have made it more clear or

Re: [libvirt] [PATCH 3/3] util: virsysinfo: parse frequency information on S390

John Ferlan [2018-01-10, 05:34PM -0500]: > Thinking partially in terms of something Andrea posted as a result of > something I commented on: > > https://www.redhat.com/archives/libvir-list/2018-January/msg00240.html > > Maybe we should take the approach of leaving it as zero

Re: [libvirt] [PATCH 3/3] util: virsysinfo: parse frequency information on S390

John Ferlan <jfer...@redhat.com> [2018-01-08, 07:55AM -0500]: > > > On 01/08/2018 03:39 AM, Bjoern Walk wrote: > > John Ferlan <jfer...@redhat.com> [2018-01-04, 03:56PM -0500]: > >> On 12/19/2017 05:08 AM, Bjoern Walk wrote: > >>> diff --git

[libvirt] [PATCH v2 0/2] processor frequency information on S390

ase for to sysinfotest.c Bjoern Walk (2): util: virsysinfo: parse frequency information on S390 tests: sysinfotest: add new test case for S390 src/util/virsysinfo.c | 41 ++- tests/sysinfodata/s390-freqcpuinfo.data | 52 + tests/sysinfodata/s390-freqsysinfo.data |

[libvirt] [PATCH v2 2/2] tests: sysinfotest: add new test case for S390

Let's add a test case for S390 with CPU frequency information available. Test data is sampled from an IBM z13 system running kernel 4.14 on LPAR. Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- tests/sysi

[libvirt] [PATCH v2 1/2] util: virsysinfo: parse frequency information on S390

art...@linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- src/util/virsysinfo.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/src/util/virsy

Re: [libvirt] [PATCHv2 1/1] include: function parameter names same in declaration

Daniel P. Berrangé [2018-02-13, 09:47AM +]: > On Mon, Feb 12, 2018 at 03:24:03PM -0600, Chris Venteicher wrote: > > Headers use same function parameter names as definition code. > > > > In some cases in libvirt-domain and libvirt-network an established > > naming pattern

Re: [libvirt] [PATCH libvirt] tests: run virshtest independent of current pwd

John Ferlan <jfer...@redhat.com> [2018-02-13, 10:32AM -0500]: > > > On 02/08/2018 07:38 AM, Bjoern Walk wrote: > > virshtest execves the virsh binary. Make sure that it finds the binary's > > location independent of the current working directory by specifying the >

[libvirt] [PATCH libvirt] tests: run virshtest independent of current pwd

i <fiu...@linux.vnet.ibm.com> Signed-off-by: Bjoern Walk <bw...@linux.vnet.ibm.com> --- tests/virshtest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/virshtest.c b/tests/virshtest.c index 67453bd9..94548a82 100644 --- a/tests/virshtest.c +++ b/tests/vir

[libvirt] [PATCH libvirt] qemu: log the crash information for S390

uot;s390" } } } Let's log this information into the domain log file, e.g.: 2018-02-08 13:11:26.075+: panic s390: core='0' psw-mask='0x000200018000' psw-addr='0x0010f146' reason='disabled-wait' Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com> Sign

Re: [libvirt] [PATCH libvirt] qemu: log the crash information for S390

John Ferlan <jfer...@redhat.com> [2018-02-20, 12:25PM -0500]: > On 02/15/2018 06:58 AM, Bjoern Walk wrote: > > Since QEMU 2.12 guest crash information for S390 is available in the > > QEMU monitor, e.g.: > > > > { > > "tim

Re: [libvirt] [PATCH] tests: viriscsitest: make it work on big endian archs

lt of > virStorageBackendCreateIfaceIQN() will be what the test actually > expects. > > Signed-off-by: Pino Toscano Tested-by: Bjoern Walk signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] Availability of libvirt-4.6.0 Release Candidate 2

Daniel Veillard [2018-07-31, 12:19PM +0800]: >It is out, tagged in git and with signed tarball and rpms at the > usual place: > >ftp://libvirt.org/libvirt/ > > in my limited testing it works but we have that pending issue > raised by Andrea. worse case someone reverse the patches and >

Re: [libvirt] Availability of libvirt-4.6.0 Release Candidate 2

Bjoern Walk [2018-07-31, 03:16PM +0200]: > I have not yet had the time to figure out what goes wrong, any ideas are > welcome. Ah, classic. The mocked virRandomBytes function is not endian-agnostic, generating a different interface name as expected by the test. Bjoern -- IBM Systems

Re: [libvirt] Availability of libvirt-4.6.0 Release Candidate 2

Michal Privoznik [2018-07-31, 04:10PM +0200]: > On 07/31/2018 03:54 PM, Bjoern Walk wrote: > > Bjoern Walk [2018-07-31, 03:16PM +0200]: > >> I have not yet had the time to figure out what goes wrong, any ideas are > >> welcome. > > > > Ah, clas

Re: [libvirt] Availability of libvirt-4.6.0 Release Candidate 2

Bjoern Walk [2018-07-31, 02:21PM +0200]: > Daniel Veillard [2018-07-31, 12:19PM +0800]: > >It is out, tagged in git and with signed tarball and rpms at the > > usual place: > > > >ftp://libvirt.org/libvirt/ > > > > in my limited testing

Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

Pino Toscano [2018-08-01, 03:21PM +0200]: > Hi Bjoern, > > On Wednesday, 1 August 2018 14:57:07 CEST Bjoern Walk wrote: > > And here's the fix for the viriscsitest on big-endian machine like > > Daniel suggested. > > I sent an alternative fix, only for viriscsitest,

Re: [libvirt] Availability of libvirt-4.6.0 Release Candidate 2

Daniel P. Berrangé [2018-08-01, 11:51AM +0100]: > On Tue, Jul 31, 2018 at 03:54:43PM +0200, Bjoern Walk wrote: > > Bjoern Walk [2018-07-31, 03:16PM +0200]: > > > I have not yet had the time to figure out what goes wrong, any ideas are > > > welcome. >

Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

Eric Blake [2018-08-01, 09:51AM -0500]: > On 08/01/2018 07:57 AM, Bjoern Walk wrote: > > And here's the fix for the viriscsitest on big-endian machine like > > Daniel suggested. > > > From d59b254294a90c5a9ca0fb6ad29465cd0950bb61 Mon Sep 17 00:00:00 2001 > > From

Re: [libvirt] [PATCH] util: virrandom: make virRandomBits endian-safe

Pino Toscano [2018-08-02, 10:02AM +0200]: > I do not think this patch is correct: we are dealing with random bytes, > so there is no "endianness" for them. Well, it's not incorrect either, isn't it? I agree that endianness doesn't matter for random data, but in the same time, it doesn't hurt to

[libvirt] [PATCH] util: virrandom: make virRandomBits endian-safe

Make the generation of random bits in virRandomBits independent of the endianness of the running architecture. This also solves problems with the mocked random byte generation on big-endian machines. Suggested-by: Daniel P. Berrangé Signed-off-by: Bjoern Walk --- This goes on top of Michal's

Re: [libvirt] [PATCH for v4.6.0 0/2] Fix some random problems

94 From d59b254294a90c5a9ca0fb6ad29465cd0950bb61 Mon Sep 17 00:00:00 2001 From: Bjoern Walk Date: Wed, 1 Aug 2018 14:48:47 +0200 Subject: [PATCH] util: virrandom: make virRandomBits endian-safe Make the generation of random bits in virRandomBits independent of the endianness of the running architecture. This also solves

Re: [libvirt] [PATCH v3 1/2] process: wait longer on kill per assigned Hostdev

Christian Ehrhardt [2018-08-14, 11:27AM +0200]: > diff --git a/src/util/virprocess.c b/src/util/virprocess.c > index ecea27a2d4..46360cc051 100644 > --- a/src/util/virprocess.c > +++ b/src/util/virprocess.c > @@ -341,15 +341,19 @@ int virProcessKill(pid_t pid, int sig) > * Returns 0 if it was

  1   2   3   >