Re: [libvirt] [PATCH] Add migration APIs for libxl driver

I didn't get a chance to test this yet, but have some initial review comments. Signed-off-by: Chunyan Liu --- src/libxl/libxl_driver.c | 617 ++ src/libxl/libxl_driver.h | 17 ++- 2 files changed, 632 insertions(+), 2 deletions(-) diff

Re: [libvirt] [PATCH v14 00/49] write separate module for hostdev passthrough

The whole patch series could be get from here: https://github.com/chunyanliu/libvirt/commits/hostdev_passthrough -Chunyan On 3/7/2014 at 06:52 PM, in message 1394189596-22994-1-git-send-email-cy...@suse.com, Chunyan Liu cy...@suse.com wrote: These patches implements a separate module for

Re: [libvirt] [PATCH 1/2] libxl: support syntax interface type=hostdev

On 5/10/2014 at 06:18 AM, in message 536d541d.5040...@suse.com, Jim Fehlig jfeh...@suse.com wrote: Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com A while back when testing Chunyan's common hostdev library series, I mentioned that interface type='hostdev' was not

Re: [libvirt] [PATCH V2] storagevol: add nocow to vol xml

On 7/9/2014 at 07:25 PM, in message 53bd26a7.9090...@redhat.com, Ján Tomkojto...@redhat.com wrote: On 07/08/2014 08:47 AM, Chunyan Liu wrote: Add 'nocow' to storage volume xml so that user can have an option to set NOCOW flag to the newly created volume. It's useful on btrfs file

Re: [libvirt] [PATCH] blockcopy: check dst = identical device

On 7/29/2014 at 11:47 PM, in message 53d7c1f6.4030...@redhat.com, Eric Blake ebl...@redhat.com wrote: On 07/29/2014 07:37 AM, Eric Blake wrote: On 07/29/2014 03:59 AM, Chunyan Liu wrote: Check whether dst is the same device as source, if yes, report error and exit. Currently

Re: [libvirt] [PATCH] blockcopy: check dst = identical device

On 7/29/2014 at 11:47 PM, in message 53d7c1f6.4030...@redhat.com, Eric Blake ebl...@redhat.com wrote: On 07/29/2014 07:37 AM, Eric Blake wrote: On 07/29/2014 03:59 AM, Chunyan Liu wrote: Check whether dst is the same device as source, if yes, report error and exit. Currently

Re: [libvirt] [PATCH] blockcopy: check dst = identical device

On 7/31/2014 at 11:35 AM, in message 53d9b993.4040...@redhat.com, Eric Blake ebl...@redhat.com wrote: On 07/30/2014 09:29 PM, Chun Yan Liu wrote: A better idea would be to rely on the volume lease manager - obtaining a lease should be impossible for an image already in use

Re: [libvirt] [PATCH] blockcopy: check dst = identical device

On 7/31/2014 at 11:35 AM, in message 53d9b993.4040...@redhat.com, Eric Blake ebl...@redhat.com wrote: On 07/30/2014 09:29 PM, Chun Yan Liu wrote: A better idea would be to rely on the volume lease manager - obtaining a lease should be impossible for an image already in use

Re: [libvirt] [PATCH] blockcopy: check dst = identical device

On 7/31/2014 at 05:52 PM, in message 53DA11DB.FE6 : 102 : 21807, Chun Yan Liu wrote: On 7/31/2014 at 11:35 AM, in message 53d9b993.4040...@redhat.com, Eric Blake ebl...@redhat.com wrote: On 07/30/2014 09:29 PM, Chun Yan Liu wrote: A better idea would be to rely

[libvirt] virsh migrate: sometimes command line cannot exit until manually press ENTER key

Hi, List, Do you meet the same problem? Host is kvm, doing: (e.g.) #virsh migrate sles11 qemu+ssh://147.2.207.55/system --live --unsafe password: Sometimes, VM is already running on the target host and disappears from source host, but the command line still hangs there, if pressing ENTER, it will

Re: [libvirt] virsh migrate: sometimes command line cannot exit until manually press ENTER key

On 8/8/2014 at 12:18 AM, in message CAAfHSJvP1P20kBFD9ZgYy=0JVvG5oiS0eVCfGZc+k39=eha...@mail.gmail.com, Shivaprasad bhat shivaprasadb...@gmail.com wrote: On Thu, Aug 7, 2014 at 11:02 AM, Chun Yan Liu cy...@suse.com wrote: Hi, List, Do you meet the same problem? Host is kvm, doing

Re: [libvirt] [PATCH] cmdMigrate: move vshConnect before vshWatchJob

On 8/8/2014 at 04:44 PM, in message 1407487476-28077-1-git-send-email-cy...@suse.com, Chunyan Liu cy...@suse.com wrote: A possible fix to issue: http://www.redhat.com/archives/libvir-list/2014-August/thread.html#00227 While doing migration on KVM host, found problem sometimes: VM is

Re: [libvirt] [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

On 9/2/2014 at 04:54 PM, in message 20140902085434.ga21...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 02, 2014 at 03:40:42PM +0800, Chunyan Liu wrote: To use virtio-serial device, unix socket created for chardev with default umask(022) has insufficient

Re: [libvirt] [Qemu-devel] [PATCH 1/2] add 'umask' option to -chardev

On 9/2/2014 at 05:16 PM, in message 20140902091655.gb21...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 02, 2014 at 03:08:51AM -0600, Chun Yan Liu wrote: On 9/2/2014 at 04:54 PM, in message 20140902085434.ga21...@redhat.com, Daniel P. Berrange berra

Re: [libvirt] [PATCH 3/3] libxl: add .domainSendKey

On 12/9/2014 at 05:44 PM, in message 2014120909.gb29...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Dec 09, 2014 at 11:27:46AM +0800, Chunyan Liu wrote: libxl supports sysrq. Add .domainSendKey function to support sending sysrq key. I think this is really

Re: [libvirt] [PATCH 3/3] libxl: add .domainSendKey

On 12/10/2014 at 05:21 PM, in message 20141210092125.gb6...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Dec 09, 2014 at 11:19:22PM -0700, Chun Yan Liu wrote: On 12/9/2014 at 05:44 PM, in message 2014120909.gb29...@redhat.com, Daniel P. Berrange

Re: [libvirt] [virt-tools-list] [PATCH] virtinst: refresh pools status before fetch_pools

On 12/5/2014 at 09:54 PM, in message 5481b907.4040...@redhat.com, Cole Robinson crobi...@redhat.com wrote: On 12/05/2014 03:40 AM, Chunyan Liu wrote: Currently, when connecting to hypervisor, if there are pools active but in fact target path already deleted (or for other reasons the

Re: [libvirt] [PATCH V2 2/5] implement remote protocol for domainSendSysrq

On 12/12/2014 at 05:20 PM, in message 548ab36e.30...@redhat.com, Peter Krempa pkre...@redhat.com wrote: On 12/12/14 10:04, Chunyan Liu wrote: Signed-off-by: Chunyan Liu cy...@suse.com --- src/remote/remote_driver.c | 2 +- src/remote/remote_protocol.x | 13 -

Re: [libvirt] [PATCH V2 1/5] Add public API virDomainSendSysrq

On 12/12/2014 at 05:35 PM, in message 20141212093545.gd136...@orkuz.home, Jiri Denemark jdene...@redhat.com wrote: On Fri, Dec 12, 2014 at 10:18:36 +0100, Peter Krempa wrote: On 12/12/14 10:04, Chunyan Liu wrote: Add public API virDomainSendSysrq for sending SysRequest key.

Re: [libvirt] [PATCH V2 2/5] implement remote protocol for domainSendSysrq

On 12/12/2014 at 09:38 PM, in message 20141212133825.gj32...@redhat.com, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Dec 12, 2014 at 01:24:57PM +0100, Peter Krempa wrote: On 12/12/14 12:49, John Ferlan wrote: On 12/12/2014 04:04 AM, Chunyan Liu wrote:

Re: [libvirt] [PATCH V2 1/5] Add public API virDomainSendSysrq

On 12/15/2014 at 11:27 AM, in message 548ec58d026600084...@soto.provo.novell.com, Chun Yan Liu cy...@suse.com wrote: On 12/12/2014 at 05:35 PM, in message 20141212093545.gd136...@orkuz.home, Jiri Denemark jdene...@redhat.com wrote: On Fri, Dec 12, 2014 at 10:18:36 +0100, Peter

Re: [libvirt] [PATCH V3 3/5] virsh: add 'sysrq' command

On 12/17/2014 at 08:14 PM, in message 549173ac.2000...@redhat.com, Ján Tomkojto...@redhat.com wrote: On 12/17/2014 09:48 AM, Chunyan Liu wrote: All domainSendSysrq related API should be manageable from the virsh command line. So, expose 'virsh sysrq' command. Signed-off-by:

Re: [libvirt] [PATCH V3 1/5] Add public API virDomainSendSysrq

On 12/17/2014 at 06:52 PM, in message 20141217105227.gq136...@orkuz.home, Jiri Denemark jdene...@redhat.com wrote: On Wed, Dec 17, 2014 at 16:48:52 +0800, Chunyan Liu wrote: Add public API virDomainSendSysrq for sending SysRequest key. Signed-off-by: Chunyan Liu cy...@suse.com

Re: [libvirt] [PATCH V3 1/5] Add public API virDomainSendSysrq

On 12/18/2014 at 01:00 PM, in message 5492d008026600086...@soto.provo.novell.com, Chun Yan Liu cy...@suse.com wrote: On 12/17/2014 at 06:52 PM, in message 20141217105227.gq136...@orkuz.home, Jiri Denemark jdene...@redhat.com wrote: On Wed, Dec 17, 2014 at 16:48:52 +0800

Re: [libvirt] [PATCH V3 1/5] Add public API virDomainSendSysrq

On 12/19/2014 at 08:03 PM, in message 54941429.8000...@redhat.com, John Ferlan jfer...@redhat.com wrote: On 12/19/2014 12:31 AM, Chun Yan Liu wrote: On 12/18/2014 at 01:00 PM, in message 5492d008026600086...@soto.provo.novell.com, Chun Yan Liu cy...@suse.com wrote

Re: [libvirt] [PATCH V3 1/5] Add public API virDomainSendSysrq

On 12/21/2014 at 10:34 PM, in message 5496da81.40...@redhat.com, Peter Krempa pkre...@redhat.com wrote: On 12/19/14 13:03, John Ferlan wrote: On 12/19/2014 12:31 AM, Chun Yan Liu wrote: On 12/18/2014 at 01:00 PM, in message 5492d008026600086

Re: [libvirt] [PATCH 2/2] Add tests to xmconfigtest

On 12/23/2014 at 09:42 AM, in message 5498c888.6000...@suse.com, Jim Fehlig jfeh...@suse.com wrote: Chunyan Liu wrote: Hi Chunyan, Thanks for the fix, and the test! But I have a few questions regarding the latter... Add tests to testing HVM default features (pae, acpi,

Re: [libvirt] [PATCH V3 1/5] Add public API virDomainSendSysrq

On 12/22/2014 at 08:17 PM, in message 54980bf2.1060...@redhat.com, John Ferlan jfer...@redhat.com wrote: On 12/21/2014 10:15 PM, Chun Yan Liu wrote: On 12/19/2014 at 08:03 PM, in message 54941429.8000...@redhat.com, John Ferlan jfer...@redhat.com wrote: On 12

Re: [libvirt] [PATCH 2/2] Add tests to xmconfigtest

On 12/23/2014 at 11:13 AM, in message 5498ddcc.2020...@suse.com, Jim Fehlig jfeh...@suse.com wrote: Chun Yan Liu wrote: On 12/23/2014 at 09:42 AM, in message 5498c888.6000...@suse.com, Jim Fehlig jfeh...@suse.com wrote: Chunyan Liu wrote: Hi

Re: [libvirt] [PATCH V3 1/5] Add public API virDomainSendSysrq

On 12/23/2014 at 11:42 AM, in message 5498e4ba.1000...@redhat.com, John Ferlan jfer...@redhat.com wrote: On 12/22/2014 09:55 PM, Chun Yan Liu wrote: On 12/22/2014 at 08:17 PM, in message 54980bf2.1060...@redhat.com, John Ferlan jfer...@redhat.com wrote: On 12

Re: [libvirt] [PATCH V3 1/5] Add public API virDomainSendSysrq

On 12/23/2014 at 03:32 PM, in message 54991AA7.243 : 102 : 21807, Chun Yan Liu wrote: On 12/23/2014 at 11:42 AM, in message 5498e4ba.1000...@redhat.com, John Ferlan jfer...@redhat.com wrote: On 12/22/2014 09:55 PM, Chun Yan Liu wrote: On 12/22/2014 at 08:17 PM

Re: [libvirt] vm snapshot multi-disk

On 7/14/2015 at 05:42 AM, in message CALFpzo551ioR=w5asf7jxmtp8egqsp2au_o6awmyofz9mfg...@mail.gmail.com, Marcus shadow...@gmail.com wrote: Oh, I almost forgot to mention the versions: libvirt 1.2.8-16.0.1.el7_1.2.x86_64 qemu 2.1.2-23.el7_1.1.x86_64 Just FYI, tested on my machine,

Re: [libvirt] [PATCH] fix vol-create when target allocation=0

On 8/24/2015 at 05:47 PM, in message 20150824094707.GD22373@wheatley, Martin Kletzander mklet...@redhat.com wrote: On Mon, Aug 24, 2015 at 01:50:41PM +0800, Chunyan Liu wrote: Regression is introduced by commit e30297b0. After that, it will report Cannot fill file error with following

Re: [libvirt] [PATCH 1/6] extend usb controller model to support xen pvusb

>>> On 6/14/2016 at 01:27 PM, in message <575f95c4.4080...@suse.com>, Juergen >>> Gross wrote: > On 14/06/16 07:02, Jim Fehlig wrote: > > On 06/12/2016 10:53 AM, Chunyan Liu wrote: > >> According to libxl implementation, it supports pvusb > >> controller of version 1.1 and

Re: [libvirt] [PATCH 1/6] extend usb controller model to support xen pvusb

>>> On 6/14/2016 at 11:29 PM, in message <75f3d94f-19d3-b466-781f-abb283063...@laine.org>, Laine Stump wrote: > On 06/14/2016 01:02 AM, Jim Fehlig wrote: > >> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c > >> >index 490260f..5c3de83 100644 > >> >---

[libvirt] [RFC] extend USB controller 'model' to support xen pvusb

Hi, List, Currently libxl supports pvusb type USB controller hotplug and in creation time, I'd like to add the support in libvirt libxl driver too. According to current USB controller schema, we need to extend 'model' to support xen PVUSB type. Since libxl support USB controller of version 1.1

[libvirt] 答复： Re: [PATCH] libxl: support assignment from a pool of SRIOV VFs

>>> Jim Fehlig 2016-2-20 上午 7:30 >>> On 01/25/2016 07:24 PM, Chunyan Liu wrote: > Add codes to support creating domain with network defition of assigning > SRIOV VF from a pool. And fix hot plug and unplug SRIOV VF under this > kind of network defition. > > Signed-off-by:

Re: [libvirt] [PATCH V2] libxl: support assignment from a pool of SRIOV VFs

>>> On 3/10/2016 at 08:08 AM, in message <56e0bb0f.3000...@suse.com>, Jim Fehlig wrote: > Hi Chunyan, > > Sorry for the long delay... > > On 02/23/2016 01:07 AM, Chunyan Liu wrote: > > Add codes to support creating domain with network defition of assigning > > SRIOV

Re: [libvirt] [PATCH V3 2/2] libxl: support assignment from a pool of SRIOV VFs

>>> On 3/11/2016 at 05:56 AM, in message <56e1ed8f.4070...@suse.com>, Jim Fehlig wrote: > Chunyan Liu wrote: > > Add codes to support creating domain with network defition of assigning > > SRIOV VF from a pool. And fix hot plug and unplug SRIOV VF under this > > kind of

Re: [libvirt] [PATCH V4 4/6] libxl: support creating domain with VF assignment from a pool

>>> On 3/29/2016 at 08:05 AM, in message <56f9c6d0.5000...@suse.com>, Jim Fehlig wrote: > On 03/21/2016 02:11 AM, Chunyan Liu wrote: > > Add codes to support creating domain with network defition of assigning > > SRIOV VF from a pool. > > > > Signed-off-by: Chunyan Liu

Re: [libvirt] [PATCH 1/3] libxl: rename cleanup_dom label

Reviewed-by: Chunyan Liu >>> On 3/29/2016 at 08:54 AM, in message <1459212889-5490-2-git-send-email-jfeh...@suse.com>, Jim Fehlig wrote: > Rename cleanup_dom label to destroy_dom, which better describes what > it does. > > Signed-off-by: Jim Fehlig

Re: [libvirt] [PATCH V4 6/6] libxlDomainStart: correct cleanup after failure

>>> On 3/29/2016 at 09:00 AM, in message <56f9d3c0.7020...@suse.com>, Jim Fehlig wrote: > On 03/21/2016 02:11 AM, Chunyan Liu wrote: > > Functions like libxlNetworkPrepareDevices, libxlBuildDomainConfig, > > virHostdevPrepareDomainDevices will allocate and reserve some > >

Re: [libvirt] [PATCH 3/3] libxl: only disable domain death events in libxlDomainCleanup

Reviewed-by: Chunyan Liu >>> On 3/29/2016 at 08:54 AM, in message <1459212889-5490-4-git-send-email-jfeh...@suse.com>, Jim Fehlig wrote: > Remove disabling domain death events from libxlDomainStart error > path. The domain death event is already disabled in

Re: [libvirt] [PATCH 2/3] libxl: fix resource leaks in libxlDomainStart error paths

Reviewed-by: Chunyan Liu >>> On 3/29/2016 at 08:54 AM, in message <1459212889-5490-3-git-send-email-jfeh...@suse.com>, Jim Fehlig wrote: > From: Chunyan Liu > > libxlDomainStart allocates and reserves resources that were not > being

Re: [libvirt] [PATCH V4 4/6] libxl: support creating domain with VF assignment from a pool

>>> On 3/29/2016 at 08:05 AM, in message <56f9c6d0.5000...@suse.com>, Jim Fehlig wrote: > On 03/21/2016 02:11 AM, Chunyan Liu wrote: > > Add codes to support creating domain with network defition of assigning > > SRIOV VF from a pool. > > > > Signed-off-by: Chunyan Liu

Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

>>> On 5/24/2016 at 03:23 AM, in message <57435894.9080...@suse.com>, Jim Fehlig <jfeh...@suse.com> wrote: > On 05/23/2016 12:51 AM, Chun Yan Liu wrote: > > > > Yes, I think it's OK. And another place needs to be updated, since now it's > > not onl

Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

>>> On 5/20/2016 at 06:32 PM, in message <573ee7c3.7000...@oracle.com>, Joao Martins wrote: > On 05/19/2016 09:14 AM, Chunyan Liu wrote: > > Support hot attach/detach a USB host device to guest. > > Curretnly libxl only supports xen PV guest, and only > > supports

Re: [libvirt] [PATCH] libxl: add .domainInterfaceAddresses

>>> On 5/17/2016 at 11:46 PM, in message <2fa0cb6f-ea83-d6f3-18f8-51a671574...@laine.org>, Laine Stump <la...@laine.org> wrote: > On 05/16/2016 06:05 PM, Jim Fehlig wrote: > > Chun Yan Liu wrote: > >>>>> On 5/14/2016 at 07:47 AM, in message

Re: [libvirt] [PATCH V2 2/4] libxl: support hotplug USB host device

>>> On 5/21/2016 at 05:25 AM, in message <573f80e3.4070...@suse.com>, Jim Fehlig wrote: > On 05/20/2016 02:25 PM, Jim Fehlig wrote: > > On 05/20/2016 04:32 AM, Joao Martins wrote: > >> On 05/19/2016 09:14 AM, Chunyan Liu wrote: > >>> Support hot attach/detach a USB host

Re: [libvirt] [PATCH 1/2] xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl

>>> On 5/16/2016 at 06:14 PM, in message <57399d91.1030...@oracle.com>, Joao Martins wrote: > > On 05/13/2016 05:54 PM, Jim Fehlig wrote: > > On 05/13/2016 06:59 AM, Joao Martins wrote: > >> > >> On 05/12/2016 09:55 PM, Jim Fehlig wrote: > >>> Joao Martins

Re: [libvirt] [PATCH 1/2] xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl

>>> On 5/14/2016 at 12:54 AM, in message <573606ab.4080...@suse.com>, Jim Fehlig wrote: > On 05/13/2016 06:59 AM, Joao Martins wrote: > > > > On 05/12/2016 09:55 PM, Jim Fehlig wrote: > >> Joao Martins wrote: > >>> On 05/12/2016 12:54 AM, Jim Fehlig wrote: > On

Re: [libvirt] [PATCH 1/2] xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl

>>> On 5/12/2016 at 11:00 PM, in message <57349a91.50...@oracle.com>, Joao >>> Martins wrote: > On 05/12/2016 12:54 AM, Jim Fehlig wrote: > > On 04/21/2016 05:10 AM, Chunyan Liu wrote: > >> According to current xl.cfg docs and xl codes, it uses type=vif > >>

Re: [libvirt] [PATCH 2/2] libxl: support hotplug USB host device

>>> On 5/13/2016 at 07:20 AM, in message <57350fa5.3070...@suse.com>, Jim Fehlig wrote: > Chunyan Liu wrote: > > Support hot attach/detach a USB host device to guest. > > Curretnly libxl only supports xen PV guest, and only > > s/Curretnly/Currently/ > > > supports

Re: [libvirt] [PATCH 1/2] libxl: support creating guest with USB hostdev

>>> On 5/13/2016 at 06:56 AM, in message <57350a36.3070...@suse.com>, Jim Fehlig wrote: > Chunyan Liu wrote: > > Support creating guest with USB host device in config file. > > Currently libxl only supports xen PV guest, and only supports > > specifying USB host device by

Re: [libvirt] [PATCH 1/2] xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl

>>> On 5/14/2016 at 12:58 AM, in message <5736079b.5050...@suse.com>, Jim Fehlig wrote: > On 05/13/2016 07:08 AM, Joao Martins wrote: > > I am not sure what's the etiquette in these cases but I sent you some > patches > > that fixes the tests and makes some adjustments to

Re: [libvirt] [PATCH] libxl: add .domainInterfaceAddresses

>>> On 5/14/2016 at 07:47 AM, in message <5736677d.8030...@suse.com>, Jim Fehlig wrote: > On 05/13/2016 12:21 AM, Chunyan Liu wrote: > > Add .domainInterfaceAddresses so that user can have a way to > > get domain interface address by 'virsh domifaddr'. Currently > > it