Re: [libvirt] [PATCH 2/7] util: add virGetGroupList

2013-07-25 Thread Cole Robinson
On 07/23/2013 11:03 AM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964358 Since neither getpwuid_r() nor initgroups() are safe to call in between fork and exec (they obtain a mutex, but if some other thread in the parent also held the mutex at the time of the fork, the

Re: [libvirt] [PATCH 3/7] util: make virSetUIDGID async-signal-safe

2013-07-25 Thread Cole Robinson
On 07/23/2013 11:03 AM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964358 POSIX states that multi-threaded apps should not use functions that are not async-signal-safe between fork and exec, yet we were using getpwuid_r and initgroups. Although rare, it is possible to

Re: [libvirt] [PATCH 4/7] Fix potential deadlock across fork() in QEMU driver

2013-07-25 Thread Cole Robinson
On 07/23/2013 11:03 AM, Eric Blake wrote: From: Daniel P. Berrange berra...@redhat.com https://bugzilla.redhat.com/show_bug.cgi?id=964358 The hook scripts used by virCommand must be careful wrt accessing any mutexes that may have been held by other threads in the parent process. With the

Re: [libvirt] [PATCH 6/7] security_dac: compute supplemental groups before fork

2013-07-25 Thread Cole Robinson
On 07/23/2013 11:03 AM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964358 Commit 75c1256 states that virGetGroupList must not be called between fork and exec, then commit ee777e99 promptly violated that for lxc's use of virSecurityManagerSetProcessLabel. Hoist the

Re: [libvirt] [PATCH 7/7] security: fix deadlock with prefork

2013-07-25 Thread Cole Robinson
On 07/23/2013 11:04 AM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964358 Attempts to start a domain with both SELinux and DAC security modules loaded will deadlock; latent problem introduced in commit fdb3bde and exposed in commit 29fe5d7. Basically, when recursing into

Re: [libvirt] [PATCH 0/7] backport of getGroupList to v0.10.2-maint

2013-07-25 Thread Cole Robinson
On 07/23/2013 11:03 AM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964358 Since it was on Fedora 18 that I first noticed the deadlock possible when a child process calls getpwuid_r while the parent owned the lock in a different thread, I'm interested in backporting my

Re: [libvirt] [PATCH 5/7] security: framework for driver PreFork handler

2013-07-25 Thread Cole Robinson
On 07/23/2013 11:03 AM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=964358 A future patch wants the DAC security manager to be able to safely get the supplemental group list for a given uid, but at the time of a fork rather than during initialization so as to pick up on

[libvirt] [PATCH] python: Drop TODO

2013-07-29 Thread Cole Robinson
File hasn't been really touched for 7 years. And with recent rawhide changes it contributed to an RPM build failure. Let's drop it. This also removes installation of a libvirt-python doc dir, so drop handling of it from the RPM spec. --- libvirt.spec.in| 7 --- python/Makefile.am | 7

Re: [libvirt] [PATCH] python: Drop TODO

2013-07-29 Thread Cole Robinson
On 07/29/2013 07:59 AM, Daniel P. Berrange wrote: On Mon, Jul 29, 2013 at 07:55:24AM -0400, Cole Robinson wrote: File hasn't been really touched for 7 years. And with recent rawhide changes it contributed to an RPM build failure. Let's drop it. This also removes installation of a libvirt

Re: [libvirt] [v1.0.5-maint PATCH] lxc: correctly backport /dev/tty fix

2013-07-29 Thread Cole Robinson
On 07/29/2013 05:50 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=982317 maint-only patch; reported by Geert Jansen Commit 17cdc298 tried to backport upstream 90a0c6d, but in resolving conflicts, failed to account that upstream commit e1d32bb refactored code to leave

[libvirt] [PATCH 7/9] qemu: Fix networking for ARM guests

2013-07-31 Thread Cole Robinson
Similar to the chardev bit, ARM boards depend on the old style '-net nic' for actually instantiating net devices. And add tests for working ARM XML with console, disk, and networking. --- src/qemu/qemu_command.c| 34 -- src/qemu/qemu_domain.c

[libvirt] [PATCH 4/9] qemu: Fix adding specifying char devs for ARM

2013-07-31 Thread Cole Robinson
QEMU ARM boards don't give us any way to explicitly wire in a -chardev, so use the old style -serial options. --- src/qemu/qemu_capabilities.c | 18 ++ src/qemu/qemu_capabilities.h | 4 src/qemu/qemu_command.c | 3 +-- src/qemu/qemu_process.c | 37

[libvirt] [PATCH 0/9] qemu: Support qemu-system-arm vexpress-a9

2013-07-31 Thread Cole Robinson
of the picture, and the boards depend on old CLI infrastrucure like -net nic and -serial. Patch 6 adds disk bus=sd, which is often the only way to specify storage for ARM boards. Patch 9 adds virtio-mmio address support, which enables virtio for vexpress-a9. Cole Robinson (9): qemu_command

[libvirt] [PATCH 6/9] domain_conf: Add disk bus=sd, wire it up for qemu

2013-07-31 Thread Cole Robinson
This corresponds to '-sd' and '-drive if=sd' on the qemu command line. Needed for many ARM boards which don't provide any other way to pass in storage. --- docs/formatdomain.html.in | 3 ++- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 4 +++- src/conf/domain_conf.h

[libvirt] [PATCH 8/9] qemu: Only setup vhost if virtType == kvm

2013-07-31 Thread Cole Robinson
vhost only works in KVM mode AIUI, and is infact compiled out if the emulator is built for non-native architecture. --- src/qemu/qemu_command.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 3b275e3..f611940 100644

[libvirt] [PATCH 1/9] qemu_command: Drop incorrect ATTRIBUTE_UNUSED annotation

2013-07-31 Thread Cole Robinson
--- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index aa3a2fd..d924110 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1439,7 +1439,7 @@ struct _qemuDomainPCIAddressSet { *

[libvirt] [PATCH 2/9] domain_conf: Set QEMU ARM default USB model to 'none'

2013-07-31 Thread Cole Robinson
Preferably what we'd do is not add any USB controller by default, but that goes against how the QEMU driver has historically acted for other architectures, so let's be consistent. --- src/conf/domain_conf.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH 5/9] qemu: Don't try to allocate PCI addresses for ARM

2013-07-31 Thread Cole Robinson
--- src/qemu/qemu_command.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4209e5e..6da35d0 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1692,6 +1692,16 @@ cleanup: return

[libvirt] [PATCH 3/9] domain_conf: Don't add default memballoon device on ARM

2013-07-31 Thread Cole Robinson
Unlike USB, qemu_command can handle an empty memballoon device, so just don't add it. And add test cases for a basic working ARM guest. --- docs/schemas/domaincommon.rng | 19 +++ src/conf/domain_conf.c | 38 ++

[libvirt] [PATCH 9/9] qemu: Support virtio-mmio transport for virtio on ARM

2013-07-31 Thread Cole Robinson
Starting with qemu 1.6, the qemu-system-arm vexpress-a9 model has a hardcoded virtio-mmio transport which enables attaching all virtio devices. On the command line, we have to use virtio-XXX-device rather than virtio-XXX-pci, thankfully s390 already set the precedent here so it's fairly straight

[libvirt] ANNOUNCE: libvirt 1.0.5.5 maintenance release

2013-08-01 Thread Cole Robinson
libvirt 1.0.5.5 maintenance release is now available. This is libvirt 1.0.5 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.0.5.5.tar.gz Changes in this version: * Set the

[libvirt] ANNOUNCE: libvirt 0.10.2.7 maintenance release

2013-08-01 Thread Cole Robinson
libvirt 0.10.2.7 maintenance release is now available. This is libvirt 0.10.2 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.10.2.7.tar.gz Changes in this version: * udev:

[libvirt] [PATCH 00/10] test: Mock snapshot APIs and misc improvements

2013-08-07 Thread Cole Robinson
This series implements snapshot APIs for the test driver, and adds some misc improvements, like specifying domain state in the passed in driver XML. Cole Robinson (10): test: Split object parsing into their own functions test: Simplify args passed to testDomainStartState test: Unify object

[libvirt] [PATCH 06/10] test: Wire up managed save APIs

2013-08-07 Thread Cole Robinson
Also add a hasmanagedsave element to set this data when starting the connection. --- src/test/test_driver.c | 125 - tests/virshtest.c | 2 +- 2 files changed, 125 insertions(+), 2 deletions(-) diff --git a/src/test/test_driver.c

[libvirt] [PATCH 01/10] test: Split object parsing into their own functions

2013-08-07 Thread Cole Robinson
The function that parses custom driver XML was getting pretty unruly, split the object parsing into their own functions. Rename some variables to be consistent across each function. This should be functionally identical. --- src/test/test_driver.c | 463

[libvirt] [PATCH 04/10] test: Allow specifying object runstate in driver XML

2013-08-07 Thread Cole Robinson
When passing in custom driver XML, allow a block like domain ... testdriver runstate3/runstate /testdriver /domain This is only read at initial driver start time, and sets the initial run state of the object. This is handy for UI testing. Wire it up for domains, networks, pools, and

[libvirt] [PATCH 03/10] test: Unify object XML parsing

2013-08-07 Thread Cole Robinson
Right now things are split a bit between parsing from a relative file path or parsing from inline XML. Unify it. This will simplify upcoming bits. --- src/test/test_driver.c | 236 + 1 file changed, 103 insertions(+), 133 deletions(-) diff --git

[libvirt] [PATCH 07/10] snapshot_conf: Allow parsing an XML node

2013-08-07 Thread Cole Robinson
Similar to how other objects arrange their parse APIs. This will be used by the test driver. --- src/conf/snapshot_conf.c | 85 ++-- src/conf/snapshot_conf.h | 6 2 files changed, 67 insertions(+), 24 deletions(-) diff --git

[libvirt] [PATCH 02/10] test: Simplify args passed to testDomainStartState

2013-08-07 Thread Cole Robinson
Passing virConnectPtr is redundant, just pass testConnPtr and simplify certain callers. --- src/test/test_driver.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 718f83c..960a58e

[libvirt] [PATCH 09/10] test: Implement readonly snapshot APIs

2013-08-07 Thread Cole Robinson
This is just stolen from qemu_driver.c with tweaks to fit the test driver. --- src/test/test_driver.c | 392 + 1 file changed, 392 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 67c6d68..0d4cc85 100644 ---

[libvirt] [PATCH 10/10] test: Implement snapshot create/delete/revert APIs

2013-08-07 Thread Cole Robinson
Again stolen from qemu_driver.c, but dropping all the unneeded bits. This aims to copy all the current qemu validation checks since that's the most commonly used real driver, but some of the checks are completely artificial in the test driver. This only supports creation of internal snapshots for

[libvirt] [PATCH 05/10] test: Allow specifying object transient state in driver XML

2013-08-07 Thread Cole Robinson
Similar to the runstate commit, allow a block like: testdriver transient/ /testdriver Wire it up for domains and networks. Generalize the boolean lookup pattern since we are going to use it for other bits as well. --- src/test/test_driver.c | 45

[libvirt] [PATCH 08/10] test: Allow specifying domainsnapshot XML

2013-08-07 Thread Cole Robinson
The user can pass it in as a subelement of domain as we already do for storage volumes. --- src/test/test_driver.c | 67 ++ 1 file changed, 67 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 09260ba..67c6d68 100644

Re: [libvirt] [PATCH 00/10] test: Mock snapshot APIs and misc improvements

2013-08-16 Thread Cole Robinson
On 08/09/2013 01:03 PM, Daniel P. Berrange wrote: On Wed, Aug 07, 2013 at 07:28:54PM -0400, Cole Robinson wrote: This series implements snapshot APIs for the test driver, and adds some misc improvements, like specifying domain state in the passed in driver XML. Good addition, the test

[libvirt] [PATCH] tools: Make sure to distribute conf_DATA, fix RPM build

2013-08-17 Thread Cole Robinson
--- Pushed as build breaker. tools/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/Makefile.am b/tools/Makefile.am index d48883c..f85c35c 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -33,6 +33,7 @@ ICON_FILES = \ EXTRA_DIST = \ $(ICON_FILES)

[libvirt] [PATCH v2 6/9] qemu: Don't try to allocate PCI addresses for ARM

2013-08-18 Thread Cole Robinson
--- src/qemu/qemu_command.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ceab12c..aaff132 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1773,6 +1773,16 @@ cleanup: return

[libvirt] [PATCH v2 5/9] qemu: Fix adding specifying char devs for ARM

2013-08-18 Thread Cole Robinson
QEMU ARM boards don't give us any way to explicitly wire in a -chardev, so use the old style -serial options. Unfortunately this isn't as simple as just turning off the CHARDEV flag for qemu-system-arm, as upcoming virtio support _will_ use device/chardev. --- src/qemu/qemu_capabilities.c | 18

[libvirt] [PATCH v2 0/9] Support qemu-system-arm vexpress-a9

2013-08-18 Thread Cole Robinson
to CLI infrastrucure like -net nic and -serial. v2: Rebased series Drop patches applied with Laine's series Add patch 1 and 3 Clarify caveats in a few patch descriptions Cole Robinson (9): qemu: Set QEMU_AUDIO_DRV=none with -nographic qemu: Only setup vhost if virtType == kvm

[libvirt] [PATCH v2 2/9] qemu: Only setup vhost if virtType == kvm

2013-08-18 Thread Cole Robinson
vhost only works in KVM mode at the moment, and is infact compiled out if the emulator is built for non-native architecture. While it may work at some point in the future for plain qemu, for now it's just noise on the command line (and which contributes to arm cli breakage). ---

[libvirt] [PATCH v2 3/9] domain_conf: Add default memballon in PostParse callbacks

2013-08-18 Thread Cole Robinson
This should be a no-op change for now. --- src/qemu/qemu_domain.c | 10 ++ src/xen/xen_driver.c | 9 + 2 files changed, 19 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 393af6b..8dc7675 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH v2 8/9] qemu: Fix networking for ARM guests

2013-08-18 Thread Cole Robinson
Similar to the chardev bit, ARM boards depend on the old style '-net nic' for actually instantiating net devices. But we can't block out -netdev altogether since it's needed for upcoming virtio support. And add tests for working ARM XML with console, disk, and networking. ---

[libvirt] [PATCH v2 7/9] domain_conf: Add disk bus=sd, wire it up for qemu

2013-08-18 Thread Cole Robinson
This corresponds to '-sd' and '-drive if=sd' on the qemu command line. Needed for many ARM boards which don't provide any other way to pass in storage. --- docs/formatdomain.html.in | 3 ++- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 4 +++- src/conf/domain_conf.h

[libvirt] [PATCH v2 4/9] qemu: Don't add default memballoon device on ARM

2013-08-18 Thread Cole Robinson
And add test cases for a basic working ARM guest. --- docs/schemas/domaincommon.rng | 19 + src/conf/domain_conf.c | 14 - src/qemu/qemu_domain.c | 4 ++- .../qemuxml2argv-arm-vexpressa9-nodevs.args

[libvirt] [PATCH v2 9/9] qemu: Support virtio-mmio transport for virtio on ARM

2013-08-18 Thread Cole Robinson
Starting with qemu 1.6, the qemu-system-arm vexpress-a9 model has a hardcoded virtio-mmio transport which enables attaching all virtio devices. On the command line, we have to use virtio-XXX-device rather than virtio-XXX-pci, thankfully s390 already set the precedent here so it's fairly straight

[libvirt] [PATCH v2 1/9] qemu: Set QEMU_AUDIO_DRV=none with -nographic

2013-08-19 Thread Cole Robinson
On my machine, a guest fails to boot if it has a sound card, but not graphical device/display is configured, because pulseaudio fails to initialize since it can't access $HOME. A workaround is removing the audio device, however on ARM boards there isn't any option to do that, so -nographic always

Re: [libvirt] [PATCH v2 4/9] qemu: Don't add default memballoon device on ARM

2013-08-19 Thread Cole Robinson
On 08/19/2013 01:00 PM, Daniel P. Berrange wrote: On Sun, Aug 18, 2013 at 02:57:54PM -0400, Cole Robinson wrote: And add test cases for a basic working ARM guest. Does virtio-balloon not work on ARM ? I thought that was an architecture angostic device type. It works, but only where

[libvirt] [PATCH v2 0/9] test: Mock snapshot APIs and misc improvements

2013-08-30 Thread Cole Robinson
with qemu Cole Robinson (9): test: Allow specifying object runstate in driver XML test: Allow specifying object transient state in driver XML test: Wire up managed save APIs test: Implement readonly snapshot APIs test: Implement snapshot create/delete/revert APIs qemu: snapshots: Simplify

[libvirt] [PATCH v2 6/9] qemu: snapshots: Simplify REDEFINE flag check

2013-08-30 Thread Cole Robinson
Makes things more readable IMO --- src/qemu/qemu_driver.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ed29373..e7212c1 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12283,6 +12283,7

[libvirt] [PATCH v2 4/9] test: Implement readonly snapshot APIs

2013-08-30 Thread Cole Robinson
This is just stolen from qemu_driver.c with tweaks to fit the test driver. --- src/test/test_driver.c | 392 + 1 file changed, 392 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2bcdd64..fd2ff1b 100644 ---

[libvirt] [PATCH v2 2/9] test: Allow specifying object transient state in driver XML

2013-08-30 Thread Cole Robinson
Similar to the runstate commit, allow a boolean test:transient/ element for setting domain persistence at driver startup. --- src/test/test_driver.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index fdfb13a..a181a9b

[libvirt] [PATCH v2 7/9] qemu: snapshot: Break out redefine preparation to shared function

2013-08-30 Thread Cole Robinson
--- src/conf/snapshot_conf.c | 150 +++ src/conf/snapshot_conf.h | 7 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 131 + 4 files changed, 160 insertions(+), 129 deletions(-) diff --git

[libvirt] [PATCH v2 8/9] test: snapshot: Add REDEFINE support

2013-08-30 Thread Cole Robinson
--- src/test/test_driver.c | 67 -- 1 file changed, 43 insertions(+), 24 deletions(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index e0055b5..076f326 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -6450,26

[libvirt] [PATCH v2 9/9] test: Allow specifying domainsnapshot XML

2013-08-30 Thread Cole Robinson
The user can pass it as a test:domainsnapshot subelement of a domain. --- src/test/test_driver.c | 99 +- 1 file changed, 98 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 076f326..f0ac523 100644 ---

[libvirt] [PATCH v2 3/9] test: Wire up managed save APIs

2013-08-30 Thread Cole Robinson
Also add a test:hasmanagedsave element to set this data when starting the connection. --- src/test/test_driver.c | 129 - tests/virshtest.c | 2 +- 2 files changed, 129 insertions(+), 2 deletions(-) diff --git a/src/test/test_driver.c

[libvirt] [PATCH v2 5/9] test: Implement snapshot create/delete/revert APIs

2013-08-30 Thread Cole Robinson
Again stolen from qemu_driver.c, but dropping all the unneeded bits. This aims to copy all the current qemu validation checks since that's the most commonly used real driver, but some of the checks are completely artificial in the test driver. This only supports creation of internal snapshots for

Re: [libvirt] [PATCH v2 2/9] qemu: Only setup vhost if virtType == kvm

2013-08-30 Thread Cole Robinson
On 08/19/2013 12:56 PM, Daniel P. Berrange wrote: On Sun, Aug 18, 2013 at 02:57:52PM -0400, Cole Robinson wrote: vhost only works in KVM mode at the moment, and is infact compiled out if the emulator is built for non-native architecture. While it may work at some point in the future for plain

[libvirt] [PATCH v3 4/8] qemu: Fix specifying char devs for ARM

2013-08-30 Thread Cole Robinson
QEMU ARM boards don't give us any way to explicitly wire in a -chardev, so use the old style -serial options. Unfortunately this isn't as simple as just turning off the CHARDEV flag for qemu-system-arm, as upcoming virtio support _will_ use device/chardev. --- src/qemu/qemu_capabilities.c | 18

[libvirt] [PATCH v3 3/8] qemu: Don't add default memballoon device on ARM

2013-08-30 Thread Cole Robinson
And add test cases for a basic working ARM guest. --- docs/schemas/domaincommon.rng | 19 + src/qemu/qemu_domain.c | 4 ++- .../qemuxml2argv-arm-vexpressa9-nodevs.args| 5 .../qemuxml2argv-arm-vexpressa9-nodevs.xml

[libvirt] [PATCH v3 0/8] Support qemu-system-arm vexpress-a9

2013-08-30 Thread Cole Robinson
to CLI infrastrucure like -net nic and -serial. v3: Rebased series Add qemu.conf nographics_allow_host_audio for patch #1 Drop domain_conf.c default memballoon handling in patch #2, not #3 Cole Robinson (8): qemu: Set QEMU_AUDIO_DRV=none with -nographic domain_conf: Add default

[libvirt] [PATCH v3 8/8] qemu: Support virtio-mmio transport for virtio on ARM

2013-08-30 Thread Cole Robinson
Starting with qemu 1.6, the qemu-system-arm vexpress-a9 model has a hardcoded virtio-mmio transport which enables attaching all virtio devices. On the command line, we have to use virtio-XXX-device rather than virtio-XXX-pci, thankfully s390 already set the precedent here so it's fairly straight

[libvirt] [PATCH 1/8 v3] qemu: Set QEMU_AUDIO_DRV=none with -nographic

2013-08-30 Thread Cole Robinson
On my machine, a guest fails to boot if it has a sound card, but not graphical device/display is configured, because pulseaudio fails to initialize since it can't access $HOME. A workaround is removing the audio device, however on ARM boards there isn't any option to do that, so -nographic always

[libvirt] [PATCH v3 5/8] qemu: Don't try to allocate PCI addresses for ARM

2013-08-30 Thread Cole Robinson
--- src/qemu/qemu_command.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a8e532c..87345c7 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1773,6 +1773,16 @@ cleanup: return

[libvirt] [PATCH v3 7/8] qemu: Fix networking for ARM guests

2013-08-30 Thread Cole Robinson
Similar to the chardev bit, ARM boards depend on the old style '-net nic' for actually instantiating net devices. But we can't block out -netdev altogether since it's needed for upcoming virtio support. And add tests for working ARM XML with console, disk, and networking. ---

Re: [libvirt] [PATCH 1/8 v3] qemu: Set QEMU_AUDIO_DRV=none with -nographic

2013-08-30 Thread Cole Robinson
Wrong in-reply-to, resent with proper threading. - Cole On 08/30/2013 12:44 PM, Cole Robinson wrote: On my machine, a guest fails to boot if it has a sound card, but not graphical device/display is configured, because pulseaudio fails to initialize since it can't access $HOME. A workaround

[libvirt] [PATCH v3 2/8] domain_conf: Add default memballoon in PostParse callbacks

2013-08-30 Thread Cole Robinson
This should be a no-op change for now. --- src/conf/domain_conf.c | 13 - src/qemu/qemu_domain.c | 10 ++ src/xen/xen_driver.c | 9 + 3 files changed, 19 insertions(+), 13 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt] [PATCH v3 6/8] domain_conf: Add disk bus=sd, wire it up for qemu

2013-08-30 Thread Cole Robinson
This corresponds to '-sd' and '-drive if=sd' on the qemu command line. Needed for many ARM boards which don't provide any other way to pass in storage. --- docs/formatdomain.html.in | 3 ++- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 4 +++- src/conf/domain_conf.h

[libvirt] [PATCH v2 1/9] test: Allow specifying object runstate in driver XML

2013-08-30 Thread Cole Robinson
When passing in custom driver XML, allow a block like domain xmlns:test='http://libvirt.org/schemas/domain/test/1.0' ... test:runstate5/test:runstate /domain This is only read at initial driver start time, and sets the initial run state of the object. This is handy for UI testing. It's only

Re: [libvirt] [PATCH v3 8/8] qemu: Support virtio-mmio transport for virtio on ARM

2013-09-02 Thread Cole Robinson
On 09/02/2013 08:52 AM, Daniel P. Berrange wrote: On Fri, Aug 30, 2013 at 12:41:36PM -0400, Cole Robinson wrote: Starting with qemu 1.6, the qemu-system-arm vexpress-a9 model has a hardcoded virtio-mmio transport which enables attaching all virtio devices. On the command line, we have to use

Re: [libvirt] [PATCH v3 0/8] Support qemu-system-arm vexpress-a9

2013-09-02 Thread Cole Robinson
On 08/30/2013 12:41 PM, Cole Robinson wrote: This series adds the bits needed to kick of a qemu-system-arm -machine vexpress-a9 guest. vexpress-a15 likely works as well but is untested. Patches 1-2 are related bugfixes/improvements. Patch 6 adds disk bus=sd, which is often the only way

[libvirt] [PATCH] Drop ChangeLog generation

2013-09-02 Thread Cole Robinson
Fedora is perpetually low on space for its live cd, and a bug was filed asking libvirt to drop the rather large ChangeLog from the RPM: https://bugzilla.redhat.com/show_bug.cgi?id=977099 Really though, what's the point of a static ChangeLog these days? git has won, and is far more useful for

[libvirt] [PATCH] spec: Only distribute ChangeLog in -devel package

2013-09-04 Thread Cole Robinson
Helps save space on the Fedora livecd, as requested here: https://bugzilla.redhat.com/show_bug.cgi?id=977099 --- libvirt.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index e94901a..a327eab 100644 --- a/libvirt.spec.in +++

Re: [libvirt] [PATCH] conf: Remove the actual hostdev when removing a network

2013-09-04 Thread Cole Robinson
On 09/03/2013 11:29 AM, Peter Krempa wrote: Commit 50348e6edfa reused the code to remove the hostdev portion of a network definition on multiple places but forgot to take into account that sometimes the actual network is passed and in some cases the parent of that. This patch uses the

Re: [libvirt] [fedora-virt] Sanlock + libvirt

2013-09-09 Thread Cole Robinson
cc-ing libvir-list On 09/09/2013 08:20 AM, Ján ONDREJ (SAL) wrote: Hello, in sanlock docs (https://fedorahosted.org/sanlock/) there is described, how to use it. There is no mention about NFS. Can I use sanlock with LVM (without NFS) with livbirt? It this feature implemented in libvirt for

Re: [libvirt] [PATCH V3] AArch64: Porting of armv7l conditons to run qemu for aarch64.

2014-01-06 Thread Cole Robinson
On 01/02/2014 05:42 AM, Pranavkumar Sawargaonkar wrote: AArch64 qemu has similar behavior as armv7l, like use of mmio etc. This patch adds similar bypass checks what we have for armv7l to aarch64. E.g. we are enabling mmio transport for Nicdev. Making addDefaultUSB and addDefaultMemballoon to

Re: [libvirt] [PATCH libvirt-java] spec: Only install unversioned jar file

2014-01-06 Thread Cole Robinson
On 12/18/2013 02:58 AM, Claudio Bley wrote: At Tue, 17 Dec 2013 16:34:11 -0500, Cole Robinson wrote: As intended by Fedora's java packaging guidelines: https://bugzilla.redhat.com/show_bug.cgi?id=1022139 --- libvirt-java.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

Re: [libvirt] [PATCHV2] qemu: Add support for changing timeout value to open unix monitor socket

2014-01-08 Thread Cole Robinson
On 01/07/2014 05:39 AM, Richard W.M. Jones wrote: On Tue, Jan 07, 2014 at 11:37:11AM +0100, Martin Kletzander wrote: On Tue, Jan 07, 2014 at 10:28:41AM +, Richard W.M. Jones wrote: On Thu, Jan 02, 2014 at 06:29:35PM +0200, Pavel Fux wrote: Adding an option to change monitor socket opening

[libvirt] ANNOUNCE: libvirt 1.1.3.3 maintenance release

2014-01-16 Thread Cole Robinson
libvirt 1.1.3.3 maintenance release is now available. This is libvirt 1.1.3 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.1.3.3.tar.gz Changes in this version: *

[libvirt] ANNOUNCE: libvirt 1.0.5.9 maintenance release

2014-01-16 Thread Cole Robinson
libvirt 1.0.5.9 maintenance release is now available. This is libvirt 1.0.5 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.0.5.9.tar.gz Changes in this version: * Fix race

Re: [libvirt] 'host-passthrough' for arm64

2014-01-20 Thread Cole Robinson
On 01/20/2014 08:19 AM, Oleg Strikov wrote: Hello guys, I'm trying to come up with basic OpenStack support for arm64 node. I'd like to use 'libvirt_cpu_mode=host-passthrough' configuration option with Nova which issues cpu mode='host-passthrough' to libvirt xml config. But with this option

Re: [libvirt] [PATCH] qemu: Enable 'host-passthrough' cpu mode for aarch64

2014-01-25 Thread Cole Robinson
On 01/23/2014 10:19 AM, Oleg Strikov wrote: This patch allows libvirt user to specify 'host-passthrough' cpu mode while using qemu/kvm backend on aarch64. It uses 'host' as a CPU model name instead of some other stub (correct CPU detection is not implemented yet) to allow libvirt user to

[libvirt] ANNOUNCE: virt-xml: Edit libvirt XML with command line options

2014-01-26 Thread Cole Robinson
I've just pushed a new tool to virt-manager.git called virt-xml. virt-xml uses virt-install's command line options to allow building and editing domain XML. Best way to describe what it can do is with a bunch of examples: See a list of all suboptions that --disk and --network take # virt-xml

Re: [libvirt] [virt-tools-list] ANNOUNCE: virt-xml: Edit libvirt XML with command line options

2014-01-27 Thread Cole Robinson
On 01/27/2014 05:24 AM, Martin Kletzander wrote: On Sun, Jan 26, 2014 at 01:24:59PM -0500, Cole Robinson wrote: I've just pushed a new tool to virt-manager.git called virt-xml. virt-xml uses virt-install's command line options to allow building and editing domain XML. Best way to describe

Re: [libvirt] ANNOUNCE: virt-xml: Edit libvirt XML with command line options

2014-01-27 Thread Cole Robinson
On 01/27/2014 09:16 AM, Eric Blake wrote: On 01/26/2014 11:24 AM, Cole Robinson wrote: I've just pushed a new tool to virt-manager.git called virt-xml. virt-xml uses virt-install's command line options to allow building and editing domain XML. Best way to describe what it can do

Re: [libvirt] ANNOUNCE: virt-xml: Edit libvirt XML with command line options

2014-01-29 Thread Cole Robinson
On 01/28/2014 11:49 AM, Michal Privoznik wrote: On 26.01.2014 19:24, Cole Robinson wrote: I've just pushed a new tool to virt-manager.git called virt-xml. virt-xml uses virt-install's command line options to allow building and editing domain XML. Best way to describe what it can do

[libvirt] [PATCH] examples: event-test: Add network event support

2014-02-11 Thread Cole Robinson
Just an example of network lifecycle events --- examples/event-test.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/examples/event-test.py b/examples/event-test.py index 1402c04..fb750c7 100644 --- a/examples/event-test.py +++ b/examples/event-test.py @@ -500,6 +500,14 @@ def

Re: [libvirt] [PATCH] examples: event-test: Add network event support

2014-02-11 Thread Cole Robinson
Ignore this one, didn't have 'python' in the subject. - Cole On 02/11/2014 12:45 PM, Cole Robinson wrote: Just an example of network lifecycle events --- examples/event-test.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/examples/event-test.py b/examples/event-test.py

[libvirt] [PATCH python] examples: event-test: Add network event support

2014-02-11 Thread Cole Robinson
Just an example of network lifecycle events --- examples/event-test.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/examples/event-test.py b/examples/event-test.py index 1402c04..fb750c7 100644 --- a/examples/event-test.py +++ b/examples/event-test.py @@ -500,6 +500,14 @@ def

Re: [libvirt] [python PATCH] examples: demonstrate network events

2014-02-11 Thread Cole Robinson
On 02/04/2014 07:25 PM, Eric Blake wrote: Commit 6ea5be0 added network event callback support, so we might as well demonstrate that it works by updating our example. * examples/event-test.py: Add network event, fix typos. Signed-off-by: Eric Blake ebl...@redhat.com ---

Re: [libvirt] [PATCH] qemu: Implement a stub cpuArchDriver.baseline() handler for aarch64

2014-02-11 Thread Cole Robinson
On 02/11/2014 10:51 AM, Oleg Strikov wrote: Openstack Nova calls virConnectBaselineCPU() during initialization of the instance to get a full list of CPU features. This patch adds a stub to aarch64-specific code to handle this request (no actual work is done). That's enough to have this stub

Re: [libvirt] [libvirt-users] Help? Running into problems with migrateToURI2() and virDomainDefCheckABIStability()

2014-02-12 Thread Cole Robinson
On 02/12/2014 01:03 PM, Chris Friesen wrote: On 02/11/2014 04:45 PM, Cole Robinson wrote: On 02/10/2014 06:46 PM, Chris Friesen wrote: Hi, We've run into a problem with libvirt 1.1.2 and are looking for some comments on whether this is a bug or design intent. We're trying to use

[libvirt] ANNOUNCE: virt-manager 1.0.0 released

2014-02-14 Thread Cole Robinson
I'm happy to announce the release of virt-manager 1.0.0! Our version numbers were starting to get awkward, and this release was suitably featureful, so it felt like time to bump the major version. (And it's trendy these days, right?). virt-manager is a desktop application for managing KVM, Xen,

Re: [libvirt] virDomainGetMaxVcpus does not work as expected

2014-02-18 Thread Cole Robinson
On 02/18/2014 02:11 AM, Claudio Bley wrote: Hi. Any opinions on this? At Thu, 13 Feb 2014 14:50:08 +0100, Claudio Bley wrote: Hi. When calling virDomainGetMaxVcpus (http://libvirt.org/html/libvirt-libvirt.html#virDomainGetMaxVcpus) on an inactive domain, I receive this error: scala

Re: [libvirt] [libvirt-users] event-test.py cannot detects domain shutdown

2014-02-18 Thread Cole Robinson
On 02/18/2014 05:12 AM, Kim Larry wrote: 2014년 2월 11일 오후 10:00에 Eric Blake ebl...@redhat.com 작성: On 02/11/2014 12:20 AM, Kim Larry wrote: libvirtd version is 1.1.4 and using Xen for hypervisor. I'm not as familiar with the xen hypervisor as with qemu; it may just be the case that no one

[libvirt] ANNOUNCE: libvirt 1.1.3.4 maintenance release

2014-02-18 Thread Cole Robinson
libvirt 1.1.3.4 maintenance release is now available. This is libvirt 1.1.3 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.1.3.4.tar.gz Changes in this version: *

Re: [libvirt] [PATCH v2] qemu: Use virtio network device for aarch64/virt

2014-02-19 Thread Cole Robinson
On 02/14/2014 09:09 AM, Oleg Strikov wrote: This patch changes network device type used by default from rtl8139 to virtio when architecture type is aarch64 and machine type is virt. Qemu doesn't support any other machine types for aarch64 right now and we can't make any other aarch64-specific

Re: [libvirt] [libvirt-users] event-test.py cannot detects domain shutdown

2014-02-19 Thread Cole Robinson
On 02/18/2014 10:45 PM, Jim Fehlig wrote: Cole Robinson wrote: On 02/18/2014 05:12 AM, Kim Larry wrote: The thing I found today is that if libvirt uses xend driver, shutdown events are delivered, but if libvirt uses libxl drvier, doesn't show up anything. It seems there are bugs

Re: [libvirt] [PATCH 1/3] virSystemdCreateMachine: Set dependencies for slices

2014-02-24 Thread Cole Robinson
On 02/21/2014 07:32 AM, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1031696 When creating a new domain, we let systemd know about it by calling CreateMachine() function via dbus. Systemd then creates a scope and places domain into it. However, later when the host is

[libvirt] [PATCH libvirt-java] spec: Depend on java-headless for Fedora 21+

2014-02-25 Thread Cole Robinson
Details: https://bugzilla.redhat.com/show_bug.cgi?id=1068369 --- libvirt-java.spec.in | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-java.spec.in b/libvirt-java.spec.in index 137af83..d07b998 100644 --- a/libvirt-java.spec.in +++ b/libvirt-java.spec.in @@ -12,7 +12,11 @@

Re: [libvirt] [PATCH libvirt-java] spec: Depend on java-headless for Fedora 21+

2014-02-25 Thread Cole Robinson
On 02/25/2014 12:17 PM, Daniel P. Berrange wrote: On Tue, Feb 25, 2014 at 12:14:25PM -0500, Cole Robinson wrote: Details: https://bugzilla.redhat.com/show_bug.cgi?id=1068369 --- libvirt-java.spec.in | 4 1 file changed, 4 insertions(+) diff --git a/libvirt-java.spec.in b/libvirt

Re: [libvirt] [PATCH] qemu: Enable 'host-passthrough' cpu mode for arm

2014-02-28 Thread Cole Robinson
On 02/26/2014 11:40 AM, Oleg Strikov wrote: This patch allows libvirt user to specify 'host-passthrough' cpu mode while using qemu/kvm backend on arm (arm32). It uses 'host' as a CPU model name instead of some other stub (correct CPU detection is not implemented yet) to allow libvirt user to

<    1   2   3   4   5   6   7   8   9   10   >