Certain error paths won't unlock the node device object.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/node_device/node_device_driver.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/node_device/node_device_driver.c
b/src/node_device
These will be used by the test driver, so move them to a shareable space.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/node_device_conf.c | 89 +++
src/conf/node_device_conf.h | 11 +++
src/libvirt_private.syms |2
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c | 129 +++-
1 files changed, 127 insertions(+), 2 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 0541a73..888bc9c 100644
--- a/src/test
The following series refactors the storage pool parsing code to better
facilitate FindPoolSources (both for the test driver, and future pool backend
implementations). The last patch implements a FindPoolSources for the test
driver, with hardcoded results for test:///default.
Thanks,
Cole
Cole
We need to parse a source XML block for FindPoolSources, so this is a step
in sharing the parsing. The new storage pool XML 2 XML tests cover this area
pretty well to ensure we aren't causing regressions.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/storage_conf.c | 185
Similar in theory to *AssignDef type functions, this duplicate functionality
will be used by an future FindPoolSources implementations.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/storage_conf.c | 22 ++
src/conf/storage_conf.h
The results are hardcoded into the test driver, no option to read from a
testfile is implemented at this time.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c | 75 +--
1 files changed, 71 insertions(+), 4 deletions
This will simplify adding FindPoolSources support to more pool backends in
the future (as well as the test driver).
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/storage_conf.c | 52 ++
src/conf/storage_conf.h |4
Matthias Bolte wrote:
2009/10/12 Cole Robinson crobi...@redhat.com:
All schema tests have identical functionality, so avoid the duplication.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
 tests/Makefile.am      |   1 +
 tests/capabilityschematest  |  34
On 10/19/2009 08:54 AM, Laurent Léonard wrote:
Hi,
I'm trying to package libvirt 0.7.2 for Debian and get some linker issues :
make[3]: Entering directory `/home/user/debian/libvirt/libvirt-0.7.2/tools'
On 10/19/2009 03:18 AM, Daniel Berteaud wrote:
Le lundi 19 octobre 2009 à 09:14 +0200, Chris Lalancette a écrit :
Sascha Frey wrote:
Hi,
I met a problem setting up virt-manager and libvirt:
I want to use an existing customized network bridge with libvirt
(I need special iptables rules
On 10/17/2009 08:58 AM, Matthias Bolte wrote:
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index f09f814..77f7be3 100644
--- a/src/conf/node_device_conf.c
+++ b/src/conf/node_device_conf.c
@@ -1215,6 +1215,95 @@ virNodeDeviceDefParseFile(virConnectPtr conn,
 Â
On 10/17/2009 08:03 AM, Matthias Bolte wrote:
2009/10/16 Cole Robinson crobi...@redhat.com:
Provide a simple interface for other tests to lookup the testDebug variable.
Also remove a redundant error message in interface tests.
If anyone feels inclined to change this env variable to match
On 10/17/2009 09:10 AM, Matthias Bolte wrote:
2009/10/16 Cole Robinson crobi...@redhat.com:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
 src/test/test_driver.c |  129
+++-
 1 files changed, 127 insertions(+), 2 deletions(-)
diff
On 10/19/2009 08:40 AM, Daniel Veillard wrote:
On Fri, Oct 16, 2009 at 11:59:20AM -0400, Cole Robinson wrote:
Otherwise any virRandom calls will result in a segfault.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
tests/testutils.c |3 ++-
1 files changed, 2 insertions(+), 1
On 10/19/2009 10:38 AM, Cole Robinson wrote:
On 10/17/2009 08:03 AM, Matthias Bolte wrote:
2009/10/16 Cole Robinson crobi...@redhat.com:
Provide a simple interface for other tests to lookup the testDebug variable.
Also remove a redundant error message in interface tests.
If anyone feels
On 10/19/2009 05:28 PM, Dave Allan wrote:
Cole Robinson wrote:
Certain error paths won't unlock the node device object.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/node_device/node_device_driver.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src
On 10/20/2009 11:55 AM, Dave Allan wrote:
Cole Robinson wrote:
These will be used by the test driver, so move them to a shareable space.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/node_device_conf.c | 89 +++
src/conf/node_device_conf.h
On 10/21/2009 05:18 AM, Daniel Veillard wrote:
Cole, I'm afraid you broke the dist when making this commit
On Mon, Oct 12, 2009 at 10:46:54AM -0400, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
[...]
create mode 100644 tests/networkxml2xmlin/forward-delay
Playing with the GetVcpus API call (and virsh vcpuinfo), there is a
slight inconsistency that may be a bug.
In qemudDomainGetVcpus, we have:
if (nodeGetInfo(dom-conn, nodeinfo) 0)
goto cleanup;
maxcpu = maplen * 8;
if (maxcpu nodeinfo.cpus)
maxcpu = nodeinfo.cpus;
On 10/21/2009 04:41 PM, Matthias Bolte wrote:
If no matching device was found (cap == NULL) then no strdup() call
was made and *wwnn and *wwpn are untouched. Checking them for NULL
in this situation may result in reporting an false-positive OOM error
because *wwnn and *wwpn may be initialized
On 10/22/2009 12:20 PM, Paolo Bonzini wrote:
This patch adds an optional attribute to the bootp tag, that
allows to specify a TFTP server address other than the address of
the DHCP server itself.
This can be used to forward the BOOTP settings of the host down to the
guest. This is
On 10/22/2009 01:50 PM, shyam_i...@dell.com wrote:
snip
diff --git a/src/storage_backend_iscsi.c b/src/storage_backend_iscsi.c
index b516add..3f2a79d 100644
--- a/src/storage_backend_iscsi.c
+++ b/src/storage_backend_iscsi.c
@@ -39,6 +39,10 @@
#include storage_backend_iscsi.h
#include
On 10/23/2009 07:22 AM, Jon Nordby wrote:
The problem is due to libvirt using mount.nfs instead of mount.nfs4 for
NFSv4 shares.
virt-manager tries the following command (see attached file):
[...@jon-laptop ~]$ sudo /bin/mount 10.0.0.2:/libvirt_install
/var/lib/libvirt/images/server-install
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
virFileDeletePID() is unnecessarily called in qemudRemoveDomainStatus().
The only caller of qemudRemoveDomainStatus() is qemudShutdownVMDaemon(),
and that already calls virFileDeletePID (with a better error message).
Remove the redundant call
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
Signed-off-by: Chris Lalancette clala...@redhat.com
---
daemon/libvirtd.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 78dfb2d..03bc1b4 100644
--- a/daemon/libvirtd.c
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
(original patch from Charles Duffy)
Signed-off-by: Chris Lalancette clala...@redhat.com
---
daemon/libvirtd.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
xenUnifiedDomainEventRegister() calls out to
virDomainEventCallbackListAdd(), which increments the reference
count on the connection. That is fine, but then
xenUnifiedDomainEventRegister() increments the usage count again,
leading to a usage
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
Signed-off-by: Chris Lalancette clala...@redhat.com
---
src/libvirt.c | 41 ++---
1 files changed, 22 insertions(+), 19 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 9e87900..5787f22
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
---
src/xen/xend_internal.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
index 27d215e..d3ab019 100644
--- a/src/xen/xend_internal.c
+++
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
Signed-off-by: Chris Lalancette clala...@redhat.com
---
src/qemu/qemu_driver.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 4cd235d..da7dda7 100644
---
On 10/23/2009 10:21 AM, Cole Robinson wrote:
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
Signed-off-by: Chris Lalancette clala...@redhat.com
---
src/qemu/qemu_driver.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
Signed-off-by: Chris Lalancette clala...@redhat.com
---
daemon/libvirtd.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 4eb33bc..02bd287 100644
---
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
We can slightly tighten up the regex's used to detect the use of
nonreentrant functions. We can also check src/util/virterror.c
by modifying a comment; I think it's worth it to get the additional
coverage.
Signed-off-by: Chris Lalancette
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
We should always be using virGetHostname in place of
gethostname; thus add in a new syntax-check rule to make
sure no new uses creep in.
Signed-off-by: Chris Lalancette clala...@redhat.com
---
.x-sc_prohibit_gethostname |2 ++
On 10/22/2009 11:54 AM, Matthias Bolte wrote:
* src/qemu/qemu_conf.c: change the error message to refer to
'cgroup_controllers' instead of 'cgroup_device_acl'
---
src/qemu/qemu_conf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_conf.c
On 10/24/2009 01:30 PM, Matthias Bolte wrote:
In xenInotifyXendDomainsDirLookup() the wrong UUID variable is used
to search in the config info list.
In xenInotifyEvent() the event is dispatched if it's NULL.
Both were introduced in bc898df2c74fe3c8efedfbbd430737bac950e65e.
---
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 082cb04..a3beedb 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/libvirt.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 926c539..126675e 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -3217,7 +3217,7 @@ virDomainMigrate (virDomainPtr
All drivers have copy + pasted inadequate error reporting which wraps
util.c:virGetHostname. Move all error reporting to this function, and improve
what we report.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
daemon/libvirtd.c |3 +--
src/lxc/lxc_driver.c| 10
Currently the check for a VM name/uuid collision on the migrate destination
only errors for active domains. Not sure why this wouldn't apply for non
running VMs as well, so drop the check.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c | 11 ---
1 files
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/util/virterror.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/util/virterror.c b/src/util/virterror.c
index 657cb3f..10f979c 100644
--- a/src/util/virterror.c
+++ b/src/util/virterror.c
@@ -1082,6 +1082,7
On 10/17/2009 09:10 AM, Matthias Bolte wrote:
2009/10/16 Cole Robinson crobi...@redhat.com:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
 src/test/test_driver.c |  129
+++-
 1 files changed, 127 insertions(+), 2 deletions(-)
diff
On 10/28/2009 10:44 AM, Daniel P. Berrange wrote:
On Wed, Oct 28, 2009 at 03:32:32PM +0100, Chris Lalancette wrote:
Cole Robinson wrote:
static int umlListDomains(virConnectPtr conn, int *ids, int nids) {
diff --git a/src/util/util.c b/src/util/util.c
index 98f8a14..49eac6d 100644
On 10/28/2009 10:29 AM, Daniel Veillard wrote:
On Fri, Oct 16, 2009 at 12:35:14PM -0400, Cole Robinson wrote:
The results are hardcoded into the test driver, no option to read from a
testfile is implemented at this time.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test
On 10/28/2009 10:09 AM, Chris Lalancette wrote:
Cole Robinson wrote:
The xen driver will generate a migration port if only a hostname is passed
in the optional migrate URI, so let's do the same in qemu.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c | 29
On 10/28/2009 09:34 AM, Chris Lalancette wrote:
Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/util/virterror.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/util/virterror.c b/src/util/virterror.c
index 657cb3f..10f979c 100644
On 10/28/2009 10:26 AM, Chris Lalancette wrote:
Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/libvirt.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 926c539..126675e 100644
--- a/src/libvirt.c
On 10/28/2009 10:26 AM, Chris Lalancette wrote:
Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 082cb04..a3beedb
On 11/02/2009 10:54 AM, Chris Lalancette wrote:
Harald Dunkel wrote:
If I try this on the command line, then there is the same
0003 error.
If I omit the if=virtio for the cdrom drive, then it boots
the cd without 0003.
Yeah, the if=virtio on the cdrom line is bogus.
Can you reproduce
to virGetHostname, but I think it's worth
it.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
daemon/libvirtd.c |7 +++
src/lxc/lxc_driver.c| 16 +---
src/qemu/qemu_driver.c | 22 ++
src/test/test_driver.c | 16 +---
src/uml
- Don't duplicate SystemError
- Use proper error code in domain_conf
- Fix a broken error call in qemu_conf
- Don't use VIR_ERR_ERROR in security driver (isn't a valid code in this case)
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/domain_conf.c |2 +-
src/conf
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/storage_encryption_conf.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf/storage_encryption_conf.c
b/src/conf/storage_encryption_conf.c
index b97b989..a329622 100644
--- a/src/conf
As pointed out by Dan here:
https://www.redhat.com/archives/libvir-list/2009-October/msg00784.html
We should be using the same logic for collision prevention and domain
redefinition in
the migrate routines as we use in create/define/restore.
Cole Robinson (3):
qemu: Remove compiled out
Pretty sure this would deadlock now that we have proper locking, so
remove the code.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c | 12
1 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c | 151 +++-
1 files changed, 59 insertions(+), 92 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 7eed356..e038887 100644
--- a/src/qemu
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c | 30 --
1 files changed, 4 insertions(+), 26 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e038887..6981d99 100644
--- a/src/qemu/qemu_driver.c
+++ b/src
;a=commit;h=3505790b85da55c16191a9dca46404c29e0b7f87
Cole Robinson (6):
test: Fixes for SetVcpus
test: Break out wrapper for setting up started domain state.
test: Use privateData to track running VM vcpu state
test: Update vcpu runtime info in SetVcpus
test: Implement virDomainGetVcpus
test
- Implement DomainGetMaxVCPUs
- Use GetMaxVCPUs to validate requested CPU amount
- Deny the 'hotplug' for a running domain.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c | 26 ++
1 files changed, 22 insertions(+), 4 deletions(-)
diff --git
This should be a no op for now, but we will use this function to set up
transient state in the future.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c | 42 --
1 files changed, 32 insertions(+), 10 deletions(-)
diff --git
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c | 135 +++-
1 files changed, 133 insertions(+), 2 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 8472e27..a8bec58 100644
--- a/src/test
is implemented.
Thanks,
Cole
commit 59871ddf8956a96a1148769c05ada6e763d91080
Author: Cole Robinson crobi...@redhat.com
Date: Mon Nov 2 15:34:46 2009 -0500
Add virConnectGetLibvirtVersion
There is currently no way to determine the libvirt version of a remote libvirtd we
are connected
On 11/03/2009 05:38 AM, Harald Dunkel wrote:
Cole Robinson wrote:
Yeah, the commit is here (the last hunk is the important one):
http://hg.fedorahosted.org/hg/python-virtinst/rev/252ff7bc5ff9
Relevant fedora packages should have the fix.
Maybe you could do the community outside
On 11/03/2009 07:35 AM, Chris Lalancette wrote:
When building with --disable-nls, I got a few messages like this:
storage/storage_backend.c: In function 'virStorageBackendCreateQemuImg':
storage/storage_backend.c:571: warning: format not a string literal and no
format arguments
Fix these
On 11/03/2009 07:35 AM, Chris Lalancette wrote:
qemudShutdownVMDaemon() calls qemudRemoveDomainStatus(), which
then calls virFileDeletePID(). qemudShutdownVMDaemon() then
unnecessarily calls virFileDeletePID() again. Remove this second
usage of it, and also slightly refactor
On 11/02/2009 02:52 PM, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c | 151
+++-
1 files changed, 59 insertions(+), 92 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu
On 11/03/2009 03:29 PM, Daniel Veillard wrote:
On Mon, Nov 02, 2009 at 02:44:12PM -0500, Cole Robinson wrote:
All drivers have copy + pasted inadequate error reporting which wraps
util.c:virGetHostname. Move all error reporting to this function, and improve
what we report.
Changes from v1
On 11/03/2009 03:59 PM, Daniel P. Berrange wrote:
On Mon, Nov 02, 2009 at 03:02:44PM -0500, Cole Robinson wrote:
Looks good apart from the tiny leak
Daniel
I've pushed this series with the leak fix you mentioned above.
Thanks,
Cole
--
Libvir-list mailing list
Libvir-list@redhat.com
On 11/03/2009 04:00 PM, Daniel P. Berrange wrote:
On Mon, Nov 02, 2009 at 02:52:37PM -0500, Cole Robinson wrote:
Pretty sure this would deadlock now that we have proper locking, so
remove the code.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c | 12
On 11/03/2009 03:38 PM, Daniel Veillard wrote:
On Mon, Nov 02, 2009 at 02:44:13PM -0500, Cole Robinson wrote:
- Don't duplicate SystemError
- Use proper error code in domain_conf
- Fix a broken error call in qemu_conf
- Don't use VIR_ERR_ERROR in security driver (isn't a valid code
On 11/03/2009 03:39 PM, Daniel Veillard wrote:
On Mon, Nov 02, 2009 at 02:44:14PM -0500, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/storage_encryption_conf.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf
Performs changes needed when stopping a VM (which are currently duplicated
in several places, and forgotten in others).
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c | 42 +++---
1 files changed, 23 insertions(+), 19 deletions
This matches the expected behavior of state drivers such as QEMU.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/test/test_driver.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 35299d5..343834c
Code to check for a VM duplicate in create/define/restore is present in
various forms throughout several drivers. Break this code out into its
own function (virDomainObjIsDuplicate) and use where applicable.
Cole Robinson (2):
qemu: Break out function to check if we can create/define/restore
Use this function in the qemu, uml, lxc, and test drivers.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/conf/domain_conf.c | 64 +
src/conf/domain_conf.h |4 ++
src/libvirt_private.syms |1 +
src/lxc/lxc_driver.c | 68
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/qemu/qemu_driver.c | 30 --
1 files changed, 4 insertions(+), 26 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 20621d1..53f7398 100644
--- a/src/qemu/qemu_driver.c
+++ b/src
On 11/10/2009 06:56 PM, Ryota Ozaki wrote:
qemu/qemu_monitor_text.c: In function 'qemuMonitorTextIOProcess':
qemu/qemu_monitor_text.c:175: error: format '%d' expects type 'int', but
argument 7 has type 'size_t'
* src/qemu/qemu_monitor.c src/qemu/qemu_monitor_text.c:
cast size_t to int
Hi Chris (and list),
Playing with TUNNELLED migration, I'm hitting an issue. Take this example:
VM URI = qemu+ssh://phys1/system
destconn = qemu:///system
invoking virDomainMigrate with a VM from the former URI, and destconn as the
latter, we will deadlock. The qemu driver would be reopening
On 11/11/2009 03:04 AM, Daniel P. Berrange wrote:
On Tue, Nov 10, 2009 at 09:05:46PM -0500, Cole Robinson wrote:
Hi Chris (and list),
Playing with TUNNELLED migration, I'm hitting an issue. Take this example:
VM URI = qemu+ssh://phys1/system
destconn = qemu:///system
invoking
On 11/12/2009 06:49 AM, Daniel P. Berrange wrote:
On Mon, Nov 02, 2009 at 03:52:28PM -0500, Cole Robinson wrote:
Hi all,
The attached patch adds a new API call for retrieving the libvirt
version used by a connection: virConnectGetLibvirtVersion. Without this,
there is currently no way
On 11/02/2009 03:52 PM, Cole Robinson wrote:
Hi all,
The attached patch adds a new API call for retrieving the libvirt
version used by a connection: virConnectGetLibvirtVersion. Without this,
there is currently no way to determine the libvirt version of a remote
qemu connection for example
On 11/13/2009 12:18 PM, Guido Günther wrote:
On Thu, Nov 05, 2009 at 08:35:20PM +0100, Guido Günther wrote:
Hi,
attached patch makes sure we only remove the masquerade rules if
forwardType == VIR_NETWORK_FORWARD_NAT and not if forwardType ==
VIR_NETWORK_FORWARD_ROUTE since we don't use them
On 11/13/2009 06:08 PM, Jim Fehlig wrote:
detach-disk was not working for inactive xen domains due to lookup of
device ID from xenstore. When detaching disks there is no need to use
device id as device name can be used directly. Unfortunately that same
is not true for network devices. In
On 11/16/2009 12:33 AM, Thomas Treutner wrote:
Hi,
I'm having a little problem when triggering (live) migration from
libvirt-java
(libvirt.so at client is approx. 0.7.1), I get an error that the qemu://
driver for migration URIs is not supported, only qemu+tcp://
Strange thing is,
On 11/18/2009 09:28 AM, Thomas Treutner wrote:
On Wednesday 18 November 2009 14:05:03 Bryan Kearney wrote:
thanks.. I am in the code right now.. what would have been better in the
javadoc for you? I will put it in.
...
If uri is NULL, then libvirt will try to find the best method. Uri may
On 11/18/2009 11:00 AM, Daniel P. Berrange wrote:
The qemudStartVMDaemon() and several functions it calls use
the QEMU monitor. The QEMU driver is locked while this function
is executing, so it is rquired to release the driver lock and
reacquire it either side of issuing a monitor command. It
These have never worked. Would be nice to get this in the pending release!
Signed-off-by: Cole Robinson crobi...@redhat.com
---
python/generator.py |4 +-
python/libvirt-override-api.xml | 10
python/libvirt-override.c | 102
People have been confused about this in the past, so document that
vnet and vif are reserved names and will be ignored if manually specified.
Signed-off-by: Cole Robinson crobi...@redhat.com
---
docs/formatdomain.html.in | 31 ++-
1 files changed, 26 insertions
cc-ing libvirt-list
On 11/19/2009 10:35 PM, Dustin Xiong wrote:
Hi everyone!
I am a newer to the virt-manager and maillist. I sent the mail just want
to ask some questions about virt-manager running on Arch of Itanium 64.
My itanium 64 cpu actualy support the VT. I compiled the kvm85
Recent generator refactoring broke libvirt.py. With this patch, libvirt.py
is generated exactly the same as before the offending commit.
---
python/generator.py |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/python/generator.py b/python/generator.py
index
On 09/14/2011 04:27 PM, Cole Robinson wrote:
Recent generator refactoring broke libvirt.py. With this patch, libvirt.py
is generated exactly the same as before the offending commit.
---
python/generator.py |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
Just to be clear
On 09/14/2011 05:35 PM, Eric Blake wrote:
On 09/14/2011 02:27 PM, Cole Robinson wrote:
Recent generator refactoring broke libvirt.py. With this patch, libvirt.py
is generated exactly the same as before the offending commit.
Mention the actual commit that caused the regression: 9eba0d25
The wiki's been spammed, see November 9 for example:
http://wiki.libvirt.org/page/Special:Recentchanges
virt-manager.org had a similar problem. Any one know any good proactive
ways to prevent this?
- Cole
--
libvir-list mailing list
libvir-list@redhat.com
On 11/10/2011 03:10 PM, Daniel P. Berrange wrote:
On Thu, Nov 10, 2011 at 02:50:30PM -0500, Cole Robinson wrote:
The wiki's been spammed, see November 9 for example:
http://wiki.libvirt.org/page/Special:Recentchanges
virt-manager.org had a similar problem. Any one know any good proactive
On 11/20/2009 01:39 PM, Jim Fehlig wrote:
Daniel Veillard wrote:
On Mon, Nov 16, 2009 at 04:06:41PM -0700, Jim Fehlig wrote:
virDomain{Attach,Detach}Device is only permitted on active
domains. Explicitly state this restriction in the API
documentation.
Well, actually I'm not
On 11/20/2009 08:16 AM, Thomas Baker wrote:
cc-ing libvirt-list, since that's where this functionality would live.
I'm running virt-manager 0.7 on Fedora 11 and I recently converted a
parallels win2003 server over to run there. I've been running Xen paravirt
guests under CentOS 5 and when
On 11/23/2009 01:43 AM, Dustin Xiong wrote:
Date: Fri, 20 Nov 2009 08:14:09 -0500, cole wrote:
cc-ing libvirt-list
My cpu is itanium 64, the OS is RHEL.The libvirt is 0.6.3,
virt-manager
is 0.6.1.
Ah, are you using the version of libvirt that comes with RHEL 5.4? That
version has
On 11/25/2009 11:36 AM, Michael N. Moran wrote:
First, I am a casual VM user. I have been using
Fedora Core 7 on my Dell laptop for a couple of
years with a single QEMU/KVM guest running Windoze XP.
I recently installed Fedora 12 on a new hard disk
and would like to use my old Windows VM
On 11/25/2009 01:27 PM, Michael N. Moran wrote:
On 11/25/2009 12:53 PM, Cole Robinson wrote:
On 11/25/2009 11:36 AM, Michael N. Moran wrote:
First, I am a casual VM user. I have been using
Fedora Core 7 on my Dell laptop for a couple of
years with a single QEMU/KVM guest running Windoze XP
On 11/26/2009 07:06 PM, Nix wrote:
The only remaining obvious problem is virt-manager-related, I think:
this log spam:
Nov 27 00:04:38 spindle err: 00:04:38.977: error : virLibConnError:383 : this
function is not supported by the hypervisor: virConnectNumOfInterfaces
Nov 27 00:04:38
701 - 800 of 3789 matches
Mail list logo
