Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

On Fri, Jul 20, 2018 at 12:24:50PM +0200, Ján Tomko wrote: > On Thu, Jul 19, 2018 at 07:38:15PM -0400, John Ferlan wrote: > > > > > > On 07/18/2018 10:44 AM, Ján Tomko wrote: > > > Unless explicitly requested, enable the QEMU driver > > > only if the Jansson library is present. > > > > > >

[libvirt] [PATCH 0/2] rpm: modernize the spec file for RHEL

Drop conditionals for RHEL-6 and assume systemd is present Daniel P. Berrangé (2): rpm: increase min required RHEL to 7 rpm: remove conditionals for systemd libvirt.spec.in | 246 1 file changed, 20 insertions(+), 226 deletions(-) -- 2.17.1

[libvirt] [PATCH 1/2] rpm: increase min required RHEL to 7

We no longer build on RHEL-6, so can bump min required RHEL to 7 removing many conditions. Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 92 ++--- 1 file changed, 11 insertions(+), 81 deletions(-) diff --git a/libvirt.spec.in b

[libvirt] [PATCH 2/2] rpm: remove conditionals for systemd

All our supported RHEL and Fedora versions include systemd, so we can assume it is always present in the spec. Signed-off-by: Daniel P. Berrangé --- libvirt.spec.in | 160 1 file changed, 12 insertions(+), 148 deletions(-) diff --git

Re: [libvirt] [PATCH] src: Fix memory leak in virNWFilterBindingDispose

t; index 878a1c5b5f..caf035f178 100644 > --- a/src/datatypes.c > +++ b/src/datatypes.c > @@ -893,6 +893,7 @@ virNWFilterBindingDispose(void *obj) > VIR_DEBUG("release binding %p %s", binding, binding->portdev); > > VIR_FREE(binding->portdev); > +VIR_FR

Re: [libvirt] [PATCH 4/4] qemu: vnc: switch to tls-creds-x509

On Wed, Jul 18, 2018 at 09:55:47AM +0200, Ján Tomko wrote: > On Wed, Jul 18, 2018 at 08:32:44AM +0100, Daniel P. Berrangé wrote: > > On Tue, Jul 17, 2018 at 05:15:56PM +0200, Ján Tomko wrote: > > > The tls, x509 and x509verify options were deprecated in QEMU v2.5.0: &

Re: [libvirt] [PATCH 4/4] qemu: vnc: switch to tls-creds-x509

On Tue, Jul 17, 2018 at 05:15:56PM +0200, Ján Tomko wrote: > The tls, x509 and x509verify options were deprecated in QEMU v2.5.0: > > commit 3e305e4a4752f70c0b5c3cf5b43ec957881714f7 > Author: Daniel P. Berrange > > ui: convert VNC server to use QCryptoTLSSession > > Use the

[libvirt] [PATCH] locking: don't create qemu-sanlock.conf file when QEMU isn't enabled

The test targets result in the qemu-sanlock.conf file being created when sanlock is enabled, even if QEMU is not enabled. As a result it never gets cleaned up when distclean is run, breaking distcheck. Signed-off-by: Daniel P. Berrangé --- src/locking/Makefile.inc.am | 8 ++-- 1 file

[libvirt] [PATCH] tests: fix TLS handshake failure with TLS 1.3

the certificate for verification and the test failed. This is exposed in Fedora 29 rawhide which has just enabled TLS 1.3 in its GNUTLS builds. Signed-off-by: Daniel P. Berrangé --- tests/virnettlssessiontest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests

Re: [libvirt] CPU Support

On Wed, Jul 18, 2018 at 12:41:48PM +0300, Hetz Ben Hamo wrote: > Hi, > > I've been looking at the CPU list and although I see lots of CPU's, I > cannot find 2 CPU families: > > * AMD Ryzen > * AMD Threadripper > > Although EPYC has been added recently. > > Are there any missing details which

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On Thu, Jul 12, 2018 at 05:47:00PM +0200, Thomas Huth wrote: > On 12.07.2018 08:32, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > [...] > >> For libvirt, I think whenever something is proposed for deprecation > >> we could just CC libvir-list, or

Re: [libvirt] [PATCH 1/2] qemu-doc: Move appendix "Deprecated features" to its own file

ed, 235 insertions(+), 234 deletions(-) > create mode 100644 qemu-deprecated.texi Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop1

Re: [libvirt] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list

anges > +R: libvir-list@redhat.com > +F: qemu-deprecated.texi > + > Build System > > GIT submodules Reviewed-by: Daniel P. Berrangé Note, that libvir-list requires senders to be subscribed before mails are delivered, otherwise they go into moderation queue. My n

Re: [libvirt] [PATCH v2 7/9] rpc: Alter virNetDaemonQuit processing

On Thu, Jul 12, 2018 at 03:34:00PM -0400, John Ferlan wrote: > > > On 07/09/2018 03:11 AM, Peter Krempa wrote: > > On Sat, Jul 07, 2018 at 08:11:05 -0400, John Ferlan wrote: > >> When virNetDaemonQuit is called from libvirtd's shutdown > >> handler (daemonShutdownHandler) we need to perform the

Re: [libvirt] [go PATCH 00/37] Fix error reporting thread safety wrt goroutine rescheduling

This series has been tested by the KubeVirt devs who confirmed it fixes the problems they see, so I'll push it shortly. On Mon, Jul 16, 2018 at 02:23:46PM +0100, Daniel P. Berrangé wrote: > The Libvirt C API provides the virGetLastError() function to let callers > aquire the error infor

Re: [libvirt] [PATCHv4 13/15] build: switch --with-qemu default from yes to check

On Mon, Jul 23, 2018 at 09:38:47AM +0200, Andrea Bolognani wrote: > On Mon, 2018-07-23 at 09:27 +0200, Andrea Bolognani wrote: > > On Fri, 2018-07-20 at 11:33 +0100, Daniel P. Berrangé wrote: > > > On Fri, Jul 20, 2018 at 12:24:50PM +0200, Ján Tomko wrote: > > >

[libvirt] [python PATCH 3/3] rpm: update min required rhel/fedora

Signed-off-by: Daniel P. Berrangé --- libvirt-python.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 8709317..21dc713 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -3,8 +3,8

[libvirt] [python PATCH 2/3] rpm: add BuildRequires on gcc

The gcc RPM is no longer part of the default build root. Signed-off-by: Daniel P. Berrangé --- libvirt-python.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 589855e..8709317 100644 --- a/libvirt-python.spec.in +++ b/libvirt

[libvirt] [python PATCH 0/3] rpm: misc updates to modernize spec

Daniel P. Berrangé (3): rpm: use the versioned python2 macro names rpm: add BuildRequires on gcc rpm: update min required rhel/fedora libvirt-python.spec.in | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) -- 2.17.1 -- libvir-list mailing list libvir

[libvirt] [python PATCH 1/3] rpm: use the versioned python2 macro names

The use of non-versioned python2 macro names is deprecated in Fedora Signed-off-by: Daniel P. Berrangé --- libvirt-python.spec.in | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index f3940cc..589855e 100644

Re: [libvirt] [dockerfiles PATCH] refresh: Add refresh script

; --- > refresh | 30 ++ > 1 file changed, 30 insertions(+) > create mode 100755 refresh Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -

Re: [libvirt] [PATCH] New virsh feature: domif-setlink --domain --interface --state completer

On Mon, Jul 16, 2018 at 02:47:40PM +0200, Peter Krempa wrote: > On Thu, Jul 12, 2018 at 10:15:22 +0200, Simon Kobyda wrote: > > After you go through command mentioned above, completer finds > > what state the device is currently in, and suggests an opposite state. > > --- > >

[libvirt] [go PATCH 01/37] error: add helper for converting libvirt to go error objects

Signed-off-by: Daniel P. Berrangé --- error.go | 11 +++ 1 file changed, 11 insertions(+) diff --git a/error.go b/error.go index bee8b70..b8e2900 100644 --- a/error.go +++ b/error.go @@ -583,6 +583,17 @@ func (err Error) Error() string { err.Code, err.Domain, err.Message

[libvirt] [go PATCH 02/37] storage volume: add missin blank line

Signed-off-by: Daniel P. Berrangé --- storage_volume.go | 1 + 1 file changed, 1 insertion(+) diff --git a/storage_volume.go b/storage_volume.go index 22dd284..739cdb2 100644 --- a/storage_volume.go +++ b/storage_volume.go @@ -239,6 +239,7 @@ func (v *StorageVol) Wipe(flags uint32) error

[libvirt] [go PATCH 04/37] Use "Wrapper" or "Helper" as suffix for C functions

Instead of using "_cgo" for multiple scenarios, use "Wrapper" as suffix where a libvirt API is being wrapped, and "Helper" as a suffix where we are implementing a helper function (eg an event callback). Signed-off-by: Daniel P. Berrangé --- api_test.go

[libvirt] [go PATCH 05/37] Change "Compat" suffix to "Wrapper" to have standard naming scheme

There are many reasons why we need to create wrappers around the native libvirt public APIs, and multiple reasons may apply to the same function. Using a standard "Wrapper" suffix will clarify it. Signed-off-by: Daniel P. Berrangé --- api_test.go| 2 +-

[libvirt] [go PATCH 21/37] storage pool: fix error reporting thread safety

Create wrapper functions for each storage pool C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- storage_pool.go | 117

[libvirt] [go PATCH 11/37] stream: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- stream_compat.go | 69 --- stream_compat.h | 13 - stream_wrapper.go | 34 +++ stream_wrapper.h | 12 + 4 files changed, 46 insertions(+), 82 deletions(-) delete mode 100644

[libvirt] [go PATCH 25/37] nwfilter binding: fix error reporting thread safety

Create wrapper functions for each nwfilter binding C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- nwfilter_binding.go

[libvirt] [go PATCH 07/37] network: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- network.go | 1 + network_compat.h| 10 --- network_events_wrapper.go | 10 +++ network_events_wrapper.h| 8 ++ network_compat.go => network_wrapper.go |

[libvirt] [go PATCH 18/37] Add XXX_wrapper.{h, go} for every remaining file

Signed-off-by: Daniel P. Berrangé --- domain_snapshot_wrapper.go | 34 ++ domain_snapshot_wrapper.h | 32 interface_wrapper.go | 34 ++ interface_wrapper.h| 32

[libvirt] [go PATCH 16/37] domain: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- domain.go | 1 + domain_compat.h | 141 --- domain_compat.go => domain_wrapper.go | 2 +- domain_wrapper.h | 157 ++ 4 files changed,

[libvirt] [go PATCH 32/37] qemu: fix error reporting thread safety

Create wrapper functions for each qemu C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- qemu.go | 31

[libvirt] [go PATCH 27/37] network: fix error reporting thread safety

Create wrapper functions for each network C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- network.go | 80

[libvirt] [go PATCH 14/37] qemu: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- qemu_compat.go | 48 qemu_compat.h | 3 --- qemu_wrapper.go | 10 ++ qemu_wrapper.h | 3 +++ 4 files changed, 13 insertions(+), 51 deletions(-) delete mode 100644 qemu_compat.go diff --git

[libvirt] [go PATCH 22/37] stream: fix error reporting thread safety

Create wrapper functions for each stream C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- stream.go | 80

[libvirt] [go PATCH 20/37] storage vol: fix error reporting thread safety

Create wrapper functions for each storage volume C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- storage_volume.go

[libvirt] [go PATCH 15/37] lxc: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- lxc.go | 2 +- lxc_compat.go => lxc_wrapper.go | 2 +- lxc_compat.h => lxc_wrapper.h | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename lxc_compat.go => lxc_wrapper.go (98%) rename lxc_compat.h => lxc_wr

[libvirt] [go PATCH 12/37] storage volume: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- storage_volume.go | 1 + storage_volume_compat.h | 4 --- ...ume_compat.go => storage_volume_wrapper.go | 1 + storage_volume_wrapper.h | 34 +++ 4 files changed,

[libvirt] [go PATCH 08/37] nwfilter binding: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- nwfilter_binding.go | 1 + nwfilter_binding_compat.h | 11 -- ...g_compat.go => nwfilter_binding_wrapper.go | 1 + nwfilter_binding_wrapper.h| 38 +++ 4 files changed,

[libvirt] [go PATCH 10/37] secret: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- secret_compat.go | 47 secret_compat.h | 3 --- secret_events_wrapper.go | 11 ++ secret_events_wrapper.h | 6 +++-- 4 files changed, 15 insertions(+), 52 deletions(-) delete mode 100644

[libvirt] [go PATCH 09/37] node device: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- node_device_compat.go | 46 --- node_device_compat.h | 3 --- node_device_events_wrapper.go | 10 node_device_events_wrapper.h | 9 --- 4 files changed, 16 insertions(+), 52 deletions

[libvirt] [go PATCH 06/37] connect: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- connect_compat.go | 206 - connect_compat.h | 81 -- connect_wrapper.go | 172 + connect_wrapper.h | 75 + 4 files changed, 247 insertions

[libvirt] [go PATCH 35/37] error: remove GetLastError() function

an error object directly so nothing should need the GetLastError() binding anyway. Signed-off-by: Daniel P. Berrangé --- api_test.go | 1 + error.go| 20 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/api_test.go b/api_test.go index a16a1eb..564bdd4

[libvirt] [go PATCH 17/37] make the XXX_wrapper.h header files self-contained

Pull in the main libvirt headers and compat headers from XXX_wrapper.h so that they are self-contained Signed-off-by: Daniel P. Berrangé --- callbacks_wrapper.go | 2 -- connect.go | 3 --- connect_wrapper.go | 2 -- connect_wrapper.h | 5

[libvirt] [go PATCH 23/37] secret: fix error reporting thread safety

Create wrapper functions for each secret C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- secret.go | 50

[libvirt] [go PATCH 13/37] storage pool: move wrapper functions out of compat header

Signed-off-by: Daniel P. Berrangé --- storage_pool_compat.go | 46 -- storage_pool_compat.h | 4 --- storage_pool_events_wrapper.go | 10 storage_pool_events_wrapper.h | 2 ++ 4 files changed, 12 insertions(+), 50 deletions(-) delete

[libvirt] [go PATCH 19/37] Standardize formatting in all wrapper headers

Signed-off-by: Daniel P. Berrangé --- connect.go| 2 +- connect_wrapper.go| 2 +- connect_wrapper.h | 169 +++- domain_events_wrapper.h | 258 +++--- domain_snapshot.go| 3

[libvirt] [go PATCH 00/37] Fix error reporting thread safety wrt goroutine rescheduling

... } The wrapper function is responsible for calling virGetLastError() and since this is C code, we're guaranteed its all in the same OS level thread. Daniel P. Berrangé (37): error: add helper for converting libvirt to go error objects storage volume: add missin blank line Rename *cfuncs.{go,h

[libvirt] [go PATCH 03/37] Rename *cfuncs.{go, h} to *wrapper.{go, h}

Signed-off-by: Daniel P. Berrangé --- api_test.go | 2 +- callbacks_cfuncs.go => callbacks_wrapper.go | 2 +- callbacks_cfuncs.h => callbacks_wrapper.h | 6 +++--- conn

[libvirt] [go PATCH 37/37] connect: add missing references on domain object in stats records

Signed-off-by: Daniel P. Berrangé --- connect.go | 4 1 file changed, 4 insertions(+) diff --git a/connect.go b/connect.go index 34a96ed..8cc7cc7 100644 --- a/connect.go +++ b/connect.go @@ -2915,6 +2915,10 @@ func (c *Connect) GetAllDomainStats(doms []*Domain, statsTypes DomainStatsTypes

[libvirt] [go PATCH 33/37] lxc: fix error reporting thread safety

Create wrapper functions for each lxc C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- lxc.go | 20

[libvirt] [go PATCH 34/37] events: fix error reporting thread safety

Create wrapper functions for each events C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- domain_events.go

[libvirt] [go PATCH 28/37] interface: fix error reporting thread safety

Create wrapper functions for each interface C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- interface.go | 45

[libvirt] [go PATCH 36/37] error: make GetNotImplementedError private

The GetNotImplementedError() method is only for internal use so should not have a public name. Signed-off-by: Daniel P. Berrangé --- connect.go | 24 +- domain.go | 56 +- error.go | 2 +- lxc.go

[libvirt] [go PATCH 24/37] nwfilter: fix error reporting thread safety

Create wrapper functions for each nwfilter C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- nwfilter.go | 35

[libvirt] [go PATCH 26/37] node device: fix error reporting thread safety

Create wrapper functions for each node device C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- node_device.go | 62

[libvirt] [go PATCH 29/37] domain snapshot: fix error reporting thread safety

Create wrapper functions for each domain snapshot C API that accepts a virErrorPtr parameter. This avoids accessing a thread local from a goroutine which may race with other goroutines doing native API calls in the same OS thread. Signed-off-by: Daniel P. Berrangé --- domain_snapshot.go

[libvirt] [PATCH 1/2] doc: switch to modern syntax for VNC TLS setup

The use of 'tls', 'x509' and 'x509verify' properties is the deprecated backcompat syntax, replaced by use of TLS creds objects. Signed-off-by: Daniel P. Berrangé --- qemu-doc.texi | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/qemu-doc.texi b/qemu

[libvirt] [PATCH 0/2] vnc: remove deprecated TLS related features

Daniel P. Berrangé (2): doc: switch to modern syntax for VNC TLS setup vnc: remove support for deprecated tls, x509, x509verify options qemu-deprecated.texi | 20 -- qemu-doc.texi| 20 +++--- qemu-options.hx | 43 - ui/vnc.c | 91

[libvirt] [PATCH 2/2] vnc: remove support for deprecated tls, x509, x509verify options

-by: Daniel P. Berrangé --- qemu-deprecated.texi | 20 -- qemu-options.hx | 43 - ui/vnc.c | 91 3 files changed, 154 deletions(-) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 9920a85adc..6b92cec48a

Re: [libvirt] [jenkins-ci PATCH] guests: Make mappings more future proof

> Rewrite some of the mappings based on these expectations. > > Signed-off-by: Andrea Bolognani > --- > guests/vars/mappings.yml | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

[libvirt] [PATCH] IGNORE. Testing patchew.org syntax-check reporting

Signed-off-by: Daniel P. Berrangé --- src/libvirt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index aeb8804714..ed4ec062e7 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -21,8 +21,6 @@ * Daniel Veillard */ -#include - #include #include

[libvirt] [go PATCH] travis: update some of the test matrix versions to moderize coverage

Add latest go 1.10 to matrix and (arbitrarily) trim out 1.6 and 1.8 Add libvirt 4.5.0 and (arbitrarily) trim out 1.2.10 Signed-off-by: Daniel P. Berrangé --- .travis.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 1bdb48f..7cd7587

Re: [libvirt] [go PATCH] travis: update some of the test matrix versions to moderize coverage

On Wed, Jul 25, 2018 at 02:12:26PM +0200, Andrea Bolognani wrote: > On Wed, 2018-07-25 at 12:58 +0100, Daniel P. Berrangé wrote: > > Add latest go 1.10 to matrix and (arbitrarily) trim out 1.6 and 1.8 > > > > Add libvirt 4.5.0 and (arbitrarily) trim out 1.2.10 > >

Re: [libvirt] [PATCH 1/2] socket: preserve real errno when socket/bind calls fail

On Tue, Jul 24, 2018 at 05:51:50PM +0200, Jiri Denemark wrote: > On Tue, Jul 24, 2018 at 15:18:09 +0100, Daniel P. Berrangé wrote: > > When reporting socket/bind failures we want to ensure any fatal error > > reported is as accurate as possible. We'll prefer reporting a bind()

[libvirt] [PATCH 0/2] Allow for further expected failures when listening on sockets

Daniel P. Berrangé (2): socket: preserve real errno when socket/bind calls fail rpc: treat EADDRNOTAVAIL as non-fatal when listening src/rpc/virnetsocket.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) -- 2.17.1 -- libvir-list mailing list libvir

[libvirt] [PATCH 1/2] socket: preserve real errno when socket/bind calls fail

When reporting socket/bind failures we want to ensure any fatal error reported is as accurate as possible. We'll prefer reporting a bind() errno over a socket() errno, because if socket() works but bind() fails that is a more significant event. Signed-off-by: Daniel P. Berrangé --- src/rpc

[libvirt] [PATCH 2/2] rpc: treat EADDRNOTAVAIL as non-fatal when listening

will have IPv6 and so bind() would fail with the EADDRNOTAVAIL errno. Thus it should be treated as non-fatal as long as at least one socket was succesfully bound. Signed-off-by: Daniel P. Berrangé --- src/rpc/virnetsocket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc

Re: [libvirt] [PATCH] qemu: caps: use model "qemu" for s390 tcg cpu-model-expansion

On Tue, Jul 24, 2018 at 06:53:54PM +0200, Cornelia Huck wrote: > On Tue, 24 Jul 2018 18:08:21 +0200 > Jiri Denemark wrote: > > > On Mon, Jul 23, 2018 at 17:45:33 -0400, Collin Walling wrote: > > > Use model name "qemu" instead of "max" when calling > > > query-cpu-model-expansion for s390 on

Re: [libvirt] [PATCH v1 15/40] util: firewall: use VIR_AUTOFREE instead of VIR_FREE for scalar types

On Tue, Jul 24, 2018 at 10:46:54PM +0530, Sukrit Bhatnagar wrote: > On Tue, 24 Jul 2018 at 11:54, Erik Skultety wrote: > > > > On Mon, Jul 23, 2018 at 11:18:07PM +0530, Sukrit Bhatnagar wrote: > > > On Mon, 23 Jul 2018 at 18:39, Erik Skultety wrote: > > > > > > > > On Sat, Jul 21, 2018 at

Re: [libvirt] [PATCH 3/3] m4: Work around MinGW detection of strncpy() usage

On Tue, Jul 17, 2018 at 01:09:57PM +0200, Andrea Bolognani wrote: > With the recent update in Fedora Rawhide, MinGW has > started freaking out about our use of strncpy(): > > In function 'virStrncpy', > inlined from 'virStrcpy' at ../../src/util/virstring.c:811:12: >

[libvirt] [PATCH] Update to latest gnulib to fix ffs() detection on mingw

ffs() was not correctly detected on mingw with previous gnulib rebase: https://lists.gnu.org/archive/html/bug-gnulib/2018-07/msg00061.html. Signed-off-by: Daniel P. Berrangé --- .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed as a mingw build fix diff --git a/.gnulib b

Re: [libvirt] [PATCH] maint: update to latest gnulib

On Tue, Jul 17, 2018 at 10:14:18AM +0200, Andrea Bolognani wrote: > On Sat, 2018-07-14 at 09:20 +0200, Michal Privoznik wrote: > > The changelog is quite long because we haven't updated gnulib in > > a while. Anyway, among the new changes you'll find GCC 8 support, > > faster build time, mingw

Re: [libvirt] [PATCH] spec: remove libcgroup and cgconfig

f-by: Pavel Hrdina > --- > libvirt.spec.in | 19 --- > 1 file changed, 19 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop1

[libvirt] [PATCH] Add DOMAIN_MEMORY_STAT_DISK_CACHES constant

Signed-off-by: Daniel P. Berrangé --- domain.go | 1 + domain_compat.h | 6 ++ 2 files changed, 7 insertions(+) Pushed as a build fix diff --git a/domain.go b/domain.go index cc0285b..6a9e2a1 100644 --- a/domain.go +++ b/domain.go @@ -377,6 +377,7 @@ const

[libvirt] [perl PATCH] Add VIR_DOMAIN_MEMORY_STAT_DISK_CACHES constant

Signed-off-by: Daniel P. Berrangé --- Changes| 2 +- lib/Sys/Virt.xs| 5 + lib/Sys/Virt/Domain.pm | 4 3 files changed, 10 insertions(+), 1 deletion(-) Pushed as a build fix diff --git a/Changes b/Changes index 74bbb22..4c77425 100644 --- a/Changes +++ b

Re: [libvirt] [go PATCH] Add DOMAIN_MEMORY_STAT_DISK_CACHES constant

Sorry this checkout was missing the subject prefix config. This is for the go binding. On Wed, Jul 18, 2018 at 02:47:03PM +0100, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > domain.go | 1 + > domain_compat.h | 6 ++ > 2 files change

Re: [libvirt] [PATCH v2 2/2] nwfilter: Check for filter presence before open connect during teardown

rc/conf/domain_nwfilter.c | 22 +++--- > 1 file changed, 15 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fsto

Re: [libvirt] [PATCH v2 1/2] nwfilter: Disallow binding creation in session mode

On Thu, Aug 30, 2018 at 11:06:07AM -0400, John Ferlan wrote: > Similar to nwfilterDefineXML, let's be sure the a filter binding > creation is not attempted in session mode and generate the proper > error message. > > Failure to open nwfilter in session mode (nwfilterConnectOpen) > fails already,

Re: [libvirt] [PATCH v2 1/2] nwfilter: Disallow binding creation in session mode

On Thu, Aug 30, 2018 at 12:50:09PM -0400, John Ferlan wrote: > > > On 08/30/2018 12:27 PM, Daniel P. Berrangé wrote: > > On Thu, Aug 30, 2018 at 11:06:07AM -0400, John Ferlan wrote: > >> Similar to nwfilterDefineXML, let's be sure the a filter binding > >> cre

Re: [libvirt] [PATCH v3 00/28] Introduce metadata locking

On Mon, Aug 27, 2018 at 10:08:13AM +0200, Michal Privoznik wrote: > v3 of: > > https://www.redhat.com/archives/libvir-list/2018-August/msg00814.html > > What has changed since v2? A lot. > - The lock manager was moved into security manager (which requires a lot > of preparation which is done

Re: [libvirt] [PATCH 4/6] conf: Move virDomainPCIAddressAsString() to device_conf

On Fri, Aug 31, 2018 at 04:00:45PM +0200, Andrea Bolognani wrote: > It's a better fit than domain_conf. > > Unfortunately, even after this change functions > handling virPCIDeviceAddress are split pretty much > evenly between conf/device_conf and utils/virpci: > ideally everything would be moved

Re: [libvirt] domain XML for tracking libosinfo ID

On Wed, Sep 05, 2018 at 02:01:42PM +0200, Martin Kletzander wrote: > On Wed, Sep 05, 2018 at 09:28:52AM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 04, 2018 at 03:44:12PM -0400, Cole Robinson wrote: > > > Right now in virt-manager we only track a VM's OS name (win10, f

Re: [libvirt] domain XML for tracking libosinfo ID

On Tue, Sep 04, 2018 at 03:44:12PM -0400, Cole Robinson wrote: > Right now in virt-manager we only track a VM's OS name (win10, fedora28, > etc.) during the VM install phase. This piece of data is important > post-install though: if the user adds a new disk to the VM later, we want to > be able to

Re: [libvirt] [libvirt-snmp][PATCH 2/2] spec: Modernize the spec file

On Wed, Sep 05, 2018 at 10:25:12AM +0200, Michal Privoznik wrote: > There are two macros ("BuildRoot" and "defattr") that were > required in RHEL-5 world. Things are different now and we do not > need to specify those anymore. > > Signed-off-by: Michal Privoznik > --- > libvirt-snmp.spec.in | 5

Re: [libvirt] [PATCH] tests: skip some unicode tests if expected output won't match

On Tue, Sep 04, 2018 at 04:57:42PM +0200, Simon Kobyda wrote: > On Tue, 2018-09-04 at 11:30 +0100, Daniel P. Berrangé wrote: > > The expected output strings from the vshtabletest.c are created on a > > modern Linux host where unicode printing support is very good. On > > olde

[libvirt] [go PATCH] Avoid clashing path with default storage pool

The test driver provides a default storage pool at /default-pool. Libvirt now enforces source path uniqueness, so we must pick a different path for our test pools. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix connect_test.go | 6 +++--- storage_pool_test.go | 2 +- 2 files

[libvirt] [perl PATCH] Avoid using /default-pool for test storage pool

The path /default-pool is used by a predefined storage pool in the test driver, and libvirt now enforces pool source uniqueness. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix t/400-storage-pools.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/400-storage

Re: [libvirt] [jenkins-ci PATCH] guests: Special-case fedora-gpg-keys updates on Rawhide

+ > 2 files changed, 26 insertions(+), 7 deletions(-) After chatting with one of the Fedora team about this, we came to conclusion there's no nicer option right now, so Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com

Re: [libvirt] [PATCH 5/5] tests: pass ULLONG_MAX to qemuMonitorJSONGetBalloonInfo

On Tue, Aug 28, 2018 at 12:22:55PM +0200, Ján Tomko wrote: > Test that we correctly accept 64-bit unsigned numbers for QEMU. > > Signed-off-by: Ján Tomko > --- > tests/qemumonitorjsontest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. B

Re: [libvirt] [PATCH 1/5] virjsontest: store name in testInfo

On Tue, Aug 28, 2018 at 12:22:51PM +0200, Ján Tomko wrote: > Give the testing function access to the test name instead of only > passing it to virTestRun. > > Signed-off-by: Ján Tomko > --- > tests/virjsontest.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

[libvirt] [PATCH] rpc: fix handling of SSH auth failure code

The result of libssh2_userauth_password is being assigned to 'ret' in one branch and 'rc' in the other branch. Checks are all done against the 'ret' variable, so one branch never does the correct check. Signed-off-by: Daniel P. Berrangé --- src/rpc/virnetsshsession.c | 10 +- 1 file

Re: [libvirt] [PATCH 4/5] Test parsing of large numbers in JSON

On Tue, Aug 28, 2018 at 12:22:54PM +0200, Ján Tomko wrote: > We expect to get numbers as big as ULLONG_MAX from QEMU, > add a test for them. > > Signed-off-by: Ján Tomko > --- > tests/virjsontest.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Daniel P. Berra

Re: [libvirt] [PATCH 3/5] virjsontest: use the test name in AddRemove test

On Tue, Aug 28, 2018 at 12:22:53PM +0200, Ján Tomko wrote: > Instead of printing the whole JSON in error messages, > print just the test name. > > Signed-off-by: Ján Tomko > --- > tests/virjsontest.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [libvirt] [PATCH 2/5] virjsontest: use name instead of doc for deflatten test

--- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangl

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

On Tue, Sep 04, 2018 at 02:00:21PM +0200, Andrea Bolognani wrote: > On Tue, 2018-09-04 at 12:01 +0100, Daniel P. Berrangé wrote: > > If no JSON parser is available qemublocktest fails, so skip its execution. > > > > Signed-off-by: Daniel P. Berrangé > > --- >

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

On Tue, Sep 04, 2018 at 02:10:56PM +0200, Andrea Bolognani wrote: > On Tue, 2018-09-04 at 13:05 +0100, Daniel P. Berrangé wrote: > > > > Pushed as a build fix for platforms without JSON parser installed > > > > > > Which platforms? All machines in our CI en

[libvirt] [PATCH] tests: skip some unicode tests if expected output won't match

-off-by: Daniel P. Berrangé --- Pushed as a build fix tests/vshtabletest.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/vshtabletest.c b/tests/vshtabletest.c index 9e9c045226..1138e34161 100644 --- a/tests/vshtabletest.c +++ b/tests/vshtabletest.c @@ -21,6 +21,7 @@ #inc

[libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

If no JSON parser is available qemublocktest fails, so skip its execution. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix for platforms without JSON parser installed tests/qemublocktest.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions

<    6   7   8   9   10   11   12   13   14   15   >