[libvirt] [PATCH 2/3] qemu: consolidate parameters of qemuBuildChrChardevStr into flags

There are two boolean parameters passed to qemuBuildChrChardevStr, and soon there will be a third. It will be clearer to understand from callers' POV if we use named flags instead. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_command.c | 86 ++--- 1

[libvirt] [PATCH 0/3] Fix regression with vhostuser and chardev FD passing

for the chardev used with vhostuser only. Daniel P. Berrangé (3): qemu: remove chardevStdioLogd param from vhostuser code path qemu: consolidate parameters of qemuBuildChrChardevStr into flags qemu: don't use chardev FD passing for vhostuser backend src/qemu/qemu_command.c

[libvirt] [PATCH 1/3] qemu: remove chardevStdioLogd param from vhostuser code path

The vhostuser network backend is only supported with the UNIX domain socket chardev backend, so passing around chardevStdioLogd is not required. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_command.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git

[libvirt] [PATCH 3/3] qemu: don't use chardev FD passing for vhostuser backend

is the most prudent approach, avoiding need for a QEMU version number check. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_command.c | 31 +++ tests/qemuxml2argvdata/net-vhostuser.args | 3 +-- tests/qemuxml2argvtest.c | 2 +- 3 files

Re: [libvirt] opening tap devices that are created in a container

On Thu, Jul 05, 2018 at 10:20:16AM -0400, Jason Baron wrote: > Hi, > > Opening tap devices, such as macvtap, that are created in containers is > problematic because the interface for opening tap devices is via > /dev/tapNN and devtmpfs is not typically mounted inside a container as > its not

Re: [libvirt] [PATCH 2/3] qemu: consolidate parameters of qemuBuildChrChardevStr into flags

On Thu, Jul 05, 2018 at 02:43:18PM +0200, Michal Prívozník wrote: > On 07/05/2018 01:36 PM, Daniel P. Berrangé wrote: > > There are two boolean parameters passed to qemuBuildChrChardevStr, > > and soon there will be a third. It will be clearer to understand > > from callers

Re: [libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

On Wed, Jul 04, 2018 at 01:48:56PM +0200, Olaf Hering wrote: > Am Wed, 4 Jul 2018 11:57:58 +0100 > schrieb Daniel P. Berrangé : > > > On Mon, Jun 04, 2018 at 12:29:37PM +0200, Olaf Hering wrote: > > > In this case the resolver returns not only the IPv4 addresses but

Re: [libvirt] [PATCH v3] Loop through all resolved addresses in virNetSocketNewListenTCP

eep going and loop through all returned > addresses. In case none of the attempts to bind to some address > succeeded, try to report some appropriate error. > > Signed-off-by: Olaf Hering > --- > > v3: > more whitespace fixes, as suggested by Daniel P. Berrangé >

Re: [libvirt] perl-Sys-Virt docs and linker options

On Wed, Jul 04, 2018 at 12:05:27PM +0200, Olaf Hering wrote: > The docs in libvirt-perl.git refer still to Makefile.PL. > > In the buildlog I noticed that somehow /usr/local is used, nothing uses the > relevant flags from libvirt.pc: > > cc -shared -L/usr/local/lib64 -fstack-protector -o >

[libvirt] [PATCH] qemu: fix UNIX socket chardevs operating in client mode

in server mode. Reported-by: Richard W.M. Jones Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_command.c | 3 +- .../qemuxml2argvdata/serial-unix-chardev.args | 2 ++ .../serial-unix-chardev.x86_64-latest.args| 36 +++ .../qemuxml2argvdata/serial-unix

Re: [libvirt] opening tap devices that are created in a container

On Mon, Jul 09, 2018 at 04:56:04PM -0400, Jason Baron wrote: > > > On 07/05/2018 12:10 PM, Daniel P. Berrangé wrote: > > On Thu, Jul 05, 2018 at 10:20:16AM -0400, Jason Baron wrote: > >> Hi, > >> > >> Opening tap devices, such as macvtap, that are

Re: [libvirt] opening tap devices that are created in a container

On Mon, Jul 09, 2018 at 05:00:49PM -0400, Jason Baron wrote: > > > On 07/08/2018 02:01 AM, Martin Kletzander wrote: > > On Thu, Jul 05, 2018 at 06:24:20PM +0200, Roman Mohr wrote: > >> On Thu, Jul 5, 2018 at 4:20 PM Jason Baron wrote: > >> > >>> Hi, > >>> > >>> Opening tap devices, such as

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On Tue, Jul 10, 2018 at 05:01:22PM +0200, Cornelia Huck wrote: > Who is, in general, testing which libvirt version? I can think of: > - libvirt developers, which will probably run libvirt current git, but > more likely a released QEMU? In general libvirt devs tend to run a mixture of whatever

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On Tue, Jul 10, 2018 at 04:09:38PM +0100, Peter Maydell wrote: > On 10 July 2018 at 15:22, Cornelia Huck wrote: > > On Tue, 10 Jul 2018 07:59:15 +0200 > > Markus Armbruster wrote: > > > >> In addition to actively pulling libvirt developers into review of > >> deprecation patches, we should

Re: [libvirt] [PATCH] qemu: fix UNIX socket chardevs operating in client mode

On Fri, Jul 06, 2018 at 12:12:51PM +0100, Richard W.M. Jones wrote: > On Fri, Jul 06, 2018 at 11:03:00AM +0100, Daniel P. Berrangé wrote: > > When support was adding for passing a pre-opened listener socket to UNIX > > chardevs, it accidentally passed the listener socket

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On Fri, Jul 06, 2018 at 04:56:46PM +0200, Kevin Wolf wrote: > Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > > On Wed, 4 Jul 2018 17:14:02 +0100 > > Peter Maydell wrote: > > > > > On 4 July 2018 at 14:34, Kevin Wolf wrote: > > > > Essentially, what is important to me isn't getting

Re: [libvirt] [PATCH] qemu: monitor: Note change in output of query-cpus-fast

On Mon, Jul 09, 2018 at 12:33:49PM +0200, Peter Krempa wrote: > We did not use the field that has changed but note it in the code which > extracts the data for future reference. Especially since there is an > example of the output. > > https://bugzilla.redhat.com/show_bug.cgi?id=1598829 > >

Re: [libvirt] [PATCH 2/6] qemuxml2argvtest: Don't spawn session daemon

On Mon, Jul 09, 2018 at 11:56:10AM +0200, Michal Privoznik wrote: > After f14c37ce4c2ccd111 the cleanup path for > qemuBuildInterfaceCommandLine() and qemuBuildNetCommandLine() > tries to connect to nwfilter driver in order to tear down any > NWFilter that was brought up during cmd line

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On Mon, Jul 09, 2018 at 01:08:38PM +0200, Cornelia Huck wrote: > On Mon, 09 Jul 2018 08:33:05 +0200 > Markus Armbruster wrote: > > > Peter Maydell writes: > > > > > On 6 July 2018 at 15:56, Kevin Wolf wrote: > > >> Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: > > >>> That way, we

[libvirt] [PATCH python] fix build with older libvirt missing virNWFilterBindingPtr

-off-by: Daniel P. Berrangé --- typewrappers.h | 4 1 file changed, 4 insertions(+) diff --git a/typewrappers.h b/typewrappers.h index 1570c6a..4423774 100644 --- a/typewrappers.h +++ b/typewrappers.h @@ -27,6 +27,10 @@ typedef ssize_t Py_ssize_t; #endif +#if !LIBVIR_CHECK_VERSION(4, 5

Re: [libvirt] [PATCH v2 2/2] qemu: monitor: Use 'target' instead of 'arch' in reply of 'query-cpus-fast'

> > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_monitor_json.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |:

Re: [libvirt] [PATCH v2 1/2] qemu: monitor: Remove qemuMonitorJSONExtractCPUArchInfo wrapper

t; 1 file changed, 5 insertions(+), 22 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-phot

Re: [libvirt] [PATCH 2/6] qemuxml2argvtest: Don't spawn session daemon

On Mon, Jul 09, 2018 at 02:00:06PM +0200, Michal Privoznik wrote: > On 07/09/2018 12:44 PM, Daniel P. Berrangé wrote: > > On Mon, Jul 09, 2018 at 11:56:10AM +0200, Michal Privoznik wrote: > >> After f14c37ce4c2ccd111 the cleanup path for > >> qe

Re: [libvirt] [PATCH] Changed LPC slot from 1 to 31

{ > +} else if (addr->slot == 31) { > virReportError(VIR_ERR_INTERNAL_ERROR, "%s", > - _("PCI bus 0 slot 1 is reserved for the implicit " > + _("PCI bus 0 slot 31 is reserved for the i

Re: [libvirt] [PATCH] spec: Explicitly require matching libvirt-libs

y. So since libvirt-daemon-driver-XXX does explicitly link to libvirt.so I think it is just about justified in complaining > > libvirt.spec.in | 20 > 1 file changed, 20 insertions(+) Reviewed-by: Daniel P. Berrangé if you update the commit message to mention

Re: [libvirt] [PATCH 2/5] AUTHORS: Fix entries disagreeing with mailmap

), 1 deletion(-) Heh, thanks :-) Reviewed-by: Daniel P. Berrangé > > diff --git a/AUTHORS.in b/AUTHORS.in > index dbced5bf3f..6144fac64a 100644 > --- a/AUTHORS.in > +++ b/AUTHORS.in > @@ -14,7 +14,7 @@ Christian Ehrhardt > Christophe Fergeau > Claudio Bley >

Re: [libvirt] [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial

On Wed, Jul 04, 2018 at 03:34:40PM +0200, Kevin Wolf wrote: > Am 04.07.2018 um 15:02 hat Cornelia Huck geschrieben: > > On Tue, 3 Jul 2018 13:32:29 +0200 > > Kevin Wolf wrote: > > > > > > > > Has serial/gemoetry been fixed meanwhile and will it make it into > > > > > > the > > > > > > next

[libvirt] [PATCH] rpm: add new nwfilter RNGs to mingw-libvirt spec file

Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix mingw-libvirt.spec.in | 4 1 file changed, 4 insertions(+) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index 917d2143d8..cc1e619927 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -248,6 +248,8

Re: [libvirt] [PATCH 0/5] Fix virtlockd loosing locks

On Tue, Mar 06, 2018 at 05:58:47PM +, Daniel P. Berrangé wrote: > This is a workaround for the bizarre behaviour whereby the kernel throws > away all fcntl() locks on execve()... if any threads are running. We > simply make virtlockd & virlogd single threaded instead. > >

[libvirt] [PATCH 2/5] rpc: simplify calling convention of virNetServerClientDispatchFunc

Currently virNetServerClientDispatchFunc implementations are only responsible for free'ing the "msg" parameter upon success. Simplify the calling convention by making it their unconditional responsibility to free the "msg", and close the client if desired. Signed-off-by: Danie

[libvirt] [PATCH 1/5] rpc: push ref acquisition into RPC dispatch function

eference acquisition into virNetServerDispatchNewMessage. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/rpc/virnetserver.c | 2 ++ src/rpc/virnetserverclient.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetserver.c b/sr

[libvirt] [PATCH 3/5] rpc: invoke the message dispatch callback with client unlocked

/virevent.c:327 #14 0x55a6628716d5 in virNetDaemonRun (dmn=0x55a663a771b0) at rpc/virnetdaemon.c:858 #15 0x55a662864c1d in main (argc=, argv=0x7ffd105b4838) at logging/log_daemon.c:1235 Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/rpc/virnetserverclient.

[libvirt] [PATCH 5/5] rpc: switch virtlockd and virtlogd to use single-threaded dispatch

threaded at time of exec(). Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/locking/lock_daemon.c | 4 ++-- src/logging/log_daemon.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c index 79ab

[libvirt] [PATCH 4/5] rpc: avoid crashing in pre-exec if no workers are present

If max_workers is set to zero, then the worker thread pool won't be created, so when serializing state for pre-exec we must set various parameters to zero. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/rpc/virnetserver.c | 3 +++ 1 file changed, 3 insertions(+) diff

[libvirt] [PATCH 0/5] Fix virtlockd loosing locks

This is a workaround for the bizarre behaviour whereby the kernel throws away all fcntl() locks on execve()... if any threads are running. We simply make virtlockd & virlogd single threaded instead. Daniel P. Berrangé (5): rpc: push ref acquisition into RPC dispatch function rpc: simp

Re: [libvirt] [tck PATCH 2/2] Fix no-mac-broadcast test

> did, it was only because something else was broken). > > Signed-off-by: Laine Stump <la...@laine.org> > --- > scripts/nwfilter/230-no-mac-broadcast.t | 29 - > 1 file changed, 28 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé &

Re: [libvirt] [tck PATCH 1/2] cleanup all nwfilters beginning with ^tck

ne), and remove > same during the cleanup at the end. > > Signed-off-by: Laine Stump <la...@laine.org> > --- > lib/Sys/Virt/TCK.pm | 16 > 1 file changed, 16 insertions(+) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: htt

Re: [libvirt] RFC regarding libvirtd deadlock

On Wed, Mar 07, 2018 at 04:52:26PM -0700, Jim Fehlig wrote: > Doing something foolish like > > # while true; do killall -HUP libvirtd; sleep 1; done > # virsh create vm.xml > > can deadlock libvirtd. Threads of interest are > > Thread 4 (Thread 0x7fc13b53e700 (LWP 64084)): > #0

Re: [libvirt] [PATCH 3/5] rpc: invoke the message dispatch callback with client unlocked

On Wed, Mar 07, 2018 at 06:48:25PM -0500, John Ferlan wrote: > > > On 03/06/2018 12:58 PM, Daniel P. Berrangé wrote: > > Currently if the virNetServer instance is created with max_workers==0 to > > request a non-threaded dispatch process, we deadlock during d

Re: [libvirt] [PATCH 4/5] rpc: avoid crashing in pre-exec if no workers are present

On Wed, Mar 07, 2018 at 06:50:09PM -0500, John Ferlan wrote: > > > On 03/06/2018 12:58 PM, Daniel P. Berrangé wrote: > > If max_workers is set to zero, then the worker thread pool won't be > > created, so when serializing state for pre-exec we must set various &

Re: [libvirt] [RFC] Defining firmware (OVMF, et al) metadata format & file

On Thu, Mar 08, 2018 at 08:52:45AM +0100, Gerd Hoffmann wrote: > Hi, > > > > [*] Open question: Who, between QEMU and libvirt, should define the said > > > firmware metadata format and file? > > > > IMHO QEMU should be defining the format, because the file will contain > > info about certain

Re: [libvirt] [RFC] Defining firmware (OVMF, et al) metadata format & file

On Thu, Mar 08, 2018 at 08:45:07AM +0100, Gerd Hoffmann wrote: > > Suggested approach > > -- > > > > Based on an upstream discussion on 'virt-tools'[1] mailing list and some > > Bugzillas, Gerd Hoffmann, Laszlo Ersek and Dan Berrangé had a suggestion > > to define a firmware

Re: [libvirt] [PATCH 5/4] travis: Sync packages with libvirt-jenkins-ci

d > - patch >- perl > - - pkg-config > + - pkgconf >- policykit-1 >- qemu-utils >- radvd Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> (I'll assume you've pushed this through travis already on a private br

Re: [libvirt] [PATCH] qemu: different declarations for the same method.

On Fri, Mar 09, 2018 at 12:24:15AM -0300, Julio Faracco wrote: > Recently, this warning is appearing while libvirt is being compiled: > Function 'qemuAssignDeviceDiskAlias' argument order different: > declaration 'vmdef, def' definition 'def, disk' No objection to the patch, but can you say which

Re: [libvirt] [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

On Thu, Mar 08, 2018 at 09:47:27PM +0100, Laszlo Ersek wrote: > On 03/08/18 16:47, Daniel P. Berrangé wrote: > > On Thu, Mar 08, 2018 at 12:10:30PM +0100, Laszlo Ersek wrote: > > >> I suggest (or agree) that the property list be composed of free-form > >> name=valu

[libvirt] [PATCH] Update to latest gnulib

GnuLib has now fixed the incompatibility with latest GLibC that was affecting builds on Fedora rawhide. We can thus update and drop our local workaround. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- Pushed to git since we don't review trivial gnulib updates. .

Re: [libvirt] [PATCH go-xml] fix type tag for rdp and destkop graphics devices

Thanks, I've pushed this to git now On Sat, Mar 10, 2018 at 06:46:30PM -0500, Ryan Goodfellow wrote: > Signed-off-by: Ryan Goodfellow <rgood...@isi.edu> > > On Mon, Mar 5, 2018 at 4:25 AM, Daniel P. Berrangé <berra...@redhat.com> > wrote: > > > On Sun, Mar 0

Re: [libvirt] [Qemu-devel] [RFC] Defining firmware (OVMF, et al) metadata format & file

On Fri, Mar 09, 2018 at 04:18:45PM +0100, Laszlo Ersek wrote: > On 03/09/18 15:27, Gerd Hoffmann wrote: > > Hi, > > > >> For OVMF (x86), I guess the initial set of properties should come from > >> the "-D FOO[=BAR]" build flags that OVMF currently supports. (The list > >> might grow or change

Re: [libvirt] [PATCH] libvirtd: fix potential deadlock when reloading

onn=0x7fc119a0, > xml=0x7fc11ed0 " > Fix suggested by danpb > > https://www.redhat.com/archives/libvir-list/2018-March/msg00382.html Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.

Re: [libvirt] [PATCH v2 5/9] libvirt: add new public API to get launch security info

On Thu, Mar 08, 2018 at 11:12:04AM -0600, Brijesh Singh wrote: > The API can be used outside the libvirt to get the launch security > information. When SEV is enabled, the API can be used to get the > measurement of the launch process. > > Signed-off-by: Brijesh Singh >

Re: [libvirt] [PATCH v2 3/9] conf: introduce launch-security element in domain

On Thu, Mar 08, 2018 at 11:12:02AM -0600, Brijesh Singh wrote: > The launch-security element can be used to define the security > model to use when launching a domain. Currently we support 'sev'. > > When 'sev' is used, the VM will be launched with AMD SEV feature enabled. > SEV feature supports

Re: [libvirt] [PATCH v2 4/9] qemu: add support to launch SEV guest

On Thu, Mar 08, 2018 at 11:12:03AM -0600, Brijesh Singh wrote: > QEMU >= 2.12 provides 'sev-guest' object which is used to launch encrypted > VMs on AMD platform using SEV feature. The various inputs required to > launch SEV guest is provided through the tag. A typical > SEV guest launch command

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, Mar 12, 2018 at 03:30:33PM +0100, Andrea Bolognani wrote: > On Mon, 2018-03-12 at 14:00 +0000, Daniel P. Berrangé wrote: > > On Mon, Mar 12, 2018 at 02:29:49PM +0100, Andrea Bolognani wrote: > > > This time around it's not enough to just pick the latest com

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, Mar 12, 2018 at 03:53:09PM +0100, Andrea Bolognani wrote: > On Mon, 2018-03-12 at 14:46 +0000, Daniel P. Berrangé wrote: > > > The build system doesn't get refreshed automatically after this > > > change, so it's still trying to generate virkeycodetable_rfb.h >

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, Mar 12, 2018 at 02:29:49PM +0100, Andrea Bolognani wrote: > This time around it's not enough to just pick the latest commit, > because with aed87bb2aa6ed83b49574eb982e3bdd4c36acf17 keycodemapdb > renamed the 'rfb' keycode to 'qnum' and we need to accept the new > name while maintaining

Re: [libvirt] [PATCH v2 2/9] qemu: introduce SEV feature in hypervisor capabilities

x 83d04d4c8506..2239566105fd 100644 > --- a/src/conf/domain_capabilities.h > +++ b/src/conf/domain_capabilities.h > @@ -170,6 +170,7 @@ struct _virDomainCaps { > /* add new domain devices here */ > > virDomainCapsFeatureGIC gic; > + virSEVCapabilityPtr sev; > /* add new domain features

Re: [libvirt] [PATCH] qemu: different declarations for the same method.

from cppcheck, as opposed to the compiler. > $ > > -- > Julio Cesar Faracco > > 2018-03-12 7:19 GMT-03:00 Daniel P. Berrangé <berra...@redhat.com>: > > On Fri, Mar 09, 2018 at 12:24:15AM -0300, Julio Faracco wrote: > >> Recently, this warning is appeari

Re: [libvirt] [PATCH v2 1/9] qemu: provide support to query the SEV capability

(VIR_STRDUP(capability->cert_chain, cert_chain) < 0) > +goto cleanup; > + > +capability->cbitpos = cbitpos; > +capability->reduced_phys_bits = reduced_phys_bits; > +*capabilities = capability; > +ret = 0; > + > + cleanup: > +virJSONValue

[libvirt] [PATCH] conf: allow more user friendly names for disk formats

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- src/conf/domain_conf.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 04a6ee77af..007b73a84d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -

Re: [libvirt] [PATCH] keycodemapdb: Update submodule

On Mon, Mar 12, 2018 at 04:03:59PM +0100, Andrea Bolognani wrote: > On Mon, 2018-03-12 at 14:58 +0000, Daniel P. Berrangé wrote: > > On Mon, Mar 12, 2018 at 03:53:09PM +0100, Andrea Bolognani wrote: > > > On Mon, 2018-03-12 at 14:46 +, Daniel P. Berrangé wrote: > >

Re: [libvirt] Two more libvirt GSOC ideas

On Mon, Mar 12, 2018 at 04:18:35PM +0100, Erik Skultety wrote: > Hi, > I'd like to add 2 more GSOC ideas to our wiki page, but I'd like to get some > opinions whether you think these might even be appropriate GSOC project > candidates. > > #1 > PROJECT: > Support wildcard with log filters > >

Re: [libvirt] [PATCH v2 2/9] qemu: introduce SEV feature in hypervisor capabilities

On Mon, Mar 12, 2018 at 10:25:44AM -0500, Brijesh Singh wrote: > > > On 03/12/2018 08:33 AM, Daniel P. Berrangé wrote: > > On Thu, Mar 08, 2018 at 11:12:01AM -0600, Brijesh Singh wrote: > > > Extend hypervisor capabilities to include sev feature. When available, &

Re: [libvirt] [PATCH 3/4] travis: test upstart script handling on precise distro scenario

On Tue, Feb 27, 2018 at 03:19:44PM +, Daniel P. Berrangé wrote: > On Tue, Feb 27, 2018 at 04:14:21PM +0100, Andrea Bolognani wrote: > > On Fri, 2018-02-23 at 12:00 +0000, Daniel P. Berrangé wrote: > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > >

Re: [libvirt] [PATCH 1/4] travis: add a scenario for running make distcheck

On Tue, Feb 27, 2018 at 04:53:17PM +0100, Andrea Bolognani wrote: > On Tue, 2018-02-27 at 15:41 +0000, Daniel P. Berrangé wrote: > > > > Running syntax-check in all 5 scenarios isn't buying us anything, > > > > as the syntax-check rules don't depend on what is install

Re: [libvirt] [PATCH 1/4] travis: add a scenario for running make distcheck

On Tue, Feb 27, 2018 at 04:35:32PM +0100, Andrea Bolognani wrote: > On Tue, 2018-02-27 at 15:06 +0000, Daniel P. Berrangé wrote: > > > > - compiler: gcc > > > >dist: precise > > > > +# Special scenario to run distcheck, so w

Re: [libvirt] [PATCH 3/4] conf: introduce sev element in domain

On Tue, Feb 27, 2018 at 11:07:25AM -0600, Brijesh Singh wrote: > > > On 02/27/2018 05:10 AM, Daniel P. Berrangé wrote: > > On Mon, Feb 26, 2018 at 11:53:35AM -0600, Brijesh Singh wrote: > > > Secure Encrypted Virtualization (sev) element is used to provide the guest >

Re: [libvirt] [PATCH 3/4] travis: test upstart script handling on precise distro scenario

On Tue, Feb 27, 2018 at 04:43:18PM +0100, Andrea Bolognani wrote: > On Tue, 2018-02-27 at 15:19 +0000, Daniel P. Berrangé wrote: > > > Both precise and trusty use upstart, so there's no reason not > > > to apply this to both, especially if we're going trusty-only as &g

Re: [libvirt] [PATCH 4/4] travis: run 'make install' during build tests

On Tue, Feb 27, 2018 at 04:23:01PM +0100, Andrea Bolognani wrote: > On Fri, 2018-02-23 at 12:01 +0000, Daniel P. Berrangé wrote: > > Running 'make install' is important to catch some VPATH problems > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> &

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 02:08:29PM +0100, --help wrote: > Signed-off-by: --help You're going to have todo better than that to beat the exploits of Little Bobby Tables [1]. > --- > docs/news.xml | 102 > ++ > 1 file

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 03:28:57PM +0100, Peter Krempa wrote: > On Thu, Mar 01, 2018 at 15:12:39 +0100, Michal Privoznik wrote: > > On 03/01/2018 02:15 PM, Peter Krempa wrote: > > > On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal Privoznik wrote: > > >> Signed-off-by: --help >

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 03:12:39PM +0100, Michal Privoznik wrote: > On 03/01/2018 02:15 PM, Peter Krempa wrote: > > On Thu, Mar 01, 2018 at 14:08:29 +0100, Michal Privoznik wrote: > >> Signed-off-by: --help > > > > Hmm. > > > >> --- > >> docs/news.xml | 102 > >>

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 03:40:01PM +0100, Michal Privoznik wrote: > On 03/01/2018 03:29 PM, Daniel P. Berrangé wrote: > > On Thu, Mar 01, 2018 at 03:12:39PM +0100, Michal Privoznik wrote: > >> On 03/01/2018 02:15 PM, Peter Krempa wrote: > >>> On Thu, Mar 01,

Re: [libvirt] [PATCH] news: Update release notes

On Thu, Mar 01, 2018 at 03:41:00PM +0100, Peter Krempa wrote: > On Thu, Mar 01, 2018 at 14:34:58 +, Daniel Berrange wrote: > > On Thu, Mar 01, 2018 at 03:28:57PM +0100, Peter Krempa wrote: > > > On Thu, Mar 01, 2018 at 15:12:39 +0100, Michal Privoznik wrote: > > > > On 03/01/2018 02:15 PM,

Re: [libvirt] [PATCH] qemu: hotplug: fail when net device detach times out

On Tue, Mar 13, 2018 at 06:13:46PM +, Jonathan Davies wrote: > On 13/03/18 14:23, Daniel P. Berrangé wrote: > > On Tue, Mar 13, 2018 at 02:07:08PM +, Jonathan Davies wrote: > > > qemuDomainDetachNetDevice should not treat a timeout in a call to > > > qem

Re: [libvirt] [dbus PATCH 16/18] introduce support for libdbus library

On Mon, Mar 12, 2018 at 05:21:46PM +0100, Pavel Hrdina wrote: > We will switch to libdbus library because the systemd sd-bus > implementation is not thread safe. Hmmm, libdbus.so isn't all that great with threads either. It has had countless bugs in its thread support over the years to the extent

Re: [libvirt] [dbus PATCH 13/18] domain: ensure connection to libvirt

4 > src/domain.c | 51 +++ > 3 files changed, 56 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [libvirt] [dbus PATCH 14/18] connect: parse message arguments as first thing

On Mon, Mar 12, 2018 at 05:21:44PM +0100, Pavel Hrdina wrote: > There is no need to open connection if parsing arguments fails. > > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/connect.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-

Re: [libvirt] [dbus PATCH 05/18] domain: introduce VIRT_DBUS_DOMAIN_INTERFACE

On Mon, Mar 12, 2018 at 05:21:35PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/domain.c | 2 +- > src/domain.h | 2 ++ > src/events.c | 8 > 3 files changed, 7 insertions(+), 5 deletions(-) Reviewed-by: D

Re: [libvirt] [dbus PATCH 07/18] events: fix function names for TrayChange and DiskChange events

On Mon, Mar 12, 2018 at 05:21:37PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/events.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Rega

Re: [libvirt] [dbus PATCH 06/18] events: fix signal message for TrayChange event

On Mon, Mar 12, 2018 at 05:21:36PM +0100, Pavel Hrdina wrote: > The reply contains only two strings. > > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <ber

Re: [libvirt] [dbus PATCH 08/18] main: error out if signal handler is not registered

On Mon, Mar 12, 2018 at 05:21:38PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/main.c | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berran

Re: [libvirt] [dbus PATCH 04/18] connect: introduce VIRT_DBUS_CONNECT_INTERFACE

es changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https:

Re: [libvirt] [dbus PATCH 03/18] util: introduce VIRT_DBUS_ERROR_INTERFACE

On Mon, Mar 12, 2018 at 05:21:33PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/util.c | 4 ++-- > src/util.h | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redh

Re: [libvirt] [dbus PATCH 12/18] maint: cleanup includes

rc/util.c| 2 ++ > src/util.h| 2 -- > 8 files changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org

Re: [libvirt] [dbus PATCH 11/18] maint: fix coding style

ed, 36 insertions(+), 28 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://enta

Re: [libvirt] [dbus PATCH 10/18] spec: don't use hard-coded system_user

On Mon, Mar 12, 2018 at 05:21:40PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > libvirt-dbus.spec.in | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Rega

Re: [libvirt] [dbus PATCH 09/18] main: fix error message

On Mon, Mar 12, 2018 at 05:21:39PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > src/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: http

Re: [libvirt] [dbus PATCH 15/18] domain: create a helper function to get a domain object

file changed, 75 insertions(+), 145 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |:

Re: [libvirt] [dbus PATCH 02/18] util: there is no need to mark cleanup functions as inline

eletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > -static inline void > -virtDBusUtilVirDomainFreep(virDomainPtr *domainp) > -{ > -if (*domainp) > -virDomainFree(*domainp); > -} > +void > +virtDBusUtilVirDomainFreep(virDomainPt

Re: [libvirt] [dbus PATCH 16/18] introduce support for libdbus library

On Tue, Mar 13, 2018 at 09:39:13AM +0100, Pavel Hrdina wrote: > On Mon, Mar 12, 2018 at 04:30:30PM +0000, Daniel P. Berrangé wrote: > > On Mon, Mar 12, 2018 at 05:21:46PM +0100, Pavel Hrdina wrote: > > > We will switch to libdbus library because the systemd sd-bus &g

Re: [libvirt] [dbus PATCH 01/18] util: rename VIR_ATTR_UNUSED

- > src/events.c | 12 - > src/main.c| 12 - > src/util.h| 3 ++- > 5 files changed, 57 insertions(+), 56 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.c

Re: [libvirt] [GSoC]: Help in setup

On Tue, Mar 13, 2018 at 01:37:25PM +0100, Cedric Bosdonnat wrote: > On Tue, 2018-03-13 at 16:45 +0530, Sukrit Bhatnagar wrote: > > Here is the output: > > > > skrtbhtngr@ubuntu:~/libvirt$ ./autogen.sh --system > > > > Updating submodules... > > Submodule 'gnulib'

Re: [libvirt] [dbus PATCH 16/18] introduce support for libdbus library

On Tue, Mar 13, 2018 at 10:07:58AM +, Daniel P. Berrangé wrote: > On Tue, Mar 13, 2018 at 09:39:13AM +0100, Pavel Hrdina wrote: > > On Mon, Mar 12, 2018 at 04:30:30PM +0000, Daniel P. Berrangé wrote: > > > On Mon, Mar 12, 2018 at 05:21:46PM +0100, Pavel Hrdina wrote: >

Re: [libvirt] [PATCH] qemu: hotplug: fail when net device detach times out

On Tue, Mar 13, 2018 at 03:42:10PM +0100, Jiri Denemark wrote: > On Tue, Mar 13, 2018 at 14:23:22 +0000, Daniel P. Berrangé wrote: > > On Tue, Mar 13, 2018 at 02:07:08PM +, Jonathan Davies wrote: > > > If qemuDomainWaitForDeviceRemoval times out, it returns 0. In t

Re: [libvirt] [PATCH] qemu: hotplug: fail when net device detach times out

On Tue, Mar 13, 2018 at 02:07:08PM +, Jonathan Davies wrote: > qemuDomainDetachNetDevice should not treat a timeout in a call to > qemuDomainWaitForDeviceRemoval as success. Instead, it should treat it > as failure -- this is the intention behind having a timeout. Actually this is intentional

[libvirt] [PATCH security-notice 1/4] LSN-2018-0001 / CVE-2017-5715 - Spectre variant 2 branch target injection

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- notices/2018/0001.xml | 276 ++ 1 file changed, 276 insertions(+) create mode 100644 notices/2018/0001.xml diff --git a/notices/2018/0001.xml b/notices/2018/0001.xml new file mode

[libvirt] [PATCH security-notice 0/4] Add missing security notices

This provides the security notices we've had so far in 2018 and a script to make future ones easier to create. Daniel P. Berrangé (4): LSN-2018-0001 / CVE-2017-5715 - Spectre variant 2 branch target injection LSN-2018-0002 / CVE-2018-5748 - QEMU monitor denial of service LSN-2018-0003

[libvirt] [PATCH security-notice 2/4] LSN-2018-0002 / CVE-2018-5748 - QEMU monitor denial of service

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- notices/2018/0002.xml | 274 ++ 1 file changed, 274 insertions(+) create mode 100644 notices/2018/0002.xml diff --git a/notices/2018/0002.xml b/notices/2018/0002.xml new file mode

[libvirt] [PATCH security-notice 4/4] Add a script for generating a list of vulnerable tags & branches

be copied straight into the security notice, meaning we just have to then fill out details of which changeset and tag fixed the flaw. Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- scripts/report-vulnerable-tags.pl | 108 ++ 1 file changed, 108 inse

[libvirt] [PATCH security-notice 3/4] LSN-2018-0003 / CVE-2018-6764 - Insecure usage of NSS modules during container startup

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> --- notices/2018/0003.xml | 269 ++ 1 file changed, 269 insertions(+) create mode 100644 notices/2018/0003.xml diff --git a/notices/2018/0003.xml b/notices/2018/0003.xml new file mode

<    7   8   9   10   11   12   13   14   15   16   >