[libvirt] [PATCH v2 06/21] schemas: add schema for nwfilter binding XML document

2018-05-15 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/schemas/domaincommon.rng| 27 +- docs/schemas/nwfilter.rng| 29 +-- docs/schemas/nwfilter_params.rng | 32 + docs/schemas/nwfilterbinding.rng | 49 tests

[libvirt] [perl PATCH v2] Switch over to using Module::Build

2018-05-15 Thread Daniel P . Berrangé
The Module::Build system is nicer than ExtUtils::MakeMaker as it allows for better cross-platform portability by only relying on Perl, rather than both Perl and system 'make' binary. Signed-off-by: Daniel P. Berrangé --- .gitignore | 17 +++ Build.PL

Re: [libvirt] [perl PATCH] Switch over to using Module::Build

2018-05-15 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 07:23:28PM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 16:32 +0100, Daniel P. Berrangé wrote: > > The Module::Build system is nicer than ExtUtils::MakeMaker as it allows > > for better cross-platform portability by only relying on Perl, rather >

Re: [libvirt] [perl PATCH] Switch over to using Module::Build

2018-05-15 Thread Daniel P . Berrangé
On Tue, May 15, 2018 at 08:17:09PM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 18:55 +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 07:23:28PM +0200, Andrea Bolognani wrote: > > > Lastly, the RPM build fails with > > > > > > RPM bu

Re: [libvirt] [PATCHv3 00/13] Switch from yajl to Jansson

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 10:53:22AM +0200, Ján Tomko wrote: > On Tue, May 15, 2018 at 05:24:40PM +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 06:12:05PM +0200, Andrea Bolognani wrote: > > > On Fri, 2018-05-11 at 14:59 +0200, Ján Tomko wrote: > > >

Re: [libvirt] [perl PATCH] Switch over to using Module::Build

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 10:49:39AM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 20:47 +0100, Daniel P. Berrangé wrote: > > On Tue, May 15, 2018 at 08:17:09PM +0200, Andrea Bolognani wrote: > > > + /usr/bin/perl Build.PL installdirs=vendor > > > Created

[libvirt] [tck PATCH] Use a pre-created MANIFEST file

2018-05-16 Thread Daniel P . Berrangé
Using the MANIFEST.SKIP blacklist approach risks creating tarballs with extra files mistakenly included if the working directory is not clean. Switch to a pre-created MANIFEST file, since maintaining this short list of files is not hard work. Signed-off-by: Daniel P. Berrangé --- .gitignore

Re: [libvirt] [PATCH] log: actually do substring matches with fnmatch

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 11:59:31AM +0200, Erik Skultety wrote: > On Mon, May 14, 2018 at 02:53:49PM +0100, Daniel P. Berrangé wrote: > > Historically we matched log filters with strstr(), and when switching to > > fnmatch in cbb0fd3cfdc287f6f4653ef1f04a7cfb2ea51b27, it was stated th

Re: [libvirt] ANNOUNCE: Plans for the next release

2018-05-16 Thread Daniel P . Berrangé
On Mon, May 14, 2018 at 05:15:59PM +0200, Pavel Hrdina wrote: > Hi, > > I would like to make the next libvirt-dbus release with stable APIs, > there is a lot of them already implemented and other projects can start > adapting to use libvirt-dbus. > > The release version would be 1.0.0 and current

[libvirt] [PATCH v2] log: actually do substring matches with fnmatch

2018-05-16 Thread Daniel P . Berrangé
lly make that happen. This fixes it to prepend and append "*". We don't bother to check if the pattern already has a leading/trailing '*', because "**foo**" will match the same as "*foo*". Signed-off-by: Daniel P. Berrangé --- Changed in v2: - Simplify

Re: [libvirt] ANNOUNCE: Plans for the next release

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 01:38:06PM +0200, Pavel Hrdina wrote: > On Wed, May 16, 2018 at 12:09:15PM +0100, Daniel P. Berrangé wrote: > > On Mon, May 14, 2018 at 05:15:59PM +0200, Pavel Hrdina wrote: > > > Hi, > > > > > > I would like to make the next l

Re: [libvirt] [dbus PATCH v2] docs: Introduce man file for libvirt-dbus daemon

2018-05-16 Thread Daniel P . Berrangé
| 1 + > docs/Makefile.am | 13 + > docs/libvirt-dbus.pod | 66 +++ > libvirt-dbus.spec.in | 2 ++ > 6 files changed, 85 insertions(+), 1 deletion(-) > create mode 100644 docs/Makefile.am > create mode 100644 docs/libv

Re: [libvirt] [PATCH] travis: Install Jansson instead of yajl

2018-05-16 Thread Daniel P . Berrangé
ould be pushed at the same time as Ján's series. > > .travis.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org

Re: [libvirt] [jenkins-ci PATCH 1/3] guests: Install Module::Build for libvirt-perl

2018-05-16 Thread Daniel P . Berrangé
ml > @@ -1,7 +1,7 @@ > --- > packages: >- perl-CPAN-Changes > - - perl-ExtUtils-MakeMaker > + - perl-Module-Build >- perl-Test-Pod > - perl-Test-Pod-Coverage >- perl-Time-HiRes Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.c

Re: [libvirt] [jenkins-ci PATCH 2/3] guests: Add Archive::Tar dependency for Perl projects

2018-05-16 Thread Daniel P . Berrangé
st-Pod > diff --git a/guests/vars/projects/libvirt-tck.yml > b/guests/vars/projects/libvirt-tck.yml > index 8d29c1c..d0f 100644 > --- a/guests/vars/projects/libvirt-tck.yml > +++ b/guests/vars/projects/libvirt-tck.yml > @@ -1,5 +1,6 @@ > --- > packages: > +

Re: [libvirt] [jenkins-ci PATCH 3/3] guests: Blacklist perl-ExtUtils-MakeMaker

2018-05-16 Thread Daniel P . Berrangé
, after a reasonable amount of time. > > Signed-off-by: Andrea Bolognani > --- > guests/vars/mappings.yml | 1 - > guests/vars/projects/blacklist.yml | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |:

Re: [libvirt] [jenkins-ci PATCH 4/3] guests: Add Package::Constants dependency for Perl projects

2018-05-16 Thread Daniel P . Berrangé
ges: >- perl-IO-Compress-Bzip2 >- perl-IO-String > - perl-Module-Build > + - perl-Package-Constants >- perl-Sub-Uplevel >- perl-TAP-Formatter-HTML >- perl-TAP-Formatter-JUnit Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.c

Re: [libvirt] [jenkins-ci PATCH 5/3] guests: Fix PERL5LIB for Module::Build

2018-05-16 Thread Daniel P . Berrangé
| 2 +- > guests/host_vars/libvirt-freebsd-current/main.yml | 2 +- > guests/host_vars/libvirt-ubuntu-14/main.yml | 2 +- > guests/host_vars/libvirt-ubuntu-16/main.yml | 2 +- > guests/host_vars/libvirt-ubuntu-18/main.yml | 2 +- > 14 files changed, 14 insertions(

Re: [libvirt] [perl PATCH v2] Switch over to using Module::Build

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 04:56:24PM +0200, Andrea Bolognani wrote: > On Tue, 2018-05-15 at 18:54 +0100, Daniel P. Berrangé wrote: > [...] > > diff --git a/prepare-release.sh b/prepare-release.sh > > index fea03f4..6850350 100755 > > --- a/prepare-release.sh > > +++ b/p

Re: [libvirt] [jenkins-ci PATCH 2/2] projects: Define archive_format for osinfo-db

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 05:18:56PM +0200, Andrea Bolognani wrote: > On Wed, 2018-05-16 at 15:25 +0200, Erik Skultety wrote: > > On Thu, May 10, 2018 at 05:26:33PM +0200, Andrea Bolognani wrote: > > > Follow the standard templating behavior instead of needlessly > > > hardcoding information in the s

Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 05:30:33PM +0200, Marc Hartmayer wrote: > On Wed, May 09, 2018 at 05:40 PM +0200, "Daniel P. Berrangé" > wrote: > > On Wed, May 09, 2018 at 04:56:12PM +0200, Marc Hartmayer wrote: > >> Introduce new libvirt API virDomainCreateWithParams

[libvirt] [jenkins-ci PATCH] jobs: don't create MANIFEST file during build

2018-05-16 Thread Daniel P . Berrangé
Projects have switched to a pre-built MANIFEST Signed-off-by: Daniel P. Berrangé --- jobs/perl-modulebuild.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/jobs/perl-modulebuild.yaml b/jobs/perl-modulebuild.yaml index 60374da..a80d6b8 100644 --- a/jobs/perl-modulebuild.yaml +++ b/jobs

[libvirt] Libvirt daemon split / VM shim progress

2018-05-16 Thread Daniel P . Berrangé
A update on progress splitting libvirtd into multiple daemons * General refactoring of the RPC client/server This is about allowing libvirtd daemon to forward API calls to other daemons when there is no built-in driver. It also involves the remote client learning how to connect to o

Re: [libvirt] [PATCH 02/12] Introduce new domain create API virDomainCreateWithParams

2018-05-16 Thread Daniel P . Berrangé
On Wed, May 16, 2018 at 06:21:40PM +0200, Christian Borntraeger wrote: > > > On 05/16/2018 05:35 PM, Daniel P. Berrangé wrote: > > On Wed, May 16, 2018 at 05:30:33PM +0200, Marc Hartmayer wrote: > >> On Wed, May 09, 2018 at 05:40 PM +0200, "Daniel P. Berrangé"

[libvirt] [jenkins-ci PATCH] projects: set TEST_MAINTAINER for libvirt-perl build job too

2018-05-17 Thread Daniel P . Berrangé
The TEST_MAINTAINER=1 env variable will effect running of Build.PL, causing it to turn on many more GCC warning flags to validate the build. So we need to set it for build job as well as test job. Signed-off-by: Daniel P. Berrangé --- projects/libvirt-perl.yaml | 2 ++ 1 file changed, 2

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Daniel P . Berrangé
gnani > --- > guests/lcitool | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop

[libvirt] [PATCH v3 0/4] qemu: use FD passing for chardev UNIX sockets

2018-05-17 Thread Daniel P . Berrangé
: - Refactor UNIX socket opening code to allow it to be mocked in the unit tests to avoid creating real UNIX sockets Daniel P. Berrangé (4): qemu: probe for -chardev 'fd' parameter for FD passing qemu: support passing pre-opened UNIX socket listen FD qemu: don't retry connec

[libvirt] [PATCH v3 1/4] qemu: probe for -chardev 'fd' parameter for FD passing

2018-05-17 Thread Daniel P . Berrangé
QEMU >= 2.12 will support passing of pre-opened file descriptors for socket based character devices. Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + te

[libvirt] [PATCH v3 2/4] qemu: support passing pre-opened UNIX socket listen FD

2018-05-17 Thread Daniel P . Berrangé
FD, while some hostnames may require listening on multiple FDs to cover IPv4 and IPv6 concurrently. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_command.c | 64 ++- src/qemu/qemu_command.h | 4 ++ .../disk-drive-write-ca

[libvirt] [PATCH v3 4/4] qemu: remove pointless connect retry logic in agent

2018-05-17 Thread Daniel P . Berrangé
us be sure the QEMU agent socket is present and don't need to retry connections to it, even without having the chardev FD passing feature. Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_agent.c | 84 --- 1 file chan

[libvirt] [PATCH v3 3/4] qemu: don't retry connect() if doing FD passing

2018-05-17 Thread Daniel P . Berrangé
remove the retry loop and timeout when connecting to the QEMU monitor if we are doing FD passing. Libvirt can go straight to sending the QMP greeting and will simply block waiting for a reply until QEMU is ready. Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/qemu

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 04:10:37PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-17 at 14:18 +0100, Daniel P. Berrangé wrote: > > On Thu, May 17, 2018 at 03:09:11PM +0200, Andrea Bolognani wrote: > > > Perl to the rescue! The script ends up being only marginally > > &g

[libvirt] [tck PATCH] Stop deleting MANIFEST file when making release dists

2018-05-17 Thread Daniel P . Berrangé
The MANIFEST file is now pre-created rather than auto-generated Signed-off-by: Daniel P. Berrangé --- Pushed as trivial + build fix prepare-release.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prepare-release.sh b/prepare-release.sh index ad29f16..ef5d7b8 100755

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 04:35:12PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-17 at 15:22 +0100, Daniel P. Berrangé wrote: > > On Thu, May 17, 2018 at 04:10:37PM +0200, Andrea Bolognani wrote: > > > A friend suggested > > > > > > diff --git a/guests/

Re: [libvirt] [PATCH v2 05/21] conf: add support for parsing/formatting virNWFilterBindingDefPtr

2018-05-17 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 01:31:04PM -0400, Laine Stump wrote: > On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > > A typical XML representation of the virNWFilterBindingDefPtr struct > > looks like this: > > > > > > > > f25arm7 > &g

Re: [libvirt] [RFC v3] external (pull) backup API

2018-05-18 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 05:43:37PM -0500, Eric Blake wrote: > Here's my updated counterproposal for a backup API. > > In comparison to v2 posted by Nikolay: > https://www.redhat.com/archives/libvir-list/2018-April/msg00115.html > - changed terminology a bit: Nikolay's "BlockSnapshot" is now called

[libvirt] [PATCH] qemu: include kernel version in QEMU log file

2018-05-18 Thread Daniel P . Berrangé
We currently print the libvirt and qemu version strings into the per-guest logfile. It would be useful to know what kernel is running too, so add that. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_process.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src

Re: [libvirt] [PATCH] set default seccompSandbox as 0 for qemu

2018-05-18 Thread Daniel P . Berrangé
On Fri, May 18, 2018 at 07:37:33PM +0800, zhenwei pi wrote: > start qemu fail : qemu-system-x86_64: -sandbox on,obsolete=deny, > elevateprivileges=deny,spawn=deny,resourcecontrol=deny: > seccomp support is disabled > libvirt version : 4.3 > qemu version : 2.12 > reproducer : recompile qemu

Re: [libvirt] [PATCH] set default seccompSandbox as 0 for qemu

2018-05-18 Thread Daniel P . Berrangé
On Fri, May 18, 2018 at 12:42:07PM +0100, Daniel P. Berrangé wrote: > On Fri, May 18, 2018 at 07:37:33PM +0800, zhenwei pi wrote: > > start qemu fail : qemu-system-x86_64: -sandbox on,obsolete=deny, > > elevateprivileges=deny,spawn=deny,resourcecontrol=deny: > > seccom

[libvirt] [PATCH] nwfilter: fix IP address learning

2018-05-18 Thread Daniel P . Berrangé
In a previous commit: commit d4bf8f415074759baf051644559e04fe7f8b Author: Daniel P. Berrangé Date: Wed Feb 14 09:43:59 2018 + nwfilter: handle missing switch enum cases Ensure all enum cases are listed in switch statements, or cast away enum type in places where we

[libvirt] nwfilter deadlock with libpcap and TPACKET_V3

2018-05-18 Thread Daniel P . Berrangé
I've just found a deadlock in nwfilter caused by something in libpcap. There are 2 VMs running with the nwfilter stress test, but the deadlock in fact only involves VM VM. Three threads in libvirtd Thread 1 (Thread 0x7f3a26f726c0 (LWP 15384)): #0 __lll_lock_wait () at ../sysdeps/unix/sysv/linux

Re: [libvirt] [PATCH] nwfilter: fix IP address learning

2018-05-18 Thread Daniel P . Berrangé
On Fri, May 18, 2018 at 12:59:01PM +0100, Daniel P. Berrangé wrote: > In a previous commit: > > commit d4bf8f415074759baf051644559e04fe7f8b > Author: Daniel P. Berrangé > Date: Wed Feb 14 09:43:59 2018 + > > nwfilter: handle missing switch enum cases >

Re: [libvirt] [PATCH 0/8] Fix some issues with rng grammar for output XML's

2018-05-21 Thread Daniel P . Berrangé
On Sat, May 19, 2018 at 08:14:30AM -0400, John Ferlan wrote: > The storagevol, capability, and nodedev output grammar files had > some issues. Details noted in each patch. > > John Ferlan (8): > schema: Add physical sizing grammer for storagevol grammar > schema: Remove xenmigr from host migra

Re: [libvirt] Abandoning php-virt-control project

2018-05-21 Thread Daniel P . Berrangé
On Sun, May 20, 2018 at 12:24:12PM +0200, Michal Novotny wrote: > Hi, > since I'm pretty busy last few months and I didn't do any commit to the > php-virt-control project [1] for a pretty long time it's time to hand over > this project to somebody that is interested in continuing the project so > p

[libvirt] [PATCH] qemu: clarify message about block peek format restriction

2018-05-21 Thread Daniel P . Berrangé
Include the actual disk format in the error message to help the user see what is wrong. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_driver.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e61af23870

[libvirt] [PATCH] nwfilter: directly use poll to wait for packets instead of pcap_next

2018-05-21 Thread Daniel P . Berrangé
exiting which blocks the rest of libvirtd waiting on mutex acquisition. By switching to do poll() in libvirt code, we can ensure that we always exit the poll() at a time that is right for libvirt. Signed-off-by: Daniel P. Berrangé --- src/nwfilter/nwfilter_learnipaddr.c | 37

Re: [libvirt] nwfilter deadlock with libpcap and TPACKET_V3

2018-05-21 Thread Daniel P . Berrangé
On Sat, May 19, 2018 at 09:43:49PM +0200, Martin Kletzander wrote: > On Fri, May 18, 2018 at 05:30:00PM +0100, Daniel P. Berrangé wrote: > > I've just found a deadlock in nwfilter caused by something in libpcap. > > > > There are 2 VMs running with the nwfilter str

Re: [libvirt] [PATCH] travis: Print test log file from distcheck as well

2018-05-21 Thread Daniel P . Berrangé
ould have just used a "*" here since we build from clean git we know it will only expand to a single file, but not a real issue. > else > echo "=== NO LOG FILE FOUND ==="; > fi' Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://

[libvirt] [tck PATCH 1/3] scripts: avoid using multicast MAC addresses

2018-05-21 Thread Daniel P . Berrangé
The leading digit from the MAC address should be an even number Signed-off-by: Daniel P. Berrangé --- scripts/domain/215-nic-hotplug-many.t | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/domain/215-nic-hotplug-many.t b/scripts/domain/215-nic-hotplug-many.t

[libvirt] [tck PATCH 2/3] scripts: strip quotes from URI before checking it

2018-05-21 Thread Daniel P . Berrangé
The config file may have the URI listed with or without quotes, and the nwfilter tests didn't strip quotes before checking against the whitelisted URI. Signed-off-by: Daniel P. Berrangé --- scripts/nwfilter/nwfilter2vmtest.sh | 2 +- scripts/nwfilter/nwfilter_concurrent.sh | 2 +- 2

[libvirt] [tck PATCH 3/3] scripts: fix block info test conditions

2018-05-21 Thread Daniel P . Berrangé
The semantics of the "physical" field were fixed to not duplicate the info of the "allocation" field. The use of block_peek on non-raw volumes now raises an error since we cannot peek inside volumes. Signed-off-by: Daniel P. Berrangé --- scripts/domain/121-block-info

[libvirt] [tck PATCH 0/3] Some misc fixes

2018-05-21 Thread Daniel P . Berrangé
Just random things i found while testing the TCK against current git Daniel P. Berrangé (3): scripts: avoid using multicast MAC addresses scripts: strip quotes from URI before checking it scripts: fix block info test conditions scripts/domain/121-block-info.t | 5 ++--- scripts

Re: [libvirt] [RFC PATCH 0/9] qemu: add vhost-vsock-pci support

2018-05-21 Thread Daniel P . Berrangé
On Mon, May 21, 2018 at 05:37:10PM +0200, Ján Tomko wrote: > @Stefan, please take a look at the docs/ changes in patch 6 > > Add , mapping to vhost-vsock-pci I think it is pretty misleading to use for this, because the whole point of vsock existing is that it is *not* a NIC ! I think we need to

[libvirt] [tck PATCH v2 02/13] scripts: strip quotes from URI before checking it

2018-05-21 Thread Daniel P . Berrangé
The config file may have the URI listed with or without quotes, and the nwfilter tests didn't strip quotes before checking against the whitelisted URI. Signed-off-by: Daniel P. Berrangé --- scripts/networks/networkApplyTest.sh| 2 +- scripts/nwfilter/nwfilter2vmtest.sh | 2 +- sc

[libvirt] [tck PATCH v2 10/13] scripts: don't abort the entire test harness when libvirtd isn't running

2018-05-21 Thread Daniel P . Berrangé
It is reasonable to run TCK against a manually started libvirtd, so we should not abort the entire test suite. Just mark the hook scripts as skipped. Signed-off-by: Daniel P. Berrangé --- scripts/hooks/051-daemon-hook.t | 2 +- scripts/hooks/052-domain-hook.t | 14 +- 2 files

[libvirt] [tck PATCH v2 00/13] Make sure all tests pass

2018-05-21 Thread Daniel P . Berrangé
I went through and fixed every single broken test, so everything should now pass when run against latest git master. Daniel P. Berrangé (13): scripts: avoid using multicast MAC addresses scripts: strip quotes from URI before checking it scripts: fix block info test conditions scripts

[libvirt] [tck PATCH v2 01/13] scripts: avoid using multicast MAC addresses

2018-05-21 Thread Daniel P . Berrangé
The leading digit from the MAC address should be an even number Signed-off-by: Daniel P. Berrangé --- scripts/domain/215-nic-hotplug-many.t | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/domain/215-nic-hotplug-many.t b/scripts/domain/215-nic-hotplug-many.t

[libvirt] [tck PATCH v2 04/13] scripts: remove testing of 'cow' format

2018-05-21 Thread Daniel P . Berrangé
Support for the 'cow' format was delete from QEMU so will always throw an error if tried in libvirt with modern QEMU commit 550830f9351291c585c963204ad9127998b1c1ce Author: Stefan Hajnoczi Date: Tue Sep 16 15:24:24 2014 +0100 block: delete cow block driver Signed-off-by

[libvirt] [tck PATCH v2 03/13] scripts: fix block info test conditions

2018-05-21 Thread Daniel P . Berrangé
The semantics of the "physical" field were fixed to not duplicate the info of the "allocation" field. The use of block_peek on non-raw volumes now raises an error since we cannot peek inside volumes. Signed-off-by: Daniel P. Berrangé --- scripts/domain/121-block-info

[libvirt] [tck PATCH v2 12/13] lib: don't re-assign $_

2018-05-21 Thread Daniel P . Berrangé
Perl has started to forbid code from declaring "my $_", because $_ is implicitly always a local scope. Rewrite the code to avoid tickling this warning. Signed-off-by: Daniel P. Berrangé --- lib/Sys/Virt/TCK/Hooks.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff -

[libvirt] [tck PATCH v2 11/13] scripts: re-enable save/restore test

2018-05-21 Thread Daniel P . Berrangé
The referenced QEMU bug is long since fixed Signed-off-by: Daniel P. Berrangé --- scripts/domain/102-broken-save-restore.t | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/domain/102-broken-save-restore.t b/scripts/domain/102-broken-save-restore.t index 4a05705

[libvirt] [tck PATCH v2 07/13] scripts: switch to using luks encryption with QEMU

2018-05-21 Thread Daniel P . Berrangé
The ability to use qcow legacy encryption is disabled with QEMU for a long time. Switch to using luks encryption, although this is not yet fully wired up in libvirt so the tests still (temporarily) fail. Signed-off-by: Daniel P. Berrangé --- lib/Sys/Virt/TCK/DomainBuilder.pm | 4 ++-- lib

[libvirt] [tck PATCH v2 06/13] scripts: cope with multiple seclabels in live XML

2018-05-21 Thread Daniel P . Berrangé
Libvirt may report two seclabels, one for SELinux and one for DAC. Make sure we grab the right one from the XML. Also fix the number of tests. Signed-off-by: Daniel P. Berrangé --- scripts/selinux/100-static-relabel-no.t | 4 ++-- scripts/selinux/110-static-relabel-yes.t | 6 +++--- 2 files

[libvirt] [tck PATCH v2 05/13] scripts: portability fixes in checking command output

2018-05-21 Thread Daniel P . Berrangé
-off-by: Daniel P. Berrangé --- scripts/networks/networkxml2hostout/tck-testnet-1.dat | 2 +- scripts/networks/networkxml2hostout/tck-testnet-2.dat | 2 +- scripts/networks/networkxml2hostout/tck-testnet-3.dat | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts

[libvirt] [tck PATCH v2 13/13] lib: allow marking the scratch disk as shareable

2018-05-21 Thread Daniel P . Berrangé
One of the tests checks the ability to boot multiple guests at once, and it is using the same (empty) disk image for all. Modern QEMU rejects this sharing, but it is harmless in context of this test case, so we mark the disk as shareable to allow it. Signed-off-by: Daniel P. Berrangé --- lib

[libvirt] [tck PATCH v2 09/13] scripts: fix the various hotplug tests

2018-05-21 Thread Daniel P . Berrangé
PCI device hotunplug requires a running guest OS that cooperates with the ACPI unplug request. We must thus boot a real guest and wait for it to be ready before running the tests. Signed-off-by: Daniel P. Berrangé --- scripts/domain/200-disk-hotplug.t | 4 +++- scripts/domain/205-disk

[libvirt] [tck PATCH v2 08/13] scripts: skip luks test entirely for now

2018-05-21 Thread Daniel P . Berrangé
Libvirt support for luks-inside-qcow2 is not quite ready yet. Signed-off-by: Daniel P. Berrangé --- scripts/qemu/100-disk-encryption.t | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/qemu/100-disk-encryption.t b/scripts/qemu/100-disk-encryption.t index 3b1651a..32e2adf 100644 --- a

[libvirt] [PATCH 1/2] cpu: define the 'ssbd' CPUID feature bit (CVE-2018-3639)

2018-05-21 Thread Daniel P . Berrangé
New microcode introduces the "Speculative Store Bypass Disable" CPUID feature bit. This needs to be exposed to guest OS to allow them to protect against CVE-2018-3639. Signed-off-by: Daniel P. Berrangé --- src/cpu/cpu_map.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git

[libvirt] [PATCH 2/2] cpu: define the 'virt-ssbd' CPUID feature bit (CVE-2018-3639)

2018-05-21 Thread Daniel P . Berrangé
older versions of QEMU, this feature must be manually enabled using policy=force. Guests using the "host-passthrough" CPU mode do not need special handling. Signed-off-by: Daniel P. Berrangé --- src/cpu/cpu_map.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu/cpu_map.xml

[libvirt] [PATCH 0/2] cpu: speculative store buffer bypass mitigation (CVE-2018-3639)

2018-05-21 Thread Daniel P . Berrangé
=3b78ce4a34b761c7fe13520de822984019ff1a8f And QEMU patches posted at https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg04795.html [1] https://bugs.chromium.org/p/project-zero/issues/detail?id=1528 https://access.redhat.com/security/vulnerabilities/ssbd Daniel P. Berrangé (2): cpu: define the 'ssbd' CPU

Re: [libvirt] [libvirt-users] virRandomBits - not very random

2018-06-01 Thread Daniel P . Berrangé
On Wed, May 30, 2018 at 10:21:54PM +0200, Martin Kletzander wrote: > On Tue, May 29, 2018 at 10:06:25AM -0400, John Ferlan wrote: > > > > > > On 05/29/2018 09:44 AM, Michal Privoznik wrote: > > > On 05/29/2018 03:38 PM, Martin Kletzander wrote: > > > > On Fri, May 25, 2018 at 09:37:44AM -0500, Er

Re: [libvirt] [PATCH 08/10] virrandom: Make virRandomBits better

2018-06-01 Thread Daniel P . Berrangé
On Wed, May 30, 2018 at 03:43:31PM +0200, Martin Kletzander wrote: > On Wed, May 30, 2018 at 02:16:08PM +0200, Michal Privoznik wrote: > > On 05/29/2018 03:44 PM, Martin Kletzander wrote: > > > On Tue, May 29, 2018 at 10:24:44AM +0200, Michal Privoznik wrote: > > > > Now that we have strong PRNG ge

Re: [libvirt] [PATCH 2/1] nwfilter: Fix IP address learning

2018-06-01 Thread Daniel P . Berrangé
On Sat, May 26, 2018 at 08:27:47AM -0400, John Ferlan wrote: > In a previous commit: > >commit d4bf8f415074759baf051644559e04fe7f8b >Author: Daniel P. Berrangé >Date: Wed Feb 14 09:43:59 2018 + > > nwfilter: handle missing switch enum cases >

Re: [libvirt] [RFC PATCH 0/9] qemu: add vhost-vsock-pci support

2018-06-01 Thread Daniel P . Berrangé
On Tue, May 22, 2018 at 11:40:25AM +0200, Ján Tomko wrote: > On Mon, May 21, 2018 at 04:46:13PM +0100, Daniel P. Berrangé wrote: > > On Mon, May 21, 2018 at 05:37:10PM +0200, Ján Tomko wrote: > > > @Stefan, please take a look at the docs/ changes in patch 6 > > > &

Re: [libvirt] [PATCH v2] util: Loop through all resolved addresses in virNetSocketNewListenTCP

2018-06-01 Thread Daniel P . Berrangé
On Thu, May 24, 2018 at 02:00:06PM +0200, Olaf Hering wrote: > Currently virNetSocketNewListenTCP bails out early under the following > conditions: > - the hostname resolves to at least one IPv4 and at least one IPv6 > address > - the local interfaces have that one IPv4 address assigned, but not

Re: [libvirt] [jenkins-ci PATCH v3 0/3] Enable out-of-the-box parallel make

2018-06-01 Thread Daniel P . Berrangé
Set MAKEFLAGS for out-of-the-box parallel make > jobs: Drop explicit parallel make usage > > guests/templates/bashrc | 2 ++ > jobs/autotools.yaml | 10 +- > jobs/defaults.yaml | 1 - > projects/libvirt.yaml | 4 ++-- > projects/osinfo-db.yaml | 4 ++-- &g

Re: [libvirt] [GSoC] Design ideas for implementing cleanup attribute

2018-06-01 Thread Daniel P . Berrangé
On Mon, May 28, 2018 at 01:04:28PM +0530, Sukrit Bhatnagar wrote: > On 25 May 2018 at 16:20, Pavel Hrdina wrote: > > On Fri, May 25, 2018 at 12:06:50PM +0200, Andrea Bolognani wrote: > >> On Fri, 2018-05-25 at 10:04 +0200, Pavel Hrdina wrote: > >> > On Fri, May 25, 2018 at 09:13:51AM +0200, Andrea

Re: [libvirt] [PATCHv2 3/7] conf: introduce element

2018-06-01 Thread Daniel P . Berrangé
On Thu, May 24, 2018 at 12:39:11PM +0200, Ján Tomko wrote: > Add a new 'vsock' element for the vsock device. > The 'model' attribute is optional. > A subelement should be used to specify the guest cid, > or should be used. I always find the vs naming somewhat confusing because we are not cons

Re: [libvirt] [PATCH 0/2] travis: Minor macOS improvements

2018-06-01 Thread Daniel P . Berrangé
On Wed, May 30, 2018 at 03:13:32PM +0200, Andrea Bolognani wrote: > Andrea Bolognani (2): > travis: Move PATH to macOS-specific environment > travis: Install and use ccache on macOS > > .travis.yml | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) Rev

Re: [libvirt] [libvirt-users] virRandomBits - not very random

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 02:01:03PM +0200, Martin Kletzander wrote: > On Fri, Jun 01, 2018 at 11:17:44AM +0100, Daniel P. Berrangé wrote: > > On Wed, May 30, 2018 at 10:21:54PM +0200, Martin Kletzander wrote: > > > On Tue, May 29, 2018 at 10:06:25AM -0400,

Re: [libvirt] [PATCH 08/10] virrandom: Make virRandomBits better

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 02:10:56PM +0200, Martin Kletzander wrote: > On Fri, Jun 01, 2018 at 11:25:35AM +0100, Daniel P. Berrangé wrote: > > On Wed, May 30, 2018 at 03:43:31PM +0200, Martin Kletzander wrote: > > > On Wed, May 30, 2018 at 02:16:08PM +0200, Michal Privoznik wrote

Re: [libvirt] [PATCH 1/2] conf: rename to

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 01:36:04PM +0200, Ján Tomko wrote: > To avoid the vs. confusion, > change to: > > > Signed-off-by: Ján Tomko > Suggested-by: Daniel P. Berrangé > --- > docs/formatdomain.html.in | 6 +++--- > docs/schemas/domaincomm

Re: [libvirt] [PATCH] qemu.conf: Change the example user from 'root' to 'qemu'

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 02:08:38PM +0200, Kashyap Chamarthy wrote: > Signed-off-by: Kashyap Chamarthy > --- > src/qemu/qemu.conf | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf > index 31738ff19c..444247cf31 100644 > --- a/src

Re: [libvirt] [PATCH] qemu.conf: Change the example user from 'root' to 'qemu'

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 02:46:40PM +0200, Peter Krempa wrote: > On Fri, Jun 01, 2018 at 13:32:20 +0100, Daniel Berrange wrote: > > On Fri, Jun 01, 2018 at 02:08:38PM +0200, Kashyap Chamarthy wrote: > > > Signed-off-by: Kashyap Chamarthy > > > --- > > > src/qemu/qemu.conf | 5 +++-- > > > 1 file c

Re: [libvirt] [PATCH] qemu.conf: Change the example user from 'root' to 'qemu'

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 05:49:24PM +0200, Ján Tomko wrote: > On Fri, Jun 01, 2018 at 05:05:30PM +0200, Kashyap Chamarthy wrote: > > On Fri, Jun 01, 2018 at 02:11:12PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Jun 01, 2018 at 02:46:40PM +0200, Peter Krempa wrote: > >

Re: [libvirt] [PATCH 1/2] qemu: Report error on unexpected job stats type

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 06:04:29PM +0200, Jiri Denemark wrote: > On Fri, Jun 01, 2018 at 17:55:12 +0200, Jiri Denemark wrote: > > On Fri, Jun 01, 2018 at 17:31:02 +0200, Peter Krempa wrote: > > > On Fri, Jun 01, 2018 at 10:46:02 +0200, Jiri Denemark wrote: > > > > If we ever fail to properly set jo

Re: [libvirt] [PATCH libvirt v2 1/9] virConnectRegisterCloseCallback: Cleanup 'opaque' if there is no connectRegisterCloseCallback

2018-06-04 Thread Daniel P . Berrangé
On Thu, Apr 26, 2018 at 08:16:54PM -0400, John Ferlan wrote: > > > On 04/26/2018 12:09 PM, Marc Hartmayer wrote: > > On Thu, Apr 26, 2018 at 05:06 PM +0200, John Ferlan > > wrote: > >> On 04/12/2018 08:40 AM, Marc Hartmayer wrote: > >>> The commit 'close callback: move it to driver' (88f09b75eb

Re: [libvirt] [tck PATCH v2 02/13] scripts: strip quotes from URI before checking it

2018-06-04 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 04:04:09PM -0400, Laine Stump wrote: > On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote: > > The config file may have the URI listed with or without quotes, and the > > nwfilter tests didn't strip quotes before checking against the > > whitelisted

Re: [libvirt] [tck PATCH v2 07/13] scripts: switch to using luks encryption with QEMU

2018-06-04 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 09:52:50PM -0400, Laine Stump wrote: > On 06/01/2018 09:06 PM, Laine Stump wrote: > > On 05/21/2018 12:46 PM, Daniel P. Berrangé wrote: > >> The ability to use qcow legacy encryption is disabled with QEMU for a > >> long time. Switch to using luk

Re: [libvirt] [tck PATCH] Don't assume the domain's network interface tap device is named "vnet0"

2018-06-04 Thread Daniel P . Berrangé
3 ++- > scripts/nwfilter/210-no-mac-spoofing.t| 3 ++- > scripts/nwfilter/230-no-mac-broadcast.t | 3 ++- > scripts/nwfilter/240-no-arp-spoofing.t| 3 ++- > 7 files changed, 20 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé > > diff --git a/lib/Sys/Virt/TCK.

Re: [libvirt] [RFC] proposal for libiscsi storage pool

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 10:14:15AM +0200, Jiri Denemark wrote: > On Tue, Jun 05, 2018 at 09:37:06 +0200, Michal Privoznik wrote: > > On 06/04/2018 05:54 PM, Clementine Hayat wrote: > > > Hi everybody! > > > > > > I am starting this thread to discuss a new storage pool backend for > > > iSCSI using

Re: [libvirt] [PATCH 1/3] configure: Require GnuTLS

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 10:45:55AM +0200, Michal Privoznik wrote: > We are building with GnuTLS everywhere because GnuTLS is widely > available. In addition after recent patches Libvirt relies on > GnuTLS' PRNG. This second sentance isn't true AFAIK - we still have fallback to /dev/urandom - GNUTL

Re: [libvirt] [PATCH 2/3] build: Build gnutls related sources unconditionally

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 10:45:56AM +0200, Michal Privoznik wrote: > Now that GnuTLS is required these source files must be compiled > in. > > Signed-off-by: Michal Privoznik > --- > src/Makefile.am | 7 +-- > src/rpc/Makefile.inc.am | 14 ++ > tests/Makefile.am | 1

Re: [libvirt] [PATCH 3/3] src: Drop most of #ifdef WITH_GNUTLS

2018-06-05 Thread Daniel P . Berrangé
; tests/vircryptotest.c | 24 +--- > tests/virfilecachetest.c| 18 +++- > tests/virnetdaemontest.c| 8 -- > tests/virnetserverclienttest.c | 2 -- > tests/virrandommock.c | 8 ++---- > 20 files changed, 27

Re: [libvirt] [RFC PATCH] travis: require libgnutls28-dev

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 09:37:55AM +0200, Ján Tomko wrote: > Since commit we require GnuTLS >= 3.2.0. > Install the aptly-named libgnutls28-dev package > instead of plain libgnutls-dev. > > Signed-off-by: Ján Tomko > --- > RFC, since I haven't even started to figure out how to test it. I doesn'

Re: [libvirt] [jenkins-ci PATCH] guests: Fix os_version for development branches

2018-06-05 Thread Daniel P . Berrangé
g replacement. > > Signed-off-by: Andrea Bolognani > --- > guests/tasks/base.yml | 20 ++-- > 1 file changed, 14 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photo

Re: [libvirt] [jenkins-ci PATCH 1/5] guests: Add .j2 extension to existing templates

2018-06-05 Thread Daniel P . Berrangé
bash_profile.j2} | 0 > guests/templates/{bashrc => bashrc.j2} | 0 > 3 files changed, 1 insertion(+), 1 deletion(-) > rename guests/templates/{bash_profile => bash_profile.j2} (100%) > rename guests/templates/{bashrc => bashrc.j2} (100%) Reviewed-by: Daniel P

Re: [libvirt] [jenkins-ci PATCH 2/5] guests: Remove distinction between files and templates

2018-06-05 Thread Daniel P . Berrangé
.j2} (100%) > rename guests/{files/jessie-backports.preferences => > templates/jessie-backports.preferences.j2} (100%) > rename guests/{files/jessie-backports.sources => > templates/jessie-backports.sources.j2} (100%) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: http

Re: [libvirt] [jenkins-ci PATCH 4/5] guests: Make PYTHONPATH dynamic

2018-06-05 Thread Daniel P . Berrangé
16/main.yml | 2 -- > guests/host_vars/libvirt-ubuntu-18/main.yml | 2 -- > guests/templates/bashrc.j2| 10 +- > 16 files changed, 9 insertions(+), 30 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berr

Re: [libvirt] [jenkins-ci PATCH 3/5] guests: Make PERL5LIB dynamic

2018-06-05 Thread Daniel P . Berrangé
guests/host_vars/libvirt-ubuntu-18/main.yml | 1 - > guests/templates/bashrc.j2| 6 +- > 16 files changed, 5 insertions(+), 16 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com

<    1   2   3   4   5   6   7   8   9   10   >