Re: [libvirt] [jenkins-ci PATCH 5/5] guests: Move remaining paths out of the inventory

2018-06-05 Thread Daniel P . Berrangé
ars/all/main.yml | 11 --- > guests/templates/bashrc.j2 | 18 +- > 2 files changed, 9 insertions(+), 20 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org

Re: [libvirt] [jenkins-ci PATCH 3/5] guests: Make PERL5LIB dynamic

2018-06-05 Thread Daniel P . Berrangé
On Mon, May 21, 2018 at 06:53:25PM +0200, Andrea Bolognani wrote: > Instead of having to specify this separately for every > guest due to minor differences in the environment, figure > it out at login time by asking Perl itself for the > information we need. We still have the problem that any time

Re: [libvirt] [jenkins-ci PATCH 3/5] guests: Make PERL5LIB dynamic

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 01:10:45PM +0200, Andrea Bolognani wrote: > On Tue, 2018-06-05 at 11:42 +0100, Daniel P. Berrangé wrote: > > On Mon, May 21, 2018 at 06:53:25PM +0200, Andrea Bolognani wrote: > > > Instead of having to specify this separately for every > > > gue

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-05 Thread Daniel P . Berrangé
-off-by: Michal Privoznik > --- > configure.ac | 2 -- > m4/virt-gnutls.m4 | 4 > 2 files changed, 6 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org

Re: [libvirt] [PATCH v2 2/5] src: Always build virnettlscontext into libvirt-net-rpc.la

2018-06-05 Thread Daniel P . Berrangé
c/libvirt_remote.syms | 17 + > src/rpc/Makefile.inc.am | 14 ++ > 3 files changed, 19 insertions(+), 29 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: htt

Re: [libvirt] [PATCH v2 3/5] src: Dissolve libvirt_gnutls.syms in libvirt_remote.syms

2018-06-05 Thread Daniel P . Berrangé
virt_gnutls.syms | 31 --- > src/libvirt_remote.syms | 8 > 3 files changed, 8 insertions(+), 37 deletions(-) > delete mode 100644 src/libvirt_gnutls.syms Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberr

Re: [libvirt] [PATCH v2 4/5] tests: Always build TLS related tests

2018-06-05 Thread Daniel P . Berrangé
, 2 insertions(+), 10 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.in

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote: > (CCing libvir-list) > > On Tue, Jun 05, 2018 at 09:43:00AM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 05, 2018 at 09:27:46AM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > &g

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote: > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 05, 2018 at 10:06:46AM -0300, Eduardo Habkost wrote: > > > (CCing libvir-list) > > > > > > On Tue, Jun 05

Re: [libvirt] [PATCH 0/3] travis: Stop performing Ubuntu builds

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 03:57:03PM +0200, Andrea Bolognani wrote: > They're all failing at the moment anyway. > > We'll get the Ubuntu coverage back as soon as we add Ubuntu > builders to the CentOS CI environment. I've got fixes testing for travis to make it use both 16.04 and 18.04 for builds.

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 11:03:46AM -0300, Eduardo Habkost wrote: > On Tue, Jun 05, 2018 at 03:44:39PM +0200, Pavel Hrdina wrote: > > On Tue, Jun 05, 2018 at 10:35:38AM -0300, Eduardo Habkost wrote: > > > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: >

Re: [libvirt] [PATCH v3 2/4] qemu: support passing pre-opened UNIX socket listen FD

2018-06-05 Thread Daniel P . Berrangé
On Thu, May 24, 2018 at 04:50:36PM -0500, Eric Blake wrote: > On 05/17/2018 08:40 AM, Daniel P. Berrangé wrote: > > There is a race condition when spawning QEMU where libvirt has spawned > > QEMU but the monitor socket is not yet open. Libvirt has to repeatedly > > try t

Re: [libvirt] libvirt default machine-type guarantees? (was Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine)

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 07:16:56PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 05, 2018 at 02:12:32PM +0100, Daniel P. Berrangé wrote: > > eg old OS versions that only work with PC, or more commonly pre-existing > > cloud disk images that were built against PC can't be assu

[libvirt] [PATCH v2 1/2] nwfilter: fix IP address learning

2018-06-05 Thread Daniel P . Berrangé
In a previous commit: commit d4bf8f415074759baf051644559e04fe7f8b Author: Daniel P. Berrangé Date: Wed Feb 14 09:43:59 2018 + nwfilter: handle missing switch enum cases Ensure all enum cases are listed in switch statements, or cast away enum type in places where we

[libvirt] [PATCH v2 2/2] nwfilter: directly use poll to wait for packets instead of pcap_next

2018-06-05 Thread Daniel P . Berrangé
exiting which blocks the rest of libvirtd waiting on mutex acquisition. By switching to do poll() in libvirt code, we can ensure that we always exit the poll() at a time that is right for libvirt. Signed-off-by: Daniel P. Berrangé --- src/nwfilter/nwfilter_learnipaddr.c | 37

[libvirt] [PATCH v2 0/2] nwfilter: fix IP address learning

2018-06-05 Thread Daniel P . Berrangé
Changed in v2: - Use if() instead of switch() Daniel P. Berrangé (2): nwfilter: fix IP address learning nwfilter: directly use poll to wait for packets instead of pcap_next src/nwfilter/nwfilter_learnipaddr.c | 55 ++--- src/nwfilter/nwfilter_learnipaddr.h | 2

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-05 Thread Daniel P . Berrangé
On Tue, Jun 05, 2018 at 06:50:53PM +0200, Andrea Bolognani wrote: > On Tue, 2018-06-05 at 14:38 +0200, Michal Privoznik wrote: > > On 06/05/2018 02:04 PM, Daniel P. Berrangé wrote: > > > On Tue, Jun 05, 2018 at 01:55:54PM +0200, Michal Privoznik wrote: > > > &g

[libvirt] [PATCH] tests: use a fixed NBD TLS certificate path

2018-06-05 Thread Daniel P . Berrangé
The default NBD TLS certificate path varies based on prefix given to configure, causing tests to fail depending on build options. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix for CI tests/qemuxml2argvdata/disk-drive-network-tlsx509.args | 4 ++-- tests/qemuxml2argvtest.c

[libvirt] [perl PATCH 4/6] Remove obsolete %defattr statement

2018-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index 341e40c..35f8e01 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@ -66,7 +66,6 @@ virtualization containers to be

[libvirt] [perl PATCH 0/6] Update RPM spec to match latest Fedora

2018-06-05 Thread Daniel P . Berrangé
Syncing changes back from Fedora to follow best practice Daniel P. Berrangé (6): Remove obsolete RPM group tag Replace search.cpan.org with metacpan.org Remove commented out cruft leftover from Module::Build conversion Remove obsolete %defattr statement Use %license for LICENSE file

[libvirt] [perl PATCH 3/6] Remove commented out cruft leftover from Module::Build conversion

2018-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 4 1 file changed, 4 deletions(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index 928c7cf..341e40c 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@ -60,10 +60,6 @@ virtualization containers to

[libvirt] [perl PATCH 1/6] Remove obsolete RPM group tag

2018-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index e7b4044..b171826 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@ -31,7 +31,6 @@ Version:@VERSION@ Release

[libvirt] [perl PATCH 5/6] Use %license for LICENSE file instead of %doc

2018-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index 35f8e01..dd26412 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@ -66,7 +66,8 @@ virtualization

[libvirt] [perl PATCH 2/6] Replace search.cpan.org with metacpan.org

2018-06-05 Thread Daniel P . Berrangé
The former is being shutdown very soon in favour of the latter Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index b171826..928c7cf 100644 --- a/perl-Sys

[libvirt] [perl PATCH 6/6] Modernize list of build deps to match actual required packages

2018-06-05 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index dd26412..451af27 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL

[libvirt] [PATCH] travis: switch to using Ubuntu 16.04 and 18.04

2018-06-05 Thread Daniel P . Berrangé
-jenkins-ci repo, to remove the duplication. This work for future improvement though, this just does the minimal conversion to match what we already do, but with newer distro. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 212 1 file

Re: [libvirt] [PATCH] docs: document mandatory signoffs in governance.html

2018-06-06 Thread Daniel P . Berrangé
stating that they have the legal right to make the >contribution, if doing so on behalf of a broader organization / >company. Most of the project's code is distributed under the GNU Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-06 Thread Daniel P . Berrangé
On Wed, Jun 06, 2018 at 08:24:59AM +0200, Andrea Bolognani wrote: > On Tue, 2018-06-05 at 18:03 +0100, Daniel P. Berrangé wrote: > > We can't use docker on centos6 either and believe it or not the host > > doesn't have hardware virt either. > > > > I could

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-06 Thread Daniel P . Berrangé
On Wed, Jun 06, 2018 at 12:05:28PM +0200, Andrea Bolognani wrote: > On Wed, 2018-06-06 at 11:54 +0200, Peter Krempa wrote: > > Well, so we need to be able to run configure so that we can create > > makefiles which build the docs. > > > > If we extract the steps to build the docs from makefile into

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-06 Thread Daniel P . Berrangé
On Wed, Jun 06, 2018 at 11:54:41AM +0200, Peter Krempa wrote: > On Wed, Jun 06, 2018 at 11:44:37 +0200, Andrea Bolognani wrote: > > On Wed, 2018-06-06 at 09:45 +0100, Daniel P. Berrangé wrote: > > > On Wed, Jun 06, 2018 at 08:24:59AM +0200, Andrea Bolognani wrote: > > >

Re: [libvirt] [PATCH] travis: switch to using Ubuntu 16.04 and 18.04

2018-06-06 Thread Daniel P . Berrangé
On Wed, Jun 06, 2018 at 11:27:38AM +0200, Andrea Bolognani wrote: > On Tue, 2018-06-05 at 18:47 +0100, Daniel P. Berrangé wrote: > > The container images provided by Travis only support Ubuntu 14.04, > > however, Travis has ability to run docker, which allows the build > > sc

Re: [libvirt] [PATCH] travis: switch to using Ubuntu 16.04 and 18.04

2018-06-06 Thread Daniel P . Berrangé
On Wed, Jun 06, 2018 at 01:01:05PM +0200, Andrea Bolognani wrote: > On Wed, 2018-06-06 at 11:28 +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 06, 2018 at 11:27:38AM +0200, Andrea Bolognani wrote: > > > We will probably want to do that, since installing packages takes > &g

[libvirt] [go PATCH] Blacklist virGetLastError{Code,Domain}

2018-06-06 Thread Daniel P . Berrangé
These methods will not be exposed to apps, since we always return all errors. Signed-off-by: Daniel P. Berrangé --- api_test.go | 2 ++ 1 file changed, 2 insertions(+) Pushed as a trivial build fix diff --git a/api_test.go b/api_test.go index 27f77dd..53632df 100644 --- a/api_test.go +++ b

[libvirt] [python PATCH] Blacklist virGetLastError{Code,Domain}

2018-06-06 Thread Daniel P . Berrangé
These methods will not be exposed to apps, since we auto raise all errors. Signed-off-by: Daniel P. Berrangé --- sanitytest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Pushed as a trivial build fix diff --git a/sanitytest.py b/sanitytest.py index 190d32b..d5c23dc 100644 --- a

[libvirt] [perl PATCH] Blacklist virGetLastError{Code,Domain}

2018-06-06 Thread Daniel P . Berrangé
These methods will not be exposed to apps, since we auto raise all errors. Signed-off-by: Daniel P. Berrangé --- t/030-api-coverage.t | 2 ++ 1 file changed, 2 insertions(+) Pushed as a trivial build fix diff --git a/t/030-api-coverage.t b/t/030-api-coverage.t index 39d6146..15d4a77 100644

[libvirt] [PATCH v2] travis: switch to using Ubuntu 16.04 and 18.04

2018-06-06 Thread Daniel P . Berrangé
-jenkins-ci repo, to remove the duplication. This work for future improvement though, this just does the minimal conversion to match what we already do, but with newer distro. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 217 +--- 1 file

[libvirt] [PATCH] Don't use enums in TPM struct fields

2018-06-06 Thread Daniel P . Berrangé
igned enum expression < 0 is always false [-Werror,-Wtautological-compare] if ((def->version = virDomainTPMVersionTypeFromString(version)) < 0) { ~~~~~~~~~~~ ^ ~ Signed-off-by: Daniel P. Berrangé --- src/conf/domain_conf.

Re: [libvirt] [PATCH] util: Implement and use virFileIsRegular() rather than d_type

2018-06-06 Thread Daniel P . Berrangé
virFileIsRegular() function. > > Signed-off-by: Stefan Berger > --- > src/libvirt_private.syms | 1 + > src/util/virfile.c | 17 + > src/util/virfile.h | 1 + > 3 files changed, 15 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Be

Re: [libvirt] [PATCH] Don't use enums in TPM struct fields

2018-06-07 Thread Daniel P . Berrangé
On Wed, Jun 06, 2018 at 08:32:39PM +0200, Ján Tomko wrote: > This deprives us of the -Wswitch-enum warning on all compilers > because some don't detect the bogus negative value comparison. > And the comment has even less power than the clang warning. So: > > 1. Is it actually worth the trouble to

Re: [libvirt] [PATCH] Don't use enums in TPM struct fields

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 10:25:11AM +0200, Peter Krempa wrote: > On Thu, Jun 07, 2018 at 09:15:06 +0100, Daniel Berrange wrote: > > On Wed, Jun 06, 2018 at 08:32:39PM +0200, Ján Tomko wrote: > > > This deprives us of the -Wswitch-enum warning on all compilers > > > because some don't detect the bogu

Re: [libvirt] [PATCH] Don't use enums in TPM struct fields

2018-06-07 Thread Daniel P . Berrangé
On Wed, Jun 06, 2018 at 08:32:39PM +0200, Ján Tomko wrote: > This deprives us of the -Wswitch-enum warning on all compilers > because some don't detect the bogus negative value comparison. > And the comment has even less power than the clang warning. So: > > 1. Is it actually worth the trouble to

[libvirt] [PATCH v3] travis: switch to using Ubuntu 16.04 and 18.04

2018-06-07 Thread Daniel P . Berrangé
-jenkins-ci repo, to remove the duplication. This work for future improvement though, this just does the minimal conversion to match what we already do, but with newer distro. Signed-off-by: Daniel P. Berrangé --- .travis.yml | 214 +--- 1 file

[libvirt] [perl PATCH] Only use perl-interpreter & perl-generators on Fedora / future RHEL

2018-06-07 Thread Daniel P . Berrangé
These dependancies were newly introduced when perl core packaging was changed in recentish Fedora, so aren't available on RHEL-7. Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt.spec.PL | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/perl-Sys-Virt.spec.PL b/per

Re: [libvirt] [PATCH 0/5] Introduce VIR_CONNECT_GET_ALL_DOMAINS_STATS_BEST_EFFORT

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 01:59:11PM +0200, Michal Privoznik wrote: > Problem is, if there is a long standing job on a domain fetching > statistics might hiccup which might be a problem for mgmt apps that > query stats every few seconds. > > Orthogonal to this, I think we should break our sync QEMU_

Re: [libvirt] [PATCH v3] travis: switch to using Ubuntu 16.04 and 18.04

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 02:37:34PM +0200, Andrea Bolognani wrote: > On Thu, 2018-06-07 at 10:55 +0100, Daniel P. Berrangé wrote: > > The container images provided by Travis only support Ubuntu 14.04, > > however, Travis has ability to run docker, which allows the build > > sc

Re: [libvirt] [PATCH 03/10] util: Introduce virFileFlock

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 03:54:24PM +0200, Martin Kletzander wrote: > We already have virFileLock(), but we are now using flock() in the code as > well (due to requirements for mutual exclusion between libvirt and other > programs using flock() as well), so let's have a function for that as well so

[libvirt] [PATCH] docs: remove git snapshot download links

2018-06-07 Thread Daniel P . Berrangé
better served by using official releases. Those needing latest code are better served by using git checkout. The tarball snapshots are not compelling enough to invest time in fixing the script that produces them. Signed-off-by: Daniel P. Berrangé --- NB when pushing this, I would delete the

[libvirt] [jenkins-ci PATCH] Add perl-generators package

2018-06-08 Thread Daniel P . Berrangé
Modern Fedora packaging requires the perl-generators package for RPM builds. Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 4 guests/vars/projects/libvirt-perl.yml | 1 + guests/vars/projects/libvirt-tck.yml | 1 + 3 files changed, 6 insertions(+) diff

Re: [libvirt] [jenkins-ci PATCH] Add perl-generators package

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:41:54AM +0200, Andrea Bolognani wrote: > On Fri, 2018-06-08 at 09:49 +0100, Daniel P. Berrangé wrote: > [...] > > + perl-generators: > > +default: > > +Fedora: perl-generators > > Sorting is off - this should be further down, af

Re: [libvirt] [jenkins-ci PATCH] Add perl-generators package

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:57:43AM +0200, Andrea Bolognani wrote: > On Fri, 2018-06-08 at 10:45 +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 08, 2018 at 11:41:54AM +0200, Andrea Bolognani wrote: > > > Regardless of the nits pointed out above, this commit will fix > &

[libvirt] ANNOUNCE: Libvirt Sandbox release "Gobi" v0.8.0

2018-06-08 Thread Daniel P . Berrangé
I'm happy to annonunce a new release of libvirt sandbox with many accumulated bug fixes and a few features, is now available from https://libvirt.org/sources/sandbox/libvirt-sandbox-0.8.0.tar.gz The GPG signature: https://libvirt.org/sources/sandbox/libvirt-sandbox-0.8.0.tar.gz.asc Is creat

[libvirt] [tck PATCH 00/12] Misc fixes to the TCK

2018-06-08 Thread Daniel P . Berrangé
Some final misc fixes before doing a new release Daniel P. Berrangé (12): rpm: use standard perl variables rpm: fix license tag to include option of Artistic license rpm: add some missing dependencies rpm: remove obsolete clean section rpm: remove obsolete build root setting rpm

[libvirt] [tck PATCH 05/12] rpm: remove obsolete build root setting

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index b4cb4a9..2d5c38b 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -34,7 +34,6 @@ License: GPLv2

[libvirt] [tck PATCH 11/12] build: ignore more auto generated files

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index ca3e424..65b446f 100644 --- a/.gitignore +++ b/.gitignore @@ -3,7 +3,10 @@ *.orig *~ Build +META.json META.yml +MYMETA.json +MYMETA.yml Makefile Makefile.PL

[libvirt] [tck PATCH 07/12] rpm: cleanup docs file list

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index d3544b6..49f4a3c 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -105,10

[libvirt] [tck PATCH 02/12] rpm: fix license tag to include option of Artistic license

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 4b1683f..39cc72f 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -30,7 +30,7

[libvirt] [tck PATCH 04/12] rpm: remove obsolete clean section

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 4 1 file changed, 4 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index c92fa34..b4cb4a9 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -105,10 +105,6 @@ find

[libvirt] [tck PATCH 06/12] rpm: remove obsolete group setting

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 2d5c38b..d3544b6 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -31,7 +31,6 @@ Name: perl

[libvirt] [tck PATCH 03/12] rpm: add some missing dependencies

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 39cc72f..c92fa34 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL

[libvirt] [tck PATCH 09/12] build: misc updates the Module::Build config

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- Build.PL | 12 +++- MANIFEST | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Build.PL b/Build.PL index bf2d7a9..75a1436 100644 --- a/Build.PL +++ b/Build.PL @@ -61,6 +61,9 @@ EOF my $b = $class->new( module_name =>

[libvirt] [tck PATCH 08/12] rpm: delete redundant changelog

2018-06-08 Thread Daniel P . Berrangé
The changelog entries only make sense in the context of a distro, not upstream. Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 2 -- 1 file changed, 2 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 49f4a3c..42d2cef 100644 --- a/perl-Sys

[libvirt] [tck PATCH 01/12] rpm: use standard perl variables

2018-06-08 Thread Daniel P . Berrangé
We don't need to manually build variables for perl install locations as RPM includes that. Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.sp

[libvirt] [tck PATCH 10/12] conf: update URLs for Fedora 28 images

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- conf/default.cfg | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index d9d858c..494c303 100644 --- a/conf/default.cfg +++ b/conf/default.cfg @@ -49,7 +49,7 @@ images = ( hvm

[libvirt] [tck PATCH 12/12] Disable known hosts file

2018-06-08 Thread Daniel P . Berrangé
Despite having StrictHostKeyChecking=no, SSH still complains about the host key mismatch and disables password auth as a result. Using /dev/null as the known_hosts file ensures the keys are never saved to the user's profile. Signed-off-by: Daniel P. Berrangé --- scripts/nwfilter/210-n

Re: [libvirt] [tck PATCH 00/12] Misc fixes to the TCK

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 02:45:39PM +0100, Daniel P. Berrangé wrote: > Some final misc fixes before doing a new release Self-NACK. Some more things need fixing and the license change patch is actually wrong. > > Daniel P. Berrangé (12): > rpm: use standard perl variables > r

[libvirt] [tck PATCH v2 11/15] scripts: disable known hosts file

2018-06-08 Thread Daniel P . Berrangé
Despite having StrictHostKeyChecking=no, SSH still complains about the host key mismatch and disables password auth as a result. Using /dev/null as the known_hosts file ensures the keys are never saved to the user's profile. Signed-off-by: Daniel P. Berrangé --- scripts/nwfilter/210-n

[libvirt] [tck PATCH v2 03/15] rpm: remove obsolete clean section

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 4 1 file changed, 4 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 69e5621..be40d40 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -105,10 +105,6 @@ find

[libvirt] [tck PATCH v2 00/15] Misc fixes to the TCK

2018-06-08 Thread Daniel P . Berrangé
Some final misc fixes before doing a new release Daniel P. Berrangé (15): rpm: use standard perl variables rpm: add some missing dependencies rpm: remove obsolete clean section rpm: remove obsolete build root setting rpm: remove obsolete group setting rpm: cleanup docs file list rpm

[libvirt] [tck PATCH v2 15/15] lib: fix array value accessor to use preferred style

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- lib/Sys/Virt/TCK.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index 60bd136..78d3774 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -1275,7 +1275,7 @@ sub get_ip_from_leases

[libvirt] [tck PATCH v2 01/15] rpm: use standard perl variables

2018-06-08 Thread Daniel P . Berrangé
We don't need to manually build variables for perl install locations as RPM includes that. Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.sp

[libvirt] [tck PATCH v2 04/15] rpm: remove obsolete build root setting

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index be40d40..ab2194f 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -34,7 +34,6 @@ License: GPLv2

[libvirt] [tck PATCH v2 05/15] rpm: remove obsolete group setting

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index ab2194f..0dea8de 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -31,7 +31,6 @@ Name: perl

[libvirt] [tck PATCH v2 08/15] build: misc updates the Module::Build config

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- Build.PL | 12 +++- MANIFEST | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Build.PL b/Build.PL index bf2d7a9..75a1436 100644 --- a/Build.PL +++ b/Build.PL @@ -61,6 +61,9 @@ EOF my $b = $class->new( module_name =>

[libvirt] [tck PATCH v2 06/15] rpm: cleanup docs file list

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 0dea8de..a9b4148 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -105,10

[libvirt] [tck PATCH v2 13/15] lib: merge NetworkHelpers module into main TCK module

2018-06-08 Thread Daniel P . Berrangé
The TCK module requires stuff in the NetworkHelpers and also vica-verca. This circular dependancy causes import problems, when trying to use the functions in NetworkHelpers from the TCK module. Signed-off-by: Daniel P. Berrangé --- MANIFEST | 1 - lib/Sys/Virt

[libvirt] [tck PATCH v2 12/15] lib: use Test::More directly instead of Test::Builder

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- lib/Sys/Virt/TCK.pm | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index 29280f6..1a835bd 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -35,7 +35,7 @@ use

[libvirt] [tck PATCH v2 10/15] build: ignore more auto generated files

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index ca3e424..65b446f 100644 --- a/.gitignore +++ b/.gitignore @@ -3,7 +3,10 @@ *.orig *~ Build +META.json META.yml +MYMETA.json +MYMETA.yml Makefile Makefile.PL

[libvirt] [tck PATCH v2 14/15] license: only refer to the GPL not Artistic

2018-06-08 Thread Daniel P . Berrangé
The source file headers all say GPL and do not mention the Artistic license, likewise the Build.PL file and RPM Spec. Remove bogus references to the Artistic license from the LICENSE file. Signed-off-by: Daniel P. Berrangé --- LICENSE | 159

[libvirt] [tck PATCH v2 09/15] conf: update URLs for Fedora 28 images

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- conf/default.cfg | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index d9d858c..494c303 100644 --- a/conf/default.cfg +++ b/conf/default.cfg @@ -49,7 +49,7 @@ images = ( hvm

[libvirt] [tck PATCH v2 02/15] rpm: add some missing dependencies

2018-06-08 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 4b1683f..69e5621 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL

[libvirt] [tck PATCH v2 07/15] rpm: delete redundant changelog

2018-06-08 Thread Daniel P . Berrangé
The changelog entries only make sense in the context of a distro, not upstream. Signed-off-by: Daniel P. Berrangé --- perl-Sys-Virt-TCK.spec.PL | 2 -- 1 file changed, 2 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index a9b4148..0026b7e 100644 --- a/perl-Sys

Re: [libvirt] [tck PATCH] scripts: shorten netdev/domain name to prevent overflow

2018-06-08 Thread Daniel P . Berrangé
digits long before the test fails. Alternatively just delete the and let libvirt autoassign. > > Signed-off-by: Laine Stump > --- > scripts/nwfilter/nwfilter2vmtest.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel --

Re: [libvirt] [tck PATCH] network tests: change network address to avoid commonly-used subnet

2018-06-08 Thread Daniel P . Berrangé
Stump > --- > scripts/networks/networkxml2hostout/tck-testnet-3.dat | 4 ++-- > scripts/networks/networkxml2hostout/tck-testnet-3.post.dat | 4 ++-- > scripts/networks/networkxml2xmlin/tck-testnet-3.xml| 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-

Re: [libvirt] [tck PATCH 03/12] rpm: add some missing dependencies

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:07:13AM -0400, Laine Stump wrote: > On 06/08/2018 09:45 AM, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > perl-Sys-Virt-TCK.spec.PL | 15 --- > > 1 file changed, 12 insertions(+), 3 deletions(-) &g

Re: [libvirt] [tck PATCH v2 13/15] lib: merge NetworkHelpers module into main TCK module

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:38:07AM -0400, Laine Stump wrote: > On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > > The TCK module requires stuff in the NetworkHelpers and also vica-verca. > > This circular dependancy causes import problems, when trying to use the > > functi

Re: [libvirt] [tck PATCH v2 14/15] license: only refer to the GPL not Artistic

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:42:14AM -0400, Laine Stump wrote: > On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > > The source file headers all say GPL and do not mention the Artistic > > license, likewise the Build.PL file and RPM Spec. Remove bogus > > references to the

Re: [libvirt] [tck PATCH v2 11/15] scripts: disable known hosts file

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 11:29:35AM -0400, Laine Stump wrote: > On 06/08/2018 10:55 AM, Daniel P. Berrangé wrote: > > Despite having StrictHostKeyChecking=no, SSH still complains about the > > host key mismatch and disables password auth as a result. Using > > /dev/null as

Re: [libvirt] [tck PATCH] Fix typo/bug in get_network_ip

2018-06-08 Thread Daniel P . Berrangé
;); > +$ip = NetAddr::IP->new("$net_ip/$net_prefix"); > } else { > $ip = NetAddr::IP->new("$net_ip"); > } Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |:

[libvirt] ANNOUNCE: Libvirt TCK release v1.0.0

2018-06-11 Thread Daniel P . Berrangé
It has been 9 years since the first release of Libvirt TCK, so I'm happy to annonunce a second ever release, with countless accumulated bug fixes and features, is now available from https://libvirt.org/sources/tck/Sys-Virt-TCK-v1.0.0.tar.gz The GPG signature: https://libvirt.org/sources/tck/

[libvirt] [PATCH] conf: remove duplicated typedefs for virDomainSevDef

2018-06-12 Thread Daniel P . Berrangé
mainSevDef virDomainSevDef; ^ ../../src/conf/domain_conf.h:145:33: note: previous definition is here typedef struct _virDomainSevDef virDomainSevDef; ^ Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix src/conf/domain_conf.h | 3 -

[libvirt] [PATCH] qemu: add qemu_monitor_priv.h to sources list

2018-06-12 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix src/qemu/Makefile.inc.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am index 46797af4be..2afa67f195 100644 --- a/src/qemu/Makefile.inc.am +++ b/src/qemu/Makefile.inc.am

Re: [libvirt] [Qemu-devel] KVM Forum 2018: Call For Participation

2018-06-12 Thread Daniel P . Berrangé
A friendly reminder that the deadline for abstract submission is end of day this Thursday, June 14th. On Thu, May 17, 2018 at 12:52:35PM +0200, Paolo Bonzini wrote: > > KVM Forum 2018: Call For Participation > October 24-26, 2018 -

Re: [libvirt] [PATCH v9 00/11] x86: Secure Encrypted Virtualization (AMD)

2018-06-12 Thread Daniel P . Berrangé
On Mon, Jun 11, 2018 at 11:17:02AM -0500, Brijesh Singh wrote: > Hi Erik, > > > On 06/11/2018 09:10 AM, Erik Skultety wrote: > > On Fri, Jun 08, 2018 at 10:14:35AM -0500, Brijesh Singh wrote: > > > > > > Re: Jano's below comment > > > > > > (Also, some of the patches have double "<< >>" around

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-12 Thread Daniel P . Berrangé
On Tue, Jun 12, 2018 at 12:24:14PM +0200, Andrea Bolognani wrote: > On Wed, 2018-06-06 at 12:45 +0200, Andrea Bolognani wrote: > > Another thing to keep in mind is that moving the website build to > > a CentOS 7 container would allow us to remove the last remnants > > of CentOS 6 support from libvi

Re: [libvirt] [PATCH v2 1/5] configure: Require GnuTLS

2018-06-12 Thread Daniel P . Berrangé
On Tue, Jun 12, 2018 at 01:26:05PM +0200, Andrea Bolognani wrote: > On Tue, 2018-06-12 at 11:41 +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 12, 2018 at 12:24:14PM +0200, Andrea Bolognani wrote: > > > I've started building Docker containers with all libvirt build >

Re: [libvirt] [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-12 Thread Daniel P . Berrangé
On Tue, Jun 12, 2018 at 02:42:05PM +0200, Igor Mammedov wrote: > We can keep daemonizing flow in QEMU as it's now. > But Eduardo's idea about libvirt created socked + letting QEMU connect to it > has a merit. It should fix current deadlock issue with as monitor > won't be depending on lead exit eve

Re: [libvirt] [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig

2018-06-12 Thread Daniel P . Berrangé
On Tue, Jun 12, 2018 at 03:04:42PM +0200, Michal Privoznik wrote: > On 06/12/2018 02:42 PM, Igor Mammedov wrote: > > >>> > >>> Do we really need to make -daemonize and -preconfig work > >>> together? libvirt uses -daemonize only for its initial > >>> capability probing, which shouldn't require -p

Re: [libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt"

2018-06-12 Thread Daniel P . Berrangé
ing found the following commit which > introduced the race, but I'm not really sure how to fix it. Isn't this a > bug in automake? :-) The attractive big hammer solution is to stop using libtool entirely and create shared libraries directly with gcc -shared, thus getting rid of t

Re: [libvirt] [PATCH v2 05/21] conf: add support for parsing/formatting virNWFilterBindingDefPtr

2018-06-12 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 05:55:39PM -0400, John Ferlan wrote: > > > On 05/17/2018 01:37 PM, Daniel P. Berrangé wrote: > > On Thu, May 17, 2018 at 01:31:04PM -0400, Laine Stump wrote: > >> On 05/15/2018 01:43 PM, Daniel P. Berrangé wrote: > >>>

Re: [libvirt] [PATCH] libvirt: fix a typo

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 12:13:37PM +0200, Andrea Bolognani wrote: > On Wed, 2018-06-13 at 16:35 +0800, Chen Hanxiao wrote: > > From: Chen Hanxiao > > > > s/httsp/https > > You need a leading slash as well :) s/leading/trailing :-P Regards, Daniel -- |: https://berrange.com -o-https:/

<    1   2   3   4   5   6   7   8   9   10   >