[libvirt] [PATCH v4 2/6] nwfilter: keep track of active filter bindings

2018-06-26 Thread Daniel P . Berrangé
has a record of all active filters. Signed-off-by: Daniel P. Berrangé --- src/conf/virnwfilterobj.h | 4 ++ src/nwfilter/nwfilter_driver.c | 84 -- 2 files changed, 63 insertions(+), 25 deletions(-) diff --git a/src/conf/virnwfilterobj.h b/src/conf

[libvirt] [PATCH v4 3/6] nwfilter: remove virt driver callback layer for rebuilding filters

2018-06-26 Thread Daniel P . Berrangé
objects, as they're never touched. Reviewed-by: John Ferlan Signed-off-by: Daniel P. Berrangé --- src/conf/nwfilter_conf.c | 136 +++- src/conf/nwfilter_conf.h | 51 +--- src/conf/virnwfilterobj.c | 4 +- src/libvirt_private

Re: [libvirt] [PATCH 0/2] {lxc, util}: Fixing issues with NULL argument for

2018-06-27 Thread Daniel P . Berrangé
On Tue, Jun 26, 2018 at 11:27:55PM -0300, Julio Faracco wrote: > This serie fixes the argument 'type' of syscall mount(). Valgrind is > throwing a memory issue when that parameter is NULL. The best option > to fix this issue is replace NULL to "none" filesystem. There's no memory problem here. It

Re: [libvirt] [PATCH v1 00/11] Enable vfio-pci 'property' for mediated device

2018-06-27 Thread Daniel P . Berrangé
On Wed, Jun 27, 2018 at 03:34:37PM +0200, Erik Skultety wrote: > See the RFC here: > https://www.redhat.com/archives/libvir-list/2018-May/msg02218.html > > Since RFC: > - split graphics 'gl' to a standalone structure since it's now SPICE, SDL, > *and* VNC that will support it > > - egl-headless

Re: [libvirt] [dbus PATCH] mailmap: Add mailmap file

2018-06-27 Thread Daniel P . Berrangé
ff-by: Andrea Bolognani > --- > .mailmap | 9 + > 1 file changed, 9 insertions(+) > create mode 100644 .mailmap Reviewed-by: Daniel P. Berrangé > diff --git a/.mailmap b/.mailmap > new file mode 100644 > index 000..9a35b7c > --- /dev/null > +++ b/.mailmap > @@

Re: [libvirt] [PATCH] nwfilter: Remove redundant check if object exists

2018-06-28 Thread Daniel P . Berrangé
de frees > 'def' only if 'obj' is NULL. > > Signed-off-by: Pavel Hrdina > --- > src/nwfilter/nwfilter_driver.c | 7 --- > 1 file changed, 7 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://w

[libvirt] [PATCH python] Fix bugs in nwfilter binding APIs

2018-06-28 Thread Daniel P . Berrangé
We did not correctly mangle the API names in two cases, and we also forgot to specialize the lookup method name in the sanity test. Signed-off-by: Daniel P. Berrangé --- generator.py | 5 - sanitytest.py | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/generator.py b

[libvirt] [PATCH] qemu: don't use chardev FD passing with standalone args

2018-06-28 Thread Daniel P . Berrangé
When using domxml-to-native, we must generate CLI args that can be used in a standalone scenario. This means no FD passing can be used. To achieve this we must clear the QEMU_CAPS_CHARDEV_FD_PASS capability bit. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_process.c | 5 + src/qemu

Re: [libvirt] [PATCH] qemu: don't use chardev FD passing with standalone args

2018-06-28 Thread Daniel P . Berrangé
On Thu, Jun 28, 2018 at 07:42:33AM -0500, Eric Blake wrote: > On 06/28/2018 06:50 AM, Daniel P. Berrangé wrote: > > When using domxml-to-native, we must generate CLI args that can be used > > in a standalone scenario. This means no FD passing can be used. To > > achieve t

Re: [libvirt] [PATCH] qemu: Allow cachetune only for KVM domains

2018-06-28 Thread Daniel P . Berrangé
IR_DOMAIN_VIRT_KVM) { > +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > + _("cachetune is only supported for KVM domains")); > +goto cleanup; > +} > + > if (qemuDomainDefValidateFeatures(def, qemuCaps) < 0) &g

[libvirt] CPU model versioning separate from machine type versioning ?

2018-06-28 Thread Daniel P . Berrangé
This post is to raise question about helping use of named CPU models with KVM ie any case not using -cpu host. In the old days (ie before 2018), the world was innocent and we had a nice set of named CPU models that corresponded to different Intel/AMD physical CPU families/generations (lets tempora

Re: [libvirt] [Qemu-devel] CPU model versioning separate from machine type versioning ?

2018-06-29 Thread Daniel P . Berrangé
On Thu, Jun 28, 2018 at 07:59:38PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > This post is to raise question about helping use of named CPU models with > > KVM ie any case not using -cpu host. > > > > In the old days

Re: [libvirt] CPU model versioning separate from machine type versioning ?

2018-06-29 Thread Daniel P . Berrangé
On Thu, Jun 28, 2018 at 04:52:27PM -0300, Eduardo Habkost wrote: > On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote: > [...] > > What if we can borrow the concept of versioning from machine types and apply > > it to CPU models directly. For example, consider

Re: [libvirt] [Qemu-devel] CPU model versioning separate from machine type versioning ?

2018-06-29 Thread Daniel P . Berrangé
On Fri, Jun 29, 2018 at 09:53:53AM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote: > > [...] > > > What if we can borrow the concept of versioning from machin

Re: [libvirt] [Qemu-devel] CPU model versioning separate from machine type versioning ?

2018-06-29 Thread Daniel P . Berrangé
On Fri, Jun 29, 2018 at 02:12:51PM +0200, Jiri Denemark wrote: > On Fri, Jun 29, 2018 at 11:14:17 +0100, Daniel P. Berrangé wrote: > > On Thu, Jun 28, 2018 at 04:52:27PM -0300, Eduardo Habkost wrote: > > > On Thu, Jun 28, 2018 at 04:45:02PM +0100, Daniel P. Berrangé wrote: > &

[libvirt] [PATCH v2] qemu: format serial and geometry on frontend disk device

2018-07-02 Thread Daniel P . Berrangé
now, because we don't ahve support for that with -device for usb-storage just yet. Note that some disk buses (sd) still don't support -device. Although QEMU allowed these properties to be set on -drive for if=sd, they have been ignored so we now report an error in this case. Signed-off-by

Re: [libvirt] [PATCH v2] qemu: format serial and geometry on frontend disk device

2018-07-02 Thread Daniel P . Berrangé
just yet. > > > > Note that some disk buses (sd) still don't support -device. Although > > QEMU allowed these properties to be set on -drive for if=sd, they > > have been ignored so we now report an error in this case. > > > > Signed-off-by: Daniel P. Berr

[libvirt] [PATCH v3] qemu: format serial and geometry on frontend disk device

2018-07-02 Thread Daniel P . Berrangé
now, because we don't ahve support for that with -device for usb-storage just yet. Note that some disk buses (sd) still don't support -device. Although QEMU allowed these properties to be set on -drive for if=sd, they have been ignored so we now report an error in this case. Signed-off-by

Re: [libvirt] [PATCH v3] qemu: format serial and geometry on frontend disk device

2018-07-02 Thread Daniel P . Berrangé
just yet. > > > > Note that some disk buses (sd) still don't support -device. Although > > QEMU allowed these properties to be set on -drive for if=sd, they > > have been ignored so we now report an error in this case. > > > > Signed-off-by: Daniel P. Berran

Re: [libvirt] [PATCH v3] qemu: format serial and geometry on frontend disk device

2018-07-02 Thread Daniel P . Berrangé
that some disk buses (sd) still don't support -device. Although > > > > QEMU allowed these properties to be set on -drive for if=sd, they > > > > have been ignored so we now report an error in this case. > > > > > > > > Signed-off-by: Daniel P. Berr

Re: [libvirt] [PATCH 0/3] bhyve: implement MSRs ignore unknown writes feature

2019-02-07 Thread Daniel P . Berrangé
On Wed, Feb 06, 2019 at 04:00:06PM -0500, Cole Robinson wrote: > On 1/25/19 12:54 PM, Roman Bogorodskiy wrote: > > > > Roman Bogorodskiy (3): > > conf: introduce 'msrs' feature > > bhyve: implement MSRs ignore unknown writes feature > > news: document bhyve msrs feature > > > > docs/drvbhy

Re: [libvirt] [PATCH 0/3] bhyve: implement MSRs ignore unknown writes feature

2019-02-07 Thread Daniel P . Berrangé
On Thu, Feb 07, 2019 at 06:05:25PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrangé wrote: > > > On Wed, Feb 06, 2019 at 04:00:06PM -0500, Cole Robinson wrote: > > > On 1/25/19 12:54 PM, Roman Bogorodskiy wrote: > > > > > > > > Roman Bog

Re: [libvirt] [tck PATCH 1/4] storage: skip qcow1 tests when qcow1 isn't supported by qemu-img

2019-02-11 Thread Daniel P . Berrangé
/100-create-vol-dir.t | 22 - > scripts/storage/200-clone-vol-dir.t | 48 > 2 files changed, 41 insertions(+), 29 deletions(-) Reviewed-by: Daniel P. Berrangé This is an example where libvirt storage pool capabilities would be useful. R

Re: [libvirt] [tck PATCH 2/4] storage: fix/improve diagnostic messages

2019-02-11 Thread Daniel P . Berrangé
storage/100-create-vol-dir.t | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.

Re: [libvirt] [tck PATCH 3/4] networks: remove stray use of brctl command

2019-02-11 Thread Daniel P . Berrangé
twork-bridge.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: h

Re: [libvirt] [tck PATCH 4/4] nwfilter: allow for ebtables *not* removing leading 0 from mac addresses

2019-02-11 Thread Daniel P . Berrangé
/nwfilter/100-ping-still-working.t | 4 ++-- > scripts/nwfilter/210-no-mac-spoofing.t| 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-11 Thread Daniel P . Berrangé
lter/nwfilterxml2fwallout/vlan-test.fwall | 4 ++-- > 9 files changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrangé > > diff --git a/scripts/nwfilter/nwfilter2vmtest.sh > b/scripts/nwfilter/nwfilter2vmtest.sh > index 778013b..2e8c0b0 100644 > --- a/scrip

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: > On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé > wrote: > > > On Sat, Feb 09, 2019 at 02:03:05PM -0500, Laine Stump wrote: > > > Since this test (050-apply-verify-host.t), we can't use a regexp in &g

Re: [libvirt] [tck PATCH 1/4] storage: skip qcow1 tests when qcow1 isn't supported by qemu-img

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 06:10:38AM -0500, Laine Stump wrote: > On Mon, Feb 11, 2019, 5:47 AM Daniel P. Berrangé > wrote: > > > On Thu, Feb 07, 2019 at 10:08:28PM -0500, Laine Stump wrote: > > > RHEL8 has dropped support for qcow1 format images, so skip the tests > >

Re: [libvirt] [tck PATCH 1/4] storage: skip qcow1 tests when qcow1 isn't supported by qemu-img

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 07:14:26AM -0500, John Ferlan wrote: > > > On 2/11/19 6:12 AM, Daniel P. Berrangé wrote: > > On Mon, Feb 11, 2019 at 06:10:38AM -0500, Laine Stump wrote: > >> On Mon, Feb 11, 2019, 5:47 AM Daniel P. Berrangé > >> wrote: > >> >

Re: [libvirt] [PATCH v2 1/2] conf: add debugcon chardev guest interface

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 02:40:55PM +0100, Andrea Bolognani wrote: > On Mon, 2019-02-11 at 08:14 +, Nikolay Shirokovskiy wrote: > > On 08.02.2019 17:34, Andrea Bolognani wrote: > > > Even with that fixed, while your code prevents a element > > > associated to the isa-debugcon to be automaticall

[libvirt] [PATCH] virsh: fix return value in storage vol name completor

2019-02-11 Thread Daniel P . Berrangé
The function must return a pointer, not a boolean. Fortunately 'false' is equivalent to 'NULL' so this bug no had ill effect previously. Signed-off-by: Daniel P. Berrangé --- tools/virsh-completer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools

[libvirt] [tck PATCH] Set cache=none for KVM guests

2019-02-11 Thread Daniel P . Berrangé
QEMU will refuse to live migrate with the default caching mode, so we must explicitly set cache=none for the migration tests to pass. Signed-off-by: Daniel P. Berrangé --- lib/Sys/Virt/TCK/DomainBuilder.pm | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/Sys

Re: [libvirt] [python PATCH v4 1/2] generator.py: typo fix

2019-02-11 Thread Daniel P . Berrangé
gt; ll = len(listname) > l = len(classe) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org

Re: [libvirt] [python PATCH v4 2/2] Add virDomainCheckpoint APIs

2019-02-11 Thread Daniel P . Berrangé
ns(+), 7 deletions(-) > create mode 100644 libvirt-override-virDomainCheckpoint.py Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrang

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 09:51:09AM -0500, Laine Stump wrote: > On 2/11/19 6:11 AM, Daniel P. Berrangé wrote: > > On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: > > > On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé > > > wrote: > > > > > &g

Re: [libvirt] [libvirt-go PATCH 1/2] Add VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY constant

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 04:11:54PM +0100, Erik Skultety wrote: > Signed-off-by: Erik Skultety > --- > domain.go | 4 > domain_compat.h | 5 + > 2 files changed, 9 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [libvirt] [libvirt-go PATCH 2/2] Introduce DomainMigrateMaxSpeedFlags constant

2019-02-11 Thread Daniel P . Berrangé
at it is preferrable to change the enum type so we get better type checking over the long term, despite this small risk/ > > Signed-off-by: Erik Skultety > --- > domain.go | 10 -- > domain_compat.h | 4 > 2 files changed, 12 insertions(+), 2 deletio

Re: [libvirt] [python PATCH v4 0/2] Python bindings for virDomainCheckpoint

2019-02-11 Thread Daniel P . Berrangé
On Thu, Feb 07, 2019 at 04:39:52PM -0600, Eric Blake wrote: > Python counterpart to: > https://www.redhat.com/archives/libvir-list/2019-February/msg00252.html > > I'll push patch 1 now as a trivial fix; patch 2 can't go in until > the corresponding libvirt patches are accepted (which may in turn >

Re: [libvirt] Wiki account request

2019-02-12 Thread Daniel P . Berrangé
On Tue, Feb 12, 2019 at 04:30:01PM +0100, Pino Toscano wrote: > Hi, > > I'd like an account on the libvirt wiki, so I can add ideas to the GSoC > page. I'll take care of this and send you the details off list. Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/

Re: [libvirt] [jenkins-ci PATCH v2 5/9] lcitool: force non-interactive apt-get frontend

2019-02-13 Thread Daniel P . Berrangé
On Wed, Feb 06, 2019 at 05:21:36PM +0100, Andrea Bolognani wrote: > On Tue, 2019-02-05 at 17:53 +0000, Daniel P. Berrangé wrote: > [...] > > if package_format == "deb": > > sys.stdout.write(textwrap.dedent(""&qu

Re: [libvirt] [jenkins-ci PATCH v2 8/9] lcitool: support generating cross compiler dockerfiles

2019-02-13 Thread Daniel P . Berrangé
On Thu, Feb 07, 2019 at 04:21:34PM +0100, Andrea Bolognani wrote: > On Tue, 2019-02-05 at 17:53 +0000, Daniel P. Berrangé wrote: > [...] > > With the Debian 9 distro, this supports arm64, armel, armhf, mips, > > mipsel, mips64el, ppc64el, s390x, which are all the official arc

[libvirt] [jenkins-ci PATCH v3 03/10] guests: fix glusterfs package name on Debian

2019-02-13 Thread Daniel P . Berrangé
We want the development headers not the client binary Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index e10e3da..0945e36

[libvirt] [jenkins-ci PATCH v3 06/10] lcitool: force non-interactive apt-get frontend

2019-02-13 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- guests/lcitool | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool index bd32d1f..a7bcae3 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -541,7 +541,8 @@ class Application: if package_format

[libvirt] [jenkins-ci PATCH v3 04/10] guests: Debian SID has dropped the sheepdog package

2019-02-13 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 0945e36..f31b460 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -774,6 +774,7 @@ mappings

[libvirt] [jenkins-ci PATCH v3 02/10] guests: add xfsprogs development package for libvirt

2019-02-13 Thread Daniel P . Berrangé
Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 4 guests/vars/projects/libvirt.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index f211169..e10e3da 100644 --- a/guests

[libvirt] [jenkins-ci PATCH v3 01/10] guests: use libpcap0.8-dev package on Debian

2019-02-13 Thread Daniel P . Berrangé
The libpcap-dev package is a temporary backcompat package until everything switches to the new libpcap0.8-dev pacakge name. Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests

[libvirt] [jenkins-ci PATCH v3 00/10] Add support for cross compiling libvirt via Debian

2019-02-13 Thread Daniel P . Berrangé
tiple package name mistakes - Modify lcitool to generate cross-arch docker files - Add --no-install-recommended flag to apt-get - Add DEBIAN_FRONTEND=noninteractive env to apt-get - Improve error reporting in lcitool - Add make rule for generating dockerfiles locally Daniel P. Berrang

[libvirt] [jenkins-ci PATCH v3 10/10] lcitool: support generating cross compiler dockerfiles

2019-02-13 Thread Daniel P . Berrangé
For various reasons (commented inline) a few blacklists are required on a per-arch basis. Signed-off-by: Daniel P. Berrangé --- .../libvirt-debian-9/cross-build.yml | 50 ++ .../libvirt-debian-sid/cross-build.yml| 52 +++ guests/lcitool

[libvirt] [jenkins-ci PATCH v3 05/10] lcitool: include root cause when reporting errors

2019-02-13 Thread Daniel P . Berrangé
The root cause exception contains the useful information about what really failed during loading of some resource, or running of a command. Signed-off-by: Daniel P. Berrangé --- guests/lcitool | 54 +- 1 file changed, 27 insertions(+), 27

[libvirt] [jenkins-ci PATCH v3 08/10] lcitool: refactor logic for building package list

2019-02-13 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- guests/lcitool | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 1271954..0978c40 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -529,15 +529,18 @@ class Application

[libvirt] [jenkins-ci PATCH v3 09/10] lcitool: avoid using an env var to store package list

2019-02-13 Thread Daniel P . Berrangé
Every statement in a dockerfile results in a new layer in the image. There is no need for an env var to store the package list when it can be included inline. This avoids the env variable being later exposed to the container at runtime. Signed-off-by: Daniel P. Berrangé --- guests/lcitool | 18

[libvirt] [jenkins-ci PATCH v3 07/10] lcitool: avoid installing recommended packages

2019-02-13 Thread Daniel P . Berrangé
We know exactly which packages we need and don't want apt picking extra "recommended" ones for us. Reviewed-by: Andrea Bolognani Signed-off-by: Daniel P. Berrangé --- guests/lcitool | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/lcitool b/guest

Re: [libvirt] [PATCH 2/3] domain: Define explicit flags for saved image xml

2019-02-14 Thread Daniel P . Berrangé
On Wed, Feb 13, 2019 at 05:22:50PM -0600, Eric Blake wrote: > Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use > of @flags as a subset of virDomainXMLFlags, documenting that 2 of the > 3 flags defined at the time would never be valid. Later, commit > 28f8dfdc (1.0.0) introduced

Re: [libvirt] [jenkins-ci PATCH v3 05/10] lcitool: include root cause when reporting errors

2019-02-14 Thread Daniel P . Berrangé
On Thu, Feb 14, 2019 at 10:46:21AM +0100, Andrea Bolognani wrote: > On Wed, 2019-02-13 at 19:03 +0000, Daniel P. Berrangé wrote: > [...] > > @@ -177,8 +177,8 @@ class Inventory: > > parser = configparser.SafeConfigParser() > > pars

[libvirt] [jenkins-ci PATCH 3/5] lcitool: allow restricting host list to those supporting docker

2019-02-14 Thread Daniel P . Berrangé
Add a '-d' arg to the 'hosts' command to restrict the output to only include hosts on which dockerfiles can be built Signed-off-by: Daniel P. Berrangé --- guests/lcitool | 10 ++ 1 file changed, 10 insertions(+) diff --git a/guests/lcitool b/guests/lcitool index 35a

[libvirt] [jenkins-ci PATCH 4/5] make: add a simple build target that generates all dockerfiles

2019-02-14 Thread Daniel P . Berrangé
This is useful for local testing of docker changes, and can also be called to rebuild the content needed for the libvirt-dockerfiles repository. Signed-off-by: Daniel P. Berrangé --- Makefile | 19 +++ 1 file changed, 19 insertions(+) diff --git a/Makefile b/Makefile index

[libvirt] [jenkins-ci PATCH 2/5] lcitool: use subparsers for commands

2019-02-14 Thread Daniel P . Berrangé
dockerfile -h usage: lcitool dockerfile [-h] hosts projects positional arguments: hosts list of hosts to act on (accepts globs) projectslist of projects to consider (accepts globs) optional arguments: -h, --help show this help message and exit Signed-off-by

[libvirt] [jenkins-ci PATCH 1/5] make: add a rule for running a 'syntax-check' with flake8

2019-02-14 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- Makefile | 4 1 file changed, 4 insertions(+) create mode 100644 Makefile diff --git a/Makefile b/Makefile new file mode 100644 index 000..1ba6b21 --- /dev/null +++ b/Makefile @@ -0,0 +1,4 @@ + + +syntax-check: + flake8 guests/lcitool

[libvirt] [jenkins-ci PATCH 0/5] do testing of the libvirt-jenkins-ci project

2019-02-14 Thread Daniel P . Berrangé
This sets things up so that we do testing of the libvirt-jenkins-ci via flake8, and also validate the docker file builder works. Daniel P. Berrangé (5): make: add a rule for running a 'syntax-check' with flake8 lcitool: use subparsers for commands lcitool: allow restricting ho

[libvirt] [jenkins-ci PATCH 5/5] Add project for CI testing libvirt-jenkins-ci

2019-02-14 Thread Daniel P . Berrangé
A build task will validate that the dockerfile generator is able to create output, and a syntax-check task will run flake8 Signed-off-by: Daniel P. Berrangé --- guests/playbooks/build/jobs/defaults.yml | 2 ++ .../build/projects/libvirt-jenkins-ci.yml | 15

Re: [libvirt] [jenkins-ci PATCH 1/2] guests: Add mapping for modprobe

2019-02-14 Thread Daniel P . Berrangé
On Thu, Feb 14, 2019 at 02:45:45PM +0100, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > guests/vars/mappings.yml | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://ww

Re: [libvirt] [jenkins-ci PATCH 2/2] guests: Install modprobe for libvirt

2019-02-14 Thread Daniel P . Berrangé
On Thu, Feb 14, 2019 at 02:45:46PM +0100, Andrea Bolognani wrote: > Signed-off-by: Andrea Bolognani > --- > guests/vars/projects/libvirt.yml | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://ww

Re: [libvirt] [PATCH] virkmodtest: Don't fail if modprobe doesn't exist

2019-02-14 Thread Daniel P . Berrangé
; tests/virkmodtest.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: htt

Re: [libvirt] [PATCH] network: explicitly allow icmp/icmpv6 in libvirt zonefile

2019-02-15 Thread Daniel P . Berrangé
nd that's what this patch does. > > This is a further refinement of the resolution to > https://bugzilla.redhat.com/1650320 > > Signed-off-by: Laine Stump > --- > src/network/libvirt.zone | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrangé Regards,

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-15 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 02:56:31PM +, Daniel P. Berrangé wrote: > On Mon, Feb 11, 2019 at 09:51:09AM -0500, Laine Stump wrote: > > On 2/11/19 6:11 AM, Daniel P. Berrangé wrote: > > > On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: > > > > On Mon,

[libvirt] [PATCH v4 01/17] util: add helper APIs for dealing with inotify in portable manner

2019-02-15 Thread Daniel P . Berrangé
future. Signed-off-by: Daniel P. Berrangé --- MAINTAINERS | 7 + Makefile.objs | 2 +- include/qemu/filemonitor.h| 128 +++ tests/Makefile.include| 3 + tests/test-util-filemonitor.c | 685 ++ util

[libvirt] [PATCH v4 0/6] Add authorization support to all network services

2019-02-15 Thread Daniel P . Berrangé
-on: <20190215155709.15777-1-berra...@redhat.com> Daniel P. Berrangé (6): qemu-nbd: add support for authorization of TLS clients nbd: allow authorization with nbd-server-start QMP command migration: add support for a "tls-authz" migration parameter chardev: add support for authorization fo

[libvirt] [PATCH v4 00/17] Add authorization support to all network services

2019-02-15 Thread Daniel P . Berrangé
-on: <20190215155709.15777-1-berra...@redhat.com> Daniel P. Berrangé (17): util: add helper APIs for dealing with inotify in portable manner qom: don't require user creatable objects to be registered hw/usb: don't set IN_ISDIR for inotify watch in MTP driver hw/usb: fix const-ness for s

[libvirt] [PATCH v4 2/6] nbd: allow authorization with nbd-server-start QMP command

2019-02-15 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" As with the previous patch to qemu-nbd, the nbd-server-start QMP command also needs to be able to specify authorization when enabling TLS encryption. First the client must create a QAuthZ object instance using the 'object-add' command: { 'execute': 'object-add

[libvirt] [PATCH v4 3/6] migration: add support for a "tls-authz" migration parameter

2019-02-15 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The QEMU instance that runs as the server for the migration data transport (ie the target QEMU) needs to be able to configure access control so it can prevent unauthorized clients initiating an incoming migration. This adds a new 'tls-authz' migration parameter that is

[libvirt] [PATCH v4 4/6] chardev: add support for authorization for TLS clients

2019-02-15 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Currently any client which can complete the TLS handshake is able to use a chardev server. The server admin can turn on the 'verify-peer' option for the x509 creds to require the client to provide a x509 certificate. This means the client will have to acquire a certific

[libvirt] [PATCH v4 1/6] qemu-nbd: add support for authorization of TLS clients

2019-02-15 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Currently any client which can complete the TLS handshake is able to use the NBD server. The server admin can turn on the 'verify-peer' option for the x509 creds to require the client to provide a x509 certificate. This means the client will have to acquire a certificat

[libvirt] [PATCH v4 6/6] monitor: deprecate acl_show, acl_reset, acl_policy, acl_add, acl_remove

2019-02-15 Thread Daniel P . Berrangé
authz' or 'sasl-authz' parameters to the VNC server, and equivalent for other network services. Reviewed-by: Juan Quintela Signed-off-by: Daniel P. Berrangé --- monitor.c| 23 +++ qemu-deprecated.texi | 6 ++ 2 files changed, 29 insertion

[libvirt] [PATCH v4 5/6] vnc: allow specifying a custom authorization object name

2019-02-15 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" The VNC server has historically had support for ACLs to check both the SASL username and the TLS x509 distinguished name. The VNC server was responsible for creating the initial ACL, and the client app was then responsible for populating it with rules using the HMP 'acl

Re: [libvirt] [PATCH v4 00/17] Add authorization support to all network services

2019-02-15 Thread Daniel P . Berrangé
mis-fire. Ignore this one, I used the wrong base branch to git-publish and didn't interrupt it quickly enough Re-posted v4 with correct base. On Fri, Feb 15, 2019 at 05:13:28PM +0000, Daniel P. Berrangé wrote: > v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04482.htm

[libvirt] [PATCH] conf: make virPCIDeviceAddressFormat void

2019-02-15 Thread Daniel P . Berrangé
Only one of the three callers of virPCIDeviceAddressFormat correctly handles an error return status. Fortunately it can't fail so can be made void. Signed-off-by: Daniel P. Berrangé --- src/conf/device_conf.c | 3 +-- src/conf/device_conf.h | 6 +++--- src/conf/domain_c

Re: [libvirt] [PATCH v2 3/3] iohelper: Don't include newlines in error messages

2019-02-19 Thread Daniel P . Berrangé
> -fprintf(stderr, _("%s: failure with %s\n: %s"), > > +fprintf(stderr, _("%s: failure with %s: %s"), > > program_name, path, virGetLastErrorMessage()); > > exit(EXIT_FAILURE); Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://b

Re: [libvirt] [PATCH v3 4/4] util: Report error in virFileWrapperFdClose()

2019-02-19 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 05:52:31PM +0100, Andrea Bolognani wrote: > libvirt_iohelper is used internally by the virFileWrapperFd APIs; > more specifically, in the QEMU driver we have the doCoreDump() and > qemuDomainSaveMemory() helper functions as users, and those in turn > end up being called by t

Re: [libvirt] [PATCH v3 2/4] qemu: Always call virFileWrapperFdClose()

2019-02-19 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 05:52:29PM +0100, Andrea Bolognani wrote: > Right now we're reporting errors in virFileWrapperFdFree(), > but that's hardly the appropriate place to do so, as free > functions are supposed to do nothing more than release > allocated resources. > > We want to move that code

[libvirt] [glib PATCH 01/15] po: provide custom make rules for po file management

2019-02-20 Thread Daniel P . Berrangé
than any other rules libvirt-glib has, so stop using intltool and don't use gettextize ether. Signed-off-by: Daniel P. Berrangé --- .gitignore | 7 --- autogen.sh | 3 +- configure.ac | 8 ++- libvirt-gconfig/Makefile.am | 1 + li

[libvirt] [glib PATCH 07/15] po: minimize de el en_GB eo es et eu fa fi

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/de.mini.po | 20 + po/de.po | 153 po/el.mini.po | 20 + po/el.po | 153 po/{en_GB.po

[libvirt] [glib PATCH 12/15] po: minimize or pa pl pt_BR pt ro ru si sk sl

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/or.mini.po | 20 + po/or.po | 153 po/pa.mini.po | 20 + po/pa.po | 153 po/{pl.po => pl.mini

[libvirt] [glib PATCH 00/15] po: improve translation handling

2019-02-20 Thread Daniel P . Berrangé
n doing this change in libvirt, I discovered a serious bug in the Zanata client that has been screwing up translations in every project that uses Zanata by adding bogus "fuzzy" annotations. The particularly attractive statistic: 194 files changed, 2607 insertions(+), 14146 deletions(-

[libvirt] [glib PATCH 03/15] po: add rules for integration with zanata

2019-02-20 Thread Daniel P . Berrangé
Add rules to handle pushing libvirt-glib.pot to zanata, and refreshing .po files with new content from zanata. Signed-off-by: Daniel P. Berrangé --- po/Makefile.am | 8 1 file changed, 8 insertions(+) diff --git a/po/Makefile.am b/po/Makefile.am index 279fc47..d37014b 100644 --- a/po

[libvirt] [glib PATCH 14/15] po: minimize uk ur vi wba yo zh_CN zh_HK zh_TW zu

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/{uk.po => uk.mini.po} | 152 +++--- po/ur.mini.po| 20 + po/ur.po | 153 --- po/vi.mini.po| 20 + po/vi.po |

[libvirt] [glib PATCH 08/15] po: minimize fr gl gu he hi hr hu ia

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/{fr.po => fr.mini.po} | 156 +++ po/gl.mini.po| 20 + po/gl.po | 153 -- po/gu.mini.po| 20 + po/gu.po |

[libvirt] [glib PATCH 11/15] po: minimize mn mr ms nb nds ne nl nn nso

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/mn.mini.po | 20 +++ po/mn.po | 153 - po/mr.mini.po | 20 +++ po/mr.po | 153 - po/ms.mini.po | 20 +++ po/ms.po | 153

[libvirt] [glib PATCH 09/15] po: minimize id ilo is it ja ka kk km kn ko

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/id.mini.po| 20 + po/id.po | 153 --- po/ilo.mini.po | 20 + po/ilo.po| 153 --- po/is.mini.po| 20

[libvirt] [glib PATCH 02/15] po: remove language list from zanata configuration

2019-02-20 Thread Daniel P . Berrangé
The element in zanata.xml is no longer relevant as this info is recorded server side. Signed-off-by: Daniel P. Berrangé --- po/zanata.xml | 99 --- 1 file changed, 99 deletions(-) diff --git a/po/zanata.xml b/po/zanata.xml index 70cc22a..042c695

[libvirt] [glib PATCH 05/15] po: minimize af am anp ar as ast bal be bg bn_IN

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/af.mini.po| 20 ++ po/af.po | 153 -- po/am.mini.po| 20 ++ po/am.po | 153 -- po/anp.mini.po | 19 ++ po/anp.po| 152

[libvirt] [glib PATCH 13/15] po: minimize sq sr@latin sr sv ta te tg th tr tw

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/sq.mini.po | 20 ++ po/sq.po| 153 --- po/sr.mini.po | 21 ++ po/sr.po| 154 po/s...@latin.mini.po | 21 ++ po/s

[libvirt] [glib PATCH 06/15] po: minimize bn bo br brx bs ca cs cy da de_CH

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/bn.mini.po| 20 + po/bn.po | 153 - po/bo.mini.po| 20 + po/bo.po | 153 - po/br.mini.po| 20 + po

Re: [libvirt] [PATCH v3 2/4] qemu: Always call virFileWrapperFdClose()

2019-02-20 Thread Daniel P . Berrangé
On Wed, Feb 20, 2019 at 01:16:34PM +0100, Andrea Bolognani wrote: > On Tue, 2019-02-19 at 17:01 +0000, Daniel P. Berrangé wrote: > > On Tue, Feb 19, 2019 at 05:52:29PM +0100, Andrea Bolognani wrote: > [...] > > > @@ -3231,6 +3231,7 @@ qemuDomainSaveMemory(vi

Re: [libvirt] [PATCH v3 4/4] util: Report error in virFileWrapperFdClose()

2019-02-20 Thread Daniel P . Berrangé
On Wed, Feb 20, 2019 at 01:34:15PM +0100, Andrea Bolognani wrote: > On Tue, 2019-02-19 at 16:58 +0000, Daniel P. Berrangé wrote: > > On Tue, Feb 19, 2019 at 05:52:31PM +0100, Andrea Bolognani wrote: > [...] > > > @@ -337,8 +337,12 @@ virFileWrapperFdClose(vi

[libvirt] [glib PATCH v2 08/15] po: minimize fr gl gu he hi hr hu ia

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/{fr.po => fr.mini.po} | 156 +++ po/gl.mini.po| 20 + po/gl.po | 153 -- po/gu.mini.po| 20 + po/gu.po |

[libvirt] [glib PATCH v2 00/15] po: improve translation handling

2019-02-20 Thread Daniel P . Berrangé
anged in v2: - Fix a number of problems with VPATH builds Daniel P. Berrangé (15): po: provide custom make rules for po file management po: remove language list from zanata configuration po: add rules for integration with zanata po: minimize & canonicalize translations stored in git

[libvirt] [glib PATCH v2 06/15] po: minimize bn bo br brx bs ca cs cy da de_CH

2019-02-20 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- po/bn.mini.po| 20 + po/bn.po | 153 - po/bo.mini.po| 20 + po/bo.po | 153 - po/br.mini.po| 20 + po

[libvirt] [glib PATCH v2 03/15] po: add rules for integration with zanata

2019-02-20 Thread Daniel P . Berrangé
Add rules to handle pushing libvirt-glib.pot to zanata, and refreshing .po files with new content from zanata. Signed-off-by: Daniel P. Berrangé --- po/Makefile.am | 8 1 file changed, 8 insertions(+) diff --git a/po/Makefile.am b/po/Makefile.am index f2818c7..d66aec7 100644 --- a/po

[libvirt] [glib PATCH v2 01/15] po: provide custom make rules for po file management

2019-02-20 Thread Daniel P . Berrangé
than any other rules libvirt-glib has, so stop using intltool and don't use gettextize ether. Signed-off-by: Daniel P. Berrangé --- .gitignore | 8 --- autogen.sh | 3 +- configure.ac | 8 ++- libvirt-gconfig/Makefile.am | 1 + li

<    1   2   3   4   5   6   7   8   9   10   >